[GitHub] [incubator-pinot] jackjlli commented on pull request #6107: Making pushType non-mandatory

2020-10-05 Thread GitBox
jackjlli commented on pull request #6107: URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703938464 @icefury71 The 4th item I pasted above is the one we should be cautious about:

[GitHub] [incubator-pinot] jackjlli commented on pull request #6107: Making pushType non-mandatory

2020-10-05 Thread GitBox
jackjlli commented on pull request #6107: URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703921970 The config `segmentPushType` is needed at least in the following scenarios: 1. Retention manager needs it to purge segments: