[GitHub] [incubator-pinot] kishoreg commented on issue #3913: Adding the support for sampling logs

kishoreg commented on issue #3913: Adding the support for sampling logs URL: https://github.com/apache/incubator-pinot/pull/3913#issuecomment-470022616 thats right. tryAcquire is non-blocking (please verify) This is an

[GitHub] [incubator-pinot] kishoreg commented on issue #3913: Adding the support for sampling logs

kishoreg commented on issue #3913: Adding the support for sampling logs URL: https://github.com/apache/incubator-pinot/pull/3913#issuecomment-470017142 can we set a maxRate instead of setting samplingRate? we can use the RateLimiter from Gauva to implement this for now. This will make the