[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4475: Add sql +, -, *, / symbol arith

2019-08-09 Thread GitBox
fx19880617 commented on a change in pull request #4475: Add sql +, -, *, / symbol arith URL: https://github.com/apache/incubator-pinot/pull/4475#discussion_r312689854 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -49,6

[GitHub] [incubator-pinot] sunny19930321 removed a comment on issue #4507: Thirdeye documentation

2019-08-09 Thread GitBox
sunny19930321 removed a comment on issue #4507: Thirdeye documentation URL: https://github.com/apache/incubator-pinot/issues/4507#issuecomment-519795522 It is better To provide the following methods of calculation: baseline, Percentage Change, ChangeIn Contribution, Contribution To

[GitHub] [incubator-pinot] sunny19930321 commented on issue #4507: Thirdeye documentation

2019-08-09 Thread GitBox
sunny19930321 commented on issue #4507: Thirdeye documentation URL: https://github.com/apache/incubator-pinot/issues/4507#issuecomment-519795522 It is better To provide the following methods of calculation: baseline, Percentage Change, ChangeIn Contribution, Contribution To Overall

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4498: Re-enable the flakey test in table rebalancer cluster integration test

2019-08-09 Thread GitBox
siddharthteotia commented on issue #4498: Re-enable the flakey test in table rebalancer cluster integration test URL: https://github.com/apache/incubator-pinot/pull/4498#issuecomment-520007948 Although the external view stabilization check has been made stronger here in the code changes,

[incubator-pinot] branch master updated: Put Helix manager out of resource manager (#4506)

2019-08-09 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new fa615df Put Helix manager out of

[GitHub] [incubator-pinot] jackjlli merged pull request #4506: Put Helix manager out of resource manager

2019-08-09 Thread GitBox
jackjlli merged pull request #4506: Put Helix manager out of resource manager URL: https://github.com/apache/incubator-pinot/pull/4506 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4505: [TE] Update AnomalyFlattenResource

2019-08-09 Thread GitBox
xiaohui-sun merged pull request #4505: [TE] Update AnomalyFlattenResource URL: https://github.com/apache/incubator-pinot/pull/4505 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-pinot] branch master updated: [TE] Update AnomalyFlattenResource (#4505)

2019-08-09 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new a174d81 [TE] Update

[incubator-pinot] branch master updated: [TE] frontend - harleyjj/aiavailability - implements AI availability table UI (#4510)

2019-08-09 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 61b2a07 [TE] frontend -

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4510: [TE] frontend - harleyjj/aiavailability - implements AI availability …

2019-08-09 Thread GitBox
xiaohui-sun merged pull request #4510: [TE] frontend - harleyjj/aiavailability - implements AI availability … URL: https://github.com/apache/incubator-pinot/pull/4510 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4498: Re-enable the flakey test in table rebalancer cluster integration test

2019-08-09 Thread GitBox
codecov-io edited a comment on issue #4498: Re-enable the flakey test in table rebalancer cluster integration test URL: https://github.com/apache/incubator-pinot/pull/4498#issuecomment-518795951 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4498?src=pr=h1) Report >

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4503: Show detect rule for anomaly

2019-08-09 Thread GitBox
xiaohui-sun commented on a change in pull request #4503: Show detect rule for anomaly URL: https://github.com/apache/incubator-pinot/pull/4503#discussion_r312648501 ## File path: thirdeye/thirdeye-frontend/app/pods/components/rootcause-anomaly/component.js ## @@ -192,6

[GitHub] [incubator-pinot] codecov-io commented on issue #4512: Simplify ControllerRequestURLBuilder, remove invalid URLs

2019-08-09 Thread GitBox
codecov-io commented on issue #4512: Simplify ControllerRequestURLBuilder, remove invalid URLs URL: https://github.com/apache/incubator-pinot/pull/4512#issuecomment-520070760 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4512?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4512: Simplify ControllerRequestURLBuilder, remove invalid URLs

2019-08-09 Thread GitBox
Jackie-Jiang merged pull request #4512: Simplify ControllerRequestURLBuilder, remove invalid URLs URL: https://github.com/apache/incubator-pinot/pull/4512 This is an automated message from the Apache Git Service. To respond

[incubator-pinot] branch controller_request_builder deleted (was d52ca94)

2019-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch controller_request_builder in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was d52ca94 Simplify ControllerRequestURLBuilder, remove invalid URLs The revisions that

[incubator-pinot] branch master updated: Simplify ControllerRequestURLBuilder, remove invalid URLs (#4512)

2019-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new d340627 Simplify

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

2019-08-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r312675180 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4512: Simplify ControllerRequestURLBuilder, remove invalid URLs

2019-08-09 Thread GitBox
Jackie-Jiang opened a new pull request #4512: Simplify ControllerRequestURLBuilder, remove invalid URLs URL: https://github.com/apache/incubator-pinot/pull/4512 - Simplify the ControllerRequestURLBuilder - Remove the invalid URLs - Remove the out-of-date multitenancy documents

[incubator-pinot] branch controller_request_builder created (now d52ca94)

2019-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch controller_request_builder in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at d52ca94 Simplify ControllerRequestURLBuilder, remove invalid URLs This branch

[incubator-pinot] 01/01: Simplify ControllerRequestURLBuilder, remove invalid URLs

2019-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch controller_request_builder in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit d52ca949632bf7391bd8ed6d08a2abe8173b6257 Author: Jackie (Xiaotian) Jiang AuthorDate: Fri

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4513: Fixed the url for report

2019-08-09 Thread GitBox
xiaohui-sun opened a new pull request #4513: Fixed the url for report URL: https://github.com/apache/incubator-pinot/pull/4513 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4494: Fix potential NPE from HelixDataAccessor

2019-08-09 Thread GitBox
Jackie-Jiang commented on issue #4494: Fix potential NPE from HelixDataAccessor URL: https://github.com/apache/incubator-pinot/pull/4494#issuecomment-520109635 @jackjlli We should drop this pr right? This is an automated

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

2019-08-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r312675180 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

2019-08-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r312675180 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4513: Fixed the url for report

2019-08-09 Thread GitBox
xiaohui-sun merged pull request #4513: Fixed the url for report URL: https://github.com/apache/incubator-pinot/pull/4513 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-pinot] branch master updated: Fixed the url for report (#4513)

2019-08-09 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 38fbae9 Fixed the url for report

[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #4514: Reduce the number of calls to ZK to fetch the current ideal state in rebalancer

2019-08-09 Thread GitBox
siddharthteotia opened a new pull request #4514: Reduce the number of calls to ZK to fetch the current ideal state in rebalancer URL: https://github.com/apache/incubator-pinot/pull/4514 In TableRebalancer, after updating the ideal state (after moving segments), if we successfully

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

2019-08-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r312676733 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4515: [TE] fix for availability report

2019-08-09 Thread GitBox
xiaohui-sun merged pull request #4515: [TE] fix for availability report URL: https://github.com/apache/incubator-pinot/pull/4515 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #4498: The external view check in rebalancer should also check for no extra servers

2019-08-09 Thread GitBox
siddharthteotia edited a comment on issue #4498: The external view check in rebalancer should also check for no extra servers URL: https://github.com/apache/incubator-pinot/pull/4498#issuecomment-520096592 Filed https://issues.apache.org/jira/browse/HELIX-818 for a potential issue for why

[incubator-pinot] branch plug_in_instance_assignment created (now 3e8a3a8)

2019-08-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch plug_in_instance_assignment in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 3e8a3a8 [Instance Assignment] Plug in instance assignment No new revisions were

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4516: [Instance Assignment] Plug in instance assignment

2019-08-09 Thread GitBox
Jackie-Jiang opened a new pull request #4516: [Instance Assignment] Plug in instance assignment URL: https://github.com/apache/incubator-pinot/pull/4516 - Enhance Instance class to support multiple tags and pools, allowing adding pools from API - Add instance assignment APIs including:

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4498: Re-enable the flakey test in table rebalancer cluster integration test

2019-08-09 Thread GitBox
siddharthteotia commented on issue #4498: Re-enable the flakey test in table rebalancer cluster integration test URL: https://github.com/apache/incubator-pinot/pull/4498#issuecomment-520096592 Filed https://issues.apache.org/jira/browse/HELIX-818 for a potential issue for why state

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4494: Fix potential NPE from HelixDataAccessor

2019-08-09 Thread GitBox
siddharthteotia commented on a change in pull request #4494: Fix potential NPE from HelixDataAccessor URL: https://github.com/apache/incubator-pinot/pull/4494#discussion_r312670754 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4515: [TE] fix for availability report

2019-08-09 Thread GitBox
xiaohui-sun opened a new pull request #4515: [TE] fix for availability report URL: https://github.com/apache/incubator-pinot/pull/4515 Remove excessive '_'. This is an automated message from the Apache Git Service. To respond