[GitHub] [incubator-pinot] adriancole commented on pull request #6039: WIP: ServiceManager ADD_TABLE role

adriancole commented on pull request #6039: URL: https://github.com/apache/incubator-pinot/pull/6039#issuecomment-701167620 had a chat with @Mayank mainly to introduce the use case and things of priority here. for the curious this is for a "quick start" of hypertrace, which ideally can

[incubator-pinot] branch put-hadoop-libs-in-orc-module created (now 9bd660c)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch put-hadoop-libs-in-orc-module in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 9bd660c Put hadoop dependencies to pinot-orc, pinot-parquet modules This branch

[incubator-pinot] 01/01: Put hadoop dependencies to pinot-orc, pinot-parquet modules

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch put-hadoop-libs-in-orc-module in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 9bd660c80be39ef92611bbcb37d2b6e4b7d8f034 Author: Jack Li(Analytics Engineering)

[GitHub] [incubator-pinot] mayankshriv commented on pull request #6078: Refresh the routing when realtime segment is committed

mayankshriv commented on pull request #6078: URL: https://github.com/apache/incubator-pinot/pull/6078#issuecomment-701154675 @Jackie-Jiang Thanks for addressing this. This is an automated message from the Apache Git Service.

[incubator-pinot] branch master updated: Adding push job type of segment metadata only mode (#5967)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 4f2e767 Adding push job type of

[incubator-pinot] branch master updated (009ab53 -> e5cdb1e)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 009ab53 Add FilterOptimizer which supports optimizing both PQL and SQL query filter (#6056) add

[GitHub] [incubator-pinot] fx19880617 merged pull request #5967: Adding push job type of segment metadata only mode

fx19880617 merged pull request #5967: URL: https://github.com/apache/incubator-pinot/pull/5967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] fx19880617 merged pull request #6071: [Pinot Helm][v0.2.2] Allow configurable controller vip

fx19880617 merged pull request #6071: URL: https://github.com/apache/incubator-pinot/pull/6071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated: Add FilterOptimizer which supports optimizing both PQL and SQL query filter (#6056)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 009ab53 Add FilterOptimizer which

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6056: Add FilterOptimizer which supports optimizing query filter from both BrokerRequest and PinotQuery

Jackie-Jiang merged pull request #6056: URL: https://github.com/apache/incubator-pinot/pull/6056 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6073: Adding more table config validation

Jackie-Jiang commented on a change in pull request #6073: URL: https://github.com/apache/incubator-pinot/pull/6073#discussion_r497231638 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java ## @@ -76,10 +79,41 @@ public static void

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

Jackie-Jiang commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r497201010 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java ## @@ -0,0 +1,92 @@ +/**

[incubator-pinot] branch master updated: Add toString() to AggregationFunctionColumnPair (#6077)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 8d79e0a Add toString() to

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6077: Add toString() to AggregationFunctionColumnPair

Jackie-Jiang merged pull request #6077: URL: https://github.com/apache/incubator-pinot/pull/6077 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6029: Partitioning mis-match can lead to bad query results in Realtime

Jackie-Jiang commented on issue #6029: URL: https://github.com/apache/incubator-pinot/issues/6029#issuecomment-701106090 Removing the partition info for consuming segments could cause performance degradation for extremely high QPS use cases. Filed #6078 as a work-around without

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6040: Remove the partition info from the consuming segment ZK metadata

Jackie-Jiang commented on pull request #6040: URL: https://github.com/apache/incubator-pinot/pull/6040#issuecomment-701105519 After some benchmark we found this change might cause some performance degradation for extremely high QPS use cases. Closing this PR and filed #6078 as a

[GitHub] [incubator-pinot] Jackie-Jiang closed pull request #6040: Remove the partition info from the consuming segment ZK metadata

Jackie-Jiang closed pull request #6040: URL: https://github.com/apache/incubator-pinot/pull/6040 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6078: Refresh the routing when realtime segment is committed

Jackie-Jiang opened a new pull request #6078: URL: https://github.com/apache/incubator-pinot/pull/6078 ## Description Related to issue #6029 When a consuming realtime segment is committed, it will refresh the segment ZK metadata (the partition metadata can change when the stream

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6077: Add toString() to AggregationFunctionColumnPair

Jackie-Jiang opened a new pull request #6077: URL: https://github.com/apache/incubator-pinot/pull/6077 Solve the issue where AggregationFunctionColumnPair is not properly logged in StarTreeV2BuilderConfig This is an

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6050: Minion taskExecutor for RealtimeToOfflineSegments task

mcvsubbu commented on a change in pull request #6050: URL: https://github.com/apache/incubator-pinot/pull/6050#discussion_r497145807 ## File path: pinot-minion/src/main/java/org/apache/pinot/minion/executor/RealtimeToOfflineSegmentsTaskExecutor.java ## @@ -0,0 +1,275 @@ +/**

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6050: Minion taskExecutor for RealtimeToOfflineSegments task

snleee commented on a change in pull request #6050: URL: https://github.com/apache/incubator-pinot/pull/6050#discussion_r497125779 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java ## @@ -61,4 +61,17 @@ private MinionConstants() {

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6050: Minion taskExecutor for RealtimeToOfflineSegments task

npawar commented on a change in pull request #6050: URL: https://github.com/apache/incubator-pinot/pull/6050#discussion_r497118618 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java ## @@ -61,4 +61,17 @@ private MinionConstants() {

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6050: Minion taskExecutor for RealtimeToOfflineSegments task

npawar commented on a change in pull request #6050: URL: https://github.com/apache/incubator-pinot/pull/6050#discussion_r497117811 ## File path: pinot-minion/src/main/java/org/apache/pinot/minion/executor/RealtimeToOfflineSegmentsTaskExecutor.java ## @@ -0,0 +1,275 @@ +/** +

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6050: Minion taskExecutor for RealtimeToOfflineSegments task

npawar commented on a change in pull request #6050: URL: https://github.com/apache/incubator-pinot/pull/6050#discussion_r497115105 ## File path: pinot-minion/src/main/java/org/apache/pinot/minion/executor/RealtimeToOfflineSegmentsTaskExecutor.java ## @@ -0,0 +1,275 @@ +/** +

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #6076: [TE] upgrade dropwizard-swagger dependency

vincentchenjl opened a new pull request #6076: URL: https://github.com/apache/incubator-pinot/pull/6076 Upgrade dropwizard-swagger to 2.0.12-1 so that it pulls the latest version of io.dropwizard. This is an automated

[incubator-pinot] branch master updated (e892cb2 -> 40cb64d)

This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from e892cb2 Enhance DistinctCountThetaSketchAggregationFunction (#6004) add 40cb64d Add list of

[GitHub] [incubator-pinot] mcvsubbu merged pull request #6037: Add list of allowed tables for emitting table level metrics

mcvsubbu merged pull request #6037: URL: https://github.com/apache/incubator-pinot/pull/6037 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] icefury71 opened a new issue #6075: Enable off-heap memory for Bloom filter

icefury71 opened a new issue #6075: URL: https://github.com/apache/incubator-pinot/issues/6075 Currently Bloom filter uses JVM heap which is not ideal. We should enable support for using off-heap memory. This is an

[GitHub] [incubator-pinot] icefury71 opened a new issue #6074: Support Bloom filter on columns of type BYTES

icefury71 opened a new issue #6074: URL: https://github.com/apache/incubator-pinot/issues/6074 Currently Bloom filter cannot be specified on BYTES column types (results in segments getting into an error state). This is an

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6059: [WIP] Add CLI commands for interacting with PinotFS

mayankshriv commented on a change in pull request #6059: URL: https://github.com/apache/incubator-pinot/pull/6059#discussion_r497090804 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/LocalPinotFS.java ## @@ -111,7 +111,7 @@ public long length(URI

[GitHub] [incubator-pinot] icefury71 opened a new pull request #6073: Adding more table config validation

icefury71 opened a new pull request #6073: URL: https://github.com/apache/incubator-pinot/pull/6073 ## Description Related to issue #5942 * Adding more table config validation (retention, pushType and tenant) * Fixing bug where retention manager does not work for real-time tables

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5942: Better Table config validation

Jackie-Jiang commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-701024984 We can also add checks on partition config where the table can be partitioned on at most one column

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6066: Detect the behavior when column name mismatches in the query

mayankshriv commented on a change in pull request #6066: URL: https://github.com/apache/incubator-pinot/pull/6066#discussion_r497089012 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -769,94 +786,133 @@

[incubator-pinot] branch segment_metadata_push updated (41ce862 -> d7ca99f)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch segment_metadata_push in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 41ce862 Adding integration tests add d7ca99f Adding integration tests This update

[incubator-pinot] branch segment_metadata_push updated (dc89494 -> 41ce862)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch segment_metadata_push in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit dc89494 Adding integration tests omit 1a98a47 Address comments omit 662b7b5

[incubator-pinot] branch segment_metadata_push updated (2d32aaf -> dc89494)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch segment_metadata_push in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 2d32aaf Address comments add 1a98a47 Address comments add dc89494 Adding

[GitHub] [incubator-pinot] icefury71 commented on issue #5942: Better Table config validation

icefury71 commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-701001585 > yes, that works as long as the same validations are performed. thanks Yes, its calling the same validation function underneath.

[GitHub] [incubator-pinot] mcvsubbu commented on issue #5942: Better Table config validation

mcvsubbu commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-701001231 yes, that works as long as the same validations are performed. thanks This is an automated message from

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6046: Deep Extraction Support for ORC, Thrift, and ProtoBuf Records

jackjlli commented on a change in pull request #6046: URL: https://github.com/apache/incubator-pinot/pull/6046#discussion_r496310134 ## File path: pinot-plugins/pinot-input-format/pinot-orc/src/main/java/org/apache/pinot/plugin/inputformat/orc/ORCRecordReader.java ## @@

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

kishoreg commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r497053467 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java ## @@ -0,0 +1,81 @@ +/** + *

[GitHub] [incubator-pinot] jihaozh opened a new pull request #6072: [TE] show alert health on the alerts page

jihaozh opened a new pull request #6072: URL: https://github.com/apache/incubator-pinot/pull/6072 This PR brings consistent detection health to the alerts page. Previously, the health is fetched from the offline results, which cannot be generated if there are too many alerts because out

[incubator-pinot] branch health-alerts created (now b0319e9)

This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch health-alerts in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at b0319e9 [TE] show alert health on the alerts page This branch includes the following new commits:

[incubator-pinot] 01/01: [TE] show alert health on the alerts page

This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch health-alerts in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit b0319e95e2a4c093125e7476cb6ad1873bc23bb5 Author: Jihao Zhang AuthorDate: Tue Sep 29 13:24:08 2020 -0700

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6050: Minion taskExecutor for RealtimeToOfflineSegments task

snleee commented on a change in pull request #6050: URL: https://github.com/apache/incubator-pinot/pull/6050#discussion_r496245347 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java ## @@ -61,4 +61,17 @@ private MinionConstants() {

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6004: Enhance DistinctCountThetaSketchAggregationFunction

Jackie-Jiang merged pull request #6004: URL: https://github.com/apache/incubator-pinot/pull/6004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] yupeng9 commented on pull request #4889: Use jar-no-fork as the goal instead of jar for maven-source-plugin

yupeng9 commented on pull request #4889: URL: https://github.com/apache/incubator-pinot/pull/4889#issuecomment-700945618 bump this PR @fx19880617 @mcvsubbu This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6004: Enhance DistinctCountThetaSketchAggregationFunction

codecov-commenter commented on pull request #6004: URL: https://github.com/apache/incubator-pinot/pull/6004#issuecomment-700934315 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6004?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6053: Add support for Decimal with Precision Sum aggregation

codecov-commenter commented on pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#issuecomment-700933500 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6053?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jackjlli commented on pull request #6070: Add Hadoop related dependencies in pinot-tool module

jackjlli commented on pull request #6070: URL: https://github.com/apache/incubator-pinot/pull/6070#issuecomment-700932259 @kishoreg we do use `PluginManager` to instantiate the specific record reader. It's just that the required Hadoop jars are not pulled in because they are transitive

[incubator-pinot] branch segment_metadata_push updated (4d315f4 -> 2d32aaf)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch segment_metadata_push in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 4d315f4 Address comments add 2d32aaf Address comments This update added new

[incubator-pinot] branch segment_metadata_push updated (4d315f4 -> 2d32aaf)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch segment_metadata_push in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 4d315f4 Address comments add 2d32aaf Address comments This update added new

[GitHub] [incubator-pinot] jackjlli commented on pull request #6070: Add Hadoop related dependencies in pinot-tool module

jackjlli commented on pull request #6070: URL: https://github.com/apache/incubator-pinot/pull/6070#issuecomment-700930974 @mayankshriv the Hadoop jars are also needed for parquet as well. This is an automated message from

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

KKcorps commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r496982316 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -776,31 +781,30 @@ public IdSet

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

KKcorps commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r496976524 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java ## @@ -117,6 +117,18 @@

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

KKcorps commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r496982041 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AdditionWithPrecisionTransformFunction.java ## @@ -0,0

[incubator-pinot] branch segment_metadata_push updated (02ad0df -> 4d315f4)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch segment_metadata_push in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 02ad0df Address comments add 4d315f4 Address comments This update added new

[incubator-pinot] branch segment_metadata_push updated (02ad0df -> 4d315f4)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch segment_metadata_push in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 02ad0df Address comments add 4d315f4 Address comments This update added new

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5967: Adding push job type of segment metadata only mode

fx19880617 commented on a change in pull request #5967: URL: https://github.com/apache/incubator-pinot/pull/5967#discussion_r496974974 ## File path:

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5967: Adding push job type of segment metadata only mode

fx19880617 commented on a change in pull request #5967: URL: https://github.com/apache/incubator-pinot/pull/5967#discussion_r496974735 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5967: Adding push job type of segment metadata only mode

fx19880617 commented on a change in pull request #5967: URL: https://github.com/apache/incubator-pinot/pull/5967#discussion_r496973089 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5967: Adding push job type of segment metadata only mode

Jackie-Jiang commented on a change in pull request #5967: URL: https://github.com/apache/incubator-pinot/pull/5967#discussion_r496966149 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6004: Enhance DistinctCountThetaSketchAggregationFunction

Jackie-Jiang commented on pull request #6004: URL: https://github.com/apache/incubator-pinot/pull/6004#issuecomment-700913048 @mayankshriv Changed the ``DistinctCountRawThetaSketchAggregationFunction` to have the same usage as `DistinctCountThetaSketchAggregationFunction`

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

KKcorps commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r496962171 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java ## @@ -0,0 +1,81 @@ +/** + *

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

KKcorps commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r496961334 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java ## @@ -0,0 +1,81 @@ +/** + *

[GitHub] [incubator-pinot] kishoreg commented on pull request #6070: Add Hadoop related dependencies in pinot-tool module

kishoreg commented on pull request #6070: URL: https://github.com/apache/incubator-pinot/pull/6070#issuecomment-700901988 Why was this approved? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] kishoreg commented on pull request #6070: Add Hadoop related dependencies in pinot-tool module

kishoreg commented on pull request #6070: URL: https://github.com/apache/incubator-pinot/pull/6070#issuecomment-700902220 We should be using plugins for this rt This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] icefury71 edited a comment on issue #5942: Better Table config validation

icefury71 edited a comment on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-700900788 > +1 to a utility to validate, we can add a validate endpoint in the controller @kishoreg @mcvsubbu Seems like we already have a `/tables/validate`

[GitHub] [incubator-pinot] icefury71 commented on issue #5942: Better Table config validation

icefury71 commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-700900788 > +1 to a utility to validate, we can add a validate endpoint in the controller @kishoreg @mcvsubbu Seems like we already have a `/tables/validate` end-point in

[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #6062: [TE] Fixed tests on ThirdEye dashboard for MacOS

suvodeep-pyne commented on pull request #6062: URL: https://github.com/apache/incubator-pinot/pull/6062#issuecomment-700880341 Thanks @vincentchenjl ! This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6004: Enhance DistinctCountThetaSketchAggregationFunction

Jackie-Jiang commented on a change in pull request #6004: URL: https://github.com/apache/incubator-pinot/pull/6004#discussion_r496927468 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java ##

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6004: Enhance DistinctCountThetaSketchAggregationFunction

Jackie-Jiang commented on a change in pull request #6004: URL: https://github.com/apache/incubator-pinot/pull/6004#discussion_r496926008 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java ##

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6004: Enhance DistinctCountThetaSketchAggregationFunction

Jackie-Jiang commented on a change in pull request #6004: URL: https://github.com/apache/incubator-pinot/pull/6004#discussion_r496925731 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java ##

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6004: Enhance DistinctCountThetaSketchAggregationFunction

Jackie-Jiang commented on a change in pull request #6004: URL: https://github.com/apache/incubator-pinot/pull/6004#discussion_r496923525 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -776,6 +783,69 @@ public IdSet

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6004: Enhance DistinctCountThetaSketchAggregationFunction

Jackie-Jiang commented on a change in pull request #6004: URL: https://github.com/apache/incubator-pinot/pull/6004#discussion_r496922926 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -776,6 +783,69 @@ public IdSet

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6004: Enhance DistinctCountThetaSketchAggregationFunction

mayankshriv commented on a change in pull request #6004: URL: https://github.com/apache/incubator-pinot/pull/6004#discussion_r496864642 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -776,6 +783,69 @@ public IdSet

[GitHub] [incubator-pinot] jackjlli merged pull request #6070: Add Hadoop related dependencies in pinot-tool module

jackjlli merged pull request #6070: URL: https://github.com/apache/incubator-pinot/pull/6070 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated (f556c59 -> f196dfc)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from f556c59 [TE] Fixed tests on ThirdEye dashboard for MacOS (#6062) add f196dfc Add Hadoop related

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5967: Adding push job type of segment metadata only mode

fx19880617 commented on a change in pull request #5967: URL: https://github.com/apache/incubator-pinot/pull/5967#discussion_r496906820 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@

[incubator-pinot] branch segment_metadata_push updated (662b7b5 -> 02ad0df)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch segment_metadata_push in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 662b7b5 Adding clean up for temp files add 02ad0df Address comments No new

[incubator-pinot] branch master updated (26f6019 -> f556c59)

This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 26f6019 [TE] ThirdEye Coordinator skeleton stub (#6065) add f556c59 [TE] Fixed tests on ThirdEye

[GitHub] [incubator-pinot] apucher merged pull request #6062: [TE] Fixed tests on ThirdEye dashboard for MacOS

apucher merged pull request #6062: URL: https://github.com/apache/incubator-pinot/pull/6062 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated (2379791 -> 26f6019)

This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 2379791 Move scalar function from commons to plugins package (#6064) add 26f6019 [TE] ThirdEye

[GitHub] [incubator-pinot] apucher merged pull request #6065: [TE] ThirdEye Coordinator skeleton stub

apucher merged pull request #6065: URL: https://github.com/apache/incubator-pinot/pull/6065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

KKcorps commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r496870036 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java ## @@ -0,0 +1,81 @@ +/** + *

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

KKcorps commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r496868587 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/SumWithPrecisionAggregationFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

KKcorps commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r496867698 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/SumWithPrecisionAggregationFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

kishoreg commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r496850851 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java ## @@ -0,0 +1,81 @@ +/** + *

[GitHub] [incubator-pinot] mayankshriv commented on pull request #6004: Enhance DistinctCountThetaSketchAggregationFunction

mayankshriv commented on pull request #6004: URL: https://github.com/apache/incubator-pinot/pull/6004#issuecomment-700811748 > What's the motivation to add a new aggregation function as opposed to enhancing the existing one? Is there a backward compatibility issue? If not, it adds more

[GitHub] [incubator-pinot] icefury71 commented on issue #5942: Better Table config validation

icefury71 commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-700733890 What I meant is - technically it should be supported (it's not today and we should probably fix that). On Tue, Sep 29, 2020 at 12:31 AM Buchi Reddy Busi Reddy <

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

KKcorps commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r496624093 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java ## @@ -0,0 +1,76 @@ +/** + *

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r496623617 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -223,6 +228,16 @@

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6053: Add support for Decimal with Precision Sum aggregation

KKcorps commented on a change in pull request #6053: URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r496623778 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/AggregationFunctionType.java ## @@ -30,6 +30,7 @@ MIN("min"),

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r496623436 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/listener/ClusterInstanceConfigChangeListener.java ## @@ -0,0

[GitHub] [incubator-pinot] buchireddy commented on issue #5942: Better Table config validation

buchireddy commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-700507663 > > Another use case: Validate that the bloomFilterColumns aren't BYTES type since that's not supported at this point. > > cc @kishoreg @icefury71 > > Looks

[incubator-pinot] branch pinot-helm-adding-controller-vip updated (13b3165 -> 10eaa01)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch pinot-helm-adding-controller-vip in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 13b3165 Allow configurable controller vip add 10eaa01 Allow configurable

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #6071: [Pinot Helm] Allow configurable controller vip

fx19880617 opened a new pull request #6071: URL: https://github.com/apache/incubator-pinot/pull/6071 ## Description Allow user to enable/disable and specify controller vip address. This is an automated message from

[incubator-pinot] 01/01: Allow configurable controller vip

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch pinot-helm-adding-controller-vip in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 13b316585e56e55cfdeaefd35ee228d80aa21f09 Author: Xiang Fu AuthorDate: Mon Sep 28

[incubator-pinot] branch pinot-helm-adding-controller-vip created (now 13b3165)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch pinot-helm-adding-controller-vip in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 13b3165 Allow configurable controller vip This branch includes the following