[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437853396 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437654871 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437650377 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437650377 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r436241696 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,484 @@ +/**

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r436241645 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,484 @@ +/**

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r436241116 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LiteralTransformFunction.java ## @@ -75,22 +82,40 @@

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r436234419 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r436167325 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r435757717 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LessThanOrEqualTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r435756385 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,482 @@ +/**

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r435753015 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,482 @@ +/**

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r435752267 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,482 @@ +/**

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r435751703 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r435749077 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,482 @@ +/**

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r435747938 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r435746366 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-05 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r435745019 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -610,6 +611,40 @@ private static Expression

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-03 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r434899806 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-03 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r434898899 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-03 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r434890598 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-03 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r434889628 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-05-29 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r432769120 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -610,6 +611,25 @@ private static Expression

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-05-29 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r432313174 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-05-29 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r432305059 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java ## @@ -0,0