[GitHub] [incubator-pinot] guruguha commented on pull request #5718: Feature/#5390 segment indexing reload status api

2020-08-26 Thread GitBox
guruguha commented on pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#issuecomment-681329302 @mcvsubbu can you please review again? This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-pinot] guruguha commented on pull request #5718: Feature/#5390 segment indexing reload status api

2020-08-12 Thread GitBox
guruguha commented on pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#issuecomment-673286243 > > A lot of code duplication with the existing table size reader. Please find ways to use a common base class if possible > > Is this addressed? Oh! Someh

[GitHub] [incubator-pinot] guruguha commented on pull request #5718: Feature/#5390 segment indexing reload status api

2020-08-09 Thread GitBox
guruguha commented on pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#issuecomment-671066095 There were a few concerns raised by Subbu on the number of API calls that would be made to a server in the case where there are a large number of segments. W

[GitHub] [incubator-pinot] guruguha commented on pull request #5718: Feature/#5390 segment indexing reload status api

2020-07-31 Thread GitBox
guruguha commented on pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#issuecomment-667438068 Initially, the thought was to have status for a single segment reload. But then it was observed that usually, users request for a full segment reload. So, I added t