guruguha commented on pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#issuecomment-667438068
Initially, the thought was to have status for a single segment reload. But then it was observed that usually, users request for a full segment reload. So, I added the API to show reload status for all segments. I do have a design doc <https://docs.google.com/document/d/1E_J7PxF9WtaE6ido__u0O-Emtyu0IghQicC-1eLZeRo/edit#>. Sure, let's discuss there. :) -Guru On Fri, Jul 31, 2020 at 5:25 PM Subbu Subramaniam <notificati...@github.com> wrote: > *@mcvsubbu* commented on this pull request. > ------------------------------ > > In > pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java > <https://github.com/apache/incubator-pinot/pull/5718#discussion_r463895616> > : > > > @@ -485,4 +503,80 @@ private void deleteSegmentsInternal(String tableNameWithType, List<String> segme > throw new ControllerApplicationException(LOGGER, e.getMessage(), Response.Status.FORBIDDEN); > } > } > + > + @GET > + @Path("segments/{tableName}/reload-status") > + @Produces(MediaType.APPLICATION_JSON) > + @ApiOperation(value = "Status of segment reload", notes = "Status of segment reload") > > If you are adding one to get the status of one segment at a time, then the > user can (if needed) iterate over the segments and get each segment. Let us > evaluate the use case first. Are we talking about a full table reload or a > segment reload? If full table reload, maybe we only want to return those > segments that DID NOT reload properly? > > The API definition leaves much discussion to be desired, and a PR is NOT > the place to discuss API. If you have a design doc, we will discuss there. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-pinot/pull/5718#discussion_r463895616>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACFCTWTQNNHNVC63IBMT3DDR6NOHNANCNFSM4PBWT4GA> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
