[GitHub] [pulsar-client-go] reugn opened a new pull request #673: Handle the parameters parsing error in NewProvider

2021-11-28 Thread GitBox
reugn opened a new pull request #673: URL: https://github.com/apache/pulsar-client-go/pull/673 ### Modifications Added parsing error check in NewProvider; minor cleanups. ### Verifying this change - [ ] Make sure that the change passes the CI checks. -- This is

[GitHub] [pulsar] mattisonchao commented on issue #13016: Consumer: Failed to load config into existing configuration data

2021-11-28 Thread GitBox
mattisonchao commented on issue #13016: URL: https://github.com/apache/pulsar/issues/13016#issuecomment-981353324 i will check it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[pulsar] branch master updated: [Workflow] add guidelines for merging a PR (#12988)

2021-11-28 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new bce8a2e [Workflow] add guidelines for merging a

[GitHub] [pulsar] Anonymitaet merged pull request #12988: [Workflow] add guidelines for merging a PR

2021-11-28 Thread GitBox
Anonymitaet merged pull request #12988: URL: https://github.com/apache/pulsar/pull/12988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] xuesongxs opened a new issue #13016: Consumer: Failed to load config into existing configuration data

2021-11-28 Thread GitBox
xuesongxs opened a new issue #13016: URL: https://github.com/apache/pulsar/issues/13016 **Describe the bug** Pulsar v2.8.1 Build consumer by loadConf(), An exception occurred when starting the consumer. consumer code: ``` Map config = new HashMap<>();

[GitHub] [pulsar] 315157973 opened a new pull request #13015: Fix unit test using deprecated API

2021-11-28 Thread GitBox
315157973 opened a new pull request #13015: URL: https://github.com/apache/pulsar/pull/13015 ### Motivation The current unit test uses the deprecated API ### Modifications Change to use new API ### Verifying this change ### Documentation - [ x ]

[GitHub] [pulsar] urfreespace opened a new pull request #13014: [website][upgrade]feat: website upgrade / docs migration - 2.5.2 / reference

2021-11-28 Thread GitBox
urfreespace opened a new pull request #13014: URL: https://github.com/apache/pulsar/pull/13014 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] urfreespace opened a new pull request #13013: [website][upgrade]feat: website upgrade / docs migration - 2.5.2 / adaptors/cookbook/develop

2021-11-28 Thread GitBox
urfreespace opened a new pull request #13013: URL: https://github.com/apache/pulsar/pull/13013 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] urfreespace opened a new pull request #13012: [website][upgrade]feat: website upgrade / docs migration - 2.5.2 / admin/security/client

2021-11-28 Thread GitBox
urfreespace opened a new pull request #13012: URL: https://github.com/apache/pulsar/pull/13012 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] urfreespace opened a new pull request #13011: [website][upgrade]feat: website upgrade / docs migration - 2.5.2 / administration/helm/deploy

2021-11-28 Thread GitBox
urfreespace opened a new pull request #13011: URL: https://github.com/apache/pulsar/pull/13011 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] urfreespace opened a new pull request #13010: [website][upgrade]feat: website upgrade / docs migration - 2.5.2 / functions/sql/io

2021-11-28 Thread GitBox
urfreespace opened a new pull request #13010: URL: https://github.com/apache/pulsar/pull/13010 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] urfreespace opened a new pull request #13009: [website][upgrade]feat: website upgrade / docs migration - 2.5.2 / get started/concepts/schema

2021-11-28 Thread GitBox
urfreespace opened a new pull request #13009: URL: https://github.com/apache/pulsar/pull/13009 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] wolfstudy commented on pull request #12972: Fix zk-node leak of admin path

2021-11-28 Thread GitBox
wolfstudy commented on pull request #12972: URL: https://github.com/apache/pulsar/pull/12972#issuecomment-981324275 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Jason918 commented on pull request #13005: [metadata] add DelayInjectionMetadataStore

2021-11-28 Thread GitBox
Jason918 commented on pull request #13005: URL: https://github.com/apache/pulsar/pull/13005#issuecomment-981321983 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Jason918 commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-28 Thread GitBox
Jason918 commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r758061664 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/TopicStatsImpl.java ## @@ -76,6 +76,9 @@ /** Get estimated

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #12993: Do not reuse the Failed OpAddEntry object which lead bundle unloading timeout.

2021-11-28 Thread GitBox
michaeljmarshall commented on a change in pull request #12993: URL: https://github.com/apache/pulsar/pull/12993#discussion_r758058263 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -1678,7 +1678,6 @@ public

[GitHub] [pulsar] yuruguo removed a comment on pull request #13002: [pulsar-admin] Check the size options in cmd for topic and namespace

2021-11-28 Thread GitBox
yuruguo removed a comment on pull request #13002: URL: https://github.com/apache/pulsar/pull/13002#issuecomment-981184229 @eolivelli @gaoran10 @Technoboy- ptal, thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #12993: Do not reuse the Failed OpAddEntry object which lead bundle unloading timeout.

2021-11-28 Thread GitBox
michaeljmarshall commented on a change in pull request #12993: URL: https://github.com/apache/pulsar/pull/12993#discussion_r758041248 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -1678,7 +1678,6 @@ public

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #12996: [website] Modify admin-api-topic.md document

2021-11-28 Thread GitBox
BewareMyPower commented on a change in pull request #12996: URL: https://github.com/apache/pulsar/pull/12996#discussion_r758036220 ## File path: site2/docs/admin-api-topics.md ## @@ -1224,7 +1248,7 @@ persistent://tenant/namespace/topic2 ```java

[GitHub] [pulsar-client-go] wolfstudy merged pull request #671: Add subscription properties for ConsumerOptions

2021-11-28 Thread GitBox
wolfstudy merged pull request #671: URL: https://github.com/apache/pulsar-client-go/pull/671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-client-go] branch master updated: Add subscription properties for ConsumerOptions (#671)

2021-11-28 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 6385727 Add subscription properties for

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12999: [Issue 12998][io] enhance clickhouse cluster sink support

2021-11-28 Thread GitBox
codelipenghui commented on a change in pull request #12999: URL: https://github.com/apache/pulsar/pull/12999#discussion_r758032106 ## File path: pulsar-io/jdbc/clickhouse/pom.xml ## @@ -41,7 +41,6 @@ ru.yandex.clickhouse clickhouse-jdbc

[pulsar] branch master updated (e7b0e3d -> e4b8b33)

2021-11-28 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e7b0e3d Fix update ledger list to znode version mismatch failed, ledger not delete (#12015) add e4b8b33

[GitHub] [pulsar] codelipenghui merged pull request #12997: [broker] [code cleanup] unused field in DispatchRateLimiter

2021-11-28 Thread GitBox
codelipenghui merged pull request #12997: URL: https://github.com/apache/pulsar/pull/12997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch branch-2.8 updated: Fix update ledger list to znode version mismatch failed, ledger not delete (#12015)

2021-11-28 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new b898173 Fix update ledger list to

[pulsar] branch master updated (bef937b -> e7b0e3d)

2021-11-28 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from bef937b Add subscription properties for SubscriptionStats (#12979) add e7b0e3d Fix update ledger list to

[GitHub] [pulsar] codelipenghui merged pull request #12015: Fix update ledger list to znode version mismatch failed, ledger not delete

2021-11-28 Thread GitBox
codelipenghui merged pull request #12015: URL: https://github.com/apache/pulsar/pull/12015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Jason918 opened a new issue #13008: Flaky-test: [org.apache.pulsar.metadata.ZKSessionTest].[testDisconnection]

2021-11-28 Thread GitBox
Jason918 opened a new issue #13008: URL: https://github.com/apache/pulsar/issues/13008 [org.apache.pulsar.metadata.ZKSessionTest] is flaky. The [testDisconnection] test method fails sporadically. [example

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #671: Add subscription properties for ConsumerOptions

2021-11-28 Thread GitBox
wolfstudy commented on pull request #671: URL: https://github.com/apache/pulsar-client-go/pull/671#issuecomment-981258838 So, here I opened an issue to track the status of this pr.https://github.com/apache/pulsar-client-go/issues/672 -- This is an automated message from the Apache Git

[GitHub] [pulsar-client-go] wolfstudy opened a new issue #672: Add unit test case for SubscriptionProperties

2021-11-28 Thread GitBox
wolfstudy opened a new issue #672: URL: https://github.com/apache/pulsar-client-go/issues/672 Add unit test case for SubscriptionProperties, refer to: https://github.com/apache/pulsar-client-go/pull/671#issuecomment-981257522 -- This is an automated message from the Apache Git

[GitHub] [pulsar] Jason918 opened a new pull request #13007: Fix race condition in FaultInjectionMetadataStore#programmedFailure

2021-11-28 Thread GitBox
Jason918 opened a new pull request #13007: URL: https://github.com/apache/pulsar/pull/13007 ### Motivation `org.apache.pulsar.metadata.impl.FaultInjectionMetadataStore#programmedFailure` is not thread safe. Multi threads can get the same failure at the same time (At Line 195),

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #671: Add subscription properties for ConsumerOptions

2021-11-28 Thread GitBox
wolfstudy commented on pull request #671: URL: https://github.com/apache/pulsar-client-go/pull/671#issuecomment-981257522 In this pull request, i don't add unit test case for this, because I have no way to get the corresponding indicator information from SubscriptionStats. So in

[GitHub] [pulsar-client-go] wolfstudy opened a new pull request #671: Add subscription properties for ConsumerOptions

2021-11-28 Thread GitBox
wolfstudy opened a new pull request #671: URL: https://github.com/apache/pulsar-client-go/pull/671 Signed-off-by: xiaolongran ### Motivation In https://github.com/apache/pulsar/pull/12869, we introduce pluggable entry filter in Dispatcher, the pull request is the Go SDK

[pulsar] branch master updated (5e25184 -> bef937b)

2021-11-28 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5e25184 [docs] [ISSUE 11805] Add topic lookup metrics (#11927) add bef937b Add subscription properties for

[GitHub] [pulsar] wolfstudy merged pull request #12979: Add subscription properties for SubscriptionStats

2021-11-28 Thread GitBox
wolfstudy merged pull request #12979: URL: https://github.com/apache/pulsar/pull/12979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] wolfstudy commented on pull request #12972: Fix zk-node leak of admin path

2021-11-28 Thread GitBox
wolfstudy commented on pull request #12972: URL: https://github.com/apache/pulsar/pull/12972#issuecomment-981245071 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] 315157973 commented on pull request #12970: [PIP-105] Part-2 Support pluggable entry filter in Dispatcher

2021-11-28 Thread GitBox
315157973 commented on pull request #12970: URL: https://github.com/apache/pulsar/pull/12970#issuecomment-981241081 @eolivelli PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12996: [website] Modify admin-api-topic.md document

2021-11-28 Thread GitBox
Anonymitaet commented on a change in pull request #12996: URL: https://github.com/apache/pulsar/pull/12996#discussion_r757996972 ## File path: site2/docs/admin-api-topics.md ## @@ -943,6 +943,30 @@ admin.topics().getLastMessage(topic); +### Get backlog size + +You can

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12996: [website] Modify admin-api-topic.md document

2021-11-28 Thread GitBox
Anonymitaet commented on a change in pull request #12996: URL: https://github.com/apache/pulsar/pull/12996#discussion_r757998579 ## File path: site2/docs/admin-api-topics.md ## @@ -1224,7 +1248,7 @@ persistent://tenant/namespace/topic2 ```java

[GitHub] [pulsar] RobertIndie commented on a change in pull request #12872: [Broker] Support create subscription by specifying the earliest or latest position.

2021-11-28 Thread GitBox
RobertIndie commented on a change in pull request #12872: URL: https://github.com/apache/pulsar/pull/12872#discussion_r757998632 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ResetCursorData.java ## @@ -43,6 +43,21 @@ public ResetCursorData(long

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13001: [DOCS] Update io-debug.md

2021-11-28 Thread GitBox
Anonymitaet commented on a change in pull request #13001: URL: https://github.com/apache/pulsar/pull/13001#discussion_r757997451 ## File path: site2/docs/io-debug.md ## @@ -44,12 +44,12 @@ To better demonstrate how to debug Pulsar connectors, here takes a Mongo sink co

[pulsar] branch master updated (cfda694 -> 5e25184)

2021-11-28 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from cfda694 Move ConsumerBatchReceiveTest out of the quarantine test group (#12992) add 5e25184 [docs] [ISSUE

[GitHub] [pulsar] Anonymitaet closed issue #11805: [Doc] missed doc for topic lookup metrics

2021-11-28 Thread GitBox
Anonymitaet closed issue #11805: URL: https://github.com/apache/pulsar/issues/11805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet merged pull request #11927: [docs] [ISSUE 11805] Add topic lookup metrics

2021-11-28 Thread GitBox
Anonymitaet merged pull request #11927: URL: https://github.com/apache/pulsar/pull/11927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Shoothzj commented on pull request #12993: Do not reuse the Failed OpAddEntry object which lead bundle unloading timeout.

2021-11-28 Thread GitBox
Shoothzj commented on pull request #12993: URL: https://github.com/apache/pulsar/pull/12993#issuecomment-981200326 @codelipenghui what's the relationship between this and #12396 . Does this mean we don't need it anymore? -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] yuruguo commented on pull request #13002: [pulsar-admin] Check the size options in cmd for topic and namespace

2021-11-28 Thread GitBox
yuruguo commented on pull request #13002: URL: https://github.com/apache/pulsar/pull/13002#issuecomment-981184229 @eolivelli @gaoran10 @Technoboy- ptal, thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] Jason918 commented on pull request #13006: [Issue 13004] Fix race condition in ResourceLockImpl#revalidate

2021-11-28 Thread GitBox
Jason918 commented on pull request #13006: URL: https://github.com/apache/pulsar/pull/13006#issuecomment-981101635 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Jason918 commented on pull request #12975: [Issue 12812] Introduce ZKBatchedMetadataStore.

2021-11-28 Thread GitBox
Jason918 commented on pull request #12975: URL: https://github.com/apache/pulsar/pull/12975#issuecomment-981098704 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] sl1316 commented on issue #271: Consider using gRPC as an externally exposed API

2021-11-28 Thread GitBox
sl1316 commented on issue #271: URL: https://github.com/apache/pulsar/issues/271#issuecomment-981095046 @cbornet can you provide some guidance regarding how to use the grpc protocol? I only saw binary protocol in http://pulsar.apache.org/docs/en/develop-binary-protocol/ . -- This is an

[GitHub] [pulsar] Jason918 commented on a change in pull request #13005: [metadata] add DelayInjectionMetadataStore

2021-11-28 Thread GitBox
Jason918 commented on a change in pull request #13005: URL: https://github.com/apache/pulsar/pull/13005#discussion_r757903118 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/impl/DelayInjectionMetadataStoreTest.java ## @@ -0,0 +1,73 @@ +/** + * Licensed

[GitHub] [pulsar] Jason918 commented on a change in pull request #13005: [metadata] add DelayInjectionMetadataStore

2021-11-28 Thread GitBox
Jason918 commented on a change in pull request #13005: URL: https://github.com/apache/pulsar/pull/13005#discussion_r757901794 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/DelayInjectionMetadataStore.java ## @@ -0,0 +1,245 @@ +/** + * Licensed to

[GitHub] [pulsar] Jason918 opened a new pull request #13006: [Issue 13004] Fix race condition in ResourceLockImpl#revalidate

2021-11-28 Thread GitBox
Jason918 opened a new pull request #13006: URL: https://github.com/apache/pulsar/pull/13006 Fixes #13004 ### Motivation See #13004 ### Modifications Add a new field `revalidateFuture` to store the status of last revalidate. If it's not done, then

[GitHub] [pulsar] eolivelli commented on a change in pull request #13005: [metadata] add DelayInjectionMetadataStore

2021-11-28 Thread GitBox
eolivelli commented on a change in pull request #13005: URL: https://github.com/apache/pulsar/pull/13005#discussion_r757866877 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/impl/DelayInjectionMetadataStoreTest.java ## @@ -0,0 +1,73 @@ +/** + *

[GitHub] [pulsar] Jason918 opened a new pull request #13005: [metadata] add DelayInjectionMetadataStore

2021-11-28 Thread GitBox
Jason918 opened a new pull request #13005: URL: https://github.com/apache/pulsar/pull/13005 ### Motivation Currently, we have `FaultInjectionMetadataStore` which can only inject errors for metadata store. but there are some race conditions in metadata store, like #13004,

[GitHub] [pulsar] Jason918 opened a new issue #13004: [metadata] Race condition in ResourceLockImpl#revalidate

2021-11-28 Thread GitBox
Jason918 opened a new issue #13004: URL: https://github.com/apache/pulsar/issues/13004 **Describe the bug** Current unit test `org.apache.pulsar.metadata.LockManagerTest#updateValueWhenKeyDisappears` have a small chance that will fails with following exception: > >