gaozhangmin commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1006356562
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dragonls opened a new issue #13645:
URL: https://github.com/apache/pulsar/issues/13645
**Describe the bug**
It seems that there are no subscription throughput out metrics for non
persistent topic consumer, which make it hard to know whether the consumers are
working fine.
I
shibd commented on issue #13640:
URL: https://github.com/apache/pulsar/issues/13640#issuecomment-1006350996
Hi, Why create subscription on non persistent topic is not support by admin
api? @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the
leizhiyuan commented on issue #13643:
URL: https://github.com/apache/pulsar/issues/13643#issuecomment-1006350888
> @leizhiyuan
>
> Maybe `priority` make more sence.
>
> What do you think about it ?
ok, priority is more clear
--
This is an automated message from the
equanz opened a new pull request #13644:
URL: https://github.com/apache/pulsar/pull/13644
### Motivation
It seems some test cases like `**/*Test2.java` aren't run on the default
test lifecycle.
The https://github.com/apache/pulsar/pull/10148 occurs the issue. I'd like
to fix it.
mattisonchao commented on issue #13643:
URL: https://github.com/apache/pulsar/issues/13643#issuecomment-1006344245
@leizhiyuan
Maybe ``priority`` make more sence.
What do you think about it ?
--
This is an automated message from the Apache Git Service.
To respond to the
leizhiyuan commented on issue #13643:
URL: https://github.com/apache/pulsar/issues/13643#issuecomment-1006343600
if this is ok，you can assign to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
leizhiyuan opened a new issue #13643:
URL: https://github.com/apache/pulsar/issues/13643
**Is your enhancement request related to a problem? Please describe.**
A clear and concise description of what the enhancement is.
current， if we have two Policies that match the same
lordcheng10 edited a comment on pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1006328484
> scheduleAtFixedRate
IMHO , GenericBrokerHostUsageImpl only needs to replace scheduleAtFixedRate
with scheduleWithFixedDelay.
I have used
lordcheng10 edited a comment on pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1006328484
> scheduleAtFixedRate
IMHO , GenericBrokerHostUsageImpl only needs to replace scheduleAtFixedRate
with scheduleWithFixedDelay.
I have used
mingyifei removed a comment on pull request #13553:
URL: https://github.com/apache/pulsar/pull/13553#issuecomment-1006331509
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mingyifei commented on pull request #13553:
URL: https://github.com/apache/pulsar/pull/13553#issuecomment-1006331509
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lordcheng10 edited a comment on pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1006328484
> scheduleAtFixedRate
I have used scheduleWithFixedDelay instead of scheduleAtFixedRate in the
class GenericBrokerHostUsageImpl.
Please review again
liudezhi2098 commented on pull request #13619:
URL: https://github.com/apache/pulsar/pull/13619#issuecomment-1006328867
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gaozhangmin commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1006328612
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lordcheng10 commented on pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1006328484
> scheduleAtFixedRate
I have used scheduleWithFixedDelay instead of scheduleAtFixedRate in the
class GenericBrokerHostUsageImpl. Please review again
gaozhangmin commented on issue #13523:
URL: https://github.com/apache/pulsar/issues/13523#issuecomment-1006328180
@keyboardbobo You can commit your source code if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
suiyuzeng commented on pull request #13624:
URL: https://github.com/apache/pulsar/pull/13624#issuecomment-1006317413
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
suiyuzeng commented on pull request #13623:
URL: https://github.com/apache/pulsar/pull/13623#issuecomment-1006317136
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gaozhangmin commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1006316794
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pavikarunakaran opened a new issue #13642:
URL: https://github.com/apache/pulsar/issues/13642
Hi,
I'm getting error logs in pulsar bookkeeper and because of this I'm not
getting acknowledged from the pulsar whether the job is pushed successfully or
not. Since there is no
lordcheng10 commented on pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1006315419
> @lordcheng10 - would you also take a look at `GenericBrokerHostUsageImpl`?
That uses `scheduleAtFixedRate` when in the same way.
OK
--
This is an automated
keyboardbobo commented on issue #13523:
URL: https://github.com/apache/pulsar/issues/13523#issuecomment-1006314674
I modified the source code, and by isolating the problematic producer, I can
successfully prevent the cluster traffic from dropping.
--
This is an automated message from
keyboardbobo removed a comment on issue #13523:
URL: https://github.com/apache/pulsar/issues/13523#issuecomment-1006314275
By isolating the problematic producer, I can prevent the cluster traffic
from dropping
--
This is an automated message from the Apache Git Service.
To respond to
keyboardbobo commented on issue #13523:
URL: https://github.com/apache/pulsar/issues/13523#issuecomment-1006314275
By isolating the problematic producer, I can prevent the cluster traffic
from dropping
--
This is an automated message from the Apache Git Service.
To respond to the
BewareMyPower commented on pull request #12988:
URL: https://github.com/apache/pulsar/pull/12988#issuecomment-1006301408
I have a question, is the path of `commit-message.png` correct?
The image's path is `site2/website/static/img/commit-message.png`, while the
markdown's path is
BewareMyPower commented on pull request #13424:
URL: https://github.com/apache/pulsar/pull/13424#issuecomment-1006299888
Never mind. There was a PR that adds the guideline for merging a PR:
https://github.com/apache/pulsar/pull/12988. It will be included in Pulsar
2.10.0 website.
--
michaeljmarshall commented on pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1006299661
@lordcheng10 - would you also take a look at `GenericBrokerHostUsageImpl`?
That uses `scheduleAtFixedRate` when in the same way.
--
This is an automated message
github-actions[bot] commented on pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641#issuecomment-1006299280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gaozhangmin opened a new pull request #13641:
URL: https://github.com/apache/pulsar/pull/13641
### Motivation
#12366 added bundle metrics, But, If we enabled expose these metrics, It
would overwrite previous load balancing metrics.
### Modifications
seperate
Shoothzj commented on pull request #13424:
URL: https://github.com/apache/pulsar/pull/13424#issuecomment-1006294409
> Hi, just a tip for new committers. When you merge a PR, it's better to
copy and paste the PR description like
>
>
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 016fb87 update doc (#13614)
add 793dd91 Fix time field use error (#12249)
No new revisions were added by
Shoothzj merged pull request #12249:
URL: https://github.com/apache/pulsar/pull/12249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
BewareMyPower commented on pull request #13424:
URL: https://github.com/apache/pulsar/pull/13424#issuecomment-1006292692
Hi, just a tip for new committers. When you merge a PR, it's better to copy
and paste the PR description like
goflutterjava commented on pull request #13638:
URL: https://github.com/apache/pulsar/pull/13638#issuecomment-1006290941
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kimula commented on pull request #13636:
URL: https://github.com/apache/pulsar/pull/13636#issuecomment-1006279963
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dragonls opened a new issue #13640:
URL: https://github.com/apache/pulsar/issues/13640
**Describe the bug**
I am trying to use non persistent topic on pulsar 2.7.2 non persistent
topic. Pulsar cluster disallow auto subscription creation,
`allowAutoSubscriptionCreation=false`.
I
michaeljmarshall opened a new pull request #13639:
URL: https://github.com/apache/pulsar/pull/13639
### Motivation
The `ResourceUsage` class can easily be made immutable. Since it is possibly
shared across threads, it is safer to make it immutable. As a benefit, we can
calculate
Demogorgon314 commented on pull request #13634:
URL: https://github.com/apache/pulsar/pull/13634#issuecomment-1006273189
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
massakam commented on a change in pull request #13525:
URL: https://github.com/apache/pulsar/pull/13525#discussion_r779288016
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiHealthCheckTest.java
##
@@ -66,18 +63,7 @@ public void
goflutterjava opened a new pull request #13638:
URL: https://github.com/apache/pulsar/pull/13638
### Motivation
currently, the `pulsar-client-api` module is not protected by the
`checkstyle-plugin`.
### Modifications
- Enable CheckStyle Plugin
- Fix checkstyle violations
###
Jason918 commented on pull request #13618:
URL: https://github.com/apache/pulsar/pull/13618#issuecomment-1006264207
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nodece commented on a change in pull request #13596:
URL: https://github.com/apache/pulsar/pull/13596#discussion_r779267691
##
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
##
@@ -75,6 +78,11 @@
protected abstract
Jason918 commented on pull request #13599:
URL: https://github.com/apache/pulsar/pull/13599#issuecomment-1006261198
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lordcheng10 commented on pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1006253651
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mattisonchao opened a new issue #13637:
URL: https://github.com/apache/pulsar/issues/13637
**Is your enhancement request related to a problem? Please describe.**
Relate pull requests :
https://github.com/apache/pulsar/pull/8372
https://github.com/apache/pulsar/pull/13094
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1006249035
@Jason918 I think this pull request is ready to merge. PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1006235775
@Shoothzj PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #13636:
URL: https://github.com/apache/pulsar/pull/13636#issuecomment-1006245479
@kimula:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about
kimula opened a new pull request #13636:
URL: https://github.com/apache/pulsar/pull/13636
### Motivation
The document of Node.js client lacks information on worker threads.
### Modifications
Add notes on worker threads to the document.
### Verifying this change
lordcheng10 commented on pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1006245143
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
liuyu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 825d2fe update log content (#13540)
add 016fb87 update doc (#13614)
No new revisions were added by this
Anonymitaet merged pull request #13614:
URL: https://github.com/apache/pulsar/pull/13614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mingyifei opened a new issue #13635:
URL: https://github.com/apache/pulsar/issues/13635
After the bookeeper obtains the FileChannel, it writes the called write,
reads the called read, write is written to the system buffer, and forced to
write to the disk through fileChannel.force. Why is
nodece commented on a change in pull request #13596:
URL: https://github.com/apache/pulsar/pull/13596#discussion_r779267691
##
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
##
@@ -75,6 +78,11 @@
protected abstract
Demogorgon314 commented on issue #13605:
URL: https://github.com/apache/pulsar/issues/13605#issuecomment-1006242932
@lhotari I already pushed a patch, please take a look, thanks : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a change to branch revert-691-xiaolong/split-eventsCh
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git.
from accf726 Revert "Use a separate gorutine to handle the logic of
reconnect
Demogorgon314 opened a new pull request #13634:
URL: https://github.com/apache/pulsar/pull/13634
Fixes #13605
### Motivation
Currently, the multiTopicReader `hasMessageAvailable` might get the wrong
result, we must check `numMessagesInQueue() > 0` again after finish all
zxJin-x commented on pull request #13502:
URL: https://github.com/apache/pulsar/pull/13502#issuecomment-1006241044
@eolivelli PTAL, again, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wolfstudy opened a new pull request #700:
URL: https://github.com/apache/pulsar-client-go/pull/700
Reverts apache/pulsar-client-go#691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a change to branch revert-691-xiaolong/split-eventsCh
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git.
at accf726 Revert "Use a separate gorutine to handle the logic of
reconnect
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch revert-691-xiaolong/split-eventsCh
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
commit accf726bdf3972ac3b8b64c7fe1c0480959cc2de
Author: xiaolong ran
AuthorDate: Thu Jan 6
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1006235775
@Shoothzj PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Technoboy- commented on a change in pull request #13383:
URL: https://github.com/apache/pulsar/pull/13383#discussion_r779259574
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
##
@@ -476,6 +499,46 @@ public void doUnsubscribe(final
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 53ad936 Allow to config no-password truststore (#13424)
add 825d2fe update log content (#13540)
No new
Shoothzj merged pull request #13540:
URL: https://github.com/apache/pulsar/pull/13540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
suiyuzeng commented on a change in pull request #13624:
URL: https://github.com/apache/pulsar/pull/13624#discussion_r779257745
##
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopicPolicies.java
##
@@ -85,6 +85,10 @@ public
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from a178b67 [website][upgrade] feat: rest api pages (#13597)
add 53ad936 Allow to config no-password truststore
Shoothzj merged pull request #13424:
URL: https://github.com/apache/pulsar/pull/13424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lordcheng10 commented on a change in pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#discussion_r779255342
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/LinuxBrokerHostUsageImpl.java
##
@@ -110,6 +110,10 @@ public
lordcheng10 commented on a change in pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#discussion_r779255342
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/LinuxBrokerHostUsageImpl.java
##
@@ -110,6 +110,10 @@ public
keyboardbobo commented on issue #13523:
URL: https://github.com/apache/pulsar/issues/13523#issuecomment-1006226499
Theoretically speaking, only a slow response from any broker or a slow
network will drag down other producers, because the slowest producer will
always be the bottleneck
--
hsaputra commented on pull request #13463:
URL: https://github.com/apache/pulsar/pull/13463#issuecomment-1006225027
FYI @cckellogg , @jerrypeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Technoboy- commented on a change in pull request #13596:
URL: https://github.com/apache/pulsar/pull/13596#discussion_r779251326
##
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
##
@@ -75,6 +78,11 @@
protected abstract
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 1b36f32 Change level log to debug for broker interceptor testing
(#13604)
add a178b67 [website][upgrade]
lordcheng10 commented on pull request #13540:
URL: https://github.com/apache/pulsar/pull/13540#issuecomment-1006219315
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
urfreespace merged pull request #13597:
URL: https://github.com/apache/pulsar/pull/13597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1006218883
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ross710 commented on issue #11100:
URL: https://github.com/apache/pulsar/issues/11100#issuecomment-1006218658
We were able to reproduce this issue with one of our applications.
With ~40 producers spun up but idle (not producing any messages) we tested
with pulsar client 2.6.3 and
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002868882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lordcheng10 commented on a change in pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#discussion_r779244655
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/LinuxBrokerHostUsageImpl.java
##
@@ -110,6 +110,10 @@ public
Shoothzj commented on pull request #13619:
URL: https://github.com/apache/pulsar/pull/13619#issuecomment-1006210618
After discuss with @liudezhi2098, We need to apply `checkstyle-plugins` to
`managed-ledger` module to protect these changes.
--
This is an automated message from the
mattisonchao commented on issue #13628:
URL: https://github.com/apache/pulsar/issues/13628#issuecomment-1006207324
> Some preliminary questions:
>
> * Where are you going to store this data? (Think about a huge cluster with
thousands of independent, isolated tenants)
> * How do
This is an automated email from the ASF dual-hosted git repository.
yong pushed a change to branch 2.8.1
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
at 1b36f32 Change level log to debug for broker interceptor testing
(#13604)
No new revisions were added by this
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 1b36f32 Change level log to debug for broker
codelipenghui merged pull request #13604:
URL: https://github.com/apache/pulsar/pull/13604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1005454497
@codelipenghui PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Ethan-Merrill opened a new issue #13633:
URL: https://github.com/apache/pulsar/issues/13633
## Motivation
Certain uses of Pulsar functions could benefit from the ability to access
the states of other functions. Currently functions can only access their own
states, and so sharing
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 17a971a [Tests] Fix flaky
org.mockito.exceptions.misusing.WrongTypeOfReturnValue issue in broker tests
(#13621)
Shoothzj merged pull request #13610:
URL: https://github.com/apache/pulsar/pull/13610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Shoothzj closed issue #13607:
URL: https://github.com/apache/pulsar/issues/13607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
michaeljmarshall commented on a change in pull request #13606:
URL: https://github.com/apache/pulsar/pull/13606#discussion_r779194795
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##
@@ -740,16 +740,17 @@ public void
michaeljmarshall commented on a change in pull request #13606:
URL: https://github.com/apache/pulsar/pull/13606#discussion_r779186259
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##
@@ -740,16 +740,17 @@ public void
hsaputra commented on pull request #13157:
URL: https://github.com/apache/pulsar/pull/13157#issuecomment-1006104606
Thanks for the follow up, @michaeljmarshall !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
michaeljmarshall commented on pull request #13622:
URL: https://github.com/apache/pulsar/pull/13622#issuecomment-1006099031
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
michaeljmarshall commented on a change in pull request #13609:
URL: https://github.com/apache/pulsar/pull/13609#discussion_r779152660
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/LinuxBrokerHostUsageImpl.java
##
@@ -110,6 +110,10 @@
michaeljmarshall commented on pull request #13463:
URL: https://github.com/apache/pulsar/pull/13463#issuecomment-1006093023
I lean towards reverting the whole commit and then creating new PRs to add
the right functionality. However, I don't have a strong opinion here.
> Maybe we can
michaeljmarshall commented on pull request #13157:
URL: https://github.com/apache/pulsar/pull/13157#issuecomment-1006087757
Hi @hsaputra - you're right that it would impact external implementations.
There is already a PR to revert this commit. There is ongoing discussion there.
github-actions[bot] commented on pull request #13632:
URL: https://github.com/apache/pulsar/pull/13632#issuecomment-1006076561
@michaeljmarshall:Thanks for your contribution. For this PR, do we need to
update docs?
(The [PR template contains info about
michaeljmarshall opened a new pull request #13632:
URL: https://github.com/apache/pulsar/pull/13632
Related PRs: https://github.com/apache/pulsar/pull/13387
https://github.com/apache/pulsar/pull/13389
### Motivation
Remove the DC/OS deployment example documentation and
1 - 100 of 185 matches
Mail list logo
