[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #155: [fix][build] Hide non-exported symbols from the dependencies

2022-12-22 Thread GitBox
BewareMyPower commented on PR #155: URL: https://github.com/apache/pulsar-client-cpp/pull/155#issuecomment-1363697773 I tried to build the x64 deb package in my local env, it does not include the symbols from libcurl or openssl. ```bash $ nm -D /usr/lib/libpulsar.so | grep curl

[GitHub] [pulsar-client-go] Gleiphir2769 opened a new issue, #925: [CI] Set the squash merge message to "Default to pull request title"

2022-12-22 Thread GitBox
Gleiphir2769 opened a new issue, #925: URL: https://github.com/apache/pulsar-client-go/issues/925 I noticed that the default squash merge message is set from "Default to pull request title" to "Default message". Could we use "Default to pull request title" just like before? I think

[GitHub] [pulsar] startjava opened a new issue, #19036: [Doc] Auto-split Hash Range::C1 to C3 ??

2022-12-22 Thread GitBox
startjava opened a new issue, #19036: URL: https://github.com/apache/pulsar/issues/19036 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs?

[pulsar-client-go] branch master updated: fix: fix 923 (#924)

2022-12-22 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 1d3499a fix: fix 923 (#924) 1d3499a is

[GitHub] [pulsar-client-go] wolfstudy closed issue #923: [BUG] Outdated interface description of `SeekByTime`

2022-12-22 Thread GitBox
wolfstudy closed issue #923: [BUG] Outdated interface description of `SeekByTime` URL: https://github.com/apache/pulsar-client-go/issues/923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-go] wolfstudy merged pull request #924: [Issue 923] Remove the outdated interface description of `SeekByTime`

2022-12-22 Thread GitBox
wolfstudy merged PR #924: URL: https://github.com/apache/pulsar-client-go/pull/924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-cpp] BewareMyPower opened a new pull request, #155: [fix][build] Hide non-exported symbols from the dependencies

2022-12-22 Thread GitBox
BewareMyPower opened a new pull request, #155: URL: https://github.com/apache/pulsar-client-cpp/pull/155 ### Motivation Currently the released libraries don't hide the symbols from the dependencies, it can be verified by the following steps on Ubuntu: ```bash curl -O -L

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19017: [wip][fix][broker] Fix estimateBacklogFromPosition if position is greater than the greatest ledgerId

2022-12-22 Thread GitBox
congbobo184 commented on code in PR #19017: URL: https://github.com/apache/pulsar/pull/19017#discussion_r1056093208 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -1269,14 +1269,15 @@ public long

[pulsar] branch master updated (38053b5d1ba -> aaf3a9a9a74)

2022-12-22 Thread yuruguo
This is an automated email from the ASF dual-hosted git repository. yuruguo pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 38053b5d1ba [improve][io] Debezium sources: Support loading config from secrets (#19004) add aaf3a9a9a74

[GitHub] [pulsar] yuruguo merged pull request #19029: [improve][client] Check topic pattern when creating consumer

2022-12-22 Thread GitBox
yuruguo merged PR #19029: URL: https://github.com/apache/pulsar/pull/19029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-client-cpp] branch main updated (fa3ac76 -> 97af35a)

2022-12-22 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git from fa3ac76 [feat] PIP 107: Introduce chunk message ID (#148) add 97af35a fix auxv header (#152) No new

[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #152: [fix] Fix `auxv` detection

2022-12-22 Thread GitBox
BewareMyPower merged PR #152: URL: https://github.com/apache/pulsar-client-cpp/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #153: [fix] Fix MessageId serialization when it's a batched message

2022-12-22 Thread GitBox
BewareMyPower commented on PR #153: URL: https://github.com/apache/pulsar-client-cpp/pull/153#issuecomment-1363572861 @shibd I see. I will fix it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[pulsar] branch branch-2.11 updated: [fix][client] Fix multi-topic consumer stuck after redeliver messages (#18491)

2022-12-22 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 6748d93c2e3 [fix][client] Fix

[GitHub] [pulsar-client-cpp] shibd commented on pull request #153: [fix] Fix MessageId serialization when it's a batched message

2022-12-22 Thread GitBox
shibd commented on PR #153: URL: https://github.com/apache/pulsar-client-cpp/pull/153#issuecomment-1363559609 @BewareMyPower It seems that compilation does not pass in the macOS environment. -- This is an automated message from the Apache Git Service. To respond to the message, please

svn commit: r58877 - /dev/pulsar/pulsar-client-node/pulsar-client-node-1.8.0-candidate-2/

2022-12-22 Thread zike
Author: zike Date: Fri Dec 23 02:46:33 2022 New Revision: 58877 Log: Staging artifacts and signature for Pulsar Node.js client release 1.8.0-candidate-2 Added: dev/pulsar/pulsar-client-node/pulsar-client-node-1.8.0-candidate-2/

[pulsar] branch master updated (513e6719357 -> 38053b5d1ba)

2022-12-22 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 513e6719357 Revert "Update .asf.yaml to avoid merge PRs without approvals to the active release branches (#19024)

[GitHub] [pulsar] Technoboy- merged pull request #19004: [improve][io] Debezium sources: Support loading config from secrets

2022-12-22 Thread GitBox
Technoboy- merged PR #19004: URL: https://github.com/apache/pulsar/pull/19004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-client-node] annotated tag v1.8.0-rc.2 updated (0ce9cd0 -> f20e638)

2022-12-22 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a change to annotated tag v1.8.0-rc.2 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git *** WARNING: tag v1.8.0-rc.2 was modified! *** from 0ce9cd0 (commit) to f20e638 (tag)

[pulsar-client-node] 02/02: Bump async from 3.2.1 to 3.2.4 (#261)

2022-12-22 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a commit to branch branch-1.8 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git commit 0ce9cd0606cd94eeb6c2242e7c810db8ffbef545 Author: nkurihar AuthorDate: Thu Dec 22 21:32:53 2022 +0900

[pulsar-client-node] branch branch-1.8 updated (a33f615 -> 0ce9cd0)

2022-12-22 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a change to branch branch-1.8 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git from a33f615 [refactor] Refactor the cpp client version controlling in the build script (#259) new

[pulsar-client-node] 01/02: fix: Add license headers (#262)

2022-12-22 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a commit to branch branch-1.8 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git commit 341ec92651447ae57e0a3a31e03df9b2191acf05 Author: nkurihar AuthorDate: Thu Dec 22 19:47:27 2022 +0900

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #154: [feat] Support partitioned topic reader.

2022-12-22 Thread GitBox
BewareMyPower commented on code in PR #154: URL: https://github.com/apache/pulsar-client-cpp/pull/154#discussion_r1055983371 ## include/pulsar/ConsumerConfiguration.h: ## @@ -383,6 +383,26 @@ class PULSAR_PUBLIC ConsumerConfiguration { */ InitialPosition

[GitHub] [pulsar] codecov-commenter commented on pull request #19028: [fix][client] Prevent DNS reverse lookup when physical address is an IP address

2022-12-22 Thread GitBox
codecov-commenter commented on PR #19028: URL: https://github.com/apache/pulsar/pull/19028#issuecomment-1363537054 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19028?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] github-actions[bot] commented on issue #18300: Flaky-test: MetadataStoreStatsTest#testBatchMetadataStoreMetrics

2022-12-22 Thread GitBox
github-actions[bot] commented on issue #18300: URL: https://github.com/apache/pulsar/issues/18300#issuecomment-1363536189 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #18507: [Bug] Pulsar Admin sink update can potentially wipe out "inputSpecs"

2022-12-22 Thread GitBox
github-actions[bot] commented on issue #18507: URL: https://github.com/apache/pulsar/issues/18507#issuecomment-1363536094 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on pull request #18518: [improve] Introduce the sync() API to ensure consistency on reads during critical metadata operation paths

2022-12-22 Thread GitBox
github-actions[bot] commented on PR #18518: URL: https://github.com/apache/pulsar/pull/18518#issuecomment-1363536060 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] codelipenghui merged pull request #19034: Revert "Update .asf.yaml to avoid merge PRs without approvals to the active release branches (#19024)

2022-12-22 Thread GitBox
codelipenghui merged PR #19034: URL: https://github.com/apache/pulsar/pull/19034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated: Revert "Update .asf.yaml to avoid merge PRs without approvals to the active release branches (#19024) (#19034)

2022-12-22 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 513e6719357 Revert "Update .asf.yaml to avoid

[pulsar] branch master updated: [fix][broker] Fix thread safety issue in info-internal admin api for partitioned topics (#19021)

2022-12-22 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 64caf495a71 [fix][broker] Fix thread safety

[GitHub] [pulsar] Technoboy- merged pull request #19021: [fix][broker] Fix thread safety issue in info-internal admin api for partitioned topics

2022-12-22 Thread GitBox
Technoboy- merged PR #19021: URL: https://github.com/apache/pulsar/pull/19021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Technoboy- closed pull request #19028: [fix][client] Prevent DNS reverse lookup when physical address is an IP address

2022-12-22 Thread GitBox
Technoboy- closed pull request #19028: [fix][client] Prevent DNS reverse lookup when physical address is an IP address URL: https://github.com/apache/pulsar/pull/19028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] coderzc opened a new pull request, #19035: [feat][broker][PIP-195]Implement Filter out all delayed messages and skip them when reading messages from bookies - part7

2022-12-22 Thread GitBox
coderzc opened a new pull request, #19035: URL: https://github.com/apache/pulsar/pull/19035 PIP: #16763 ### Motivation #16763 ### Modifications Implement Filter out all delayed messages and skip them when reading messages from bookies ### Verifying

[GitHub] [pulsar-client-cpp] shibd opened a new pull request, #154: [feat] Support partitioned topic reader.

2022-12-22 Thread GitBox
shibd opened a new pull request, #154: URL: https://github.com/apache/pulsar-client-cpp/pull/154 ### Motivation In the current implementation, Reader does not yet support partitioned topics. ### Modifications - ConsumerConfig support set `subscriptionMode`. -

[GitHub] [pulsar] labuladong commented on issue #18925: [Bug] Cannot auto delete partitioned topic

2022-12-22 Thread GitBox
labuladong commented on issue #18925: URL: https://github.com/apache/pulsar/issues/18925#issuecomment-1363492572 I have investigated the source code, and I reproduced that the partitioned topics cannot be auto-deleted. It seems we only store partitioned topic metadata in zk instead

[GitHub] [pulsar] tisonkun commented on pull request #19033: [improve][misc] Send GitHub discussion notifications to commits@

2022-12-22 Thread GitBox
tisonkun commented on PR #19033: URL: https://github.com/apache/pulsar/pull/19033#issuecomment-1363489929 Emmm...IIRC we have another thread having consensus on such move but the link you share here has no response. Thus I'll hold this PR before I saw the consensus or we follow lazy

[GitHub] [pulsar] tisonkun commented on pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
tisonkun commented on PR #19024: URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1363487804 > Interesting, why changing the configuration via the GitHub Settings works. @codelipenghui It's possible that you're the admin of your fork and bypass the protect rules.

[GitHub] [pulsar] codelipenghui opened a new pull request, #19034: Revert "Update .asf.yaml to avoid merge PRs without approvals to the active release branches (#19024)

2022-12-22 Thread GitBox
codelipenghui opened a new pull request, #19034: URL: https://github.com/apache/pulsar/pull/19034 ### Motivation See: https://github.com/apache/pulsar/pull/19024#issuecomment-1363480874 ### Modifications Revert #19024 ### Does this pull request potentially affect

[GitHub] [pulsar] codelipenghui commented on pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
codelipenghui commented on PR #19024: URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1363480874 Bad news: ``` ~/GitHub/apache/incubator-pulsar (branch-2.11) » git push apache branch-2.11

[pulsar] branch master updated: Update .asf.yaml to avoid merge PRs without approvals to the active release branches (#19024)

2022-12-22 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 849bea659e0 Update .asf.yaml to avoid merge

[GitHub] [pulsar] codelipenghui merged pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
codelipenghui merged PR #19024: URL: https://github.com/apache/pulsar/pull/19024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19033: [improve][misc] Send GitHub discussion notifications to commits@

2022-12-22 Thread GitBox
michaeljmarshall opened a new pull request, #19033: URL: https://github.com/apache/pulsar/pull/19033 ### Motivation Mailing list thread: TBD When we first introduced GitHub discussions, we had their notifications go to the dev@ list. That has produced many notifications, and

[GitHub] [pulsar] lhotari commented on issue #19032: Flaky-test: TestPulsarAuth.testPulsarSqlAuth hangs and makes the test run to get cancelled by a timeout

2022-12-22 Thread GitBox
lhotari commented on issue #19032: URL: https://github.com/apache/pulsar/issues/19032#issuecomment-1363249375 might be related to #13964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari opened a new issue, #19032: Flaky-test: TestPulsarAuth.testPulsarSqlAuth hangs and makes the test run to get cancelled by a timeout

2022-12-22 Thread GitBox
lhotari opened a new issue, #19032: URL: https://github.com/apache/pulsar/issues/19032 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure

[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#f85d591)

2022-12-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new cf2b15d317e Docs sync done from apache/pulsar

[GitHub] [pulsar] eolivelli opened a new issue, #11037: Flaky-test: org.apache.pulsar.client.impl.schema.PrimitiveSchemaTest.allSchemasShouldSupportNull and allSchemasShouldRoundtripInput

2022-12-22 Thread GitBox
eolivelli opened a new issue, #11037: URL: https://github.com/apache/pulsar/issues/11037 ``` java.lang.NullPointerException: NPE when using schema null : null at org.apache.pulsar.client.impl.schema.PrimitiveSchemaTest.allSchemasShouldRoundtripInput(PrimitiveSchemaTest.java:132)

[GitHub] [pulsar] lhotari commented on issue #11037: Flaky-test: org.apache.pulsar.client.impl.schema.PrimitiveSchemaTest.allSchemasShouldSupportNull and allSchemasShouldRoundtripInput

2022-12-22 Thread GitBox
lhotari commented on issue #11037: URL: https://github.com/apache/pulsar/issues/11037#issuecomment-1363186408 There's a similar flaky test issue that exists in master branch. example: https://github.com/apache/pulsar/actions/runs/3759470154/jobs/6389256559#step:10:600 ```

[GitHub] [pulsar] codecov-commenter commented on pull request #19021: [fix][broker] Fix thread safety issue in info-internal admin api for partitioned topics

2022-12-22 Thread GitBox
codecov-commenter commented on PR #19021: URL: https://github.com/apache/pulsar/pull/19021#issuecomment-1363133163 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19021?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] lhotari commented on a diff in pull request #19021: [fix][broker] Fix thread safety issue in info-internal admin api for partitioned topics

2022-12-22 Thread GitBox
lhotari commented on code in PR #19021: URL: https://github.com/apache/pulsar/pull/19021#discussion_r1055637524 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java: ## @@ -1330,10 +1322,15 @@ protected void

[GitHub] [pulsar] lhotari commented on pull request #19021: [fix][broker] Fix thread safety issue in info-internal admin api for partitioned topics

2022-12-22 Thread GitBox
lhotari commented on PR #19021: URL: https://github.com/apache/pulsar/pull/19021#issuecomment-1363045381 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] BewareMyPower commented on pull request #19031: [fix][client] Fix deserialized BatchMessageIdImpl acknowledgment failure

2022-12-22 Thread GitBox
BewareMyPower commented on PR #19031: URL: https://github.com/apache/pulsar/pull/19031#issuecomment-1362999460 More explanations to the refactoring parts of this PR: 1. I don't want to handle the list cumulative acknowledgment. Pulsar never supports this operation. There is no

[GitHub] [pulsar] BewareMyPower opened a new pull request, #19031: [fix][client] Fix deserialized BatchMessageIdImpl acknowledgment failure

2022-12-22 Thread GitBox
BewareMyPower opened a new pull request, #19031: URL: https://github.com/apache/pulsar/pull/19031 Fixes https://github.com/apache/pulsar/issues/19030 ### Motivation When a `BatchMessageIdImpl` is created from a deserialization, the `BatchMessageAcker` object cannot be shared

[GitHub] [pulsar] imaffe commented on pull request #18643: [improve][fn] 18532: Function JavaInstanceStarter support reading configs from file

2022-12-22 Thread GitBox
imaffe commented on PR #18643: URL: https://github.com/apache/pulsar/pull/18643#issuecomment-1362876147 @freeznet Hi Rui,can you mark this PR as ready-to-test ? I want to kick off the test process to see if anything goes wrong. -- This is an automated message from the Apache Git

[GitHub] [pulsar] imaffe commented on a diff in pull request #18951: [improve][fn] support reading config options from file in Function Python Runner

2022-12-22 Thread GitBox
imaffe commented on code in PR #18951: URL: https://github.com/apache/pulsar/pull/18951#discussion_r1055492238 ## pulsar-functions/instance/src/main/python/python_instance_main.py: ## @@ -88,8 +132,10 @@ def main(): parser.add_argument('--extra_dependency_repository',

[GitHub] [pulsar] BewareMyPower commented on issue #19030: [Bug] Deserialized BatchMessageIdImpl cannot be used for acknowledgment

2022-12-22 Thread GitBox
BewareMyPower commented on issue #19030: URL: https://github.com/apache/pulsar/issues/19030#issuecomment-1362843527 The deserialization logic in https://github.com/apache/pulsar/pull/9855 is meaningless.

[GitHub] [pulsar] BewareMyPower opened a new issue, #19030: [Bug] Deserialized BatchMessageIdImpl cannot be used for acknowledgment

2022-12-22 Thread GitBox
BewareMyPower opened a new issue, #19030: URL: https://github.com/apache/pulsar/issues/19030 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version OS: Ubuntu 20.04 Pulsar: master

[GitHub] [pulsar] labuladong commented on pull request #18995: [fix][broker] forbid uploading BYTES schema with admin API

2022-12-22 Thread GitBox
labuladong commented on PR #18995: URL: https://github.com/apache/pulsar/pull/18995#issuecomment-1362830917 Oh there is another test case fail... Let me fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] labuladong commented on a diff in pull request #18995: [fix][broker] forbid uploading BYTES schema with admin API

2022-12-22 Thread GitBox
labuladong commented on code in PR #18995: URL: https://github.com/apache/pulsar/pull/18995#discussion_r1055445675 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiSchemaTest.java: ## @@ -185,6 +185,16 @@ private void testSchemaInfoApi(Schema schema,

[GitHub] [pulsar] labuladong closed pull request #18992: [fix][broker] fix `Topic does not have schema to check` error when create schema consumer

2022-12-22 Thread GitBox
labuladong closed pull request #18992: [fix][broker] fix `Topic does not have schema to check` error when create schema consumer URL: https://github.com/apache/pulsar/pull/18992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] labuladong commented on pull request #18992: [fix][broker] fix `Topic does not have schema to check` error when create schema consumer

2022-12-22 Thread GitBox
labuladong commented on PR #18992: URL: https://github.com/apache/pulsar/pull/18992#issuecomment-1362825664 Close because https://github.com/apache/pulsar/pull/17449 changed to a similar solution. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] labuladong commented on pull request #17449: [fix][broker]Fix using schema to create consumer fails after using AUTO_CONSUME consumer to subscribe topic

2022-12-22 Thread GitBox
labuladong commented on PR #17449: URL: https://github.com/apache/pulsar/pull/17449#issuecomment-1362824456 Hi @Denovo1998! I'm glad that you have this idea too, so I'll close my pr. For your discussion above, my solution is to only count the consumer which specifies a schema:

[pulsar] branch master updated (41edd2ead7e -> f85d591549e)

2022-12-22 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 41edd2ead7e [fix][txn] Correct the prompt message (#17009) add f85d591549e [feat][doc] add Pulsar API content

[GitHub] [pulsar] Anonymitaet merged pull request #19002: [feat][doc] add Pulsar API content

2022-12-22 Thread GitBox
Anonymitaet merged PR #19002: URL: https://github.com/apache/pulsar/pull/19002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] asafm commented on pull request #18116: [PIP-214][broker]Add broker level metrics statistics and expose to prometheus

2022-12-22 Thread GitBox
asafm commented on PR #18116: URL: https://github.com/apache/pulsar/pull/18116#issuecomment-1362810964 @yyj8 You may want to follow [those](https://pulsar.apache.org/contribute/personal-ci/) instructions to have a ready-made fork with a green test. -- This is an automated message from

[pulsar-client-node] branch master updated: Bump async from 3.2.1 to 3.2.4 (#261)

2022-12-22 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git The following commit(s) were added to refs/heads/master by this push: new 4f1c220 Bump async from 3.2.1 to

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
codelipenghui commented on code in PR #19024: URL: https://github.com/apache/pulsar/pull/19024#discussion_r1055412385 ## .asf.yaml: ## @@ -77,11 +77,31 @@ github: branch-2.4: {} branch-2.5: {} branch-2.6: {} -branch-2.7: {} -branch-2.8: {} -

[GitHub] [pulsar-client-node] BewareMyPower merged pull request #261: Bump async from 3.2.1 to 3.2.4

2022-12-22 Thread GitBox
BewareMyPower merged PR #261: URL: https://github.com/apache/pulsar-client-node/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui commented on pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
codelipenghui commented on PR #19024: URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362782517 > Such config change is not one-way effect so you can always try and revert if something unexpected :) Got it. Yes, if we are not able to cherry-pick directly. We can revert

[GitHub] [pulsar] tisonkun commented on pull request #19025: [fix][doc] Stablize swagger docs

2022-12-22 Thread GitBox
tisonkun commented on PR #19025: URL: https://github.com/apache/pulsar/pull/19025#issuecomment-1362781796 OWASP failed on other dependencies that we should handle in different PRs: ``` debezium-connector-mysql-1.9.7.Final.jar: CVE-2017-15945(7.8) Error:

[GitHub] [pulsar-client-cpp] BewareMyPower opened a new pull request, #153: [fix] Fix MessageId serialization when it's a batched message

2022-12-22 Thread GitBox
BewareMyPower opened a new pull request, #153: URL: https://github.com/apache/pulsar-client-cpp/pull/153 ### Motivation The serialization and deserialization of `MessageId` became wrong after https://github.com/apache/pulsar-client-cpp/pull/132. 1. The batch size is not

[GitHub] [pulsar] tisonkun commented on pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
tisonkun commented on PR #19024: URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362780665 @codelipenghui Such config change is not one-way effect so you can always try and revert if something unexpected :) -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] codelipenghui commented on pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
codelipenghui commented on PR #19024: URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362772628 https://user-images.githubusercontent.com/12592133/209132432-cd6766b1-70b6-44b5-836d-705f5c324eda.png;> I have tried it on my fork repo, but I can push the commit to the

[GitHub] [pulsar] codecov-commenter commented on pull request #19029: [improve][client] Check topic pattern when creating consumer

2022-12-22 Thread GitBox
codecov-commenter commented on PR #19029: URL: https://github.com/apache/pulsar/pull/19029#issuecomment-1362766515 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19029?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#41edd2e)

2022-12-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 6501b6df405 Docs sync done from apache/pulsar

[GitHub] [pulsar] tisonkun commented on pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
tisonkun commented on PR #19024: URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362762636 > IIUC `required_pull_request_reviews` infers `Require a pull request before merging` @codelipenghui you can try merge this patch and see if you can direct push to those

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19013: [improve][admin]internalGetMessageById shouldn't be allowed on partitioned topic

2022-12-22 Thread GitBox
Technoboy- commented on code in PR #19013: URL: https://github.com/apache/pulsar/pull/19013#discussion_r1055385473 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java: ## @@ -2763,18 +2763,31 @@ private PositionImpl

[GitHub] [pulsar] codelipenghui commented on pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
codelipenghui commented on PR #19024: URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362740685 @nicoloboschi @tisonkun We will not enforce for every cherry-pick to open a pull request. The committers can push the commit to the release branches after this change. It is to

[GitHub] [pulsar] yuruguo opened a new pull request, #19029: [improve][client] Check topic pattern when creating consumer

2022-12-22 Thread GitBox
yuruguo opened a new pull request, #19029: URL: https://github.com/apache/pulsar/pull/19029 ### Motivation Check `topicsPattern` is not null or empty when invoking `ConsumerBuilder.topicsPattern`. ```java ConsumerBuilder topicsPattern(Pattern topicsPattern); ConsumerBuilder

[GitHub] [pulsar] tisonkun commented on pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
tisonkun commented on PR #19024: URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362725748 @nicoloboschi I support that such restrictions bring more burden than values - we are working in the community, and committers should share a high trust level. It ruins collaborations

[GitHub] [pulsar] tisonkun commented on a diff in pull request #19025: [fix][doc] Stablize swagger docs

2022-12-22 Thread GitBox
tisonkun commented on code in PR #19025: URL: https://github.com/apache/pulsar/pull/19025#discussion_r1055361529 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopicsExt.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [pulsar] nicoloboschi commented on pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
nicoloboschi commented on PR #19024: URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362721394 > @nicoloboschi IIUC `required_pull_request_reviews` infers `Require a pull request before merging` thus it's impossible after this change gets merged. yes that's what I

[GitHub] [pulsar] yuruguo commented on a diff in pull request #19025: [fix][doc] Stablize swagger docs

2022-12-22 Thread GitBox
yuruguo commented on code in PR #19025: URL: https://github.com/apache/pulsar/pull/19025#discussion_r1055358723 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopicsExt.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [pulsar] AlvaroStream commented on a diff in pull request #19019: [improve][doc] Java example explaining code without using lombok

2022-12-22 Thread GitBox
AlvaroStream commented on code in PR #19019: URL: https://github.com/apache/pulsar/pull/19019#discussion_r1055357155 ## site2/docs/schema-understand.md: ## @@ -122,6 +122,11 @@ Pulsar gets the schema definition from the predefined `struct` using an Avro lib 1. Create the

[pulsar] branch master updated (dc29f3a4b6c -> 41edd2ead7e)

2022-12-22 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from dc29f3a4b6c [fix][broker]Update rest api response class (#18965) add 41edd2ead7e [fix][txn] Correct the

[GitHub] [pulsar] nicoloboschi merged pull request #17009: [fix][txn] Correct the prompt message

2022-12-22 Thread GitBox
nicoloboschi merged PR #17009: URL: https://github.com/apache/pulsar/pull/17009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari opened a new pull request, #19028: [fix][client] Prevent DNS reverse lookup when physical address is an IP address

2022-12-22 Thread GitBox
lhotari opened a new pull request, #19028: URL: https://github.com/apache/pulsar/pull/19028 ### Motivation A call to java.net.InetSocketAddress#getHostName will trigger a reverse DNS lookup when the physical address is an IP address. This is not desired since the DNS resolver will

[pulsar-client-node] branch master updated: fix: Add license headers (#262)

2022-12-22 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git The following commit(s) were added to refs/heads/master by this push: new 12e4373 fix: Add license headers

[GitHub] [pulsar-client-node] tisonkun merged pull request #262: Add license headers

2022-12-22 Thread GitBox
tisonkun merged PR #262: URL: https://github.com/apache/pulsar-client-node/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-node] tisonkun commented on pull request #262: Add license headers

2022-12-22 Thread GitBox
tisonkun commented on PR #262: URL: https://github.com/apache/pulsar-client-node/pull/262#issuecomment-1362687109 @nkurihar Anyway, it does no harm :) Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar-client-node] nkurihar commented on pull request #262: Add license headers

2022-12-22 Thread GitBox
nkurihar commented on PR #262: URL: https://github.com/apache/pulsar-client-node/pull/262#issuecomment-1362679032 > I think we don't have to add license header to markdown files. I feel so too, but I'm not sure whether the license is necessarry even for .md files, so I have added

[GitHub] [pulsar-client-node] nkurihar opened a new pull request, #262: Add license headers

2022-12-22 Thread GitBox
nkurihar opened a new pull request, #262: URL: https://github.com/apache/pulsar-client-node/pull/262 Added license headers to some files by executing `npm run license:addheader`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar-client-go] Gleiphir2769 opened a new pull request, #924: [Issue 923] Remove the outdated interface description of `SeekByTime`

2022-12-22 Thread GitBox
Gleiphir2769 opened a new pull request, #924: URL: https://github.com/apache/pulsar-client-go/pull/924 Fixes #923 ### Motivation Remove the outdated interface description of `SeekByTime`. More details here #923. ### Modifications Remove the outdated interface

[GitHub] [pulsar-client-go] Gleiphir2769 opened a new issue, #923: [BUG] Legacy interface description of `SeekByTime`

2022-12-22 Thread GitBox
Gleiphir2769 opened a new issue, #923: URL: https://github.com/apache/pulsar-client-go/issues/923 I noticed that the interface description of `SeekByTime` is outdated.

[GitHub] [pulsar] luweiqianyi commented on issue #18952: [Doc] Deploy docker-compose command is incorrect

2022-12-22 Thread GitBox
luweiqianyi commented on issue #18952: URL: https://github.com/apache/pulsar/issues/18952#issuecomment-1362650371 @liangyepianzhou version: '3' in docker-compose.yml is not correct! 版本不对 是不是你使用 ``` depends_on: zookeeper: condition: service_health

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
codelipenghui commented on code in PR #19024: URL: https://github.com/apache/pulsar/pull/19024#discussion_r1055280721 ## .asf.yaml: ## @@ -77,11 +77,31 @@ github: branch-2.4: {} branch-2.5: {} branch-2.6: {} -branch-2.7: {} -branch-2.8: {} -

[GitHub] [pulsar] luweiqianyi commented on issue #18952: [Doc] Deploy docker-compose command is incorrect

2022-12-22 Thread GitBox
luweiqianyi commented on issue #18952: URL: https://github.com/apache/pulsar/issues/18952#issuecomment-1362626677 @liangyepianzhou when using key words "depends_on" ,as below": ``` depends_on: zookeeper: condition: service_healthy ``` my goland reports

[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #18989: [fix][broker] Fix deadlock in PendingAckHandleImpl

2022-12-22 Thread GitBox
nicoloboschi commented on code in PR #18989: URL: https://github.com/apache/pulsar/pull/18989#discussion_r1053032593 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java: ## @@ -937,18 +937,16 @@ public

[GitHub] [pulsar-client-go] billowqiu commented on pull request #767: Revert "Fix stuck when reconnect broker (#703)"

2022-12-22 Thread GitBox
billowqiu commented on PR #767: URL: https://github.com/apache/pulsar-client-go/pull/767#issuecomment-1362616255 > @billowqiu @zwb1234567 @jiaqingchen Would you mind explaining why you reverted this change in your fork with

[GitHub] [pulsar] codecov-commenter commented on pull request #18986: [improve][io] Elasticsearch sink: Support loading config from secrets

2022-12-22 Thread GitBox
codecov-commenter commented on PR #18986: URL: https://github.com/apache/pulsar/pull/18986#issuecomment-1362603896 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/18986?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] codelipenghui commented on pull request #19024: Update .asf.yaml to avoid merge PRs without approvals to the active release branches

2022-12-22 Thread GitBox
codelipenghui commented on PR #19024: URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362603454 > Is it still possible to directly cherry pick without passing from a pull request? I think so, the change should only affect the new pull request to release branches. --

  1   2   >