BewareMyPower commented on PR #155:
URL:
https://github.com/apache/pulsar-client-cpp/pull/155#issuecomment-1363697773
I tried to build the x64 deb package in my local env, it does not include
the symbols from libcurl or openssl.
```bash
$ nm -D /usr/lib/libpulsar.so | grep curl
Gleiphir2769 opened a new issue, #925:
URL: https://github.com/apache/pulsar-client-go/issues/925
I noticed that the default squash merge message is set from "Default to pull
request title" to "Default message".
Could we use "Default to pull request title" just like before? I think
startjava opened a new issue, #19036:
URL: https://github.com/apache/pulsar/issues/19036
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### What issue do you find in Pulsar docs?
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 1d3499a fix: fix 923 (#924)
1d3499a is
wolfstudy closed issue #923: [BUG] Outdated interface description of
`SeekByTime`
URL: https://github.com/apache/pulsar-client-go/issues/923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wolfstudy merged PR #924:
URL: https://github.com/apache/pulsar-client-go/pull/924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
BewareMyPower opened a new pull request, #155:
URL: https://github.com/apache/pulsar-client-cpp/pull/155
### Motivation
Currently the released libraries don't hide the symbols from the
dependencies, it can be verified by the following steps on Ubuntu:
```bash
curl -O -L
congbobo184 commented on code in PR #19017:
URL: https://github.com/apache/pulsar/pull/19017#discussion_r1056093208
##
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##
@@ -1269,14 +1269,15 @@ public long
This is an automated email from the ASF dual-hosted git repository.
yuruguo pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
from 38053b5d1ba [improve][io] Debezium sources: Support loading config
from secrets (#19004)
add aaf3a9a9a74
yuruguo merged PR #19029:
URL: https://github.com/apache/pulsar/pull/19029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
xyz pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git
from fa3ac76 [feat] PIP 107: Introduce chunk message ID (#148)
add 97af35a fix auxv header (#152)
No new
BewareMyPower merged PR #152:
URL: https://github.com/apache/pulsar-client-cpp/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
BewareMyPower commented on PR #153:
URL:
https://github.com/apache/pulsar-client-cpp/pull/153#issuecomment-1363572861
@shibd I see. I will fix it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.11 by this push:
new 6748d93c2e3 [fix][client] Fix
shibd commented on PR #153:
URL:
https://github.com/apache/pulsar-client-cpp/pull/153#issuecomment-1363559609
@BewareMyPower It seems that compilation does not pass in the macOS
environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Author: zike
Date: Fri Dec 23 02:46:33 2022
New Revision: 58877
Log:
Staging artifacts and signature for Pulsar Node.js client release
1.8.0-candidate-2
Added:
dev/pulsar/pulsar-client-node/pulsar-client-node-1.8.0-candidate-2/
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
from 513e6719357 Revert "Update .asf.yaml to avoid merge PRs without
approvals to the active release branches (#19024)
Technoboy- merged PR #19004:
URL: https://github.com/apache/pulsar/pull/19004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
zike pushed a change to annotated tag v1.8.0-rc.2
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git
*** WARNING: tag v1.8.0-rc.2 was modified! ***
from 0ce9cd0 (commit)
to f20e638 (tag)
This is an automated email from the ASF dual-hosted git repository.
zike pushed a commit to branch branch-1.8
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git
commit 0ce9cd0606cd94eeb6c2242e7c810db8ffbef545
Author: nkurihar
AuthorDate: Thu Dec 22 21:32:53 2022 +0900
This is an automated email from the ASF dual-hosted git repository.
zike pushed a change to branch branch-1.8
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git
from a33f615 [refactor] Refactor the cpp client version controlling in the
build script (#259)
new
This is an automated email from the ASF dual-hosted git repository.
zike pushed a commit to branch branch-1.8
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git
commit 341ec92651447ae57e0a3a31e03df9b2191acf05
Author: nkurihar
AuthorDate: Thu Dec 22 19:47:27 2022 +0900
BewareMyPower commented on code in PR #154:
URL: https://github.com/apache/pulsar-client-cpp/pull/154#discussion_r1055983371
##
include/pulsar/ConsumerConfiguration.h:
##
@@ -383,6 +383,26 @@ class PULSAR_PUBLIC ConsumerConfiguration {
*/
InitialPosition
codecov-commenter commented on PR #19028:
URL: https://github.com/apache/pulsar/pull/19028#issuecomment-1363537054
#
[Codecov](https://codecov.io/gh/apache/pulsar/pull/19028?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
github-actions[bot] commented on issue #18300:
URL: https://github.com/apache/pulsar/issues/18300#issuecomment-1363536189
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on issue #18507:
URL: https://github.com/apache/pulsar/issues/18507#issuecomment-1363536094
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on PR #18518:
URL: https://github.com/apache/pulsar/pull/18518#issuecomment-1363536060
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
codelipenghui merged PR #19034:
URL: https://github.com/apache/pulsar/pull/19034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 513e6719357 Revert "Update .asf.yaml to avoid
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 64caf495a71 [fix][broker] Fix thread safety
Technoboy- merged PR #19021:
URL: https://github.com/apache/pulsar/pull/19021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Technoboy- closed pull request #19028: [fix][client] Prevent DNS reverse lookup
when physical address is an IP address
URL: https://github.com/apache/pulsar/pull/19028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
coderzc opened a new pull request, #19035:
URL: https://github.com/apache/pulsar/pull/19035
PIP: #16763
### Motivation
#16763
### Modifications
Implement Filter out all delayed messages and skip them when reading
messages from bookies
### Verifying
shibd opened a new pull request, #154:
URL: https://github.com/apache/pulsar-client-cpp/pull/154
### Motivation
In the current implementation, Reader does not yet support partitioned
topics.
### Modifications
- ConsumerConfig support set `subscriptionMode`.
-
labuladong commented on issue #18925:
URL: https://github.com/apache/pulsar/issues/18925#issuecomment-1363492572
I have investigated the source code, and I reproduced that the partitioned
topics cannot be auto-deleted.
It seems we only store partitioned topic metadata in zk instead
tisonkun commented on PR #19033:
URL: https://github.com/apache/pulsar/pull/19033#issuecomment-1363489929
Emmm...IIRC we have another thread having consensus on such move but the
link you share here has no response. Thus I'll hold this PR before I saw the
consensus or we follow lazy
tisonkun commented on PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1363487804
> Interesting, why changing the configuration via the GitHub Settings works.
@codelipenghui It's possible that you're the admin of your fork and bypass
the protect rules.
codelipenghui opened a new pull request, #19034:
URL: https://github.com/apache/pulsar/pull/19034
### Motivation
See: https://github.com/apache/pulsar/pull/19024#issuecomment-1363480874
### Modifications
Revert #19024
### Does this pull request potentially affect
codelipenghui commented on PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1363480874
Bad news:
```
~/GitHub/apache/incubator-pulsar (branch-2.11) » git push apache branch-2.11
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 849bea659e0 Update .asf.yaml to avoid merge
codelipenghui merged PR #19024:
URL: https://github.com/apache/pulsar/pull/19024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
michaeljmarshall opened a new pull request, #19033:
URL: https://github.com/apache/pulsar/pull/19033
### Motivation
Mailing list thread: TBD
When we first introduced GitHub discussions, we had their notifications go
to the dev@ list. That has produced many notifications, and
lhotari commented on issue #19032:
URL: https://github.com/apache/pulsar/issues/19032#issuecomment-1363249375
might be related to #13964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lhotari opened a new issue, #19032:
URL: https://github.com/apache/pulsar/issues/19032
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Example failure
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new cf2b15d317e Docs sync done from apache/pulsar
eolivelli opened a new issue, #11037:
URL: https://github.com/apache/pulsar/issues/11037
```
java.lang.NullPointerException: NPE when using schema null : null
at
org.apache.pulsar.client.impl.schema.PrimitiveSchemaTest.allSchemasShouldRoundtripInput(PrimitiveSchemaTest.java:132)
lhotari commented on issue #11037:
URL: https://github.com/apache/pulsar/issues/11037#issuecomment-1363186408
There's a similar flaky test issue that exists in master branch.
example:
https://github.com/apache/pulsar/actions/runs/3759470154/jobs/6389256559#step:10:600
```
codecov-commenter commented on PR #19021:
URL: https://github.com/apache/pulsar/pull/19021#issuecomment-1363133163
#
[Codecov](https://codecov.io/gh/apache/pulsar/pull/19021?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
lhotari commented on code in PR #19021:
URL: https://github.com/apache/pulsar/pull/19021#discussion_r1055637524
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##
@@ -1330,10 +1322,15 @@ protected void
lhotari commented on PR #19021:
URL: https://github.com/apache/pulsar/pull/19021#issuecomment-1363045381
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
BewareMyPower commented on PR #19031:
URL: https://github.com/apache/pulsar/pull/19031#issuecomment-1362999460
More explanations to the refactoring parts of this PR:
1. I don't want to handle the list cumulative acknowledgment. Pulsar never
supports this operation. There is no
BewareMyPower opened a new pull request, #19031:
URL: https://github.com/apache/pulsar/pull/19031
Fixes https://github.com/apache/pulsar/issues/19030
### Motivation
When a `BatchMessageIdImpl` is created from a deserialization, the
`BatchMessageAcker` object cannot be shared
imaffe commented on PR #18643:
URL: https://github.com/apache/pulsar/pull/18643#issuecomment-1362876147
@freeznet Hi Rui,can you mark this PR as ready-to-test ? I want to kick off
the test process to see if anything goes wrong.
--
This is an automated message from the Apache Git
imaffe commented on code in PR #18951:
URL: https://github.com/apache/pulsar/pull/18951#discussion_r1055492238
##
pulsar-functions/instance/src/main/python/python_instance_main.py:
##
@@ -88,8 +132,10 @@ def main():
parser.add_argument('--extra_dependency_repository',
BewareMyPower commented on issue #19030:
URL: https://github.com/apache/pulsar/issues/19030#issuecomment-1362843527
The deserialization logic in https://github.com/apache/pulsar/pull/9855 is
meaningless.
BewareMyPower opened a new issue, #19030:
URL: https://github.com/apache/pulsar/issues/19030
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Version
OS: Ubuntu 20.04
Pulsar: master
labuladong commented on PR #18995:
URL: https://github.com/apache/pulsar/pull/18995#issuecomment-1362830917
Oh there is another test case fail... Let me fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
labuladong commented on code in PR #18995:
URL: https://github.com/apache/pulsar/pull/18995#discussion_r1055445675
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiSchemaTest.java:
##
@@ -185,6 +185,16 @@ private void testSchemaInfoApi(Schema schema,
labuladong closed pull request #18992: [fix][broker] fix `Topic does not have
schema to check` error when create schema consumer
URL: https://github.com/apache/pulsar/pull/18992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
labuladong commented on PR #18992:
URL: https://github.com/apache/pulsar/pull/18992#issuecomment-1362825664
Close because https://github.com/apache/pulsar/pull/17449 changed to a
similar solution.
--
This is an automated message from the Apache Git Service.
To respond to the message,
labuladong commented on PR #17449:
URL: https://github.com/apache/pulsar/pull/17449#issuecomment-1362824456
Hi @Denovo1998! I'm glad that you have this idea too, so I'll close my pr.
For your discussion above, my solution is to only count the consumer which
specifies a schema:
This is an automated email from the ASF dual-hosted git repository.
liuyu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
from 41edd2ead7e [fix][txn] Correct the prompt message (#17009)
add f85d591549e [feat][doc] add Pulsar API content
Anonymitaet merged PR #19002:
URL: https://github.com/apache/pulsar/pull/19002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
asafm commented on PR #18116:
URL: https://github.com/apache/pulsar/pull/18116#issuecomment-1362810964
@yyj8 You may want to follow
[those](https://pulsar.apache.org/contribute/personal-ci/) instructions to have
a ready-made fork with a green test.
--
This is an automated message from
This is an automated email from the ASF dual-hosted git repository.
xyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git
The following commit(s) were added to refs/heads/master by this push:
new 4f1c220 Bump async from 3.2.1 to
codelipenghui commented on code in PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#discussion_r1055412385
##
.asf.yaml:
##
@@ -77,11 +77,31 @@ github:
branch-2.4: {}
branch-2.5: {}
branch-2.6: {}
-branch-2.7: {}
-branch-2.8: {}
-
BewareMyPower merged PR #261:
URL: https://github.com/apache/pulsar-client-node/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
codelipenghui commented on PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362782517
> Such config change is not one-way effect so you can always try and revert
if something unexpected :)
Got it. Yes, if we are not able to cherry-pick directly. We can revert
tisonkun commented on PR #19025:
URL: https://github.com/apache/pulsar/pull/19025#issuecomment-1362781796
OWASP failed on other dependencies that we should handle in different PRs:
```
debezium-connector-mysql-1.9.7.Final.jar: CVE-2017-15945(7.8)
Error:
BewareMyPower opened a new pull request, #153:
URL: https://github.com/apache/pulsar-client-cpp/pull/153
### Motivation
The serialization and deserialization of `MessageId` became wrong after
https://github.com/apache/pulsar-client-cpp/pull/132.
1. The batch size is not
tisonkun commented on PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362780665
@codelipenghui Such config change is not one-way effect so you can always
try and revert if something unexpected :)
--
This is an automated message from the Apache Git Service.
To
codelipenghui commented on PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362772628
https://user-images.githubusercontent.com/12592133/209132432-cd6766b1-70b6-44b5-836d-705f5c324eda.png;>
I have tried it on my fork repo, but I can push the commit to the
codecov-commenter commented on PR #19029:
URL: https://github.com/apache/pulsar/pull/19029#issuecomment-1362766515
#
[Codecov](https://codecov.io/gh/apache/pulsar/pull/19029?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new 6501b6df405 Docs sync done from apache/pulsar
tisonkun commented on PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362762636
> IIUC `required_pull_request_reviews` infers `Require a pull request before
merging`
@codelipenghui you can try merge this patch and see if you can direct push
to those
Technoboy- commented on code in PR #19013:
URL: https://github.com/apache/pulsar/pull/19013#discussion_r1055385473
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##
@@ -2763,18 +2763,31 @@ private PositionImpl
codelipenghui commented on PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362740685
@nicoloboschi @tisonkun We will not enforce for every cherry-pick to open a
pull request. The committers can push the commit to the release branches after
this change. It is to
yuruguo opened a new pull request, #19029:
URL: https://github.com/apache/pulsar/pull/19029
### Motivation
Check `topicsPattern` is not null or empty when invoking
`ConsumerBuilder.topicsPattern`.
```java
ConsumerBuilder topicsPattern(Pattern topicsPattern);
ConsumerBuilder
tisonkun commented on PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362725748
@nicoloboschi I support that such restrictions bring more burden than values
- we are working in the community, and committers should share a high trust
level. It ruins collaborations
tisonkun commented on code in PR #19025:
URL: https://github.com/apache/pulsar/pull/19025#discussion_r1055361529
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopicsExt.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation
nicoloboschi commented on PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362721394
> @nicoloboschi IIUC `required_pull_request_reviews` infers `Require a pull
request before merging` thus it's impossible after this change gets merged.
yes that's what I
yuruguo commented on code in PR #19025:
URL: https://github.com/apache/pulsar/pull/19025#discussion_r1055358723
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopicsExt.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation
AlvaroStream commented on code in PR #19019:
URL: https://github.com/apache/pulsar/pull/19019#discussion_r1055357155
##
site2/docs/schema-understand.md:
##
@@ -122,6 +122,11 @@ Pulsar gets the schema definition from the predefined
`struct` using an Avro lib
1. Create the
This is an automated email from the ASF dual-hosted git repository.
nicoloboschi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
from dc29f3a4b6c [fix][broker]Update rest api response class (#18965)
add 41edd2ead7e [fix][txn] Correct the
nicoloboschi merged PR #17009:
URL: https://github.com/apache/pulsar/pull/17009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lhotari opened a new pull request, #19028:
URL: https://github.com/apache/pulsar/pull/19028
### Motivation
A call to java.net.InetSocketAddress#getHostName will trigger a reverse DNS
lookup when the physical address is an IP address. This is not desired since
the DNS resolver will
This is an automated email from the ASF dual-hosted git repository.
tison pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git
The following commit(s) were added to refs/heads/master by this push:
new 12e4373 fix: Add license headers
tisonkun merged PR #262:
URL: https://github.com/apache/pulsar-client-node/pull/262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tisonkun commented on PR #262:
URL:
https://github.com/apache/pulsar-client-node/pull/262#issuecomment-1362687109
@nkurihar Anyway, it does no harm :)
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
nkurihar commented on PR #262:
URL:
https://github.com/apache/pulsar-client-node/pull/262#issuecomment-1362679032
> I think we don't have to add license header to markdown files.
I feel so too, but I'm not sure whether the license is necessarry even for
.md files, so I have added
nkurihar opened a new pull request, #262:
URL: https://github.com/apache/pulsar-client-node/pull/262
Added license headers to some files by executing `npm run license:addheader`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Gleiphir2769 opened a new pull request, #924:
URL: https://github.com/apache/pulsar-client-go/pull/924
Fixes #923
### Motivation
Remove the outdated interface description of `SeekByTime`. More details here
#923.
### Modifications
Remove the outdated interface
Gleiphir2769 opened a new issue, #923:
URL: https://github.com/apache/pulsar-client-go/issues/923
I noticed that the interface description of `SeekByTime` is outdated.
luweiqianyi commented on issue #18952:
URL: https://github.com/apache/pulsar/issues/18952#issuecomment-1362650371
@liangyepianzhou version: '3' in docker-compose.yml is not correct! 版本不对
是不是你使用
```
depends_on:
zookeeper:
condition: service_health
codelipenghui commented on code in PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#discussion_r1055280721
##
.asf.yaml:
##
@@ -77,11 +77,31 @@ github:
branch-2.4: {}
branch-2.5: {}
branch-2.6: {}
-branch-2.7: {}
-branch-2.8: {}
-
luweiqianyi commented on issue #18952:
URL: https://github.com/apache/pulsar/issues/18952#issuecomment-1362626677
@liangyepianzhou when using key words "depends_on" ,as below":
```
depends_on:
zookeeper:
condition: service_healthy
```
my goland reports
nicoloboschi commented on code in PR #18989:
URL: https://github.com/apache/pulsar/pull/18989#discussion_r1053032593
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##
@@ -937,18 +937,16 @@ public
billowqiu commented on PR #767:
URL: https://github.com/apache/pulsar-client-go/pull/767#issuecomment-1362616255
> @billowqiu @zwb1234567 @jiaqingchen Would you mind explaining why you
reverted this change in your fork with
codecov-commenter commented on PR #18986:
URL: https://github.com/apache/pulsar/pull/18986#issuecomment-1362603896
#
[Codecov](https://codecov.io/gh/apache/pulsar/pull/18986?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
codelipenghui commented on PR #19024:
URL: https://github.com/apache/pulsar/pull/19024#issuecomment-1362603454
> Is it still possible to directly cherry pick without passing from a pull
request?
I think so, the change should only affect the new pull request to release
branches.
--
1 - 100 of 107 matches
Mail list logo