[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #169: [feat] Add producer interceptor

2023-01-10 Thread GitBox
BewareMyPower commented on code in PR #169: URL: https://github.com/apache/pulsar-client-cpp/pull/169#discussion_r1066672106 ## include/pulsar/ProducerConfiguration.h: ## @@ -532,6 +533,10 @@ class PULSAR_PUBLIC ProducerConfiguration { */ ProducerAccessMode

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #18810: [improve][broker] PIP-192: Implement broker registry for new load manager

2023-01-10 Thread GitBox
heesung-sn commented on code in PR #18810: URL: https://github.com/apache/pulsar/pull/18810#discussion_r1066671971 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-10 Thread GitBox
tisonkun commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r108265 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,106 @@ +--- +author: Apache Pulsar Community +title: "Apache Pulsar 2022 Year in Review" +date:

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #169: [feat] Add producer interceptor

2023-01-10 Thread GitBox
BewareMyPower commented on code in PR #169: URL: https://github.com/apache/pulsar-client-cpp/pull/169#discussion_r1066671800 ## include/pulsar/ProducerConfiguration.h: ## @@ -532,6 +533,10 @@ class PULSAR_PUBLIC ProducerConfiguration { */ ProducerAccessMode

[GitHub] [pulsar-client-node] shibd commented on a diff in pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-10 Thread GitBox
shibd commented on code in PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#discussion_r1066658153 ## pkg/mac/build-cpp-deps-lib.sh: ## @@ -166,13 +167,18 @@ if [ ! -f curl-${CURL_VERSION}.done ]; then curl -O -L

[GitHub] [pulsar] lhotari commented on issue #10816: PulsarProxy does not always refresh authentication tokens received from client

2023-01-10 Thread GitBox
lhotari commented on issue #10816: URL: https://github.com/apache/pulsar/issues/10816#issuecomment-1378355110 > You're referring to the final process, not lookup process, there are two connections between `connect to broker` and `lookup`. @nodece I'm not exactly sure what you mean

[GitHub] [pulsar-client-node] shibd commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-10 Thread GitBox
shibd commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1378349565 > @shibd BTW, I'm not sure whether we can provide the Pulsar.node to test. Though we have the Pulsar.node, there is no document to describe how to use it. I think we should

[GitHub] [pulsar-client-cpp] RobertIndie commented on a diff in pull request #169: [feat] Add producer interceptor

2023-01-10 Thread GitBox
RobertIndie commented on code in PR #169: URL: https://github.com/apache/pulsar-client-cpp/pull/169#discussion_r1066656516 ## include/pulsar/ProducerConfiguration.h: ## @@ -532,6 +533,10 @@ class PULSAR_PUBLIC ProducerConfiguration { */ ProducerAccessMode

[GitHub] [pulsar] lhotari commented on issue #10816: PulsarProxy does not always refresh authentication tokens received from client

2023-01-10 Thread GitBox
lhotari commented on issue #10816: URL: https://github.com/apache/pulsar/issues/10816#issuecomment-1378334788 @nodece since #17831 is already merged, I guess PR #18130 is where there should be proper problem description. Please improve it. -- This is an automated message from the Apache

[GitHub] [pulsar] lhotari commented on issue #10816: PulsarProxy does not always refresh authentication tokens received from client

2023-01-10 Thread GitBox
lhotari commented on issue #10816: URL: https://github.com/apache/pulsar/issues/10816#issuecomment-1378332387 > I fixed the lookup action by #17831. @nodece Please add the proper problem description to PR #17831. It will be easier to review the PR when there's a clear description of

[GitHub] [pulsar-site] Sherlock113 commented on pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-10 Thread GitBox
Sherlock113 commented on PR #371: URL: https://github.com/apache/pulsar-site/pull/371#issuecomment-1378327716 I removed the ecosystem tools provided by vendor and updated the blog. Thank you all for your review! Let me know if you have other questions. @tisonkun @eolivelli @lhotari

[GitHub] [pulsar] mattisonchao commented on pull request #19182: [cleanup][broker] Remove AuthorizationProvider methods deprecated in 2.7 and 2.9

2023-01-10 Thread GitBox
mattisonchao commented on PR #19182: URL: https://github.com/apache/pulsar/pull/19182#issuecomment-1378326118 Oh, I saw the label. Please ignore my comment first sentence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar-site] Sherlock113 commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-10 Thread GitBox
Sherlock113 commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1066630757 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,109 @@ +--- +author: Apache Pulsar Community +title: "Apache Pulsar 2022 Year in Review" +date:

[GitHub] [pulsar-site] Sherlock113 commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-10 Thread GitBox
Sherlock113 commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1066630440 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,109 @@ +--- +author: Apache Pulsar Community +title: "Apache Pulsar 2022 Year in Review" +date:

[GitHub] [pulsar-site] Sherlock113 commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-10 Thread GitBox
Sherlock113 commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1066630151 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,109 @@ +--- +author: Apache Pulsar Community +title: "Apache Pulsar 2022 Year in Review" +date:

[GitHub] [pulsar-site] Sherlock113 commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-10 Thread GitBox
Sherlock113 commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1066630028 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,109 @@ +--- +author: Apache Pulsar Community +title: "Apache Pulsar 2022 Year in Review" +date:

[GitHub] [pulsar-site] Sherlock113 commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-10 Thread GitBox
Sherlock113 commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1066629672 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,109 @@ +--- +author: Apache Pulsar Community +title: "Apache Pulsar 2022 Year in Review" +date:

[GitHub] [pulsar] lifepuzzlefun commented on pull request #18550: [fix][ml] Ensure ManagedLedger readEntryOps can be finished within `readEntryTimeoutSeconds`

2023-01-10 Thread GitBox
lifepuzzlefun commented on PR #18550: URL: https://github.com/apache/pulsar/pull/18550#issuecomment-1378304809 @tisonkun @eolivelli thanks for reply. I have rebase the current master code and add a new unit test for modify code. please take a look -- This is an automated message from

[GitHub] [pulsar] lhotari commented on issue #11037: Flaky-test: org.apache.pulsar.client.impl.schema.PrimitiveSchemaTest.allSchemasShouldSupportNull and allSchemasShouldRoundtripInput

2023-01-10 Thread GitBox
lhotari commented on issue #11037: URL: https://github.com/apache/pulsar/issues/11037#issuecomment-1378304476 another in https://github.com/apache/pulsar/actions/runs/3889639700/jobs/6638163973#step:11:593 ``` Error: Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed:

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-10 Thread GitBox
gaoran10 commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066615515 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-10 Thread GitBox
gaoran10 commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066615515 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-10 Thread GitBox
gaoran10 commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066610154 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-10 Thread GitBox
gaoran10 commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066601386 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/CombinedSegmentDelayedIndexQueue.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar-client-node] BewareMyPower commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-10 Thread GitBox
BewareMyPower commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1378275629 @ericallam You can follow the guide [here](https://github.com/apache/pulsar-client-node#how-to-build) (make sure this PR is included): ```bash

[GitHub] [pulsar-client-node] ericallam commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-10 Thread GitBox
ericallam commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1378262381 What's the best way for me to test this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] izumo27 commented on issue #19164: Enable tls hostname verification in c++ client it is failing but works with java client

2023-01-10 Thread GitBox
izumo27 commented on issue #19164: URL: https://github.com/apache/pulsar/issues/19164#issuecomment-1378261774 I found the same problem and I'm trying to fix it in this PR. https://github.com/apache/pulsar-client-cpp/pull/126 FYI c++ client was separated from pulsar repository

[GitHub] [pulsar-site] tisonkun commented on pull request #374: [build][pytools] Build site and precommit

2023-01-10 Thread GitBox
tisonkun commented on PR #374: URL: https://github.com/apache/pulsar-site/pull/374#issuecomment-1378254036 CI preview looks good: https://user-images.githubusercontent.com/18818196/211723619-a4b882cc-a91e-42b6-a593-f9734c2ac989.png;>

[GitHub] [pulsar-site] tisonkun opened a new pull request, #374: [build][pytools] Build site and precommit

2023-01-10 Thread GitBox
tisonkun opened a new pull request, #374: URL: https://github.com/apache/pulsar-site/pull/374 * This closes https://github.com/apache/pulsar/issues/19186. * This closes https://github.com/apache/pulsar/issues/19185. -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19184: [fix][broker] Always pass subName for subscription operations

2023-01-10 Thread GitBox
michaeljmarshall opened a new pull request, #19184: URL: https://github.com/apache/pulsar/pull/19184 ### Motivation When a DLQ producer connects, it creates a subscription when configured to do so. The `subscriptionName` should be passed to the `authorizationProvider` to properly

[GitHub] [pulsar] codecov-commenter commented on pull request #19182: [cleanup][broker] Remove AuthorizationProvider methods deprecated in 2.7 and 2.9

2023-01-10 Thread GitBox
codecov-commenter commented on PR #19182: URL: https://github.com/apache/pulsar/pull/19182#issuecomment-1378238349 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19182?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-10 Thread GitBox
michaeljmarshall commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1066569322 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -687,73 +689,93 @@ private void completeConnect(int clientProtoVersion,

[pulsar] branch master updated (74313816826 -> 932023da50a)

2023-01-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 74313816826 [improve][broker] Add ref count for sticky hash to optimize the performance of Key_Shared

[GitHub] [pulsar] michaeljmarshall merged pull request #19176: [cleanup][broker] Pass subName to authz provider on unsubscribe

2023-01-10 Thread GitBox
michaeljmarshall merged PR #19176: URL: https://github.com/apache/pulsar/pull/19176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] michaeljmarshall commented on pull request #19176: [cleanup][broker] Pass subName to authz provider on unsubscribe

2023-01-10 Thread GitBox
michaeljmarshall commented on PR #19176: URL: https://github.com/apache/pulsar/pull/19176#issuecomment-1378233492 @mattisonchao - I am working on a more general test to cover more cases. Before that, I am doing some cleanup of the authorization code base. I created an issue to improve the

[GitHub] [pulsar] michaeljmarshall opened a new issue, #19183: Improve testing for authorization to prevent regressions in topic operations related to subscriptions

2023-01-10 Thread GitBox
michaeljmarshall opened a new issue, #19183: URL: https://github.com/apache/pulsar/issues/19183 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation In PR

[GitHub] [pulsar] fregate commented on issue #12628: Could not complete the operation. Number of retries has been exhausted. Failed reason: Maximum redirect reached: 5

2023-01-10 Thread GitBox
fregate commented on issue #12628: URL: https://github.com/apache/pulsar/issues/12628#issuecomment-137813 Something broke inside pulsarconf or pulsardata mounts in docker. Removed all corresponding data and create new image installation fix this. But it very suspicious for me - it has

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19182: [cleanup][broker] Remove AuthorizationProvider methods deprecated in 2.7

2023-01-10 Thread GitBox
michaeljmarshall opened a new pull request, #19182: URL: https://github.com/apache/pulsar/pull/19182 ### Motivation We have many methods in the `AuthorizationProvider` interface that have been annotated with `@Deprecated` for since the 2.7.0 release. The PR that deprecated these

[GitHub] [pulsar] liangyepianzhou opened a new pull request, #19181: upgrade bookkeeper for branch-2.10

2023-01-10 Thread GitBox
liangyepianzhou opened a new pull request, #19181: URL: https://github.com/apache/pulsar/pull/19181 Fixes https://github.com/liangyepianzhou/pulsar/actions/runs/3889405613/jobs/6637633408 ### Motivation & Modification Upgrade the version of the bookkeeper to resolve the compile

[GitHub] [pulsar] codecov-commenter commented on pull request #19180: [cleanup][broker] AuthorizationService deprecate unused blocking methods

2023-01-10 Thread GitBox
codecov-commenter commented on PR #19180: URL: https://github.com/apache/pulsar/pull/19180#issuecomment-1378208048 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19180?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar-site] Technoboy- opened a new pull request, #373: [Don't merge] Update release note

2023-01-10 Thread GitBox
Technoboy- opened a new pull request, #373: URL: https://github.com/apache/pulsar-site/pull/373 ### Motivation As released 2.11.0, add release note for it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[pulsar-site] 01/01: Update release note

2023-01-10 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch release-2.11.0 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit f87d46889cf9614e2b91d7a31e652e6765b956de Author: Jiwe Guo AuthorDate: Wed Jan 11 11:38:57 2023 +0800

[pulsar-site] branch release-2.11.0 created (now f87d46889cf)

2023-01-10 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch release-2.11.0 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at f87d46889cf Update release note This branch includes the following new commits: new

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19180: [cleanup][broker] AuthorizationService deprecate unused blocking methods

2023-01-10 Thread GitBox
michaeljmarshall opened a new pull request, #19180: URL: https://github.com/apache/pulsar/pull/19180 ### Motivation With the acceptance of PIP 149, we've made a clear move to remove blocking calls in the Pulsar code base. The `AuthorizationService` has some unused methods that

[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #171: [fix] Fix missing schema related function definitions

2023-01-10 Thread GitBox
BewareMyPower commented on PR #171: URL: https://github.com/apache/pulsar-client-cpp/pull/171#issuecomment-1378192914 Please fix the code style, see https://github.com/apache/pulsar-client-cpp#requirements-for-contributors. -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #81: Add a version attribute

2023-01-10 Thread GitBox
BewareMyPower commented on code in PR #81: URL: https://github.com/apache/pulsar-client-python/pull/81#discussion_r1066537842 ## pkg/mac/build-mac-wheels.sh: ## @@ -25,7 +25,7 @@ cd "${ROOT_DIR}" source pkg/mac/common.sh -PYTHON_CLIENT_VERSION=$(cat version.txt | xargs)

[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #81: Add a version attribute

2023-01-10 Thread GitBox
BewareMyPower commented on code in PR #81: URL: https://github.com/apache/pulsar-client-python/pull/81#discussion_r1066536574 ## pulsar/__about__.py: ## @@ -0,0 +1 @@ +__version__='3.1.0a1' Review Comment: Please add the license in this file. Unfortunately the current CI

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-10 Thread GitBox
poorbarcode commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066530809 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/CombinedSegmentDelayedIndexQueue.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[pulsar] branch branch-2.9 updated: [improve][broker] Add ref count for sticky hash to optimize the performance of Key_Shared subscription (#19167)

2023-01-10 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.9 by this push: new e310713be43 [improve][broker] Add ref

[pulsar] branch branch-2.10 updated: [improve][broker] Add ref count for sticky hash to optimize the performance of Key_Shared subscription (#19167)

2023-01-10 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 0ac194b0a0b [improve][broker] Add

[pulsar-site] branch main updated: Indicate metrics are reset upon restart and mark the ones the don't (#363)

2023-01-10 Thread junma
This is an automated email from the ASF dual-hosted git repository. junma pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new ffac3c899ea Indicate metrics are reset upon

[GitHub] [pulsar-site] momo-jun merged pull request #363: Indicate metrics are reset upon restart and mark the ones the don't

2023-01-10 Thread GitBox
momo-jun merged PR #363: URL: https://github.com/apache/pulsar-site/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch branch-2.11 updated: [improve][broker] Add ref count for sticky hash to optimize the performance of Key_Shared subscription (#19167)

2023-01-10 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 41bb1b0c473 [improve][broker] Add

[GitHub] [pulsar-client-node] BewareMyPower commented on a diff in pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-10 Thread GitBox
BewareMyPower commented on code in PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#discussion_r1066521533 ## pkg/mac/build-cpp-deps-lib.sh: ## @@ -166,13 +167,18 @@ if [ ! -f curl-${CURL_VERSION}.done ]; then curl -O -L

[pulsar] branch master updated: [improve][broker] Add ref count for sticky hash to optimize the performance of Key_Shared subscription (#19167)

2023-01-10 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 74313816826 [improve][broker] Add ref count

[GitHub] [pulsar] codelipenghui merged pull request #19167: [improve][broker] Add ref count for sticky hash to optimize the performance of Key_Shared subscription

2023-01-10 Thread GitBox
codelipenghui merged PR #19167: URL: https://github.com/apache/pulsar/pull/19167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-node] BewareMyPower commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-10 Thread GitBox
BewareMyPower commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1378174963 I think we need to wait for the feedback from @ericallam. > use Apple's SSL/TLS implementation instead of OpenSSL: It does not make sense to me. Can you

[GitHub] [pulsar] github-actions[bot] commented on pull request #19179: [improve][branch-2.10]upgrade the bookkeeper version to 4.14.6

2023-01-10 Thread GitBox
github-actions[bot] commented on PR #19179: URL: https://github.com/apache/pulsar/pull/19179#issuecomment-137817 @horizonzy Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ]

[GitHub] [pulsar] horizonzy opened a new pull request, #19179: [improve][branch-2.10]upgrade the bookkeeper version to 4.14.6

2023-01-10 Thread GitBox
horizonzy opened a new pull request, #19179: URL: https://github.com/apache/pulsar/pull/19179 Fixes #xyz Master Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change

[GitHub] [pulsar] horizonzy opened a new pull request, #19178: [improve][branch-2.9]upgrade the bookkeeper version to 4.14.6

2023-01-10 Thread GitBox
horizonzy opened a new pull request, #19178: URL: https://github.com/apache/pulsar/pull/19178 Fixes #xyz Master Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change

[GitHub] [pulsar] horizonzy opened a new pull request, #19177: [improve][branch-2.8]Upgrade the bk version to 4.14.6

2023-01-10 Thread GitBox
horizonzy opened a new pull request, #19177: URL: https://github.com/apache/pulsar/pull/19177 Fixes #xyz Master Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change

[GitHub] [pulsar] nodece commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-10 Thread GitBox
nodece commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1066522428 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -687,73 +689,93 @@ private void completeConnect(int clientProtoVersion, String

[GitHub] [pulsar] nodece commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-10 Thread GitBox
nodece commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1066521846 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -687,73 +689,93 @@ private void completeConnect(int clientProtoVersion, String

[GitHub] [pulsar-client-node] BewareMyPower commented on a diff in pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-10 Thread GitBox
BewareMyPower commented on code in PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#discussion_r1066521533 ## pkg/mac/build-cpp-deps-lib.sh: ## @@ -166,13 +167,18 @@ if [ ! -f curl-${CURL_VERSION}.done ]; then curl -O -L

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

2023-01-10 Thread GitBox
Nicklee007 commented on PR #16780: URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1378168738 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pulsar-site] 01/02: ci: speed up license header checker

2023-01-10 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit b2edc8d0a3c45eedda3cb724e3019be8ed0689cf Author: tison AuthorDate: Wed Jan 11 09:50:01 2023 +0800 ci: speed up

[pulsar-site] branch main updated (34b95183f76 -> 850394e2619)

2023-01-10 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from 34b95183f76 Docs sync done from apache/pulsar (#dda1437) new b2edc8d0a3c ci: speed up license header checker

[pulsar-site] 02/02: ci: run sync-without-push separately

2023-01-10 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit 850394e2619873441b531a66de4d3ebd36e50d4e Author: tison AuthorDate: Wed Jan 11 09:53:26 2023 +0800 ci: run

[GitHub] [pulsar-site] tisonkun merged pull request #372: ci: run sync-without-push separately

2023-01-10 Thread GitBox
tisonkun merged PR #372: URL: https://github.com/apache/pulsar-site/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] github-actions[bot] commented on pull request #18073: [fix][txn] Port for master "Use PulsarClient HashWheelTimer to schedule producer batch trigger task"

2023-01-10 Thread GitBox
github-actions[bot] commented on PR #18073: URL: https://github.com/apache/pulsar/pull/18073#issuecomment-1378147265 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #18835: [Doc] Message Id Uniqueness?

2023-01-10 Thread GitBox
github-actions[bot] commented on issue #18835: URL: https://github.com/apache/pulsar/issues/18835#issuecomment-1378146894 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] aloyszhang commented on pull request #19147: [fix][broker] catch exception for brokerInterceptor

2023-01-10 Thread GitBox
aloyszhang commented on PR #19147: URL: https://github.com/apache/pulsar/pull/19147#issuecomment-1378143066 @eolivelli @BewareMyPower Will only catch exceptions for ackRequest and send a discuss to mail list -- This is an automated message from the Apache Git Service. To respond to

[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#dda1437)

2023-01-10 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 34b95183f76 Docs sync done from apache/pulsar

[pulsar] branch master updated: [fix][io] Fix Alluxio sink to respect the alluxioMasterHost property (#19172)

2023-01-10 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new dda14379640 [fix][io] Fix Alluxio sink to

[GitHub] [pulsar] tisonkun merged pull request #19172: [fix][io] Fix Alluxio sink to respect the alluxioMasterHost property

2023-01-10 Thread GitBox
tisonkun merged PR #19172: URL: https://github.com/apache/pulsar/pull/19172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tisonkun commented on pull request #19172: [fix][io] Fix Alluxio sink to respect the alluxioMasterHost property

2023-01-10 Thread GitBox
tisonkun commented on PR #19172: URL: https://github.com/apache/pulsar/pull/19172#issuecomment-1378121215 Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] codecov-commenter commented on pull request #19176: [cleanup][broker] Pass subName to authz provider on unsubscribe

2023-01-10 Thread GitBox
codecov-commenter commented on PR #19176: URL: https://github.com/apache/pulsar/pull/19176#issuecomment-1378053024 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19176?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19176: [cleanup][broker] Pass subName to authz provider on unsubscribe

2023-01-10 Thread GitBox
michaeljmarshall opened a new pull request, #19176: URL: https://github.com/apache/pulsar/pull/19176 ### Motivation In https://github.com/apache/pulsar/pull/15347, there is a regression where the `subName` needed to be passed to the authorization provider. That PR is not released,

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #15907: [feature][functions]Support auth for function go

2023-01-10 Thread GitBox
michaeljmarshall commented on code in PR #15907: URL: https://github.com/apache/pulsar/pull/15907#discussion_r1066411080 ## pulsar-function-go/conf/conf.go: ## @@ -77,6 +77,9 @@ type Conf struct { UserConfig string `json:"userConfig" yaml:"userConfig"`

[pulsar] branch master updated: [fix][build] Upgrade dependency-check-maven plugin to fix broken OWASP check (#19170)

2023-01-10 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 82b1357d397 [fix][build] Upgrade

[GitHub] [pulsar] lhotari merged pull request #19170: [fix][build] Upgrade dependency-check-maven plugin to fix broken OWASP check

2023-01-10 Thread GitBox
lhotari merged PR #19170: URL: https://github.com/apache/pulsar/pull/19170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] DaveDuggins commented on a diff in pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-10 Thread GitBox
DaveDuggins commented on code in PR #349: URL: https://github.com/apache/pulsar-site/pull/349#discussion_r1066343758 ## src/components/HomepageFeatures.js: ## @@ -4,48 +4,48 @@ import ReactMarkdown from "react-markdown"; const FeatureList = (language) => [ { -title:

[GitHub] [pulsar-site] DaveDuggins commented on pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-10 Thread GitBox
DaveDuggins commented on PR #349: URL: https://github.com/apache/pulsar-site/pull/349#issuecomment-1377847795 > @DaveDuggins, Can you please change the title and summary to reflect the content and intent of this PR? I think another PR you had got the description and title mixed into here

[GitHub] [pulsar-site] DaveDuggins commented on a diff in pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-10 Thread GitBox
DaveDuggins commented on code in PR #349: URL: https://github.com/apache/pulsar-site/pull/349#discussion_r1066336102 ## src/components/HomepageFeatures.js: ## @@ -4,48 +4,48 @@ import ReactMarkdown from "react-markdown"; const FeatureList = (language) => [ { -title:

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-10 Thread GitBox
michaeljmarshall commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1066310904 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -687,73 +689,93 @@ private void completeConnect(int clientProtoVersion,

[GitHub] [pulsar] nlu90 commented on a diff in pull request #15907: [feature][functions]Support auth for function go

2023-01-10 Thread GitBox
nlu90 commented on code in PR #15907: URL: https://github.com/apache/pulsar/pull/15907#discussion_r1066271927 ## pulsar-function-go/conf/conf.go: ## @@ -77,6 +77,9 @@ type Conf struct { UserConfig string `json:"userConfig" yaml:"userConfig"`

[GitHub] [pulsar-client-python] erichare commented on pull request #81: Add a version attribute

2023-01-10 Thread GitBox
erichare commented on PR #81: URL: https://github.com/apache/pulsar-client-python/pull/81#issuecomment-1377784782 > This PR looks like to use the 4th method of https://packaging.python.org/en/latest/guides/single-sourcing-package-version/#single-sourcing-the-version, but as the warning

[GitHub] [pulsar-site] dave2wave commented on a diff in pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-10 Thread GitBox
dave2wave commented on code in PR #349: URL: https://github.com/apache/pulsar-site/pull/349#discussion_r1066155855 ## src/components/HomepageFeatures.js: ## @@ -4,48 +4,48 @@ import ReactMarkdown from "react-markdown"; const FeatureList = (language) => [ { -title:

[GitHub] [pulsar-site] michaeljmarshall commented on a diff in pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-10 Thread GitBox
michaeljmarshall commented on code in PR #349: URL: https://github.com/apache/pulsar-site/pull/349#discussion_r1066043523 ## src/components/HomepageFeatures.js: ## @@ -4,48 +4,48 @@ import ReactMarkdown from "react-markdown"; const FeatureList = (language) => [ { -

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

2023-01-10 Thread GitBox
heesung-sn commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1066087400 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -55,6 +55,7 @@ import

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

2023-01-10 Thread GitBox
heesung-sn commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1066087400 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -55,6 +55,7 @@ import

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

2023-01-10 Thread GitBox
heesung-sn commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1066087400 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -55,6 +55,7 @@ import

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

2023-01-10 Thread GitBox
heesung-sn commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1066084076 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[pulsar] branch master updated: [feat][ci] Add integration to ge.apache.org Gradle Enterprise server (#19133)

2023-01-10 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5171d81b6ae [feat][ci] Add integration to

[GitHub] [pulsar] lhotari merged pull request #19133: [feat][ci] Add integration to ge.apache.org Gradle Enterprise server

2023-01-10 Thread GitBox
lhotari merged PR #19133: URL: https://github.com/apache/pulsar/pull/19133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari commented on pull request #19133: [feat][ci] Add integration to ge.apache.org Gradle Enterprise server

2023-01-10 Thread GitBox
lhotari commented on PR #19133: URL: https://github.com/apache/pulsar/pull/19133#issuecomment-1377577888 > BTW, compatibility issues can be a risk that there're further unstable cases so we need to investigate it. @tisonkun I have reported this issue

[GitHub] [pulsar-site] michaeljmarshall commented on pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-10 Thread GitBox
michaeljmarshall commented on PR #349: URL: https://github.com/apache/pulsar-site/pull/349#issuecomment-1377572844 > @DaveDuggins, Can you please change the title and summary to reflect the content and intent of this PR? I think another PR you had got the description and title mixed into

[GitHub] [pulsar] michaeljmarshall commented on issue #19111: Update contribution guide according to the move of source of docs

2023-01-10 Thread GitBox
michaeljmarshall commented on issue #19111: URL: https://github.com/apache/pulsar/issues/19111#issuecomment-1377559515 Thanks for sharing that @Anonymitaet! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar-site] michaeljmarshall commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-10 Thread GitBox
michaeljmarshall commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1066017298 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,109 @@ +--- +author: Apache Pulsar Community +title: "Apache Pulsar 2022 Year in Review"

[GitHub] [pulsar] nodece commented on a diff in pull request #19141: [improve][broker,proxy] Use ChannelVoidPromise to avoid useless promise objects creation

2023-01-10 Thread GitBox
nodece commented on code in PR #19141: URL: https://github.com/apache/pulsar/pull/19141#discussion_r1066000437 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java: ## @@ -495,5 +493,9 @@ public void exceptionCaught(ChannelHandlerContext ctx,

[GitHub] [pulsar] lhotari opened a new issue, #19175: Flaky-test: ProxyWithAuthorizationTest.testProxyAuthorization

2023-01-10 Thread GitBox
lhotari opened a new issue, #19175: URL: https://github.com/apache/pulsar/issues/19175 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure

  1   2   >