[GitHub] [pulsar] fantapsody opened a new pull request, #18937: [fix][client-admin] Fix the conversion from the response to string in client error handling

2023-04-10 Thread via GitHub
fantapsody opened a new pull request, #18937: URL: https://github.com/apache/pulsar/pull/18937 ### Motivation The code to parse the response as a string is incorrect in the error handling of the admin client. The code `e.getResponse().getEntity().toString()` returns something like `j

[GitHub] [pulsar] RobertIndie closed pull request #18937: [fix][client-admin] Fix the conversion from the response to string in client error handling

2023-04-10 Thread via GitHub
RobertIndie closed pull request #18937: [fix][client-admin] Fix the conversion from the response to string in client error handling URL: https://github.com/apache/pulsar/pull/18937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] pgier opened a new pull request, #18440: [feat][broker] Expose pulsar out bytes and message metrics per topic

2023-04-10 Thread via GitHub
pgier opened a new pull request, #18440: URL: https://github.com/apache/pulsar/pull/18440 Add prometheus metrics which expose the per topic messages out and bytes out total on a per topic basis. Currently, only the subscription level stats are enabled. ### Motivation There ar

[GitHub] [pulsar] RobertIndie closed pull request #18440: [feat][broker] Expose pulsar out bytes and message metrics per topic

2023-04-10 Thread via GitHub
RobertIndie closed pull request #18440: [feat][broker] Expose pulsar out bytes and message metrics per topic URL: https://github.com/apache/pulsar/pull/18440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pulsar] poorbarcode closed issue #19826: PIP-259: Make the config httpMaxRequestHeaderSize of the pulsar web server to configurable

2023-04-10 Thread via GitHub
poorbarcode closed issue #19826: PIP-259: Make the config httpMaxRequestHeaderSize of the pulsar web server to configurable URL: https://github.com/apache/pulsar/issues/19826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[pulsar] branch master updated: [fix] [doc] Fix outdated java-doc of rate limiter (#19014)

2023-04-10 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 81971e2d91a [fix] [doc] Fix outdated java-doc of r

[GitHub] [pulsar] RobertIndie merged pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter

2023-04-10 Thread via GitHub
RobertIndie merged PR #19014: URL: https://github.com/apache/pulsar/pull/19014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[GitHub] [pulsar-client-go] wolfstudy opened a new pull request, #1008: Fix reconnection backoff logic

2023-04-10 Thread via GitHub
wolfstudy opened a new pull request, #1008: URL: https://github.com/apache/pulsar-client-go/pull/1008 ### Motivation Currently, qhen the backoff policy calculates the time after the user specifies MaxRetry, the initial time of each calculation is 100ms, and there is no way to

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][metrics] Fix the reason label of authentication metrics

2023-04-10 Thread via GitHub
gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1162347391 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/PulsarAuthenticationException.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache S

[pulsar] branch master updated (25dea3dc9dd -> b7f7e040b6a)

2023-04-10 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 25dea3dc9dd [fix] Use scheduled executor in BinaryProtoLookupService (#20043) add b7f7e040b6a [fix] [admin] PIP-

[GitHub] [pulsar] poorbarcode merged pull request #19514: [fix] [admin] PIP-259: Admin API can not work if uri too large

2023-04-10 Thread via GitHub
poorbarcode merged PR #19514: URL: https://github.com/apache/pulsar/pull/19514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][metrics] Fix the reason label of authentication metrics

2023-04-10 Thread via GitHub
gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1162346831 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java: ## @@ -157,8 +158,7 @@ public String authenticate(Auth

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][metrics] Fix the reason label of authentication metrics

2023-04-10 Thread via GitHub
gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1162346246 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderBasic.java: ## @@ -104,10 +105,11 @@ public String authenticate(Au

[GitHub] [pulsar-client-cpp] BewareMyPower commented on issue #248: logging thread_local error when thread exit [Bug]

2023-04-10 Thread via GitHub
BewareMyPower commented on issue #248: URL: https://github.com/apache/pulsar-client-cpp/issues/248#issuecomment-1502743418 I cannot reproduce this issue with the following code: ```c++ #include using namespace pulsar; class OuterClient { public: OuterClient(

[GitHub] [pulsar] jiangpengcheng commented on pull request #20000: [fix][fn] Support multiple input topics for Go runtime

2023-04-10 Thread via GitHub
jiangpengcheng commented on PR #2: URL: https://github.com/apache/pulsar/pull/2#issuecomment-1502736434 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] michaeljmarshall commented on pull request #19618: [feat][proxy] Add proxyVersion to CommandConnect; expose in stats

2023-04-10 Thread via GitHub
michaeljmarshall commented on PR #19618: URL: https://github.com/apache/pulsar/pull/19618#issuecomment-1502716713 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20059: [improve][broker] PIP-192 Improve TransferSheder for overload outlier for large clusters

2023-04-10 Thread via GitHub
gaoran10 commented on code in PR #20059: URL: https://github.com/apache/pulsar/pull/20059#discussion_r1162324117 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java: ## @@ -671,6 +685,18 @@ private boolean isUnderLoaded(L

[GitHub] [pulsar] poorbarcode commented on pull request #20031: [fix] [cli] Fix Broker crashed by too much memory usage of pulsar tools

2023-04-10 Thread via GitHub
poorbarcode commented on PR #20031: URL: https://github.com/apache/pulsar/pull/20031#issuecomment-1502714419 rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20059: [improve][broker] PIP-192 Improve TransferSheder for overload outlier for large clusters

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20059: URL: https://github.com/apache/pulsar/pull/20059#discussion_r1162259119 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java: ## @@ -671,6 +685,18 @@ private boolean isUnderLoaded

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20059: [improve][broker] PIP-192 Improve TransferSheder for overload outlier for large clusters

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20059: URL: https://github.com/apache/pulsar/pull/20059#discussion_r1162312847 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java: ## @@ -671,6 +685,18 @@ private boolean isUnderLoaded

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20059: [improve][broker] PIP-192 Improve TransferSheder for overload outlier for large clusters

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20059: URL: https://github.com/apache/pulsar/pull/20059#discussion_r1162259119 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java: ## @@ -671,6 +685,18 @@ private boolean isUnderLoaded

[GitHub] [pulsar] dragonls opened a new pull request, #20068: [fix][broker] Fix tenant admin authorization bug.

2023-04-10 Thread via GitHub
dragonls opened a new pull request, #20068: URL: https://github.com/apache/pulsar/pull/20068 Fixes #20066 ### Motivation Fixes the bug that producers/consumers will all disconnect while using tenant admin to produce/consume. ### Modifications Add `validateTen

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20059: [improve][broker] PIP-192 Improve TransferSheder for overload outlier for large clusters

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20059: URL: https://github.com/apache/pulsar/pull/20059#discussion_r1162259119 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java: ## @@ -671,6 +685,18 @@ private boolean isUnderLoaded

[GitHub] [pulsar] codecov-commenter commented on pull request #20000: [fix][fn] Support multiple input topics for Go runtime

2023-04-10 Thread via GitHub
codecov-commenter commented on PR #2: URL: https://github.com/apache/pulsar/pull/2#issuecomment-1502663856 ## [Codecov](https://codecov.io/gh/apache/pulsar/pull/2?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #20037: [fix][test] Fix flaky testCreateTopicWithZombieReplicatorCursor

2023-04-10 Thread via GitHub
BewareMyPower commented on code in PR #20037: URL: https://github.com/apache/pulsar/pull/20037#discussion_r1162281071 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1542,7 +1542,13 @@ public CompletableFuture checkReplicat

[GitHub] [pulsar] codecov-commenter commented on pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter

2023-04-10 Thread via GitHub
codecov-commenter commented on PR #19014: URL: https://github.com/apache/pulsar/pull/19014#issuecomment-1502651244 ## [Codecov](https://codecov.io/gh/apache/pulsar/pull/19014?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #20067: [fix][proxy] Refresh auth data if ProxyLookupRequests

2023-04-10 Thread via GitHub
michaeljmarshall opened a new pull request, #20067: URL: https://github.com/apache/pulsar/pull/20067 Fixes: https://github.com/apache/pulsar/issues/10816 PIP: #19771 Supersedes: https://github.com/apache/pulsar/pull/19026 Depends on: https://github.com/apache/pulsar/pull/20062

[GitHub] [pulsar] dragonls opened a new issue, #20066: [Bug] [broker] Producer and consumer will all be disconnected while using tenant admin to produce/consume

2023-04-10 Thread via GitHub
dragonls opened a new issue, #20066: URL: https://github.com/apache/pulsar/issues/20066 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version Pulsar 2.9.3 ### Minimal reproduce

[GitHub] [pulsar-client-cpp] haolujun commented on issue #248: logging thread_local error when thread exit [Bug]

2023-04-10 Thread via GitHub
haolujun commented on issue #248: URL: https://github.com/apache/pulsar-client-cpp/issues/248#issuecomment-1502642939 The Code like bellow: ` class OuterClient { public: OuterClient(const std::string& service_url) : client_(service_url) {} ~OuterClient() { cl

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20037: [fix][broker] Check replication cluster before starting the replicator when policies are updated

2023-04-10 Thread via GitHub
poorbarcode commented on code in PR #20037: URL: https://github.com/apache/pulsar/pull/20037#discussion_r1162266652 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1542,7 +1542,13 @@ public CompletableFuture checkReplicatio

[GitHub] [pulsar] jiangpengcheng commented on pull request #20000: [fix][fn] Support multiple input topics for Go runtime

2023-04-10 Thread via GitHub
jiangpengcheng commented on PR #2: URL: https://github.com/apache/pulsar/pull/2#issuecomment-1502634627 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] poorbarcode commented on pull request #19514: [fix] [admin] PIP-259: Admin API can not work if uri too large

2023-04-10 Thread via GitHub
poorbarcode commented on PR #19514: URL: https://github.com/apache/pulsar/pull/19514#issuecomment-1502634659 rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [pulsar] RobertIndie commented on pull request #19432: [improve] Allow to build and push multi-arch Docker images

2023-04-10 Thread via GitHub
RobertIndie commented on PR #19432: URL: https://github.com/apache/pulsar/pull/19432#issuecomment-1502632780 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20059: [improve][broker] PIP-192 Improve TransferSheder for overload outlier for large clusters

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20059: URL: https://github.com/apache/pulsar/pull/20059#discussion_r1162259119 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java: ## @@ -671,6 +685,18 @@ private boolean isUnderLoaded

[GitHub] [pulsar] RobertIndie closed issue #19771: PIP-257: Add Open ID Connect Support to Server Components

2023-04-10 Thread via GitHub
RobertIndie closed issue #19771: PIP-257: Add Open ID Connect Support to Server Components URL: https://github.com/apache/pulsar/issues/19771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] RobertIndie commented on issue #19771: PIP-257: Add Open ID Connect Support to Server Components

2023-04-10 Thread via GitHub
RobertIndie commented on issue #19771: URL: https://github.com/apache/pulsar/issues/19771#issuecomment-1502629178 This PIP has been implemented in https://github.com/apache/pulsar/pull/19849. @michaeljmarshall I am closing it now. Feel free to reopen it and move it to the 3.1.0 milestone

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19737: [improve] [broker] PIP-240: new public method unloadSubscription in PersistentTopic

2023-04-10 Thread via GitHub
poorbarcode commented on code in PR #19737: URL: https://github.com/apache/pulsar/pull/19737#discussion_r1162256669 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1009,17 +1057,15 @@ private CompletableFuture getNonDurabl

[GitHub] [pulsar] coderzc commented on issue #16763: PIP-195: New bucket based delayed message tracker

2023-04-10 Thread via GitHub
coderzc commented on issue #16763: URL: https://github.com/apache/pulsar/issues/16763#issuecomment-1502627646 It should be noted, I haven't implemented this part of `Share the delayed message index across subscriptions` yet, but this PIP still works well, although this part is not implement

[GitHub] [pulsar] RobertIndie commented on issue #16913: PIP-196 Segmented transaction buffer snapshot

2023-04-10 Thread via GitHub
RobertIndie commented on issue #16913: URL: https://github.com/apache/pulsar/issues/16913#issuecomment-1502626459 Confirmed with @liangyepianzhou . There is still work left for metric and admin. Move this PIP to the 3.1.0 milestone to track. -- This is an automated message from the Apache

[GitHub] [pulsar] RobertIndie commented on issue #16913: PIP-196 Segmented transaction buffer snapshot

2023-04-10 Thread via GitHub
RobertIndie commented on issue #16913: URL: https://github.com/apache/pulsar/issues/16913#issuecomment-1502626404 Confirmed with @liangyepianzhou . There is still work left for metric and admin. Move this PIP to the 3.1.0 milestone to track. -- This is an automated message from the Apache

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20059: [improve][broker] PIP-192 Improve TransferSheder for overload outlier for large clusters

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20059: URL: https://github.com/apache/pulsar/pull/20059#discussion_r1162253184 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java: ## @@ -671,6 +685,18 @@ private boolean isUnderLoaded

[GitHub] [pulsar] RobertIndie closed issue #16763: PIP-195: New bucket based delayed message tracker

2023-04-10 Thread via GitHub
RobertIndie closed issue #16763: PIP-195: New bucket based delayed message tracker URL: https://github.com/apache/pulsar/issues/16763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [pulsar] RobertIndie commented on issue #16763: PIP-195: New bucket based delayed message tracker

2023-04-10 Thread via GitHub
RobertIndie commented on issue #16763: URL: https://github.com/apache/pulsar/issues/16763#issuecomment-1502620604 Confirmed with @coderzc . This PIP has been implemented. Close this PIP as completed -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [pulsar] poorbarcode opened a new pull request, #19014: [fix] [doc] Fix outdated java-doc of rate limiter

2023-04-10 Thread via GitHub
poorbarcode opened a new pull request, #19014: URL: https://github.com/apache/pulsar/pull/19014 ### Motivation After PR #8611, the acquiring permits can be larger than configured msg-rate if used by subscribing. But doc was not updated in time. ### Modifications fix the outd

[GitHub] [pulsar] poorbarcode closed pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter

2023-04-10 Thread via GitHub
poorbarcode closed pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter URL: https://github.com/apache/pulsar/pull/19014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19737: [improve] [broker] PIP-240: new public method unloadSubscription in PersistentTopic

2023-04-10 Thread via GitHub
poorbarcode commented on code in PR #19737: URL: https://github.com/apache/pulsar/pull/19737#discussion_r1162251986 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1009,17 +1057,15 @@ private CompletableFuture getNonDurabl

[GitHub] [pulsar] poorbarcode opened a new pull request, #19737: [improve] [broker] PIP-240: new public method unloadSubscription in PersistentTopic

2023-04-10 Thread via GitHub
poorbarcode opened a new pull request, #19737: URL: https://github.com/apache/pulsar/pull/19737 ### Motivation [PIP-240: A new API to unload subscriptions](https://github.com/apache/pulsar/issues/19187) ### Modifications - part-1: add a new method `unloadSubscription( St

[GitHub] [pulsar] poorbarcode closed pull request #19737: [improve] [broker] PIP-240: new public method unloadSubscription in PersistentTopic

2023-04-10 Thread via GitHub
poorbarcode closed pull request #19737: [improve] [broker] PIP-240: new public method unloadSubscription in PersistentTopic URL: https://github.com/apache/pulsar/pull/19737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19737: [improve] [broker] PIP-240: new public method unloadSubscription in PersistentTopic

2023-04-10 Thread via GitHub
poorbarcode commented on code in PR #19737: URL: https://github.com/apache/pulsar/pull/19737#discussion_r1162250437 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -430,6 +433,51 @@ public AtomicLong getPendingWriteOps() {

[GitHub] [pulsar] RobertIndie commented on issue #16153: PIP-180: Shadow Topic, an alternative way to support readonly topic ownership.

2023-04-10 Thread via GitHub
RobertIndie commented on issue #16153: URL: https://github.com/apache/pulsar/issues/16153#issuecomment-1502617598 Hi, @Jason918. What is the status of this PIP? I see [that](https://github.com/apache/pulsar/pull/18265#issue-1429430819) the basic function is ready for this PIP. So my underst

[pulsar] branch master updated (a9186514089 -> 25dea3dc9dd)

2023-04-10 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from a9186514089 [improve][client] PIP-224: Add getLastMessageIds API (#20040) add 25dea3dc9dd [fix] Use scheduled ex

[GitHub] [pulsar] poorbarcode merged pull request #20043: [fix] Use scheduled executor in BinaryProtoLookupService

2023-04-10 Thread via GitHub
poorbarcode merged PR #20043: URL: https://github.com/apache/pulsar/pull/20043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[GitHub] [pulsar] poorbarcode closed issue #20042: [Bug][java-client] No Retry when subscribing to topic via pattern

2023-04-10 Thread via GitHub
poorbarcode closed issue #20042: [Bug][java-client] No Retry when subscribing to topic via pattern URL: https://github.com/apache/pulsar/issues/20042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20059: [improve][broker] PIP-192 Improve TransferSheder for overload outlier for large clusters

2023-04-10 Thread via GitHub
gaoran10 commented on code in PR #20059: URL: https://github.com/apache/pulsar/pull/20059#discussion_r1162244347 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java: ## @@ -671,6 +685,18 @@ private boolean isUnderLoaded(L

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20059: [improve][broker] PIP-192 Improve TransferSheder for overload outlier for large clusters

2023-04-10 Thread via GitHub
gaoran10 commented on code in PR #20059: URL: https://github.com/apache/pulsar/pull/20059#discussion_r1162244347 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java: ## @@ -671,6 +685,18 @@ private boolean isUnderLoaded(L

[GitHub] [pulsar-client-go] Gleiphir2769 commented on pull request #1007: ci: stablize golangci-lint task

2023-04-10 Thread via GitHub
Gleiphir2769 commented on PR #1007: URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1502611036 > Besides, it's a false positive on bodyclose linter. There are a few false positive reports upstream, like [timakin/bodyclose#42](https://github.com/timakin/bodyclose/issu

[GitHub] [pulsar-client-go] tisonkun commented on pull request #1007: ci: stablize golangci-lint task

2023-04-10 Thread via GitHub
tisonkun commented on PR #1007: URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1502608301 > But I am very curious why httpclient can pass the previous CI. It has already been introduced in 2021. The old golangci-lint we used has the ability for ignoring old files?

[GitHub] [pulsar] RobertIndie commented on pull request #18440: [feat][broker] Expose pulsar out bytes and message metrics per topic

2023-04-10 Thread via GitHub
RobertIndie commented on PR #18440: URL: https://github.com/apache/pulsar/pull/18440#issuecomment-1502605055 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] TakaHiR07 opened a new pull request, #20065: [improve] [txn] respond to client when txn update status to committing or aborting

2023-04-10 Thread via GitHub
TakaHiR07 opened a new pull request, #20065: URL: https://github.com/apache/pulsar/pull/20065 Master Issue: #19747 ### Motivation Related to issue, endTxn behave as kafka. When txn status update to committing/aborting, respond success to client. ### Modifications

[pulsar] branch master updated: [improve][client] PIP-224: Add getLastMessageIds API (#20040)

2023-04-10 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a9186514089 [improve][client] PIP-224: Add getLastM

[GitHub] [pulsar] BewareMyPower closed issue #4940: Serialization and Deserialization for MultiMessageIdImpl

2023-04-10 Thread via GitHub
BewareMyPower closed issue #4940: Serialization and Deserialization for MultiMessageIdImpl URL: https://github.com/apache/pulsar/issues/4940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] BewareMyPower merged pull request #20040: [improve][client] PIP-224: Add getLastMessageIds API

2023-04-10 Thread via GitHub
BewareMyPower merged PR #20040: URL: https://github.com/apache/pulsar/pull/20040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[GitHub] [pulsar-client-go] Gleiphir2769 commented on pull request #1007: ci: stablize golangci-lint task

2023-04-10 Thread via GitHub
Gleiphir2769 commented on PR #1007: URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1502595019 Good work! @tisonkun But I am very curious why `httpclient` can pass the previous CI. It's introduced in 2021. It means the old golangci-lint we used has the ability

[GitHub] [pulsar-client-cpp] BewareMyPower commented on issue #234: [feat][cpp-client] PIP-145: Notifications for faster topic discovery - already implemented in Java client but not yet in C++?

2023-04-10 Thread via GitHub
BewareMyPower commented on issue #234: URL: https://github.com/apache/pulsar-client-cpp/issues/234#issuecomment-1502587690 Recently there is no plan to do that, let's keep this issue open and see if there is anyone can help -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
Demogorgon314 commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162225366 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java: ## @@ -151,7 +151,7 @@ public String getBrokerId() {

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #20030: [fix][metrics] Fix the reason label of authentication metrics

2023-04-10 Thread via GitHub
michaeljmarshall commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1162217415 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java: ## @@ -157,8 +158,7 @@ public String authentic

[pulsar] branch branch-2.11 updated: [fix] [ml] Fix uncompleted future when remove cursor (#20050)

2023-04-10 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 0fd5af03dca [fix] [ml] Fix uncomple

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162219908 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java: ## @@ -151,7 +151,7 @@ public String getBrokerId() { @O

[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#11751b7)

2023-04-10 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 225bfa8d793 Docs sync done from apache/pulsar (

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162218388 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/filter/BrokerLMClassFilter.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache S

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162218388 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/filter/BrokerLMClassFilter.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache S

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
Demogorgon314 commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162213444 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/filter/BrokerLMClassFilter.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apach

[GitHub] [pulsar] michaeljmarshall merged pull request #20060: [improve] Removed usages of SafeRun

2023-04-10 Thread via GitHub
michaeljmarshall merged PR #20060: URL: https://github.com/apache/pulsar/pull/20060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[pulsar] branch master updated: [improve] Removed usages of SafeRun (#20060)

2023-04-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new bafecb2a9c0 [improve] Removed usages of SafeR

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
Demogorgon314 commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162211402 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/manager/RedirectManager.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] michaeljmarshall commented on pull request #20062: [improve][proxy] Only create ConnectionPool when needed

2023-04-10 Thread via GitHub
michaeljmarshall commented on PR #20062: URL: https://github.com/apache/pulsar/pull/20062#issuecomment-1502554997 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
Demogorgon314 commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162211304 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/filter/BrokerFilterTestBase.java: ## @@ -115,6 +116,7 @@ public BrokerLookupData g

[GitHub] [pulsar] codecov-commenter commented on pull request #20060: [improve] Removed usages of SafeRun

2023-04-10 Thread via GitHub
codecov-commenter commented on PR #20060: URL: https://github.com/apache/pulsar/pull/20060#issuecomment-1502551187 ## [Codecov](https://codecov.io/gh/apache/pulsar/pull/20060?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [pulsar-manager] Aaron-ML commented on issue #505: Starting Docker container pulsar-manager-0.3.0 with internal PostreSQL does not work

2023-04-10 Thread via GitHub
Aaron-ML commented on issue #505: URL: https://github.com/apache/pulsar-manager/issues/505#issuecomment-1502519317 Hitting this as well, looks like a lot of this stuff is on hold or what? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162187454 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/manager/RedirectManager.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Sof

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162187454 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/manager/RedirectManager.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Sof

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162186982 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/filter/BrokerLMClassFilter.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache S

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
Demogorgon314 commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162186415 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/manager/RedirectManager.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
Demogorgon314 commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162185849 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/filter/BrokerLMClassFilter.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apach

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162185526 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -106,6 +107,8 @@ public class ExtensibleLoadMan

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
Demogorgon314 commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162184812 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/data/BrokerLookupData.java: ## @@ -67,6 +69,16 @@ public Optional getProtocol(Stri

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1161880903 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -106,6 +107,8 @@ public class ExtensibleLoadMan

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
heesung-sn commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1161880903 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -106,6 +107,8 @@ public class ExtensibleLoadMan

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
Demogorgon314 commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162184289 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -106,6 +107,8 @@ public class ExtensibleLoad

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #20058: [improve][broker] PIP-192: Redirect the request to current load manager

2023-04-10 Thread via GitHub
Demogorgon314 commented on code in PR #20058: URL: https://github.com/apache/pulsar/pull/20058#discussion_r1162182853 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java: ## @@ -51,7 +51,7 @@ @Slf4j public class BrokerRegistry

[GitHub] [pulsar] aymkhalil opened a new pull request, #20064: [improve][pulsar-shell] Use singleton custom command factories

2023-04-10 Thread via GitHub
aymkhalil opened a new pull request, #20064: URL: https://github.com/apache/pulsar/pull/20064 Fixes #20061 ### Motivation Loads custom factories in pulsar shell only once because multiple loads are redundant, and the lifecycle of classes in the NAR class

[GitHub] [pulsar] anguillanneuf opened a new issue, #20063: [Bug] examples/example-stateful-function-config.yaml does not exist in 2.11 distro

2023-04-10 Thread via GitHub
anguillanneuf opened a new issue, #20063: URL: https://github.com/apache/pulsar/issues/20063 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version The Get Started guide for [stateful

[GitHub] [pulsar] codelipenghui commented on pull request #20030: [fix][metrics] Fix the reason label of authentication metrics

2023-04-10 Thread via GitHub
codelipenghui commented on PR #20030: URL: https://github.com/apache/pulsar/pull/20030#issuecomment-1502459091 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] codelipenghui commented on pull request #20030: [fix][metrics] Fix the reason label of authentication metrics

2023-04-10 Thread via GitHub
codelipenghui commented on PR #20030: URL: https://github.com/apache/pulsar/pull/20030#issuecomment-1502459024 And please also update the documentation after the RP get merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [pulsar] codelipenghui commented on pull request #20040: [improve][client] PIP-224: Add getLastMessageIds API

2023-04-10 Thread via GitHub
codelipenghui commented on PR #20040: URL: https://github.com/apache/pulsar/pull/20040#issuecomment-1502445812 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[pulsar] branch master updated: [feat] PIP-257: Add AuthenticationProviderOpenID (#19849)

2023-04-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 11751b7da23 [feat] PIP-257: Add Authenticatio

[GitHub] [pulsar] michaeljmarshall merged pull request #19849: [feat] PIP-257: Add AuthenticationProviderOpenID

2023-04-10 Thread via GitHub
michaeljmarshall merged PR #19849: URL: https://github.com/apache/pulsar/pull/19849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #20062: [improve][proxy] Only create ConnectionPool when needed

2023-04-10 Thread via GitHub
michaeljmarshall opened a new pull request, #20062: URL: https://github.com/apache/pulsar/pull/20062 ### Motivation The Pulsar Proxy has two modes for proxying requests. The first is to proxy lookup requests and the second is to proxy bytes. In the lookup case, the proxy handles redi

[GitHub] [pulsar] merlimat commented on pull request #20060: [improve] Removed usages of SafeRun

2023-04-10 Thread via GitHub
merlimat commented on PR #20060: URL: https://github.com/apache/pulsar/pull/20060#issuecomment-1502341381 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar-client-cpp] JTBS commented on issue #234: [feat][cpp-client] PIP-145: Notifications for faster topic discovery - already implemented in Java client but not yet in C++?

2023-04-10 Thread via GitHub
JTBS commented on issue #234: URL: https://github.com/apache/pulsar-client-cpp/issues/234#issuecomment-1502327679 @BewareMyPower or anyone who can help, is there any tentative plan to support this feature -similar to how it was implemented in Java client. In original doc there is mention

  1   2   3   >