[GitHub] [pulsar] lhotari commented on a diff in pull request #19215: [improve][client] Use Jackson's ObjectReader in Client's JSON readers

2023-01-12 Thread GitBox
lhotari commented on code in PR #19215: URL: https://github.com/apache/pulsar/pull/19215#discussion_r1068606954 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/reader/JacksonJsonReader.java: ## @@ -33,17 +34,17 @@ */ public class JacksonJsonReader

[GitHub] [pulsar] lhotari opened a new pull request, #19215: [improve][client] Use Jackson's ObjectReader in Client's JSON readers

2023-01-12 Thread GitBox
lhotari opened a new pull request, #19215: URL: https://github.com/apache/pulsar/pull/19215 ### Motivation - benefits: - no need to lookup the type when reading happens. - The type gets fetched from cache once. - Since a reference is kept, it won't overflow

[GitHub] [pulsar] lhotari opened a new issue, #19214: Flaky-test: CompactionReaderImplTest.test

2023-01-12 Thread GitBox
lhotari opened a new issue, #19214: URL: https://github.com/apache/pulsar/issues/19214 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure

[GitHub] [pulsar] pgier opened a new issue, #19213: pulsar-shell should quit cleanly on EOF character (CTRL-D)

2023-01-12 Thread GitBox
pgier opened a new issue, #19213: URL: https://github.com/apache/pulsar/issues/19213 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation It's common for command line shells to

[GitHub] [pulsar] codecov-commenter commented on pull request #19212: [fix][ci] Fix PulsarFunctionLocalRunTest that broke after ClusterData validation changes

2023-01-12 Thread GitBox
codecov-commenter commented on PR #19212: URL: https://github.com/apache/pulsar/pull/19212#issuecomment-1380930939 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19212?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19151: [improve][broker] Add parameter check for create/update cluster.

2023-01-12 Thread GitBox
michaeljmarshall commented on code in PR #19151: URL: https://github.com/apache/pulsar/pull/19151#discussion_r1068579592 ## pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/ClusterDataImpl.java: ## @@ -398,4 +400,30 @@ public ClusterDataImpl build() {

[GitHub] [pulsar] lhotari commented on pull request #19151: [improve][broker] Add parameter check for create/update cluster.

2023-01-12 Thread GitBox
lhotari commented on PR #19151: URL: https://github.com/apache/pulsar/pull/19151#issuecomment-1380926203 @mattisonchao I wonder if a "https" url would need to be accepted in the serviceUrl just because of backwards compatibility reasons? -- This is an automated message from the Apache

[GitHub] [pulsar] lhotari commented on pull request #19151: [improve][broker] Add parameter check for create/update cluster.

2023-01-12 Thread GitBox
lhotari commented on PR #19151: URL: https://github.com/apache/pulsar/pull/19151#issuecomment-1380925462 @mattisonchao Is this PR a potential breaking change? Please check #19212 . ("Pulsar CI Flaky" jobs have been failing for several days with OOME after this PR was merged:

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19191: [fix][client] Fix producer could send timeout when enable batching

2023-01-12 Thread GitBox
michaeljmarshall commented on code in PR #19191: URL: https://github.com/apache/pulsar/pull/19191#discussion_r1068553187 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java: ## @@ -873,14 +869,23 @@ private boolean canAddToCurrentBatch(MessageImpl

[GitHub] [pulsar] lhotari opened a new pull request, #19212: [fix][ci] Fix PulsarFunctionLocalRunTest that broke after ClusterData validation changes

2023-01-12 Thread GitBox
lhotari opened a new pull request, #19212: URL: https://github.com/apache/pulsar/pull/19212 ### Motivation "Pulsar CI Flaky" builds fail with OOMEs and produces heap dumps. It turns out that #19151 causes a breaking change. In PulsarFunctionLocalRunTest, the line 275

[GitHub] [pulsar] lhotari merged pull request #19194: [improve][ci] Gradle Enterprise Configuration Tweaks

2023-01-12 Thread GitBox
lhotari merged PR #19194: URL: https://github.com/apache/pulsar/pull/19194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] merlimat commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-12 Thread GitBox
merlimat commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1068389656 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -78,6 +123,8 @@ public static String

[GitHub] [pulsar] zbentley commented on issue #19210: [Bug] BacklogQuota not being enforced when it should be

2023-01-12 Thread GitBox
zbentley commented on issue #19210: URL: https://github.com/apache/pulsar/issues/19210#issuecomment-1380739363 I work with @awitghirmai; we were investigating this together. This part of the stats output seems impossible/like an invariant violation inside the broker: ```

[GitHub] [pulsar-site] yuweisung commented on pull request #378: [doc][improve] add instructions for REST API JSON files and fix 404 issues

2023-01-12 Thread GitBox
yuweisung commented on PR #378: URL: https://github.com/apache/pulsar-site/pull/378#issuecomment-1380648647 Can we add a description about the api standard? openapi, swagger, or others? I think this is helpful for api tester to import the api right. -- This is an automated message from

[GitHub] [pulsar] codecov-commenter commented on pull request #19194: [improve][ci] Gradle Enterprise Configuration Tweaks

2023-01-12 Thread GitBox
codecov-commenter commented on PR #19194: URL: https://github.com/apache/pulsar/pull/19194#issuecomment-1380610458 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19194?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] awitghirmai opened a new issue, #19210: [Bug]

2023-01-12 Thread GitBox
awitghirmai opened a new issue, #19210: URL: https://github.com/apache/pulsar/issues/19210 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version **OS Version/Computer:** M1 Macbook,

[GitHub] [pulsar] codecov-commenter commented on pull request #19209: [fix][txn] Fix transactions disabled error message

2023-01-12 Thread GitBox
codecov-commenter commented on PR #19209: URL: https://github.com/apache/pulsar/pull/19209#issuecomment-1380493463 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19209?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar-client-reactive] Plawn commented on pull request #112: Add sendManyCorrelated to ReactiveMessageSender

2023-01-12 Thread GitBox
Plawn commented on PR #112: URL: https://github.com/apache/pulsar-client-reactive/pull/112#issuecomment-1380467162 Don't forget this PR :) pls It's what I currently need -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] nicoloboschi opened a new pull request, #19209: [fix][txn] Fix transactions disabled error message

2023-01-12 Thread GitBox
nicoloboschi opened a new pull request, #19209: URL: https://github.com/apache/pulsar/pull/19209 ### Motivation If the broker has not enabled the transactions feature and a transactions command is received, it returns the error `Transaction manager is not not enabled` which is

[GitHub] [pulsar-client-reactive] Plawn opened a new issue, #114: Add support for Mutiny

2023-01-12 Thread GitBox
Plawn opened a new issue, #114: URL: https://github.com/apache/pulsar-client-reactive/issues/114 Add support for mutiny as a reactive library -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-node] ericallam commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-12 Thread GitBox
ericallam commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1380407029 This issue is only happening on NodeJS 18.0+ (at least from my tests), and does not occur when we downgrade to Node 16.19.0 -- This is an automated message from the Apache

[GitHub] [pulsar] cbornet commented on a diff in pull request #19160: [improve][misc] Use shared Jackson ObjectMapper to reduce overhead and remove ThreadLocal solution

2023-01-12 Thread GitBox
cbornet commented on code in PR #19160: URL: https://github.com/apache/pulsar/pull/19160#discussion_r1068150057 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/LocalPoliciesResources.java: ## @@ -66,7 +66,7 @@ public CompletableFuture>> getLocalPolici

[GitHub] [pulsar-site] asafm commented on pull request #349: [doc][improve] Update Pulsar site landing page content

2023-01-12 Thread GitBox
asafm commented on PR #349: URL: https://github.com/apache/pulsar-site/pull/349#issuecomment-1380329239 @dave2wave Sorry about that, I'll start the discussion in the mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] lhotari commented on pull request #19160: [improve][misc] Use shared Jackson ObjectMapper to reduce overhead and remove ThreadLocal solution

2023-01-12 Thread GitBox
lhotari commented on PR #19160: URL: https://github.com/apache/pulsar/pull/19160#issuecomment-1380314133 @nicoloboschi PTAL . I have added a ProtectedObjectMapper class which prevents mutating the shared ObjectMapper config. -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] andrasbeni opened a new pull request, #19208: [improve][broker]Enable custom metadata stores

2023-01-12 Thread GitBox
andrasbeni opened a new pull request, #19208: URL: https://github.com/apache/pulsar/pull/19208 Fixes #xyz Master Issue: #xyz PIP: #xyz ### Motivation Pulsar can use different metadata stores (ZK, etcd, etc.). These metadata

[GitHub] [pulsar] lhotari commented on pull request #19191: [fix][client] Fix producer could send timeout when enable batching

2023-01-12 Thread GitBox
lhotari commented on PR #19191: URL: https://github.com/apache/pulsar/pull/19191#issuecomment-1380262893 I don't fully agree on the fix. When looking at the logic, it feels that org.apache.pulsar.client.impl.AbstractBatchMessageContainer#haveEnoughSpace is wrong if a bug like this occurs.

[GitHub] [pulsar] lhotari commented on pull request #19191: [fix][client] Fix producer could send timeout when enable batching

2023-01-12 Thread GitBox
lhotari commented on PR #19191: URL: https://github.com/apache/pulsar/pull/19191#issuecomment-1380261367 This is a good catch, but I didn't have a chance to review it before merging. @Technoboy- Please wait for reviews from the people who have worked on the code when such issues

[GitHub] [pulsar] Technoboy- closed issue #19189: [Bug] producer could send timeout when enable batching

2023-01-12 Thread GitBox
Technoboy- closed issue #19189: [Bug] producer could send timeout when enable batching URL: https://github.com/apache/pulsar/issues/19189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Technoboy- merged pull request #19191: [fix][client] Fix producer could send timeout when enable batching

2023-01-12 Thread GitBox
Technoboy- merged PR #19191: URL: https://github.com/apache/pulsar/pull/19191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] Technoboy- commented on a diff in pull request #373: Update release note for 2.11.0

2023-01-12 Thread GitBox
Technoboy- commented on code in PR #373: URL: https://github.com/apache/pulsar-site/pull/373#discussion_r1068064933 ## release-notes/versioned/client-websocket-2.11.0.md: ## @@ -0,0 +1,10 @@ +--- +id: client-websocket-2.11.0 +title: Client Websocket 2.11.0 +sidebar_label:

[GitHub] [pulsar-site] Technoboy- commented on a diff in pull request #373: Update release note for 2.11.0

2023-01-12 Thread GitBox
Technoboy- commented on code in PR #373: URL: https://github.com/apache/pulsar-site/pull/373#discussion_r1068064653 ## release-notes/versioned/pulsar-2.11.0.md: ## @@ -0,0 +1,643 @@ +--- +id: pulsar-2.11.0 +title: Apache Pulsar 2.11.0 +sidebar_label: Apache Pulsar 2.11.0 +--- +

[GitHub] [pulsar] Technoboy- closed issue #19198: [doc][improve] add instructions for REST API JSON files and fix 404 issues

2023-01-12 Thread GitBox
Technoboy- closed issue #19198: [doc][improve] add instructions for REST API JSON files and fix 404 issues URL: https://github.com/apache/pulsar/issues/19198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar-site] Technoboy- merged pull request #378: [doc][improve] add instructions for REST API JSON files and fix 404 issues

2023-01-12 Thread GitBox
Technoboy- merged PR #378: URL: https://github.com/apache/pulsar-site/pull/378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] Technoboy- merged pull request #380: Add 2.11.0 to javadoc generator black list

2023-01-12 Thread GitBox
Technoboy- merged PR #380: URL: https://github.com/apache/pulsar-site/pull/380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Technoboy- merged pull request #19202: [fix][doc] Remove lombok plugin and define FunctionRecordBuilder explicitly

2023-01-12 Thread GitBox
Technoboy- merged PR #19202: URL: https://github.com/apache/pulsar/pull/19202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] philixtian opened a new issue, #19207: [Bug] Didn't updata metadata when try to updata the num of partitions of a partitioned-topic

2023-01-12 Thread GitBox
philixtian opened a new issue, #19207: URL: https://github.com/apache/pulsar/issues/19207 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version v-2.10.0 ### Minimal reproduce

[GitHub] [pulsar-site] momo-jun merged pull request #361: [improve][develop-plugin] Add section for AdditionalServlet plugins

2023-01-12 Thread GitBox
momo-jun merged PR #361: URL: https://github.com/apache/pulsar-site/pull/361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codecov-commenter commented on pull request #19204: [improve][broker] Add metric to indicates the max size of managed ledger cache size

2023-01-12 Thread GitBox
codecov-commenter commented on PR #19204: URL: https://github.com/apache/pulsar/pull/19204#issuecomment-1380212520 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19204?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar-site] alpreu commented on pull request #361: [improve][develop-plugin] Add section for AdditionalServlet plugins

2023-01-12 Thread GitBox
alpreu commented on PR #361: URL: https://github.com/apache/pulsar-site/pull/361#issuecomment-1380203895 @momo-jun I rebased now and added the 2.11 version as well, should be good to go now :) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] alpreu opened a new pull request, #19206: [branch-2.11][cherry-pick] Elasticsearch sink: Support loading config from secrets

2023-01-12 Thread GitBox
alpreu opened a new pull request, #19206: URL: https://github.com/apache/pulsar/pull/19206 2.11 backport of https://github.com/apache/pulsar/pull/18986 ### Motivation ### Modifications ### Verifying this change - [ ] Make sure that the change passes

[GitHub] [pulsar] gaozhangmin opened a new pull request, #19204: [improve][broker] Add metric to indicates the max size of managed ledger cache size

2023-01-12 Thread GitBox
gaozhangmin opened a new pull request, #19204: URL: https://github.com/apache/pulsar/pull/19204 ### Motivation Currently, We cannot get the max size of managed ledger cache size from metrics. ### Modifications Add metrics `ml_cache_total_size ` which indicates the max size

[GitHub] [pulsar] alpreu opened a new pull request, #19205: [branch-2.11][cherry-pick] Debezium sources: Support loading config from secrets

2023-01-12 Thread GitBox
alpreu opened a new pull request, #19205: URL: https://github.com/apache/pulsar/pull/19205 2.11 backport of https://github.com/apache/pulsar/pull/19004 ### Motivation ### Modifications ### Verifying this change - [ ] Make sure that the change

[GitHub] [pulsar-site] alpreu commented on pull request #378: [doc][improve] add instructions for REST API JSON files and fix 404 issues

2023-01-12 Thread GitBox
alpreu commented on PR #378: URL: https://github.com/apache/pulsar-site/pull/378#issuecomment-1380126030 This looks good, thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tisonkun commented on pull request #19202: [fix][doc] Remove lombok plugin and define FunctionRecordBuilder explicitly

2023-01-12 Thread GitBox
tisonkun commented on PR #19202: URL: https://github.com/apache/pulsar/pull/19202#issuecomment-1380122718 delombok should help, but then we should move the related class to `src/main/lombok` and it's the same level of change as define explicitly. I choose a way more understandable for me

[GitHub] [pulsar] mattisonchao merged pull request #19199: [fix][broker] Fix race condition while updating partition number

2023-01-12 Thread GitBox
mattisonchao merged PR #19199: URL: https://github.com/apache/pulsar/pull/19199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nodece commented on issue #10816: PulsarProxy does not always refresh authentication tokens received from client

2023-01-12 Thread GitBox
nodece commented on issue #10816: URL: https://github.com/apache/pulsar/issues/10816#issuecomment-1380091828 Thank you for your detailed explanation and guidance. > Perhaps this works for most cases where there's a single connection in the connection pool. What if there are multiple

[GitHub] [pulsar] Shoothzj commented on pull request #19193: [fix] [doc] fix multiple apis in the automatically generated documentation use the same anchor point

2023-01-12 Thread GitBox
Shoothzj commented on PR #19193: URL: https://github.com/apache/pulsar/pull/19193#issuecomment-1380084219 Now we aggregate rest api into a single file. I think it might be better to split them. This is also good for us to generate other language admin clients. I am trying to work on it.

[GitHub] [pulsar] cbornet commented on pull request #19199: [fix][broker] Fix race condition while updating partition number

2023-01-12 Thread GitBox
cbornet commented on PR #19199: URL: https://github.com/apache/pulsar/pull/19199#issuecomment-1380068005 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] nodece commented on pull request #17831: [fix][proxy] Fix refresh client auth

2023-01-12 Thread GitBox
nodece commented on PR #17831: URL: https://github.com/apache/pulsar/pull/17831#issuecomment-1380040321 > I think that this change should be reverted. This can cause corruption of the traffic between the client and the proxy. I provided some explanation in this comment: [#10816

[GitHub] [pulsar] eolivelli merged pull request #19171: [fix][broker] Allow user lookup topic name with `-partition-` but no metadata

2023-01-12 Thread GitBox
eolivelli merged PR #19171: URL: https://github.com/apache/pulsar/pull/19171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-node] ullebe1 opened a new issue, #284: Document minimum required libstdc++ version

2023-01-12 Thread GitBox
ullebe1 opened a new issue, #284: URL: https://github.com/apache/pulsar-client-node/issues/284 Running this on Debian Buster (which is EOL, but this issue should manifest itself on RHEL 8 too as it also has a too old `libstdc++`) by doing `npm install pulsar-client` as documented in the

[GitHub] [pulsar] nodece merged pull request #19180: [cleanup][broker] Deprecate blocking AuthorizationService, AuthorizationProvider methods

2023-01-12 Thread GitBox
nodece merged PR #19180: URL: https://github.com/apache/pulsar/pull/19180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] nodece commented on pull request #914: Move out the auth package from internal

2023-01-12 Thread GitBox
nodece commented on PR #914: URL: https://github.com/apache/pulsar-client-go/pull/914#issuecomment-1379990992 Hi @aristotelism, you can use the master codebase by `go get github.com/apache/pulsar-client-go@master`. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] nodece commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-12 Thread GitBox
nodece commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1067844698 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -687,73 +689,93 @@ private void completeConnect(int clientProtoVersion, String

[GitHub] [pulsar] nodece commented on a diff in pull request #18130: [fix][broker] Fix update authentication data

2023-01-12 Thread GitBox
nodece commented on code in PR #18130: URL: https://github.com/apache/pulsar/pull/18130#discussion_r1067839122 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -687,73 +689,93 @@ private void completeConnect(int clientProtoVersion, String

[GitHub] [pulsar] nodece opened a new pull request, #19203: [improve][websocket] Add ping support

2023-01-12 Thread GitBox
nodece opened a new pull request, #19203: URL: https://github.com/apache/pulsar/pull/19203 ### Motivation When the WebSocket connection is idle timeout, the server disconnects the client. We need to keep alive between the client and the server. There are two options: 1.

[GitHub] [pulsar-site] tisonkun opened a new pull request, #380: Add 2.11.0 to javadoc generator black list

2023-01-12 Thread GitBox
tisonkun opened a new pull request, #380: URL: https://github.com/apache/pulsar-site/pull/380 Signed-off-by: tison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar-site] Sherlock113 commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-12 Thread GitBox
Sherlock113 commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1067749798 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,106 @@ +--- +author: Apache Pulsar Community +title: "Apache Pulsar 2022 Year in Review" +date:

[GitHub] [pulsar-site] Sherlock113 commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-12 Thread GitBox
Sherlock113 commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1067808978 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,106 @@ +--- +author: Apache Pulsar Community +title: "Apache Pulsar 2022 Year in Review" +date:

[GitHub] [pulsar-client-cpp] romainbrancourt commented on pull request #171: [fix] Fix missing schema related function definitions

2023-01-12 Thread GitBox
romainbrancourt commented on PR #171: URL: https://github.com/apache/pulsar-client-cpp/pull/171#issuecomment-1379945282 @BewareMyPower done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-site] Sherlock113 commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-12 Thread GitBox
Sherlock113 commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1067806788 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,106 @@ +--- +author: Apache Pulsar Community Review Comment: Thank you, but I refuse to do

[GitHub] [pulsar] poorbarcode commented on issue #19187: PIP-240: A new API to reset subscriptions

2023-01-11 Thread GitBox
poorbarcode commented on issue #19187: URL: https://github.com/apache/pulsar/issues/19187#issuecomment-1379929956 Hi @dave2wave > I think that the terminology of unload is wrong. These are reset operations. already change `unload` to `reset` -- This is an automated

[GitHub] [pulsar] poorbarcode commented on issue #19187: PIP-240: A new API to reset subscriptions

2023-01-11 Thread GitBox
poorbarcode commented on issue #19187: URL: https://github.com/apache/pulsar/issues/19187#issuecomment-1379929522 Hi @eolivelli > If there is a problem we should spend time on investigating the problem and not in adding this kind of tools. You are right. When a user

[GitHub] [pulsar-client-node] ericallam commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-11 Thread GitBox
ericallam commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1379916212 I was able to connect to StreamNative cloud with OAuth2 credentials on 1.7.0 from macOS, using the following steps to install the pulsar-client:

[GitHub] [pulsar] codecov-commenter commented on pull request #19202: [fix][doc] Remove lombok plugin and define FunctionRecordBuilder explicitly

2023-01-11 Thread GitBox
codecov-commenter commented on PR #19202: URL: https://github.com/apache/pulsar/pull/19202#issuecomment-1379909921 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19202?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] tisonkun commented on pull request #19193: [fix] [doc] fix multiple apis in the automatically generated documentation use the same anchor point

2023-01-11 Thread GitBox
tisonkun commented on PR #19193: URL: https://github.com/apache/pulsar/pull/19193#issuecomment-1379903044 I agree that it's not a breaking change for end-users but only affects the doc experience. Some related works previous: * https://github.com/apache/pulsar/pull/19025 *

[GitHub] [pulsar] tisonkun opened a new pull request, #19202: [fix][doc] Remove lombok plugin and define FunctionRecordBuilder explicitly

2023-01-11 Thread GitBox
tisonkun opened a new pull request, #19202: URL: https://github.com/apache/pulsar/pull/19202 * This refers to https://github.com/apache/pulsar/pull/18520 * This refers to https://github.com/apache/pulsar/pull/16041 Verified locally with: ``` mvn -pl pulsar-client-api

[GitHub] [pulsar] mattisonchao commented on pull request #19193: [fix] [doc] fix multiple apis in the automatically generated documentation use the same anchor point

2023-01-11 Thread GitBox
mattisonchao commented on PR #19193: URL: https://github.com/apache/pulsar/pull/19193#issuecomment-1379894833 @tisonkun What do you think about this PR? I am not familiar with swagger, but I know you have worked on this part recently. -- This is an automated message from the Apache Git

[GitHub] [pulsar] tisonkun commented on a diff in pull request #16041: [improve][function] Support Record as Function output type

2023-01-11 Thread GitBox
tisonkun commented on code in PR #16041: URL: https://github.com/apache/pulsar/pull/16041#discussion_r1067761272 ## pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/utils/FunctionRecord.java: ## @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software

[GitHub] [pulsar-client-node] RobertIndie merged pull request #280: [refactor] optimize ci and build from source code.

2023-01-11 Thread GitBox
RobertIndie merged PR #280: URL: https://github.com/apache/pulsar-client-node/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tisonkun commented on pull request #18520: [improve][build] Add lombok plugin to solve Javadoc issue.

2023-01-11 Thread GitBox
tisonkun commented on PR #18520: URL: https://github.com/apache/pulsar/pull/18520#issuecomment-1379877993 @Technoboy- I think this the root cause that the generated javadoc for 2.11.0 using pytools becomes empty. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar-site] Sherlock113 commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-11 Thread GitBox
Sherlock113 commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1067749798 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,106 @@ +--- +author: Apache Pulsar Community +title: "Apache Pulsar 2022 Year in Review" +date:

[GitHub] [pulsar] thetumbled commented on pull request #19201: [fix] [broker] fix timeout transaction.

2023-01-11 Thread GitBox
thetumbled commented on PR #19201: URL: https://github.com/apache/pulsar/pull/19201#issuecomment-1379866210 Maybe there is a better way to fix it? for example, move following code ``` stores.put(tcId, store); ``` from

[GitHub] [pulsar] lhotari commented on a diff in pull request #19161: [improve][common] Add and register Jackson Java 8 support modules to Pulsar

2023-01-11 Thread GitBox
lhotari commented on code in PR #19161: URL: https://github.com/apache/pulsar/pull/19161#discussion_r1066849141 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/ObjectMapperFactory.java: ## @@ -109,7 +112,10 @@ @Slf4j public class ObjectMapperFactory { public

[GitHub] [pulsar] urfreespace commented on issue #18960: [Doc] Documentation site search navigates to the end of the page

2023-01-11 Thread GitBox
urfreespace commented on issue #18960: URL: https://github.com/apache/pulsar/issues/18960#issuecomment-1379855549 > OK. I get the point now. I have met this issue ever that the anchor doesn't work as expected. It may not be caused by the search mechanism but by anchor resolution. >

[GitHub] [pulsar] lhotari commented on pull request #19194: [improve][ci] Gradle Enterprise Configuration Tweaks

2023-01-11 Thread GitBox
lhotari commented on PR #19194: URL: https://github.com/apache/pulsar/pull/19194#issuecomment-1379848624 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19171: [fix][broker] Allow user lookup topic name with `-partition-` but no metadata

2023-01-11 Thread GitBox
mattisonchao commented on code in PR #19171: URL: https://github.com/apache/pulsar/pull/19171#discussion_r1067707979 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1165,11 +1165,16 @@ public CompletableFuture>

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-11 Thread GitBox
Anonymitaet commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1067691268 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,106 @@ +--- +author: Apache Pulsar Community Review Comment: ```suggestion author:

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-11 Thread GitBox
Anonymitaet commented on code in PR #371: URL: https://github.com/apache/pulsar-site/pull/371#discussion_r1067689800 ## blog/2023-01-10-pulsar-2022-year-in-review.md: ## @@ -0,0 +1,106 @@ +--- +author: Apache Pulsar Community +title: "Apache Pulsar 2022 Year in Review" +date:

[GitHub] [pulsar] thetumbled opened a new pull request, #19201: [fix] [broker] fix timeout transaction.

2023-01-11 Thread GitBox
thetumbled opened a new pull request, #19201: URL: https://github.com/apache/pulsar/pull/19201 Fixes #19200 ### Motivation ### Modifications make `CoordinatorNotFoundException` retryable. ### Verifying this change - [ ] Make sure that the

[GitHub] [pulsar] codecov-commenter commented on pull request #19199: [fix][broker] Fix race condition while updating partition number

2023-01-11 Thread GitBox
codecov-commenter commented on PR #19199: URL: https://github.com/apache/pulsar/pull/19199#issuecomment-1379801441 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19199?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] thetumbled opened a new issue, #19200: [Bug] [broker] Timeout transaction do not end.

2023-01-11 Thread GitBox
thetumbled opened a new issue, #19200: URL: https://github.com/apache/pulsar/issues/19200 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version master ### Minimal reproduce

[GitHub] [pulsar] mattisonchao closed pull request #19199: [fix][broker] Fix race condition while updating partition number

2023-01-11 Thread GitBox
mattisonchao closed pull request #19199: [fix][broker] Fix race condition while updating partition number URL: https://github.com/apache/pulsar/pull/19199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] mattisonchao opened a new pull request, #19199: [fix][broker] Fix race condition while updating partition number

2023-01-11 Thread GitBox
mattisonchao opened a new pull request, #19199: URL: https://github.com/apache/pulsar/pull/19199 ### Motivation We use `latest` to copy subscriptions from another topic; there is a gap between the topic creation and subscription. In this period of time, If some new producer sends

[GitHub] [pulsar-site] Anonymitaet commented on pull request #364: [fix][doc] Correct configuration requirements for the HDFS sinks

2023-01-11 Thread GitBox
Anonymitaet commented on PR #364: URL: https://github.com/apache/pulsar-site/pull/364#issuecomment-1379789770 Ping @Demogorgon314 again for technical review, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #373: Update release note for 2.11.0

2023-01-11 Thread GitBox
Anonymitaet commented on code in PR #373: URL: https://github.com/apache/pulsar-site/pull/373#discussion_r1067680040 ## release-notes/versioned/client-java-2.11.0.md: ## @@ -0,0 +1,48 @@ +--- +id: client-java-2.11.0 +title: Client Java 2.11.0 +sidebar_label: Client Java 2.11.0

[GitHub] [pulsar-site] Anonymitaet commented on pull request #378: [doc][improve] add instructions for REST API JSON files and fix 404 issues

2023-01-11 Thread GitBox
Anonymitaet commented on PR #378: URL: https://github.com/apache/pulsar-site/pull/378#issuecomment-1379782432 Hi @alpreu and @yuweisung I've addressed your concerns in this PR, could you please help review it? Thank you! -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #378: [doc][improve] add instructions for REST API JSON files and fix 404 issues

2023-01-11 Thread GitBox
Anonymitaet commented on code in PR #378: URL: https://github.com/apache/pulsar-site/pull/378#discussion_r1067677858 ## docs/admin-get-started.md: ## @@ -34,7 +34,9 @@ If you have enabled authentication, you need to provide an auth configuration to -You can find details

[GitHub] [pulsar] tisonkun merged pull request #19190: [fix] Some typos in Cmd classes

2023-01-11 Thread GitBox
tisonkun merged PR #19190: URL: https://github.com/apache/pulsar/pull/19190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tisonkun commented on pull request #19190: [fix] Some typos in Cmd classes

2023-01-11 Thread GitBox
tisonkun commented on PR #19190: URL: https://github.com/apache/pulsar/pull/19190#issuecomment-1379779261 Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #373: Update release note for 2.11.0

2023-01-11 Thread GitBox
momo-jun commented on code in PR #373: URL: https://github.com/apache/pulsar-site/pull/373#discussion_r1067675612 ## release-notes/versioned/pulsar-2.11.0.md: ## @@ -0,0 +1,643 @@ +--- +id: pulsar-2.11.0 +title: Apache Pulsar 2.11.0 +sidebar_label: Apache Pulsar 2.11.0 +--- +

[GitHub] [pulsar-site] Anonymitaet opened a new pull request, #378: [doc][improve] add instructions for REST API JSON files and fix 404 i…

2023-01-11 Thread GitBox
Anonymitaet opened a new pull request, #378: URL: https://github.com/apache/pulsar-site/pull/378 Fix https://github.com/apache/pulsar/issues/19198 The preview looks good: - Next

[GitHub] [pulsar] Anonymitaet opened a new issue, #19198: [doc][improve] add instructions for REST API JSON files and fix 404 issues

2023-01-11 Thread GitBox
Anonymitaet opened a new issue, #19198: URL: https://github.com/apache/pulsar/issues/19198 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? Issues

[GitHub] [pulsar] Nicklee007 commented on pull request #19190: [fix] Some typos in Cmd classes

2023-01-11 Thread GitBox
Nicklee007 commented on PR #19190: URL: https://github.com/apache/pulsar/pull/19190#issuecomment-1379765647 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] TakaHiR07 commented on issue #19169: [Bug][txn] exclusive subscription would lead to high cpu usage when do tailing-read

2023-01-11 Thread GitBox
TakaHiR07 commented on issue #19169: URL: https://github.com/apache/pulsar/issues/19169#issuecomment-1379746393 > @TakaHiR07 #14286 has not been fixed. this problem is the same as #14286 Thanks for your view. I guess this high cpu problem is easily reproduced and need to be fixed in

[GitHub] [pulsar] horizonzy commented on pull request #19156: [fix][broker] Support zookeeper read-only config.

2023-01-11 Thread GitBox
horizonzy commented on PR #19156: URL: https://github.com/apache/pulsar/pull/19156#issuecomment-1379741543 > LGTM, > > But I have to mention one thing If you want to cherry-pick this PR to branch-2.9, you've got to support and cherry-pick `zooKeeperAllowReadOnlyOperations`

[GitHub] [pulsar] HQebupt commented on pull request #19191: [fix][client] Fix producer could send timeout when enable batching

2023-01-11 Thread GitBox
HQebupt commented on PR #19191: URL: https://github.com/apache/pulsar/pull/19191#issuecomment-1379739733 Nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] codecov-commenter commented on pull request #19191: [fix][client] Fix producer could send timeout when enable batching

2023-01-11 Thread GitBox
codecov-commenter commented on PR #19191: URL: https://github.com/apache/pulsar/pull/19191#issuecomment-1379729771 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19191?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19171: [fix][broker] Allow user lookup topic name with `-partition-` but no metadata

2023-01-11 Thread GitBox
Technoboy- commented on code in PR #19171: URL: https://github.com/apache/pulsar/pull/19171#discussion_r1067638201 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1165,11 +1165,16 @@ public CompletableFuture>

[GitHub] [pulsar] github-actions[bot] commented on pull request #17820: [Bugfix] [LinuxInfoUtils] incorrect CPU usage collected by pulsar #17815

2023-01-11 Thread GitBox
github-actions[bot] commented on PR #17820: URL: https://github.com/apache/pulsar/pull/17820#issuecomment-1379716029 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

<    8   9   10   11   12   13   14   15   16   17   >