heesung-sn commented on PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1499317178
Fixed one module: https://github.com/apache/pulsar/pull/19991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
heesung-sn commented on PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1122974438
> @heesung-sn Just that you know about it, it's usually useful to work on
GitHub Actions workflow changes in your own fork before opening a PR to
apache/pulsar. Please check the
heesung-sn commented on PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1121297658
> > Regarding CLI java version, because CLI has dependencies on broker
modules, it needs to follow broker's java version.
>
> @heesung-sn Why does the CLI depend on broker
heesung-sn commented on PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1121255136
> > Why are we requiring JDK17 to build ?
>
> Initially, the motivation for this was to enable the use of new language
features in Pulsar server-side modules, for example,
heesung-sn commented on PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1121224758
> > @heesung-sn Are you interested in a follow up PR to address the above
comment?
>
> I already created #15505 to address this.
I see this followup change. Thank you
heesung-sn commented on PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1120050175
> @heesung-sn I reviewed the changes and since it would have been too hard
to explain the details, I have push changes to an experiment that I'm running
in my fork, it's
heesung-sn commented on PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1119211915
> There are three more occurrences of the JRE/JDK versions (8 or 11) in the
following topics. Should they be updated as well?
>
> - deploy-bare-metal.md
>
>
heesung-sn commented on PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1115357996
Hi @lhotari @nicoloboschi,
I think I resolved your comments in the latest push. Could you review this
PR again by any chance?
--
This is an automated message from the Apache Git
heesung-sn commented on PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1110074011
> We must create a matrix test suite where we run the Pulsar client suite
with jdk8 and jdk17 to ensure compatibility
Yes, that is a part of the plan. I was focusing on the
