[GitHub] [pulsar-client-node] shibd commented on a diff in pull request #322: [feat]: Support client.getPartitionsForTopic (#320)

2023-05-08 Thread via GitHub
shibd commented on code in PR #322: URL: https://github.com/apache/pulsar-client-node/pull/322#discussion_r1188061390 ## tests/client.test.js: ## @@ -49,5 +74,54 @@ const Pulsar = require('../index.js'); })).toThrow('Service URL is required and must be specified as a

[GitHub] [pulsar-client-node] shibd commented on a diff in pull request #322: [feat]: Support client.getPartitionsForTopic (#320)

2023-05-07 Thread via GitHub
shibd commented on code in PR #322: URL: https://github.com/apache/pulsar-client-node/pull/322#discussion_r1186980916 ## tests/end_to_end.test.js: ## @@ -1242,5 +1242,21 @@ const Pulsar = require('../index.js'); await consumer.close(); await client.close();