Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-28 Thread via GitHub
lhotari commented on code in PR #17524: URL: https://github.com/apache/pulsar/pull/17524#discussion_r1582557959 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1605,40 +1691,74 @@ public CompletableFuture close(

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-28 Thread via GitHub
lhotari merged PR #17524: URL: https://github.com/apache/pulsar/pull/17524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-27 Thread via GitHub
poorbarcode commented on code in PR #17524: URL: https://github.com/apache/pulsar/pull/17524#discussion_r1582003453 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1605,40 +1691,74 @@ public CompletableFuture close(

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-27 Thread via GitHub
lhotari commented on code in PR #17524: URL: https://github.com/apache/pulsar/pull/17524#discussion_r1581892388 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1605,40 +1691,74 @@ public CompletableFuture close(

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-27 Thread via GitHub
codecov-commenter commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2081126369 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/17524?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-27 Thread via GitHub
poorbarcode commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2081093590 >> @poorbarcode looks like OneWayReplicatorTest.testUnFenceTopicToReuse fails > Sorry, I found a behavior change(before: broker tries to unfence topic to reuse when clos

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-26 Thread via GitHub
poorbarcode commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2079693146 > @poorbarcode looks like OneWayReplicatorTest.testUnFenceTopicToReuse fails Sorry, I found a behavior change(before: broker tries to unfence topic to reuse when clos clients

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-26 Thread via GitHub
lhotari commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2079199183 @poorbarcode looks like OneWayReplicatorTest.testUnFenceTopicToReuse fails -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-26 Thread via GitHub
poorbarcode commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2078692154 > However, I think this Topic state management needs a serious refactoring. Agree with you -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-26 Thread via GitHub
lhotari commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2078692302 > However, I think this Topic state management needs a serious refactoring. > > I suggest defining TopicState and revisit topic state transitions in a state machine manner.