lhotari commented on code in PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#discussion_r1582557959
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -1605,40 +1691,74 @@ public CompletableFuture close(
lhotari merged PR #17524:
URL: https://github.com/apache/pulsar/pull/17524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
poorbarcode commented on code in PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#discussion_r1582003453
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -1605,40 +1691,74 @@ public CompletableFuture close(
lhotari commented on code in PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#discussion_r1581892388
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -1605,40 +1691,74 @@ public CompletableFuture close(
codecov-commenter commented on PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2081126369
##
[Codecov](https://app.codecov.io/gh/apache/pulsar/pull/17524?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
poorbarcode commented on PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2081093590
>> @poorbarcode looks like OneWayReplicatorTest.testUnFenceTopicToReuse fails
> Sorry, I found a behavior change(before: broker tries to unfence topic to
reuse when clos
poorbarcode commented on PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2079693146
> @poorbarcode looks like OneWayReplicatorTest.testUnFenceTopicToReuse fails
Sorry, I found a behavior change(before: broker tries to unfence topic to
reuse when clos clients
lhotari commented on PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2079199183
@poorbarcode looks like OneWayReplicatorTest.testUnFenceTopicToReuse fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
poorbarcode commented on PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2078692154
> However, I think this Topic state management needs a serious refactoring.
Agree with you
--
This is an automated message from the Apache Git Service.
To respond to the
lhotari commented on PR #17524:
URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2078692302
> However, I think this Topic state management needs a serious refactoring.
>
> I suggest defining TopicState and revisit topic state transitions in a
state machine manner.
10 matches
Mail list logo