Re: [PR] [improve][cli]Support for pulsar-shell persistent modes [pulsar]

sandeep-mst commented on code in PR #22522: URL: https://github.com/apache/pulsar/pull/22522#discussion_r1570513172 ## pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java: ## @@ -414,18 +441,34 @@ public List readCommand() { return;

Re: [PR] [improve][cli]Support for pulsar-shell persistent modes [pulsar]

lhotari commented on code in PR #22522: URL: https://github.com/apache/pulsar/pull/22522#discussion_r1570436161 ## pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java: ## @@ -414,18 +441,34 @@ public List readCommand() { return;

Re: [PR] [improve][cli]Support for pulsar-shell persistent modes [pulsar]

sandeep-mst commented on code in PR #22522: URL: https://github.com/apache/pulsar/pull/22522#discussion_r1570388422 ## pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java: ## @@ -414,18 +441,36 @@ public List readCommand() { return;

Re: [PR] [improve][cli]Support for pulsar-shell persistent modes [pulsar]

sandeep-mst commented on code in PR #22522: URL: https://github.com/apache/pulsar/pull/22522#discussion_r1570389366 ## pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java: ## @@ -414,18 +441,36 @@ public List readCommand() { return;

Re: [PR] [improve][cli]Support for pulsar-shell persistent modes [pulsar]

sandeep-mst commented on PR #22515: URL: https://github.com/apache/pulsar/pull/22515#issuecomment-2060792240 Closing in favour of https://github.com/apache/pulsar/pull/22522 I have resolved the review comments in that PR -- This is an automated message from the Apache Git Service. To

Re: [PR] [improve][cli]Support for pulsar-shell persistent modes [pulsar]

lhotari commented on code in PR #22522: URL: https://github.com/apache/pulsar/pull/22522#discussion_r1568560031 ## pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java: ## @@ -414,18 +441,36 @@ public List readCommand() { return;

Re: [PR] [improve][cli]Support for pulsar-shell persistent modes [pulsar]

sandeep-mst closed pull request #22515: [improve][cli]Support for pulsar-shell persistent modes URL: https://github.com/apache/pulsar/pull/22515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [improve][cli]Support for pulsar-shell persistent modes [pulsar]

lhotari commented on code in PR #22515: URL: https://github.com/apache/pulsar/pull/22515#discussion_r1566816835 ## pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java: ## @@ -567,6 +602,14 @@ private static boolean isQuitCommand(String line) {

Re: [PR] [improve][cli]Support for pulsar-shell persistent modes [pulsar]

lhotari commented on PR #22515: URL: https://github.com/apache/pulsar/pull/22515#issuecomment-2058366744 @sandeep-mst Thanks for the contribution. Please target the `master` branch since we currently follow that type of process where PRs target the master branch when it's applicable. --

Re: [PR] [improve][cli]Support for pulsar-shell persistent modes [pulsar]

lhotari commented on code in PR #22515: URL: https://github.com/apache/pulsar/pull/22515#discussion_r1566813924 ## pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java: ## @@ -567,6 +602,14 @@ private static boolean isQuitCommand(String line) {

Re: [PR] [improve][cli]Support for pulsar-shell persistent modes [pulsar]

lhotari commented on code in PR #22515: URL: https://github.com/apache/pulsar/pull/22515#discussion_r1566809132 ## pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java: ## @@ -567,6 +602,14 @@ private static boolean isQuitCommand(String line) {