[GitHub] [pulsar] zplinuxlover commented on pull request #6903: PIP-61: Advertise multiple addresses

2020-05-21 Thread GitBox
zplinuxlover commented on pull request #6903: URL: https://github.com/apache/pulsar/pull/6903#issuecomment-631899841 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar-client-go] yarthur1 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-21 Thread GitBox
yarthur1 commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428484520 ## File path: pulsar/producer_partition.go ## @@ -490,49 +475,77 @@ func (p *partitionProducer) SendAsync(ctx context.Context, msg

[GitHub] [pulsar-client-go] jonyhy96 opened a new issue #257: Retry count limit in reconnectToBroker

2020-05-21 Thread GitBox
jonyhy96 opened a new issue #257: URL: https://github.com/apache/pulsar-client-go/issues/257 **Is your feature request related to a problem? Please describe.** Once the connection is closed the reconnectToBroker logic of both producer and consumer will try to reconnect to the broker

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-21 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-631973158 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] srkukarni opened a new pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
srkukarni opened a new pull request #7010: URL: https://github.com/apache/pulsar/pull/7010 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] Anonymitaet commented on issue #6882: 2.5.1 documentation contains the out-of-date documentation of kubernetes deployment

2020-05-21 Thread GitBox
Anonymitaet commented on issue #6882: URL: https://github.com/apache/pulsar/issues/6882#issuecomment-631918952 @Huanli-Meng Since you worked on this issue and discussed w/ sijie before, could u pls double-check the issue status? thanks

[GitHub] [pulsar] Anonymitaet commented on pull request #5946: [Issue 4981][docs] The reference page of Configuration updated

2020-05-21 Thread GitBox
Anonymitaet commented on pull request #5946: URL: https://github.com/apache/pulsar/pull/5946#issuecomment-631933751 @BGRichi any updates for this PR? This is an automated message from the Apache Git Service. To respond to

[pulsar-translation] branch master updated: Update schedule_zh-CN.md (#31)

2020-05-21 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-translation.git The following commit(s) were added to refs/heads/master by this push: new 9254a60 Update schedule_zh-CN.md

[GitHub] [pulsar-translation] Anonymitaet merged pull request #31: Update schedule_zh-CN.md

2020-05-21 Thread GitBox
Anonymitaet merged pull request #31: URL: https://github.com/apache/pulsar-translation/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] cckellogg opened a new pull request #7008: Fix possible null pointer when getting instance metrics.

2020-05-21 Thread GitBox
cckellogg opened a new pull request #7008: URL: https://github.com/apache/pulsar/pull/7008 Fix issue in the ThreadRuntime where the instance will throw a null pointer exception when asked for metrics. ``` 0521 04:13:50 INFO | "javaInstanceRunnable

[GitHub] [pulsar] srkukarni opened a new pull request #7009: Fix swagger annotations for builtin sources/sinks rest api

2020-05-21 Thread GitBox
srkukarni opened a new pull request #7009: URL: https://github.com/apache/pulsar/pull/7009 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] huangdx0726 commented on pull request #5716: [Issues 5709]remove the namespace checking

2020-05-21 Thread GitBox
huangdx0726 commented on pull request #5716: URL: https://github.com/apache/pulsar/pull/5716#issuecomment-631917063 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar-client-go] yarthur1 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-21 Thread GitBox
yarthur1 commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428483868 ## File path: pulsar/producer_partition.go ## @@ -490,49 +475,77 @@ func (p *partitionProducer) SendAsync(ctx context.Context, msg

[GitHub] [pulsar] zplinuxlover commented on pull request #6903: PIP-61: Advertise multiple addresses

2020-05-21 Thread GitBox
zplinuxlover commented on pull request #6903: URL: https://github.com/apache/pulsar/pull/6903#issuecomment-631956740 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] snowcrumble commented on a change in pull request #6023: [pulsar-client-go]Add DeliverAfter option for go client

2020-05-21 Thread GitBox
snowcrumble commented on a change in pull request #6023: URL: https://github.com/apache/pulsar/pull/6023#discussion_r428475163 ## File path: pulsar-client-go/pulsar/producer_test.go ## @@ -416,3 +416,71 @@ func TestProducer_SendAndGetMsgID(t *testing.T) {

[GitHub] [pulsar-translation] sijia-w opened a new pull request #31: Update schedule_zh-CN.md

2020-05-21 Thread GitBox
sijia-w opened a new pull request #31: URL: https://github.com/apache/pulsar-translation/pull/31 <-- ### Contribution Checklist - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.

[GitHub] [pulsar] huangdx0726 commented on pull request #5716: [Issues 5709]remove the namespace checking

2020-05-21 Thread GitBox
huangdx0726 commented on pull request #5716: URL: https://github.com/apache/pulsar/pull/5716#issuecomment-631955884 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] snowcrumble commented on a change in pull request #6023: [pulsar-client-go]Add DeliverAfter option for go client

2020-05-21 Thread GitBox
snowcrumble commented on a change in pull request #6023: URL: https://github.com/apache/pulsar/pull/6023#discussion_r428473920 ## File path: pulsar-client-go/pulsar/producer_test.go ## @@ -416,3 +416,71 @@ func TestProducer_SendAndGetMsgID(t *testing.T) {

[GitHub] [pulsar-client-go] yarthur1 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-21 Thread GitBox
yarthur1 commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428483179 ## File path: pulsar/producer_partition.go ## @@ -490,49 +475,77 @@ func (p *partitionProducer) SendAsync(ctx context.Context, msg

[GitHub] [pulsar-client-go] yarthur1 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-21 Thread GitBox
yarthur1 commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428485255 ## File path: pulsar/producer_partition.go ## @@ -322,9 +331,8 @@ func (p *partitionProducer) internalSend(request *sendRequest) {

[GitHub] [pulsar] jerrypeng edited a comment on pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
jerrypeng edited a comment on pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#issuecomment-632331138 @srkukarni > Some methods are updating multiple counters/gauages. That still has to be in sync block to ensure that we get consistent stats. Given a

[GitHub] [pulsar] jerrypeng edited a comment on pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
jerrypeng edited a comment on pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#issuecomment-632331138 @srkukarni > Some methods are updating multiple counters/gauages. That still has to be in sync block to ensure that we get consistent stats. Given a

[GitHub] [pulsar] jerrypeng commented on a change in pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
jerrypeng commented on a change in pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#discussion_r428924499 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -546,13 +547,17 @@

[GitHub] [pulsar-client-go] jiazhai commented on issue #257: Retry number limit in reconnectToBroker

2020-05-21 Thread GitBox
jiazhai commented on issue #257: URL: https://github.com/apache/pulsar-client-go/issues/257#issuecomment-632431719 @jonyhy96 Thanks for reporting this issue. In java side the first time connect will be limited by the operation timeout(30s); But once it get success connect, when the

[GitHub] [pulsar] srkukarni commented on pull request #7011: Fix break changes in namespace offload policy and RabbitMQ sink.

2020-05-21 Thread GitBox
srkukarni commented on pull request #7011: URL: https://github.com/apache/pulsar/pull/7011#issuecomment-632444012 The broker unit tests have failed a lot of times. Maybe something to do with this change? This is an

[GitHub] [pulsar-client-go] wcn00 opened a new issue #258: Is there a way to specify schemas for new topics and get schemas for existing ones in this client?

2020-05-21 Thread GitBox
wcn00 opened a new issue #258: URL: https://github.com/apache/pulsar-client-go/issues/258 Subject pretty much says it all. Is there a way to specify schemas for new topics and get schemas for existing ones in this client? I'm reading the code and I don't see schema's mentioned in

[GitHub] [pulsar] srkukarni commented on a change in pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
srkukarni commented on a change in pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#discussion_r428968508 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -546,13 +547,17 @@

[GitHub] [pulsar-client-go] jonyhy96 commented on issue #257: Retry number limit in reconnectToBroker

2020-05-21 Thread GitBox
jonyhy96 commented on issue #257: URL: https://github.com/apache/pulsar-client-go/issues/257#issuecomment-632443576 @jiazhai Thanks for reply. > This behavior looks fine. It could avoid user to manually reconnect. I also like this auto reconnect feature but i think maybe we can give

[GitHub] [pulsar-client-go] jonyhy96 edited a comment on issue #257: Retry number limit in reconnectToBroker

2020-05-21 Thread GitBox
jonyhy96 edited a comment on issue #257: URL: https://github.com/apache/pulsar-client-go/issues/257#issuecomment-632443576 @jiazhai Thanks for reply. > This behavior looks fine. It could avoid user to manually reconnect. I also like this auto reconnect feature but i think maybe

[pulsar-helm-chart] branch merlimat-patch-1 created (now d5d3e2c)

2020-05-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch merlimat-patch-1 in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git. at d5d3e2c Use regular 2-2-2 BK client settings by default This branch includes the following

[pulsar-helm-chart] 01/01: Use regular 2-2-2 BK client settings by default

2020-05-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch merlimat-patch-1 in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git commit d5d3e2c0105fb54e76f9d63e05c2cf5955374a81 Author: Matteo Merli AuthorDate: Thu May 21 15:34:10 2020

[GitHub] [pulsar-client-go] jiazhai commented on issue #258: Is there a way to specify schemas for new topics and get schemas for existing ones in this client?

2020-05-21 Thread GitBox
jiazhai commented on issue #258: URL: https://github.com/apache/pulsar-client-go/issues/258#issuecomment-632436427 also pulsarctl has this command too. This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar-client-go] jiazhai commented on issue #258: Is there a way to specify schemas for new topics and get schemas for existing ones in this client?

2020-05-21 Thread GitBox
jiazhai commented on issue #258: URL: https://github.com/apache/pulsar-client-go/issues/258#issuecomment-632436217 @wcn00 This is a bin/pulsar-admin sub-command, and seems it is not supported in go-client api. This is an

[GitHub] [pulsar-client-go] jiazhai edited a comment on issue #258: Is there a way to specify schemas for new topics and get schemas for existing ones in this client?

2020-05-21 Thread GitBox
jiazhai edited a comment on issue #258: URL: https://github.com/apache/pulsar-client-go/issues/258#issuecomment-632436427 also pulsarctl has this command too. https://streamnative.io/docs/pulsarctl/v0.4.1/#schemas This is

[GitHub] [pulsar] codelipenghui commented on pull request #7011: Fix break changes in namespace offload policy and RabbitMQ sink.

2020-05-21 Thread GitBox
codelipenghui commented on pull request #7011: URL: https://github.com/apache/pulsar/pull/7011#issuecomment-632448020 @srkukarni How can I get the previous error log? I think we can paste the failed tests under the comments. So that I can reproduce it on my laptop.

[GitHub] [pulsar] jerrypeng commented on a change in pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
jerrypeng commented on a change in pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#discussion_r428924499 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -546,13 +547,17 @@

[GitHub] [pulsar-client-go] yarthur1 opened a new issue #259: problem about sendRequest fail to add batchbuilder

2020-05-21 Thread GitBox
yarthur1 opened a new issue #259: URL: https://github.com/apache/pulsar-client-go/issues/259 Expected behavior when I view producer send section source code,the partitionProducer func internalSend only log err after fail to add batchbuilder, should n't callback and release

[GitHub] [pulsar-client-go] keithnull commented on issue #177: Not support multi pulsar cluster addresses

2020-05-21 Thread GitBox
keithnull commented on issue #177: URL: https://github.com/apache/pulsar-client-go/issues/177#issuecomment-632457978 @wolfstudy Hi, I'm interested in this issue (for OSPP Summer 2020) and willing to work on it. But I can't fully understand why multi pulsar cluster addresses are

[GitHub] [pulsar] srkukarni commented on pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
srkukarni commented on pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#issuecomment-632344106 To unblock this pr, I've removed stats changes. Lets discuss that in a separate issue This is an automated

[GitHub] [pulsar] zplinuxlover commented on pull request #6903: PIP-61: Advertise multiple addresses

2020-05-21 Thread GitBox
zplinuxlover commented on pull request #6903: URL: https://github.com/apache/pulsar/pull/6903#issuecomment-632447178 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] xuesong172500 commented on pull request #7006: issue #6698, Add instantiation interface in Pulsar function (#6706)

2020-05-21 Thread GitBox
xuesong172500 commented on pull request #7006: URL: https://github.com/apache/pulsar/pull/7006#issuecomment-632495479 done. daxia_...@126.com From: Sergii Zhevzhyk Date: 2020-05-22 03:12 To: apache/pulsar CC: xuesong172500; Mention Subject: Re:

[GitHub] [pulsar] whisper-bye commented on issue #6239: Pulsar Functions not working in LocalRunner (2.5.0)

2020-05-21 Thread GitBox
whisper-bye commented on issue #6239: URL: https://github.com/apache/pulsar/issues/6239#issuecomment-632465500 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] Anonymitaet commented on issue #6110: [Doc 2.5.0] The content of Connector Admin CLI is blank

2020-05-21 Thread GitBox
Anonymitaet commented on issue #6110: URL: https://github.com/apache/pulsar/issues/6110#issuecomment-632465759 @huangdx0726 this file "reference-connector-admin.md" is removed from doc. If you want to read Connector Admin CLI doc, see http://pulsar.apache.org/docs/en/next/io-cli/.

[GitHub] [pulsar] Anonymitaet closed issue #6110: [Doc 2.5.0] The content of Connector Admin CLI is blank

2020-05-21 Thread GitBox
Anonymitaet closed issue #6110: URL: https://github.com/apache/pulsar/issues/6110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] xuesong172500 closed pull request #7006: issue #6698, Add instantiation interface in Pulsar function (#6706)

2020-05-21 Thread GitBox
xuesong172500 closed pull request #7006: URL: https://github.com/apache/pulsar/pull/7006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] fretiq opened a new pull request #7014: [C++] Expose zstd and Snappy compression to C API

2020-05-21 Thread GitBox
fretiq opened a new pull request #7014: URL: https://github.com/apache/pulsar/pull/7014 ### Motivation I'd like to be able to use zstd and/or Snappy compression with the C API, so I've added them to the `pulsar_compression_type` enum. ### Modifications I've added

[pulsar-helm-chart] branch master updated: Use regular 2-2-2 BK client settings by default (#13)

2020-05-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 6e9ad25 Use regular 2-2-2 BK client

[GitHub] [pulsar] srkukarni commented on pull request #7011: Fix break changes in namespace offload policy and RabbitMQ sink.

2020-05-21 Thread GitBox
srkukarni commented on pull request #7011: URL: https://github.com/apache/pulsar/pull/7011#issuecomment-632460493 The most recent failure was in replicator test This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] merlimat commented on pull request #6787: Using Readers still causes backlog quota to be observed

2020-05-21 Thread GitBox
merlimat commented on pull request #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-632499624 > What I am trying to ensure is if there is a reader actively reading events, we should be able to make sure the continuity of the events it read. The only way to give a

[GitHub] [pulsar] jerrypeng commented on pull request #6787: Using Readers still causes backlog quota to be observed

2020-05-21 Thread GitBox
jerrypeng commented on pull request #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-632499123 @sijie I don't know if adding yet another config to switch the behavior of the reader is a good idea. I have already heard from members of industry/community that there are

[GitHub] [pulsar] xgdgsc opened a new issue #7013: pulsar/deployment/kubernetes/helm/scripts not included in release tarball

2020-05-21 Thread GitBox
xgdgsc opened a new issue #7013: URL: https://github.com/apache/pulsar/issues/7013 **Describe the bug** I'm following the doc at http://pulsar.apache.org/docs/en/kubernetes-helm/#step-1-install-pulsar-helm-chart I thought using version from tarball would be the same and found the path

[GitHub] [pulsar] srkukarni commented on pull request #7011: Fix break changes in namespace offload policy and RabbitMQ sink.

2020-05-21 Thread GitBox
srkukarni commented on pull request #7011: URL: https://github.com/apache/pulsar/pull/7011#issuecomment-632492538 @codelipenghui another error in filesystemoffload integration test This is an automated message from the

[GitHub] [pulsar] vzhikserg commented on pull request #7006: issue #6698, Add instantiation interface in Pulsar function (#6706)

2020-05-21 Thread GitBox
vzhikserg commented on pull request #7006: URL: https://github.com/apache/pulsar/pull/7006#issuecomment-632290943 @xuesong172500 it seems you've created 2 identical pull requests. Please close one of them This is an

[GitHub] [pulsar] srkukarni commented on pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
srkukarni commented on pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#issuecomment-632290148 @jerrypeng 1. Some methods are updating multiple counters/gauages. That still has to be in sync block to ensure that we get consistent stats 2. The fact that today this

[GitHub] [pulsar] codelipenghui commented on a change in pull request #7011: Fix break changes in namespace offload policy and RabbitMQ sink.

2020-05-21 Thread GitBox
codelipenghui commented on a change in pull request #7011: URL: https://github.com/apache/pulsar/pull/7011#discussion_r428788947 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -1062,17 +1062,6 @@ public void

[GitHub] [pulsar] guillaumepitel opened a new issue #7012: Null pointer exception when add ledger fails

2020-05-21 Thread GitBox
guillaumepitel opened a new issue #7012: URL: https://github.com/apache/pulsar/issues/7012 **Describe the bug** Pulsar starts logging a lot of the following errors, then repeatedly fails to add ledger leading to problems in messages handling (the message flow speed goes down and start

[GitHub] [pulsar] jerrypeng commented on pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
jerrypeng commented on pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#issuecomment-632331138 @srkukarni > Some methods are updating multiple counters/gauages. That still has to be in sync block to ensure that we get consistent stats. Given a specific

[GitHub] [pulsar] merlimat commented on a change in pull request #7011: Fix break changes in namespace offload policy and RabbitMQ sink.

2020-05-21 Thread GitBox
merlimat commented on a change in pull request #7011: URL: https://github.com/apache/pulsar/pull/7011#discussion_r428760906 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -1062,17 +1062,6 @@ public void

[GitHub] [pulsar] merlimat commented on a change in pull request #7011: Fix break changes in namespace offload policy and RabbitMQ sink.

2020-05-21 Thread GitBox
merlimat commented on a change in pull request #7011: URL: https://github.com/apache/pulsar/pull/7011#discussion_r428840205 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -1062,17 +1062,6 @@ public void

[GitHub] [pulsar] BewareMyPower commented on pull request #6796: [C++] Support cumulative acknowledgement when consuming partitioned topics

2020-05-21 Thread GitBox
BewareMyPower commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-632188116 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] srkukarni commented on a change in pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
srkukarni commented on a change in pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#discussion_r428851965 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -801,4 +810,12 @@ public

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-21 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-632188618 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] 315157973 removed a comment on pull request #6968: Fixes #6929 KeyValue schema supports nested generics type

2020-05-21 Thread GitBox
315157973 removed a comment on pull request #6968: URL: https://github.com/apache/pulsar/pull/6968#issuecomment-631358959 > @315157973 the direction of this change looks great in general. However, I am not sure adding `Type functionGenericType` into the source and sink configs is the best

[GitHub] [pulsar] davidlanouette commented on issue #6587: Requesting Pulsar to support IoT protocols - STOMP, AMQP, MQTT, WSS

2020-05-21 Thread GitBox
davidlanouette commented on issue #6587: URL: https://github.com/apache/pulsar/issues/6587#issuecomment-632093960 @sijie Thanks for the update! Do you have a link to that repo? I'd be interested in contributing if I can.

[pulsar] branch master updated: Add Docs for c# client (#7003)

2020-05-21 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository. zhaijia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e29860e Add Docs for c# client (#7003)

[GitHub] [pulsar] jiazhai merged pull request #7003: Add Docs for c# client

2020-05-21 Thread GitBox
jiazhai merged pull request #7003: URL: https://github.com/apache/pulsar/pull/7003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] cckellogg commented on a change in pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
cckellogg commented on a change in pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#discussion_r428723696 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -801,4 +810,12 @@ public

[GitHub] [pulsar] cckellogg commented on a change in pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
cckellogg commented on a change in pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#discussion_r428728617 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -801,4 +810,12 @@ public

[GitHub] [pulsar] cckellogg closed pull request #7008: Fix possible null pointer when getting instance metrics.

2020-05-21 Thread GitBox
cckellogg closed pull request #7008: URL: https://github.com/apache/pulsar/pull/7008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] cckellogg commented on pull request #7008: Fix possible null pointer when getting instance metrics.

2020-05-21 Thread GitBox
cckellogg commented on pull request #7008: URL: https://github.com/apache/pulsar/pull/7008#issuecomment-632152938 Being fixed in another PR #7010 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] srkukarni commented on a change in pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
srkukarni commented on a change in pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#discussion_r428732247 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -801,4 +810,12 @@ public

[GitHub] [pulsar] srkukarni commented on a change in pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-21 Thread GitBox
srkukarni commented on a change in pull request #7010: URL: https://github.com/apache/pulsar/pull/7010#discussion_r428737674 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -801,4 +810,12 @@ public

[GitHub] [pulsar] hari819 commented on issue #6236: SSL/TLS Configuration for Zookeeper,BookKeeper and Pulsar

2020-05-21 Thread GitBox
hari819 commented on issue #6236: URL: https://github.com/apache/pulsar/issues/6236#issuecomment-632103219 @rounak11 see if it helps , `sslQuorum=true serverCnxnFactory=org.apache.zookeeper.server.NettyServerCnxnFactory

[GitHub] [pulsar] codelipenghui opened a new pull request #7011: Fix break changes in namespace offload policy and RabbitMQ sink.

2020-05-21 Thread GitBox
codelipenghui opened a new pull request #7011: URL: https://github.com/apache/pulsar/pull/7011 ### Motivation Fix break changes in namespace offload policy and RabbitMQ sink. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen,

[GitHub] [pulsar] 315157973 commented on pull request #6968: Fixes #6929 KeyValue schema supports nested generics type

2020-05-21 Thread GitBox
315157973 commented on pull request #6968: URL: https://github.com/apache/pulsar/pull/6968#issuecomment-632138279 > @315157973 the direction of this change looks great in general. However, I am not sure adding `Type functionGenericType` into the source and sink configs is the best