[pulsar-client-go] branch master updated: Embed Go SDK version to 0.9.0 (#854)

2022-09-29 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new dd63a4c Embed Go SDK version to 0.9.0

[GitHub] [pulsar-client-go] wolfstudy merged pull request #854: Embed Go SDK version to 0.9.0

2022-09-29 Thread GitBox
wolfstudy merged PR #854: URL: https://github.com/apache/pulsar-client-go/pull/854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#db26073)

2022-09-29 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 4f0f05298e9 Docs sync done from

[GitHub] [pulsar-client-cpp] BewareMyPower opened a new issue, #4: Add license headers and related checks

2022-09-29 Thread GitBox
BewareMyPower opened a new issue, #4: URL: https://github.com/apache/pulsar-client-cpp/issues/4 The LICENSE file is missed currently. Before moving the C++ client from Pulsar main repo here, the license check was performed by `mvn license:check`. After adding the LICENSE file, we

[GitHub] [pulsar-client-cpp] merlimat opened a new pull request, #3: Added .asf.yaml file

2022-09-29 Thread GitBox
merlimat opened a new pull request, #3: URL: https://github.com/apache/pulsar-client-cpp/pull/3 Added similar settings as used in main pulsar repo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar-client-go] branch branch-0.9.0 updated (ea6eccf -> dd63a4c)

2022-09-29 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch branch-0.9.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git from ea6eccf feat: support multiple schema version for producer and consumer (#611) add 6a8e7f3

[GitHub] [pulsar] Apurva007 commented on issue #17878: [Doc] Fix Admin Interface docs for Managing partitioned topics

2022-09-29 Thread GitBox
Apurva007 commented on issue #17878: URL: https://github.com/apache/pulsar/issues/17878#issuecomment-1261827720 @momo-jun Thanks alot! I was trying to learn about Apache Pulsar and stumbled upon this issue. I would gladly help fix this issue.  -- This is an automated message from the

[GitHub] [pulsar] lordcheng10 closed pull request #17726: Fix metric messagesConsumedCounter calculation error

2022-09-29 Thread GitBox
lordcheng10 closed pull request #17726: Fix metric messagesConsumedCounter calculation error URL: https://github.com/apache/pulsar/pull/17726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #3: Added .asf.yaml file

2022-09-29 Thread GitBox
BewareMyPower commented on PR #3: URL: https://github.com/apache/pulsar-client-cpp/pull/3#issuecomment-1261807884 Hi Matteo, do you know how to configure `Squash and merge` by default?

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17842: [improve][broker]Improve PersistentMessageExpiryMonitor expire speed when ledger not existed

2022-09-29 Thread GitBox
AnonHxy commented on code in PR #17842: URL: https://github.com/apache/pulsar/pull/17842#discussion_r983118055 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java: ## @@ -191,9 +192,38 @@ public void

[GitHub] [pulsar-client-python] BewareMyPower opened a new pull request, #2: Add .asf.yaml file

2022-09-29 Thread GitBox
BewareMyPower opened a new pull request, #2: URL: https://github.com/apache/pulsar-client-python/pull/2 See https://github.com/apache/pulsar-client-cpp/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[pulsar] branch master updated: [fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage (#17837)

2022-09-29 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new dc44ea28ee0

[GitHub] [pulsar] congbobo184 merged pull request #17837: [fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage

2022-09-29 Thread GitBox
congbobo184 merged PR #17837: URL: https://github.com/apache/pulsar/pull/17837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] congbobo184 closed issue #14109: Flaky-test: PerformanceTransactionTest.testConsumeTxnMessage

2022-09-29 Thread GitBox
congbobo184 closed issue #14109: Flaky-test: PerformanceTransactionTest.testConsumeTxnMessage URL: https://github.com/apache/pulsar/issues/14109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] AnonHxy commented on pull request #17854: [improve][java-client]Shrink BatchMessageContainer maxBatchSize

2022-09-29 Thread GitBox
AnonHxy commented on PR #17854: URL: https://github.com/apache/pulsar/pull/17854#issuecomment-1261847448 @tjiuming @Jason918 @merlimat @codelipenghui @PTAL thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-client-python] Demogorgon314 commented on pull request #1: PIP-209: Compile Python client wrapper

2022-09-29 Thread GitBox
Demogorgon314 commented on PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#issuecomment-1261825225 > I think we still needs to import https://github.com/apache/pulsar-client-cpp as the submodule. +1 -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-client-python] merlimat merged pull request #2: Add .asf.yaml file

2022-09-29 Thread GitBox
merlimat merged PR #2: URL: https://github.com/apache/pulsar-client-python/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-client-python] branch main updated: Add .asf.yaml file (#2)

2022-09-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git The following commit(s) were added to refs/heads/main by this push: new 4e6f57e Add .asf.yaml file (#2)

[GitHub] [pulsar-client-cpp] merlimat merged pull request #3: Added .asf.yaml file

2022-09-29 Thread GitBox
merlimat merged PR #3: URL: https://github.com/apache/pulsar-client-cpp/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-client-cpp] branch main updated: Added .asf.yaml file (#3)

2022-09-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new e145d35 Added .asf.yaml file (#3)

[GitHub] [pulsar-client-cpp] merlimat commented on a diff in pull request #3: Added .asf.yaml file

2022-09-29 Thread GitBox
merlimat commented on code in PR #3: URL: https://github.com/apache/pulsar-client-cpp/pull/3#discussion_r983099400 ## .asf.yaml: ## @@ -0,0 +1,73 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #3: Added .asf.yaml file

2022-09-29 Thread GitBox
BewareMyPower commented on code in PR #3: URL: https://github.com/apache/pulsar-client-cpp/pull/3#discussion_r983099245 ## .asf.yaml: ## @@ -0,0 +1,73 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE

[GitHub] [pulsar-client-cpp] merlimat commented on pull request #3: Added .asf.yaml file

2022-09-29 Thread GitBox
merlimat commented on PR #3: URL: https://github.com/apache/pulsar-client-cpp/pull/3#issuecomment-1261808470 That would be from these lines: ``` enabled_merge_buttons: # enable squash button: squash: true # disable merge button: merge: false

[pulsar-client-go] annotated tag v0.9.0-candidate-2 updated (dd63a4c -> 6b9884d)

2022-09-29 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to annotated tag v0.9.0-candidate-2 in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git *** WARNING: tag v0.9.0-candidate-2 was modified! *** from dd63a4c (commit) to 6b9884d

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #17867: [fix][broker] Fix system service namespace create internal event topic.

2022-09-29 Thread GitBox
Technoboy- commented on code in PR #17867: URL: https://github.com/apache/pulsar/pull/17867#discussion_r983107135 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/systopic/PartitionedSystemTopicTest.java: ## @@ -172,10 +173,31 @@ public void

svn commit: r57071 - in /dev/pulsar/pulsar-client-go-0.9.0-candidate-2: ./ apache-pulsar-client-go-0.9.0-candidate-2-src.tar.gz apache-pulsar-client-go-0.9.0-candidate-2-src.tar.gz.asc apache-pulsar-c

2022-09-29 Thread rxl
Author: rxl Date: Thu Sep 29 06:29:56 2022 New Revision: 57071 Log: Staging artifacts and signature for Pulsar Client Go release 0.9.0-candidate-2 Added: dev/pulsar/pulsar-client-go-0.9.0-candidate-2/

[GitHub] [pulsar] momo-jun commented on issue #17878: [Doc] Fix Admin Interface docs for Managing partitioned topics

2022-09-29 Thread GitBox
momo-jun commented on issue #17878: URL: https://github.com/apache/pulsar/issues/17878#issuecomment-1261826613 @Apurva007 welcome to the Pulsar community. It's a good first issue. Would you like to fix it? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #17777: [fix][txn] optimize the ack/send future in TransactionImpl

2022-09-29 Thread GitBox
liangyepianzhou commented on code in PR #1: URL: https://github.com/apache/pulsar/pull/1#discussion_r983129366 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/transaction/TransactionImpl.java: ## @@ -61,8 +64,12 @@ public class TransactionImpl implements

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #17777: [fix][txn] optimize the ack/send future in TransactionImpl

2022-09-29 Thread GitBox
liangyepianzhou commented on code in PR #1: URL: https://github.com/apache/pulsar/pull/1#discussion_r983129636 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java: ## @@ -318,6 +319,84 @@ public Consumer getConsumer(String topicName,

[pulsar] branch master updated (dc44ea28ee0 -> 0f53c790ff2)

2022-09-29 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from dc44ea28ee0 [fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage (#17837) add 0f53c790ff2

[GitHub] [pulsar] congbobo184 merged pull request #17701: [improve][txn]PIP-160 make txn components supports buffered writer metrics

2022-09-29 Thread GitBox
congbobo184 merged PR #17701: URL: https://github.com/apache/pulsar/pull/17701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-python] BewareMyPower commented on pull request #1: PIP-209: Compile Python client wrapper

2022-09-29 Thread GitBox
BewareMyPower commented on PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#issuecomment-1261816420 In addition, some tests in `pulsar_test.py` might already rely on the unreleased C++ APIs as you said

[GitHub] [pulsar] momo-jun closed issue #16571: Is there any way to delete a broken topic

2022-09-29 Thread GitBox
momo-jun closed issue #16571: Is there any way to delete a broken topic URL: https://github.com/apache/pulsar/issues/16571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar-client-python] BewareMyPower commented on pull request #1: PIP-209: Compile Python client wrapper

2022-09-29 Thread GitBox
BewareMyPower commented on PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#issuecomment-1261854544 I'm going to work for the submodule way. The workflow (for CI in future) is: 1. Clone the `pulsar-client-cpp` submodule. 2. Add a `build-client-cpp.sh` to build the

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #17777: [fix][txn] optimize the ack/send future in TransactionImpl

2022-09-29 Thread GitBox
liangyepianzhou commented on code in PR #1: URL: https://github.com/apache/pulsar/pull/1#discussion_r983129366 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/transaction/TransactionImpl.java: ## @@ -61,8 +64,12 @@ public class TransactionImpl implements

[GitHub] [pulsar-test-infra] tisonkun commented on pull request #75: feat: add action of check-pr-title to ensure PR title matches Naming Convention Guide

2022-09-29 Thread GitBox
tisonkun commented on PR #75: URL: https://github.com/apache/pulsar-test-infra/pull/75#issuecomment-1261862308 I believe this feature is separated from the original `docbot` functionality. If I implement this proposal, I will simply use standard Conventional Commit + GitHub Apps like

[GitHub] [pulsar] nodece commented on a diff in pull request #17808: [improve][doc] Improve TLS encryption

2022-09-29 Thread GitBox
nodece commented on code in PR #17808: URL: https://github.com/apache/pulsar/pull/17808#discussion_r983212330 ## site2/docs/security-tls-transport.md: ## @@ -475,46 +407,97 @@ brokerClientTlsKeyStore=/var/private/tls/client.keystore.jks

[GitHub] [pulsar] nodece commented on a diff in pull request #17808: [improve][doc] Improve TLS encryption

2022-09-29 Thread GitBox
nodece commented on code in PR #17808: URL: https://github.com/apache/pulsar/pull/17808#discussion_r983212330 ## site2/docs/security-tls-transport.md: ## @@ -475,46 +407,97 @@ brokerClientTlsKeyStore=/var/private/tls/client.keystore.jks

[GitHub] [pulsar] nodece commented on a diff in pull request #17808: [improve][doc] Improve TLS encryption

2022-09-29 Thread GitBox
nodece commented on code in PR #17808: URL: https://github.com/apache/pulsar/pull/17808#discussion_r983212600 ## site2/docs/security-tls-transport.md: ## @@ -475,46 +407,97 @@ brokerClientTlsKeyStore=/var/private/tls/client.keystore.jks

[GitHub] [pulsar] ethqunzhong commented on pull request #17803: [fix][common] make managedLedgerOffloadedReadPriority compatible with broker property

2022-09-29 Thread GitBox
ethqunzhong commented on PR #17803: URL: https://github.com/apache/pulsar/pull/17803#issuecomment-1261937515 @hangc0276 ready to be merge after ci-test passed in my own repo PR. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] liangyepianzhou opened a new pull request, #17888: [fix][conf] Fix port conflict in bookkeeper.conf

2022-09-29 Thread GitBox
liangyepianzhou opened a new pull request, #17888: URL: https://github.com/apache/pulsar/pull/17888 ### Motivation prometheusStatsHttpPort=8000 and httpServerPort=8000, there will be a port conflict when deploy a cluster. ### Modification Change the

[GitHub] [pulsar] lhotari commented on pull request #17870: [improve][broker] Use separate IO event loop group for internal client.

2022-09-29 Thread GitBox
lhotari commented on PR #17870: URL: https://github.com/apache/pulsar/pull/17870#issuecomment-1262048972 > If the internal client uses a lot of threads or the exception handling is not good (such as frequent exception thread). It will affect the throughput of the entire broker.

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17831: [fix][proxy] Fix refresh client auth

2022-09-29 Thread GitBox
mattisonchao commented on code in PR #17831: URL: https://github.com/apache/pulsar/pull/17831#discussion_r983161996 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyClientCnx.java: ## @@ -54,10 +59,54 @@ protected ByteBuf newConnectCommand() throws Exception {

[GitHub] [pulsar-client-python] BewareMyPower commented on pull request #1: PIP-209: Compile Python client wrapper

2022-09-29 Thread GitBox
BewareMyPower commented on PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#issuecomment-1261885493 @shibd No. It's a submodule, we need an extra PR to update the commit of the submodule if the upstream C++ client has introduced a new feature. See

[GitHub] [pulsar] nodece commented on a diff in pull request #17831: [fix][proxy] Fix refresh client auth

2022-09-29 Thread GitBox
nodece commented on code in PR #17831: URL: https://github.com/apache/pulsar/pull/17831#discussion_r983169093 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyClientCnx.java: ## @@ -18,46 +18,61 @@ */ package org.apache.pulsar.proxy.server; -import

[GitHub] [pulsar-client-python] BewareMyPower commented on pull request #1: PIP-209: Compile Python client wrapper

2022-09-29 Thread GitBox
BewareMyPower commented on PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#issuecomment-1261894769 > will we print log the version that depends on C++ at startup? I think it's unnecessary. Just like whether would you print the version of all dependencies in Java.

[GitHub] [pulsar] andrasbeni commented on pull request #17826: [fix][cli] Check numMessages after incrementing counter

2022-09-29 Thread GitBox
andrasbeni commented on PR #17826: URL: https://github.com/apache/pulsar/pull/17826#issuecomment-1261905816 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] thetumbled opened a new issue, #17885: [Bug] Incorrect TotalNicLimit collected by pulsar

2022-09-29 Thread GitBox
thetumbled opened a new issue, #17885: URL: https://github.com/apache/pulsar/issues/17885 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 2.11 ### Minimal reproduce step

[GitHub] [pulsar-client-python] BewareMyPower opened a new issue, #4: Add CI for build and tests

2022-09-29 Thread GitBox
BewareMyPower opened a new issue, #4: URL: https://github.com/apache/pulsar-client-python/issues/4 See: - https://github.com/apache/pulsar/blob/0f53c790ff2e3051ebc80aa8d2c9253265725aeb/.github/workflows/pulsar-ci.yaml#L480-L482 The original build and test process is here:

[GitHub] [pulsar] Jason918 commented on a diff in pull request #15914: [Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion

2022-09-29 Thread GitBox
Jason918 commented on code in PR #15914: URL: https://github.com/apache/pulsar/pull/15914#discussion_r983270598 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java: ## @@ -873,23 +891,101 @@ public void

[GitHub] [pulsar-test-infra] mangoGoForward commented on pull request #75: feat: add action of check-pr-title to ensure PR title matches Naming Convention Guide

2022-09-29 Thread GitBox
mangoGoForward commented on PR #75: URL: https://github.com/apache/pulsar-test-infra/pull/75#issuecomment-1261984830 > @mangoGoForward Could you also provide corresponding tests in your own forked pulsar repo, and put links under this PR? @maxsxu Please look at

[GitHub] [pulsar-client-go] Gleiphir2769 commented on a diff in pull request #805: [Issue 456] Support chunking for big messages.

2022-09-29 Thread GitBox
Gleiphir2769 commented on code in PR #805: URL: https://github.com/apache/pulsar-client-go/pull/805#discussion_r983291109 ## pulsar/consumer_partition.go: ## @@ -1475,3 +1609,210 @@ func convertToMessageID(id *pb.MessageIdData) trackingMessageID { return msgID } +

[GitHub] [pulsar-client-cpp] Demogorgon314 opened a new pull request, #7: Add bug report issue template

2022-09-29 Thread GitBox
Demogorgon314 opened a new pull request, #7: URL: https://github.com/apache/pulsar-client-cpp/pull/7 Added similar bug report template as used in main pulsar repo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-client-go] Gleiphir2769 commented on a diff in pull request #805: [Issue 456] Support chunking for big messages.

2022-09-29 Thread GitBox
Gleiphir2769 commented on code in PR #805: URL: https://github.com/apache/pulsar-client-go/pull/805#discussion_r983291109 ## pulsar/consumer_partition.go: ## @@ -1475,3 +1609,210 @@ func convertToMessageID(id *pb.MessageIdData) trackingMessageID { return msgID } +

[GitHub] [pulsar-client-go] Gleiphir2769 commented on a diff in pull request #805: [Issue 456] Support chunking for big messages.

2022-09-29 Thread GitBox
Gleiphir2769 commented on code in PR #805: URL: https://github.com/apache/pulsar-client-go/pull/805#discussion_r983303572 ## pulsar/consumer_partition.go: ## @@ -1475,3 +1609,210 @@ func convertToMessageID(id *pb.MessageIdData) trackingMessageID { return msgID } +

[GitHub] [pulsar] poorbarcode closed issue #15370: [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack store

2022-09-29 Thread GitBox
poorbarcode closed issue #15370: [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack store URL: https://github.com/apache/pulsar/issues/15370 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] HQebupt opened a new pull request, #17884: [improve][broker]add active status into cursor stats

2022-09-29 Thread GitBox
HQebupt opened a new pull request, #17884: URL: https://github.com/apache/pulsar/pull/17884 ### Motivation The active state indicates whether a cursor is active. And it affects the cache hit rate, because inactive cursors will be evicted from the entry cache. This active state helps to

[GitHub] [pulsar-client-python] shibd commented on pull request #1: PIP-209: Compile Python client wrapper

2022-09-29 Thread GitBox
shibd commented on PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#issuecomment-1261891518 Suddenly curious, will we print log the version that depends on C++ at startup? Case Log: ``` pulsar-client-python: x.x.x depends pulsar-client-cpp: x.x.x or

[GitHub] [pulsar-client-go] hunter2046 commented on issue #739: `NewProtoSchema` is initialized as AvroSchema

2022-09-29 Thread GitBox
hunter2046 commented on issue #739: URL: https://github.com/apache/pulsar-client-go/issues/739#issuecomment-1261945119 Hey @bpereto, have you found a way to work around this? I just found the same thing and am wondering how I should convert the struct that represents the protobuf into an

[GitHub] [pulsar-client-python] BewareMyPower opened a new pull request, #3: PIP-209: Support build Python client wrapper

2022-09-29 Thread GitBox
BewareMyPower opened a new pull request, #3: URL: https://github.com/apache/pulsar-client-python/pull/3 ### Modifications - Add [pulsar-client-cpp](https://github.com/apache/pulsar-client-cpp) as the submodule - Add `build-client-cpp.sh` to build the Pulsar C++ client. - Fix the

[GitHub] [pulsar] syhily commented on issue #17876: [Bug] TransactionCoordinatorClientImpl.start() hangs forever

2022-09-29 Thread GitBox
syhily commented on issue #17876: URL: https://github.com/apache/pulsar/issues/17876#issuecomment-1261957247 The detailed test log is here: [mvn-1.log](https://github.com/apache/pulsar/files/9672766/mvn-1.log). -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] lhotari merged pull request #17883: [fix][flaky-test]ProxyConnectionThrottlingTest.testInboundConnection

2022-09-29 Thread GitBox
lhotari merged PR #17883: URL: https://github.com/apache/pulsar/pull/17883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (0f53c790ff2 -> 3de690d44de)

2022-09-29 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 0f53c790ff2 [improve][txn]PIP-160 make txn components supports buffered writer metrics (#17701) add

[GitHub] [pulsar-client-cpp] BewareMyPower commented on issue #5: Add CI for build and tests

2022-09-29 Thread GitBox
BewareMyPower commented on issue #5: URL: https://github.com/apache/pulsar-client-cpp/issues/5#issuecomment-1261967294 Thanks @yaalsn, I assigned it to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar-client-go] RobertIndie commented on a diff in pull request #805: [Issue 456] Support chunking for big messages.

2022-09-29 Thread GitBox
RobertIndie commented on code in PR #805: URL: https://github.com/apache/pulsar-client-go/pull/805#discussion_r980988431 ## pulsar/consumer_impl.go: ## @@ -91,6 +90,15 @@ func newConsumer(client *client, options ConsumerOptions) (Consumer, error) { } }

[GitHub] [pulsar] Jason918 commented on a diff in pull request #15914: [Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion

2022-09-29 Thread GitBox
Jason918 commented on code in PR #15914: URL: https://github.com/apache/pulsar/pull/15914#discussion_r983270598 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java: ## @@ -873,23 +891,101 @@ public void

[pulsar] branch master updated (9026d1954d1 -> df5e0e1869f)

2022-09-29 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 9026d1954d1 [Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914) add df5e0e1869f

[GitHub] [pulsar] codelipenghui merged pull request #17826: [fix][cli] Check numMessages after incrementing counter

2022-09-29 Thread GitBox
codelipenghui merged PR #17826: URL: https://github.com/apache/pulsar/pull/17826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-cpp] Demogorgon314 opened a new pull request, #8: Add pull request template

2022-09-29 Thread GitBox
Demogorgon314 opened a new pull request, #8: URL: https://github.com/apache/pulsar-client-cpp/pull/8 Fixes #6 ### Motivation Add pull request template -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] coderzc opened a new pull request, #17887: [improve][test] Improve SimpleProducerConsumerTest to reduce the execution time

2022-09-29 Thread GitBox
coderzc opened a new pull request, #17887: URL: https://github.com/apache/pulsar/pull/17887 Fixed * https://github.com/apache/pulsar/issues/17634 ### Modifications only execution once `setup`/`clean` and clean tenants/namespaces/producer/consumer after running the test.

[GitHub] [pulsar] nodece commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic

2022-09-29 Thread GitBox
nodece commented on code in PR #17557: URL: https://github.com/apache/pulsar/pull/17557#discussion_r983306840 ## .github/workflows/ci-documentbot.yml: ## @@ -43,4 +43,50 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} LABEL_WATCH_LIST:

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17831: [fix][proxy] Fix refresh client auth

2022-09-29 Thread GitBox
codelipenghui commented on code in PR #17831: URL: https://github.com/apache/pulsar/pull/17831#discussion_r983309654 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyClientCnx.java: ## @@ -54,10 +59,54 @@ protected ByteBuf newConnectCommand() throws Exception {

[GitHub] [pulsar-client-cpp] BewareMyPower opened a new issue, #5: Add CI for build and tests

2022-09-29 Thread GitBox
BewareMyPower opened a new issue, #5: URL: https://github.com/apache/pulsar-client-cpp/issues/5 See: - https://github.com/apache/pulsar/blob/master/.github/workflows/ci-cpp-build.yaml -

[GitHub] [pulsar-client-python] shibd commented on pull request #1: PIP-209: Compile Python client wrapper

2022-09-29 Thread GitBox
shibd commented on PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#issuecomment-1261876036 > I think we still needs to import https://github.com/apache/pulsar-client-cpp as the submodule. > > If the new feature is ready in C++ client, we don't have to wait a new

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17831: [fix][proxy] Fix refresh client auth

2022-09-29 Thread GitBox
mattisonchao commented on code in PR #17831: URL: https://github.com/apache/pulsar/pull/17831#discussion_r983161996 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyClientCnx.java: ## @@ -54,10 +59,54 @@ protected ByteBuf newConnectCommand() throws Exception {

[GitHub] [pulsar] eolivelli commented on a diff in pull request #15914: [Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion

2022-09-29 Thread GitBox
eolivelli commented on code in PR #15914: URL: https://github.com/apache/pulsar/pull/15914#discussion_r983183760 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java: ## @@ -873,23 +891,101 @@ public void

[GitHub] [pulsar] ethqunzhong commented on pull request #17803: [fix][common] make managedLedgerOffloadedReadPriority compatible with broker property

2022-09-29 Thread GitBox
ethqunzhong commented on PR #17803: URL: https://github.com/apache/pulsar/pull/17803#issuecomment-1261933495 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-cpp] yaalsn commented on issue #5: Add CI for build and tests

2022-09-29 Thread GitBox
yaalsn commented on issue #5: URL: https://github.com/apache/pulsar-client-cpp/issues/5#issuecomment-1261936954 @BewareMyPower @merlimat I'll add this workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] andrasbeni commented on issue #17132: [test] Integration test coverage

2022-09-29 Thread GitBox
andrasbeni commented on issue #17132: URL: https://github.com/apache/pulsar/issues/17132#issuecomment-1261974417 @codelipenghui , I believe integration tests are too expensive to do a full validation of output and command line parameters. Having taken a quick look at admin command

[GitHub] [pulsar-client-go] Gleiphir2769 commented on a diff in pull request #805: [Issue 456] Support chunking for big messages.

2022-09-29 Thread GitBox
Gleiphir2769 commented on code in PR #805: URL: https://github.com/apache/pulsar-client-go/pull/805#discussion_r983277131 ## pulsar/producer_partition.go: ## @@ -1050,3 +1270,41 @@ func (p *partitionProducer) _getConn() internal.Connection { //invariant is

[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #3: PIP-209: Support build Python client wrapper

2022-09-29 Thread GitBox
BewareMyPower commented on code in PR #3: URL: https://github.com/apache/pulsar-client-python/pull/3#discussion_r983285929 ## README.md: ## @@ -0,0 +1,72 @@ + + +# Pulsar Python client library + + +## How to build it from source Review Comment: The submodule download logic

[GitHub] [pulsar] cbornet commented on pull request #17877: [fix][functions] Fix the download of builtin Functions

2022-09-29 Thread GitBox
cbornet commented on PR #17877: URL: https://github.com/apache/pulsar/pull/17877#issuecomment-1261999089 > it would be great to add some tests Yes of course. I tested it manually for now. I'll add tests for the download function in a subsequent PR. -- This is an automated message

[GitHub] [pulsar] prodigy91 opened a new issue, #17886: Update Schema APIs requires Tenant Admin Permissions which is a much broader than required.

2022-09-29 Thread GitBox
prodigy91 opened a new issue, #17886: URL: https://github.com/apache/pulsar/issues/17886 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation Quite recently the GET /schema API

[GitHub] [pulsar-client-python] BewareMyPower opened a new issue, #5: Add license headers and related checks

2022-09-29 Thread GitBox
BewareMyPower opened a new issue, #5: URL: https://github.com/apache/pulsar-client-python/issues/5 Similar to https://github.com/apache/pulsar-client-cpp/issues/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] eolivelli merged pull request #15914: [Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion

2022-09-29 Thread GitBox
eolivelli merged PR #15914: URL: https://github.com/apache/pulsar/pull/15914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (3de690d44de -> 9026d1954d1)

2022-09-29 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 3de690d44de [fix][flaky-test]ProxyConnectionThrottlingTest.testInboundConnection (#17883) add 9026d1954d1

[GitHub] [pulsar] eolivelli closed issue #9962: [Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion

2022-09-29 Thread GitBox
eolivelli closed issue #9962: [Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion URL: https://github.com/apache/pulsar/issues/9962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-client-python] Demogorgon314 commented on a diff in pull request #3: PIP-209: Support build Python client wrapper

2022-09-29 Thread GitBox
Demogorgon314 commented on code in PR #3: URL: https://github.com/apache/pulsar-client-python/pull/3#discussion_r983280815 ## README.md: ## @@ -0,0 +1,72 @@ + + +# Pulsar Python client library + + +## How to build it from source Review Comment: We can add one step to let

[GitHub] [pulsar] aloyszhang commented on pull request #17722: support setting bundle number for default namespace when set up cluster

2022-09-29 Thread GitBox
aloyszhang commented on PR #17722: URL: https://github.com/apache/pulsar/pull/17722#issuecomment-1261995182 cc @codelipenghui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar-client-go] Gleiphir2769 commented on a diff in pull request #805: [Issue 456] Support chunking for big messages.

2022-09-29 Thread GitBox
Gleiphir2769 commented on code in PR #805: URL: https://github.com/apache/pulsar-client-go/pull/805#discussion_r983281714 ## pulsar/consumer_impl.go: ## @@ -91,6 +90,15 @@ func newConsumer(client *client, options ConsumerOptions) (Consumer, error) { } }

[GitHub] [pulsar] poorbarcode commented on pull request #17861: [fix][flaky-test]AdminApi2Test.cleanup

2022-09-29 Thread GitBox
poorbarcode commented on PR #17861: URL: https://github.com/apache/pulsar/pull/17861#issuecomment-1261995892 Hi @lhotari @nicoloboschi Could you take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar-client-python] eolivelli commented on a diff in pull request #1: PIP-209: Compile Python client wrapper

2022-09-29 Thread GitBox
eolivelli commented on code in PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#discussion_r983319691 ## build-mac-wheels.sh: ## @@ -246,6 +247,43 @@ else echo "Using cached LibCurl" fi

[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #17797: [fix][broker] Update new bundle-range to policies after bundle split

2022-09-29 Thread GitBox
lordcheng10 commented on code in PR #17797: URL: https://github.com/apache/pulsar/pull/17797#discussion_r983318634 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -880,12 +881,22 @@ void

[GitHub] [pulsar] nicoloboschi closed pull request #17855: [fix] Remove pulsar-broker-common dependency from pulsar-client

2022-09-29 Thread GitBox
nicoloboschi closed pull request #17855: [fix] Remove pulsar-broker-common dependency from pulsar-client URL: https://github.com/apache/pulsar/pull/17855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] poorbarcode commented on issue #16538: Flaky-test: org.apache.pulsar.functions.worker.PulsarFunctionTlsTest.PulsarFunctionTlsTest

2022-09-29 Thread GitBox
poorbarcode commented on issue #16538: URL: https://github.com/apache/pulsar/issues/16538#issuecomment-1262693559 Should we close this issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] AnonHxy commented on pull request #17822: [improve][java-client]Add init capacity for messages in BatchMessageContainerImpl

2022-09-29 Thread GitBox
AnonHxy commented on PR #17822: URL: https://github.com/apache/pulsar/pull/17822#issuecomment-1262528678 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] merlimat merged pull request #17889: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)"

2022-09-29 Thread GitBox
merlimat merged PR #17889: URL: https://github.com/apache/pulsar/pull/17889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] syhily commented on issue #17876: [Bug] TransactionCoordinatorClientImpl.start() hangs forever

2022-09-29 Thread GitBox
syhily commented on issue #17876: URL: https://github.com/apache/pulsar/issues/17876#issuecomment-1262659127 I don't think the end user should care about these system topic design. This should be a system topic initialization issue. -- This is an automated message from the Apache Git

[GitHub] [pulsar-site] tisonkun commented on pull request #236: Merge pulsar-site issues to the main repo

2022-09-29 Thread GitBox
tisonkun commented on PR #236: URL: https://github.com/apache/pulsar-site/pull/236#issuecomment-1262679501 @michaeljmarshall basic README info added. > Before we merge this PR, a committer should be involved to transfer all existing issues to the `apache/pulsar` repo. --

[pulsar] branch master updated: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)" (#17889)

2022-09-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f0b6348c3cc Revert "[Fix][Tiered Storage]

  1   2   3   >