[GitHub] [pulsar-site] momo-jun opened a new pull request, #489: [improve][doc] Clarify the scope of delayed msg delivery

2023-03-23 Thread via GitHub
momo-jun opened a new pull request, #489: URL: https://github.com/apache/pulsar-site/pull/489 ### Modification 1. Highlight and clarify the scope of delayed msg delivery. 2. Minor fixes and style alignment.

[GitHub] [pulsar] SeasonPanPan opened a new pull request, #19906: [fix][doc] fix typo in ConsumerConfigurationData and ServiceConfiguration.

2023-03-23 Thread via GitHub
SeasonPanPan opened a new pull request, #19906: URL: https://github.com/apache/pulsar/pull/19906 fix typo in ConsumerConfigurationData and ServiceConfiguration. ![img](https://user-images.githubusercontent.com/25130182/227116919-425edd35-97c8-473a-8500-f8195b75faeb.png) ###

[GitHub] [pulsar] coderzc opened a new issue, #19908: Flaky-test: ExtensibleLoadManagerImplTest.testSplitBundleAdminAPI

2023-03-23 Thread via GitHub
coderzc opened a new issue, #19908: URL: https://github.com/apache/pulsar/issues/19908 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure

[GitHub] [pulsar-site] Anonymitaet commented on pull request #490: [improve][doc] Optimize "Admin API > Features > Clusters"

2023-03-23 Thread via GitHub
Anonymitaet commented on PR #490: URL: https://github.com/apache/pulsar-site/pull/490#issuecomment-1481007780 Hi @hangc0276 I've optimized the doc based on our discussions, can you help review? TIA! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-site] Anonymitaet commented on pull request #490: [improve][doc] Optimize "Admin API > Features > Clusters"

2023-03-23 Thread via GitHub
Anonymitaet commented on PR #490: URL: https://github.com/apache/pulsar-site/pull/490#issuecomment-1481006930 Previews look good: - Admin API > Features > Clusters https://user-images.githubusercontent.com/50226895/227186389-13e2bacc-f13c-4574-b3e9-7560e148f40f.png;> -

[GitHub] [pulsar] lhotari commented on issue #19902: Flaky-test: BucketDelayedDeliveryTest.testDelayedDeliveryWithMultipleConcurrentReadEntries

2023-03-23 Thread via GitHub
lhotari commented on issue #19902: URL: https://github.com/apache/pulsar/issues/19902#issuecomment-1480663116 @coderzc Do you have a chance to take a look at this flaky test? it seems to be related to PIP-195 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar-client-go] shibd commented on a diff in pull request #991: [feat] Support consumer client memory limit

2023-03-23 Thread via GitHub
shibd commented on code in PR #991: URL: https://github.com/apache/pulsar-client-go/pull/991#discussion_r114576 ## pulsar/internal/memory_limit_controller.go: ## @@ -31,18 +31,41 @@ type MemoryLimitController interface { CurrentUsage() int64

[GitHub] [pulsar] lhotari commented on pull request #19470: [improve][fn] Support configure compression type

2023-03-23 Thread via GitHub
lhotari commented on PR #19470: URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1480721463 This PR broke the master branch. Please review and merge #19904 asap to fix master. The reason why this PR was mergeable is due to a CI bug #19905 . -- This is an automated

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #19874: [fix][client] Fix NPE when acknowledging multiple messages

2023-03-23 Thread via GitHub
BewareMyPower commented on code in PR #19874: URL: https://github.com/apache/pulsar/pull/19874#discussion_r1145786497 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java: ## @@ -496,8 +496,13 @@ protected CompletableFuture

[GitHub] [pulsar-client-go] RobertIndie commented on a diff in pull request #991: [feat] Support consumer client memory limit

2023-03-23 Thread via GitHub
RobertIndie commented on code in PR #991: URL: https://github.com/apache/pulsar-client-go/pull/991#discussion_r1145831375 ## pulsar/consumer_test.go: ## @@ -4113,3 +4113,204 @@ func TestConsumerBatchIndexAckDisabled(t *testing.T) { assert.Nil(t, err)

[GitHub] [pulsar-client-go] shibd merged pull request #991: [feat] Support consumer client memory limit

2023-03-23 Thread via GitHub
shibd merged PR #991: URL: https://github.com/apache/pulsar-client-go/pull/991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-client-go] branch master updated (6c3ee77 -> 20291f5)

2023-03-23 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git from 6c3ee77 fix: fix retryAssert (#996) add 20291f5 [feat] Support consumer client memory limit (#991)

[GitHub] [pulsar] visortelle commented on issue #19611: PIP-249: Pulsar website redesign

2023-03-23 Thread via GitHub
visortelle commented on issue #19611: URL: https://github.com/apache/pulsar/issues/19611#issuecomment-1480644099 @tuteng I'm excited to get started.  Should I start by using the provided Figma template, or are there other inputs I should take into consideration? -- This is an

[GitHub] [pulsar] jiangpengcheng commented on pull request #19897: [fix][fn] Make pulsar-admin support update py/go with package url

2023-03-23 Thread via GitHub
jiangpengcheng commented on PR #19897: URL: https://github.com/apache/pulsar/pull/19897#issuecomment-1480669654 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-client-go] Gleiphir2769 commented on a diff in pull request #991: [feat] Support consumer client memory limit

2023-03-23 Thread via GitHub
Gleiphir2769 commented on code in PR #991: URL: https://github.com/apache/pulsar-client-go/pull/991#discussion_r1145775394 ## pulsar/internal/memory_limit_controller.go: ## @@ -31,18 +31,41 @@ type MemoryLimitController interface { CurrentUsage() int64

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #486: [improve][doc] Add schema support for python functions

2023-03-23 Thread via GitHub
Anonymitaet commented on code in PR #486: URL: https://github.com/apache/pulsar-site/pull/486#discussion_r1145775435 ## docs/functions-develop-schema-registry.md: ## @@ -4,6 +4,19 @@ title: Use schema registry sidebar_label: "Use schema registry" --- -Pulsar has a built-in

[GitHub] [pulsar] lhotari commented on issue #19894: [Bug] Pulsar shutdowns Sink connector on exception

2023-03-23 Thread via GitHub
lhotari commented on issue #19894: URL: https://github.com/apache/pulsar/issues/19894#issuecomment-1480720099 > it gets stuck into shutdown/restart loop as Pulsar will retry the same message again and again. @abhilashmandaliya Would this problem of being stuck on a "poison message"

[GitHub] [pulsar-client-go] BewareMyPower commented on a diff in pull request #984: [feat][txn]Implement transactionImpl

2023-03-23 Thread via GitHub
BewareMyPower commented on code in PR #984: URL: https://github.com/apache/pulsar-client-go/pull/984#discussion_r1145803096 ## pulsar/error.go: ## @@ -103,14 +107,8 @@ const ( ProducerClosed // SchemaFailure means the payload could not be encoded using the

[GitHub] [pulsar-adapters] swamymavuri commented on a diff in pull request #46: [Issue #45] [pulsar-client-kafka-compat] Handled Kafka record headers…

2023-03-23 Thread via GitHub
swamymavuri commented on code in PR #46: URL: https://github.com/apache/pulsar-adapters/pull/46#discussion_r1145926460 ## pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java: ## @@ -70,6 +72,7 @@ import

[GitHub] [pulsar] vanhtuan0409 opened a new issue, #19910: Support basic-authentication in function url

2023-03-23 Thread via GitHub
vanhtuan0409 opened a new issue, #19910: URL: https://github.com/apache/pulsar/issues/19910 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation reopen for

[GitHub] [pulsar-site] Anonymitaet opened a new pull request, #490: [improve][doc] Optimize "Admin API > Features > Clusters"

2023-03-23 Thread via GitHub
Anonymitaet opened a new pull request, #490: URL: https://github.com/apache/pulsar-site/pull/490 ## ☘️ Acknowlegement Many thanks to @hangc0276 for providing technical support! ## ☘️ What doc does this PR add/update? ### ✅ Issues and solutions There are some

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19813: [improve][broker] PIP-192 Improved Auto Unload Logic

2023-03-23 Thread via GitHub
Demogorgon314 commented on code in PR #19813: URL: https://github.com/apache/pulsar/pull/19813#discussion_r1145760495 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/SplitScheduler.java: ## @@ -156,6 +159,13 @@ public void start() {

[GitHub] [pulsar] abhilashmandaliya commented on issue #19894: [Bug] Pulsar shutdowns Sink connector on exception

2023-03-23 Thread via GitHub
abhilashmandaliya commented on issue #19894: URL: https://github.com/apache/pulsar/issues/19894#issuecomment-1480769277 > > it gets stuck into shutdown/restart loop as Pulsar will retry the same message again and again. > > @abhilashmandaliya Would this problem of being stuck on a

[GitHub] [pulsar-dotpulsar] blankensteiner commented on a diff in pull request #146: Partitioned Topic Consumer Support

2023-03-23 Thread via GitHub
blankensteiner commented on code in PR #146: URL: https://github.com/apache/pulsar-dotpulsar/pull/146#discussion_r1145897117 ## samples/Consuming/Program.cs: ## @@ -52,8 +52,9 @@ private static async Task ConsumeMessages(IConsumer consumer, Cancellati {

[GitHub] [pulsar] github-actions[bot] commented on pull request #19909: Upgrade bk to 4.16.0 for test

2023-03-23 Thread via GitHub
github-actions[bot] commented on PR #19909: URL: https://github.com/apache/pulsar/pull/19909#issuecomment-1480922784 @hangc0276 Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ]

[GitHub] [pulsar] hangc0276 closed pull request #19909: Upgrade bk to 4.16.0 for test

2023-03-23 Thread via GitHub
hangc0276 closed pull request #19909: Upgrade bk to 4.16.0 for test URL: https://github.com/apache/pulsar/pull/19909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19813: [improve][broker] PIP-192 Improved Auto Unload Logic

2023-03-23 Thread via GitHub
Demogorgon314 commented on code in PR #19813: URL: https://github.com/apache/pulsar/pull/19813#discussion_r1146027666 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java: ## @@ -122,17 +148,14 @@ static class LoadStats {

[GitHub] [pulsar] lhotari opened a new issue, #19902: Flaky-test: BucketDelayedDeliveryTest.testDelayedDeliveryWithMultipleConcurrentReadEntries

2023-03-23 Thread via GitHub
lhotari opened a new issue, #19902: URL: https://github.com/apache/pulsar/issues/19902 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #486: [improve][doc] Add schema support for python functions

2023-03-23 Thread via GitHub
Anonymitaet commented on code in PR #486: URL: https://github.com/apache/pulsar-site/pull/486#discussion_r1145775435 ## docs/functions-develop-schema-registry.md: ## @@ -4,6 +4,19 @@ title: Use schema registry sidebar_label: "Use schema registry" --- -Pulsar has a built-in

[GitHub] [pulsar] lhotari opened a new issue, #19905: [Bug][CI] pulsar-function-go build failures are ignored when the last commit in the PR doesn't modify go files

2023-03-23 Thread via GitHub
lhotari opened a new issue, #19905: URL: https://github.com/apache/pulsar/issues/19905 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version master ### Minimal reproduce step

[GitHub] [pulsar] abhilashmandaliya commented on pull request #19898: Updated reflection library version

2023-03-23 Thread via GitHub
abhilashmandaliya commented on PR #19898: URL: https://github.com/apache/pulsar/pull/19898#issuecomment-1480773749 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #486: [improve][doc] Add schema support for python functions

2023-03-23 Thread via GitHub
Anonymitaet commented on code in PR #486: URL: https://github.com/apache/pulsar-site/pull/486#discussion_r1146047106 ## docs/functions-develop-schema-registry.md: ## @@ -4,6 +4,19 @@ title: Use schema registry sidebar_label: "Use schema registry" --- -Pulsar has a built-in

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19851: [improve][broker] PIP-192: Support delete namespace bundle admin API

2023-03-23 Thread via GitHub
Demogorgon314 commented on code in PR #19851: URL: https://github.com/apache/pulsar/pull/19851#discussion_r1145715365 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1445,23 +1451,44 @@ public PulsarClientImpl

[GitHub] [pulsar] lhotari commented on pull request #17756: [feat][broker][PIP-195] Implement BucketDelayedDeliveryTrackerFactory and load BucketDelayedDeliveryTracker - part6

2023-03-23 Thread via GitHub
lhotari commented on PR #17756: URL: https://github.com/apache/pulsar/pull/17756#issuecomment-1480663692 This PR introduced a flaky test, #19902 . @coderzc Do you have a chance to fix it? Thanks -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-client-go] Gleiphir2769 commented on a diff in pull request #991: [feat] Support consumer client memory limit

2023-03-23 Thread via GitHub
Gleiphir2769 commented on code in PR #991: URL: https://github.com/apache/pulsar-client-go/pull/991#discussion_r1145749318 ## pulsar/consumer_partition.go: ## @@ -333,6 +335,7 @@ func newPartitionConsumer(parent Consumer, client *client, options *partitionCon }

[GitHub] [pulsar] lhotari opened a new pull request, #19903: [improve][ci] Handle retry of maven downloads for more failure cases

2023-03-23 Thread via GitHub
lhotari opened a new pull request, #19903: URL: https://github.com/apache/pulsar/pull/19903 ### Motivation In CI, there are some occurrences of failed maven downloads. [For example](https://github.com/apache/pulsar/actions/runs/4489637889/jobs/7896090250#step:11:74): ```

[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #486: [improve][doc] Add schema support for python functions

2023-03-23 Thread via GitHub
momo-jun commented on code in PR #486: URL: https://github.com/apache/pulsar-site/pull/486#discussion_r1145825390 ## docs/functions-develop-schema-registry.md: ## @@ -4,6 +4,19 @@ title: Use schema registry sidebar_label: "Use schema registry" --- -Pulsar has a built-in

[GitHub] [pulsar] AnonHxy commented on pull request #19893: [imporve][broker] use shortTermMsgRate and shortTermThroughput for UniformLoadShedder

2023-03-23 Thread via GitHub
AnonHxy commented on PR #19893: URL: https://github.com/apache/pulsar/pull/19893#issuecomment-1480775416 > It's better to provide the details of Motivation +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-client-go] liangyepianzhou commented on a diff in pull request #984: [feat][txn]Implement transactionImpl

2023-03-23 Thread via GitHub
liangyepianzhou commented on code in PR #984: URL: https://github.com/apache/pulsar-client-go/pull/984#discussion_r1145842578 ## pulsar/error.go: ## @@ -103,14 +107,8 @@ const ( ProducerClosed // SchemaFailure means the payload could not be encoded using the

[GitHub] [pulsar] vanhtuan0409 commented on issue #19910: Support basic-authentication in function url

2023-03-23 Thread via GitHub
vanhtuan0409 commented on issue #19910: URL: https://github.com/apache/pulsar/issues/19910#issuecomment-1480931492 submitted PR https://github.com/apache/pulsar/pull/19750 @tisonkun could you help me to check this PR? -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19813: [improve][broker] PIP-192 Improved Auto Unload Logic

2023-03-23 Thread via GitHub
Demogorgon314 commented on code in PR #19813: URL: https://github.com/apache/pulsar/pull/19813#discussion_r1145759608 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/reporter/BrokerLoadDataReporter.java: ## @@ -152,4 +180,49 @@ protected double

[GitHub] [pulsar] lhotari opened a new pull request, #19904: [fix][fn] Revert change to deprecation since it broke the master branch

2023-03-23 Thread via GitHub
lhotari opened a new pull request, #19904: URL: https://github.com/apache/pulsar/pull/19904 ### Motivation Master branch build fails with this error message: ``` Error: pf/instance.go:158:15: SA1019: gi.context.instanceConf.funcDetails.AutoAck is deprecated: Do not use.

[GitHub] [pulsar-site] SeasonPanPan commented on pull request #488: fix typo of client-configuration-consumer.md

2023-03-23 Thread via GitHub
SeasonPanPan commented on PR #488: URL: https://github.com/apache/pulsar-site/pull/488#issuecomment-1480766290 @Anonymitaet Thank you for review. I pulled a new PR on https://github.com/apache/pulsar/pull/19906 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar-client-go] Gleiphir2769 commented on a diff in pull request #991: [feat] Support consumer client memory limit

2023-03-23 Thread via GitHub
Gleiphir2769 commented on code in PR #991: URL: https://github.com/apache/pulsar-client-go/pull/991#discussion_r1145845933 ## pulsar/consumer_test.go: ## @@ -4113,3 +4113,204 @@ func TestConsumerBatchIndexAckDisabled(t *testing.T) { assert.Nil(t, err)

[GitHub] [pulsar] hangc0276 opened a new pull request, #19909: Upgrade bk to 4.16.0 for test

2023-03-23 Thread via GitHub
hangc0276 opened a new pull request, #19909: URL: https://github.com/apache/pulsar/pull/19909 Fixes #xyz Master Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #486: [improve][doc] Add schema support for python functions

2023-03-23 Thread via GitHub
Anonymitaet commented on code in PR #486: URL: https://github.com/apache/pulsar-site/pull/486#discussion_r1146047106 ## docs/functions-develop-schema-registry.md: ## @@ -4,6 +4,19 @@ title: Use schema registry sidebar_label: "Use schema registry" --- -Pulsar has a built-in

[GitHub] [pulsar-site] SeasonPanPan opened a new pull request, #488: fix typo of client-configuration-consumer.md

2023-03-23 Thread via GitHub
SeasonPanPan opened a new pull request, #488: URL: https://github.com/apache/pulsar-site/pull/488 ### Documentation fix typo of client-configuration-consumer.md, please check.

[GitHub] [pulsar] abhilashmandaliya commented on issue #19894: [Bug] Pulsar shutdowns Sink connector on exception

2023-03-23 Thread via GitHub
abhilashmandaliya commented on issue #19894: URL: https://github.com/apache/pulsar/issues/19894#issuecomment-1480661046 > > For the sinks having EFFECTIVE_ONCE guarantee, prior to pulsar v2.7.3 , if there was any exception in record processing, the CompletableFuture

[GitHub] [pulsar] Technoboy- closed pull request #19858: [fix] [cli] Release the orphan producers after the primary consumer is closed

2023-03-23 Thread via GitHub
Technoboy- closed pull request #19858: [fix] [cli] Release the orphan producers after the primary consumer is closed URL: https://github.com/apache/pulsar/pull/19858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] abhilashmandaliya commented on issue #19894: [Bug] Pulsar shutdowns Sink connector on exception

2023-03-23 Thread via GitHub
abhilashmandaliya commented on issue #19894: URL: https://github.com/apache/pulsar/issues/19894#issuecomment-1480705073 > The behavior you want makes sense when auto acknowledge is turned on, in that case the Sink should acknowledge the message in case of success and nack the message

[GitHub] [pulsar-adapters] swamymavuri commented on a diff in pull request #46: [Issue #45] [pulsar-client-kafka-compat] Handled Kafka record headers…

2023-03-23 Thread via GitHub
swamymavuri commented on code in PR #46: URL: https://github.com/apache/pulsar-adapters/pull/46#discussion_r1145926460 ## pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java: ## @@ -70,6 +72,7 @@ import

[GitHub] [pulsar-client-go] BewareMyPower commented on a diff in pull request #984: [feat][txn]Implement transactionImpl

2023-03-23 Thread via GitHub
BewareMyPower commented on code in PR #984: URL: https://github.com/apache/pulsar-client-go/pull/984#discussion_r1145983425 ## pulsar/error.go: ## @@ -225,3 +226,14 @@ func getResultStr(r Result) string { return fmt.Sprintf("Result(%d)", r) } } + +func

[GitHub] [pulsar-client-go] BewareMyPower commented on a diff in pull request #984: [feat][txn]Implement transactionImpl

2023-03-23 Thread via GitHub
BewareMyPower commented on code in PR #984: URL: https://github.com/apache/pulsar-client-go/pull/984#discussion_r1146129062 ## pulsar/transaction_test.go: ## @@ -79,6 +81,138 @@ func TestTCClient(t *testing.T) { defer client.Close() } +/** +* Test points: +*

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #19414: [improve][client] PIP-229: Add a common interface to get fields of MessageIdData

2023-03-23 Thread via GitHub
BewareMyPower commented on code in PR #19414: URL: https://github.com/apache/pulsar/pull/19414#discussion_r1146176043 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageImpl.java: ## @@ -68,11 +68,6 @@ public MessageId getMessageId() { return

[GitHub] [pulsar] visortelle commented on issue #19611: PIP-249: Pulsar website redesign

2023-03-23 Thread via GitHub
visortelle commented on issue #19611: URL: https://github.com/apache/pulsar/issues/19611#issuecomment-1481200579 @asafm Sure. Joined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] lhotari commented on issue #18466: Flaky-test: TransactionEndToEndTest.produceCommitTest

2023-03-23 Thread via GitHub
lhotari commented on issue #18466: URL: https://github.com/apache/pulsar/issues/18466#issuecomment-1481200762 I wonder if the most recent failure is different. The stack trace contains

[GitHub] [pulsar] liangyepianzhou commented on issue #18466: Flaky-test: TransactionEndToEndTest.produceCommitTest

2023-03-23 Thread via GitHub
liangyepianzhou commented on issue #18466: URL: https://github.com/apache/pulsar/issues/18466#issuecomment-1481240224 There may have been some recent changes or unresolved issues from before. I will make another attempt to address this problem. -- This is an automated message from the

[GitHub] [pulsar] yuweisung added a comment to the discussion: Can I config the pulsar TLS Encryption at tenant level?

2023-03-23 Thread GitBox
GitHub user yuweisung added a comment to the discussion: Can I config the pulsar TLS Encryption at tenant level? It is possible to do so but an operational headache. You can turn on/off tls encryption (pulsar+ssl, or pulsar) and set the advertisedlistener in individual brokers. Then use

[GitHub] [pulsar-adapters] swamymavuri commented on a diff in pull request #46: [Issue #45] [pulsar-client-kafka-compat] Handled Kafka record headers…

2023-03-23 Thread via GitHub
swamymavuri commented on code in PR #46: URL: https://github.com/apache/pulsar-adapters/pull/46#discussion_r1146162466 ## pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java: ## @@ -404,10 +409,28 @@ public

[GitHub] [pulsar] asafm commented on issue #19611: PIP-249: Pulsar website redesign

2023-03-23 Thread via GitHub
asafm commented on issue #19611: URL: https://github.com/apache/pulsar/issues/19611#issuecomment-1481195206 @visortelle Let's coordinate our efforts in Pulsar Slack under `#pip_249`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] asafm opened a new pull request, #19911: [fix]doc] Add link to PIP proposal

2023-03-23 Thread via GitHub
asafm opened a new pull request, #19911: URL: https://github.com/apache/pulsar/pull/19911 ### Motivation Add a link to see existing PIP issues so you can select a number ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is

[GitHub] [pulsar] github-actions[bot] commented on pull request #19911: [fix]doc] Add link to PIP proposal

2023-03-23 Thread via GitHub
github-actions[bot] commented on PR #19911: URL: https://github.com/apache/pulsar/pull/19911#issuecomment-1481391110 @asafm Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ]

[GitHub] [pulsar-adapters] swamymavuri commented on a diff in pull request #46: [Issue #45] [pulsar-client-kafka-compat] Handled Kafka record headers…

2023-03-23 Thread via GitHub
swamymavuri commented on code in PR #46: URL: https://github.com/apache/pulsar-adapters/pull/46#discussion_r1146162466 ## pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java: ## @@ -404,10 +409,28 @@ public

[GitHub] [pulsar] asafm opened a new issue, #19912: PIP-261: d

2023-03-23 Thread via GitHub
asafm opened a new issue, #19912: URL: https://github.com/apache/pulsar/issues/19912 ### Motivation d ### Goal d ### API Changes d ### Implementation d ### Security Considerations d ### Alternatives d ###

[pulsar] branch master updated (a9037334a39 -> a1fdbd294ca)

2023-03-23 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from a9037334a39 [fix] [admin] Make response code to 400 instead of 500 when delete topic fails due to enabled

[GitHub] [pulsar] jak78 edited a comment on the discussion: Can I config the pulsar TLS Encryption at tenant level?

2023-03-23 Thread GitBox
GitHub user jak78 edited a comment on the discussion: Can I config the pulsar TLS Encryption at tenant level? @snailxr welcome to the community! As @yuweisung wrote: this is doable but cumbersome. @snailxr could you tell us why you want to disable TLS at the tenant level? GitHub link:

[GitHub] [pulsar] jak78 added a comment to the discussion: Can I config the pulsar TLS Encryption at tenant level?

2023-03-23 Thread GitBox
GitHub user jak78 added a comment to the discussion: Can I config the pulsar TLS Encryption at tenant level? @snailxr welcome to the community! As @yuweisung this is doable but cumbersome. @snailxr could you tell us why you want to disable TLS at the tenant level? GitHub link:

[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #486: [improve][doc] Add schema support for python functions

2023-03-23 Thread via GitHub
momo-jun commented on code in PR #486: URL: https://github.com/apache/pulsar-site/pull/486#discussion_r1146206031 ## docs/functions-develop-schema-registry.md: ## @@ -4,6 +4,19 @@ title: Use schema registry sidebar_label: "Use schema registry" --- -Pulsar has a built-in

[GitHub] [pulsar-client-cpp] shibd opened a new pull request, #228: [fix] Consumer batch receive will cause data loss.

2023-03-23 Thread via GitHub
shibd opened a new pull request, #228: URL: https://github.com/apache/pulsar-client-cpp/pull/228 ### Motivation Currently, the batch receive method may cause data loss. The root cause is, when `message` can't add to `messages`(The batch has satisfied the batch receive policy),

[GitHub] [pulsar] Technoboy- merged pull request #19875: [fix][broker] Fix NPE when update topic policy.

2023-03-23 Thread via GitHub
Technoboy- merged PR #19875: URL: https://github.com/apache/pulsar/pull/19875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] BewareMyPower commented on a diff in pull request #984: [feat][txn]Implement transactionImpl

2023-03-23 Thread via GitHub
BewareMyPower commented on code in PR #984: URL: https://github.com/apache/pulsar-client-go/pull/984#discussion_r1146120366 ## pulsar/transaction_test.go: ## @@ -79,6 +81,138 @@ func TestTCClient(t *testing.T) { defer client.Close() } +/** +* Test points: +*

[GitHub] [pulsar-adapters] cbornet commented on a diff in pull request #46: [Issue #45] [pulsar-client-kafka-compat] Handled Kafka record headers…

2023-03-23 Thread via GitHub
cbornet commented on code in PR #46: URL: https://github.com/apache/pulsar-adapters/pull/46#discussion_r1146180464 ## pulsar-client-kafka-compat/pulsar-client-kafka/src/test/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumerTest.java: ## @@ -0,0 +1,144 @@ +/** + *

[GitHub] [pulsar] lhotari commented on issue #18466: Flaky-test: TransactionEndToEndTest.produceCommitTest

2023-03-23 Thread via GitHub
lhotari commented on issue #18466: URL: https://github.com/apache/pulsar/issues/18466#issuecomment-1481198818 > This flaky test can be resolved by https://github.com/apache/pulsar/pull/18486 and https://github.com/apache/pulsar/pull/17836 @liangyepianzhou this problem remains.

[GitHub] [pulsar] crossoverJie closed pull request #19871: [fix][client] Fix typo in ConsumerStats

2023-03-23 Thread via GitHub
crossoverJie closed pull request #19871: [fix][client] Fix typo in ConsumerStats URL: https://github.com/apache/pulsar/pull/19871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] horizonzy opened a new pull request, #19913: Make LedgerOffloaderFactory compatible with old version.

2023-03-23 Thread via GitHub
horizonzy opened a new pull request, #19913: URL: https://github.com/apache/pulsar/pull/19913 ### Motivation After #13833, we change the signature of LedgerOffloaderFactory#create. Before: no offloaderStats. ``` default T create(OffloadPoliciesImpl

[GitHub] [pulsar] anand-ftc commented on issue #7019: Webhook Size is always zero

2023-03-23 Thread via GitHub
anand-ftc commented on issue #7019: URL: https://github.com/apache/pulsar/issues/7019#issuecomment-1481310493 Hi @rajasekar33 can you help me I am getting the same error in the logs continously -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-client-cpp] shibd opened a new issue, #229: Flaky test: ConsumerInterceptorsTest.TestNegativeAcksSend

2023-03-23 Thread via GitHub
shibd opened a new issue, #229: URL: https://github.com/apache/pulsar-client-cpp/issues/229 [example failure](https://github.com/apache/pulsar-client-cpp/actions/runs/4501817436/jobs/7922762277?pr=228) ``` FAILED TESTS (5/488): 264 ms: ./pulsar-tests

[GitHub] [pulsar] flowchartsman commented on issue #19721: [Bug] Cannot update Pulsar function in Pulsar standalone

2023-03-23 Thread via GitHub
flowchartsman commented on issue #19721: URL: https://github.com/apache/pulsar/issues/19721#issuecomment-1481689944 > Use file path for `--py|--go|--jar`, and set `functionsWorkerEnablePackageManagement` to true in `conf/broker.conf` I have tried package management and never gotten

[GitHub] [pulsar] michaeljmarshall commented on issue #19771: PIP-257: Add Open ID Connect Support to Server Components

2023-03-23 Thread via GitHub
michaeljmarshall commented on issue #19771: URL: https://github.com/apache/pulsar/issues/19771#issuecomment-1481804679 > It seems important that the function submitter not be able to escalate their privileges by selecting an arbitrary service account. I feel that the function worker

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19888: [feat][fn] PIP-257: Support mounting k8s ServiceAccount for OIDC auth

2023-03-23 Thread via GitHub
michaeljmarshall commented on code in PR #19888: URL: https://github.com/apache/pulsar/pull/19888#discussion_r1146786693 ## pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactoryConfig.java: ## @@ -169,4 +169,17 @@ public

[GitHub] [pulsar] michaeljmarshall commented on pull request #19797: [cleanup][proxy] Remove authorization config

2023-03-23 Thread via GitHub
michaeljmarshall commented on PR #19797: URL: https://github.com/apache/pulsar/pull/19797#issuecomment-1481892432 I thought that might work, but @eolivelli thinks we should keep it around. It sounds like the kind of decision to make on the mailing list. -- This is an automated message

[GitHub] [pulsar] ahothan commented on pull request #19758: [fix] Fix Authentication metric has infinity label values

2023-03-23 Thread via GitHub
ahothan commented on PR #19758: URL: https://github.com/apache/pulsar/pull/19758#issuecomment-1481926609 diffs lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19851: [improve][broker] PIP-192: Support delete namespace bundle admin API

2023-03-23 Thread via GitHub
heesung-sn commented on code in PR #19851: URL: https://github.com/apache/pulsar/pull/19851#discussion_r1146702601 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1445,23 +1451,44 @@ public PulsarClientImpl

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19813: [improve][broker] PIP-192 Improved Auto Unload Logic

2023-03-23 Thread via GitHub
heesung-sn commented on code in PR #19813: URL: https://github.com/apache/pulsar/pull/19813#discussion_r1146755749 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/reporter/BrokerLoadDataReporter.java: ## @@ -152,4 +180,49 @@ protected double

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19888: [feat][fn] PIP-257: Support mounting k8s ServiceAccount for OIDC auth

2023-03-23 Thread via GitHub
michaeljmarshall commented on code in PR #19888: URL: https://github.com/apache/pulsar/pull/19888#discussion_r1146779611 ## pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/KubernetesServiceAccountAuthProvider.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19813: [improve][broker] PIP-192 Improved Auto Unload Logic

2023-03-23 Thread via GitHub
heesung-sn commented on code in PR #19813: URL: https://github.com/apache/pulsar/pull/19813#discussion_r1146782748 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java: ## @@ -122,17 +148,14 @@ static class LoadStats {

[GitHub] [pulsar] flowchartsman commented on issue #18972: [Bug] pulsar-admin functions upload does not appear to work at all.

2023-03-23 Thread via GitHub
flowchartsman commented on issue #18972: URL: https://github.com/apache/pulsar/issues/18972#issuecomment-1481685488 2.10.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19813: [improve][broker] PIP-192 Improved Auto Unload Logic

2023-03-23 Thread via GitHub
heesung-sn commented on code in PR #19813: URL: https://github.com/apache/pulsar/pull/19813#discussion_r1146756985 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/SplitScheduler.java: ## @@ -156,6 +159,13 @@ public void start() {

[GitHub] [pulsar] EronWright commented on issue #19771: PIP-257: Add Open ID Connect Support to Server Components

2023-03-23 Thread via GitHub
EronWright commented on issue #19771: URL: https://github.com/apache/pulsar/issues/19771#issuecomment-1481641279 @michaeljmarshall sorry for the delayed response. About the function pod's service account, I would like to share my thoughts about that. The pod's KSA can be understood

[GitHub] [pulsar] EronWright commented on issue #19771: PIP-257: Add Open ID Connect Support to Server Components

2023-03-23 Thread via GitHub
EronWright commented on issue #19771: URL: https://github.com/apache/pulsar/issues/19771#issuecomment-1481695646 On the topic of authorization: as you've shown, the `sub` claim conveys the name of the KSA, and that would assumedly be used as the Pulsar role name. One would then set Pulsar

[GitHub] [pulsar] dlg99 commented on a diff in pull request #19821: [WIP] Added Debezium DB2 connector for Pulsar

2023-03-23 Thread via GitHub
dlg99 commented on code in PR #19821: URL: https://github.com/apache/pulsar/pull/19821#discussion_r1146986919 ## tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/sources/debezium/DebeziumDB2DbSourceTester.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the

[GitHub] [pulsar] github-actions[bot] commented on issue #17133: [Doc] Fix the RabbitMQ connector docs

2023-03-23 Thread via GitHub
github-actions[bot] commented on issue #17133: URL: https://github.com/apache/pulsar/issues/17133#issuecomment-1482144667 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] momo-jun opened a new issue, #19914: [Doc] A bunch of empty doc files created unexpectedly and distract the site search

2023-03-23 Thread via GitHub
momo-jun opened a new issue, #19914: URL: https://github.com/apache/pulsar/issues/19914 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs?

[GitHub] [pulsar] crossoverJie opened a new pull request, #19915: [fix][client] Fix client erroneous code comments

2023-03-23 Thread via GitHub
crossoverJie opened a new pull request, #19915: URL: https://github.com/apache/pulsar/pull/19915 ### Motivation Fix incorrect comments. ### Documentation - [x] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete`

[GitHub] [pulsar] Technoboy- closed pull request #19889: [fix][broker] Fix the thread safety issue of BrokerData#getTimeAverageData access

2023-03-23 Thread via GitHub
Technoboy- closed pull request #19889: [fix][broker] Fix the thread safety issue of BrokerData#getTimeAverageData access URL: https://github.com/apache/pulsar/pull/19889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #489: [improve][doc] Clarify the scope of delayed msg delivery

2023-03-23 Thread via GitHub
Anonymitaet commented on code in PR #489: URL: https://github.com/apache/pulsar-site/pull/489#discussion_r1147073378 ## docs/concepts-messaging.md: ## @@ -531,8 +534,7 @@ In the diagram below, **Consumer A**, **Consumer B** and **Consumer C** are all :::note

[GitHub] [pulsar] Anonymitaet commented on pull request #19906: [fix][doc] fix typo in ConsumerConfigurationData and ServiceConfiguration.

2023-03-23 Thread via GitHub
Anonymitaet commented on PR #19906: URL: https://github.com/apache/pulsar/pull/19906#issuecomment-1482192393 @SeasonPanPan please fill in this part in your PR description. https://user-images.githubusercontent.com/50226895/227415212-a55f60d0-1912-49e7-8ebe-b51ab0036791.png;> Feel

[GitHub] [pulsar] snailxr added a comment to the discussion: Can I config the pulsar TLS Encryption at tenant level?

2023-03-23 Thread GitBox
GitHub user snailxr added a comment to the discussion: Can I config the pulsar TLS Encryption at tenant level? @yuweisung Could you give me some steps or some links that I can refer to? GitHub link: https://github.com/apache/pulsar/discussions/19907#discussioncomment-5412697 This is an

[GitHub] [pulsar] github-actions[bot] commented on pull request #19584: [fix][fn] Make KubernetesRuntime translate characters in function tenant, namespace, and name during function removal to avoid l

2023-03-23 Thread via GitHub
github-actions[bot] commented on PR #19584: URL: https://github.com/apache/pulsar/pull/19584#issuecomment-1482143131 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on pull request #19515: [feat][sql] Support querying compacted data in Pulsar SQL

2023-03-23 Thread via GitHub
github-actions[bot] commented on PR #19515: URL: https://github.com/apache/pulsar/pull/19515#issuecomment-1482143262 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

  1   2   >