[pulsar] branch master updated (52e81445875 -> 4d8156fca05)

2023-04-13 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 52e81445875 [fix][fn] check user metric len before iterating (#20021) add 4d8156fca05 [improve][ci]Add

[GitHub] [pulsar] nicoloboschi merged pull request #20081: [improve][ci]Add branch-3.0 to owasp checks

2023-04-13 Thread via GitHub
nicoloboschi merged PR #20081: URL: https://github.com/apache/pulsar/pull/20081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codecov-commenter commented on pull request #20006: [fix][test]Fix flaky test produceCommitTest

2023-04-13 Thread via GitHub
codecov-commenter commented on PR #20006: URL: https://github.com/apache/pulsar/pull/20006#issuecomment-1506453202 ## [Codecov](https://codecov.io/gh/apache/pulsar/pull/20006?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] eolivelli commented on pull request #19975: [refactor][fn] Use AuthorizationServer more in Function Worker API

2023-04-13 Thread via GitHub
eolivelli commented on PR #19975: URL: https://github.com/apache/pulsar/pull/19975#issuecomment-1506421901 This is not strictly a public API change, it is more like fixing a security issue. Nobody is expected to implement these interfaces. -- This is an automated message from the

[GitHub] [pulsar] tisonkun commented on issue #20076: [Bug] When consuming messages using messageListener, the ConsumerStats#getMsgNumInReceiverQueue method always returns 0.

2023-04-13 Thread via GitHub
tisonkun commented on issue #20076: URL: https://github.com/apache/pulsar/issues/20076#issuecomment-1506402954 @crossoverJie @Technoboy- Thanks for your clarification! Make sense to me. Looking forward to your patch  -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] heesung-sn opened a new pull request, #20087: [improve][broker] PIP-192 Add compression and maxBatchSize for the lo…

2023-04-13 Thread via GitHub
heesung-sn opened a new pull request, #20087: URL: https://github.com/apache/pulsar/pull/20087 Master Issue: https://github.com/apache/pulsar/issues/16691 ### Motivation Raising a PR to implement: https://github.com/apache/pulsar/issues/16691 ###

[GitHub] [pulsar] codelipenghui commented on pull request #19975: [refactor][fn] Use AuthorizationServer more in Function Worker API

2023-04-13 Thread via GitHub
codelipenghui commented on PR #19975: URL: https://github.com/apache/pulsar/pull/19975#issuecomment-1506502951 @freeznet I have forward the email under the private mailing list to your apache email, so that you can get all the context about the changes. -- This is an automated message

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #514: [improve][doc] Add explanations and illustrations for failover

2023-04-13 Thread via GitHub
Anonymitaet commented on code in PR #514: URL: https://github.com/apache/pulsar-site/pull/514#discussion_r1165220191 ## docs/concepts-messaging.md: ## @@ -515,16 +515,64 @@ Exclusive is the default subscription type. Failover -In the *Failover* type, multiple

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #514: [improve][doc] Add explanations and illustrations for failover

2023-04-13 Thread via GitHub
Anonymitaet commented on code in PR #514: URL: https://github.com/apache/pulsar-site/pull/514#discussion_r1165221519 ## docs/concepts-messaging.md: ## @@ -515,16 +515,64 @@ Exclusive is the default subscription type. Failover -In the *Failover* type, multiple

[GitHub] [pulsar-client-cpp] RobertIndie opened a new pull request, #250: [cleanup] Remove useless variable `interceptors_` in `ProducerImplBase`

2023-04-13 Thread via GitHub
RobertIndie opened a new pull request, #250: URL: https://github.com/apache/pulsar-client-cpp/pull/250 ### Motivation The variable `interceptors_` in `ProducerImplBase` is useless. This PR cleans up the code. ### Verifying this change This change is a

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #230: [feat] Support consumer batch receive on C client.

2023-04-13 Thread via GitHub
BewareMyPower commented on code in PR #230: URL: https://github.com/apache/pulsar-client-cpp/pull/230#discussion_r1165396338 ## include/pulsar/c/messages.h: ## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [pulsar-site] RobertIndie commented on a diff in pull request #515: [Doc] Add C++ doc for client and producer

2023-04-13 Thread via GitHub
RobertIndie commented on code in PR #515: URL: https://github.com/apache/pulsar-site/pull/515#discussion_r1165321199 ## docs/client-libraries-producers.md: ## @@ -178,25 +224,6 @@ await producer.Send(data); -- Send messages with customized metadata without using

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #20087: [improve][broker] PIP-192 Fix getLastMessageId for compressed payload(And add compression and maxBatchSize for the load bala

2023-04-13 Thread via GitHub
Demogorgon314 commented on code in PR #20087: URL: https://github.com/apache/pulsar/pull/20087#discussion_r1165206855 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawBatchMessageContainerImplTest.java: ## @@ -169,7 +189,7 @@ public void

[GitHub] [pulsar-site] RobertIndie opened a new pull request, #515: [Doc] Add C++ doc for client and producer

2023-04-13 Thread via GitHub
RobertIndie opened a new pull request, #515: URL: https://github.com/apache/pulsar-site/pull/515 ### Documentation - [x] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-site] RobertIndie opened a new pull request, #516: Refine the java client doc

2023-04-13 Thread via GitHub
RobertIndie opened a new pull request, #516: URL: https://github.com/apache/pulsar-site/pull/516 Address the following comments: * https://github.com/apache/pulsar-site/pull/393#discussion_r1098646842 * https://github.com/apache/pulsar-site/pull/393#discussion_r1098649330 ###

[GitHub] [pulsar-client-cpp] BewareMyPower opened a new pull request, #249: Support the base64 encoded credentials for OAuth2 authentication

2023-04-13 Thread via GitHub
BewareMyPower opened a new pull request, #249: URL: https://github.com/apache/pulsar-client-cpp/pull/249 Fixes https://github.com/apache/pulsar-client-python/issues/101 ### Motivation Currently the `private_key` field of the JSON passed to `AuthOauth2` only represents the path

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #514: [improve][doc] Add explanations and illustrations for failover

2023-04-13 Thread via GitHub
Anonymitaet commented on code in PR #514: URL: https://github.com/apache/pulsar-site/pull/514#discussion_r1165229123 ## docs/concepts-messaging.md: ## @@ -515,16 +515,64 @@ Exclusive is the default subscription type. Failover -In the *Failover* type, multiple

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #514: [improve][doc] Add explanations and illustrations for failover

2023-04-13 Thread via GitHub
Anonymitaet commented on code in PR #514: URL: https://github.com/apache/pulsar-site/pull/514#discussion_r1165228617 ## docs/concepts-messaging.md: ## @@ -515,16 +515,64 @@ Exclusive is the default subscription type. Failover -In the *Failover* type, multiple

[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #516: Refine the java client doc

2023-04-13 Thread via GitHub
momo-jun commented on code in PR #516: URL: https://github.com/apache/pulsar-site/pull/516#discussion_r1165355792 ## docs/client-libraries-java-use.md: ## @@ -79,7 +79,7 @@ while (true) { } ``` -If you don't want to block your main thread and rather listen constantly for

[GitHub] [pulsar] nlu90 commented on pull request #20089: [improve][fn] Upgrade Kotlin version from 1.4.32 to 1.8.20.

2023-04-13 Thread via GitHub
nlu90 commented on PR #20089: URL: https://github.com/apache/pulsar/pull/20089#issuecomment-1507588626 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] dhermanson commented on pull request #12411: use correct property when determine if jsr310 enabled

2023-04-13 Thread via GitHub
dhermanson commented on PR #12411: URL: https://github.com/apache/pulsar/pull/12411#issuecomment-1507691633 It looks like this issue remains unfixed [in

[GitHub] [pulsar] dlg99 opened a new issue, #20091: [Bug] CI: pulsar does not run tests with interceptors enabled

2023-04-13 Thread via GitHub
dlg99 opened a new issue, #20091: URL: https://github.com/apache/pulsar/issues/20091 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 3.0 RC 1 ### Minimal reproduce step

[GitHub] [pulsar] jddCynet commented on issue #12944: ARM based docker image

2023-04-13 Thread via GitHub
jddCynet commented on issue #12944: URL: https://github.com/apache/pulsar/issues/12944#issuecomment-1506881782 How can we run it as a docker standalone ? I tried this cmd `docker run -it -p 6650:6650 -p 8080:8080 --mount source=pulsardata,target=/pulsar/data --mount

[GitHub] [pulsar] gmiklos-ltg commented on issue #5350: Pulsar can't load the customized SerDe

2023-04-13 Thread via GitHub
gmiklos-ltg commented on issue #5350: URL: https://github.com/apache/pulsar/issues/5350#issuecomment-1506884054 There is also an issue with PulsarSource that relates to TopicSchema not using the correct classloader. I would like to suggest a fix in a PR that I will create shortly. --

[GitHub] [pulsar] 315157973 closed pull request #19992: [fix][broker] Avoid Bookie data is never deleted

2023-04-13 Thread via GitHub
315157973 closed pull request #19992: [fix][broker] Avoid Bookie data is never deleted URL: https://github.com/apache/pulsar/pull/19992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] dragonls commented on a diff in pull request #20068: [fix][broker] Fix tenant admin authorization bug.

2023-04-13 Thread via GitHub
dragonls commented on code in PR #20068: URL: https://github.com/apache/pulsar/pull/20068#discussion_r1165539818 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java: ## @@ -84,7 +84,18 @@ public void

[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #250: [cleanup] Remove useless variable `interceptors_` in `ProducerImplBase`

2023-04-13 Thread via GitHub
BewareMyPower merged PR #250: URL: https://github.com/apache/pulsar-client-cpp/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] gmiklos-ltg opened a new issue, #20088: Upgrade Kotlin version from 1.4.32 to 1.8.20.

2023-04-13 Thread via GitHub
gmiklos-ltg opened a new issue, #20088: URL: https://github.com/apache/pulsar/issues/20088 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation While evaluating Pulsar Functions

[GitHub] [pulsar] gmiklos-ltg opened a new pull request, #20089: [improve][fn] Upgrade Kotlin version from 1.4.32 to 1.8.20.

2023-04-13 Thread via GitHub
gmiklos-ltg opened a new pull request, #20089: URL: https://github.com/apache/pulsar/pull/20089 Fixes #20088 ### Motivation While evaluating Pulsar Functions for our data transformation purposes we ran into an issue where the Kotlin runtime of the function clashed with the

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #230: [feat] Support consumer batch receive on C client.

2023-04-13 Thread via GitHub
BewareMyPower commented on code in PR #230: URL: https://github.com/apache/pulsar-client-cpp/pull/230#discussion_r1165427701 ## tests/c/c_ConsumerTest.cc: ## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[pulsar-client-cpp] branch main updated: [feat] Support set batch index ack for C client. (#246)

2023-04-13 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new f4587d7 [feat] Support set batch index ack

[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #246: [feat] Support set batch index ack for C client.

2023-04-13 Thread via GitHub
BewareMyPower merged PR #246: URL: https://github.com/apache/pulsar-client-cpp/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] gmiklos-ltg opened a new pull request, #20090: [fix][fn] Use functions classloader in TopicSchema

2023-04-13 Thread via GitHub
gmiklos-ltg opened a new pull request, #20090: URL: https://github.com/apache/pulsar/pull/20090 Fixes #5350 ### Motivation While evaluating Pulsar Functions for our data transformation use-cases we ran into the following startup issue with our function that was using a custom

[pulsar-client-cpp] branch main updated: [cleanup] Remove useless variable `interceptors_` definition (#250)

2023-04-13 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new a57bb07 [cleanup] Remove useless variable

[GitHub] [pulsar] BewareMyPower commented on pull request #20055: [fix][txn] Fix transaction is not aborted when send or ACK failed

2023-04-13 Thread via GitHub
BewareMyPower commented on PR #20055: URL: https://github.com/apache/pulsar/pull/20055#issuecomment-1507013863 ping @congbobo184 @liangyepianzhou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #20006: [fix][test]Fix flaky test produceCommitTest

2023-04-13 Thread via GitHub
liangyepianzhou commented on code in PR #20006: URL: https://github.com/apache/pulsar/pull/20006#discussion_r1165680545 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java: ## @@ -811,7 +811,7 @@ private void txnCumulativeAckTest(boolean

[GitHub] [pulsar] coderzc closed pull request #20086: [fix][broker] Ensure previous delayed index be removed from snapshotSegmentLastIndexTable & Make load operate asynchronous

2023-04-13 Thread via GitHub
coderzc closed pull request #20086: [fix][broker] Ensure previous delayed index be removed from snapshotSegmentLastIndexTable & Make load operate asynchronous URL: https://github.com/apache/pulsar/pull/20086 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun commented on issue #5350: Pulsar can't load the customized SerDe

2023-04-13 Thread via GitHub
tisonkun commented on issue #5350: URL: https://github.com/apache/pulsar/issues/5350#issuecomment-1506945513 @gmiklos-ltg do you mean https://github.com/apache/pulsar/pull/20090? Thanks for your patch and I'll try to review it in days :) -- This is an automated message from the Apache

[GitHub] [pulsar] aymkhalil opened a new issue, #20092: [Bug] Pulsar client AUTO_CONSUME "double" as "BigDecimal" in JSON schemas

2023-04-13 Thread via GitHub
aymkhalil opened a new issue, #20092: URL: https://github.com/apache/pulsar/issues/20092 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version Pulsar client 2.10.3, 2.10.2, 2.10.1.

[GitHub] [pulsar-site] Anonymitaet commented on pull request #515: [Doc] Add C++ doc for client and producer

2023-04-13 Thread via GitHub
Anonymitaet commented on PR #515: URL: https://github.com/apache/pulsar-site/pull/515#issuecomment-1507820758 @RobertIndie Thanks for your contribution! 1. Have you previewed your changes and ensured everything goes as expected? If not, please [preview your changes

[GitHub] [pulsar] tisonkun commented on issue #20093: [BUG] Use correct property when determine if jsr310 enabled

2023-04-13 Thread via GitHub
tisonkun commented on issue #20093: URL: https://github.com/apache/pulsar/issues/20093#issuecomment-1507848752 @dhermanson I create this issue for tracking this BUG. You're welcome to apply the patch to master branch and we then pick to maintained versions. -- This is an automated

[GitHub] [pulsar] tisonkun commented on issue #19456: Flaky-test: MetadataStoreStatsTest.testMetadataStoreStats

2023-04-13 Thread via GitHub
tisonkun commented on issue #19456: URL: https://github.com/apache/pulsar/issues/19456#issuecomment-1507850647 @niharrathod But I found you open a PR #19842 against this issue, so it's also possible that this case has been fixed? -- This is an automated message from the Apache Git

[GitHub] [pulsar] tisonkun commented on pull request #20090: [fix][fn] Use functions classloader in TopicSchema

2023-04-13 Thread via GitHub
tisonkun commented on PR #20090: URL: https://github.com/apache/pulsar/pull/20090#issuecomment-1507865911 Generally, we firstly review a PR against master branch and pick it to maintained branches. Unless this is a 2.11 specific issue, please close this one and open a new PR against master

[GitHub] [pulsar] tisonkun commented on pull request #20089: [improve][fn] Upgrade Kotlin version from 1.4.32 to 1.8.20.

2023-04-13 Thread via GitHub
tisonkun commented on PR #20089: URL: https://github.com/apache/pulsar/pull/20089#issuecomment-1507872808 Should we also push this change to master first? I don't think it's a good workflow that we first merge a patch to maintained branches - we can ignore bring it to current 3.0 and

[GitHub] [pulsar] janmee opened a new issue, #20094: [Bug] Topic message id will rollback in some cases

2023-04-13 Thread via GitHub
janmee opened a new issue, #20094: URL: https://github.com/apache/pulsar/issues/20094 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 2.11.0 ### Minimal reproduce step

[GitHub] [pulsar] tisonkun closed issue #19996: [improve][doc] Optimize "Get Started" for transactions

2023-04-13 Thread via GitHub
tisonkun closed issue #19996: [improve][doc] Optimize "Get Started" for transactions URL: https://github.com/apache/pulsar/issues/19996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] github-actions[bot] commented on pull request #19781: [feat][cli] Support for transaction consistence test with PerformanceProducer.

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #19781: URL: https://github.com/apache/pulsar/pull/19781#issuecomment-1507816576 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on pull request #19741: [improve] Make subscriptions on NonPersistentTopic non-durable

2023-04-13 Thread via GitHub
github-actions[bot] commented on PR #19741: URL: https://github.com/apache/pulsar/pull/19741#issuecomment-1507816641 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #19705: PIP-254: Support configuring client version with a description suffix

2023-04-13 Thread via GitHub
github-actions[bot] commented on issue #19705: URL: https://github.com/apache/pulsar/issues/19705#issuecomment-1507816685 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] dragonls commented on a diff in pull request #20068: [fix][broker] Fix tenant admin authorization bug.

2023-04-13 Thread via GitHub
dragonls commented on code in PR #20068: URL: https://github.com/apache/pulsar/pull/20068#discussion_r1166214272 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java: ## @@ -84,7 +84,18 @@ public void

[pulsar-site] branch matrix-page updated (a71872ef570 -> d6b3dcf4d57)

2023-04-13 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch matrix-page in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from a71872ef570 update add d6b3dcf4d57 update No new revisions were added by this update. Summary of

[GitHub] [pulsar] tisonkun commented on issue #19456: Flaky-test: MetadataStoreStatsTest.testMetadataStoreStats

2023-04-13 Thread via GitHub
tisonkun commented on issue #19456: URL: https://github.com/apache/pulsar/issues/19456#issuecomment-1507849750 @niharrathod Yes. This is a flaky test highly possible due to concurrent issue, which is hard to reproduce. -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18877: [fix] [broker] getLastMessageId returns a wrong batch index of last message if enabled read compacted

2023-04-13 Thread via GitHub
poorbarcode commented on code in PR #18877: URL: https://github.com/apache/pulsar/pull/18877#discussion_r1166226668 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -2017,6 +2027,25 @@ private void

[GitHub] [pulsar] Anonymitaet commented on pull request #19849: [feat] PIP-257: Add AuthenticationProviderOpenID

2023-04-13 Thread via GitHub
Anonymitaet commented on PR #19849: URL: https://github.com/apache/pulsar/pull/19849#issuecomment-1507856747 @michaeljmarshall thanks for bringing this great feature! I see this PR is labeled with `doc-required`, would you like to contribute docs? So that users will know what it is and how

[GitHub] [pulsar] tisonkun commented on issue #20078: Provide proper exception messages for mTLS authentication

2023-04-13 Thread via GitHub
tisonkun commented on issue #20078: URL: https://github.com/apache/pulsar/issues/20078#issuecomment-1507875518 Close as answered. The meaningful exception is included in client logs, although not at the very last. If anyone find the patch above can properly integrated to master, feel

[GitHub] [pulsar] tisonkun closed issue #20078: Provide proper exception messages for mTLS authentication

2023-04-13 Thread via GitHub
tisonkun closed issue #20078: Provide proper exception messages for mTLS authentication URL: https://github.com/apache/pulsar/issues/20078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-site] Anonymitaet commented on pull request #516: Refine the java client doc

2023-04-13 Thread via GitHub
Anonymitaet commented on PR #516: URL: https://github.com/apache/pulsar-site/pull/516#issuecomment-1507821288 @RobertIndie Thanks for your contribution! Does this change apply to multiple doc versions (which are in the maintenance cycle)? If so, please [update them

[GitHub] [pulsar-site] RobertIndie commented on pull request #516: Refine the java client doc

2023-04-13 Thread via GitHub
RobertIndie commented on PR #516: URL: https://github.com/apache/pulsar-site/pull/516#issuecomment-1507830255 @Anonymitaet, I have updated all of them. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] tisonkun commented on pull request #12411: use correct property when determine if jsr310 enabled

2023-04-13 Thread via GitHub
tisonkun commented on PR #12411: URL: https://github.com/apache/pulsar/pull/12411#issuecomment-1507843910 @dhermanson Thanks for your investigation! Would you open a PR against master? I'm glad to review it. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun opened a new issue, #20093: [BUG] Use correct property when determine if jsr310 enabled

2023-04-13 Thread via GitHub
tisonkun opened a new issue, #20093: URL: https://github.com/apache/pulsar/issues/20093 It looks like this issue remains unfixed [in master](https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/SchemaDefinitionBuilderImpl.java#L132).

[GitHub] [pulsar] tisonkun commented on issue #20013: CVE-2022-1471 identified on pulsar client for snakeyaml's SafeConstructor usage mandate

2023-04-13 Thread via GitHub
tisonkun commented on issue #20013: URL: https://github.com/apache/pulsar/issues/20013#issuecomment-1507874888 It seems Jackson 2.14.2 depends to snakeyaml 2.0 now and https://github.com/apache/pulsar/pull/20085 should fix this issue. @sindhushreem you're welcome to try out the

[GitHub] [pulsar] tisonkun commented on issue #17211: Pulsar Shell: native image with GraalVM

2023-04-13 Thread via GitHub
tisonkun commented on issue #17211: URL: https://github.com/apache/pulsar/issues/17211#issuecomment-1507886377 Moved to the general discussion topic. This is hard to do because GraalVM requires developer to help marking all reflections and resources, as well as some subtle runtime issues.

[GitHub] [pulsar] janmee commented on issue #20094: [Bug] Topic message id will rollback in some cases

2023-04-13 Thread via GitHub
janmee commented on issue #20094: URL: https://github.com/apache/pulsar/issues/20094#issuecomment-1507893056 more log for broker A, broker A consider believes that it is the owner of the topic while broker B works well for client. 2023-04-12T15:17:26,356+0800 [pulsar-io-4-7] INFO

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #18877: [fix] [broker] getLastMessageId returns a wrong batch index of last message if enabled read compacted

2023-04-13 Thread via GitHub
heesung-sn commented on code in PR #18877: URL: https://github.com/apache/pulsar/pull/18877#discussion_r1165000498 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -2017,6 +2027,25 @@ private void

[pulsar-client-node] branch branch-1.8 updated: Bump json5 and tsconfig-paths (#270)

2023-04-13 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch branch-1.8 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git The following commit(s) were added to refs/heads/branch-1.8 by this push: new 7b3de1f Bump json5 and

[GitHub] [pulsar] harikrishna553 opened a new issue, #20097: [Doc] Link for MessageListener interface is broken

2023-04-13 Thread via GitHub
harikrishna553 opened a new issue, #20097: URL: https://github.com/apache/pulsar/issues/20097 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs?

[pulsar-client-node] annotated tag v1.8.2-rc.4 updated (7b3de1f -> ac8c279)

2023-04-13 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a change to annotated tag v1.8.2-rc.4 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git *** WARNING: tag v1.8.2-rc.4 was modified! *** from 7b3de1f (commit) to ac8c279 (tag)

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20075: [fix][broker] Fix avoid future of clear delayed message can't complete

2023-04-13 Thread via GitHub
mattisonchao commented on code in PR #20075: URL: https://github.com/apache/pulsar/pull/20075#discussion_r1166245669 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTrackerFactory.java: ## @@ -72,6 +78,26 @@ public DelayedDeliveryTracker

[GitHub] [pulsar] tisonkun commented on issue #19694: Cors issue

2023-04-13 Thread via GitHub
tisonkun commented on issue #19694: URL: https://github.com/apache/pulsar/issues/19694#issuecomment-1507881728 @gk0307 Can you provide a minimal reproduce repo? I don't find `Access-Control-Allow-Origin` config in broker.conf and also other configs. -- This is an automated message from

[GitHub] [pulsar] tisonkun commented on issue #19338: SQL HTTP 404 schema not found

2023-04-13 Thread via GitHub
tisonkun commented on issue #19338: URL: https://github.com/apache/pulsar/issues/19338#issuecomment-1507882753 @suhoangson Can you provide a complete reproduce steps? Said how you define table schema. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] tisonkun closed issue #17294: [ Doc ] I can't configure TLS vector to pulsar like vector to kafka

2023-04-13 Thread via GitHub
tisonkun closed issue #17294: [ Doc ] I can't configure TLS vector to pulsar like vector to kafka URL: https://github.com/apache/pulsar/issues/17294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] tisonkun commented on issue #17294: [ Doc ] I can't configure TLS vector to pulsar like vector to kafka

2023-04-13 Thread via GitHub
tisonkun commented on issue #17294: URL: https://github.com/apache/pulsar/issues/17294#issuecomment-1507884814 Closed as answered. If you have further issue, welcome to open a question at https://github.com/apache/pulsar/discussions/categories/q-a. -- This is an automated message

[GitHub] [pulsar] tisonkun commented on issue #10698: [Tests] PrometheusMetricsTest testAuthMetrics is flaky on branch-2.7

2023-04-13 Thread via GitHub
tisonkun commented on issue #10698: URL: https://github.com/apache/pulsar/issues/10698#issuecomment-1507886869 Close as stale. We don't maintain 2.7 anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] tisonkun closed issue #10698: [Tests] PrometheusMetricsTest testAuthMetrics is flaky on branch-2.7

2023-04-13 Thread via GitHub
tisonkun closed issue #10698: [Tests] PrometheusMetricsTest testAuthMetrics is flaky on branch-2.7 URL: https://github.com/apache/pulsar/issues/10698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] tisonkun closed issue #17211: Pulsar Shell: native image with GraalVM

2023-04-13 Thread via GitHub
tisonkun closed issue #17211: Pulsar Shell: native image with GraalVM URL: https://github.com/apache/pulsar/issues/17211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] github-actions[bot] added a comment to the discussion: Pulsar Shell: native image with GraalVM

2023-04-13 Thread GitBox
GitHub user github-actions[bot] added a comment to the discussion: Pulsar Shell: native image with GraalVM The issue had no activity for 30 days, mark with Stale label. GitHub link: https://github.com/apache/pulsar/discussions/20095#discussioncomment-5611443 This is an automatically

[GitHub] [pulsar] tisonkun added a comment to the discussion: Pulsar Shell: native image with GraalVM

2023-04-13 Thread GitBox
GitHub user tisonkun added a comment to the discussion: Pulsar Shell: native image with GraalVM Moved to the general discussion topic. This is hard to do because GraalVM requires developer to help marking all reflections and resources, as well as some subtle runtime issues. Ref - *

[GitHub] [pulsar] tisonkun opened a new pull request, #20096: [improve][broker] Harden non-null checker

2023-04-13 Thread via GitHub
tisonkun opened a new pull request, #20096: URL: https://github.com/apache/pulsar/pull/20096 This closes #17107. Actually, after review all code path, I don't think there's a chance we pass `null` there now. But we can somehow harden the use case. ### Does this pull request

[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #247: [feat] Support set consumer regex subscription mode for C client.

2023-04-13 Thread via GitHub
BewareMyPower commented on PR #247: URL: https://github.com/apache/pulsar-client-cpp/pull/247#issuecomment-1507931031 Could you rebase to master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-client-cpp] BewareMyPower opened a new pull request, #251: Fix the static library might failed to link on Windows

2023-04-13 Thread via GitHub
BewareMyPower opened a new pull request, #251: URL: https://github.com/apache/pulsar-client-cpp/pull/251 ### Motivation Currently the CI in master is broken, here is an example failure: https://github.com/apache/pulsar-client-cpp/actions/runs/4688588681/jobs/8309495018?pr=249

[pulsar] branch master updated (4d8156fca05 -> 653271e8d8a)

2023-04-13 Thread xiangying
This is an automated email from the ASF dual-hosted git repository. xiangying pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 4d8156fca05 [improve][ci]Add branch-3.0 to owasp checks (#20081) add 653271e8d8a [fix][test]Fix flaky test

[GitHub] [pulsar] liangyepianzhou closed issue #18466: Flaky-test: TransactionEndToEndTest.produceCommitTest

2023-04-13 Thread via GitHub
liangyepianzhou closed issue #18466: Flaky-test: TransactionEndToEndTest.produceCommitTest URL: https://github.com/apache/pulsar/issues/18466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] liangyepianzhou merged pull request #20006: [fix][test]Fix flaky test produceCommitTest

2023-04-13 Thread via GitHub
liangyepianzhou merged PR #20006: URL: https://github.com/apache/pulsar/pull/20006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] coderzc closed pull request #20082: [fix][broker] Fix avoid consume stuck when load delayed message index exception

2023-04-13 Thread via GitHub
coderzc closed pull request #20082: [fix][broker] Fix avoid consume stuck when load delayed message index exception URL: https://github.com/apache/pulsar/pull/20082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] nodece commented on a diff in pull request #20068: [fix][broker] Fix tenant admin authorization bug.

2023-04-13 Thread via GitHub
nodece commented on code in PR #20068: URL: https://github.com/apache/pulsar/pull/20068#discussion_r1165799714 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java: ## @@ -84,7 +84,18 @@ public void

[GitHub] [pulsar] nodece commented on pull request #20089: [improve][fn] Upgrade Kotlin version from 1.4.32 to 1.8.20.

2023-04-13 Thread via GitHub
nodece commented on PR #20089: URL: https://github.com/apache/pulsar/pull/20089#issuecomment-1507315375 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] codecov-commenter commented on pull request #20075: [fix][broker] Fix avoid future of clear delayed message can't complete

2023-04-13 Thread via GitHub
codecov-commenter commented on PR #20075: URL: https://github.com/apache/pulsar/pull/20075#issuecomment-1507289071 ## [Codecov](https://codecov.io/gh/apache/pulsar/pull/20075?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] niharrathod commented on issue #19456: Flaky-test: MetadataStoreStatsTest.testMetadataStoreStats

2023-04-13 Thread via GitHub
niharrathod commented on issue #19456: URL: https://github.com/apache/pulsar/issues/19456#issuecomment-1507318306 @tisonkun : Actually, I tried to re-produce running unit test locally using below command but I could not re-produce the same. I didn't work further on this.

[pulsar] branch master updated (653271e8d8a -> 091ee2504ff)

2023-04-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 653271e8d8a [fix][test]Fix flaky test produceCommitTest (#20006) add 091ee2504ff [improve][broker] PIP-192 Fix

[GitHub] [pulsar] merlimat merged pull request #20087: [improve][broker] PIP-192 Fix getLastMessageId for compressed payload(And add compression and maxBatchSize for the load balance system topic)

2023-04-13 Thread via GitHub
merlimat merged PR #20087: URL: https://github.com/apache/pulsar/pull/20087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch branch-3.0 updated: [improve][broker] PIP-192 Fix getLastMessageId for compressed payload(And add compression and maxBatchSize for the load balance system topic) (#20087)

2023-04-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new c8d2bba651b [improve][broker] PIP-192