Re: [PR] [fix] Fix concurrent containers concurrency issue [pulsar]

2024-04-27 Thread via GitHub
dao-jun commented on PR #22604: URL: https://github.com/apache/pulsar/pull/22604#issuecomment-2080396837 > Thanks for reporting the issue and starting the work to fix this issue. > > Catching the exception would be the preferred solution since there's no point of using a StampedLock

Re: [PR] [fix] Fix concurrent containers concurrency issue [pulsar]

2024-04-27 Thread via GitHub
lhotari commented on PR #22604: URL: https://github.com/apache/pulsar/pull/22604#issuecomment-2080399467 > > Thanks for reporting the issue and starting the work to fix this issue. > > Catching the exception would be the preferred solution since there's no point of using a StampedLock

Re: [PR] [fix] Fix concurrent containers concurrency issue [pulsar]

2024-04-27 Thread via GitHub
lhotari commented on PR #22604: URL: https://github.com/apache/pulsar/pull/22604#issuecomment-2080399667 Found it: https://github.com/apache/pulsar/pull/18390#discussion_r1016594541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [fix] Fix concurrent containers concurrency issue [pulsar]

2024-04-27 Thread via GitHub
dao-jun closed pull request #22604: [fix] Fix concurrent containers concurrency issue URL: https://github.com/apache/pulsar/pull/22604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [Bug] Pulsar concurrent containers has concurrency issues [pulsar]

2024-04-27 Thread via GitHub
dao-jun closed issue #22603: [Bug] Pulsar concurrent containers has concurrency issues URL: https://github.com/apache/pulsar/issues/22603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [Bug] Pulsar concurrent containers has concurrency issues [pulsar]

2024-04-27 Thread via GitHub
lhotari commented on issue #22603: URL: https://github.com/apache/pulsar/issues/22603#issuecomment-2080399302 #18388 is related -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [fix] Fix concurrent containers concurrency issue [pulsar]

2024-04-27 Thread via GitHub
dao-jun commented on PR #22604: URL: https://github.com/apache/pulsar/pull/22604#issuecomment-2080404065 Oh, I see, it looks like introduced local variables to avoid ArrayIndexOutOfBoundsExeception. It makes sense, we can sync https://github.com/apache/pulsar/pull/18390 to bookkeeper. --

Re: [D] Geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user ragaur-tibco edited a discussion: Geo-replication with SSL I was trying to setup the geo replication servers and created one cluster but after completing the geo-replication server with SSL facing below error ``` > java.util.concurrent.CompletionException:

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user visortelle edited a comment on the discussion: Not able to configure geo-replication with SSL Hi @ragaur-tibco >From my understanding, you have two running clusters `cluster-a` and >`cluster-b`. For `cluster-a` you ran: ``` bin/pulsar-admin clusters create \

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user visortelle added a comment to the discussion: Not able to configure geo-replication with SSL Hi @ragaur-tibco >From my understanding, you have two running clusters `cluster-a` and >`cluster-b`. For `cluster-a` you ran: ``` bin/pulsar-admin clusters create \

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user visortelle edited a comment on the discussion: Not able to configure geo-replication with SSL Hi @ragaur-tibco >From my understanding, you have two running clusters `cluster-a` and >`cluster-b`. For `cluster-a` you ran: ``` bin/pulsar-admin clusters create \

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user visortelle edited a comment on the discussion: Not able to configure geo-replication with SSL Hi @ragaur-tibco >From my understanding, you have two running clusters `cluster-a` and >`cluster-b`. For `cluster-a` you ran: ``` bin/pulsar-admin clusters create \

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user visortelle edited a comment on the discussion: Not able to configure geo-replication with SSL Hi @ragaur-tibco >From my understanding, you have two running clusters `cluster-a` and >`cluster-b`. For `cluster-a` you ran: ``` bin/pulsar-admin clusters create \

(pulsar) branch branch-3.1 updated: [fix][test] Flaky-test: ManagedLedgerTest.testTimestampOnWorkingLedger (#22600)

2024-04-27 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new bfdbd20b4bc [fix][test] Flaky-test:

(pulsar) branch branch-3.2 updated: [fix][test] Flaky-test: ManagedLedgerTest.testTimestampOnWorkingLedger (#22600)

2024-04-27 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.2 by this push: new cdd50a44f1f [fix][test] Flaky-test:

(pulsar) branch master updated: [fix][test] Flaky-test: ManagedLedgerTest.testTimestampOnWorkingLedger (#22600)

2024-04-27 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5d9ccd48520 [fix][test] Flaky-test:

Re: [PR] [fix][test] Flaky-test: ManagedLedgerTest.testTimestampOnWorkingLedger [pulsar]

2024-04-27 Thread via GitHub
shibd merged PR #22600: URL: https://github.com/apache/pulsar/pull/22600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[I] [Bug] ReadonlyManagedLedger initialization does ont fill in the properties [pulsar]

2024-04-27 Thread via GitHub
gvanyao opened a new issue, #22606: URL: https://github.com/apache/pulsar/issues/22606 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Read release policy - [X] I understand that

Re: [D] Geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user ragaur-tibco edited a discussion: Geo-replication with SSL I was trying to setup the geo replication server and created clusters but after completing the geo-replication server with SSL facing below error ``` > java.util.concurrent.CompletionException: java.lang.RuntimeException:

Re: [D] Geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user ragaur-tibco edited a discussion: Geo-replication with SSL I was trying to setup the geo replication server and created clusters but after completing the geo-replication server with SSL facing below error ``` > java.util.concurrent.CompletionException: java.lang.RuntimeException:

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user ragaur-tibco edited a discussion: Not able to configure geo-replication with SSL I was trying to setup the geo replication server and created clusters but after completing the geo-replication server with SSL facing below error ``` > java.util.concurrent.CompletionException:

(pulsar) branch branch-3.0 updated: [fix][test] Flaky-test: ManagedLedgerTest.testTimestampOnWorkingLedger (#22600)

2024-04-27 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new de7f05175d6 [fix][test] Flaky-test:

[PR] [fix][build] Switch slf4j scope to provided from compile [pulsar]

2024-04-27 Thread via GitHub
nodece opened a new pull request, #22607: URL: https://github.com/apache/pulsar/pull/22607 ### Motivation #22391 upgrades the slf4j version to 2.0.13. When the users upgrade the broker/client library to the master version, #22391 breaks users who are using slf4j 1.x, and their

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user visortelle edited a comment on the discussion: Not able to configure geo-replication with SSL Hi @ragaur-tibco >From my understanding, you have two running clusters `cluster-a` and >`cluster-b`. For `cluster-a` you ran: ``` bin/pulsar-admin clusters create \

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user visortelle edited a comment on the discussion: Not able to configure geo-replication with SSL Hi @ragaur-tibco >From my understanding, you have two running clusters `cluster-a` and >`cluster-b`. For `cluster-a` you ran: ``` bin/pulsar-admin clusters create \

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user visortelle edited a comment on the discussion: Not able to configure geo-replication with SSL Hi @ragaur-tibco >From my understanding, you have two running clusters `cluster-a` and >`cluster-b`. For `cluster-a` you ran: ``` bin/pulsar-admin clusters create \

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user visortelle edited a comment on the discussion: Not able to configure geo-replication with SSL Hi @ragaur-tibco >From my understanding, you have two running clusters `cluster-a` and >`cluster-b`. For `cluster-a` you ran: ``` bin/pulsar-admin clusters create \

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user visortelle edited a comment on the discussion: Not able to configure geo-replication with SSL Hi @ragaur-tibco >From my understanding, you have two running clusters `cluster-a` and >`cluster-b`. For `cluster-a` you ran: ``` bin/pulsar-admin clusters create \

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user visortelle edited a comment on the discussion: Not able to configure geo-replication with SSL Hi @ragaur-tibco >From my understanding, you have two running clusters `cluster-a` and >`cluster-b`. For `cluster-a` you ran: ``` bin/pulsar-admin clusters create \

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-27 Thread via GitHub
poorbarcode commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2081093590 >> @poorbarcode looks like OneWayReplicatorTest.testUnFenceTopicToReuse fails > Sorry, I found a behavior change(before: broker tries to unfence topic to reuse when clos

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-27 Thread via GitHub
codecov-commenter commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2081126369 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/17524?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-27 Thread via GitHub
lhotari commented on code in PR #17524: URL: https://github.com/apache/pulsar/pull/17524#discussion_r1581892388 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1605,40 +1691,74 @@ public CompletableFuture close(

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user ragaur-tibco edited a comment on the discussion: Not able to configure geo-replication with SSL @visortelle I use the command to connect cluster A to cluster B but didn't ran the command with cluster B to cluster A and I have used broker-url-secure and url-secure and didn't

Re: [D] Not able to configure geo-replication with SSL [pulsar]

2024-04-27 Thread via GitHub
GitHub user ragaur-tibco added a comment to the discussion: Not able to configure geo-replication with SSL I use the command to connect cluster A to cluster B but didn't ran the command with cluster B to cluster A and I have used broker-url-secure and url-secure and didn't specify the

Re: [I] Zookeeper SSL Failures When Certificate Is Rolled [pulsar-helm-chart]

2024-04-27 Thread via GitHub
d80tb7 commented on issue #359: URL: https://github.com/apache/pulsar-helm-chart/issues/359#issuecomment-2081182686 I think the issue here is that although the Pulsar Helm Chart sets the `zookeeper.client.certReload` property, this isn't enough. All that property does is to get Zookeeper

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
BewareMyPower commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582000782 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -1852,6 +1852,51 @@ public void

Re: [PR] [fix][broker] One topic can be closed multiple times concurrently [pulsar]

2024-04-27 Thread via GitHub
poorbarcode commented on code in PR #17524: URL: https://github.com/apache/pulsar/pull/17524#discussion_r1582003453 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1605,40 +1691,74 @@ public CompletableFuture close(

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
BewareMyPower commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582006268 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -1852,6 +1852,51 @@ public void

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
shibd commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582012492 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -1852,6 +1852,51 @@ public void findEntryFailed(ManagedLedgerException

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
BewareMyPower commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582014350 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -1852,6 +1852,51 @@ public void

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
BewareMyPower commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582015087 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -1852,6 +1852,51 @@ public void

(pulsar) branch master updated: [improve][test] Add policy authentication test for namespace API (#22593)

2024-04-27 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1bb9378b50a [improve][test] Add policy

Re: [PR] [improve][test] Add policy authentication test for namespace API [pulsar]

2024-04-27 Thread via GitHub
Technoboy- merged PR #22593: URL: https://github.com/apache/pulsar/pull/22593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
shibd commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582017168 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -1852,6 +1852,51 @@ public void findEntryFailed(ManagedLedgerException

Re: [I] Automatic certificate renewal does not work [pulsar-helm-chart]

2024-04-27 Thread via GitHub
d80tb7 commented on issue #285: URL: https://github.com/apache/pulsar-helm-chart/issues/285#issuecomment-2081183119 Just to check- has anyone got cert refresh working with zookeeper? I'm of the opinion that this still won't work. Copying the explanation here from [my comment

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
coderzc commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582011285 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3625,6 +3626,15 @@ public Position getLastPosition() {

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
RobertIndie commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582002409 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -1852,6 +1852,51 @@ public void

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
codelipenghui commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582004224 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorSubscriptionTest.java: ## @@ -167,6 +168,82 @@ public void

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
shibd commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582017410 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3625,6 +3626,15 @@ public Position getLastPosition() {

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
codelipenghui commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582017648 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -1852,6 +1852,51 @@ public void

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
codelipenghui commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582020334 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorSubscriptionTest.java: ## @@ -167,6 +168,82 @@ public void

Re: [PR] [fix][test] Flaky-test: AdminApiMultiBrokersTest.testForceDeletePartitionedTopicWithSub [pulsar]

2024-04-27 Thread via GitHub
Technoboy- closed pull request #22592: [fix][test] Flaky-test: AdminApiMultiBrokersTest.testForceDeletePartitionedTopicWithSub URL: https://github.com/apache/pulsar/pull/22592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
coderzc commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582008865 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java: ## @@ -509,6 +509,16 @@ public PositionImpl

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
shibd commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582018517 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorSubscriptionTest.java: ## @@ -167,6 +168,82 @@ public void

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-27 Thread via GitHub
BewareMyPower commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1582018608 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -1852,6 +1852,51 @@ public void