[GitHub] superbaobei opened a new issue #2950: is Authentication available in java client?

2018-11-06 Thread GitBox
superbaobei opened a new issue #2950: is Authentication available in java client? URL: https://github.com/apache/pulsar/issues/2950 i'm newer for pulsar today I read pulsar java client in org.apache.pulsar.client.impl.conf.ClientConfigurationData in class ClientConfigurationData

[GitHub] srkukarni commented on issue #2944: Make Log a logger instead of Logger Adapter

2018-11-06 Thread GitBox
srkukarni commented on issue #2944: Make Log a logger instead of Logger Adapter URL: https://github.com/apache/pulsar/pull/2944#issuecomment-436517476 rerun integration tests This is an automated message from the Apache Git Se

[GitHub] srkukarni commented on issue #2946: Make sure that the returned object is string for conversion purposes

2018-11-06 Thread GitBox
srkukarni commented on issue #2946: Make sure that the returned object is string for conversion purposes URL: https://github.com/apache/pulsar/pull/2946#issuecomment-436517381 rerun integration tests This is an automated mess

[GitHub] jiazhai opened a new pull request #2949: default enable cpp client producer batch

2018-11-06 Thread GitBox
jiazhai opened a new pull request #2949: default enable cpp client producer batch URL: https://github.com/apache/pulsar/pull/2949 ### Motivation In Cpp client producer batching is disabled by default, This is not align with java client, and use default value will cause benchmark h

[GitHub] jiazhai commented on issue #2943: Issue #2657: change function cli getstate to use REST endpoint

2018-11-06 Thread GitBox
jiazhai commented on issue #2943: Issue #2657: change function cli getstate to use REST endpoint URL: https://github.com/apache/pulsar/pull/2943#issuecomment-436510431 rerun integration tests This is an automated message from

[GitHub] srkukarni closed pull request #2945: Make sure to create client before doing admission check

2018-11-06 Thread GitBox
srkukarni closed pull request #2945: Make sure to create client before doing admission check URL: https://github.com/apache/pulsar/pull/2945 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[pulsar] branch master updated: Make sure to create client before doing admission check (#2945)

2018-11-06 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 144ee74 Make sure to create client before do

[GitHub] merlimat commented on issue #2948: Fix Get Function Cluster in Doc

2018-11-06 Thread GitBox
merlimat commented on issue #2948: Fix Get Function Cluster in Doc URL: https://github.com/apache/pulsar/pull/2948#issuecomment-436499642 @k2la please also update in the master docs directory at https://github.com/apache/pulsar/blob/master/site2/docs/functions-quickstart.m d ---

[GitHub] nkurihar closed pull request #2948: Fix Get Function Cluster in Doc

2018-11-06 Thread GitBox
nkurihar closed pull request #2948: Fix Get Function Cluster in Doc URL: https://github.com/apache/pulsar/pull/2948 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[pulsar] branch master updated: fix api path (#2948)

2018-11-06 Thread nkurihar
This is an automated email from the ASF dual-hosted git repository. nkurihar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e0c3430 fix api path (#2948) e0c3430 is descr

[GitHub] jiazhai commented on a change in pull request #2943: Issue #2657: change function cli getstate to use REST endpoint

2018-11-06 Thread GitBox
jiazhai commented on a change in pull request #2943: Issue #2657: change function cli getstate to use REST endpoint URL: https://github.com/apache/pulsar/pull/2943#discussion_r231373245 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java #

[GitHub] k2la opened a new pull request #2948: Fix Get Function Cluster in Doc

2018-11-06 Thread GitBox
k2la opened a new pull request #2948: Fix Get Function Cluster in Doc URL: https://github.com/apache/pulsar/pull/2948 ### Motivation http://pulsar.apache.org/docs/en/io-quickstart/ > curl -s http://localhost:8080/admin/v2/functions/cluster This command returns the result lik

[GitHub] srkukarni opened a new pull request #2947: Check for presence of namespace/tenant before creating function

2018-11-06 Thread GitBox
srkukarni opened a new pull request #2947: Check for presence of namespace/tenant before creating function URL: https://github.com/apache/pulsar/pull/2947 ### Motivation Currently functions can be created even if the corresponding namespace/tenant does not exist. This is contrary to

[GitHub] srkukarni commented on a change in pull request #2945: Make sure to create client before doing admission check

2018-11-06 Thread GitBox
srkukarni commented on a change in pull request #2945: Make sure to create client before doing admission check URL: https://github.com/apache/pulsar/pull/2945#discussion_r231356874 ## File path: pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/KubernetesRu

[GitHub] jerrypeng commented on a change in pull request #2945: Make sure to create client before doing admission check

2018-11-06 Thread GitBox
jerrypeng commented on a change in pull request #2945: Make sure to create client before doing admission check URL: https://github.com/apache/pulsar/pull/2945#discussion_r231349895 ## File path: pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/KubernetesRu

[GitHub] srkukarni commented on issue #2945: Make sure to create client before doing admission check

2018-11-06 Thread GitBox
srkukarni commented on issue #2945: Make sure to create client before doing admission check URL: https://github.com/apache/pulsar/pull/2945#issuecomment-436458056 rerun integration tests This is an automated message from the

[GitHub] srkukarni commented on a change in pull request #2945: Make sure to create client before doing admission check

2018-11-06 Thread GitBox
srkukarni commented on a change in pull request #2945: Make sure to create client before doing admission check URL: https://github.com/apache/pulsar/pull/2945#discussion_r231331197 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRu

[GitHub] david-streamlio commented on issue #2869: Added Pulsar IO connector for local files

2018-11-06 Thread GitBox
david-streamlio commented on issue #2869: Added Pulsar IO connector for local files URL: https://github.com/apache/pulsar/pull/2869#issuecomment-436434948 @sijie I am not sure why the test fails during testing. I am able to run the test successfully locally using TestNG 6.13.1. Do we use

[GitHub] srkukarni opened a new pull request #2946: Make sure that the returned object is string for conversion purposes

2018-11-06 Thread GitBox
srkukarni opened a new pull request #2946: Make sure that the returned object is string for conversion purposes URL: https://github.com/apache/pulsar/pull/2946 ### Motivation IdentitySerde does not handle unicode type which is python2 specific. Thus ensure that we convert anything f

[GitHub] cckellogg commented on a change in pull request #2945: Make sure to create client before doing admission check

2018-11-06 Thread GitBox
cckellogg commented on a change in pull request #2945: Make sure to create client before doing admission check URL: https://github.com/apache/pulsar/pull/2945#discussion_r231268686 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRu

[GitHub] srkukarni opened a new pull request #2945: Make sure to create client before doing admission check

2018-11-06 Thread GitBox
srkukarni opened a new pull request #2945: Make sure to create client before doing admission check URL: https://github.com/apache/pulsar/pull/2945 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ### Mod

[GitHub] merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself

2018-11-06 Thread GitBox
merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself URL: https://github.com/apache/pulsar/pull/2935#issuecomment-436360575 run integration tests This is an automated messa

[GitHub] srkukarni opened a new pull request #2944: Make Log a logger instead of Logger Adapter

2018-11-06 Thread GitBox
srkukarni opened a new pull request #2944: Make Log a logger instead of Logger Adapter URL: https://github.com/apache/pulsar/pull/2944 ### Motivation A lot of places in the code assumes Log to be a Logger. Thus change it to be a Logger instance. ### Modifications Describe

[GitHub] merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself

2018-11-06 Thread GitBox
merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself URL: https://github.com/apache/pulsar/pull/2935#issuecomment-436344197 run integration tests This is an automated messa

[GitHub] sijie commented on issue #2936: [io][docs] introduce annotations for generating connector yaml config files

2018-11-06 Thread GitBox
sijie commented on issue #2936: [io][docs] introduce annotations for generating connector yaml config files URL: https://github.com/apache/pulsar/pull/2936#issuecomment-436339111 run integration tests This is an automated mes

[GitHub] sijie commented on issue #2901: pulsar-io/hdfs Maven compilation failed

2018-11-06 Thread GitBox
sijie commented on issue #2901: pulsar-io/hdfs Maven compilation failed URL: https://github.com/apache/pulsar/issues/2901#issuecomment-436337045 @nanguawu I think current hdfs connector is tied to 3.x first. we need to do some adjustment to support hdfs 2.x. will take a look at how

[GitHub] srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance

2018-11-06 Thread GitBox
srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#discussion_r231216618 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java

[GitHub] srkukarni commented on a change in pull request #2943: Issue #2657: change function cli getstate to use REST endpoint

2018-11-06 Thread GitBox
srkukarni commented on a change in pull request #2943: Issue #2657: change function cli getstate to use REST endpoint URL: https://github.com/apache/pulsar/pull/2943#discussion_r231214788 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java

[pulsar] branch master updated: Made Window Context up to date with Context (#2932)

2018-11-06 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new da0cc00 Made Window Context up to date with

[GitHub] srkukarni closed pull request #2932: Made Window Context up to date with Context

2018-11-06 Thread GitBox
srkukarni closed pull request #2932: Made Window Context up to date with Context URL: https://github.com/apache/pulsar/pull/2932 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself

2018-11-06 Thread GitBox
merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself URL: https://github.com/apache/pulsar/pull/2935#issuecomment-436295364 run cpp tests run integration tests This is

[GitHub] ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage

2018-11-06 Thread GitBox
ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r231168068 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/BlobStoreRepository.

[GitHub] jiazhai opened a new pull request #2943: Issue #2657: change function cli getstate to use REST endpoint

2018-11-06 Thread GitBox
jiazhai opened a new pull request #2943: Issue #2657: change function cli getstate to use REST endpoint URL: https://github.com/apache/pulsar/pull/2943 ### Motivation change StateGetter to use REST endpoint ### Modifications - change StateGetter to use REST endpoint

[GitHub] srkukarni commented on issue #2932: Made Window Context up to date with Context

2018-11-06 Thread GitBox
srkukarni commented on issue #2932: Made Window Context up to date with Context URL: https://github.com/apache/pulsar/pull/2932#issuecomment-436264549 rerun integration tests This is an automated message from the Apache Git Se

[GitHub] nanguawu commented on issue #2901: pulsar-io/hdfs Maven compilation failed

2018-11-06 Thread GitBox
nanguawu commented on issue #2901: pulsar-io/hdfs Maven compilation failed URL: https://github.com/apache/pulsar/issues/2901#issuecomment-436223887 @sijie yeah,I manually changed the hdfs client to 2.6.0 This is an automate

[GitHub] jiazhai commented on issue #2869: Added Pulsar IO connector for local files

2018-11-06 Thread GitBox
jiazhai commented on issue #2869: Added Pulsar IO connector for local files URL: https://github.com/apache/pulsar/pull/2869#issuecomment-436199269 overall lgtm, But @david-streamlio Seems the ut is flaky: org.apache.pulsar.io.file.FileSourceConfigTests.InvalidBooleanPropertyTest https:/

[GitHub] codelipenghui edited a comment on issue #2876: Limit the client reconnect behavior.

2018-11-06 Thread GitBox
codelipenghui edited a comment on issue #2876: Limit the client reconnect behavior. URL: https://github.com/apache/pulsar/issues/2876#issuecomment-435292468 @sijie I think more secure and unified on broker side, broker already limit the maxConsumersPerTopic and maxConsumersPerSubsc

[pulsar] branch asf-site updated: Updated site at revision 4fb60ee

2018-11-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 85a22c8 Updated site at revision 4fb60ee 85

[GitHub] jiazhai commented on issue #2869: Added Pulsar IO connector for local files

2018-11-06 Thread GitBox
jiazhai commented on issue #2869: Added Pulsar IO connector for local files URL: https://github.com/apache/pulsar/pull/2869#issuecomment-436174683 rerun java8 tests This is an automated message from the Apache Git Service. To

[GitHub] jiazhai commented on issue #2906: [bookkeeper] bump bookkepeer version to 4.9.0

2018-11-06 Thread GitBox
jiazhai commented on issue #2906: [bookkeeper] bump bookkepeer version to 4.9.0 URL: https://github.com/apache/pulsar/pull/2906#issuecomment-436173961 retest this please This is an automated message from the Apache Git Service

[GitHub] jiazhai commented on issue #2936: [io][docs] introduce annotations for generating connector yaml config files

2018-11-06 Thread GitBox
jiazhai commented on issue #2936: [io][docs] introduce annotations for generating connector yaml config files URL: https://github.com/apache/pulsar/pull/2936#issuecomment-436173718 rerun integration tests This is an automated

[pulsar] branch master updated: Handle case where function produces some output but no output topic given (#2941)

2018-11-06 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new be0fe35 Handle case where function produces some

[GitHub] sijie closed pull request #2941: Handle case where function produces some output but no output topic given

2018-11-06 Thread GitBox
sijie closed pull request #2941: Handle case where function produces some output but no output topic given URL: https://github.com/apache/pulsar/pull/2941 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of proven

[pulsar] branch master updated: fix go-client demo code (#2934)

2018-11-06 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 76b46a5 fix go-client demo code (#2934) 76b46a5

[GitHub] sijie closed pull request #2934: fix go-client demo code

2018-11-06 Thread GitBox
sijie closed pull request #2934: fix go-client demo code URL: https://github.com/apache/pulsar/pull/2934 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fo

[GitHub] sijie closed pull request #2940: Fix the conversion process of windowing functions

2018-11-06 Thread GitBox
sijie closed pull request #2940: Fix the conversion process of windowing functions URL: https://github.com/apache/pulsar/pull/2940 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[pulsar] branch master updated: Fix the conversion process of windowing functions (#2940)

2018-11-06 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new fab36a1 Fix the conversion process of windowing

[GitHub] ivankelly commented on a change in pull request #2935: Ensure broker is fully boostrapped before load manager register itself

2018-11-06 Thread GitBox
ivankelly commented on a change in pull request #2935: Ensure broker is fully boostrapped before load manager register itself URL: https://github.com/apache/pulsar/pull/2935#discussion_r231030667 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java

[GitHub] ivankelly commented on a change in pull request #2935: Ensure broker is fully boostrapped before load manager register itself

2018-11-06 Thread GitBox
ivankelly commented on a change in pull request #2935: Ensure broker is fully boostrapped before load manager register itself URL: https://github.com/apache/pulsar/pull/2935#discussion_r231030887 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java

[GitHub] ivankelly commented on issue #2942: Intermittent test failure in TestS3Offload

2018-11-06 Thread GitBox
ivankelly commented on issue #2942: Intermittent test failure in TestS3Offload URL: https://github.com/apache/pulsar/issues/2942#issuecomment-436167012 https://builds.apache.org/job/pulsar_precommit_integrationtests/4684/ Looks like a message is lost.