[GitHub] [pulsar] tuteng commented on issue #5076: [website]The website cannot get the swagger version file
tuteng commented on issue #5076: [website]The website cannot get the swagger version file URL: https://github.com/apache/pulsar/pull/5076#issuecomment-526478423 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5070: [doc] Improve Pulsar security authorization
Monica-zy commented on issue #5070: [doc] Improve Pulsar security authorization URL: https://github.com/apache/pulsar/pull/5070#issuecomment-526477154 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5069: [doc] Improve Pulsar Security Kerberos
Monica-zy commented on issue #5069: [doc] Improve Pulsar Security Kerberos URL: https://github.com/apache/pulsar/pull/5069#issuecomment-526477025 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5052: [doc] Improve Pulsar Security-token-admin
Monica-zy commented on issue #5052: [doc] Improve Pulsar Security-token-admin URL: https://github.com/apache/pulsar/pull/5052#issuecomment-526476903 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] massakam commented on issue #5079: Use "info" as the default root logger level
massakam commented on issue #5079: Use "info" as the default root logger level URL: https://github.com/apache/pulsar/pull/5079#issuecomment-526470545 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai opened a new pull request #5080: Update website for 2.4.1 release
jiazhai opened a new pull request #5080: Update website for 2.4.1 release URL: https://github.com/apache/pulsar/pull/5080 Update website for 2.4.1 release This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar.wiki] branch master updated: Updated Release process (markdown)
This is an automated email from the ASF dual-hosted git repository. zhaijia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 6aa19ee Updated Release process (markdown) 6aa19ee is described below commit 6aa19ee7a3f2f88438beed5611afd4ca96693bb8 Author: Jia Zhai AuthorDate: Fri Aug 30 13:02:08 2019 +0800 Updated Release process (markdown) --- Release-process.md | 1 + 1 file changed, 1 insertion(+) diff --git a/Release-process.md b/Release-process.md index e5e2520..037b131 100644 --- a/Release-process.md +++ b/Release-process.md @@ -347,6 +347,7 @@ cd site2/website 3. Cut a new version of the documentation. ```shell +yarn install yarn run version ```
[GitHub] [pulsar] merlimat opened a new pull request #5079: Use "info" as the default root logger level
merlimat opened a new pull request #5079: Use "info" as the default root logger
level
URL: https://github.com/apache/pulsar/pull/5079
# Motivation
In #3661 the root logger level was made configurable and the level was
changed from `info` to `debug`.
That change had the side effect that the control:
```java
if (log.isDebugEnabled()) {
log.debug("{}", computeExpensiveString());
}
```
is now passing the `if` condition and it's triggering the call to
`computeExpensiveString()` whose value is then never printed. This happens for
all non pulsar logger (eg. `org.apache.zookeeper..` client logs), with the
result of lot of garbage getting created.
Changing back the default value to info.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai opened a new pull request #5078: Add release notes for 2.4.1 release
jiazhai opened a new pull request #5078: Add release notes for 2.4.1 release URL: https://github.com/apache/pulsar/pull/5078 release notes for 2.4.1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng opened a new pull request #5077: [doc]Add document for pulsar IO netty source
tuteng opened a new pull request #5077: [doc]Add document for pulsar IO netty source URL: https://github.com/apache/pulsar/pull/5077 ### Motivation At present, some users want to use the netty source, but the document is not perfect, so the netty source document is added. ### Modifications * Add document of the netty source * Add TCP example and Http example This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai merged pull request #5066: Fix : ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky
jiazhai merged pull request #5066: Fix : ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky URL: https://github.com/apache/pulsar/pull/5066 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai closed issue #4894: ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky
jiazhai closed issue #4894: ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky URL: https://github.com/apache/pulsar/issues/4894 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (e78beaa -> bc76613)
This is an automated email from the ASF dual-hosted git repository. zhaijia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e78beaa [doc] Improve Pulsar Security-athenz (#5053) add bc76613 Fix : ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky (#5066) No new revisions were added by this update. Summary of changes: pulsar-client-cpp/tests/ConsumerStatsTest.cc | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-)
[GitHub] [pulsar] tuteng commented on issue #5076: [website]The website cannot get the swagger version file
tuteng commented on issue #5076: [website]The website cannot get the swagger version file URL: https://github.com/apache/pulsar/pull/5076#issuecomment-526435949 @merlimat I found that some versions of swagger files have not been generated, please generate these files when the website is published.  http://pulsar.apache.org/swagger/2.3.0/ http://pulsar.apache.org/swagger/2.3.1/ http://pulsar.apache.org/swagger/2.3.2/ http://pulsar.apache.org/swagger/2.4.0/ http://pulsar.apache.org/swagger/master/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng opened a new pull request #5076: [website]The website cannot get the swagger version file
tuteng opened a new pull request #5076: [website]The website cannot get the swagger version file URL: https://github.com/apache/pulsar/pull/5076 ### Motivation After multiple versions of rest API are currently supported, a prefix is added to the route of the online environment when it is displayed. resulting in the js file not being available.  ### Modifications * Change js file search to a relative path ### Verifying this change Click http://pulsar.apache.org/admin-rest-api/js/getSwaggerByVersion.js 404 not found Click http://pulsar.apache.org/admin-rest-api/../js/getSwaggerByVersion.js OK This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Muyoo commented on issue #5065: "Connection is already closed" when creating a Producer
Muyoo commented on issue #5065: "Connection is already closed" when creating a Producer URL: https://github.com/apache/pulsar/issues/5065#issuecomment-526428809 What make me confused is that I've never met the same problem when I used other middlewares like PostgreSQL, Kafka, HBase and so on with Docker 18.09.2. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] ppgoml edited a comment on issue #1022: URI("pulsar://broker-:6650").getPort() will return "-1" instead of 6650
ppgoml edited a comment on issue #1022: URI("pulsar://broker-:6650").getPort()
will return "-1" instead of 6650
URL: https://github.com/apache/pulsar/issues/1022#issuecomment-526415141
It seems I cannot use '_' in host.
(new URI("pulsar://tkiot_pulsar1:6650")).getPort() returns -1
I found this useful link.
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=5049974
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] Muyoo opened a new issue #5065: "Connection is already closed" when creating a Producer
Muyoo opened a new issue #5065: "Connection is already closed" when creating a
Producer
URL: https://github.com/apache/pulsar/issues/5065
After I set up a Pulsar in standalone on MacOS, I get an exception
`Connection is already closed` when I create a Producer:
```
15:53:56.739 [pulsar-client-io-1-1] INFO
org.apache.pulsar.client.impl.ClientCnx - [id: 0x3fab3a4b, L:/127.0.0.1:60316 !
R:/127.0.0.1:6650] Disconnected
15:53:56.742 [pulsar-client-io-1-1] WARN
org.apache.pulsar.client.impl.ConnectionPool - [[id: 0x3fab3a4b,
L:/127.0.0.1:60316 ! R:/127.0.0.1:6650]] Connection handshake failed:
org.apache.pulsar.client.api.PulsarClientException: Connection already closed
15:53:56.742 [pulsar-client-io-1-1] WARN
org.apache.pulsar.client.impl.PulsarClientImpl -
[persistent://public/default/wyq-test] Failed to get partitioned topic
metadata: org.apache.pulsar.client.api.PulsarClientException: Connection
already closed
Exception in thread "main"
org.apache.pulsar.client.api.PulsarClientException:
java.util.concurrent.ExecutionException:
org.apache.pulsar.client.api.PulsarClientException: Connection already closed
at
org.apache.pulsar.client.api.PulsarClientException.unwrap(PulsarClientException.java:297)
at
org.apache.pulsar.client.impl.ProducerBuilderImpl.create(ProducerBuilderImpl.java:88)
at
org.xmuyoo.blueberry.crawling.streams.Publisher.main(Publisher.java:108)
Caused by: java.util.concurrent.ExecutionException:
org.apache.pulsar.client.api.PulsarClientException: Connection already closed
at
java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
at
java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895)
at
org.apache.pulsar.client.impl.ProducerBuilderImpl.create(ProducerBuilderImpl.java:86)
... 1 more
Caused by: org.apache.pulsar.client.api.PulsarClientException: Connection
already closed
at
org.apache.pulsar.client.impl.ClientCnx.channelInactive(ClientCnx.java:220)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
at
org.apache.pulsar.shade.io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:390)
at
org.apache.pulsar.shade.io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:355)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
at
org.apache.pulsar.shade.io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1429)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
at
org.apache.pulsar.shade.io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:947)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannel$AbstractUnsafe$8.run(AbstractChannel.java:826)
at
org.apache.pulsar.shade.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
at
org.apache.pulsar.shade.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
at
org.apache.pulsar.shade.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:474)
at
org.apache.pulsar.shade.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:909)
at
org.apache.pulsar.shade.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:748)
```
And I run Pulsar in Docker(18.09.2) with the command in the document:
```
$ docker run -it \
-p 6650:6650 \
-p 8080:8080 \
-v $PWD/data:/pulsar/data \
apachepulsar/pulsar:2.4.0 \
bin/pulsar standalone
```
There is no ERROR in the log messages.
And my code is here:
```Java
public static void main(String[] args) throws Exception {
PulsarClient client = PulsarClient.builder()
.serviceUrl("pulsar://127.0.0.1:665
[GitHub] [pulsar] Muyoo commented on issue #5065: "Connection is already closed" when creating a Producer
Muyoo commented on issue #5065: "Connection is already closed" when creating a Producer URL: https://github.com/apache/pulsar/issues/5065#issuecomment-526426793 Ok. I've just upgraded my Docket Desktop version to 19.03.1 and it works then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Muyoo edited a comment on issue #5065: "Connection is already closed" when creating a Producer
Muyoo edited a comment on issue #5065: "Connection is already closed" when creating a Producer URL: https://github.com/apache/pulsar/issues/5065#issuecomment-526426793 Ok. I've just upgraded my Docker Desktop version to 19.03.1 and it works then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Muyoo closed issue #5065: "Connection is already closed" when creating a Producer
Muyoo closed issue #5065: "Connection is already closed" when creating a Producer URL: https://github.com/apache/pulsar/issues/5065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fxbing commented on issue #5066: Fix : ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky
fxbing commented on issue #5066: Fix : ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky URL: https://github.com/apache/pulsar/pull/5066#issuecomment-526424642 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar.wiki] branch master updated: Updated PIP 40: Pulsar Manager (markdown)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new ca77182 Updated PIP 40: Pulsar Manager (markdown) ca77182 is described below commit ca771826a3536bb83f29935e9f929fe4b682f2a4 Author: Sijie Guo AuthorDate: Thu Aug 29 18:50:14 2019 -0700 Updated PIP 40: Pulsar Manager (markdown) --- PIP-40:-Pulsar-Manager.md | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PIP-40:-Pulsar-Manager.md b/PIP-40:-Pulsar-Manager.md index f8cd0a4..5fe9ccb 100644 --- a/PIP-40:-Pulsar-Manager.md +++ b/PIP-40:-Pulsar-Manager.md @@ -1,7 +1,7 @@ * **Status**: Drafting -* **Author**: -* **Pull Request**: -* **Mailing List discussion**: +* **Author**: Guangning E +* **Pull Request**: https://lists.apache.org/thread.html/ec4437456d399aaefbca0b980bbfb2c63fd83ad1d15a2d05d8046962@%3Cdev.pulsar.apache.org%3E +* **Mailing List discussion**: * **Release**: -Design Proposal: \ No newline at end of file +Design Proposal: https://docs.google.com/document/d/1C3meaHJzxX9wGDWQx-dC1b20yGeKsQtbwNiYuxZgOCE \ No newline at end of file
[GitHub] [pulsar] aahmed-se closed pull request #3982: [WIP] Move Docker images to jdk11 and python3 as default
aahmed-se closed pull request #3982: [WIP] Move Docker images to jdk11 and python3 as default URL: https://github.com/apache/pulsar/pull/3982 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se closed pull request #5035: [WIP] GitHub exp3
aahmed-se closed pull request #5035: [WIP] GitHub exp3 URL: https://github.com/apache/pulsar/pull/5035 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5064: Add Github workflow for gated checkin
aahmed-se commented on issue #5064: Add Github workflow for gated checkin URL: https://github.com/apache/pulsar/pull/5064#issuecomment-526417693 Will leave this one open close all the others. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] ppgoml commented on issue #1022: URI("pulsar://broker-:6650").getPort() will return "-1" instead of 6650
ppgoml commented on issue #1022: URI("pulsar://broker-:6650").getPort() will
return "-1" instead of 6650
URL: https://github.com/apache/pulsar/issues/1022#issuecomment-526415141
It seems I cannot use '_' in host.
(new URI("pulsar://tkiot_pulsar1:6650")).getPort() returns -1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] rdhabalia opened a new pull request #5075: [pulsar-client] support set read-position based on timestamp
rdhabalia opened a new pull request #5075: [pulsar-client] support set read-position based on timestamp URL: https://github.com/apache/pulsar/pull/5075 ### Motivation Right now, Pulsar-Reader can set the initial position by providing messageId. However, some of the users have usecase to only consume messages which are older than X hours and they want to set reader position at specific time and start consuming messages. ### Modification Allow reader to set initial position based on time where user can provide rollback time from where user wants to start reading messages. ### Result - This will not change existing behavior - User can define rollback time from where it can start reading messages on pulsar-reader This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5067: [bookkeeper] Don't return DEFAULT_RACK if ZkBookieRackAffinityMapping can't resolve network location
sijie commented on issue #5067: [bookkeeper] Don't return DEFAULT_RACK if ZkBookieRackAffinityMapping can't resolve network location URL: https://github.com/apache/pulsar/pull/5067#issuecomment-526375917 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5058: [docs] Clarify non-persistent topics guaranties part
sijie commented on issue #5058: [docs] Clarify non-persistent topics guaranties part URL: https://github.com/apache/pulsar/pull/5058#issuecomment-526375750 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5038: [doc] Improve Pulsar security-tls-authentication
sijie commented on issue #5038: [doc] Improve Pulsar security-tls-authentication URL: https://github.com/apache/pulsar/pull/5038#issuecomment-526375703 @Jennifer88huang PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5064: Add Github workflow for gated checkin
sijie commented on issue #5064: Add Github workflow for gated checkin URL: https://github.com/apache/pulsar/pull/5064#issuecomment-526375576 @aahmed-se as discussed in the email thread, it seems Github Action is not a solution for Pulsar. Can we close the related pull requests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie merged pull request #5053: [doc] Improve Pulsar Security-athenz
sijie merged pull request #5053: [doc] Improve Pulsar Security-athenz URL: https://github.com/apache/pulsar/pull/5053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (e231d22 -> e78beaa)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e231d22 [k8s] convert to valid pod name part with k8s function runtime (#4996) add e78beaa [doc] Improve Pulsar Security-athenz (#5053) No new revisions were added by this update. Summary of changes: site2/docs/security-athenz.md | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-)
[GitHub] [pulsar] sijie commented on issue #5070: [doc] Improve Pulsar security authorization
sijie commented on issue #5070: [doc] Improve Pulsar security authorization URL: https://github.com/apache/pulsar/pull/5070#issuecomment-526374758 @Anonymitaet ^^ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5074: [Dashboard] Fix incorrect statistics on tenants page
sijie commented on issue #5074: [Dashboard] Fix incorrect statistics on tenants page URL: https://github.com/apache/pulsar/pull/5074#issuecomment-526374404 @tuteng can you help review this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #4987: Trim deleted entries after recover cursor.
sijie commented on issue #4987: Trim deleted entries after recover cursor. URL: https://github.com/apache/pulsar/pull/4987#issuecomment-526374186 ping @merlimat This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated: [k8s] convert to valid pod name part with k8s function runtime (#4996)
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new e231d22 [k8s] convert to valid pod name part with k8s function
runtime (#4996)
e231d22 is described below
commit e231d22e5b04266348b5146c869a0b019a71725a
Author: Rui Fu
AuthorDate: Fri Aug 30 05:43:50 2019 +0800
[k8s] convert to valid pod name part with k8s function runtime (#4996)
### Motivation
k8s runtime use tenant, namespace, functionName to create k8s pod name, but
functionName might not meet the k8s pod name rule.
`"[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*"`, which
will cause pod create failed.
### Modifications
This PR create a new function called `toValidPodName` which convert a
string to valid pod name part, including convert to lower case and replace all
non-char part to "-".
---
.../functions/runtime/KubernetesRuntime.java | 17 +++-
.../functions/runtime/KubernetesRuntimeTest.java | 97 ++
2 files changed, 112 insertions(+), 2 deletions(-)
diff --git
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java
index 4f9b77a..a5c6d1a 100644
---
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java
+++
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java
@@ -52,6 +52,7 @@ import io.kubernetes.client.models.V1StatefulSetSpec;
import io.kubernetes.client.models.V1Toleration;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.codec.digest.DigestUtils;
import org.apache.pulsar.functions.auth.KubernetesFunctionAuthProvider;
import org.apache.pulsar.functions.instance.AuthenticationConfig;
import org.apache.pulsar.functions.instance.InstanceConfig;
@@ -1015,14 +1016,26 @@ public class KubernetesRuntime implements Runtime {
return ports;
}
-private static String createJobName(Function.FunctionDetails
functionDetails) {
+public static String createJobName(Function.FunctionDetails
functionDetails) {
return createJobName(functionDetails.getTenant(),
functionDetails.getNamespace(),
functionDetails.getName());
}
+private static String toValidPodName(String ori) {
+return ori.toLowerCase().replaceAll("[^a-z0-9-\\.]", "-");
+}
+
private static String createJobName(String tenant, String namespace,
String functionName) {
-return "pf-" + tenant + "-" + namespace + "-" + functionName;
+final String jobNameContent = String.format("%s-%s-%s", tenant,
namespace,functionName);
+final String jobName = "pf-" + jobNameContent;
+final String convertedJobName = toValidPodName(jobName);
+if (jobName.equals(convertedJobName)) {
+return jobName;
+}
+// toValidPodName may cause naming collisions, add a short hash here
to avoid it
+final String shortHash =
DigestUtils.sha1Hex(jobNameContent).toLowerCase().substring(0, 8);
+return convertedJobName + "-" + shortHash;
}
private static String getServiceUrl(String jobName, String jobNamespace,
int instanceId) {
diff --git
a/pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/KubernetesRuntimeTest.java
b/pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/KubernetesRuntimeTest.java
index e0214b2..812c003 100644
---
a/pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/KubernetesRuntimeTest.java
+++
b/pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/KubernetesRuntimeTest.java
@@ -49,6 +49,7 @@ import static
org.apache.pulsar.functions.utils.FunctionCommon.roundDecimal;
import static org.powermock.api.mockito.PowerMockito.doNothing;
import static org.powermock.api.mockito.PowerMockito.spy;
import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNotEquals;
/**
* Unit test of {@link ThreadRuntime}.
@@ -448,4 +449,100 @@ public class KubernetesRuntimeTest {
assertEquals(containerSpec.getResources().getLimits().get("cpu").getNumber().doubleValue(),
RESOURCES.getCpu());
}
+@Test
+public void testCreateJobName() throws Exception {
+verifyCreateJobNameWithBackwardCompatibility();
+verifyCreateJobNameWithUpperCaseFunctionName();
+verifyCreateJobNameWithDotFunctionName();
+verifyCreateJobNameWithDotAndUpperCaseFunctionName();
+verifyCreateJobNameWithInvalidMarksFunctionName();
+verifyCreateJobNameWithCollisionalFunctionName();
+verifyCreateJobNameWithCollisionalAndIn
[GitHub] [pulsar] sijie merged pull request #4996: [k8s] convert to valid pod name part with k8s function runtime
sijie merged pull request #4996: [k8s] convert to valid pod name part with k8s function runtime URL: https://github.com/apache/pulsar/pull/4996 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated: [doc] Improve Pulsar security-tls-transport (#5027)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 783c4ad [doc] Improve Pulsar security-tls-transport (#5027) 783c4ad is described below commit 783c4ad86877386a39c1c556cb6c42ae9e90f547 Author: Monica-zy <44013755+monica...@users.noreply.github.com> AuthorDate: Fri Aug 30 05:43:05 2019 +0800 [doc] Improve Pulsar security-tls-transport (#5027) ## Motivation Improve the language and the overall descriptive style of the Transport Encryption using TLS document of Security chapter. ## Modifications Adjust the tone, personal pronouns, voice also some typo errors of some sentences in the document. --- site2/docs/security-tls-transport.md | 92 ++-- 1 file changed, 47 insertions(+), 45 deletions(-) diff --git a/site2/docs/security-tls-transport.md b/site2/docs/security-tls-transport.md index 4faba02..ac6d9f2 100644 --- a/site2/docs/security-tls-transport.md +++ b/site2/docs/security-tls-transport.md @@ -4,41 +4,41 @@ title: Transport Encryption using TLS sidebar_label: Transport Encryption using TLS --- -## TLS Overview +## TLS overview -By default, Apache Pulsar clients communicate with the Apache Pulsar service in plain text, which means that all data is sent in the clear. TLS can be used to encrypt this traffic so that it cannot be snooped by a man-in-the-middle attacker. +By default, Apache Pulsar clients communicate with the Apache Pulsar service in plain text. This means that all data is sent in the clear. You can use TLS to encrypt this traffic to protect the traffic from the snooping of a man-in-the-middle attacker. -TLS can be configured for both encryption and authentication. You may configure just TLS transport encryption, which is covered in this guide. TLS authentication is covered [elsewhere](security-tls-authentication.md). Alternatively, you can use [another authentication mechanism](security-athenz.md) on top of TLS transport encryption. +You can also configure TLS for both encryption and authentication. Use this guide to configure just TLS transport encryption and refer to [here](security-tls-authentication.md) for TLS authentication configuration. Alternatively, you can use [another authentication mechanism](security-athenz.md) on top of TLS transport encryption. -> Note that enabling TLS may have a performance impact due to encryption overhead. +> Note that enabling TLS may impact the performance due to encryption overhead. ## TLS concepts -TLS is a form of [public key cryptography](https://en.wikipedia.org/wiki/Public-key_cryptography). Encryption is performed using key pairs consisting of a public key and a private key. Messages are encrypted with the public key and can be decrypted with the private key. +TLS is a form of [public key cryptography](https://en.wikipedia.org/wiki/Public-key_cryptography). Using key pairs consisting of a public key and a private key can perform the encryption. The public key encrpyts the messages and the private key decrypts the messages. To use TLS transport encryption, you need two kinds of key pairs, **server key pairs** and a **certificate authority**. -A third kind of key pair, **client key pairs**, are used for [client authentication](security-tls-authentication.md). +You can use a third kind of key pair, **client key pairs**, for [client authentication](security-tls-authentication.md). -The **certificate authority** private key should be stored in a very secure location (a fully encrypted, disconnected, air gapped computer). The certificate authority public key, the **trust cert**, can be freely shared. +You should store the **certificate authority** private key in a very secure location (a fully encrypted, disconnected, air gapped computer). As for the certificate authority public key, the **trust cert**, you can freely shared it. -For both client and server key pairs, the administrator first generates a private key and a certificate request. Then the certificate authority private key is used to sign the certificate request, generating a certificate. This certificate is the public key for the server/client key pair. +For both client and server key pairs, the administrator first generates a private key and a certificate request, then uses the certificate authority private key to sign the certificate request, finally generates a certificate. This certificate is the public key for the server/client key pair. -For TLS transport encryption, the clients can use the **trust cert** to verify that the server they are talking to has a key pair that was signed by the certificate authority. A man-in-the-middle attacker would not have access to the certificate authority, so they couldn't create a server with such a key pair. +For TLS transp
[GitHub] [pulsar] sijie merged pull request #5027: [doc] Improve Pulsar security-tls-transport
sijie merged pull request #5027: [doc] Improve Pulsar security-tls-transport URL: https://github.com/apache/pulsar/pull/5027 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (6a67ae0 -> d8db529)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 6a67ae0 modify BatcherBuilder interface and it's subs to implement java.io.Serializable (#5068) add d8db529 [website] add OVH in Pulsar users (#5072) No new revisions were added by this update. Summary of changes: site2/website/data/users.js | 5 + 1 file changed, 5 insertions(+)
[GitHub] [pulsar] merlimat merged pull request #5072: [website] add OVH in Pulsar users
merlimat merged pull request #5072: [website] add OVH in Pulsar users URL: https://github.com/apache/pulsar/pull/5072 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5073: java-client: Consumer closed after using seek(timestamp)
merlimat commented on issue #5073: java-client: Consumer closed after using seek(timestamp) URL: https://github.com/apache/pulsar/issues/5073#issuecomment-526310922 To clarify, the current behavior is that the consumer gets disconnected and internally the client library will automatically reconnect. In your test above, the unsubscribe actually happens before the client lib had the chance to reconnect. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5073: java-client: Consumer closed after using seek(timestamp)
merlimat commented on issue #5073: java-client: Consumer closed after using seek(timestamp) URL: https://github.com/apache/pulsar/issues/5073#issuecomment-526310303 @kimcs It happens because there's a brief disconnection during the seek. The disconnect is ultimately not necessary, and it's being removed as part of #5022. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (f7aad57 -> 6a67ae0)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f7aad57 [website]Support multi version for swagger (#5032) add 6a67ae0 modify BatcherBuilder interface and it's subs to implement java.io.Serializable (#5068) No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/pulsar/client/api/BatcherBuilder.java| 4 +++- .../java/org/apache/pulsar/client/impl/DefaultBatcherBuilder.java | 2 ++ .../java/org/apache/pulsar/client/impl/KeyBasedBatcherBuilder.java| 2 ++ 3 files changed, 7 insertions(+), 1 deletion(-)
[GitHub] [pulsar] merlimat merged pull request #5068: modify BatcherBuilder interface and it's subs to implement java.io.Serializable, otherwise java.io.NotSerializableException occurs when we use plu
merlimat merged pull request #5068: modify BatcherBuilder interface and it's subs to implement java.io.Serializable, otherwise java.io.NotSerializableException occurs when we use plusar-flink-connector. URL: https://github.com/apache/pulsar/pull/5068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5074: [Dashboard] Fix incorrect statistics on tenants page
merlimat commented on issue #5074: [Dashboard] Fix incorrect statistics on tenants page URL: https://github.com/apache/pulsar/pull/5074#issuecomment-526275970 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5066: Fix : ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky
merlimat commented on issue #5066: Fix : ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky URL: https://github.com/apache/pulsar/pull/5066#issuecomment-526274975 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat merged pull request #5032: [website]Support multi version for swagger
merlimat merged pull request #5032: [website]Support multi version for swagger URL: https://github.com/apache/pulsar/pull/5032 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat closed issue #3505: REST api documentation not scoped by version
merlimat closed issue #3505: REST api documentation not scoped by version URL: https://github.com/apache/pulsar/issues/3505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (a4cfcd7 -> f7aad57)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a4cfcd7 add different cache flags for size() and toString() (#5040) add f7aad57 [website]Support multi version for swagger (#5032) No new revisions were added by this update. Summary of changes: site2/website/pages/en/admin-rest-api.js | 5 ++--- site2/website/pages/en/functions-rest-api.js | 3 +-- site2/website/pages/en/sink-rest-api.js| 3 +-- site2/website/pages/en/source-rest-api.js | 3 +-- site2/website/static/js/custom.js | 15 +++ site2/website/static/js/getSwaggerByVersion.js | 24 src/gen-swagger.sh | 9 + 7 files changed, 45 insertions(+), 17 deletions(-) create mode 100644 site2/website/static/js/getSwaggerByVersion.js
[GitHub] [pulsar] merlimat commented on issue #5058: [docs] Clarify non-persistent topics guaranties part
merlimat commented on issue #5058: [docs] Clarify non-persistent topics guaranties part URL: https://github.com/apache/pulsar/pull/5058#issuecomment-526274364 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (83365eb -> a4cfcd7)
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 83365eb [website] Added more companies using Pulsar (#5063) add a4cfcd7 add different cache flags for size() and toString() (#5040) No new revisions were added by this update. Summary of changes: .../collections/ConcurrentOpenLongPairRangeSet.java | 20 .../ConcurrentOpenLongPairRangeSetTest.java | 12 2 files changed, 24 insertions(+), 8 deletions(-)
[GitHub] [pulsar] merlimat commented on issue #5072: [website] add OVH in Pulsar users
merlimat commented on issue #5072: [website] add OVH in Pulsar users URL: https://github.com/apache/pulsar/pull/5072#issuecomment-526266916 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rshermanTHG opened a new pull request #5074: [Dashboard] Fix incorrect statistics on tenants page
rshermanTHG opened a new pull request #5074: [Dashboard] Fix incorrect statistics on tenants page URL: https://github.com/apache/pulsar/pull/5074 ### Motivation After adding timestamp to the namespace object this lead to the statistics on the tenants page over counting. The fix currently in place only handles the count of namespaces and topics. ### Modifications Add a filter on timestamp. As a side effect this removes the need for the previous fix attempt (a subquery) and so that was also removed. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): ( no) - The public API: ( no ) - The schema: ( no ) - The default values of configurations: ( no) - The wire protocol: ( no) - The rest endpoints: ( no) - The admin cli options: ( no) - Anything that affects deployment: ( no ) ### Documentation - Does this pull request introduce a new feature? ( no) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] kimcs commented on issue #5073: java-client: Consumer closed after using seek(timestamp)
kimcs commented on issue #5073: java-client: Consumer closed after using seek(timestamp) URL: https://github.com/apache/pulsar/issues/5073#issuecomment-526216816 I tested using released version 2.4.0 of pulsar only. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] kimcs opened a new issue #5073: java-client: Consumer closed after using seek(timestamp)
kimcs opened a new issue #5073: java-client: Consumer closed after using
seek(timestamp)
URL: https://github.com/apache/pulsar/issues/5073
**Describe the bug**
Consumer is closed after a seek(timestamp) operation.
**To Reproduce**
```java
package sample;
import org.apache.pulsar.client.admin.PulsarAdmin;
import org.apache.pulsar.client.admin.PulsarAdminException;
import org.apache.pulsar.client.api.Consumer;
import org.apache.pulsar.client.api.MessageId;
import org.apache.pulsar.client.api.Producer;
import org.apache.pulsar.client.api.PulsarClient;
import org.apache.pulsar.client.api.PulsarClientException;
import org.apache.pulsar.client.impl.auth.AuthenticationDisabled;
import org.apache.pulsar.client.impl.conf.ClientConfigurationData;
import org.testng.annotations.Test;
import java.util.List;
public class SeekTimestampTest {
static final String topic =
"public/default/seek-test-timestamp-magic-h509db3";
void deleteTopic(String topic) throws PulsarClientException {
ClientConfigurationData config = new ClientConfigurationData();
config.setAuthentication(new AuthenticationDisabled());
config.setServiceUrl("http://localhost:8080";);
try (PulsarAdmin admin = new PulsarAdmin("http://localhost:8080";,
config)) {
List topics =
admin.namespaces().getTopics("public/default");
for (String topicName : topics) {
if (topicName.contains(topic)) {
admin.topics().delete(topic);
break;
}
}
} catch (PulsarAdminException e) {
throw new RuntimeException(e);
}
}
void produceMessages(PulsarClient client, int n) throws
PulsarClientException {
try (Producer producer =
client.newProducer().topic(topic).create()) {
for (int i = 0; i < n; i++) {
MessageId messageId = producer.send(new byte[]{(byte) (1 +
i)});
System.out.printf("Produced message: %s%n", messageId);
}
}
}
@Test
public void thatSeekTimestampDoesNotCloseConsumer() throws
PulsarClientException, InterruptedException {
deleteTopic(topic);
try (PulsarClient client =
PulsarClient.builder().serviceUrl("pulsar://localhost:6650").build()) {
try (Consumer consumer =
client.newConsumer().topic(topic).subscriptionName("sub1").subscribe()) {
try {
long someTimestamp = System.currentTimeMillis();
produceMessages(client, 10);
consumer.seek(someTimestamp);
} finally {
consumer.unsubscribe(); // FAILS with "Not connected to
broker"
}
}
}
}
}
```
**Expected behavior**
That seek(timestamp) should never close the consumer.
**Additional context**
In attempting to reproduce this bug I have also seen the consumer fail
before calling unsubscribe on it, e.g. when calling receive on it, but that was
harder to reproduce consistently.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #4727: libpulsar for osx is not updated to v2.4.0
merlimat commented on issue #4727: libpulsar for osx is not updated to v2.4.0 URL: https://github.com/apache/pulsar/issues/4727#issuecomment-526186280 It’s now available on home brew This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat closed issue #4727: libpulsar for osx is not updated to v2.4.0
merlimat closed issue #4727: libpulsar for osx is not updated to v2.4.0 URL: https://github.com/apache/pulsar/issues/4727 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] freeznet commented on issue #4996: [k8s] convert to valid pod name part with k8s function runtime
freeznet commented on issue #4996: [k8s] convert to valid pod name part with k8s function runtime URL: https://github.com/apache/pulsar/pull/4996#issuecomment-526181081 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] StevenLeRoux opened a new pull request #5072: [website] add OVH in Pulsar users
StevenLeRoux opened a new pull request #5072: [website] add OVH in Pulsar users URL: https://github.com/apache/pulsar/pull/5072 Self described This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet edited a comment on issue #5041: [doc]Add document for debug connector
Anonymitaet edited a comment on issue #5041: [doc]Add document for debug connector URL: https://github.com/apache/pulsar/pull/5041#issuecomment-525724635 The issue of Updating Connector Guide: https://github.com/apache/pulsar/issues/5015#event-2577499721 I've updated the guide based on the following structure:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet edited a comment on issue #5041: [doc]Add document for debug connector
Anonymitaet edited a comment on issue #5041: [doc]Add document for debug connector URL: https://github.com/apache/pulsar/pull/5041#issuecomment-525724635 Update Connector Guide Issue: https://github.com/apache/pulsar/issues/5015#event-2577499721 I've updated the guide based on the following structure:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide
Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide URL: https://github.com/apache/pulsar/issues/5015#issuecomment-524149120 PRs related to this issue: * Add [Connector Admin CLI Guide](https://github.com/apache/pulsar/pull/5028) * Add [How to Use Connectors Guide](https://github.com/apache/pulsar/pull/5071) * Add [How to Debug Connectors Guide](https://github.com/apache/pulsar/pull/5041) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide
Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide URL: https://github.com/apache/pulsar/issues/5015#issuecomment-524149120 PRs related to this issue: * Add [Connector Admin CLI Guide](https://github.com/apache/pulsar/pull/5028) * Add [How to Use Connectors Guide](https://github.com/apache/pulsar/pull/5071) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet opened a new pull request #5071: [Doc]Add *How to Use Pulsar Connectors* Guide
Anonymitaet opened a new pull request #5071: [Doc]Add *How to Use Pulsar Connectors* Guide URL: https://github.com/apache/pulsar/pull/5071 @tuteng could you please help review? Many thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fxbing commented on issue #5066: Fix : ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky
fxbing commented on issue #5066: Fix : ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky URL: https://github.com/apache/pulsar/pull/5066#issuecomment-526149538 run cpp tests run integration tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy opened a new pull request #5070: [doc] Improve Pulsar security authorization
Monica-zy opened a new pull request #5070: [doc] Improve Pulsar security authorization URL: https://github.com/apache/pulsar/pull/5070 Motivation Improve the language and the overall descriptive style of the Pulsar Security document (security authorization section): http://pulsar.apache.org/docs/en/next/security-authorization/ Modifications Adjust the tone, personal pronouns, voice also some typo errors of some sentences in the document. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5052: [doc] Improve Pulsar Security-token-admin
Monica-zy commented on issue #5052: [doc] Improve Pulsar Security-token-admin URL: https://github.com/apache/pulsar/pull/5052#issuecomment-526122413 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5027: [doc] Improve Pulsar security-tls-transport
Monica-zy commented on issue #5027: [doc] Improve Pulsar security-tls-transport URL: https://github.com/apache/pulsar/pull/5027#issuecomment-526122329 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy commented on issue #5069: [doc] Improve Pulsar Security Kerberos
Monica-zy commented on issue #5069: [doc] Improve Pulsar Security Kerberos URL: https://github.com/apache/pulsar/pull/5069#issuecomment-526121992 @Jennifer88huang Please review, thank you~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Monica-zy opened a new pull request #5069: [doc] Improve Pulsar Security Kerberos
Monica-zy opened a new pull request #5069: [doc] Improve Pulsar Security Kerberos URL: https://github.com/apache/pulsar/pull/5069 Motivation Improve the language and the overall descriptive style of the Pulsar Security document ( Security-kerberos section): http://pulsar.apache.org/docs/en/next/security-kerberos/ Modifications Adjust the tone, personal pronouns, voice also some typo errors of some sentences in the document. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] double-bin opened a new pull request #5068: modify BatcherBuilder interface and it's subs to implement java.io.Serializable, otherwise java.io.NotSerializableException occurs when we
double-bin opened a new pull request #5068: modify BatcherBuilder interface and it's subs to implement java.io.Serializable, otherwise java.io.NotSerializableException occurs when we use plusar-flink-connector. URL: https://github.com/apache/pulsar/pull/5068 modify BatcherBuilder interface and it's subs to implement java.io.Serializable, otherwise java.io.NotSerializableException occurs when we use plusar-flink-connector. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] ivankelly commented on a change in pull request #3784: Pulsar-IO: Added Kinesis Source Connector
ivankelly commented on a change in pull request #3784: Pulsar-IO: Added Kinesis Source Connector URL: https://github.com/apache/pulsar/pull/3784#discussion_r318960570 ## File path: pulsar-io/kinesis/src/main/java/org/apache/pulsar/io/kinesis/BaseKinesisConfig.java ## @@ -38,7 +37,7 @@ private String awsEndpoint; @FieldDoc( -required = true, +required = false, Review comment: it should be either/or for this and endpoint. if region is set, you should be able to leave endpoint blank This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie opened a new pull request #5067: [bookkeeper] Don't return DEFAULT_RACK if ZkBookieRackAffinityMapping can't resolve network location
sijie opened a new pull request #5067: [bookkeeper] Don't return DEFAULT_RACK if ZkBookieRackAffinityMapping can't resolve network location URL: https://github.com/apache/pulsar/pull/5067 *Motivation* Different placement policy has different default rack information. For example, the default rack for `RackAware` is `/default-rack` and the default rack for `RegionAware` is `/default-region/default-rack`. If we return the wrong default rack, it can potentially cause inconsistent network locations inserted to the network topology and causing the following errors. ``` 15:36:30.083 [BookKeeperClientScheduler-OrderedScheduler-0-0] ERROR org.apache.bookkeeper.net.NetworkTopologyImpl - Error: can't add leaf node at depth 2 to topology: Number of racks: 1 Expected number of leaves:1 /sh/rack1/1.1.1.1:3181 15:36:30.083 [BookKeeperClientScheduler-OrderedScheduler-0-0] ERROR org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl - Unexpected exception while handling joining bookie 1.1.1.2:3181 org.apache.bookkeeper.net.NetworkTopologyImpl$InvalidTopologyException: Invalid network topology. You cannot have a rack and a non-rack node at the same level of the network topology. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] freeznet commented on issue #4996: [k8s] convert to valid pod name part with k8s function runtime
freeznet commented on issue #4996: [k8s] convert to valid pod name part with k8s function runtime URL: https://github.com/apache/pulsar/pull/4996#issuecomment-526079431 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] freeznet removed a comment on issue #4996: [k8s] convert to valid pod name part with k8s function runtime
freeznet removed a comment on issue #4996: [k8s] convert to valid pod name part with k8s function runtime URL: https://github.com/apache/pulsar/pull/4996#issuecomment-525991453 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fxbing opened a new pull request #5066: Fix : ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky
fxbing opened a new pull request #5066: Fix : ConsumerStatsTest.testAsyncCallOnPartitionedTopic is flaky URL: https://github.com/apache/pulsar/pull/5066 fix #4894 ### Motivation Due to the concurrent execution of the program, when checking whether the ‘BrokerConsumerStats’'s cache is in effect, there is no guarantee that the cache time will not be exceeded. ### Modifications - Check the cache in an inexact way. - Increase waiting time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Muyoo opened a new issue #5065: "Connection is already closed" when creating a Producer
Muyoo opened a new issue #5065: "Connection is already closed" when creating a
Producer
URL: https://github.com/apache/pulsar/issues/5065
After I set up a Pulsar in standalone on MacOS, I get an exception
`Connection is already closed` when I create a Producer:
```
15:53:56.739 [pulsar-client-io-1-1] INFO
org.apache.pulsar.client.impl.ClientCnx - [id: 0x3fab3a4b, L:/127.0.0.1:60316 !
R:/127.0.0.1:6650] Disconnected
15:53:56.742 [pulsar-client-io-1-1] WARN
org.apache.pulsar.client.impl.ConnectionPool - [[id: 0x3fab3a4b,
L:/127.0.0.1:60316 ! R:/127.0.0.1:6650]] Connection handshake failed:
org.apache.pulsar.client.api.PulsarClientException: Connection already closed
15:53:56.742 [pulsar-client-io-1-1] WARN
org.apache.pulsar.client.impl.PulsarClientImpl -
[persistent://public/default/wyq-test] Failed to get partitioned topic
metadata: org.apache.pulsar.client.api.PulsarClientException: Connection
already closed
Exception in thread "main"
org.apache.pulsar.client.api.PulsarClientException:
java.util.concurrent.ExecutionException:
org.apache.pulsar.client.api.PulsarClientException: Connection already closed
at
org.apache.pulsar.client.api.PulsarClientException.unwrap(PulsarClientException.java:297)
at
org.apache.pulsar.client.impl.ProducerBuilderImpl.create(ProducerBuilderImpl.java:88)
at
org.xmuyoo.blueberry.crawling.streams.Publisher.main(Publisher.java:108)
Caused by: java.util.concurrent.ExecutionException:
org.apache.pulsar.client.api.PulsarClientException: Connection already closed
at
java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
at
java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895)
at
org.apache.pulsar.client.impl.ProducerBuilderImpl.create(ProducerBuilderImpl.java:86)
... 1 more
Caused by: org.apache.pulsar.client.api.PulsarClientException: Connection
already closed
at
org.apache.pulsar.client.impl.ClientCnx.channelInactive(ClientCnx.java:220)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
at
org.apache.pulsar.shade.io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:390)
at
org.apache.pulsar.shade.io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:355)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
at
org.apache.pulsar.shade.io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1429)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
at
org.apache.pulsar.shade.io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:947)
at
org.apache.pulsar.shade.io.netty.channel.AbstractChannel$AbstractUnsafe$8.run(AbstractChannel.java:826)
at
org.apache.pulsar.shade.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
at
org.apache.pulsar.shade.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
at
org.apache.pulsar.shade.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:474)
at
org.apache.pulsar.shade.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:909)
at
org.apache.pulsar.shade.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:748)
```
And I run Pulsar in Docker(18.09.2) with the command in the document:
```
$ docker run -it \
-p 6650:6650 \
-p 8080:8080 \
-v $PWD/data:/pulsar/data \
apachepulsar/pulsar:2.4.0 \
bin/pulsar standalone
```
There is no ERROR in the log messages.
And my code is here:
```Java
public static void main(String[] args) throws Exception {
PulsarClient client = PulsarClient.builder()
.serviceUrl("pulsar://127.0.0.1:665
[GitHub] [pulsar] Monica-zy commented on issue #5038: [doc] Improve Pulsar security-tls-authentication
Monica-zy commented on issue #5038: [doc] Improve Pulsar security-tls-authentication URL: https://github.com/apache/pulsar/pull/5038#issuecomment-526055184 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
