[GitHub] [pulsar] codecov-commenter commented on pull request #20276: [fix][ml] Fix ledger left in OPEN state when enable `inactiveLedgerRollOverTimeMs`
codecov-commenter commented on PR #20276: URL: https://github.com/apache/pulsar/pull/20276#issuecomment-1547224184 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20276?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging [#20276](https://app.codecov.io/gh/apache/pulsar/pull/20276?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (1e2f55c) into [master](https://app.codecov.io/gh/apache/pulsar/commit/00f17e88ad8fa9a4ead78d78a181c03fdee8e4df?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (00f17e8) will **increase** coverage by `35.32%`. > The diff coverage is `27.27%`. [](https://app.codecov.io/gh/apache/pulsar/pull/20276?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) ```diff @@ Coverage Diff @@ ## master #20276 +/- ## = + Coverage 37.61% 72.93% +35.32% - Complexity1258931948+19359 = Files 1691 1868 +177 Lines129028 138617 +9589 Branches 1406615244 +1178 = + Hits 48530 101104+52574 + Misses7418329461-44722 - Partials 6315 8052 +1737 ``` | Flag | Coverage Δ | | |---|---|---| | inttests | `24.15% <4.54%> (-0.02%)` | :arrow_down: | | systests | `24.94% <4.54%> (+0.16%)` | :arrow_up: | | unittests | `72.20% <27.27%> (+39.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20276?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [...org/apache/pulsar/broker/ServiceConfiguration.java](https://app.codecov.io/gh/apache/pulsar/pull/20276?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvU2VydmljZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `99.37% <ø> (+1.34%)` | :arrow_up: | | [.../apache/pulsar/io/jdbc/BaseJdbcAutoSchemaSink.java](https://app.codecov.io/gh/apache/pulsar/pull/20276?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cHVsc2FyLWlvL2pkYmMvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2lvL2pkYmMvQmFzZUpkYmNBdXRvU2NoZW1hU2luay5qYXZh) | `72.85% <0.00%> (+72.85%)` | :arrow_up: | | [...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/20276?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRMZWRnZXJJbXBsLmphdmE=) | `81.72% <27.77%> (+29.44%)` | :arrow_up: | | [.../apache/bookkeeper/mledger/impl/MetaStoreImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/20276?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01ldGFTdG9yZUltcGwuamF2YQ==) | `85.21% <100.00%> (+43.30%)` | :arrow_up: | ... and [1426 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20276/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #20323: [fix][test] Pinned bookie-client version in branch-2.10
github-actions[bot] commented on PR #20323: URL: https://github.com/apache/pulsar/pull/20323#issuecomment-1547150848 @zymap Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] zymap opened a new pull request, #20323: [fix][test] Pinned bookie-client version in branch-2.10
zymap opened a new pull request, #20323: URL: https://github.com/apache/pulsar/pull/20323 Fixes #20314 ### Motivation Use the fixed version of bookie-client to avoid some break changes. ### Modifications ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar] branch branch-2.11 updated: [fix][broker] Fix default bundle size used while setting bookie affinity (#20250)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.11 by this push:
new a6ed1cc45e5 [fix][broker] Fix default bundle size used while setting
bookie affinity (#20250)
a6ed1cc45e5 is described below
commit a6ed1cc45e5c71180f2c565ca1100e83c43b0d0c
Author: Raghavender Mittapalli <14803749+syk-co...@users.noreply.github.com>
AuthorDate: Wed May 10 18:05:17 2023 +0530
[fix][broker] Fix default bundle size used while setting bookie affinity
(#20250)
---
.../main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java | 2 +-
.../org/apache/pulsar/broker/service/BrokerBookieIsolationTest.java | 4
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
index f76e8a02827..610b799fba6 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
@@ -1099,7 +1099,7 @@ public abstract class NamespacesBase extends
AdminResource {
policies -> new LocalPolicies(policies.bundles,
bookieAffinityGroup,
policies.namespaceAntiAffinityGroup))
-.orElseGet(() -> new LocalPolicies(defaultBundle(),
+.orElseGet(() -> new
LocalPolicies(getBundles(config().getDefaultNumberOfNamespaceBundles()),
bookieAffinityGroup,
null));
log.info("[{}] Successfully updated local-policies
configuration: namespace={}, map={}", clientAppId(),
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerBookieIsolationTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerBookieIsolationTest.java
index e575154a743..accf8361824 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerBookieIsolationTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerBookieIsolationTest.java
@@ -154,6 +154,7 @@ public class BrokerBookieIsolationTest {
config.setBrokerServicePort(Optional.of(0));
config.setAdvertisedAddress("localhost");
config.setBookkeeperClientIsolationGroups(brokerBookkeeperClientIsolationGroups);
+config.setDefaultNumberOfNamespaceBundles(8);
config.setManagedLedgerDefaultEnsembleSize(2);
config.setManagedLedgerDefaultWriteQuorum(2);
@@ -205,6 +206,9 @@ public class BrokerBookieIsolationTest {
.bookkeeperAffinityGroupPrimary(tenantNamespaceIsolationGroups)
.build());
+//Checks the namespace bundles after setting the bookie affinity
+assertEquals(admin.namespaces().getBundles(ns2).getNumBundles(),
config.getDefaultNumberOfNamespaceBundles());
+
try {
admin.namespaces().getBookieAffinityGroup(ns1);
fail("ns1 should have no bookie affinity group set");
[GitHub] [pulsar] KMoonSC edited a discussion: How to get properties in org.apache.pulsar.broker.intercept.BrokerInterceptor#beforeSendMessage ?
GitHub user KMoonSC edited a discussion: How to get properties in
org.apache.pulsar.broker.intercept.BrokerInterceptor#beforeSendMessage ?
### Version
2.7.1
### What do you want ?
i want to log some information in Broker before messages send to consumer
### What have you done？
i use BrokerInterceptor to do so
here's my BrokerInterceptor:
```
public class LogBrokerInterceptor implements BrokerInterceptor {
private static final Logger logger =
LoggerFactory.getLogger(LogBrokerInterceptor.class);
@Override
public void beforeSendMessage(Subscription subscription, Entry entry,
long[] ackSet, PulsarApi.MessageMetadata msgMetadata) {
List properties = msgMetadata.getPropertiesList();
for (PulsarApi.KeyValue keyValue : properties) {
logger.info("LogBrokerInterceptor beforeSendMessage. properties
key:{} value:{}", keyValue.getKey(), keyValue.getValue());
}
logger.info("LogBrokerInterceptor beforeSendMessage. topic:{}
subscription:{} sequenceId:{} propertiesSize:{}", subscription.getTopic(),
subscription.getName(), msgMetadata.getSequenceId(), properties.size());
}
```
and here's my produce test:
```
PulsarClient client = PulsarClient.builder()
.serviceUrl("pulsar://localhost:6650")
.build();
Producer producer = client.newProducer()
.topic("public/default/my-topic")
.create();
Map properties = new HashMap<>();
properties.put("clientId", "clientId123");
producer.newMessage()
.properties(properties)
.value("data1234".getBytes())
.send();
```
### What did you expect to see?
the properties i settled wound be logged like this:
"LogBrokerInterceptor beforeSendMessage. properties key:clientId
value:clientId123"
### What did you see instead?
there's no such log, but this;
"LogBrokerInterceptor beforeSendMessage. topic:xxx subscription:xxx
sequenceId:xxx propertiesSize:0"
shows that there is no properties in msgMetadata
### Q
so here is the Question:
Am I using the wrong way to get the properties I set to the message ?
If so, how to make it right?
GitHub link: https://github.com/apache/pulsar/discussions/20322
This is an automatically sent email for commits@pulsar.apache.org.
To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar] KMoonSC edited a discussion: How to get properties in org.apache.pulsar.broker.intercept.BrokerInterceptor#beforeSendMessage ?
GitHub user KMoonSC edited a discussion: How to get properties in
org.apache.pulsar.broker.intercept.BrokerInterceptor#beforeSendMessage ?
### Version
2.7.1
### What do you want ?
i want to log some information in Broker before messages send to consumer
### What have you done？
i use BrokerInterceptor to do so
here's my BrokerInterceptor:
`
public class LogBrokerInterceptor implements BrokerInterceptor {
private static final Logger logger =
LoggerFactory.getLogger(LogBrokerInterceptor.class);
@Override
public void beforeSendMessage(Subscription subscription, Entry entry,
long[] ackSet, PulsarApi.MessageMetadata msgMetadata) {
List properties = msgMetadata.getPropertiesList();
for (PulsarApi.KeyValue keyValue : properties) {
logger.info("LogBrokerInterceptor beforeSendMessage. properties
key:{} value:{}", keyValue.getKey(), keyValue.getValue());
}
logger.info("LogBrokerInterceptor beforeSendMessage. topic:{}
subscription:{} sequenceId:{} propertiesSize:{}", subscription.getTopic(),
subscription.getName(), msgMetadata.getSequenceId(), properties.size());
}
`
and here's my produce test:
`
PulsarClient client = PulsarClient.builder()
.serviceUrl("pulsar://localhost:6650")
.build();
Producer producer = client.newProducer()
.topic("public/default/my-topic")
.create();
Map properties = new HashMap<>();
properties.put("clientId", "clientId123");
producer.newMessage()
.properties(properties)
.value("data1234".getBytes())
.send();
`
### What did you expect to see?
the properties i settled wound be logged like this:
"LogBrokerInterceptor beforeSendMessage. properties key:clientId
value:clientId123"
### What did you see instead?
there's no such log, but this;
"LogBrokerInterceptor beforeSendMessage. topic:xxx subscription:xxx
sequenceId:xxx propertiesSize:0"
shows that there is no properties in msgMetadata
### Q
so here is the Question:
Am I using the wrong way to get the properties I set to the message ?
If so, how to make it right?
GitHub link: https://github.com/apache/pulsar/discussions/20322
This is an automatically sent email for commits@pulsar.apache.org.
To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar] KMoonSC edited a discussion: How to get properties in org.apache.pulsar.broker.intercept.BrokerInterceptor#beforeSendMessage ?
GitHub user KMoonSC edited a discussion: How to get properties in
org.apache.pulsar.broker.intercept.BrokerInterceptor#beforeSendMessage ?
### Version
2.7.1
### What do you want ?
i want to log some information in Broker before messages send to consumer
### What have you done？
i use BrokerInterceptor to do so
here's my BrokerInterceptor:
``
public class LogBrokerInterceptor implements BrokerInterceptor {
private static final Logger logger =
LoggerFactory.getLogger(LogBrokerInterceptor.class);
@Override
public void beforeSendMessage(Subscription subscription, Entry entry,
long[] ackSet, PulsarApi.MessageMetadata msgMetadata) {
List properties = msgMetadata.getPropertiesList();
for (PulsarApi.KeyValue keyValue : properties) {
logger.info("LogBrokerInterceptor beforeSendMessage. properties
key:{} value:{}", keyValue.getKey(), keyValue.getValue());
}
logger.info("LogBrokerInterceptor beforeSendMessage. topic:{}
subscription:{} sequenceId:{} propertiesSize:{}", subscription.getTopic(),
subscription.getName(), msgMetadata.getSequenceId(), properties.size());
}
``
and here's my produce test:
`
PulsarClient client = PulsarClient.builder()
.serviceUrl("pulsar://localhost:6650")
.build();
Producer producer = client.newProducer()
.topic("public/default/my-topic")
.create();
Map properties = new HashMap<>();
properties.put("clientId", "clientId123");
producer.newMessage()
.properties(properties)
.value("data1234".getBytes())
.send();
`
### What did you expect to see?
the properties i settled wound be logged like this:
"LogBrokerInterceptor beforeSendMessage. properties key:clientId
value:clientId123"
### What did you see instead?
there's no such log, but this;
"LogBrokerInterceptor beforeSendMessage. topic:xxx subscription:xxx
sequenceId:xxx propertiesSize:0"
shows that there is no properties in msgMetadata
### Q
so here is the Question:
Am I using the wrong way to get the properties I set to the message ?
If so, how to make it right?
GitHub link: https://github.com/apache/pulsar/discussions/20322
This is an automatically sent email for commits@pulsar.apache.org.
To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar] KMoonSC edited a discussion: How to get properties in org.apache.pulsar.broker.intercept.BrokerInterceptor#beforeSendMessage ?
GitHub user KMoonSC edited a discussion: How to get properties in
org.apache.pulsar.broker.intercept.BrokerInterceptor#beforeSendMessage ?
### Version
2.7.1
### What do you want ?
i want to log some information in Broker before messages send to consumer
### What have you done？
i use BrokerInterceptor to do so
here's my BrokerInterceptor:
`
public class LogBrokerInterceptor implements BrokerInterceptor {
private static final Logger logger =
LoggerFactory.getLogger(LogBrokerInterceptor.class);
@Override
public void beforeSendMessage(Subscription subscription, Entry entry,
long[] ackSet, PulsarApi.MessageMetadata msgMetadata) {
List properties = msgMetadata.getPropertiesList();
for (PulsarApi.KeyValue keyValue : properties) {
logger.info("LogBrokerInterceptor beforeSendMessage. properties
key:{} value:{}", keyValue.getKey(), keyValue.getValue());
}
logger.info("LogBrokerInterceptor beforeSendMessage. topic:{}
subscription:{} sequenceId:{} propertiesSize:{}", subscription.getTopic(),
subscription.getName(), msgMetadata.getSequenceId(), properties.size());
}
`
and here's my produce test:
`
PulsarClient client = PulsarClient.builder()
.serviceUrl("pulsar://localhost:6650")
.build();
Producer producer = client.newProducer()
.topic("public/default/my-topic")
.create();
Map properties = new HashMap<>();
properties.put("clientId", "clientId123");
producer.newMessage()
.properties(properties)
.value("data1234".getBytes())
.send();
`
### What did you expect to see?
the properties i settled wound be logged like this:
"LogBrokerInterceptor beforeSendMessage. properties key:clientId
value:clientId123"
### What did you see instead?
there's no such log, but this;
"LogBrokerInterceptor beforeSendMessage. topic:xxx subscription:xxx
sequenceId:xxx propertiesSize:0"
shows that there is no properties in msgMetadata
### Q
so here is the Question:
Am I using the wrong way to get the properties I set to the message ?
If so, how to make it right?
GitHub link: https://github.com/apache/pulsar/discussions/20322
This is an automatically sent email for commits@pulsar.apache.org.
To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #20321: [fix][client] thread-safe seek
Technoboy- commented on code in PR #20321:
URL: https://github.com/apache/pulsar/pull/20321#discussion_r1193290156
##
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##
@@ -2164,7 +2161,7 @@ private CompletableFuture seekAsyncInternal(long
requestId, ByteBuf seek,
if (!duringSeek.compareAndSet(false, true)) {
log.warn("[{}][{}] Attempting to seek operation that is already in
progress, cancelling {}",
topic, subscription, seekBy);
-seekFuture.cancel(true);
+seekFuture.completeExceptionally(new IllegalStateException());
Review Comment:
`new IllegalStateException()` -> `new
IllegalStateException("String.format("%s,%s attempting to seek operation that
is already in progress", topic, subscription))` may be better ?
@michaeljmarshall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] zymap commented on issue #20314: Python tests are broken in branch-2.10
zymap commented on issue #20314: URL: https://github.com/apache/pulsar/issues/20314#issuecomment-1547131659 @lhotari We are fetching the latest bookkeeper in the python tests. ``` Collecting apache-bookkeeper-client>=4.9.2; extra == "all" Downloading apache_bookkeeper_client-4.16.1-py2.py3-none-any.whl (62 kB) ``` We replaced the python collections to collections.abc in https://github.com/apache/bookkeeper/pull/3875 and released in 4.16. So it breaks the python test. In Pulsar, we need to use a fixed bookkeeper version to avoid getting the latest version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun opened a new pull request, #20321: Fix seek async another way
tisonkun opened a new pull request, #20321: URL: https://github.com/apache/pulsar/pull/20321 This is a follow-up for https://github.com/apache/pulsar/pull/20242. Please review in commits. ### Motivation ### Modifications ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1
tisonkun commented on PR #20242: URL: https://github.com/apache/pulsar/pull/20242#issuecomment-1547105417 @Technoboy- Thanks for setting up the milestone. > not related to the issue Yep. I'm investigating some tools to unify whitespace so that we don't ask for aligning again and again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1
Technoboy- commented on PR #20242: URL: https://github.com/apache/pulsar/pull/20242#issuecomment-1547101579 @tisonkun For this patch, maybe you forget to set the milestone. and there are some modifications not related to the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #18895: [Bug] NoClassDefFoundError BlobStoreBackedReadHandleImpl
github-actions[bot] commented on issue #18895: URL: https://github.com/apache/pulsar/issues/18895#issuecomment-1547086613 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #19456: Flaky-test: MetadataStoreStatsTest.testMetadataStoreStats
github-actions[bot] commented on issue #19456: URL: https://github.com/apache/pulsar/issues/19456#issuecomment-1547085973 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19461: [improve][authorization] Uniformly use allowTopicOperationAsync to check permissions
github-actions[bot] commented on PR #19461: URL: https://github.com/apache/pulsar/pull/19461#issuecomment-1547085924 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19821: [wip][feat][io] Debezium DB2 source connector for Pulsar
github-actions[bot] commented on PR #19821: URL: https://github.com/apache/pulsar/pull/19821#issuecomment-1547085367 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #20022: [Bug] Pulsar Client ignores producer schema
github-actions[bot] commented on issue #20022: URL: https://github.com/apache/pulsar/issues/20022#issuecomment-1547085195 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #20094: [Bug] Topic ledger id will rollback in some cases
github-actions[bot] commented on issue #20094: URL: https://github.com/apache/pulsar/issues/20094#issuecomment-1547085115 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #20099: [Bug] Delayed message delivery receive duplicate messages when unload topic
github-actions[bot] commented on issue #20099: URL: https://github.com/apache/pulsar/issues/20099#issuecomment-1547085094 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #20104: [fix][schema] Apply Schema for GenericJsonRecord if present
github-actions[bot] commented on PR #20104: URL: https://github.com/apache/pulsar/pull/20104#issuecomment-1547085064 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #20107: Support invalidating client's OAuth2 token after receiving an authentication exception
github-actions[bot] commented on issue #20107: URL: https://github.com/apache/pulsar/issues/20107#issuecomment-1547085048 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #20303: [fix] [meta]Switch to the metadata store thread after zk operation
nodece commented on code in PR #20303:
URL: https://github.com/apache/pulsar/pull/20303#discussion_r1193253530
##
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreTest.java:
##
@@ -425,6 +428,75 @@ public void testDeleteUnusedDirectories(String provider,
Supplier urlSup
assertFalse(store.exists(prefix).join());
}
+@DataProvider(name = "conditionOfSwitchThread")
+public Object[][] conditionOfSwitchThread(){
+return new Object[][]{
+{false, false},
+{false, true},
+{true, false},
+{true, true}
+};
+}
+
+@Test(dataProvider = "conditionOfSwitchThread")
+public void testThreadSwitchOfZkMetadataStore(boolean hasSynchronizer,
boolean enabledBatch) throws Exception {
+final String prefix = newKey();
+final String metadataStoreName =
UUID.randomUUID().toString().replaceAll("-", "");
+MetadataStoreConfig.MetadataStoreConfigBuilder builder =
+
MetadataStoreConfig.builder().metadataStoreName(metadataStoreName);
+builder.fsyncEnable(false);
+builder.batchingEnabled(enabledBatch);
+if (!hasSynchronizer) {
+builder.synchronizer(null);
+}
+MetadataStoreConfig config = builder.build();
+@Cleanup
+ZKMetadataStore store = (ZKMetadataStore)
MetadataStoreFactory.create(zks.getConnectionString(), config);
+
+final Runnable verify = () -> {
+String currentThreadName = Thread.currentThread().getName();
+String errorMessage = String.format("Expect to switch to thread
%s, but currently it is thread %s",
+metadataStoreName, currentThreadName);
+if
(!Thread.currentThread().getName().startsWith(metadataStoreName)){
Review Comment:
Did you forget to push for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[pulsar-site] branch main updated: Add client memory limits docs. (#571)
This is an automated email from the ASF dual-hosted git repository.
liuyu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new c6e20d6bed4 Add client memory limits docs. (#571)
c6e20d6bed4 is described below
commit c6e20d6bed4b53907cbe2028d94bdec362486fd1
Author: Baodi Shi
AuthorDate: Mon May 15 08:51:12 2023 +0800
Add client memory limits docs. (#571)
---
docs/client-libraries-clients.md | 32 ++
.../version-3.0.x/client-libraries-clients.md | 32 ++
2 files changed, 64 insertions(+)
diff --git a/docs/client-libraries-clients.md b/docs/client-libraries-clients.md
index c898b13ff42..cdb3be05a6c 100644
--- a/docs/client-libraries-clients.md
+++ b/docs/client-libraries-clients.md
@@ -51,4 +51,36 @@ The following example creates a Python client using multiple
advertised listener
+
+
+## Set memory limits
+
+You can use memory limits parameters to control the total client memory usage,
+the producers and consumers under this client will compete for the memory
assigned. For implementation details, see [PIP 74: Pulsar client memory
limits](https://github.com/apache/pulsar/wiki/PIP-74%3A-Pulsar-client-memory-limits).
+
+mdx-code-block
+
+
+
+ ```java
+ PulsarClient client = PulsarClient.builder()
+ .serviceUrl("pulsar://:6650")
+ .memoryLimit(64, SizeUnit.MEGA_BYTES)
+ .build();
+ ```
+
+
+
+
+ ```go
+ client, err := pulsar.NewClient(pulsar.ClientOptions{
+URL: "pulsar://:6650",
+MemoryLimitBytes: 64 * 1024 * 1024, // Unit: byte
+ })
+ ```
+
+
+
\ No newline at end of file
diff --git a/versioned_docs/version-3.0.x/client-libraries-clients.md
b/versioned_docs/version-3.0.x/client-libraries-clients.md
index c898b13ff42..83a95290f19 100644
--- a/versioned_docs/version-3.0.x/client-libraries-clients.md
+++ b/versioned_docs/version-3.0.x/client-libraries-clients.md
@@ -51,4 +51,36 @@ The following example creates a Python client using multiple
advertised listener
+
+
+## Set memory limits
+
+You can uses memory limits param to control client overall memory usage,
+the producers and consumers under this client will compete for the memory
assigned. See [PIP 74: Pulsar client memory
limits](https://github.com/apache/pulsar/wiki/PIP-74%3A-Pulsar-client-memory-limits)
+
+mdx-code-block
+
+
+
+ ```java
+ PulsarClient client = PulsarClient.builder()
+ .serviceUrl("pulsar://:6650")
+ .memoryLimit(64, SizeUnit.MEGA_BYTES)
+ .build();
+ ```
+
+
+
+
+ ```go
+ client, err := pulsar.NewClient(pulsar.ClientOptions{
+URL: "pulsar://:6650",
+MemoryLimitBytes: 64 * 1024 * 1024, // Unit: byte
+ })
+ ```
+
+
+
\ No newline at end of file
[GitHub] [pulsar-site] Anonymitaet merged pull request #571: Add client memory limits docs.
Anonymitaet merged PR #571: URL: https://github.com/apache/pulsar-site/pull/571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #571: Add client memory limits docs.
Anonymitaet commented on PR #571: URL: https://github.com/apache/pulsar-site/pull/571#issuecomment-1547052876 > > Can you attach the related code PR in the doc PR description (as commented in [#565 (comment)](https://github.com/apache/pulsar-site/pull/565#issuecomment-1541064214))? So that reviewers will have more context, which can speed up the review process. > > oh, Sorry. Maybe we can change PR template? > > ### Preview > ### Relation PR > ### Documentation > * [ ] `doc` > * [ ] `doc-required` > * [ ] `doc-not-needed` > * [ ] `doc-complete` Sure, done in https://github.com/apache/pulsar-site/pull/572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #567: Add missing documentation for JVM metrics in Pulsar broker
Anonymitaet commented on code in PR #567: URL: https://github.com/apache/pulsar-site/pull/567#discussion_r1193240240 ## docs/reference-metrics.md: ## @@ -600,6 +600,67 @@ All the metadata store metrics are labeled with the following labels: | pulsar_batch_metadata_store_batch_execute_time_ms | Histogram | The duration of the batch execution in milliseconds. | | pulsar_batch_metadata_store_batch_size | Histogram | The number of read/write operations in the batch. | +### JVM Metrics + + Process Metrics +| Name | Type| Description | +||-|--| +| process_cpu_seconds_total | Counter | Total user and system CPU time spent in seconds. | +| process_start_time_seconds | Gauge | Start time of the process since unix epoch in seconds. | +| process_open_fds | Gauge | Number of open file descriptors. | +| process_max_fds | Gauge | Maximum number of open file descriptors. | +| process_virtual_memory_bytes | Gauge | Virtual memory size in bytes. | +| process_resident_memory_bytes | Gauge | Resident memory size in bytes. | + + Memory Metrics +| Name | Type| Description | +||-|--| +| jvm_memory_objects_pending_finalization | Gauge | The number of objects waiting in the finalizer queue. | +| jvm_memory_bytes_used | Gauge | Used bytes of a given JVM memory area. | +| jvm_memory_bytes_committed | Gauge | Committed (bytes) of a given JVM memory area. | +| jvm_memory_bytes_max | Gauge | Max (bytes) of a given JVM memory area. | +| jvm_memory_bytes_init | Gauge | Initial bytes of a given JVM memory area. | +| jvm_memory_pool_bytes_used | Used bytes of a given JVM memory pool. | +| jvm_memory_pool_bytes_committed | Gauge | Committed bytes of a given JVM memory pool. | +| jvm_memory_pool_bytes_max | Gauge | Max bytes of a given JVM memory pool. | +| jvm_memory_pool_bytes_init | Gauge | Initial bytes of a given JVM memory pool. | +| jvm_memory_pool_collection_used_bytes | Gauge | Used bytes after last collection of a given JVM memory pool. | Review Comment: ```suggestion | jvm_memory_pool_collection_used_bytes | Gauge | Used bytes after the last collection of a given JVM memory pool. | ``` ## docs/reference-metrics.md: ## @@ -600,6 +600,67 @@ All the metadata store metrics are labeled with the following labels: | pulsar_batch_metadata_store_batch_execute_time_ms | Histogram | The duration of the batch execution in milliseconds. | | pulsar_batch_metadata_store_batch_size | Histogram | The number of read/write operations in the batch. | +### JVM Metrics + + Process Metrics +| Name | Type| Description | +||-|--| +| process_cpu_seconds_total | Counter | Total user and system CPU time spent in seconds. | +| process_start_time_seconds | Gauge | Start time of the process since unix epoch in seconds. | +| process_open_fds | Gauge | Number of open file descriptors. | +| process_max_fds | Gauge | Maximum number of open file descriptors. | +| process_virtual_memory_bytes | Gauge | Virtual memory size in bytes. | +| process_resident_memory_bytes | Gauge | Resident memory size in bytes. | + + Memory Metrics +| Name | Type| Description | +||-|--| +| jvm_memory_objects_pending_finalization | Gauge | The number of objects waiting in the finalizer queue. | +| jvm_memory_bytes_used | Gauge | Used bytes of a given JVM memory area. | +| jvm_memory_bytes_committed | Gauge | Committed (bytes) of a given JVM memory area. | +| jvm_memory_bytes_max | Gauge | Max (bytes) of a given JVM memory area. | +| jvm_memory_bytes_init | Gauge | Initial bytes of a given JVM memory area. |
[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #564: Add document for bucket delayed message tracker metrics
Anonymitaet commented on code in PR #564: URL: https://github.com/apache/pulsar-site/pull/564#discussion_r1193238262 ## versioned_docs/version-3.0.x/reference-metrics.md: ## @@ -201,7 +201,12 @@ All the namespace metrics are labeled with the following labels: | pulsar_subscription_delayed | Gauge | The total message batches (entries) are delayed for dispatching. | | pulsar_storage_write_latency_le_* | Histogram | The entry rate of a namespace that the storage write latency is smaller with a given threshold. Available thresholds: pulsar_storage_write_latency_le_0_5: <= 0.5ms pulsar_storage_write_latency_le_1: <= 1mspulsar_storage_write_latency_le_5: <= 5mspulsar_storage_write_latency_le_10: <= 10mspulsar_storage_write_latency_le_20: <= 20mspulsar_storage_write_latency_le_50: <= 50mspulsar_storage_write_latency_le_100: <= 100mspulsar_storage_write_latency_le_200: <= 200mspulsar_storage_write_latency_le_1000: <= 1spulsar_storage_write_latency_le_overflow: > 1s | | pulsar_entry_size_le_* | Histogram | The entry rate of a namespace that the entry size is smaller with a given threshold. Available thresholds: pulsar_entry_size_le_128: <= 128 bytes pulsar_entry_size_le_512: <= 512 bytespulsar_entry_size_le_1_kb: <= 1 KBpulsar_entry_size_le_2_kb: <= 2 KBpulsar_entry_size_le_4_kb: <= 4 KBpulsar_entry_size_le_16_kb: <= 16 KBpulsar_entry_size_le_100_kb: <= 100 KBpulsar_entry_size_le_1_mb: <= 1 MBpulsar_entry_size_le_overflow: > 1 MB | -| pulsar_delayed_message_index_size_bytes | Gauge | The total memory size allocated by `InMemoryDelayedDeliveryTracker` of the namespace owned by this broker (in bytes). | +| pulsar_delayed_message_index_size_bytes | Gauge | The total memory size allocated by `DelayedDeliveryTracker` of the namespace owned by this broker (in bytes). | +| pulsar_delayed_message_index_bucket_total | Gauge | The number of delayed message index buckets (immutable buckets + LastMutableBucket ) | +| pulsar_delayed_message_index_loaded | Gauge | The total number of delayed message indexes for in the memory. | +| pulsar_delayed_message_index_bucket_snapshot_size_bytes | Gauge | The total size of delayed message index bucket snapshot (in bytes). | +| pulsar_delayed_message_index_bucket_op_count | Counter | The total number of operate delayed message index bucket snapshot. The `state` label can be `succeed`,`failed`,`all` (the `all` means is the total number of all states) and the `type` label can be `create`,`load`,`delete`,`merge`. | Review Comment: ```suggestion | pulsar_delayed_message_index_bucket_op_count | Counter | The total number of operation delayed message index bucket snapshots. The `state` label can be `succeed`,`failed`, and`all` (`all` means the total number of all states) and the `type` label can be `create`,`load`,`delete`, and `merge`. | ``` ## versioned_docs/version-3.0.x/reference-metrics.md: ## @@ -418,6 +428,12 @@ All the subscription metrics are labeled with the following labels: | pulsar_subscription_filter_accepted_msg_count | Counter | The number of messages accepted by `EntryFilter`. | | pulsar_subscription_filter_rejected_msg_count | Counter | The number of messages rejected by `EntryFilter`. | | pulsar_subscription_filter_rescheduled_msg_count | Counter | The number of messages rescheduled by `EntryFilter`. | +| pulsar_delayed_message_index_size_bytes | Gauge | The total memory size allocated by `DelayedDeliveryTracker` of the subscription owned by this broker (in bytes). | +| pulsar_delayed_message_index_bucket_total | Gauge | The number of delayed message index buckets (immutable buckets + LastMutableBucket ) | +| pulsar_delayed_message_index_loaded | Gauge | The total number of delayed message indexes for in the memory. | +| pulsar_delayed_message_index_bucket_snapshot_size_bytes | Gauge | The total size of delayed message index bucket snapshot (in bytes). | +| pulsar_delayed_message_index_bucket_op_count | Counter | The total number of operate delayed message index bucket snapshot. The `state` label can be `succeed`,`failed`,`all` (the `all` means is the total number of all states) and the `type` label can be `create`,`load`,`delete`,`merge`. | +| pulsar_delayed_message_index_bucket_op_latency_ms | Histogram | The latency of delayed message index bucket snapshot operation with a given quantile (threshold). The label`type` label can be `create`,`load`,`delete`,`merge`The label `quantile` can be:quantile="50" is operation latency between (0ms, 50ms]quantile="100" is operation latency between (50ms, 100ms]quantile="500" is operation between (100ms, 500ms]quantile="1000" is operation latency between (500ms, 1s]quantile="5000" is operation latency between (1s, 5s]quantile="3" is operation latency between (5s, 30s]quantile="6" is operation latency between (30s, 60s]quantile="overflow" is operation latency > 1m | Review Comment: same ##
[GitHub] [pulsar-site] Anonymitaet commented on pull request #569: fix(doc): concepts-messaging.md
Anonymitaet commented on PR #569: URL: https://github.com/apache/pulsar-site/pull/569#issuecomment-1547048962 @wanxhai does it make sense to close this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] aymardika added a comment to the discussion: [configuration between Pulsar and MongoDB Atlas not working]
GitHub user aymardika added a comment to the discussion: [configuration between Pulsar and MongoDB Atlas not working] But how could I maintain the connection permanent ? Please could you help ? Sent from Yahoo Mail on Android On Sun, May 14, 2023 at 12:37 AM, ***@***.***> wrote: The error indicates that you can correctly connect to the MongoDB cluster but "Prematurely reached end of stream". — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***> GitHub link: https://github.com/apache/pulsar/discussions/20318#discussioncomment-5899620 This is an automatically sent email for commits@pulsar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar-site] asafm commented on pull request #560: PIP-249 site redesign
asafm commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546983516 @visortelle all good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #560: PIP-249 site redesign
visortelle commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546982275 @asafm please check the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #560: PIP-249 site redesign
visortelle commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546934423 > The font on the left navigation bar is the same as the one on the main text? Yes, the font-family is the same. Made it less bold. Probably now it looks better. https://github.com/apache/pulsar-site/assets/9302460/3e298d2b-e381-476a-9504-c772916a7710;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20303: [fix] [meta]Switch to the metadata store thread after zk operation
poorbarcode commented on code in PR #20303:
URL: https://github.com/apache/pulsar/pull/20303#discussion_r1193168968
##
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreTest.java:
##
@@ -425,6 +428,75 @@ public void testDeleteUnusedDirectories(String provider,
Supplier urlSup
assertFalse(store.exists(prefix).join());
}
+@DataProvider(name = "conditionOfSwitchThread")
+public Object[][] conditionOfSwitchThread(){
+return new Object[][]{
+{false, false},
+{false, true},
+{true, false},
+{true, true}
+};
+}
+
+@Test(dataProvider = "conditionOfSwitchThread")
+public void testThreadSwitchOfZkMetadataStore(boolean hasSynchronizer,
boolean enabledBatch) throws Exception {
+final String prefix = newKey();
+final String metadataStoreName =
UUID.randomUUID().toString().replaceAll("-", "");
+MetadataStoreConfig.MetadataStoreConfigBuilder builder =
+
MetadataStoreConfig.builder().metadataStoreName(metadataStoreName);
+builder.fsyncEnable(false);
+builder.batchingEnabled(enabledBatch);
+if (!hasSynchronizer) {
+builder.synchronizer(null);
+}
+MetadataStoreConfig config = builder.build();
+@Cleanup
+ZKMetadataStore store = (ZKMetadataStore)
MetadataStoreFactory.create(zks.getConnectionString(), config);
+
+final Runnable verify = () -> {
+String currentThreadName = Thread.currentThread().getName();
+String errorMessage = String.format("Expect to switch to thread
%s, but currently it is thread %s",
+metadataStoreName, currentThreadName);
+if
(!Thread.currentThread().getName().startsWith(metadataStoreName)){
+throw new RuntimeException(errorMessage);
+}
+};
+
+// put with node which has parent(but the parent node is not exists).
+store.put(prefix + "/a1/b1/c1", "value".getBytes(),
Optional.of(-1L)).thenApply((ignore) -> {
+verify.run();
+return null;
+}).join();
+// put.
+store.put(prefix + "/b1", "value".getBytes(),
Optional.of(-1L)).thenApply((ignore) -> {
+verify.run();
+return null;
+}).join();
+// get.
+store.get(prefix + "/b1").thenApply((ignore) -> {
+verify.run();
+return null;
+}).join();
+// get the node which is not exists.
+store.get(prefix + "/non").thenApply((ignore) -> {
+verify.run();
+return null;
+}).join();
+// delete.
+store.delete(prefix + "/b1", Optional.empty()).thenApply((ignore) -> {
+verify.run();
+return null;
+}).join();
+// delete the node which is not exists.
+store.delete(prefix + "/non", Optional.empty()).thenApply((ignore) -> {
+verify.run();
+return null;
+}).exceptionally(ex -> {
+verify.run();
+return null;
+}).join();
+}
Review Comment:
> I suggest that DO NOT use CompletableFuture#get and CompletableFuture#join
anywhere.
Agree with you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-site] asafm commented on pull request #560: PIP-249 site redesign
asafm commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546927285 Other than that, it's perfect! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] asafm commented on pull request #560: PIP-249 site redesign
asafm commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546927074 The comment up is actually for the entire community page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] asafm commented on pull request #560: PIP-249 site redesign
asafm commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546926995 In community, something is not aligned on iPhone 13 mini:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #560: PIP-249 site redesign
visortelle commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546926663 @tisonkun can you please provide instructions on how to develop abd build ‘/contribute’ and other pages that aren’t available automatically after running ‘npm start’ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] asafm commented on pull request #560: PIP-249 site redesign
asafm commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546926492 When surfing on iPhone, the icons for Pulsar features sometime is cut:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] asafm commented on pull request #560: PIP-249 site redesign
asafm commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546925383  This section is still work in progress? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] asafm commented on pull request #560: PIP-249 site redesign
asafm commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546925163  The font on the left navigation bar is the same as the one on the main text? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #560: PIP-249 site redesign
visortelle commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546918913 I noticed issues on mobile. Something goes wrong with background positions when building for production. Will try to figure out the reason. Local dev: https://github.com/apache/pulsar-site/assets/9302460/84157433-ccb3-4213-99ad-c56ba3323248;> Production build: https://github.com/apache/pulsar-site/assets/9302460/9baa1ece-b5c6-43c7-be03-5170e7fba49f;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #560: PIP-249 site redesign
visortelle commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546917528 Didn't found this info on LinkedIn, but Google helped. https://github.com/apache/pulsar-site/assets/9302460/1474815a-bbad-4780-9246-5bfb9a6e2286;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #560: PIP-249 site redesign
visortelle commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546917097 @asafm please check now. I think there is a mistake in user testimonials. K.Merkushev is duplicated and J.Joseph is a company. Maybe you know the right info? https://github.com/apache/pulsar-site/assets/9302460/7f6ecfd1-db0f-4c69-ad1b-4d1c04de7cbb;> https://github.com/apache/pulsar-site/blob/70dc8e54ccf16308875c4345b28924e79700ce5b/src/pages/index.js#L101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] asafm commented on pull request #560: PIP-249 site redesign
asafm commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1546914359  This is still at work, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] wenjun8888 opened a new issue, #20320: bookkeeper storage ledgers did not auto delete [Bug]
wenjun opened a new issue, #20320: URL: https://github.com/apache/pulsar/issues/20320 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version System: Centos7.6 Pulsar: 2.8.2 ### Minimal reproduce step All the namespaces/topics we set retention policy and ttl. During pulsar manager we can see all namespace take about 25G storage size：  But in system it used nearly 100G  I don't know why, i already use "curl -XPUT 127.0.0.1:/api/v1/bookie/gc" try release disk space and it not work. ### What did you expect to see? Disk usage similar with what i see in pulsar manage. ### What did you see instead? about 90G instead of 25G ### Anything else? _No response_ ### Are you willing to submit a PR? - [ ] I'm willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-python] shibd merged pull request #117: [Doc] Add links to client docs and feature matrix in README.md
shibd merged PR #117: URL: https://github.com/apache/pulsar-client-python/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-client-python] branch main updated: Update README.md (#117)
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git The following commit(s) were added to refs/heads/main by this push: new fee8d1d Update README.md (#117) fee8d1d is described below commit fee8d1dc92045edb6348e9c1a43dd334bf907daf Author: Jun Ma <60642177+momo-...@users.noreply.github.com> AuthorDate: Sun May 14 21:04:55 2023 +0800 Update README.md (#117) --- README.md | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 650cb56..5ebbdd2 100644 --- a/README.md +++ b/README.md @@ -21,6 +21,8 @@ # Pulsar Python client library +Pulsar Python clients support a variety of Pulsar features to enable building applications connecting to your Pulsar cluster. For the supported Pulsar features, see [Client Feature Matrix](https://pulsar.apache.org/client-feature-matrix/). + ## Requirements - Python >= 3.7 @@ -53,7 +55,7 @@ Make sure the PyBind11 submodule has been downloaded and the Pulsar C++ client h ```bash cmake -B build -cmake --build build +cmake --build build cmake --install build python3 ./setup.py bdist_wheel python3 -m pip install dist/pulsar_client-*.whl --force-reinstall @@ -61,13 +63,13 @@ python3 -m pip install dist/pulsar_client-*.whl --force-reinstall > **NOTE** > -> 1. Here a separate `build` directory is created to store all CMake temporary files. However, the `setup.py` requires the `_pulsar.so` is under the project directory. +> 1. The separate `build` directory is created to store all CMake temporary files. However, the `setup.py` requires the `_pulsar.so` to be under the project directory. > 2. Add the `--force-reinstall` option to overwrite the existing Python wheel > in case your system has already installed a wheel before. > 3. On Windows, the Python command is `py` instead of `python3`. ## Running examples -You can run `python3 -c 'import pulsar'` to see whether the wheel has been installed successfully. If it failed, check whether dependencies (e.g. `libpulsar.so`) are in the system path. If not, make sure the dependencies are in `LD_LIBRARY_PATH` (on Linux) or `DYLD_LIBRARY_PATH` (on macOS). +You can run `python3 -c 'import pulsar'` to see whether the wheel has been installed successfully. If it fails, check whether dependencies (e.g., `libpulsar.so`) are in the system path. If not, make sure the dependencies are in `LD_LIBRARY_PATH` (on Linux) or `DYLD_LIBRARY_PATH` (on macOS). Then you can run examples as a simple end-to-end test. @@ -99,7 +101,7 @@ Run all unit tests: ./tests/run-unit-tests.sh ``` -Run a single unit test (e.g. `PulsarTest.test_tls_auth`): +Run a single unit test (e.g., `PulsarTest.test_tls_auth`): ```bash python3 ./tests/pulsar_test.py 'PulsarTest.test_tls_auth' @@ -118,3 +120,9 @@ pydoctor --make-html \ --html-output= \ pulsar ``` + +## Contribute + +We welcome contributions from the open source community! + +If your contribution adds Pulsar features for Python clients, you need to update both the [Pulsar docs](https://pulsar.apache.org/docs/client-libraries/) and the [Client Feature Matrix](https://pulsar.apache.org/client-feature-matrix/). See [Contribution Guide](https://pulsar.apache.org/contribute/site-intro/#pages) for more details.
[GitHub] [pulsar] mattisonchao commented on issue #20314: Python tests are broken in branch-2.10
mattisonchao commented on issue #20314: URL: https://github.com/apache/pulsar/issues/20314#issuecomment-1546884977 I wonder if we should maintain the Python client in the previous branches. /cc @BewareMyPower @shibd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #17898: Only Index Docs from Currently Supported Versions
tisonkun commented on issue #17898: URL: https://github.com/apache/pulsar/issues/17898#issuecomment-1546881337 Closed as somehow we now have only indices for new versions. I'm not sure why but let's open a new issue if there is any regressions. https://github.com/apache/pulsar/assets/18818196/89dd87d5-f4d6-4872-8fbc-28a2599b7989;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #13151: Not able to run pulsar postgres jdbc sink
tisonkun commented on issue #13151:
URL: https://github.com/apache/pulsar/issues/13151#issuecomment-1546865273
Cannot reproduce on master:
```
$ bin/pulsar-admin sinks create \
--archive ./connectors/pulsar-io-jdbc-postgres-3.1.0-SNAPSHOT.nar \
--inputs pulsar-postgres-jdbc-sink-topic \
--name pulsar-postgres-jdbc-sink \
--sink-config-file ./connectors/pulsar-postgres-jdbc-sink.yaml \
--parallelism 1
Created successfully
$ bin/pulsar-admin sinks list \
--tenant public \
--namespace default
[
"pulsar-postgres-jdbc-sink"
]
$ bin/pulsar-admin sinks get \
--tenant public \
--namespace default \
--name pulsar-postgres-jdbc-sink
{
"tenant": "public",
"namespace": "default",
"name": "pulsar-postgres-jdbc-sink",
"className": "org.apache.pulsar.io.jdbc.PostgresJdbcAutoSchemaSink",
"sourceSubscriptionPosition": "Latest",
"inputs": [
"pulsar-postgres-jdbc-sink-topic"
],
"inputSpecs": {
"pulsar-postgres-jdbc-sink-topic": {
"isRegexPattern": false,
"schemaProperties": {},
"consumerProperties": {},
"poolMessages": false
}
},
"configs": {
"jdbcUrl": "jdbc:postgresql://localhost:5432/postgres",
"userName": "chenzili",
"tableName": "pulsar_postgres_jdbc_sink"
},
"parallelism": 1,
"processingGuarantees": "ATLEAST_ONCE",
"retainOrdering": false,
"retainKeyOrdering": false,
"resources": {
"cpu": 1.0,
"ram": 1073741824,
"disk": 10737418240
},
"autoAck": true,
"cleanupSubscription": true
}
$ bin/pulsar-admin sinks status \
--tenant public \
--namespace default \
--name pulsar-postgres-jdbc-sink
{
"numInstances" : 1,
"numRunning" : 1,
"instances" : [ {
"instanceId" : 0,
"status" : {
"running" : true,
"error" : "",
"numRestarts" : 0,
"numReadFromPulsar" : 0,
"numSystemExceptions" : 0,
"latestSystemExceptions" : [ ],
"numSinkExceptions" : 0,
"latestSinkExceptions" : [ ],
"numWrittenToSink" : 0,
"lastReceivedTime" : 0,
"workerId" : "c-standalone-fw-localhost-8080"
}
} ]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #13151: Not able to run pulsar postgres jdbc sink
tisonkun closed issue #13151: Not able to run pulsar postgres jdbc sink URL: https://github.com/apache/pulsar/issues/13151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #13224: Broker Java heap space OOM
tisonkun commented on issue #13224: URL: https://github.com/apache/pulsar/issues/13224#issuecomment-1546862274 Closed as stale. Please open a new ticket in https://github.com/apache/pulsar/discussions/categories/q-a if it happens again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #13224: Broker Java heap space OOM
tisonkun closed issue #13224: Broker Java heap space OOM URL: https://github.com/apache/pulsar/issues/13224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #13358: Functions: NullPointerException in FunctionStatsManager.reset
tisonkun closed issue #13358: Functions: NullPointerException in FunctionStatsManager.reset URL: https://github.com/apache/pulsar/issues/13358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #13524: [pulsar-client] Support receiverQueueRefillThreshold configuration.
tisonkun commented on issue #13524: URL: https://github.com/apache/pulsar/issues/13524#issuecomment-1546860980 This config option no longer exists. Closed as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #13524: [pulsar-client] Support receiverQueueRefillThreshold configuration.
tisonkun closed issue #13524: [pulsar-client] Support receiverQueueRefillThreshold configuration. URL: https://github.com/apache/pulsar/issues/13524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #20319: [feat][ci] replace stale bot with ping-pong workflow
tisonkun commented on code in PR #20319: URL: https://github.com/apache/pulsar/pull/20319#discussion_r1193093450 ## .github/workflows/ci-pingpong.yaml: ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Ping Pong +on: + issues: +types: [opened, reopened] + issue_comment: +types: [created] + pull_request: +types: [opened, reopened] + pull_request_review: +types: [submitted] + pull_request_review_comment: +types: [created] Review Comment: Also, we may take [discussion](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#discussion) into consideration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #20319: [feat][ci] replace stale bot with ping-pong workflow
tisonkun commented on code in PR #20319: URL: https://github.com/apache/pulsar/pull/20319#discussion_r1193093163 ## .github/workflows/ci-pingpong.yaml: ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Ping Pong +on: + issues: +types: [opened, reopened] + issue_comment: +types: [created] + pull_request: +types: [opened, reopened] + pull_request_review: +types: [submitted] + pull_request_review_comment: +types: [created] Review Comment: Perhaps PR can adopt a simple request review ping-pong workflow. This is open for discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #20319: ci: add ping-pong action
github-actions[bot] commented on PR #20319: URL: https://github.com/apache/pulsar/pull/20319#issuecomment-1546822198 @tisonkun Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed pull request #20319: ci: add ping-pong action
tisonkun closed pull request #20319: ci: add ping-pong action URL: https://github.com/apache/pulsar/pull/20319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun opened a new pull request, #20319: ci: add ping-pong action
tisonkun opened a new pull request, #20319: URL: https://github.com/apache/pulsar/pull/20319 Fixes #xyz Master Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
