[GitHub] [pulsar] nodece opened a new pull request, #19254: [improve][websocket] Add ping support

nodece opened a new pull request, #19254: URL: https://github.com/apache/pulsar/pull/19254 ### Motivation Cherry-pick https://github.com/apache/pulsar/pull/19203 to branch-2.10. ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed`

[GitHub] [pulsar] nicoloboschi commented on issue #19218: pulsar-shell CTRL-C should be interpreted as cancel the current command and should not exit the shell

nicoloboschi commented on issue #19218: URL: https://github.com/apache/pulsar/issues/19218#issuecomment-1385089081 I fixed it here: https://github.com/apache/pulsar/pull/18615 I noticed that actually in the tarball isn't working (using 2.11.0) but within the docker container it works

[GitHub] [pulsar-client-node] shibd commented on a diff in pull request #288: Make it compatible with GLIBCXX_3.4.19 (CentOS 7)

shibd commented on code in PR #288: URL: https://github.com/apache/pulsar-client-node/pull/288#discussion_r1071954273 ## tests/load-test.sh: ## @@ -0,0 +1,42 @@ +#!/bin/bash Review Comment: This script is only used in Linux-related workflows and is recommended to be

[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #151: [feat] Support batch index acknowledgment

BewareMyPower commented on PR #151: URL: https://github.com/apache/pulsar-client-cpp/pull/151#issuecomment-1385083824 @merlimat @RobertIndie @Demogorgon314 This PR has been pending for 3 weeks. Could any committer take a look? -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #139: [feat] Support Dead Letter Topic.

BewareMyPower commented on code in PR #139: URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1071945567 ## lib/ProducerConfiguration.cc: ## @@ -16,6 +16,8 @@ * specific language governing permissions and limitations * under the License. */ +#include

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #139: [feat] Support Dead Letter Topic.

BewareMyPower commented on code in PR #139: URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1071952441 ## lib/ProducerConfigurationImpl.h: ## @@ -50,6 +50,20 @@ struct ProducerConfigurationImpl { std::map properties; bool chunkingEnabled{false};

[GitHub] [pulsar-client-cpp] tongsucn commented on pull request #129: [improve] Add configuration to limit times of client's lookup redirection.

tongsucn commented on PR #129: URL: https://github.com/apache/pulsar-client-cpp/pull/129#issuecomment-1385074860 FYI related tests has been added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] HQebupt merged pull request #19244: [fix][broker] Avoid bundle unload destination broker be set as an inactive broker.

HQebupt merged PR #19244: URL: https://github.com/apache/pulsar/pull/19244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #169: [feat] Add producer interceptor

BewareMyPower commented on code in PR #169: URL: https://github.com/apache/pulsar-client-cpp/pull/169#discussion_r1071937413 ## include/pulsar/ProducerConfiguration.h: ## @@ -532,6 +533,10 @@ class PULSAR_PUBLIC ProducerConfiguration { */ ProducerAccessMode

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #139: [feat] Support Dead Letter Topic.

BewareMyPower commented on code in PR #139: URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1071930114 ## include/pulsar/ConsumerConfiguration.h: ## @@ -554,6 +593,8 @@ class PULSAR_PUBLIC ConsumerConfiguration { bool isStartMessageIdInclusive()

[GitHub] [pulsar] codelipenghui merged pull request #19048: [improve][client] Add unified newTableView method in PulsarClient

codelipenghui merged PR #19048: URL: https://github.com/apache/pulsar/pull/19048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #126: [fix] Fix hostname verification

BewareMyPower commented on PR #126: URL: https://github.com/apache/pulsar-client-cpp/pull/126#issuecomment-1385036938 The fix LGTM, but could you describe how to generate this certificates? It would not block this PR but I think it could be improved to make tests clear. It seems that when

[GitHub] [pulsar] labuladong opened a new pull request, #19253: [fix][test] testSingleTopicConsumerBatchShortName

labuladong opened a new pull request, #19253: URL: https://github.com/apache/pulsar/pull/19253 Fixes #19089 ### Modifications Every manageredLeger has its own thread pool, so there is no ordering guarantee between different topics. ### Verifying this

[GitHub] [pulsar] lhotari merged pull request #19251: [improve][ci] Upload native crash dump files hs_err_*.log & core.* in CI unit tests

lhotari merged PR #19251: URL: https://github.com/apache/pulsar/pull/19251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codecov-commenter commented on pull request #19251: [improve][ci] Upload native crash dump files hs_err_*.log & core.* in CI unit tests

codecov-commenter commented on PR #19251: URL: https://github.com/apache/pulsar/pull/19251#issuecomment-1385012919 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19251?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] lhotari commented on issue #19218: pulsar-shell CTRL-C should be interpreted as cancel the current command and should not exit the shell

lhotari commented on issue #19218: URL: https://github.com/apache/pulsar/issues/19218#issuecomment-1385010515 There might be technical limitations in intercepting CTRL-C. I remember facing this problem with Grails shell and Gradle continuous build input many years ago. Another possibility

[GitHub] [pulsar] nodece merged pull request #19245: [improve][websocket][branch-2.9] Add ping support

nodece merged PR #19245: URL: https://github.com/apache/pulsar/pull/19245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nodece commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

nodece commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071891107 ## pulsar-metadata/src/test/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImplTest.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

lhotari commented on PR #19237: URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1384996789 > The flaky test group allows failure when running CI, if any test fails during the flaky test group running, the result will be not accurated. @yaalsn The flaky test group

[GitHub] [pulsar] asafm commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

asafm commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071875876 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/RocksdbMetadataStore.java: ## @@ -570,3 +573,17 @@ public Optional getMetadataEventSynchronizer() {

[GitHub] [pulsar] lhotari opened a new pull request, #19252: [improve][ci] Improve test fail fast: disable for non-PR builds, fail parallel forked test procs

lhotari opened a new pull request, #19252: URL: https://github.com/apache/pulsar/pull/19252 ### Motivation Currently, there's a custom fail fast mode implemented as a TestNG listener in

[GitHub] [pulsar] nodece commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

nodece commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071870686 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +63,39 @@ public static MetadataStoreExtended

[GitHub] [pulsar] nodece commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

nodece commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071869275 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +63,39 @@ public static MetadataStoreExtended

[GitHub] [pulsar] nodece commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

nodece commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071868786 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +63,39 @@ public static MetadataStoreExtended

[GitHub] [pulsar] nodece commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

nodece commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071861855 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +63,39 @@ public static MetadataStoreExtended

[GitHub] [pulsar] nodece commented on pull request #19249: [improve][io] Upgrade HBase to 2.4.15

nodece commented on PR #19249: URL: https://github.com/apache/pulsar/pull/19249#issuecomment-1384944341 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-go] nodece merged pull request #943: Update the Cobra library to significantly reduce the dependency tree

nodece merged PR #943: URL: https://github.com/apache/pulsar-client-go/pull/943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Technoboy- merged pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete

Technoboy- merged PR #19242: URL: https://github.com/apache/pulsar/pull/19242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-node] BewareMyPower opened a new pull request, #288: Make it compatible with GLIBCXX_3.4.19 (CentOS 7)

BewareMyPower opened a new pull request, #288: URL: https://github.com/apache/pulsar-client-node/pull/288 Fixes https://github.com/apache/pulsar-client-node/issues/286 ### Motivation The maximum GLIBCXX version on CentOS 7 is 3.4.19. If we want to use the Pulsar Node client on

[GitHub] [pulsar] lhotari opened a new pull request, #19251: [improve][ci] Upload native crash dump files hs_err_*.log & core.* in CI unit tests

lhotari opened a new pull request, #19251: URL: https://github.com/apache/pulsar/pull/19251 ### Motivation - helps investigate issues when there's a JVM crash such as #19250 ### Modifications - upload native crash dump files hs_err_*.log & core.* in CI unit tests

[GitHub] [pulsar] lhotari opened a new issue, #19250: [Bug] Pulsar RocksDB metadata driver causes JVM to crash in unit tests

lhotari opened a new issue, #19250: URL: https://github.com/apache/pulsar/issues/19250 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version

[GitHub] [pulsar] sekikn opened a new pull request, #19249: [improve][io] Upgrade HBase to 2.4.15

sekikn opened a new pull request, #19249: URL: https://github.com/apache/pulsar/pull/19249 ### Motivation Currently, the HBase sink uses HBase 2.4.9, which is released over a years ago. ### Modifications This PR upgrades HBase to the current latest version of the 2.4.x

[GitHub] [pulsar] Meet0861 opened a new issue, #19248: [Bug] partitioned-stats gives incorrect replication connection status

Meet0861 opened a new issue, #19248: URL: https://github.com/apache/pulsar/issues/19248 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version v-2.9.3.3-2 ### Minimal reproduce

[GitHub] [pulsar] poorbarcode commented on pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete

poorbarcode commented on PR #19242: URL: https://github.com/apache/pulsar/pull/19242#issuecomment-1384902136 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Nicklee007 commented on pull request #19244: [fix][broker] Avoid bundle unload destination broker be set as an inactive broker.

Nicklee007 commented on PR #19244: URL: https://github.com/apache/pulsar/pull/19244#issuecomment-1384898962 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] poorbarcode commented on pull request #18318: [fix][test] fix testEndTxnWhenCommittingOrAborting flaky test

poorbarcode commented on PR #18318: URL: https://github.com/apache/pulsar/pull/18318#issuecomment-1384898681 @lhotari could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] poorbarcode commented on issue #18605: Flaky-test: TransactionTest.testEndTxnWhenCommittingOrAborting

poorbarcode commented on issue #18605: URL: https://github.com/apache/pulsar/issues/18605#issuecomment-1384897300 link PR: - https://github.com/apache/pulsar/pull/18318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] poorbarcode commented on pull request #18318: [fix][test] fix testEndTxnWhenCommittingOrAborting flaky test

poorbarcode commented on PR #18318: URL: https://github.com/apache/pulsar/pull/18318#issuecomment-1384896376 new flaky-test case: - https://github.com/apache/pulsar/actions/runs/3935861095/jobs/6732032238 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] lightzhao closed pull request #17813: unload bundle causes topic fence, OpAddEntry NPE appears in addComple…

lightzhao closed pull request #17813: unload bundle causes topic fence, OpAddEntry NPE appears in addComple… URL: https://github.com/apache/pulsar/pull/17813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

lhotari commented on PR #19237: URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1384878024 > The flaky test group allows failure when running CI, if any test fails during the flaky test group running, the result will be not accurated. A few flaky tests won't

[GitHub] [pulsar] Nicklee007 commented on pull request #19244: [fix][broker] Avoid bundle unload destination broker be set as an inactive broker.

Nicklee007 commented on PR #19244: URL: https://github.com/apache/pulsar/pull/19244#issuecomment-1384872937 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-go] shibd opened a new pull request, #944: [feat] Support Exclusive Producer access mode.

shibd opened a new pull request, #944: URL: https://github.com/apache/pulsar-client-go/pull/944 Master Issue: #931 ### Motivation #931 ### Modifications - Support the `Exclusive` Producer access mode config in the `ProducerOptions`. **Note**:

[GitHub] [pulsar] codelipenghui commented on issue #18605: Flaky-test: TransactionTest.testEndTxnWhenCommittingOrAborting

codelipenghui commented on issue #18605: URL: https://github.com/apache/pulsar/issues/18605#issuecomment-1384868404 Another one https://github.com/apache/pulsar/actions/runs/3935861095/jobs/6732032238 @congbobo184 @liangyepianzhou Could you please help take a look? -- This is an

[GitHub] [pulsar] yaalsn commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

yaalsn commented on PR #19237: URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1384853857 > One more attempt. > > The coverage profile wasn't activated for the BROKER_FLAKY unit test group: > >

[GitHub] [pulsar] Demogorgon314 commented on pull request #18858: [improve][broker] PIP-192: Write the child ownership to `ServiceUnitStateChannel` instead of ZK when handling bundle split

Demogorgon314 commented on PR #18858: URL: https://github.com/apache/pulsar/pull/18858#issuecomment-1384843710 > Hmmm, I think the right solution is to improve the NamespaceService to decide to write to Zookeeper or service unit channel? We also have Admin API to split the bundle, it will

[GitHub] [pulsar] Demogorgon314 commented on pull request #18858: [improve][broker] PIP-192: Write the child ownership to `ServiceUnitStateChannel` instead of ZK when handling bundle split

Demogorgon314 commented on PR #18858: URL: https://github.com/apache/pulsar/pull/18858#issuecomment-1384829226 > I think it's incorrect in the PR's description, right? @codelipenghui Thanks for reminding me, I have fixed it. -- This is an automated message from the Apache Git

[GitHub] [pulsar] codelipenghui commented on pull request #18858: [improve][broker] PIP-192: Write the child ownership to `ServiceUnitStateChannel` instead of ZK when handling bundle split

codelipenghui commented on PR #18858: URL: https://github.com/apache/pulsar/pull/18858#issuecomment-1384826597 > When the channel handles the split event, we should write the split bundle to zookeeper instead of ServiceUnitStateChannel, @Demogorgon314 I think it's incorrect in the

[GitHub] [pulsar] codelipenghui commented on pull request #18810: [improve][broker] PIP-192: Implement broker registry for new load manager

codelipenghui commented on PR #18810: URL: https://github.com/apache/pulsar/pull/18810#issuecomment-1384824151 > The lookup data will not be too heavy for Zookeeper, right? Maybe we can do some tests to find out is necessary to use LoadDataStore to store the lookup data. IMO, it's

[GitHub] [pulsar] sekikn opened a new pull request, #19247: [fix][io] Fix the Alluxio sink to write messages successfully after the first file rotation

sekikn opened a new pull request, #19247: URL: https://github.com/apache/pulsar/pull/19247 Fixes #19174 ### Motivation Currently, the Alluxio sink fails to write messages out after the first file rotation. ### Modifications This problem is caused

[GitHub] [pulsar] codelipenghui commented on pull request #18777: [improve][broker] PIP-192: Implement load data store

codelipenghui commented on PR #18777: URL: https://github.com/apache/pulsar/pull/18777#issuecomment-1384815592 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #19154: [improve][broker] PIP-192 Moved the common broker load data feature(weightedMaxEMA) to BrokerLoadData

codelipenghui commented on code in PR #19154: URL: https://github.com/apache/pulsar/pull/19154#discussion_r1071718092 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/data/BrokerLoadData.java: ## @@ -95,17 +124,35 @@ private void

[GitHub] [pulsar] tisonkun commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client

tisonkun commented on issue #18932: URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1384811263 @etcZYP I think you should directly send a patch against the master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] horizonzy closed pull request #19246: [improve] [broker] Introduce `metadataStoreAllowReadOnlyOperations` to deprecate `zookeeperAllowReadOnlyOperations`

horizonzy closed pull request #19246: [improve] [broker] Introduce `metadataStoreAllowReadOnlyOperations` to deprecate `zookeeperAllowReadOnlyOperations` URL: https://github.com/apache/pulsar/pull/19246 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] horizonzy opened a new pull request, #19246: [improve] [broker] Introduce `metadataStoreAllowReadOnlyOperations` to deprecate `zookeeperAllowReadOnlyOperations`

horizonzy opened a new pull request, #19246: URL: https://github.com/apache/pulsar/pull/19246 Fixes #xyz Master Issue: #xyz PIP: #xyz ### Motivation This is part 2 for #19156, deprecate

[GitHub] [pulsar-client-cpp] sindhushreem opened a new issue, #174: Enable tls hostname verification in c++ client it is failing but works with java client

sindhushreem opened a new issue, #174: URL: https://github.com/apache/pulsar-client-cpp/issues/174 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 2.8.2 ### Minimal

[GitHub] [pulsar] Pomelongan commented on a diff in pull request #18666: [improve][broker] Optimize the logic of internalCreatePartitionedTopic

Pomelongan commented on code in PR #18666: URL: https://github.com/apache/pulsar/pull/18666#discussion_r1071711295 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java: ## @@ -576,124 +576,87 @@ protected void

[GitHub] [pulsar] Pomelongan commented on a diff in pull request #18666: [improve][broker] Optimize the logic of internalCreatePartitionedTopic

Pomelongan commented on code in PR #18666: URL: https://github.com/apache/pulsar/pull/18666#discussion_r1071709118 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java: ## @@ -576,124 +576,87 @@ protected void

[GitHub] [pulsar] codelipenghui commented on pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete

codelipenghui commented on PR #19242: URL: https://github.com/apache/pulsar/pull/19242#issuecomment-1384794732 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] codelipenghui merged pull request #19157: [fix][broker] Close transactionBuffer after MessageDeduplication#checkStatus failed

codelipenghui merged PR #19157: URL: https://github.com/apache/pulsar/pull/19157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Pomelongan commented on a diff in pull request #18666: [improve][broker] Optimize the logic of internalCreatePartitionedTopic

Pomelongan commented on code in PR #18666: URL: https://github.com/apache/pulsar/pull/18666#discussion_r1071709118 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java: ## @@ -576,124 +576,87 @@ protected void

[GitHub] [pulsar] etcZYP commented on issue #18932: [Client] Drop jcommander dependency in Pulsar java client

etcZYP commented on issue #18932: URL: https://github.com/apache/pulsar/issues/18932#issuecomment-1384792564 > @etcZYP Assigned. Go ahead! > > ... and feel free to ask if you are uncertain. can you plz tell me which branch should i merge into? -- This is an automated message

[GitHub] [pulsar] codelipenghui commented on issue #19216: Flaky-test: ProxyPrometheusMetricsTest.testMetrics

codelipenghui commented on issue #19216: URL: https://github.com/apache/pulsar/issues/19216#issuecomment-1384791106 Another one: https://github.com/apache/pulsar/actions/runs/3935561394/jobs/6731481016 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] nodece commented on pull request #19203: [improve][websocket] Add ping support

nodece commented on PR #19203: URL: https://github.com/apache/pulsar/pull/19203#issuecomment-1384789917 Remove `release/2.9.5`, using #19245 instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] nodece commented on pull request #19245: [improve][websocket][branch-2.9] Add ping support

nodece commented on PR #19245: URL: https://github.com/apache/pulsar/pull/19245#issuecomment-1384787257 Hi @poorbarcode, could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] codecov-commenter commented on pull request #19244: [fix][broker] Avoid bundle unload destination broker be set as an inactive broker.

codecov-commenter commented on PR #19244: URL: https://github.com/apache/pulsar/pull/19244#issuecomment-1384787224 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19244?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] nodece opened a new pull request, #19245: [improve][websocket][branch-2.9] Add ping support

nodece opened a new pull request, #19245: URL: https://github.com/apache/pulsar/pull/19245 ### Motivation Cherry-pick https://github.com/apache/pulsar/pull/19203 to branch-2.9. ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed`

[GitHub] [pulsar-client-node] k2la opened a new pull request, #287: Add Versioning Rule to Release process

k2la opened a new pull request, #287: URL: https://github.com/apache/pulsar-client-node/pull/287 ### Motivation The versioning rule of Node.js Client is not explicitly written. ### Modifications Add Versioning Rule to Release process. -- This is an automated message from the

[GitHub] [pulsar] Technoboy- closed pull request #19244: [fix][broker] Avoid bundle unload destination broker be set as an inactive broker.

Technoboy- closed pull request #19244: [fix][broker] Avoid bundle unload destination broker be set as an inactive broker. URL: https://github.com/apache/pulsar/pull/19244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] codecov-commenter commented on pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete

codecov-commenter commented on PR #19242: URL: https://github.com/apache/pulsar/pull/19242#issuecomment-1384772496 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19242?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] nodece merged pull request #19203: [improve][websocket] Add ping support

nodece merged PR #19203: URL: https://github.com/apache/pulsar/pull/19203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui merged pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

codelipenghui merged PR #19138: URL: https://github.com/apache/pulsar/pull/19138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete

poorbarcode commented on code in PR #19242: URL: https://github.com/apache/pulsar/pull/19242#discussion_r1071679627 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/GeoPersistentReplicator.java: ## @@ -184,12 +183,20 @@ protected boolean

[GitHub] [pulsar] github-actions[bot] commented on pull request #18092: [fix][sec]disable trace in web service

github-actions[bot] commented on PR #18092: URL: https://github.com/apache/pulsar/pull/18092#issuecomment-1384743516 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #18966: [Bug] Cannot update functions with Package URL

github-actions[bot] commented on issue #18966: URL: https://github.com/apache/pulsar/issues/18966#issuecomment-1384742460 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] tisonkun commented on issue #19174: [Bug][io] The Alluxio sink fails to write messages out after the first file rotation

tisonkun commented on issue #19174: URL: https://github.com/apache/pulsar/issues/19174#issuecomment-1384683462 @sekikn Thanks for your detailed investigation! Would you submit a patch? I'm glad to give it a review. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] sekikn commented on issue #19174: [Bug][io] The Alluxio sink fails to write messages out after the first file rotation

sekikn commented on issue #19174: URL: https://github.com/apache/pulsar/issues/19174#issuecomment-1384674332 Thank you for the advice @tisonkun! I finally figured out the root cause. Simply put, moving the `optionsBuilder` field to a local variable in the `createTmpFile` method should

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete

mattisonchao commented on code in PR #19242: URL: https://github.com/apache/pulsar/pull/19242#discussion_r1071595107 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/GeoPersistentReplicator.java: ## @@ -184,12 +183,20 @@ protected boolean

[GitHub] [pulsar] andrasbeni commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

andrasbeni commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071554387 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -18,13 +18,30 @@ */ package

[GitHub] [pulsar] nodece commented on pull request #19203: [improve][websocket] Add ping support

nodece commented on PR #19203: URL: https://github.com/apache/pulsar/pull/19203#issuecomment-1384279730 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tisonkun closed issue #10633: broker Write of ledger entry to quorum failed

tisonkun closed issue #10633: broker Write of ledger entry to quorum failed URL: https://github.com/apache/pulsar/issues/10633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] tisonkun commented on issue #10633: broker Write of ledger entry to quorum failed

tisonkun commented on issue #10633: URL: https://github.com/apache/pulsar/issues/10633#issuecomment-1384219417 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun commented on issue #10629: pulsar-client of PulsarOffsetBackingStore should inherit configuration from worker config

tisonkun commented on issue #10629: URL: https://github.com/apache/pulsar/issues/10629#issuecomment-1384219226 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun closed issue #10629: pulsar-client of PulsarOffsetBackingStore should inherit configuration from worker config

tisonkun closed issue #10629: pulsar-client of PulsarOffsetBackingStore should inherit configuration from worker config URL: https://github.com/apache/pulsar/issues/10629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] tisonkun closed issue #10624: Offload Function has java.lang.NoClassDefFoundError: org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader

tisonkun closed issue #10624: Offload Function has java.lang.NoClassDefFoundError: org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader URL: https://github.com/apache/pulsar/issues/10624 -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] tisonkun commented on issue #10624: Offload Function has java.lang.NoClassDefFoundError: org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader

tisonkun commented on issue #10624: URL: https://github.com/apache/pulsar/issues/10624#issuecomment-1384218930 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun commented on issue #10316: Partitions number not equals as expected error in 2.7.1

tisonkun commented on issue #10316: URL: https://github.com/apache/pulsar/issues/10316#issuecomment-1384218550 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun closed issue #10316: Partitions number not equals as expected error in 2.7.1

tisonkun closed issue #10316: Partitions number not equals as expected error in 2.7.1 URL: https://github.com/apache/pulsar/issues/10316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] tisonkun commented on issue #10456: [Enhancement] Serverless(.com) Provider

tisonkun commented on issue #10456: URL: https://github.com/apache/pulsar/issues/10456#issuecomment-1384218279 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun closed issue #10456: [Enhancement] Serverless(.com) Provider

tisonkun closed issue #10456: [Enhancement] Serverless(.com) Provider URL: https://github.com/apache/pulsar/issues/10456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] tisonkun closed issue #10455: discrepancy between persistent and non-persistent topics

tisonkun closed issue #10455: discrepancy between persistent and non-persistent topics URL: https://github.com/apache/pulsar/issues/10455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari commented on issue #19216: Flaky-test: ProxyPrometheusMetricsTest.testMetrics

lhotari commented on issue #19216: URL: https://github.com/apache/pulsar/issues/19216#issuecomment-1384218357 This remains flaky, even after adding Awaitility. example https://github.com/lhotari/pulsar/actions/runs/3931620216/jobs/6723297782#step:11:452 ``` Error: Tests run: 2,

[GitHub] [pulsar] tisonkun commented on issue #10455: discrepancy between persistent and non-persistent topics

tisonkun commented on issue #10455: URL: https://github.com/apache/pulsar/issues/10455#issuecomment-1384218045 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun closed issue #10408: add the ability to set the authMethodName

tisonkun closed issue #10408: add the ability to set the authMethodName URL: https://github.com/apache/pulsar/issues/10408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] tisonkun commented on issue #10408: add the ability to set the authMethodName

tisonkun commented on issue #10408: URL: https://github.com/apache/pulsar/issues/10408#issuecomment-1384217474 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun commented on issue #10298: [Functions] Possible memory leak

tisonkun commented on issue #10298: URL: https://github.com/apache/pulsar/issues/10298#issuecomment-1384216669 Closed as stale. Please create a new issue if it's still relevant to the maintained versions. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] tisonkun closed issue #10298: [Functions] Possible memory leak

tisonkun closed issue #10298: [Functions] Possible memory leak URL: https://github.com/apache/pulsar/issues/10298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] zbentley commented on issue #19196: [Doc] 2.10* docs provide incorrect command for `namespace set-backlog-quota`

zbentley commented on issue #19196: URL: https://github.com/apache/pulsar/issues/19196#issuecomment-1384201904 @tisonkun that would make the command valid, but ideally examples would exist for all three limit cases: just size, just time, and both. -- This is an automated message from the

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1071326907 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1071326907 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] lhotari merged pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

lhotari merged PR #19237: URL: https://github.com/apache/pulsar/pull/19237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    4   5   6   7   8   9   10   11   12   13   >