[GitHub] [pulsar] mattisonchao merged pull request #19240: [fix][broker] Support deleting partitioned topics with the keyword `-partition-` (#19230)

2023-01-16 Thread GitBox
mattisonchao merged PR #19240: URL: https://github.com/apache/pulsar/pull/19240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nodece commented on pull request #19203: [improve][websocket] Add ping support

2023-01-16 Thread GitBox
nodece commented on PR #19203: URL: https://github.com/apache/pulsar/pull/19203#issuecomment-1384035503 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] BewareMyPower commented on pull request #19158: [improve][client] PIP-224 Part 1: Add TopicMessageId for seek and acknowledge

2023-01-16 Thread GitBox
BewareMyPower commented on PR #19158: URL: https://github.com/apache/pulsar/pull/19158#issuecomment-1384038345 @codelipenghui @congbobo184 @eolivelli @hangc0276 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-client-node] BewareMyPower closed issue #284: Document minimum required libstdc++ version

2023-01-16 Thread GitBox
BewareMyPower closed issue #284: Document minimum required libstdc++ version URL: https://github.com/apache/pulsar-client-node/issues/284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar-client-node] BewareMyPower commented on issue #284: Document minimum required libstdc++ version

2023-01-16 Thread GitBox
BewareMyPower commented on issue #284: URL: https://github.com/apache/pulsar-client-node/issues/284#issuecomment-1384024450 I have tested Rocky Linux 8, CentOS 8 with latest master and they both work well. But CentOS 7 is not supported because its highest `GLIBCXX` version is 3.4.19. I've

[GitHub] [pulsar-client-node] BewareMyPower opened a new issue, #286: Support CentOS 7

2023-01-16 Thread GitBox
BewareMyPower opened a new issue, #286: URL: https://github.com/apache/pulsar-client-node/issues/286 ### Motivation The EOL of CentOS 7 is 2024-06-30, see https://wiki.centos.org/About/Product. However, the Node.js client does not support CentOS 7. ### Reproduce First,

[GitHub] [pulsar] Nicklee007 opened a new pull request, #19244: [fix][broker] Avoid bundle unload destination broker be set as an inactive broker.

2023-01-16 Thread GitBox
Nicklee007 opened a new pull request, #19244: URL: https://github.com/apache/pulsar/pull/19244 ### Motivation we should check the `destinationBroker` whether is an inactive broker and reject the unload request when the `destinationBroker` is set as an inactive destination. Otherwise

[GitHub] [pulsar-dotpulsar] entvex opened a new pull request, #133: Cleaned up the entire project using profile "DotPulsar: Full Cleanup"

2023-01-16 Thread GitBox
entvex opened a new pull request, #133: URL: https://github.com/apache/pulsar-dotpulsar/pull/133 # Description Cleaned up the entire project using profile "DotPulsar: Full Cleanup". # Testing Checked that it builds -- This is an automated message from the Apache Git

[GitHub] [pulsar-client-node] BewareMyPower commented on issue #284: Document minimum required libstdc++ version

2023-01-16 Thread GitBox
BewareMyPower commented on issue #284: URL: https://github.com/apache/pulsar-client-node/issues/284#issuecomment-1383945985 #285 fixes the issue for Debian buster, but the libstdc++ version is still too high for RHEL-based distributions. Here are the `GLIBCXX_` symbols from the

[GitHub] [pulsar] codecov-commenter commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

2023-01-16 Thread GitBox
codecov-commenter commented on PR #19237: URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383941922 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

2023-01-16 Thread GitBox
lhotari commented on PR #19237: URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383830109 codecov has a known issue https://github.com/codecov/codecov-action/issues/598 where uploading to codecov might fail with this error ``` [2023-01-16T10:14:31.630Z] ['info']

[GitHub] [pulsar-client-node] shibd commented on issue #281: Failed to create producer: ConnectError when upgrading to 1.8.0

2023-01-16 Thread GitBox
shibd commented on issue #281: URL: https://github.com/apache/pulsar-client-node/issues/281#issuecomment-1383830282 Hi, Let's continue the discussion here. https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1378497083 I build from source code following Master's

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete

2023-01-16 Thread GitBox
poorbarcode commented on code in PR #19242: URL: https://github.com/apache/pulsar/pull/19242#discussion_r1071067949 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/GeoPersistentReplicator.java: ## @@ -152,6 +154,7 @@ protected boolean

[GitHub] [pulsar-client-node] shibd commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-16 Thread GitBox
shibd commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1383818178 It's not a good idea, I'll close it first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar-client-node] shibd closed pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-16 Thread GitBox
shibd closed pull request #282: [fix] Use OAuth2 on macOX arm64 failed. URL: https://github.com/apache/pulsar-client-node/pull/282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] poorbarcode commented on pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete

2023-01-16 Thread GitBox
poorbarcode commented on PR #19242: URL: https://github.com/apache/pulsar/pull/19242#issuecomment-1383818058 @codelipenghui @mattisonchao > Why not only add the pending messages after producer.sendAsync is called? > Why can't we move this line to else branch? Great

[GitHub] [pulsar-client-node] BewareMyPower commented on issue #284: Document minimum required libstdc++ version

2023-01-16 Thread GitBox
BewareMyPower commented on issue #284: URL: https://github.com/apache/pulsar-client-node/issues/284#issuecomment-1383815349 https://github.com/apache/pulsar-client-node/pull/285 might fix this issue, I will perform more verifications in my local env. -- This is an automated message from

[GitHub] [pulsar] lhotari commented on pull request #19161: [improve][misc] Register Jackson Java 8 support modules by default

2023-01-16 Thread GitBox
lhotari commented on PR #19161: URL: https://github.com/apache/pulsar/pull/19161#issuecomment-1383814879 Since a PIP was requested, I have created #19243 which is already in voting since there was already a discussion. -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] lhotari opened a new issue, #19243: PIP-243: Register Jackson Java 8 support modules by default

2023-01-16 Thread GitBox
lhotari opened a new issue, #19243: URL: https://github.com/apache/pulsar/issues/19243 ### Motivation Jackson has a separate Java 8 support modules for adding support for proper serialization and deserialization of new classes that were added in Java 8 (Java 8 was released in 2014).

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19242: [fix] [broker] Counter of pending send messages in Replicator incorrect if schema future not complete

2023-01-16 Thread GitBox
mattisonchao commented on code in PR #19242: URL: https://github.com/apache/pulsar/pull/19242#discussion_r1071052160 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/GeoPersistentReplicator.java: ## @@ -152,6 +154,7 @@ protected boolean

[GitHub] [pulsar] yuruguo commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient

2023-01-16 Thread GitBox
yuruguo commented on PR #19048: URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1383793429 > We should also change the test to point to the new method `newTableView(Schema schema)` > > And we should also add the test for the new added method `newTableView()` Test

[GitHub] [pulsar] lhotari merged pull request #19228: [improve][misc] Follow up on ObjectMapper sharing changes

2023-01-16 Thread GitBox
lhotari merged PR #19228: URL: https://github.com/apache/pulsar/pull/19228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] poorbarcode opened a new pull request, #19242: [fix] [broker] Counter of pending send messages in Replicator incorreā€¦

2023-01-16 Thread GitBox
poorbarcode opened a new pull request, #19242: URL: https://github.com/apache/pulsar/pull/19242 ### Motivation The Replication task execution process works like this: - read messages from the origin cluster - load schema - send to the target cluster Because the network

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #19094: [feat][admin] PIP-219 Part-1 Add admin API for trimming topic

2023-01-16 Thread GitBox
codelipenghui commented on code in PR #19094: URL: https://github.com/apache/pulsar/pull/19094#discussion_r1071017707 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java: ## @@ -3267,6 +3267,44 @@ public void getLastMessageId( }

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #19094: [feat][admin] PIP-219 Part-1 Add admin API for trimming topic

2023-01-16 Thread GitBox
codelipenghui commented on code in PR #19094: URL: https://github.com/apache/pulsar/pull/19094#discussion_r1071001411 ## pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java: ## @@ -3107,4 +3109,15 @@ void run() throws PulsarAdminException {

[GitHub] [pulsar-client-python] BewareMyPower closed issue #64: [Doc] Update the release process about how to release Python client

2023-01-16 Thread GitBox
BewareMyPower closed issue #64: [Doc] Update the release process about how to release Python client URL: https://github.com/apache/pulsar-client-python/issues/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar-client-python] BewareMyPower merged pull request #68: Add the release process for Python client

2023-01-16 Thread GitBox
BewareMyPower merged PR #68: URL: https://github.com/apache/pulsar-client-python/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-16 Thread GitBox
coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1070985106 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] thetumbled commented on pull request #19201: [fix] [broker] fix timeout transaction.

2023-01-16 Thread GitBox
thetumbled commented on PR #19201: URL: https://github.com/apache/pulsar/pull/19201#issuecomment-1383694030 > @thetumbled It looks like the change is not about the issue that you described in the PR details. When reading the motivation of the PR, I thought it was related to the transaction

[GitHub] [pulsar] codelipenghui commented on pull request #19201: [fix] [broker] fix timeout transaction.

2023-01-16 Thread GitBox
codelipenghui commented on PR #19201: URL: https://github.com/apache/pulsar/pull/19201#issuecomment-1383687447 @thetumbled It looks like the change is not about the issue that you described in the PR details. When reading the motivation of the PR, I thought it was related to the

[GitHub] [pulsar] mattisonchao closed pull request #19240: [fix][broker] Support deleting partitioned topics with the keyword `-partition-` (#19230)

2023-01-16 Thread GitBox
mattisonchao closed pull request #19240: [fix][broker] Support deleting partitioned topics with the keyword `-partition-` (#19230) URL: https://github.com/apache/pulsar/pull/19240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] mattisonchao merged pull request #19241: [branch-2.9] Fix compile error caused by cherry-pick #19167.

2023-01-16 Thread GitBox
mattisonchao merged PR #19241: URL: https://github.com/apache/pulsar/pull/19241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] mattisonchao commented on pull request #19240: [fix][broker] Support deleting partitioned topics with the keyword `-partition-` (#19230)

2023-01-16 Thread GitBox
mattisonchao commented on PR #19240: URL: https://github.com/apache/pulsar/pull/19240#issuecomment-1383663480 We need to wait for PR #19241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao opened a new pull request, #19241: [branch-2.9] Fix compile error caused by cherry-pick #19167.

2023-01-16 Thread GitBox
mattisonchao opened a new pull request, #19241: URL: https://github.com/apache/pulsar/pull/19241 ## Motivation Fix compile error caused by cherry-pick #19167 The commit is https://github.com/apache/pulsar/commit/e310713be433e6e36a4191deb74ae8e5d0a03820

[GitHub] [pulsar] mattisonchao opened a new pull request, #19240: [fix][broker] Support deleting partitioned topics with the keyword `-partition-` (#19230)

2023-01-16 Thread GitBox
mattisonchao opened a new pull request, #19240: URL: https://github.com/apache/pulsar/pull/19240 ### Motivation (cherry picked from commit fc4bca6823282c4f5375e5d48552c1f0e114b5ee) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] nodece commented on pull request #19203: [improve][websocket] Add ping support

2023-01-16 Thread GitBox
nodece commented on PR #19203: URL: https://github.com/apache/pulsar/pull/19203#issuecomment-1383636936 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19153: [improve] PIP-241: add TopicEventListener / topic events for the BrokerService

2023-01-16 Thread GitBox
Demogorgon314 commented on code in PR #19153: URL: https://github.com/apache/pulsar/pull/19153#discussion_r1070934942 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -283,6 +286,8 @@ public class BrokerService implements Closeable {

[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

2023-01-16 Thread GitBox
lhotari commented on PR #19237: URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383630982 > @yaalsn Do you remember the reason for doing this? I found this description in #18081 "Except flaky test group to run code coverage, otherwise we cannot get an accurate base

[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

2023-01-16 Thread GitBox
lhotari commented on PR #19237: URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383626356 One more attempt. The coverage profile wasn't activated for the BROKER_FLAKY unit test group:

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-16 Thread GitBox
coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1070929495 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/CombinedSegmentDelayedIndexQueue.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] lhotari merged pull request #19238: Fix flaky test CompactionReaderImplTest(wait until the consumerFuture completes)

2023-01-15 Thread GitBox
lhotari merged PR #19238: URL: https://github.com/apache/pulsar/pull/19238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari closed issue #19214: Flaky-test: CompactionReaderImplTest.test

2023-01-15 Thread GitBox
lhotari closed issue #19214: Flaky-test: CompactionReaderImplTest.test URL: https://github.com/apache/pulsar/issues/19214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] lhotari commented on issue #13923: [Proxy] Race condition in Pulsar Proxy that causes UnsupportedOperationExceptions in Proxy logs

2023-01-15 Thread GitBox
lhotari commented on issue #13923: URL: https://github.com/apache/pulsar/issues/13923#issuecomment-1383604095 One interesting detail is that there's `hasProxyToBrokerUrl: false` when the problem occurs. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar-client-node] BewareMyPower commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-15 Thread GitBox
BewareMyPower commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1383595543 From https://github.com/apache/pulsar-client-node/pull/282#discussion_r1066658153 I see > I tested and the parameter doesn't work if compiled on x86_64.

[GitHub] [pulsar] lhotari commented on issue #13923: [Proxy] Race condition in Pulsar Proxy that causes UnsupportedOperationExceptions in Proxy logs

2023-01-15 Thread GitBox
lhotari commented on issue #13923: URL: https://github.com/apache/pulsar/issues/13923#issuecomment-1383592139 This problem remains. This log message appears in production environments and also in integration tests. recent example in

[GitHub] [pulsar] lhotari opened a new issue, #13923: [Proxy] Race condition in Pulsar Proxy that causes UnsupportedOperationExceptions in Proxy logs

2023-01-15 Thread GitBox
lhotari opened a new issue, #13923: URL: https://github.com/apache/pulsar/issues/13923 **Describe the bug** It is common that UnsupportedOperationExceptions appear on the Proxy logs. This particular issue was reproduced very often when Geo-replication was configured between 2

[GitHub] [pulsar] yuruguo commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient

2023-01-15 Thread GitBox
yuruguo commented on PR #19048: URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1383591669 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-node] BewareMyPower commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-15 Thread GitBox
BewareMyPower commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1383587647 @ericallam Could this error be reproduced by running the following code? ```javascript const Pulsar =

[GitHub] [pulsar] nodece commented on pull request #19203: [improve][websocket] Add ping support

2023-01-15 Thread GitBox
nodece commented on PR #19203: URL: https://github.com/apache/pulsar/pull/19203#issuecomment-1383573526 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari commented on issue #16978: Flaky-test: FilterEntryTest.testEntryFilterRescheduleMessageDependingOnConsumerSharedSubscription

2023-01-15 Thread GitBox
lhotari commented on issue #16978: URL: https://github.com/apache/pulsar/issues/16978#issuecomment-1383556933 Another one https://github.com/apache/pulsar/actions/runs/3927573395/jobs/6714418502#step:11:1062 ``` Error: Tests run: 17, Failures: 1, Errors: 0, Skipped: 16, Time

[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

2023-01-15 Thread GitBox
lhotari commented on PR #19237: URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383527048 > The final codecov result of comparison in PR comment is not accurated because the `master` branch CI should run after every PR merged, but now it doesn't because pulsar's CI runner

[GitHub] [pulsar] yuruguo commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient

2023-01-15 Thread GitBox
yuruguo commented on PR #19048: URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1383518020 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] codecov-commenter commented on pull request #19203: [improve][websocket] Add ping support

2023-01-15 Thread GitBox
codecov-commenter commented on PR #19203: URL: https://github.com/apache/pulsar/pull/19203#issuecomment-1383513716 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19203?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #19204: [improve][broker] Add metric to indicates the max size of managed ledger cache size

2023-01-15 Thread GitBox
gaozhangmin commented on code in PR #19204: URL: https://github.com/apache/pulsar/pull/19204#discussion_r1070836262 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/ManagedLedgerCacheMetrics.java: ## @@ -48,6 +48,7 @@ public synchronized List generate() {

[GitHub] [pulsar] thetumbled commented on pull request #19201: [fix] [broker] fix timeout transaction.

2023-01-15 Thread GitBox
thetumbled commented on PR #19201: URL: https://github.com/apache/pulsar/pull/19201#issuecomment-1383474511 > @thetumbled > >

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-15 Thread GitBox
codelipenghui commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1070803617 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] codecov-commenter commented on pull request #19238: Fix flaky test CompactionReaderImplTest(wait until the consumerFuture completes)

2023-01-15 Thread GitBox
codecov-commenter commented on PR #19238: URL: https://github.com/apache/pulsar/pull/19238#issuecomment-1383423269 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19238?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] yuruguo commented on pull request #19048: [improve][client] Add unified newTableView method in PulsarClient

2023-01-15 Thread GitBox
yuruguo commented on PR #19048: URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1383391121 @poorbarcode @liangyepianzhou I have started a discussion to dev mail and see more in [here](https://lists.apache.org/thread/w6vnk6cxh36j4p8oh9czdqlr5kqhdgb7) -- This is an automated

[GitHub] [pulsar] yaalsn commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

2023-01-15 Thread GitBox
yaalsn commented on PR #19237: URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383363518 The final codecov result of comparison in PR comment is not accurated because the `master` branch CI should run after every PR merged, but now it doesn't because pulsar's CI runner

[GitHub] [pulsar] mattisonchao opened a new issue, #19239: PIP-242: Introduce `enableStrictMode` to reject creating topic with `-partition-` keyword.

2023-01-15 Thread GitBox
mattisonchao opened a new issue, #19239: URL: https://github.com/apache/pulsar/issues/19239 ### Motivation // todo ### Goal // todo ### API Changes // todo ### Implementation // todo ### Alternatives // todo ### Anything

[GitHub] [pulsar] yaalsn commented on pull request #19229: [fix][build] Fix "An error has occurred in JaCoCo report generation"

2023-01-15 Thread GitBox
yaalsn commented on PR #19229: URL: https://github.com/apache/pulsar/pull/19229#issuecomment-1383359156 Thanks! Let's have a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] yaalsn commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

2023-01-15 Thread GitBox
yaalsn commented on PR #19237: URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383356748 It would be better to add `after_n_builds`, thanks for your improvement! After every CI finishes, the codecov will update the result in the comment and its platform, so currently the

[GitHub] [pulsar] github-actions[bot] commented on issue #18959: [enhancement][broker] Introduce thread block monitoring mechnism.

2023-01-15 Thread GitBox
github-actions[bot] commented on issue #18959: URL: https://github.com/apache/pulsar/issues/18959#issuecomment-1383354757 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on pull request #18934: [fix][sql] Fix presto license issue

2023-01-15 Thread GitBox
github-actions[bot] commented on PR #18934: URL: https://github.com/apache/pulsar/pull/18934#issuecomment-1383354792 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #18962: Flaky-test: TopicsTest.cleanup

2023-01-15 Thread GitBox
github-actions[bot] commented on issue #18962: URL: https://github.com/apache/pulsar/issues/18962#issuecomment-1383354724 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] heesung-sn commented on issue #19214: Flaky-test: CompactionReaderImplTest.test

2023-01-15 Thread GitBox
heesung-sn commented on issue #19214: URL: https://github.com/apache/pulsar/issues/19214#issuecomment-1383242917 Sorry for this back-and-forth. I couldn't replicate the issue on my local, but we could try this fix too. Raised another PR: https://github.com/apache/pulsar/pull/19238

[GitHub] [pulsar] heesung-sn opened a new pull request, #19238: Fix flaky test CompactionReaderImplTest(wait until the consumerFuture completes)

2023-01-15 Thread GitBox
heesung-sn opened a new pull request, #19238: URL: https://github.com/apache/pulsar/pull/19238 Fixes https://github.com/apache/pulsar/issues/19214 ### Motivation Fixes https://github.com/apache/pulsar/issues/19214 ### Modifications Wait

[GitHub] [pulsar] heesung-sn commented on issue #19214: Flaky-test: CompactionReaderImplTest.test

2023-01-15 Thread GitBox
heesung-sn commented on issue #19214: URL: https://github.com/apache/pulsar/issues/19214#issuecomment-1383214869 @lhotari I see. will work on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] congbobo184 commented on issue #19169: [Bug][txn] exclusive subscription would lead to high cpu usage when do tailing-read

2023-01-15 Thread GitBox
congbobo184 commented on issue #19169: URL: https://github.com/apache/pulsar/issues/19169#issuecomment-1383208080 oh, sure. I will make https://github.com/apache/pulsar/pull/14286 merge quickly -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] merlimat commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-15 Thread GitBox
merlimat commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1070641969 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +62,50 @@ public static MetadataStoreExtended

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19236: [improve][monitoring]PIP-231: Add `topic_load_failed` metric

2023-01-15 Thread GitBox
congbobo184 commented on code in PR #19236: URL: https://github.com/apache/pulsar/pull/19236#discussion_r1070641433 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java: ## @@ -239,6 +239,14 @@ public void recordTopicLoadTimeValue(String topic, long

[GitHub] [pulsar] congbobo184 commented on pull request #19201: [fix] [broker] fix timeout transaction.

2023-01-15 Thread GitBox
congbobo184 commented on PR #19201: URL: https://github.com/apache/pulsar/pull/19201#issuecomment-1383197970 @thetumbled

[GitHub] [pulsar] nodece commented on a diff in pull request #19203: [improve][websocket] Add ping support

2023-01-15 Thread GitBox
nodece commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1070630222 ## pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPingTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fox codecov reporting by configuring to wait for all builds sending coverage

2023-01-15 Thread GitBox
lhotari commented on PR #19237: URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383160706 Code coverage was activated in #17382 . @yaalsn would you mind reviewing this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] lhotari opened a new pull request, #19237: [fix][ci] Fox codecov reporting by configuring to wait for all builds sending coverage

2023-01-15 Thread GitBox
lhotari opened a new pull request, #19237: URL: https://github.com/apache/pulsar/pull/19237 ### Motivation - currently the codecov reporting processes the uploaded coverage reports too early and thus the coverage result is invalid. - the `after_n_builds` configuration setting

[GitHub] [pulsar] asafm commented on pull request #19047: [improve][broker]PIP-214 Add broker level metrics statistics and expose to prometheus

2023-01-15 Thread GitBox
asafm commented on PR #19047: URL: https://github.com/apache/pulsar/pull/19047#issuecomment-1383158946 @codelipenghui Looks good from my perspective -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar-client-node] BewareMyPower commented on issue #284: Document minimum required libstdc++ version

2023-01-15 Thread GitBox
BewareMyPower commented on issue #284: URL: https://github.com/apache/pulsar-client-node/issues/284#issuecomment-1383152921 > An alternative could be to not dynamically link any dependencies at all Maybe we can link statically to `libstdc++` and `libgcc_s` on Linux for Pulsar C++

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-15 Thread GitBox
poorbarcode commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1070593242 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/CombinedSegmentDelayedIndexQueue.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19203: [improve][websocket] Add ping support

2023-01-15 Thread GitBox
poorbarcode commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1070575855 ## pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPingTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19203: [improve][websocket] Add ping support

2023-01-15 Thread GitBox
poorbarcode commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1070575855 ## pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPingTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pulsar] tjiuming commented on a diff in pull request #19236: [improve][monitoring]PIP-231: Add `topic_load_failed` metric

2023-01-15 Thread GitBox
tjiuming commented on code in PR #19236: URL: https://github.com/apache/pulsar/pull/19236#discussion_r1070571380 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java: ## @@ -239,6 +239,14 @@ public void recordTopicLoadTimeValue(String topic, long

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19236: [improve][monitoring]PIP-231: Add `topic_load_failed` metric

2023-01-15 Thread GitBox
congbobo184 commented on code in PR #19236: URL: https://github.com/apache/pulsar/pull/19236#discussion_r1070568329 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -1176,6 +1176,10 @@ public void

[GitHub] [pulsar] mattisonchao merged pull request #19234: [improve][broker] Follow up #19230 to tighten the validation scope

2023-01-15 Thread GitBox
mattisonchao merged PR #19234: URL: https://github.com/apache/pulsar/pull/19234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Technoboy- merged pull request #19182: [cleanup][broker] Remove AuthorizationProvider methods deprecated in 2.7 and 2.9

2023-01-15 Thread GitBox
Technoboy- merged PR #19182: URL: https://github.com/apache/pulsar/pull/19182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tjiuming commented on pull request #19236: [improve][monitoring]PIP-231: Add `topic_load_failed` metric

2023-01-15 Thread GitBox
tjiuming commented on PR #19236: URL: https://github.com/apache/pulsar/pull/19236#issuecomment-1383118982 Tests to be completed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] tjiuming opened a new pull request, #19236: [improve][monitoring]PIP-231: Add `topic_load_failed` metric

2023-01-15 Thread GitBox
tjiuming opened a new pull request, #19236: URL: https://github.com/apache/pulsar/pull/19236 PIP: https://github.com/apache/pulsar/issues/18979 ### Motivation Add `topic_load_failed` metric ### Does this pull request potentially affect one of the following parts:

[GitHub] [pulsar-site] asafm commented on a diff in pull request #349: [doc][improve] Improve landing page 3 first sections

2023-01-15 Thread GitBox
asafm commented on code in PR #349: URL: https://github.com/apache/pulsar-site/pull/349#discussion_r1070543525 ## src/components/HomepageFeatures.js: ## @@ -4,48 +4,48 @@ import ReactMarkdown from "react-markdown"; const FeatureList = (language) => [ { -title:

[GitHub] [pulsar-site] asafm commented on a diff in pull request #349: [doc][improve] Improve landing page 3 first sections

2023-01-15 Thread GitBox
asafm commented on code in PR #349: URL: https://github.com/apache/pulsar-site/pull/349#discussion_r1070543002 ## src/components/HomepageFeatures.js: ## @@ -4,48 +4,48 @@ import ReactMarkdown from "react-markdown"; const FeatureList = (language) => [ { -title:

[GitHub] [pulsar-site] asafm commented on pull request #349: [doc][improve] Improve landing page 3 first sections

2023-01-15 Thread GitBox
asafm commented on PR #349: URL: https://github.com/apache/pulsar-site/pull/349#issuecomment-1383097360 > I'm not sure the best format for this discussion, but in my opinion, I think we need to discuss the motivation for changing the top level feature list @DaveDuggins. There are some

[GitHub] [pulsar-site] asafm commented on pull request #349: [doc][improve] Improve landing page 3 first sections

2023-01-15 Thread GitBox
asafm commented on PR #349: URL: https://github.com/apache/pulsar-site/pull/349#issuecomment-1383096720 > > @DaveDuggins, Can you please change the title and summary to reflect the content and intent of this PR? I think another PR you had got the description and title mixed into here by

[GitHub] [pulsar] asafm commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-15 Thread GitBox
asafm commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1070531001 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -18,13 +18,30 @@ */ package org.apache.pulsar.metadata.impl;

[GitHub] [pulsar] BewareMyPower commented on issue #19122: no org_apache_pulsar_shade_netty_tcnative_x86_64 in java.library.path

2023-01-15 Thread GitBox
BewareMyPower commented on issue #19122: URL: https://github.com/apache/pulsar/issues/19122#issuecomment-1383086830 No. But I think we should. The only reason that Pulsar cannot run on Windows is that RocksDB, which is depended by BookKeeper, cannot run on Windows. I have debugged

[GitHub] [pulsar] BewareMyPower commented on pull request #19147: [fix][broker] catch exception for brokerInterceptor

2023-01-15 Thread GitBox
BewareMyPower commented on PR #19147: URL: https://github.com/apache/pulsar/pull/19147#issuecomment-1383085731 @Jason918 It's not related to whether the interceptor developers are core developers of Pulsar. It's related to the fact that there is no clear definition in Pulsar about how the

[GitHub] [pulsar] codecov-commenter commented on pull request #19235: [fix][broker] Support getStats/update partitioned topic with `-partition-`

2023-01-14 Thread GitBox
codecov-commenter commented on PR #19235: URL: https://github.com/apache/pulsar/pull/19235#issuecomment-1383068884 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19235?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] Technoboy- merged pull request #19206: [branch-2.11][cherry-pick] Elasticsearch sink: Support loading config from secrets

2023-01-14 Thread GitBox
Technoboy- merged PR #19206: URL: https://github.com/apache/pulsar/pull/19206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Technoboy- merged pull request #19205: [branch-2.11][cherry-pick] Debezium sources: Support loading config from secrets

2023-01-14 Thread GitBox
Technoboy- merged PR #19205: URL: https://github.com/apache/pulsar/pull/19205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] yuruguo opened a new pull request, #19235: [fix][broker] Support getStats/update partitioned topic with `-partition-`

2023-01-14 Thread GitBox
yuruguo opened a new pull request, #19235: URL: https://github.com/apache/pulsar/pull/19235 ### Motivation Same as #19230, We allow users to use the `Client API` to create the partitioned topic which name contain `-partition-{not-number}` when they enable partitioned type auto-creation.

[GitHub] [pulsar] Technoboy- closed pull request #19205: [branch-2.11][cherry-pick] Debezium sources: Support loading config from secrets

2023-01-14 Thread GitBox
Technoboy- closed pull request #19205: [branch-2.11][cherry-pick] Debezium sources: Support loading config from secrets URL: https://github.com/apache/pulsar/pull/19205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] Technoboy- closed pull request #19206: [branch-2.11][cherry-pick] Elasticsearch sink: Support loading config from secrets

2023-01-14 Thread GitBox
Technoboy- closed pull request #19206: [branch-2.11][cherry-pick] Elasticsearch sink: Support loading config from secrets URL: https://github.com/apache/pulsar/pull/19206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] Technoboy- merged pull request #19232: [branch-2.11][ci] Fix license check issue

2023-01-14 Thread GitBox
Technoboy- merged PR #19232: URL: https://github.com/apache/pulsar/pull/19232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    5   6   7   8   9   10   11   12   13   14   >