[GitHub] [pulsar] AnonHxy commented on a diff in pull request #21078: [fix] [broker] remove bundle-data in local metadata store.

AnonHxy commented on code in PR #21078: URL: https://github.com/apache/pulsar/pull/21078#discussion_r1309956066 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/NamespaceResources.java: ## @@ -49,16 +49,18 @@ public class NamespaceResources extends

[GitHub] [pulsar] michalcukierman commented on issue #21082: [Bug] one topic suddenly cannot be consumed,others is ok

michalcukierman commented on issue #21082: URL: https://github.com/apache/pulsar/issues/21082#issuecomment-1698836870 I can reproduce the issue on my system now. Using build from master from Monday. I have a topic using `3` partitions with `1100013` messages. The client and the

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #21048: [fix][client] Fix cannot retry chunk messages and send to DLQ

poorbarcode commented on code in PR #21048: URL: https://github.com/apache/pulsar/pull/21048#discussion_r1310025536 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java: ## @@ -695,6 +695,12 @@ private void serializeAndSendMessage(MessageImpl msg,

[GitHub] [pulsar] thetumbled commented on a diff in pull request #21085: [improve] [broker] apply topK machanism to ModularLoadManagerImpl.

thetumbled commented on code in PR #21085: URL: https://github.com/apache/pulsar/pull/21085#discussion_r1310047764 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/BundleDataComparator.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #21048: [fix][client] Fix cannot retry chunk messages and send to DLQ

poorbarcode commented on code in PR #21048: URL: https://github.com/apache/pulsar/pull/21048#discussion_r1310047869 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageTracker.java: ## @@ -138,8 +138,11 @@ public void run(Timeout t) throws Exception {

[GitHub] [pulsar] tisonkun merged pull request #21090: [fix][build] Upgrade Guava to 32.1.2-jre

tisonkun merged PR #21090: URL: https://github.com/apache/pulsar/pull/21090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #21048: [fix][client] Fix cannot retry chunk messages and send to DLQ

codelipenghui commented on code in PR #21048: URL: https://github.com/apache/pulsar/pull/21048#discussion_r1310127584 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java: ## @@ -46,6 +47,7 @@ import org.slf4j.LoggerFactory; import

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #21048: [fix][client] Fix cannot retry chunk messages and send to DLQ

poorbarcode commented on code in PR #21048: URL: https://github.com/apache/pulsar/pull/21048#discussion_r1309965178 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java: ## @@ -154,28 +170,42 @@ public void testDeadLetterTopic() throws Exception

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #21048: [fix][client] Fix cannot retry chunk messages and send to DLQ

poorbarcode commented on code in PR #21048: URL: https://github.com/apache/pulsar/pull/21048#discussion_r1309965629 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java: ## @@ -154,28 +170,42 @@ public void testDeadLetterTopic() throws Exception

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #20948: [fix][broker]Fix chunked messages will be filtered by duplicating

BewareMyPower commented on code in PR #20948: URL: https://github.com/apache/pulsar/pull/20948#discussion_r1310130118 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -1459,6 +1460,29 @@ private ByteBuf processMessageChunk(ByteBuf

[GitHub] [pulsar] Shawyeok opened a new pull request, #21094: [fix][client] Fix logging problem in pulsar client

Shawyeok opened a new pull request, #21094: URL: https://github.com/apache/pulsar/pull/21094 ### Modifications - Fix wrong order of the parameters in the error message when unsubscribe failed. - Log `Could not get connection while getLastMessageId -- Will try again in {}

[GitHub] [pulsar] thetumbled commented on a diff in pull request #21085: [improve] [broker] apply topK machanism to ModularLoadManagerImpl.

thetumbled commented on code in PR #21085: URL: https://github.com/apache/pulsar/pull/21085#discussion_r1310155909 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java: ## @@ -1139,6 +1145,30 @@ public void

[GitHub] [pulsar] thetumbled commented on a diff in pull request #21078: [fix] [broker] remove bundle-data in local metadata store.

thetumbled commented on code in PR #21078: URL: https://github.com/apache/pulsar/pull/21078#discussion_r1309892997 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java: ## @@ -1740,6 +1750,20 @@ public void testDeleteNamespace(NamespaceAttr

[GitHub] [pulsar] tisonkun commented on pull request #21090: [fix][build] Upgrade Guava to 32.1.2-jre

tisonkun commented on PR #21090: URL: https://github.com/apache/pulsar/pull/21090#issuecomment-1698741974 I think we're good at merging this patch. But perhaps I'll ping some more reviewers and wait a bit. Guava is a fundamental dependency while we only bump a patch version we may

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #21078: [fix] [broker] remove bundle-data in local metadata store.

Demogorgon314 commented on code in PR #21078: URL: https://github.com/apache/pulsar/pull/21078#discussion_r1309980016 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java: ## @@ -1713,13 +1714,21 @@ private void setNamespaceAttr(NamespaceAttr

[GitHub] [pulsar] Technoboy- opened a new pull request, #21093: [fix][broker] Fix deleting topic not delete the related topic policy and schema.

Technoboy- opened a new pull request, #21093: URL: https://github.com/apache/pulsar/pull/21093 Fixes #21075 ### Motivation ### Modifications ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #21085: [improve] [broker] apply topK machanism to ModularLoadManagerImpl.

Demogorgon314 commented on code in PR #21085: URL: https://github.com/apache/pulsar/pull/21085#discussion_r1310027075 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/models/TopKBundles.java: ## @@ -132,6 +133,42 @@ static void partitionSort(List>

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #21048: [fix][client] Fix cannot retry chunk messages and send to DLQ

poorbarcode commented on code in PR #21048: URL: https://github.com/apache/pulsar/pull/21048#discussion_r1310025536 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java: ## @@ -695,6 +695,12 @@ private void serializeAndSendMessage(MessageImpl msg,

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #20948: [fix][broker]Fix chunked messages will be filtered by duplicating

BewareMyPower commented on code in PR #20948: URL: https://github.com/apache/pulsar/pull/20948#discussion_r1310154051 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingSharedTest.java: ## @@ -211,6 +214,116 @@ private static String

[GitHub] [pulsar] tisonkun commented on pull request #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile

tisonkun commented on PR #21062: URL: https://github.com/apache/pulsar/pull/21062#issuecomment-1699105079 Merging... Keep going @JooHyukKim! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] tisonkun merged pull request #21062: [refactor][cli][PIP-280] Add missing `pulsar-cli-utils` module registration in Maven `core-modules` profile

tisonkun merged PR #21062: URL: https://github.com/apache/pulsar/pull/21062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-dotpulsar] tisonkun commented on issue #117: Publish releases instead of tags for stable versions

tisonkun commented on issue #117: URL: https://github.com/apache/pulsar-dotpulsar/issues/117#issuecomment-1698710180 https://github.com/apache/logging-log4j-tools/blob/95a85e350445b95b1a0ea4c1aa92572945af3410/.github/workflows/build.yml#L80 The Log4j project developed a workflow to

[GitHub] [pulsar] tisonkun commented on pull request #21090: [fix][build] Upgrade Guava to 32.1.2-jre

tisonkun commented on PR #21090: URL: https://github.com/apache/pulsar/pull/21090#issuecomment-1698740401 ``` Error: One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '7.0': Error: Error:

[GitHub] [pulsar-helm-chart] olsenpabu opened a new issue, #390: Pulsar Manager Error 404 - Missing CSRF Token

olsenpabu opened a new issue, #390: URL: https://github.com/apache/pulsar-helm-chart/issues/390 **Describe the bug** Using Helm chart to deploy pulsar manager. All pods are up and running. When accessing pulsar manager it throws missing CSRF Token. **To Reproduce** Steps to

[GitHub] [pulsar] RobertIndie commented on pull request #21048: [fix][client] Fix cannot retry chunk messages and send to DLQ

RobertIndie commented on PR #21048: URL: https://github.com/apache/pulsar/pull/21048#issuecomment-1698842753 Hi, @poorbarcode , I have added the timeout of receive opeartion for the test. PTAL again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #21085: [improve] [broker] apply topK machanism to ModularLoadManagerImpl.

Demogorgon314 commented on code in PR #21085: URL: https://github.com/apache/pulsar/pull/21085#discussion_r1310063331 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/BundleDataComparator.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [pulsar] RobertIndie commented on a diff in pull request #21048: [fix][client] Fix cannot retry chunk messages and send to DLQ

RobertIndie commented on code in PR #21048: URL: https://github.com/apache/pulsar/pull/21048#discussion_r1310244529 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java: ## @@ -46,6 +47,7 @@ import org.slf4j.LoggerFactory; import

[GitHub] [pulsar] RobertIndie commented on a diff in pull request #21048: [fix][client] Fix cannot retry chunk messages and send to DLQ

RobertIndie commented on code in PR #21048: URL: https://github.com/apache/pulsar/pull/21048#discussion_r1310245279 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageTracker.java: ## @@ -138,8 +138,11 @@ public void run(Timeout t) throws Exception {

[GitHub] [pulsar] thetumbled commented on a diff in pull request #21085: [improve] [broker] apply topK machanism to ModularLoadManagerImpl.

thetumbled commented on code in PR #21085: URL: https://github.com/apache/pulsar/pull/21085#discussion_r1310051180 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java: ## @@ -1139,6 +1145,30 @@ public void

[GitHub] [pulsar-client-cpp] armanjupriya-er commented on pull request #257: Support get the SchemaInfo from a topic and the schema version

armanjupriya-er commented on PR #257: URL: https://github.com/apache/pulsar-client-cpp/pull/257#issuecomment-1698924826 @BewareMyPower : Can this PR be back merged to Pulsar 2.10 CPP client? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #21048: [fix][client] Fix cannot retry chunk messages and send to DLQ

poorbarcode commented on code in PR #21048: URL: https://github.com/apache/pulsar/pull/21048#discussion_r1310003210 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java: ## @@ -46,6 +47,7 @@ import org.slf4j.LoggerFactory; import

[GitHub] [pulsar] thetumbled commented on a diff in pull request #21078: [fix] [broker] remove bundle-data in local metadata store.

thetumbled commented on code in PR #21078: URL: https://github.com/apache/pulsar/pull/21078#discussion_r1309984217 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java: ## @@ -1713,13 +1714,21 @@ private void setNamespaceAttr(NamespaceAttr

[GitHub] [pulsar] thetumbled commented on a diff in pull request #21085: [improve] [broker] apply topK machanism to ModularLoadManagerImpl.

thetumbled commented on code in PR #21085: URL: https://github.com/apache/pulsar/pull/21085#discussion_r1310141718 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/models/TopKBundles.java: ## @@ -132,6 +133,42 @@ static void partitionSort(List>

[GitHub] [pulsar] yuandao1990 opened a new pull request, #21133: Feature/test

yuandao1990 opened a new pull request, #21133: URL: https://github.com/apache/pulsar/pull/21133 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change

[GitHub] [pulsar] github-actions[bot] commented on pull request #21133: Feature/test

github-actions[bot] commented on PR #21133: URL: https://github.com/apache/pulsar/pull/21133#issuecomment-1706471871 @yuandao1990 Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [

[GitHub] [pulsar] shibd commented on issue #21088: [Bug] Sink Connector not respecting client.conf brokerServiceUrl

shibd commented on issue #21088: URL: https://github.com/apache/pulsar/issues/21088#issuecomment-1706592323 @Mortom123 You should use `./pulsar-admin sinks localrun --broker-service-url xxx`. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] shibd commented on issue #21088: [Bug] Sink Connector not respecting client.conf brokerServiceUrl

shibd commented on issue #21088: URL: https://github.com/apache/pulsar/issues/21088#issuecomment-1706704211 oh, In your case. Even if you configure the correct broker address in time, it will not work. Because the broker lookup returns a result of 127.0.0.1. So you get an

[GitHub] [pulsar] codelipenghui commented on pull request #21077: [fix][proxy] Fix Proxy 502 gateway error when it is configured with Keystore TLS and admin API is called

codelipenghui commented on PR #21077: URL: https://github.com/apache/pulsar/pull/21077#issuecomment-1706531474 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Shuimo03 commented on issue #21115: [Bug] Apache Pulsar :: Docker Images :: Pulsar Latest Version FAILUR

Shuimo03 commented on issue #21115: URL: https://github.com/apache/pulsar/issues/21115#issuecomment-170662 means replacing the docker source with ali? for example, modified file that /etc/docker/damon.json? If that's the case, I recommend using "registry-mirrors": [

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #21107: [fix][misc] Fix bugs in hash bucket algorithm implementation in Pulsar collections

codelipenghui commented on code in PR #21107: URL: https://github.com/apache/pulsar/pull/21107#discussion_r1315899927 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/collections/ConcurrentLongLongPairHashMap.java: ## @@ -322,15 +324,15 @@ private static final class

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #21107: [fix][misc] Fix bugs in hash bucket algorithm implementation in Pulsar collections

codelipenghui commented on code in PR #21107: URL: https://github.com/apache/pulsar/pull/21107#discussion_r1315906178 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/collections/ConcurrentOpenHashSet.java: ## @@ -598,8 +598,14 @@ static final long hash(K key) {

[GitHub] [pulsar] Mortom123 commented on issue #21088: [Bug] Sink Connector not respecting client.conf brokerServiceUrl

Mortom123 commented on issue #21088: URL: https://github.com/apache/pulsar/issues/21088#issuecomment-1706743367 Thanks @shibd I'm unsure whether I understand you correctly or not. I'm **not** running the broker in the standalone mode but instead in cluster mode. Does it still load the

[GitHub] [pulsar] poorbarcode opened a new pull request, #21134: [fix] [broker] Revert #19446 to fix the send message future never complete

poorbarcode opened a new pull request, #21134: URL: https://github.com/apache/pulsar/pull/21134 ### Motivation Before #19446 If producer sending and topic unloading are executed at the same time, there are three scenarios: - The Broker receives the send command before

[GitHub] [pulsar] hangc0276 opened a new pull request, #21130: [improve] [bookie] Enable forceAllowCompaction by default

hangc0276 opened a new pull request, #21130: URL: https://github.com/apache/pulsar/pull/21130 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation When the ledger disk usage reaches 95%, the bookie will run into

[GitHub] [pulsar] Mortom123 commented on issue #21088: [Bug] Sink Connector not respecting client.conf brokerServiceUrl

Mortom123 commented on issue #21088: URL: https://github.com/apache/pulsar/issues/21088#issuecomment-1706629282 @shibd thanks for the advice. I tried: ``` root@fe41c5f74637:/pulsar/bin# ./pulsar-admin sinks localrun --broker-service-url pulsar://broker:6650 --tenant public

[GitHub] [pulsar] codecov-commenter commented on pull request #21077: [fix][proxy] Fix Proxy 502 gateway error when it is configured with Keystore TLS and admin API is called

codecov-commenter commented on PR #21077: URL: https://github.com/apache/pulsar/pull/21077#issuecomment-1706657853 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21077?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging

[GitHub] [pulsar] codelipenghui commented on pull request #21110: [fix] [broker] concurrent write and iterate with ConcurrentLongLongPairHashMap.

codelipenghui commented on PR #21110: URL: https://github.com/apache/pulsar/pull/21110#issuecomment-1706707456 Given the benchmark results provided in the [link](https://github.com/apache/pulsar/pull/20647#issuecomment-1607257960), it seems prudent to consider replacing the customized

[GitHub] [pulsar-site] tisonkun merged pull request #696: [improve][site]reset project version

tisonkun merged PR #696: URL: https://github.com/apache/pulsar-site/pull/696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] mattisonchao commented on pull request #21098: [branch-2.10] [fix] [broker] Fix isolated group not work problem.

mattisonchao commented on PR #21098: URL: https://github.com/apache/pulsar/pull/21098#issuecomment-1706828192 Please wait for this PR to fix some tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] hangc0276 opened a new pull request, #21131: [improve] [bookie] Change flushEntrylogBytes default value from 256MB to 32MB

hangc0276 opened a new pull request, #21131: URL: https://github.com/apache/pulsar/pull/21131 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation We set `flushEntrylogBytes` to 256MB in

[GitHub] [pulsar] github-actions[bot] commented on pull request #21131: [improve] [bookie] Change flushEntrylogBytes default value from 256MB to 32MB

github-actions[bot] commented on PR #21131: URL: https://github.com/apache/pulsar/pull/21131#issuecomment-1706412443 @hangc0276 Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ]

[GitHub] [pulsar] mattisonchao opened a new pull request, #21135: [branch-2.10] Fix flaky test

mattisonchao opened a new pull request, #21135: URL: https://github.com/apache/pulsar/pull/21135 ### Motivation Fix flaky tests of branch-2.10 ### Modifications - `testBatchMessageWithNullValue` ### Verifying this change - [x] Make sure that the change

[GitHub] [pulsar] poorbarcode commented on pull request #19446: [fix][broker] Expect msgs after server initiated CloseProducer

poorbarcode commented on PR #19446: URL: https://github.com/apache/pulsar/pull/19446#issuecomment-1706786085 @michaeljmarshall https://github.com/apache/pulsar/pull/19446/files#diff-1e0e8195fb5ec5a6d79acbc7d859c025a9b711f94e6ab37c94439e99b3202e84R1627-R1635 This leading the send

[GitHub] [pulsar] michaeljmarshall commented on pull request #21134: [fix] [broker] Revert #19446 to fix the send message future never complete

michaeljmarshall commented on PR #21134: URL: https://github.com/apache/pulsar/pull/21134#issuecomment-1706823067 > After #19446, scenario 2 changed > > * The Broker receives the send command after unloading the topic > > * Broker discards this send command

[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #692: Add a recap for Apache Pulsar Sessions in CommunityOverCode Asia 2023

tisonkun commented on code in PR #692: URL: https://github.com/apache/pulsar-site/pull/692#discussion_r1316067953 ## blog/2023-08-28-pulsar-sessions-in-communityovercode-aisa-2023.md: ## @@ -0,0 +1,54 @@ +--- +author: tison +title: "Recap: Apache Pulsar Sessions in

[GitHub] [pulsar-site] liangyepianzhou opened a new pull request, #696: [improve][site]reset project version

liangyepianzhou opened a new pull request, #696: URL: https://github.com/apache/pulsar-site/pull/696 This PR adds doc for #xyz This PR fixes #xyz - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [x] `doc-complete` --

[GitHub] [pulsar] codelipenghui commented on pull request #21107: [fix][misc] Fix bugs in hash bucket algorithm implementation in Pulsar collections

codelipenghui commented on PR #21107: URL: https://github.com/apache/pulsar/pull/21107#issuecomment-1706710445 I also left a [comment](https://github.com/apache/pulsar/pull/21110#issuecomment-1706707456) on another related PR. Maybe we should consider to replace the customized map with

[GitHub] [pulsar-site] codelipenghui commented on pull request #696: [improve][site]reset project version

codelipenghui commented on PR #696: URL: https://github.com/apache/pulsar-site/pull/696#issuecomment-1706719367 > Thank you! I'm curious what changes cause the necessity of this extra step.. I guess someone may have built a distribution using the branch, resulting in a release with

[GitHub] [pulsar] Technoboy- merged pull request #21077: [fix][proxy] Fix Proxy 502 gateway error when it is configured with Keystore TLS and admin API is called

Technoboy- merged PR #21077: URL: https://github.com/apache/pulsar/pull/21077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Technoboy- closed issue #21076: [Bug] Pulsar Proxy returns 502 Gateway error when Keystore TLS is enabled on Proxy and Admin API is utilized

Technoboy- closed issue #21076: [Bug] Pulsar Proxy returns 502 Gateway error when Keystore TLS is enabled on Proxy and Admin API is utilized URL: https://github.com/apache/pulsar/issues/21076 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] thetumbled commented on issue #21113: [Bug] [broker] concurrent write and iterate with ConcurrentLongLongPairHashMap V2.

thetumbled commented on issue #21113: URL: https://github.com/apache/pulsar/issues/21113#issuecomment-1704060793 Actually, there chances that results contain two mapping pair with the same key, with same value. Uncomment code ``` // with same value

[GitHub] [pulsar-site] zuobiao-zhou commented on pull request #681: [improve][doc] SEO for deployment

zuobiao-zhou commented on PR #681: URL: https://github.com/apache/pulsar-site/pull/681#issuecomment-1704077172 updated, PTAL @Anonymitaet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-site] zuobiao-zhou commented on pull request #683: [improve][doc] SEO for Transactions

zuobiao-zhou commented on PR #683: URL: https://github.com/apache/pulsar-site/pull/683#issuecomment-1704077227 updated, PTAL @Anonymitaet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] hzh0425 closed pull request #21114: [improve] [pip] PIP

hzh0425 closed pull request #21114: [improve] [pip] PIP URL: https://github.com/apache/pulsar/pull/21114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pulsar] github-actions[bot] commented on pull request #21114: [improve] [pip] PIP

github-actions[bot] commented on PR #21114: URL: https://github.com/apache/pulsar/pull/21114#issuecomment-1704339009 @hzh0425 Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ]

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #21033: [improve][pip] Replace reader with table view in the topic policy service

Technoboy- commented on code in PR #21033: URL: https://github.com/apache/pulsar/pull/21033#discussion_r1314252440 ## pip/pip-284.md: ## @@ -0,0 +1,114 @@ +# Background knowledge + +Apache Pulsar introduced the topic-level policies by

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #21033: [improve][pip] Replace reader with table view in the topic policy service

mattisonchao commented on code in PR #21033: URL: https://github.com/apache/pulsar/pull/21033#discussion_r1314259139 ## pip/pip-284.md: ## @@ -0,0 +1,114 @@ +# Background knowledge + +Apache Pulsar introduced the topic-level policies by

[GitHub] [pulsar] mattisonchao merged pull request #21033: [improve][pip] Replace reader with table view in the topic policy service

mattisonchao merged PR #21033: URL: https://github.com/apache/pulsar/pull/21033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] zuobiao-zhou commented on pull request #693: [improve][doc] SEO for Administration

zuobiao-zhou commented on PR #693: URL: https://github.com/apache/pulsar-site/pull/693#issuecomment-1704077332 Updated, PTAL @Anonymitaet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-site] zuobiao-zhou commented on pull request #684: [improve][doc] SEO for Tiered Storage

zuobiao-zhou commented on PR #684: URL: https://github.com/apache/pulsar-site/pull/684#issuecomment-1704077275 Updated, PTAL @Anonymitaet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] thetumbled opened a new issue, #21113: [Bug] [broker] concurrent write and iterate with ConcurrentLongLongPairHashMap V2.

thetumbled opened a new issue, #21113: URL: https://github.com/apache/pulsar/issues/21113 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version all. ### Minimal reproduce step

[GitHub] [pulsar-site] zuobiao-zhou commented on a diff in pull request #693: [improve][doc] SEO for Administration

zuobiao-zhou commented on code in PR #693: URL: https://github.com/apache/pulsar-site/pull/693#discussion_r1314210657 ## docs/administration-zk-bk.md: ## @@ -268,7 +274,12 @@ In Pulsar, you can set *persistence policies* at the namespace level, which dete You can set

[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #309: Avoid calling serializeSingleMessageInBatchWithPayload each time a message is added

BewareMyPower merged PR #309: URL: https://github.com/apache/pulsar-client-cpp/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] hzh0425 opened a new pull request, #21114: [improve] [pip] PIP

hzh0425 opened a new pull request, #21114: URL: https://github.com/apache/pulsar/pull/21114 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change - [

[GitHub] [pulsar] hzh0425 commented on pull request #21114: [improve] [pip] PIP-298 Consumer supports specifying consumption isolation level

hzh0425 commented on PR #21114: URL: https://github.com/apache/pulsar/pull/21114#issuecomment-1704340501 @liangyepianzhou pls cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] github-actions[bot] commented on issue #20857: [improve] [replication] Replicate messages in batches to improve performance

github-actions[bot] commented on issue #20857: URL: https://github.com/apache/pulsar/issues/20857#issuecomment-1703983758 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] poorbarcode commented on pull request #21134: [fix] [broker] Revert #19446 to fix the send message future never complete

poorbarcode commented on PR #21134: URL: https://github.com/apache/pulsar/pull/21134#issuecomment-1706964054 @michaeljmarshall > What version of the Java client are you using? It should be `2.9.x` or `2.10.x`. I need to reconfirm it with my colleague > The client is

[GitHub] [pulsar] redoc123 commented on issue #21104: [Bug] Client with shared subscription is blocked

redoc123 commented on issue #21104: URL: https://github.com/apache/pulsar/issues/21104#issuecomment-1706969773 you said 1 million messages right? Could you post your sample payload? I want to reproduce and debug. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] poorbarcode commented on pull request #21134: [fix] [broker] Revert #19446 to fix the send message future never complete

poorbarcode commented on PR #21134: URL: https://github.com/apache/pulsar/pull/21134#issuecomment-1707038520 @michaeljmarshall > As far as I can tell, messages are not actually removed from pendingMessages until they are ack'd, timedout, or get an error from the broker. After

[GitHub] [pulsar] michaeljmarshall commented on pull request #21134: [fix] [broker] Revert #19446 to fix the send message future never complete

michaeljmarshall commented on PR #21134: URL: https://github.com/apache/pulsar/pull/21134#issuecomment-1706998307 I am working from my memory here, but I'm pretty sure this is the way it ought to work. > the msg won't be resend because the pending ops queue is empty Messages

[GitHub] [pulsar] poorbarcode commented on pull request #21134: [draft] [fix] [broker] Revert #19446 to fix the send message future never complete

poorbarcode commented on PR #21134: URL: https://github.com/apache/pulsar/pull/21134#issuecomment-1707054012 @michaeljmarshall Thanks for your explanation. I'll sum it up tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] Apurva007 commented on pull request #21077: [fix][proxy] Fix Proxy 502 gateway error when it is configured with Keystore TLS and admin API is called

Apurva007 commented on PR #21077: URL: https://github.com/apache/pulsar/pull/21077#issuecomment-1707302598 @Technoboy- / @codelipenghui Thanks for the review! I really appreciate it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] michaeljmarshall commented on pull request #21134: [fix] [broker] Revert #19446 to fix the send message future never complete

michaeljmarshall commented on PR #21134: URL: https://github.com/apache/pulsar/pull/21134#issuecomment-1706999735 > If hit the `issue-1` above, I think the producer will get stuck. Is it possible to set up a test to show that this is true? -- This is an automated message from the

[GitHub] [pulsar] redoc123 edited a discussion: how to enable mTLS for multiple clients on same broker

GitHub user redoc123 edited a discussion: how to enable mTLS for multiple clients on same broker As per documentation, you can configure only a single client certificate in broker.conf \#configure mTLS for the internal client brokerClientTlsEnabled=true

[GitHub] [pulsar] heesung-sn commented on pull request #21129: [improve][pip] PIP-301: Introduce LoadBalanceResources to unify the load-date CRUD

heesung-sn commented on PR #21129: URL: https://github.com/apache/pulsar/pull/21129#issuecomment-1706958175 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] michaeljmarshall commented on pull request #21134: [fix] [broker] Revert #19446 to fix the send message future never complete

michaeljmarshall commented on PR #21134: URL: https://github.com/apache/pulsar/pull/21134#issuecomment-1706958070 > org.apache.pulsar.client.api.PulsarClientException$TimeoutException: The producer service-TestProducer-02586a can not send message to the topic

[GitHub] [pulsar] codecov-commenter commented on pull request #21091: [fix][broker] Avoid splitting one batch message into two entries in StrategicTwoPhaseCompactor

codecov-commenter commented on PR #21091: URL: https://github.com/apache/pulsar/pull/21091#issuecomment-1704514850 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21091?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging

[GitHub] [pulsar] mattisonchao commented on pull request #21078: [fix] [broker] remove bundle-data in local metadata store.

mattisonchao commented on PR #21078: URL: https://github.com/apache/pulsar/pull/21078#issuecomment-1704524226 Btw, I suggest we move this logic out of the namespace resource. Because we didn't create bundle data in NamespaceResource but deleted it there, it's weird. -- This is an

[GitHub] [pulsar] poorbarcode opened a new pull request, #21116: [fix] [cli] Fix repeat consume when using n-ack and batched messages

poorbarcode opened a new pull request, #21116: URL: https://github.com/apache/pulsar/pull/21116 ### Motivation Consumers will filter out the messages maintained by `AcknowledgmentsGroupingTracker`, but there is no implementation for batched messages. ### Modifications

[GitHub] [pulsar-client-go] gunli commented on issue #1088: [Improve] Rename `DisableBlockIfQueueFull` to `BlockIfQueueFull` as JAVA client and have the same default value

gunli commented on issue #1088: URL: https://github.com/apache/pulsar-client-go/issues/1088#issuecomment-1704553103 Hi @RobertIndie @shibd , would you please check if improve issue is acceptable, if it is accepted, I will summit a PR to make it done. -- This is an automated message from

[GitHub] [pulsar] equanz commented on a diff in pull request #20776: [pip][design] PIP-282: Change definition of the recently joined consumers position

equanz commented on code in PR #20776: URL: https://github.com/apache/pulsar/pull/20776#discussion_r1314434346 ## pip/pip-282.md: ## @@ -0,0 +1,293 @@ +# Background knowledge + +Key_Shared is one of the subscription types which allows multiple consumer connections. +Messages

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #21087: [fix][broker] revert remove duplicate topics name when deleteNamespace

codelipenghui commented on code in PR #21087: URL: https://github.com/apache/pulsar/pull/21087#discussion_r1314451134 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java: ## @@ -279,12 +279,6 @@ private void

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #21085: [improve] [broker] apply topK machanism to ModularLoadManagerImpl.

codelipenghui commented on code in PR #21085: URL: https://github.com/apache/pulsar/pull/21085#discussion_r1314485905 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java: ## @@ -1139,6 +1143,29 @@ public void

[GitHub] [pulsar] horizonzy commented on pull request #21096: [fix] [broker] Fix isolated group not work problem.

horizonzy commented on PR #21096: URL: https://github.com/apache/pulsar/pull/21096#issuecomment-1704754727 > > > > It makes sense, we should print a debug log when the allGroupsBookieMapping is null. > > > > > > > > > Yes, sure. > > > > > > There is a case that needs

[GitHub] [pulsar] github-actions[bot] commented on pull request #20925: [draft] [improve] [pip] PIP-291 Support producer batch IO write to improve replication

github-actions[bot] commented on PR #20925: URL: https://github.com/apache/pulsar/pull/20925#issuecomment-1704501195 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #20910: [Bug] When querying a newly created topic with Pulsar SQL, the query will be blocked.

github-actions[bot] commented on issue #20910: URL: https://github.com/apache/pulsar/issues/20910#issuecomment-1704501238 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on pull request #20469: [pip][design] PIP-269. Add an epoch of cursor to discard outdated reading

github-actions[bot] commented on PR #20469: URL: https://github.com/apache/pulsar/pull/20469#issuecomment-1704501672 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar-site] Anonymitaet merged pull request #683: [improve][doc] SEO for Transactions

Anonymitaet merged PR #683: URL: https://github.com/apache/pulsar-site/pull/683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] Anonymitaet merged pull request #681: [improve][doc] SEO for deployment

Anonymitaet merged PR #681: URL: https://github.com/apache/pulsar-site/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] Anonymitaet merged pull request #693: [improve][doc] SEO for Administration

Anonymitaet merged PR #693: URL: https://github.com/apache/pulsar-site/pull/693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   4   5   6   7   8   9   10   >