[GitHub] [pulsar] asafm commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-19 Thread GitBox
asafm commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1081486335 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +62,50 @@ public static MetadataStoreExtended

[GitHub] [pulsar] asafm commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-19 Thread GitBox
asafm commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1080972166 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +62,50 @@ public static MetadataStoreExtended

[GitHub] [pulsar] asafm commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-17 Thread GitBox
asafm commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071875876 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/RocksdbMetadataStore.java: ## @@ -570,3 +573,17 @@ public Optional getMetadataEventSynchronizer() {

[GitHub] [pulsar] asafm commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-15 Thread GitBox
asafm commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1070531001 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -18,13 +18,30 @@ */ package org.apache.pulsar.metadata.impl;