asafm commented on code in PR #19208:
URL: https://github.com/apache/pulsar/pull/19208#discussion_r1080972166
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java:
##########
@@ -45,19 +62,50 @@ public static MetadataStoreExtended createExtended(String
metadataURL, MetadataS
private static MetadataStore newInstance(String metadataURL,
MetadataStoreConfig metadataStoreConfig,
boolean enableSessionWatcher)
throws MetadataStoreException {
+ MetadataStoreProvider provider = findProvider(metadataURL);
+ if (provider != null) {
+ return provider.create(metadataURL, metadataStoreConfig,
enableSessionWatcher);
+ }
+ return new ZKMetadataStore(metadataURL, metadataStoreConfig,
enableSessionWatcher);
+ }
+
+ static void loadProviders() {
+ String factoryClasses =
System.getProperty(METADATASTORE_PROVIDERS_PROPERTY);
Review Comment:
@merlimat Which CLI tools need direct access to the Metadata store?
I only know ./pulsar-admin, which REST directly to the broker, so it doesn’t
need meta.
Can you help me understand what the many places that don’t have access to
pulsar configuration are?
Regarding BK: Isn’t BK a separate codebase, so it won’t share this code
anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
