[GitHub] massakam opened a new pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-16 Thread GitBox
massakam opened a new pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795 ### Motivation I noticed that messages with the same key might be routed to different partitions when MurmurHash3 was selected as a hashing scheme in the

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-16 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-389739626 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-16 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-388097238 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] zhaijack commented on issue #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader

2018-05-16 Thread GitBox
zhaijack commented on issue #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1784#issuecomment-389731608 @ivankelly Thanks, updated. This is an automated

[GitHub] merlimat commented on issue #1793: Added docker files and script to build static client library and Python bindings on Linux

2018-05-16 Thread GitBox
merlimat commented on issue #1793: Added docker files and script to build static client library and Python bindings on Linux URL: https://github.com/apache/incubator-pulsar/pull/1793#issuecomment-389718864 retest this please

[GitHub] merlimat closed pull request #1794: Create shared library that only exports API symbols

2018-05-16 Thread GitBox
merlimat closed pull request #1794: Create shared library that only exports API symbols URL: https://github.com/apache/incubator-pulsar/pull/1794 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: Create shared library that only exports API symbols (#1794)

2018-05-16 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 971f76b Create shared library that

[GitHub] merlimat opened a new pull request #1794: Create shared library that only exports API symbols

2018-05-16 Thread GitBox
merlimat opened a new pull request #1794: Create shared library that only exports API symbols URL: https://github.com/apache/incubator-pulsar/pull/1794 ### Motivation Pass the `-fvisibility=hidden -Wl,--exclude-libs,ALL` flags to the linker when creating `libpulsar.so`. That will

[GitHub] lucperkins commented on issue #1466: Topic compaction documentation (WIP)

2018-05-16 Thread GitBox
lucperkins commented on issue #1466: Topic compaction documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1466#issuecomment-389700478 @ivankelly This is ready for review. This is an automated message from

[GitHub] lucperkins commented on issue #1763: Document Python dependencies

2018-05-16 Thread GitBox
lucperkins commented on issue #1763: Document Python dependencies URL: https://github.com/apache/incubator-pulsar/pull/1763#issuecomment-389699189 retest this please This is an automated message from the Apache Git Service.

[GitHub] lucperkins commented on issue #1788: adding windowing function CLI option descriptions

2018-05-16 Thread GitBox
lucperkins commented on issue #1788: adding windowing function CLI option descriptions URL: https://github.com/apache/incubator-pulsar/pull/1788#issuecomment-389699047 @jerrypeng FYI I'm going to add a description for `--autoAck` in a different PR.

[GitHub] merlimat opened a new pull request #1793: Added docker files and script to build static client library and Python bindings on Linux

2018-05-16 Thread GitBox
merlimat opened a new pull request #1793: Added docker files and script to build static client library and Python bindings on Linux URL: https://github.com/apache/incubator-pulsar/pull/1793 ### Motivation To generate a statically linked `libpulsar.so` for Linux, we need to have all

[GitHub] lucperkins commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
lucperkins commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389688423 @merlimat  This is an automated message from the Apache Git Service. To respond to the

[GitHub] lucperkins closed pull request #1778: Vendored imports

2018-05-16 Thread GitBox
lucperkins closed pull request #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] merlimat commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
merlimat commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389687657 @lucperkins @sijie I have removed the only dependency in the latest updates to #1764. We shouldn't need this for now.

[GitHub] merlimat commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
merlimat commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389687657 @lucperkins @sijie I have removed the only one dependency in the latest updates to #1764. We shouldn't need this for now.

[incubator-pulsar] branch master updated: Fixes in CMakeFiles to automate build on macos (#1787)

2018-05-16 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b1a7b55 Fixes in CMakeFiles to

[GitHub] merlimat closed pull request #1787: Fixes in CMakeFiles to automate build on macos

2018-05-16 Thread GitBox
merlimat closed pull request #1787: Fixes in CMakeFiles to automate build on macos URL: https://github.com/apache/incubator-pulsar/pull/1787 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] jerrypeng commented on issue #1792: Modifying sink interface to be generic

2018-05-16 Thread GitBox
jerrypeng commented on issue #1792: Modifying sink interface to be generic URL: https://github.com/apache/incubator-pulsar/pull/1792#issuecomment-389671734 @srkukarni @sijie @rdhabalia please review This is an automated

[GitHub] jerrypeng opened a new pull request #1792: Modifying sink interface to be generic

2018-05-16 Thread GitBox
jerrypeng opened a new pull request #1792: Modifying sink interface to be generic URL: https://github.com/apache/incubator-pulsar/pull/1792 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jerrypeng commented on issue #1788: adding windowing function CLI option descriptions

2018-05-16 Thread GitBox
jerrypeng commented on issue #1788: adding windowing function CLI option descriptions URL: https://github.com/apache/incubator-pulsar/pull/1788#issuecomment-389668373 retest this please This is an automated message from the

[GitHub] merlimat closed pull request #1785: Fix sidebar link

2018-05-16 Thread GitBox
merlimat closed pull request #1785: Fix sidebar link URL: https://github.com/apache/incubator-pulsar/pull/1785 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] merlimat closed pull request #1783: Fix build with boost >= 1.66

2018-05-16 Thread GitBox
merlimat closed pull request #1783: Fix build with boost >= 1.66 URL: https://github.com/apache/incubator-pulsar/pull/1783 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Fix sidebar link (#1785)

2018-05-16 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0045d1b Fix sidebar link (#1785)

[GitHub] merlimat closed issue #1772: Getting started/Pulsar 2.0 : URL broken

2018-05-16 Thread GitBox
merlimat closed issue #1772: Getting started/Pulsar 2.0 : URL broken URL: https://github.com/apache/incubator-pulsar/issues/1772 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-pulsar] branch master updated: Fix build with boost >= 1.65 (#1783)

2018-05-16 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 86fb8a3 Fix build with boost >= 1.65

[GitHub] lucperkins opened a new pull request #1791: [WIP] Pulsar Functions windowing documentation

2018-05-16 Thread GitBox
lucperkins opened a new pull request #1791: [WIP] Pulsar Functions windowing documentation URL: https://github.com/apache/incubator-pulsar/pull/1791 This is an automated message from the Apache Git Service. To respond to

[GitHub] sijie commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
sijie commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389601498 I think you can pin a revision or tag (but I can be wrong) This is an automated message from

[GitHub] sijie closed pull request #1790: ReadHandle implementation backed by S3

2018-05-16 Thread GitBox
sijie closed pull request #1790: ReadHandle implementation backed by S3 URL: https://github.com/apache/incubator-pulsar/pull/1790 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
merlimat commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389599125 Oh, true. Isn't there a way to just pin the version of the dependencies? This is an

[GitHub] lucperkins commented on issue #1778: Vendored imports

2018-05-16 Thread GitBox
lucperkins commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-389598169 @merlimat True, but in the Go community that's considered sub-standard practice because there are no versions, which means that someone could make a

[incubator-pulsar] branch master updated: ReadHandle implementation backed by S3 (#1790)

2018-05-16 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new f0b1471 ReadHandle implementation

[GitHub] merlimat commented on issue #1785: Fix sidebar link

2018-05-16 Thread GitBox
merlimat commented on issue #1785: Fix sidebar link URL: https://github.com/apache/incubator-pulsar/pull/1785#issuecomment-389582838 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] merlimat commented on issue #1783: Fix build with boost >= 1.66

2018-05-16 Thread GitBox
merlimat commented on issue #1783: Fix build with boost >= 1.66 URL: https://github.com/apache/incubator-pulsar/pull/1783#issuecomment-389574675 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on issue #1783: Fix build with boost >= 1.66

2018-05-16 Thread GitBox
merlimat commented on issue #1783: Fix build with boost >= 1.66 URL: https://github.com/apache/incubator-pulsar/pull/1783#issuecomment-389574675 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat closed pull request #1789: Ability to disable test retries from commandline

2018-05-16 Thread GitBox
merlimat closed pull request #1789: Ability to disable test retries from commandline URL: https://github.com/apache/incubator-pulsar/pull/1789 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Ability to disable test retries from commandline (#1789)

2018-05-16 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b47c059 Ability to disable test

[GitHub] ivankelly commented on a change in pull request #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader

2018-05-16 Thread GitBox
ivankelly commented on a change in pull request #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1784#discussion_r188593231 ## File path:

[GitHub] ivankelly commented on issue #1790: ReadHandle implementation backed by S3

2018-05-16 Thread GitBox
ivankelly commented on issue #1790: ReadHandle implementation backed by S3 URL: https://github.com/apache/incubator-pulsar/pull/1790#issuecomment-389486668 @zhaijack @sijie @merlimat This is an automated message from the

[GitHub] ivankelly opened a new pull request #1790: ReadHandle implementation backed by S3

2018-05-16 Thread GitBox
ivankelly opened a new pull request #1790: ReadHandle implementation backed by S3 URL: https://github.com/apache/incubator-pulsar/pull/1790 Implementation of bookkeeper ReadHandle, which reads from an S3 object. Master Issue: #1511

[GitHub] ivankelly opened a new pull request #1789: Ability to disable test retries from commandline

2018-05-16 Thread GitBox
ivankelly opened a new pull request #1789: Ability to disable test retries from commandline URL: https://github.com/apache/incubator-pulsar/pull/1789 Sometimes it's useful to be able to disable retries when testing sometime, for example, if you want to find flakes, or you have a test

[incubator-pulsar] branch asf-site updated: Updated site at revision f3b47c0

2018-05-16 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 43b465c Updated site at revision

[GitHub] jerrypeng commented on issue #1788: adding windowing function CLI option descriptions

2018-05-16 Thread GitBox
jerrypeng commented on issue #1788: adding windowing function CLI option descriptions URL: https://github.com/apache/incubator-pulsar/pull/1788#issuecomment-389419490 @srkukarni @sijie please review This is an automated

[GitHub] jerrypeng opened a new pull request #1788: adding windowing function CLI option descriptions

2018-05-16 Thread GitBox
jerrypeng opened a new pull request #1788: adding windowing function CLI option descriptions URL: https://github.com/apache/incubator-pulsar/pull/1788 This is an automated message from the Apache Git Service. To respond to

[GitHub] merlimat closed pull request #1786: Remove duplicated dependency

2018-05-16 Thread GitBox
merlimat closed pull request #1786: Remove duplicated dependency URL: https://github.com/apache/incubator-pulsar/pull/1786 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Remove duplicated dependency (#1786)

2018-05-16 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new f3b47c0 Remove duplicated dependency

[GitHub] merlimat opened a new pull request #1787: Fixes in CMakeFiles to automate build on macos

2018-05-16 Thread GitBox
merlimat opened a new pull request #1787: Fixes in CMakeFiles to automate build on macos URL: https://github.com/apache/incubator-pulsar/pull/1787 ### Motivation Couple of fixes to improve cmake libraries discovery on MacOS.