[GitHub] sijie commented on issue #2157: #2156 - Documentation need to be updated for Admin command to apply deduplication at namespace

2018-07-13 Thread GitBox
sijie commented on issue #2157: #2156 - Documentation need to be updated for Admin command to apply deduplication at namespace URL: https://github.com/apache/incubator-pulsar/pull/2157#issuecomment-405000340 retest this please ---

[GitHub] sijie commented on issue #2155: bin/bookkeeper doesn't output the result to the console

2018-07-13 Thread GitBox
sijie commented on issue #2155: bin/bookkeeper doesn't output the result to the console URL: https://github.com/apache/incubator-pulsar/pull/2155#issuecomment-405000306 retest this please This is an automated message from th

[GitHub] sijie commented on issue #2158: Add a new docker image to include all pulsar io connectors

2018-07-13 Thread GitBox
sijie commented on issue #2158: Add a new docker image to include all pulsar io connectors URL: https://github.com/apache/incubator-pulsar/pull/2158#issuecomment-405000264 retest this please This is an automated message from

[GitHub] sijie closed pull request #2161: git ignore nar extension file

2018-07-13 Thread GitBox
sijie closed pull request #2161: git ignore nar extension file URL: https://github.com/apache/incubator-pulsar/pull/2161 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull re

[incubator-pulsar] branch master updated: git ignore nar extension file (#2161)

2018-07-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ce9b125 git ignore nar extension file

[incubator-pulsar] branch master updated: Fix: trigger function rest-api (#2162)

2018-07-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0ff99e7 Fix: trigger function rest-ap

[GitHub] merlimat closed pull request #2162: Fix: trigger function rest-api

2018-07-13 Thread GitBox
merlimat closed pull request #2162: Fix: trigger function rest-api URL: https://github.com/apache/incubator-pulsar/pull/2162 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202505495 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offloa

[GitHub] zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202505438 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offloa

[GitHub] rdhabalia removed a comment on issue #2130: Add function metrics with function-stats to get metrics on-demand

2018-07-13 Thread GitBox
rdhabalia removed a comment on issue #2130: Add function metrics with function-stats to get metrics on-demand URL: https://github.com/apache/incubator-pulsar/pull/2130#issuecomment-404997489 retest this please This is an auto

[GitHub] zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202505411 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offloa

[GitHub] rdhabalia commented on issue #2130: Add function metrics with function-stats to get metrics on-demand

2018-07-13 Thread GitBox
rdhabalia commented on issue #2130: Add function metrics with function-stats to get metrics on-demand URL: https://github.com/apache/incubator-pulsar/pull/2130#issuecomment-404997489 retest this please This is an automated me

[GitHub] rdhabalia commented on issue #2161: git ignore nar extension file

2018-07-13 Thread GitBox
rdhabalia commented on issue #2161: git ignore nar extension file URL: https://github.com/apache/incubator-pulsar/pull/2161#issuecomment-404997479 retest this please This is an automated message from the Apache Git Service. To

[GitHub] zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202505385 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offloa

[GitHub] zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202504152 ## File path: jclouds-shaded/pom.xml ## @@ -0,0 +1,105 @@ + + +h

[GitHub] zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
zhaijack commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202504042 ## File path: pom.xml ## @@ -101,6 +101,8 @@ flexible messaging

[GitHub] zhaijack opened a new issue #2164: Offload: track jclouds release update for JCLOUDS-1166

2018-07-13 Thread GitBox
zhaijack opened a new issue #2164: Offload: track jclouds release update for JCLOUDS-1166 URL: https://github.com/apache/incubator-pulsar/issues/2164 currently we use shaded version of jclouds, because of [gson conflict]( https://issues.apache.org/jira/browse/JCLOUDS-1166), It is undergoi

[GitHub] rdhabalia opened a new pull request #2163: Add pulsar-version comment for future reference

2018-07-13 Thread GitBox
rdhabalia opened a new pull request #2163: Add pulsar-version comment for future reference URL: https://github.com/apache/incubator-pulsar/pull/2163 ### Motivation Broker/Client version-change comments helps to understand compatibility changes on each version. So, added comment for

[GitHub] rdhabalia opened a new pull request #2162: Fix: trigger function rest-api

2018-07-13 Thread GitBox
rdhabalia opened a new pull request #2162: Fix: trigger function rest-api URL: https://github.com/apache/incubator-pulsar/pull/2162 ### Motivation Trigger-function rest api is broken due to wrong path-param ### Modifications fix path-param for function-name. ### R

[GitHub] rdhabalia commented on issue #2161: git ignore nar extension file

2018-07-13 Thread GitBox
rdhabalia commented on issue #2161: git ignore nar extension file URL: https://github.com/apache/incubator-pulsar/pull/2161#issuecomment-404987410 retest this please This is an automated message from the Apache Git Service. To

[GitHub] rdhabalia removed a comment on issue #2161: git ignore nar extension file

2018-07-13 Thread GitBox
rdhabalia removed a comment on issue #2161: git ignore nar extension file URL: https://github.com/apache/incubator-pulsar/pull/2161#issuecomment-404987410 retest this please This is an automated message from the Apache Git Ser

[GitHub] rdhabalia closed pull request #2159: fix: conflicting jackson transitive dependency for worker

2018-07-13 Thread GitBox
rdhabalia closed pull request #2159: fix: conflicting jackson transitive dependency for worker URL: https://github.com/apache/incubator-pulsar/pull/2159 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[incubator-pulsar] branch master updated: fix: conflicting jackson transitive dependency for worker (#2159)

2018-07-13 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e54c58a fix: conflicting jackson t

[GitHub] aahmed-se commented on issue #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on issue #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#issuecomment-404985893 @sijie @ivankelly seems a lot of changes have happened in master gonna rebuild the git commits to resolve the compli

[incubator-pulsar] branch master updated: Add numFunctionWorkers and externalServices to cluster spec (#2160)

2018-07-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 10f273a Add numFunctionWorkers and ext

[GitHub] sijie closed pull request #2160: Add numFunctionWorkers and externalServices to cluster spec

2018-07-13 Thread GitBox
sijie closed pull request #2160: Add numFunctionWorkers and externalServices to cluster spec URL: https://github.com/apache/incubator-pulsar/pull/2160 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] rdhabalia commented on issue #2159: fix: conflicting jackson transitive dependency for worker

2018-07-13 Thread GitBox
rdhabalia commented on issue #2159: fix: conflicting jackson transitive dependency for worker URL: https://github.com/apache/incubator-pulsar/pull/2159#issuecomment-404978879 retest this please This is an automated message fr

[GitHub] rdhabalia removed a comment on issue #2159: fix: conflicting jackson transitive dependency for worker

2018-07-13 Thread GitBox
rdhabalia removed a comment on issue #2159: fix: conflicting jackson transitive dependency for worker URL: https://github.com/apache/incubator-pulsar/pull/2159#issuecomment-404978879 retest this please This is an automated me

[GitHub] rdhabalia opened a new pull request #2161: git ignore nar extension file

2018-07-13 Thread GitBox
rdhabalia opened a new pull request #2161: git ignore nar extension file URL: https://github.com/apache/incubator-pulsar/pull/2161 ### Motivation `pulsar-client-tools` modules generates nar file under test-resources which should be ignored while checkin. ### Modifications

[GitHub] merlimat closed pull request #2116: Added optional key in pulsar IO

2018-07-13 Thread GitBox
merlimat closed pull request #2116: Added optional key in pulsar IO URL: https://github.com/apache/incubator-pulsar/pull/2116 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[incubator-pulsar] branch master updated: Added optional key in pulsar IO (#2116)

2018-07-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ea6eae7 Added optional key in pulsar

[GitHub] sijie opened a new pull request #2160: Add numFunctionWorkers and externalServices to cluster spec

2018-07-13 Thread GitBox
sijie opened a new pull request #2160: Add numFunctionWorkers and externalServices to cluster spec URL: https://github.com/apache/incubator-pulsar/pull/2160 *Motivation* This change is a refactor for adding connectors related integration tests. ClusterSpec is used for defining

[incubator-pulsar] branch master updated: Fix: file-url sink/source submission with cli (#2150)

2018-07-13 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3b8faea Fix: file-url sink/source

[GitHub] rdhabalia removed a comment on issue #2159: fix: conflicting jackson transitive dependency for worker

2018-07-13 Thread GitBox
rdhabalia removed a comment on issue #2159: fix: conflicting jackson transitive dependency for worker URL: https://github.com/apache/incubator-pulsar/pull/2159#issuecomment-404968930 retest this please This is an automated me

[GitHub] rdhabalia closed pull request #2150: Fix: file-url sink/source submission with cli

2018-07-13 Thread GitBox
rdhabalia closed pull request #2150: Fix: file-url sink/source submission with cli URL: https://github.com/apache/incubator-pulsar/pull/2150 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] rdhabalia commented on issue #2159: fix: conflicting jackson transitive dependency for worker

2018-07-13 Thread GitBox
rdhabalia commented on issue #2159: fix: conflicting jackson transitive dependency for worker URL: https://github.com/apache/incubator-pulsar/pull/2159#issuecomment-404968930 retest this please This is an automated message fr

[GitHub] merlimat commented on issue #2158: Add a new docker image to include all pulsar io connectors

2018-07-13 Thread GitBox
merlimat commented on issue #2158: Add a new docker image to include all pulsar io connectors URL: https://github.com/apache/incubator-pulsar/pull/2158#issuecomment-404966941 retest this please This is an automated message fr

[GitHub] aahmed-se commented on issue #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on issue #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#issuecomment-404964817 retest this please This is an automated message fro

[GitHub] merlimat removed a comment on issue #2157: #2156 - Documentation need to be updated for Admin command to apply deduplication at namespace

2018-07-13 Thread GitBox
merlimat removed a comment on issue #2157: #2156 - Documentation need to be updated for Admin command to apply deduplication at namespace URL: https://github.com/apache/incubator-pulsar/pull/2157#issuecomment-404964575 retest this please

[GitHub] merlimat commented on issue #2157: #2156 - Documentation need to be updated for Admin command to apply deduplication at namespace

2018-07-13 Thread GitBox
merlimat commented on issue #2157: #2156 - Documentation need to be updated for Admin command to apply deduplication at namespace URL: https://github.com/apache/incubator-pulsar/pull/2157#issuecomment-404964575 retest this please

[GitHub] merlimat commented on issue #2116: Added optional key in pulsar IO

2018-07-13 Thread GitBox
merlimat commented on issue #2116: Added optional key in pulsar IO URL: https://github.com/apache/incubator-pulsar/pull/2116#issuecomment-404963596 retest this please This is an automated message from the Apache Git Service. T

[GitHub] aahmed-se commented on issue #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on issue #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#issuecomment-404957135 @bsideup we tried the LocalStack the s3 operations didn't work as expected.

[GitHub] merlimat commented on issue #2116: Added optional key in pulsar IO

2018-07-13 Thread GitBox
merlimat commented on issue #2116: Added optional key in pulsar IO URL: https://github.com/apache/incubator-pulsar/pull/2116#issuecomment-404957118 retest this please This is an automated message from the Apache Git Service. T

[GitHub] rdhabalia opened a new pull request #2159: fix: conflicting jackson transitive dependency for worker

2018-07-13 Thread GitBox
rdhabalia opened a new pull request #2159: fix: conflicting jackson transitive dependency for worker URL: https://github.com/apache/incubator-pulsar/pull/2159 ### Motivation Right now, swager-io brings incompatible old-version transitive jackson dependencies which causes exception

[GitHub] sijie commented on a change in pull request #2158: Add a new docker image to include all pulsar io connectors

2018-07-13 Thread GitBox
sijie commented on a change in pull request #2158: Add a new docker image to include all pulsar io connectors URL: https://github.com/apache/incubator-pulsar/pull/2158#discussion_r202472652 ## File path: docker/pulsar-all/Dockerfile ## @@ -0,0 +1,25 @@ +# +# Licensed to th

[GitHub] merlimat commented on a change in pull request #2158: Add a new docker image to include all pulsar io connectors

2018-07-13 Thread GitBox
merlimat commented on a change in pull request #2158: Add a new docker image to include all pulsar io connectors URL: https://github.com/apache/incubator-pulsar/pull/2158#discussion_r202458172 ## File path: docker/pulsar-all/Dockerfile ## @@ -0,0 +1,25 @@ +# +# Licensed to

[GitHub] sijie opened a new pull request #2158: Add a new docker image to include all pulsar io connectors

2018-07-13 Thread GitBox
sijie opened a new pull request #2158: Add a new docker image to include all pulsar io connectors URL: https://github.com/apache/incubator-pulsar/pull/2158 *Motivation* We shipped two distributions : server & io-connectors. For people who run pulsar in docker, we need to put all t

[GitHub] merlimat commented on issue #2116: Added optional key in pulsar IO

2018-07-13 Thread GitBox
merlimat commented on issue #2116: Added optional key in pulsar IO URL: https://github.com/apache/incubator-pulsar/pull/2116#issuecomment-404932347 retest this please This is an automated message from the Apache Git Service. T

[GitHub] rdhabalia removed a comment on issue #2150: Fix: file-url sink/source submission with cli

2018-07-13 Thread GitBox
rdhabalia removed a comment on issue #2150: Fix: file-url sink/source submission with cli URL: https://github.com/apache/incubator-pulsar/pull/2150#issuecomment-404924954 retest this please This is an automated message from t

[GitHub] rdhabalia commented on issue #2150: Fix: file-url sink/source submission with cli

2018-07-13 Thread GitBox
rdhabalia commented on issue #2150: Fix: file-url sink/source submission with cli URL: https://github.com/apache/incubator-pulsar/pull/2150#issuecomment-404924954 retest this please This is an automated message from the Apach

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202441976 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202441297 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202441153 ## File path: tests/integration/compaction/pom.xml ## @@ -38,10 +38,17 @@ Apac

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202441103 ## File path: tests/integration/s3-offload/src/test/java/org/apache/pulsar/tests/integrati

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202440529 ## File path: tests/integration/compaction/src/test/java/org/apache/pulsar/tests/integrati

[GitHub] pckeyan commented on issue #2156: Documentation need to be updated for Admin command to apply deduplication at namespace

2018-07-13 Thread GitBox
pckeyan commented on issue #2156: Documentation need to be updated for Admin command to apply deduplication at namespace URL: https://github.com/apache/incubator-pulsar/issues/2156#issuecomment-404919702 Created PR - https://github.com/apache/incubator-pulsar/pull/2157 ---

[GitHub] pckeyan opened a new pull request #2157: #2156 - Documentation need to be updated for Admin command to apply deduplication at namespace

2018-07-13 Thread GitBox
pckeyan opened a new pull request #2157: #2156 - Documentation need to be updated for Admin command to apply deduplication at namespace URL: https://github.com/apache/incubator-pulsar/pull/2157 #2156 - Documentation need to be updated for Admin command to apply deduplication at namespace:

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202440122 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202439580 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] pckeyan opened a new issue #2156: Documentation need to be updated for Admin command to apply deduplication at namespace

2018-07-13 Thread GitBox
pckeyan opened a new issue #2156: Documentation need to be updated for Admin command to apply deduplication at namespace URL: https://github.com/apache/incubator-pulsar/issues/2156 Documentation need to be updated for Admin command to apply deduplication at namespace: bin/pulsar-adm

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202439346 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202437366 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202437007 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202421721 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offlo

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202421288 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offlo

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202422802 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/offlo

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202416096 ## File path: jclouds-shaded/pom.xml ## @@ -0,0 +1,105 @@ + + +

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202419637 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offlo

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202419213 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offlo

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202420982 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offlo

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202420721 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offlo

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202418450 ## File path: jclouds-shaded/pom.xml ## @@ -0,0 +1,105 @@ + + +

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202422054 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offlo

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202416686 ## File path: pulsar-broker/pom.xml ## @@ -268,6 +268,12 @@

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202420102 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/offlo

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202423593 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/offlo

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202416255 ## File path: pom.xml ## @@ -101,6 +101,8 @@ flexible messaging

[GitHub] sijie opened a new pull request #2155: bin/bookkeeper doesn't output the result to the console

2018-07-13 Thread GitBox
sijie opened a new pull request #2155: bin/bookkeeper doesn't output the result to the console URL: https://github.com/apache/incubator-pulsar/pull/2155 ### Motivation the change from log4j to log4j2 in 2.0 changes the logging behavior for `bin/bookkeeper`. some of the results of B

[GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202405824 ## File path: tests/integration/compaction/src/test/java/org/apache/pulsar/tests/integrati

[GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202403205 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202401674 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202405138 ## File path: tests/integration/compaction/pom.xml ## @@ -38,10 +38,17 @@ Apac

[GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202403937 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202399466 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/con

[GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202403535 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202401733 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202402822 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202407822 ## File path: tests/integration/s3-offload/src/test/java/org/apache/pulsar/tests/integrati

[GitHub] ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202403693 ## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/top

[GitHub] merlimat closed pull request #2147: Fix: function load correct type-class of connector

2018-07-13 Thread GitBox
merlimat closed pull request #2147: Fix: function load correct type-class of connector URL: https://github.com/apache/incubator-pulsar/pull/2147 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Fix: function load correct type-class of connector (#2147)

2018-07-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 26a70db Fix: function load correct ty

[GitHub] merlimat commented on a change in pull request #2135: Allow user to get topic from consumer message (#2007)

2018-07-13 Thread GitBox
merlimat commented on a change in pull request #2135: Allow user to get topic from consumer message (#2007) URL: https://github.com/apache/incubator-pulsar/pull/2135#discussion_r202359227 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java

[GitHub] merlimat commented on a change in pull request #2135: Allow user to get topic from consumer message (#2007)

2018-07-13 Thread GitBox
merlimat commented on a change in pull request #2135: Allow user to get topic from consumer message (#2007) URL: https://github.com/apache/incubator-pulsar/pull/2135#discussion_r202359227 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java

[GitHub] merlimat closed pull request #2148: Fix schema initialization

2018-07-13 Thread GitBox
merlimat closed pull request #2148: Fix schema initialization URL: https://github.com/apache/incubator-pulsar/pull/2148 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull req

[GitHub] merlimat closed pull request #2149: Avoid closing cursor when consumers are disconnected

2018-07-13 Thread GitBox
merlimat closed pull request #2149: Avoid closing cursor when consumers are disconnected URL: https://github.com/apache/incubator-pulsar/pull/2149 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[incubator-pulsar] branch master updated: Fix schema initialization (#2148)

2018-07-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 06e26b2 Fix schema initialization (#2

[incubator-pulsar] branch master updated: Avoid closing cursor when consumers are disconnected (#2149)

2018-07-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 123524d Avoid closing cursor when con

[GitHub] ivankelly commented on a change in pull request #2135: Allow user to get topic from consumer message (#2007)

2018-07-13 Thread GitBox
ivankelly commented on a change in pull request #2135: Allow user to get topic from consumer message (#2007) URL: https://github.com/apache/incubator-pulsar/pull/2135#discussion_r202330011 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java ###

[GitHub] bsideup commented on issue #2101: Migrate compaction and s3 offload test to testcontainers

2018-07-13 Thread GitBox
bsideup commented on issue #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#issuecomment-404793506 @aahmed-se FYI we have LocalStackContainer in Testcontainers which helps you to run S3-compatible API for the testing

[GitHub] sijie opened a new issue #2154: How pulsar proxy routes http requests to function workers

2018-07-13 Thread GitBox
sijie opened a new issue #2154: How pulsar proxy routes http requests to function workers URL: https://github.com/apache/incubator-pulsar/issues/2154 If function workers are started as part of brokers, http requests will be routed correctly. However if function workers are deployed separat

  1   2   >