[GitHub] merlimat commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-24 Thread GitBox
merlimat commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r212524152 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursor.java ## @@ -75,6 +78,16

[GitHub] merlimat commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-24 Thread GitBox
merlimat commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r212524486 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java ## @@ -330,4 +330,24

[GitHub] merlimat commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-24 Thread GitBox
merlimat commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r212524714 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -229,6 +229,16 @@ message CommandSubscribe {