[GitHub] zhaijack commented on issue #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader

2018-05-17 Thread GitBox
zhaijack commented on issue #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1784#issuecomment-389781122 @sijie Would you please help review this? This

[GitHub] nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#discussion_r188861733 ## File path: pulsar-client-cpp/tests/HashTest.cc ## @@ -58,10 +58,18 @@ TEST(HashTest, testJavaStringHash)

[incubator-pulsar] branch asf-site updated: Updated site at revision 971f76b

2018-05-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 984bf75 Updated site at revision

[incubator-pulsar] branch master updated: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader (#1784)

2018-05-17 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a6544bd PIP-17: impl

[GitHub] sijie closed pull request #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader

2018-05-17 Thread GitBox
sijie closed pull request #1784: PIP-17: impl deleteOffloaded() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1784 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ivankelly opened a new issue #1796: Proxy cannot be configured to work as proxy for both admin and client requests

2018-05-17 Thread GitBox
ivankelly opened a new issue #1796: Proxy cannot be configured to work as proxy for both admin and client requests URL: https://github.com/apache/incubator-pulsar/issues/1796 Expected behavior When I start a proxy, I should be able to point both a client and an admin client at

[GitHub] nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#discussion_r188907542 ## File path: pulsar-client-cpp/tests/HashTest.cc ## @@ -58,10 +58,18 @@ TEST(HashTest, testJavaStringHash)

[GitHub] massakam commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
massakam commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#discussion_r188892224 ## File path: pulsar-client-cpp/tests/HashTest.cc ## @@ -58,10 +58,18 @@ TEST(HashTest, testJavaStringHash)

[GitHub] ivankelly opened a new issue #1797: Proxy doesn't strip the request URL for admin requests correctly

2018-05-17 Thread GitBox
ivankelly opened a new issue #1797: Proxy doesn't strip the request URL for admin requests correctly URL: https://github.com/apache/incubator-pulsar/issues/1797 Expected behavior Using proxy to do admin tasks should work. Actual behavior On client ```

[GitHub] nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
nkurihar commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#discussion_r188861733 ## File path: pulsar-client-cpp/tests/HashTest.cc ## @@ -58,10 +58,18 @@ TEST(HashTest, testJavaStringHash)

[GitHub] massakam commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
massakam commented on a change in pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#discussion_r188864565 ## File path: pulsar-client-cpp/tests/HashTest.cc ## @@ -58,10 +58,18 @@ TEST(HashTest, testJavaStringHash)

[GitHub] merlimat closed pull request #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
merlimat closed pull request #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: Fix C++ MurmurHash3 algorithm (#1795)

2018-05-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 920ecba Fix C++ MurmurHash3

[GitHub] sijie closed pull request #1788: adding windowing function CLI option descriptions

2018-05-17 Thread GitBox
sijie closed pull request #1788: adding windowing function CLI option descriptions URL: https://github.com/apache/incubator-pulsar/pull/1788 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: adding windowing CLI option comments (#1788)

2018-05-17 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 177e88d adding windowing CLI option

[GitHub] sijie commented on issue #1795: Fix C++ MurmurHash3 algorithm

2018-05-17 Thread GitBox
sijie commented on issue #1795: Fix C++ MurmurHash3 algorithm URL: https://github.com/apache/incubator-pulsar/pull/1795#issuecomment-389914752 we might consider porting this change back for 2.0.1? This is an automated message

[GitHub] ivankelly opened a new pull request #1801: Log4j2.yaml configures loggers incorrectly

2018-05-17 Thread GitBox
ivankelly opened a new pull request #1801: Log4j2.yaml configures loggers incorrectly URL: https://github.com/apache/incubator-pulsar/pull/1801 log4j2.yaml has a list of loggers. However, this is not a yaml list, but a yaml map, so the configuration only picks up the last one.

[incubator-pulsar] branch master updated: Modifying sink interface to be generic (#1792)

2018-05-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5e4f2bb Modifying sink interface to

[GitHub] merlimat closed pull request #1792: Modifying sink interface to be generic

2018-05-17 Thread GitBox
merlimat closed pull request #1792: Modifying sink interface to be generic URL: https://github.com/apache/incubator-pulsar/pull/1792 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Log4j2.yaml configures loggers incorrectly (#1801)

2018-05-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e22ef77 Log4j2.yaml configures

[GitHub] merlimat closed pull request #1801: Log4j2.yaml configures loggers incorrectly

2018-05-17 Thread GitBox
merlimat closed pull request #1801: Log4j2.yaml configures loggers incorrectly URL: https://github.com/apache/incubator-pulsar/pull/1801 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] jerrypeng opened a new pull request #1803: Remove old comment

2018-05-17 Thread GitBox
jerrypeng opened a new pull request #1803: Remove old comment URL: https://github.com/apache/incubator-pulsar/pull/1803 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] ivankelly opened a new pull request #1802: Utilities to update configuration for integration tests

2018-05-17 Thread GitBox
ivankelly opened a new pull request #1802: Utilities to update configuration for integration tests URL: https://github.com/apache/incubator-pulsar/pull/1802 This patch provides two utility methods. One of them allows the update of a key value properties type configuration, such as

[incubator-pulsar] branch master updated: Utilities to update configuration for integration tests (#1802)

2018-05-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 63a6b83 Utilities to update

[GitHub] merlimat closed pull request #1802: Utilities to update configuration for integration tests

2018-05-17 Thread GitBox
merlimat closed pull request #1802: Utilities to update configuration for integration tests URL: https://github.com/apache/incubator-pulsar/pull/1802 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ivankelly opened a new pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength

2018-05-17 Thread GitBox
ivankelly opened a new pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength URL: https://github.com/apache/incubator-pulsar/pull/1799 LedgerEntry#getLength() returns the length of the ledger up to and including the length of the entry, not the length

[GitHub] ivankelly opened a new pull request #1798: S3ManagedLedgerOffloader should require region or endpoint

2018-05-17 Thread GitBox
ivankelly opened a new pull request #1798: S3ManagedLedgerOffloader should require region or endpoint URL: https://github.com/apache/incubator-pulsar/pull/1798 The S3 client requires one of the two, but never both. Previously we were throwing an error if region was not specified, even

[GitHub] ivankelly opened a new pull request #1800: Docker testing init script has wrong service url

2018-05-17 Thread GitBox
ivankelly opened a new pull request #1800: Docker testing init script has wrong service url URL: https://github.com/apache/incubator-pulsar/pull/1800 The script was initializing the broker server url with a http url, using the binary protocol port. This patch fixes that and also logs

[GitHub] merlimat commented on issue #1793: Added docker files and script to build static client library and Python bindings on Linux

2018-05-17 Thread GitBox
merlimat commented on issue #1793: Added docker files and script to build static client library and Python bindings on Linux URL: https://github.com/apache/incubator-pulsar/pull/1793#issuecomment-389949461 retest this please

[GitHub] merlimat commented on a change in pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength

2018-05-17 Thread GitBox
merlimat commented on a change in pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength URL: https://github.com/apache/incubator-pulsar/pull/1799#discussion_r189042435 ## File path:

[GitHub] lucperkins commented on issue #1763: Document Python dependencies

2018-05-17 Thread GitBox
lucperkins commented on issue #1763: Document Python dependencies URL: https://github.com/apache/incubator-pulsar/pull/1763#issuecomment-390023082 @merlimat Someday I'll remember on my own grr. Fixed. This is an automated

[GitHub] ivankelly commented on a change in pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength

2018-05-17 Thread GitBox
ivankelly commented on a change in pull request #1799: BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength URL: https://github.com/apache/incubator-pulsar/pull/1799#discussion_r189098223 ## File path:

[GitHub] merlimat closed pull request #1803: Remove old comment

2018-05-17 Thread GitBox
merlimat closed pull request #1803: Remove old comment URL: https://github.com/apache/incubator-pulsar/pull/1803 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[incubator-pulsar] branch master updated: Remove old comment (#1803)

2018-05-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new f09eb3c Remove old comment (#1803)

[GitHub] merlimat commented on issue #1793: Added docker files and script to build static client library and Python bindings on Linux

2018-05-17 Thread GitBox
merlimat commented on issue #1793: Added docker files and script to build static client library and Python bindings on Linux URL: https://github.com/apache/incubator-pulsar/pull/1793#issuecomment-389949461 retest this please

[GitHub] merlimat commented on issue #1763: Document Python dependencies

2018-05-17 Thread GitBox
merlimat commented on issue #1763: Document Python dependencies URL: https://github.com/apache/incubator-pulsar/pull/1763#issuecomment-390005862 @lucperkins There are some missing headers: ``` 2018-05-17\T\16:27:06.785 [WARNING] Missing header in:

[incubator-pulsar] branch master updated: Added docker files and script to build static client library and Python bindings on Linux (#1793)

2018-05-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1a0c8dc Added docker files and

[GitHub] merlimat closed pull request #1793: Added docker files and script to build static client library and Python bindings on Linux

2018-05-17 Thread GitBox
merlimat closed pull request #1793: Added docker files and script to build static client library and Python bindings on Linux URL: https://github.com/apache/incubator-pulsar/pull/1793 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] merlimat closed pull request #1763: Document Python dependencies

2018-05-17 Thread GitBox
merlimat closed pull request #1763: Document Python dependencies URL: https://github.com/apache/incubator-pulsar/pull/1763 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Document Python dependencies (#1763)

2018-05-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e6bcae5 Document Python dependencies

[GitHub] merlimat opened a new pull request #1804: Ensure BookKeeperClientFactory is only instantiated once in PulsarService

2018-05-17 Thread GitBox
merlimat opened a new pull request #1804: Ensure BookKeeperClientFactory is only instantiated once in PulsarService URL: https://github.com/apache/incubator-pulsar/pull/1804 ### Motivation Since SchemaRegistry also uses the BK client factory, 2 instances are being created and the