[GitHub] jai1 commented on issue #1169: Proxy forward auth data

jai1 commented on issue #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169#issuecomment-363669665 > As with similar changes, try to put common logic in a single method @merlimat - Have addressed your comments I feel the last commit (https:

[incubator-pulsar] branch master updated: Templatize resources page (#1041)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 153b797 Templatize resources page (#1

[GitHub] merlimat closed pull request #1041: Templatize resources page

merlimat closed pull request #1041: Templatize resources page URL: https://github.com/apache/incubator-pulsar/pull/1041 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull req

[incubator-pulsar] branch master updated: Fixed apache rat errors (#1194)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3b4d681 Fixed apache rat errors (#119

[GitHub] merlimat closed pull request #1194: Fixed apache rat errors

merlimat closed pull request #1194: Fixed apache rat errors URL: https://github.com/apache/incubator-pulsar/pull/1194 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull reque

[GitHub] merlimat closed pull request #1193: Added instructions to verify the release artifacts signatures

merlimat closed pull request #1193: Added instructions to verify the release artifacts signatures URL: https://github.com/apache/incubator-pulsar/pull/1193 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prove

[incubator-pulsar] branch master updated: Added instructions to verify the release artifacts signatures (#1193)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a7df709 Added instructions to verify

[GitHub] merlimat commented on issue #1186: Pulsar FAQ

merlimat commented on issue #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186#issuecomment-363663916 Thanks @XiaoZYang for starting this! For the FAQs I was wondering whether the wiki might be an easier way to maintain it. There are few pros & cons fo

[GitHub] merlimat commented on issue #1194: Fixed apache rat errors

merlimat commented on issue #1194: Fixed apache rat errors URL: https://github.com/apache/incubator-pulsar/pull/1194#issuecomment-363659953 > I just ran "mvn apache-rat:check" on the root directory and got these files as error What "counts" for the release is what we distribute in t

[GitHub] jai1 commented on issue #1194: Fixed apache rat errors

jai1 commented on issue #1194: Fixed apache rat errors URL: https://github.com/apache/incubator-pulsar/pull/1194#issuecomment-363654445 ok - how do you run the apache-rat check? I just ran "mvn apache-rat:check" on the root directory and got these files as error

[GitHub] merlimat commented on issue #1194: Fixed apache rat errors

merlimat commented on issue #1194: Fixed apache rat errors URL: https://github.com/apache/incubator-pulsar/pull/1194#issuecomment-363653601 @jai1 these directories are not included in the src package This is an automated messa

[GitHub] jai1 commented on issue #1194: Fixed apache rat errors

jai1 commented on issue #1194: Fixed apache rat errors URL: https://github.com/apache/incubator-pulsar/pull/1194#issuecomment-363652544 I had to add some more excludes in pom.xml to pass the rat check https://github.com/jai1/pulsar/tree/ratFixes ``` +site/* +

[GitHub] jai1 commented on issue #1194: Fixed apache rat errors

jai1 commented on issue #1194: Fixed apache rat errors URL: https://github.com/apache/incubator-pulsar/pull/1194#issuecomment-363652544 I had to add some more excludes in pom.xml to get pass the rat check https://github.com/jai1/pulsar/tree/ratFixes ``` +site/*

[GitHub] rdhabalia commented on issue #1184: Add connection timeout for binary lookup request

rdhabalia commented on issue #1184: Add connection timeout for binary lookup request URL: https://github.com/apache/incubator-pulsar/pull/1184#issuecomment-363649046 retest this please This is an automated message from the Ap

[GitHub] rdhabalia commented on issue #1184: Add connection timeout for binary lookup request

rdhabalia commented on issue #1184: Add connection timeout for binary lookup request URL: https://github.com/apache/incubator-pulsar/pull/1184#issuecomment-363649046 retest this please This is an automated message from the Ap

[GitHub] zhaijack commented on issue #1186: Pulsar FAQ

zhaijack commented on issue #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186#issuecomment-363647077 ? This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] merlimat opened a new pull request #1194: Fixed apache rat errors

merlimat opened a new pull request #1194: Fixed apache rat errors URL: https://github.com/apache/incubator-pulsar/pull/1194 ### Motivation There are several missing ASF header missing in new files added since last release.

[GitHub] merlimat commented on a change in pull request #1169: Proxy forward auth data

merlimat commented on a change in pull request #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169#discussion_r166501223 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -213,8 +221,19 @@ p

[GitHub] merlimat commented on a change in pull request #1169: Proxy forward auth data

merlimat commented on a change in pull request #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169#discussion_r166501410 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java ## @@ -59,7 +59,10

[GitHub] merlimat commented on a change in pull request #1169: Proxy forward auth data

merlimat commented on a change in pull request #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169#discussion_r166501477 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java ## @@ -59,7 +59,10

[GitHub] merlimat commented on a change in pull request #1169: Proxy forward auth data

merlimat commented on a change in pull request #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169#discussion_r166501265 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -213,8 +221,19 @@ p

[GitHub] merlimat commented on a change in pull request #1169: Proxy forward auth data

merlimat commented on a change in pull request #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169#discussion_r166485254 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@ -197,6 +1

[incubator-pulsar] branch master updated: Fix for memory leak in Proxy roles enforcement (#1192)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 27117f2 Fix for memory leak in Proxy

[GitHub] merlimat closed pull request #1192: Fix for memory leak in Proxy roles enforcement

merlimat closed pull request #1192: Fix for memory leak in Proxy roles enforcement URL: https://github.com/apache/incubator-pulsar/pull/1192 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] merlimat opened a new pull request #1193: Added instructions to verify the release artifacts signatures

merlimat opened a new pull request #1193: Added instructions to verify the release artifacts signatures URL: https://github.com/apache/incubator-pulsar/pull/1193 ### Motivation The last requirement specified in #986 was to add instructions for checking the integrity of the downloade

[GitHub] merlimat commented on a change in pull request #1192: Fix for memory leak in Proxy roles enforcement

merlimat commented on a change in pull request #1192: Fix for memory leak in Proxy roles enforcement URL: https://github.com/apache/incubator-pulsar/pull/1192#discussion_r166494706 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ##

[GitHub] merlimat commented on a change in pull request #1192: Fix for memory leak in Proxy roles enforcement

merlimat commented on a change in pull request #1192: Fix for memory leak in Proxy roles enforcement URL: https://github.com/apache/incubator-pulsar/pull/1192#discussion_r166494609 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ##

[GitHub] merlimat closed pull request #1185: Fixed storage latency stats with Prometheus

merlimat closed pull request #1185: Fixed storage latency stats with Prometheus URL: https://github.com/apache/incubator-pulsar/pull/1185 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[incubator-pulsar] branch master updated: Fixed storage latency stats with Prometheus (#1185)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 69db894 Fixed storage latency stats w

[GitHub] merlimat commented on issue #1192: Fix for memory leak in Proxy roles enforcement

merlimat commented on issue #1192: Fix for memory leak in Proxy roles enforcement URL: https://github.com/apache/incubator-pulsar/pull/1192#issuecomment-363611803 @jai1 this conflicted with my PR, please rebase This is an aut

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r166481095 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @

[GitHub] merlimat closed issue #1142: Broker should respond with error when invalid topic name is used

merlimat closed issue #1142: Broker should respond with error when invalid topic name is used URL: https://github.com/apache/incubator-pulsar/issues/1142 This is an automated message from the Apache Git Service. To respond t

[incubator-pulsar] branch master updated: Validate topic name on broker side (#1178)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 28ce0ad Validate topic name on broker

[GitHub] merlimat closed pull request #1178: Validate topic name on broker side

merlimat closed pull request #1178: Validate topic name on broker side URL: https://github.com/apache/incubator-pulsar/pull/1178 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r166483266 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/Re

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r166478918 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/C

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r166479151 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/Re

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r166478972 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/Re

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r166481485 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r166483863 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/T

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r166481095 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r166483613 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/T

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r166482739 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/

[GitHub] merlimat closed pull request #1191: Fix minor typo in documentation

merlimat closed pull request #1191: Fix minor typo in documentation URL: https://github.com/apache/incubator-pulsar/pull/1191 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[incubator-pulsar] branch master updated: Fix minor typo in documentation (#1191)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5645229 Fix minor typo in documentati

[GitHub] merlimat commented on a change in pull request #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader

merlimat commented on a change in pull request #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r166475429 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/Producer

[GitHub] merlimat commented on a change in pull request #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader

merlimat commented on a change in pull request #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r166474602 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientBu

[GitHub] merlimat commented on a change in pull request #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader

merlimat commented on a change in pull request #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r166474435 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/Producer

[GitHub] merlimat commented on issue #1147: Add support for new configration interface to AuthenticaionTls

merlimat commented on issue #1147: Add support for new configration interface to AuthenticaionTls URL: https://github.com/apache/incubator-pulsar/pull/1147#issuecomment-363598952 @maskit It appears there's a genuine test failure: https://builds.apache.org/job/pulsar-pull-request/1506/

[GitHub] Licht-T commented on issue #1183: Apply make format into Python C++ wrapper client

Licht-T commented on issue #1183: Apply make format into Python C++ wrapper client URL: https://github.com/apache/incubator-pulsar/pull/1183#issuecomment-363597808 Thanks @merlimat, these are now in the target of `make format`! --

[GitHub] merlimat commented on issue #1178: Validate topic name on broker side

merlimat commented on issue #1178: Validate topic name on broker side URL: https://github.com/apache/incubator-pulsar/pull/1178#issuecomment-363596104 @jai1 Addressed comments This is an automated message from the Apache Git S

[GitHub] jai1 commented on a change in pull request #1178: Validate topic name on broker side

jai1 commented on a change in pull request #1178: Validate topic name on broker side URL: https://github.com/apache/incubator-pulsar/pull/1178#discussion_r166470421 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -273,33 +27

[GitHub] merlimat commented on a change in pull request #1178: Validate topic name on broker side

merlimat commented on a change in pull request #1178: Validate topic name on broker side URL: https://github.com/apache/incubator-pulsar/pull/1178#discussion_r166470039 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -273,33

[GitHub] jai1 commented on a change in pull request #1178: Validate topic name on broker side

jai1 commented on a change in pull request #1178: Validate topic name on broker side URL: https://github.com/apache/incubator-pulsar/pull/1178#discussion_r166469693 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -273,33 +27

[GitHub] jai1 opened a new pull request #1192: Proxy roles enforcement

jai1 opened a new pull request #1192: Proxy roles enforcement URL: https://github.com/apache/incubator-pulsar/pull/1192 This PR fixes a bug in #1168 where there was wasteful assignment and memory leak of Bytebuf even in cases where originalPrincipal was valid. @merlimat - Thanks

[GitHub] merlimat commented on issue #1185: Fixed storage latency stats with Prometheus

merlimat commented on issue #1185: Fixed storage latency stats with Prometheus URL: https://github.com/apache/incubator-pulsar/pull/1185#issuecomment-363591419 @rdhabalia @jai1 Added tests for the stats generator This is an au

[GitHub] awilliams opened a new pull request #1191: Fix minor typo in documentation

awilliams opened a new pull request #1191: Fix minor typo in documentation URL: https://github.com/apache/incubator-pulsar/pull/1191 ### Motivation Fixes a minor typo in the website documentation. ### Modifications ~~On redelivery, messages an be sent~~ On redelivery,

[incubator-pulsar] branch master updated: Upgrade to Netty-4.1.21 (#1189)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new d0bdab8 Upgrade to Netty-4.1.21 (#118

[GitHub] merlimat closed pull request #1189: Upgrade to Netty-4.1.21

merlimat closed pull request #1189: Upgrade to Netty-4.1.21 URL: https://github.com/apache/incubator-pulsar/pull/1189 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull reque

[GitHub] merlimat opened a new issue #1190: Deleting a topic should succeed even if data is gone from bookies

merlimat opened a new issue #1190: Deleting a topic should succeed even if data is gone from bookies URL: https://github.com/apache/incubator-pulsar/issues/1190 Expected behavior Tell us what should happen Actual behavior Tell us what happens instead ##

[GitHub] merlimat commented on issue #1178: Validate topic name on broker side

merlimat commented on issue #1178: Validate topic name on broker side URL: https://github.com/apache/incubator-pulsar/pull/1178#issuecomment-363535435 @jai1 @rdhabalia Updated This is an automated message from the Apache Git S

[GitHub] merlimat commented on a change in pull request #1168: Proxy roles enforcement

merlimat commented on a change in pull request #1168: Proxy roles enforcement URL: https://github.com/apache/incubator-pulsar/pull/1168#discussion_r166412985 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -196,6 +215,13 @@ p

[GitHub] merlimat opened a new pull request #1189: Upgrade to Netty-4.1.21

merlimat opened a new pull request #1189: Upgrade to Netty-4.1.21 URL: https://github.com/apache/incubator-pulsar/pull/1189 ### Motivation In #1169 we downgraded Netty from 4.1.20 to 4.1.19 because of the `ObjectCleaner` thread bug in netty/netty#7617 That issue was fixed in 4

[GitHub] rdhabalia commented on issue #1184: Add connection timeout for binary lookup request

rdhabalia commented on issue #1184: Add connection timeout for binary lookup request URL: https://github.com/apache/incubator-pulsar/pull/1184#issuecomment-363529671 retest this please This is an automated message from the Ap

[GitHub] rdhabalia commented on issue #1184: Add connection timeout for binary lookup request

rdhabalia commented on issue #1184: Add connection timeout for binary lookup request URL: https://github.com/apache/incubator-pulsar/pull/1184#issuecomment-363529671 retest this please This is an automated message from the Ap

[GitHub] merlimat closed pull request #1187: Performance producer was not using the max producer queue size argument

merlimat closed pull request #1187: Performance producer was not using the max producer queue size argument URL: https://github.com/apache/incubator-pulsar/pull/1187 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sak

[incubator-pulsar] branch master updated: Performance producer was not using the max producer queue size argument (#1187)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new d05f94d Performance producer was not

[GitHub] ivankelly opened a new pull request #1188: Notify topic of ledger when compaction finishes

ivankelly opened a new pull request #1188: Notify topic of ledger when compaction finishes URL: https://github.com/apache/incubator-pulsar/pull/1188 When the compactor finishes compacting a topic, it send a cumulative acknowledgement to the broker, containing the ledger ID that the topic

[GitHub] merlimat closed pull request #1136: Read compacted consumer flag

merlimat closed pull request #1136: Read compacted consumer flag URL: https://github.com/apache/incubator-pulsar/pull/1136 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Read compacted consumer flag (#1136)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b68cc80 Read compacted consumer flag

[GitHub] merlimat opened a new pull request #1187: Performance producer was not using the max producer queue size argument

merlimat opened a new pull request #1187: Performance producer was not using the max producer queue size argument URL: https://github.com/apache/incubator-pulsar/pull/1187 ### Motivation Perf producer tool is not using the max-outstanding messages parameter -

[GitHub] jai1 commented on issue #1169: Proxy forward auth data

jai1 commented on issue #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169#issuecomment-363503086 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] jai1 commented on issue #1147: Add support for new configration interface to AuthenticaionTls

jai1 commented on issue #1147: Add support for new configration interface to AuthenticaionTls URL: https://github.com/apache/incubator-pulsar/pull/1147#issuecomment-363501598 retest this please This is an automated message fr

[GitHub] jai1 commented on a change in pull request #1185: Fixed storage latency stats with Prometheus

jai1 commented on a change in pull request #1185: Fixed storage latency stats with Prometheus URL: https://github.com/apache/incubator-pulsar/pull/1185#discussion_r166381806 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator

[GitHub] jai1 commented on a change in pull request #1185: Fixed storage latency stats with Prometheus

jai1 commented on a change in pull request #1185: Fixed storage latency stats with Prometheus URL: https://github.com/apache/incubator-pulsar/pull/1185#discussion_r166381806 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator

[GitHub] jai1 commented on issue #1178: Validate topic name on broker side

jai1 commented on issue #1178: Validate topic name on broker side URL: https://github.com/apache/incubator-pulsar/pull/1178#issuecomment-363500373 retest this please This is an automated message from the Apache Git Service

[GitHub] jai1 commented on issue #1185: Fixed storage latency stats with Prometheus

jai1 commented on issue #1185: Fixed storage latency stats with Prometheus URL: https://github.com/apache/incubator-pulsar/pull/1185#issuecomment-363499208 retest this please This is an automated message from the Apache Git Se

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166354179 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166366783 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166352585 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166346611 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166340273 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166353404 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166369658 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166344905 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166357940 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166373380 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166351520 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166356965 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166365662 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r166350409 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] XiaoZYang opened a new pull request #1186: 1. add faq.md

XiaoZYang opened a new pull request #1186: 1. add faq.md URL: https://github.com/apache/incubator-pulsar/pull/1186 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ### Modifications add `faq.md`

[GitHub] ivankelly commented on a change in pull request #1136: Read compacted consumer flag

ivankelly commented on a change in pull request #1136: Read compacted consumer flag URL: https://github.com/apache/incubator-pulsar/pull/1136#discussion_r166268535 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerConfiguration.java ## @@ -270

[GitHub] maskit commented on issue #1147: Add support for new configration interface to AuthenticaionTls

maskit commented on issue #1147: Add support for new configration interface to AuthenticaionTls URL: https://github.com/apache/incubator-pulsar/pull/1147#issuecomment-363369545 Reverted the Map interface for auth factory and admin client. ---

[GitHub] yangl commented on issue #1163: Debump netty version by 1 due to ObjectCleaner bug

yangl commented on issue #1163: Debump netty version by 1 due to ObjectCleaner bug URL: https://github.com/apache/incubator-pulsar/pull/1163#issuecomment-363364888 The Netty 4.0.56.Final and 4.1.21.Final released and fix this bug ObjectCleanerThread must be a deamon thread to ensure