[GitHub] merlimat opened a new pull request #1204: Reduce size of buffer used to assemble batches

2018-02-07 Thread GitBox
merlimat opened a new pull request #1204: Reduce size of buffer used to assemble batches URL: https://github.com/apache/incubator-pulsar/pull/1204 ### Motivation The current implementation is using 128KB buffers to accumulate batches before sending. (128Kb is the max batch size, so

[GitHub] merlimat opened a new pull request #1203: Use duplicates when writing from ByteBuf pair to avoid multiple threads issues

2018-02-07 Thread GitBox
merlimat opened a new pull request #1203: Use duplicates when writing from ByteBuf pair to avoid multiple threads issues URL: https://github.com/apache/incubator-pulsar/pull/1203 ### Motivation This is a fix for #1201. The truncation happens when, during an unload, the topic m

[GitHub] merlimat opened a new pull request #1202: Perf producer was overriding the producer max queue size

2018-02-07 Thread GitBox
merlimat opened a new pull request #1202: Perf producer was overriding the producer max queue size URL: https://github.com/apache/incubator-pulsar/pull/1202 ### Motivation The perf-producer is overriding the producer queue size that is being set as a CLI argument. -

[GitHub] rdhabalia commented on issue #1200: Add pluggable authorization mechanism

2018-02-07 Thread GitBox
rdhabalia commented on issue #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#issuecomment-364003615 @merlimat addressed all the comments This is an automated message from

[GitHub] merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#issuecomment-363996211 retest this please This is an automated me

[GitHub] merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#issuecomment-363983405 retest this please This is an automated me

[GitHub] merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#issuecomment-363996211 retest this please This is an automated me

[GitHub] rdhabalia closed pull request #1184: Add connection timeout for binary lookup request

2018-02-07 Thread GitBox
rdhabalia closed pull request #1184: Add connection timeout for binary lookup request URL: https://github.com/apache/incubator-pulsar/pull/1184 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[incubator-pulsar] branch master updated: Add connection timeout for binary lookup request (#1184)

2018-02-07 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b7e2e7c Add connection timeout for

[GitHub] merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#issuecomment-363983405 retest this please This is an automated me

[incubator-pulsar] branch master updated: Notify topic of ledger when compaction finishes (#1188)

2018-02-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 11648aa Notify topic of ledger when c

[GitHub] merlimat closed pull request #1188: Notify topic of ledger when compaction finishes

2018-02-07 Thread GitBox
merlimat closed pull request #1188: Notify topic of ledger when compaction finishes URL: https://github.com/apache/incubator-pulsar/pull/1188 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] jai1 closed pull request #1169: Proxy forward auth data

2018-02-07 Thread GitBox
jai1 closed pull request #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (

[incubator-pulsar] branch master updated: Proxy forward auth data (#1169)

2018-02-07 Thread jai1
This is an automated email from the ASF dual-hosted git repository. jai1 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b429931 Proxy forward auth data (#1169)

[GitHub] rdhabalia commented on issue #1184: Add connection timeout for binary lookup request

2018-02-07 Thread GitBox
rdhabalia commented on issue #1184: Add connection timeout for binary lookup request URL: https://github.com/apache/incubator-pulsar/pull/1184#issuecomment-363975981 retest this please This is an automated message from the Ap

[GitHub] rdhabalia commented on issue #1184: Add connection timeout for binary lookup request

2018-02-07 Thread GitBox
rdhabalia commented on issue #1184: Add connection timeout for binary lookup request URL: https://github.com/apache/incubator-pulsar/pull/1184#issuecomment-363975981 retest this please This is an automated message from the Ap

[GitHub] merlimat closed pull request #1199: Improve website documentation

2018-02-07 Thread GitBox
merlimat closed pull request #1199: Improve website documentation URL: https://github.com/apache/incubator-pulsar/pull/1199 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Update website documentation verbiage (#1199)

2018-02-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 85cce73 Update website documentation

[GitHub] jai1 commented on issue #1169: Proxy forward auth data

2018-02-07 Thread GitBox
jai1 commented on issue #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169#issuecomment-363964788 @rdhabalia - handled your comments - hope to get a +1 from you This is an automated me

[GitHub] rdhabalia commented on a change in pull request #1200: Add pluggable authorization mechanism

2018-02-07 Thread GitBox
rdhabalia commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r166798596 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationProvider

[GitHub] rdhabalia commented on a change in pull request #1200: Add pluggable authorization mechanism

2018-02-07 Thread GitBox
rdhabalia commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r166798315 ## File path: conf/proxy.conf ## @@ -49,6 +49,9 @@ authenticationProviders= # Enforce authorization

[GitHub] rdhabalia commented on a change in pull request #1200: Add pluggable authorization mechanism

2018-02-07 Thread GitBox
rdhabalia commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r166798683 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationProvider

[GitHub] rdhabalia commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
rdhabalia commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#discussion_r166796692 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ## @@ -518,13 +

[GitHub] merlimat commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
merlimat commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#discussion_r166792874 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ## @@ -518,13 +5

[GitHub] merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism

2018-02-07 Thread GitBox
merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r166792434 ## File path: conf/proxy.conf ## @@ -49,6 +49,9 @@ authenticationProviders= # Enforce authorization

[GitHub] merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism

2018-02-07 Thread GitBox
merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r166792594 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/AuthorizationProducerConsumerTest.java

[GitHub] merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism

2018-02-07 Thread GitBox
merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r166792127 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationService.j

[GitHub] merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism

2018-02-07 Thread GitBox
merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r166791343 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationProvider.

[GitHub] merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism

2018-02-07 Thread GitBox
merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r166791914 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationProvider.

[GitHub] merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism

2018-02-07 Thread GitBox
merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r166791584 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationProvider.

[GitHub] rdhabalia commented on a change in pull request #1169: Proxy forward auth data

2018-02-07 Thread GitBox
rdhabalia commented on a change in pull request #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169#discussion_r166789025 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -215,10 +217,18 @@

[GitHub] merlimat closed pull request #1198: Simplify documentation for getting started

2018-02-07 Thread GitBox
merlimat closed pull request #1198: Simplify documentation for getting started URL: https://github.com/apache/incubator-pulsar/pull/1198 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Simplify documentation for getting started (#1198)

2018-02-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 750e1b5 Simplify documentation for ge

[GitHub] rdhabalia commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
rdhabalia commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#discussion_r166786396 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ## @@ -518,13 +

[GitHub] merlimat commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
merlimat commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#discussion_r166785499 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ## @@ -518,13 +5

[GitHub] rdhabalia commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
rdhabalia commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#discussion_r166782076 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ## @@ -518,13 +

[GitHub] rdhabalia opened a new pull request #1200: Add pluggable authorization service

2018-02-07 Thread GitBox
rdhabalia opened a new pull request #1200: Add pluggable authorization service URL: https://github.com/apache/incubator-pulsar/pull/1200 ### Motivation As discussed in #1072, some times, we require to add pluggable authorization in broker, proxy, websocket. ### Modifications

[GitHub] jai1 commented on issue #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
jai1 commented on issue #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#issuecomment-363921016 retest this please This is an automated messag

[GitHub] awilliams opened a new pull request #1199: Update website documentation verbiage

2018-02-07 Thread GitBox
awilliams opened a new pull request #1199: Update website documentation verbiage URL: https://github.com/apache/incubator-pulsar/pull/1199 ### Motivation Improve a paragraph in the website documentation. ### Modifications ```diff A valid implementation of a Pulsar cli

[GitHub] lucperkins opened a new pull request #1198: Simplify documentation for getting started

2018-02-07 Thread GitBox
lucperkins opened a new pull request #1198: Simplify documentation for getting started URL: https://github.com/apache/incubator-pulsar/pull/1198 ### Motivation As it stands, the barebones "getting started" documentation is too complex. It forces users to figure out if they need a so

[GitHub] jai1 commented on issue #1169: Proxy forward auth data

2018-02-07 Thread GitBox
jai1 commented on issue #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169#issuecomment-363892825 @merlimat @rdhabalia @saandrews - can I merge this or do you want to take one last look.

[GitHub] merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#issuecomment-363896549 @jai1 Added fix for C++ consumer, PTAL

[GitHub] merlimat commented on a change in pull request #1172: Improve retention and expiry documentation (WIP)

2018-02-07 Thread GitBox
merlimat commented on a change in pull request #1172: Improve retention and expiry documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1172#discussion_r166741846 ## File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md ## @@ -266,13 +2

[GitHub] lucperkins commented on a change in pull request #1172: Improve retention and expiry documentation (WIP)

2018-02-07 Thread GitBox
lucperkins commented on a change in pull request #1172: Improve retention and expiry documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1172#discussion_r166739011 ## File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md ## @@ -266,13

[GitHub] jai1 commented on issue #1169: Proxy forward auth data

2018-02-07 Thread GitBox
jai1 commented on issue #1169: Proxy forward auth data URL: https://github.com/apache/incubator-pulsar/pull/1169#issuecomment-363892825 @merlimat @rdhabalia - can I merge this or do you want to take one last look. This is an a

[GitHub] merlimat closed pull request #1197: Update website documentation verbiage

2018-02-07 Thread GitBox
merlimat closed pull request #1197: Update website documentation verbiage URL: https://github.com/apache/incubator-pulsar/pull/1197 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[incubator-pulsar] branch master updated: Update website documentation verbiage (#1197)

2018-02-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 71cf49b Update website documentation

[incubator-pulsar] branch master updated: Add support for new interface to AuthenticaionTls (#1147)

2018-02-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8d88407 Add support for new interface

[GitHub] merlimat closed pull request #1147: Add support for new configration interface to AuthenticaionTls

2018-02-07 Thread GitBox
merlimat closed pull request #1147: Add support for new configration interface to AuthenticaionTls URL: https://github.com/apache/incubator-pulsar/pull/1147 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov

[GitHub] awilliams opened a new pull request #1197: Update website documentation verbiage

2018-02-07 Thread GitBox
awilliams opened a new pull request #1197: Update website documentation verbiage URL: https://github.com/apache/incubator-pulsar/pull/1197 ### Motivation Update a phrase on the website documentation to read better. ### Modifications ```diff - The TCP connection is not

[GitHub] merlimat commented on issue #1152: Change default pulsar stanalone behavior

2018-02-07 Thread GitBox
merlimat commented on issue #1152: Change default pulsar stanalone behavior URL: https://github.com/apache/incubator-pulsar/issues/1152#issuecomment-363842493 We should make the Standalone service to behave like the Proxy. Currently, the Pulsar standalone service is a very regular Pu

[GitHub] merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#issuecomment-363838023 retest this please This is an automated me

[GitHub] merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
merlimat commented on issue #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#issuecomment-363838023 retest this please This is an automated me

[incubator-pulsar] branch master updated: Fix: invalid authprovider value from config (#1196)

2018-02-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new dbbb79c Fix: invalid authprovider val

[GitHub] merlimat closed pull request #1196: Fix: invalid authprovider value from config

2018-02-07 Thread GitBox
merlimat closed pull request #1196: Fix: invalid authprovider value from config URL: https://github.com/apache/incubator-pulsar/pull/1196 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] maskit commented on issue #1147: Add support for new configration interface to AuthenticaionTls

2018-02-07 Thread GitBox
maskit commented on issue #1147: Add support for new configration interface to AuthenticaionTls URL: https://github.com/apache/incubator-pulsar/pull/1147#issuecomment-363819246 AuthenticationTls used wrong config parser (JSON). It should be fixed. --

[GitHub] sschepens commented on issue #1184: Add connection timeout for binary lookup request

2018-02-07 Thread GitBox
sschepens commented on issue #1184: Add connection timeout for binary lookup request URL: https://github.com/apache/incubator-pulsar/pull/1184#issuecomment-363793436 :+1: we've been having issues with this This is an automate

[GitHub] maskit commented on issue #1063: ENH: Add code formatter for Java

2018-02-07 Thread GitBox
maskit commented on issue #1063: ENH: Add code formatter for Java URL: https://github.com/apache/incubator-pulsar/pull/1063#issuecomment-363740425 I'm basically +1 on this, but I'm not sure `clean` is an appropriate phase. People might be confused if code was modified when they run `mvn cle

[GitHub] maskit commented on issue #1196: Fix: invalid authprovider value from config

2018-02-07 Thread GitBox
maskit commented on issue #1196: Fix: invalid authprovider value from config URL: https://github.com/apache/incubator-pulsar/pull/1196#issuecomment-363735127 retest this please This is an automated message from the Apache Git

[GitHub] rdhabalia commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
rdhabalia commented on a change in pull request #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195#discussion_r166560354 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Produ

[GitHub] rdhabalia commented on issue #1184: Add connection timeout for binary lookup request

2018-02-07 Thread GitBox
rdhabalia commented on issue #1184: Add connection timeout for binary lookup request URL: https://github.com/apache/incubator-pulsar/pull/1184#issuecomment-363704342 retest this please This is an automated message from the Ap

[GitHub] rdhabalia commented on issue #1184: Add connection timeout for binary lookup request

2018-02-07 Thread GitBox
rdhabalia commented on issue #1184: Add connection timeout for binary lookup request URL: https://github.com/apache/incubator-pulsar/pull/1184#issuecomment-363704342 retest this please This is an automated message from the Ap

[GitHub] rdhabalia opened a new pull request #1196: Fix: invalid authprovider value from config

2018-02-07 Thread GitBox
rdhabalia opened a new pull request #1196: Fix: invalid authprovider value from config URL: https://github.com/apache/incubator-pulsar/pull/1196 ### Motivation Remove incorrect value of the auth-provider. This is a

[GitHub] merlimat commented on issue #986: Bug: Download page must include KEYS, sig and hashes

2018-02-07 Thread GitBox
merlimat commented on issue #986: Bug: Download page must include KEYS, sig and hashes URL: https://github.com/apache/incubator-pulsar/issues/986#issuecomment-363699044 @sebbASF I think that finally I should have captured all the points. Thanks for explaining multiple times!

[GitHub] merlimat opened a new pull request #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-07 Thread GitBox
merlimat opened a new pull request #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195 ### Motivation The broker is validating the checksum calculated by the producer but it's not resetting the index to