[GitHub] merlimat closed pull request #1434: Move config subscriptionInitialPosition from parameter into ConfigurationData

2018-03-23 Thread GitBox
merlimat closed pull request #1434: Move config subscriptionInitialPosition from parameter into ConfigurationData URL: https://github.com/apache/incubator-pulsar/pull/1434 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[incubator-pulsar] branch master updated: move subscriptionInitialPosition from parameter into ConfigurationData (#1434)

2018-03-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6424b6e move

[GitHub] merlimat closed pull request #1421: Fix Python example class name

2018-03-23 Thread GitBox
merlimat closed pull request #1421: Fix Python example class name URL: https://github.com/apache/incubator-pulsar/pull/1421 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: Fix Python example class name (#1421)

2018-03-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a4174a5 Fix Python example class

[incubator-pulsar] branch master updated: Publish the distribution to maven artifact (#1430)

2018-03-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a5006b0 Publish the distribution to

[GitHub] maskit opened a new issue #1435: Build fails with JDK10 due to Lombok

2018-03-23 Thread GitBox
maskit opened a new issue #1435: Build fails with JDK10 due to Lombok URL: https://github.com/apache/incubator-pulsar/issues/1435 Expected behavior Build succeeds with JDK10. Actual behavior Build fails. ``` [INFO] --- maven-compiler-plugin:3.7.0:compile

[GitHub] sijie commented on a change in pull request #1424: Improve batch message acking by removing batch message tracker

2018-03-23 Thread GitBox
sijie commented on a change in pull request #1424: Improve batch message acking by removing batch message tracker URL: https://github.com/apache/incubator-pulsar/pull/1424#discussion_r176897753 ## File path:

[GitHub] maskit commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-23 Thread GitBox
maskit commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-375840518 retest this please This is an automated message from the Apache Git

[GitHub] zhaijack opened a new pull request #1434: Move subscriptionInitialPosition from parameter into ConfigurationData

2018-03-23 Thread GitBox
zhaijack opened a new pull request #1434: Move subscriptionInitialPosition from parameter into ConfigurationData URL: https://github.com/apache/incubator-pulsar/pull/1434 ### Motivation Seems subscriptionInitialPosition was not passed down success, and There was some redundant to

[GitHub] merlimat closed pull request #1407: Clarify in docs that admin is separate module

2018-03-23 Thread GitBox
merlimat closed pull request #1407: Clarify in docs that admin is separate module URL: https://github.com/apache/incubator-pulsar/pull/1407 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: Clarify in docs that admin is separate module (#1407)

2018-03-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 561d954 Clarify in docs that admin

[incubator-pulsar] branch master updated: change ruby version in Gemfile and update README (#1413)

2018-03-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 89ca249 change ruby version in

[GitHub] merlimat closed pull request #1413: Fix Ruby version error

2018-03-23 Thread GitBox
merlimat closed pull request #1413: Fix Ruby version error URL: https://github.com/apache/incubator-pulsar/pull/1413 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] merlimat closed pull request #1429: Add v2 support to the websockets endpoints.

2018-03-23 Thread GitBox
merlimat closed pull request #1429: Add v2 support to the websockets endpoints. URL: https://github.com/apache/incubator-pulsar/pull/1429 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[incubator-pulsar] branch master updated: Add v2 support to the websockets endpoints. (#1429)

2018-03-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new d11ae4d Add v2 support to the

[GitHub] zubchenok commented on issue #1432: [idea] NamespaceProducer

2018-03-23 Thread GitBox
zubchenok commented on issue #1432: [idea] NamespaceProducer URL: https://github.com/apache/incubator-pulsar/issues/1432#issuecomment-375830126 This is really needed to implement an efficient way for millions to millions messaging.

[GitHub] sijie commented on issue #1432: [idea] NamespaceProducer

2018-03-23 Thread GitBox
sijie commented on issue #1432: [idea] NamespaceProducer URL: https://github.com/apache/incubator-pulsar/issues/1432#issuecomment-375822695 this is an idea brought up at pulsar slack channel. bringing it up here to see what people is thinking about this.

[GitHub] sijie opened a new issue #1432: [idea] NamespaceProducer

2018-03-23 Thread GitBox
sijie opened a new issue #1432: [idea] NamespaceProducer URL: https://github.com/apache/incubator-pulsar/issues/1432 *Problem* If a namespace has lots of topics and each topic might have relative low traffic, it is not every efficient to create a producer for each topic. It

[GitHub] sijie commented on a change in pull request #1431: Add additional checks for Pulsar Function jar submission

2018-03-23 Thread GitBox
sijie commented on a change in pull request #1431: Add additional checks for Pulsar Function jar submission URL: https://github.com/apache/incubator-pulsar/pull/1431#discussion_r176884808 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java

[GitHub] merlimat commented on a change in pull request #1424: Improve batch message acking by removing batch message tracker

2018-03-23 Thread GitBox
merlimat commented on a change in pull request #1424: Improve batch message acking by removing batch message tracker URL: https://github.com/apache/incubator-pulsar/pull/1424#discussion_r176884704 ## File path:

[GitHub] lucperkins opened a new pull request #1431: Add additional checks for Pulsar Function jar submission

2018-03-23 Thread GitBox
lucperkins opened a new pull request #1431: Add additional checks for Pulsar Function jar submission URL: https://github.com/apache/incubator-pulsar/pull/1431 This PR adds more fine-tuned error reporting for submitting Pulsar Function jars. There are now specific errors provided when:

[GitHub] ivankelly commented on issue #1399: Integration smoke test for pulsar

2018-03-23 Thread GitBox
ivankelly commented on issue #1399: Integration smoke test for pulsar URL: https://github.com/apache/incubator-pulsar/pull/1399#issuecomment-375787744 retest this please This is an automated message from the Apache Git

[GitHub] ivankelly commented on issue #1427: Add batching support to compaction

2018-03-23 Thread GitBox
ivankelly commented on issue #1427: Add batching support to compaction URL: https://github.com/apache/incubator-pulsar/pull/1427#issuecomment-375787630 retest this please This is an automated message from the Apache Git

[GitHub] jai1 commented on issue #1425: Using correct flag (isReplicationTlsEnabled) for redirection for dele…

2018-03-23 Thread GitBox
jai1 commented on issue #1425: Using correct flag (isReplicationTlsEnabled) for redirection for dele… URL: https://github.com/apache/incubator-pulsar/pull/1425#issuecomment-375786298 retest this please This is an automated

[GitHub] sijie commented on a change in pull request #1424: Improve batch message acking by removing batch message tracker

2018-03-23 Thread GitBox
sijie commented on a change in pull request #1424: Improve batch message acking by removing batch message tracker URL: https://github.com/apache/incubator-pulsar/pull/1424#discussion_r176836877 ## File path:

[GitHub] sijie commented on issue #1421: Fix Python example class name

2018-03-23 Thread GitBox
sijie commented on issue #1421: Fix Python example class name URL: https://github.com/apache/incubator-pulsar/pull/1421#issuecomment-375764740 retest this please This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on issue #1419: Pulsar standalone fails to start with java 9

2018-03-23 Thread GitBox
sijie commented on issue #1419: Pulsar standalone fails to start with java 9 URL: https://github.com/apache/incubator-pulsar/issues/1419#issuecomment-375764386 @maskit yes. that is the issue. This is an automated message

[GitHub] sijie commented on issue #1430: Publish the distribution to maven artifact

2018-03-23 Thread GitBox
sijie commented on issue #1430: Publish the distribution to maven artifact URL: https://github.com/apache/incubator-pulsar/pull/1430#issuecomment-375762354 Not sure if that is the right approach here. But raising this up for discussions. Because the tgz can be large though.

[GitHub] sijie opened a new pull request #1430: Publish the distribution to maven artifact

2018-03-23 Thread GitBox
sijie opened a new pull request #1430: Publish the distribution to maven artifact URL: https://github.com/apache/incubator-pulsar/pull/1430 ### Motivation Currently we only stage artifacts to staging repository. For pulsar functions, if people want to try it out, there is no way to

[GitHub] merlimat commented on issue #1413: Fix Ruby version error

2018-03-23 Thread GitBox
merlimat commented on issue #1413: Fix Ruby version error URL: https://github.com/apache/incubator-pulsar/pull/1413#issuecomment-375741491 retest this please This is an automated message from the Apache Git Service. To

[GitHub] rdhabalia commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split

2018-03-23 Thread GitBox
rdhabalia commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428#discussion_r176807987 ## File path:

[GitHub] rdhabalia commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split

2018-03-23 Thread GitBox
rdhabalia commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428#discussion_r176806478 ## File path:

[GitHub] rdhabalia commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split

2018-03-23 Thread GitBox
rdhabalia commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428#discussion_r176805604 ## File path:

[GitHub] rdhabalia commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split

2018-03-23 Thread GitBox
rdhabalia commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428#discussion_r176805604 ## File path:

[GitHub] merlimat commented on issue #1426: Increase timeout on ReplicatorTest#testCloseReplicatorStartProducer

2018-03-23 Thread GitBox
merlimat commented on issue #1426: Increase timeout on ReplicatorTest#testCloseReplicatorStartProducer URL: https://github.com/apache/incubator-pulsar/pull/1426#issuecomment-375736462 retest this please This is an automated

[GitHub] merlimat commented on a change in pull request #1424: Improve batch message acking by removing batch message tracker

2018-03-23 Thread GitBox
merlimat commented on a change in pull request #1424: Improve batch message acking by removing batch message tracker URL: https://github.com/apache/incubator-pulsar/pull/1424#discussion_r176797992 ## File path:

[GitHub] merlimat commented on a change in pull request #1424: Improve batch message acking by removing batch message tracker

2018-03-23 Thread GitBox
merlimat commented on a change in pull request #1424: Improve batch message acking by removing batch message tracker URL: https://github.com/apache/incubator-pulsar/pull/1424#discussion_r176799744 ## File path:

[GitHub] merlimat commented on issue #1407: Clarify in docs that admin is separate module

2018-03-23 Thread GitBox
merlimat commented on issue #1407: Clarify in docs that admin is separate module URL: https://github.com/apache/incubator-pulsar/pull/1407#issuecomment-375725623 @ivankelly I'd leave the maven snippet (Don't care much about gradle since I don't use it :) ), since it's visually easy to

[GitHub] merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints.

2018-03-23 Thread GitBox
merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints. URL: https://github.com/apache/incubator-pulsar/pull/1410#issuecomment-375724711 retest this please This is an automated message from

[GitHub] merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints.

2018-03-23 Thread GitBox
merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints. URL: https://github.com/apache/incubator-pulsar/pull/1410#issuecomment-375724711 retest this please This is an automated message from

[GitHub] merlimat commented on issue #1388: Intermittent test failures in BrokerBkEnsemblesTests.testSkipCorruptDataLedger()

2018-03-23 Thread GitBox
merlimat commented on issue #1388: Intermittent test failures in BrokerBkEnsemblesTests.testSkipCorruptDataLedger() URL: https://github.com/apache/incubator-pulsar/issues/1388#issuecomment-375723833 @rdhabalia I'm seeing this multiple times. Would it make sense to increase the timeout

[GitHub] merlimat commented on issue #1428: Issue #1117: handle race in concurrent bundle split

2018-03-23 Thread GitBox
merlimat commented on issue #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428#issuecomment-375721049 @rdhabalia Please take a look as well This is an

[GitHub] merlimat commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split

2018-03-23 Thread GitBox
merlimat commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428#discussion_r176787527 ## File path:

[GitHub] merlimat commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split

2018-03-23 Thread GitBox
merlimat commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428#discussion_r176787833 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java

[GitHub] merlimat commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split

2018-03-23 Thread GitBox
merlimat commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428#discussion_r176786925 ## File path:

[GitHub] merlimat commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split

2018-03-23 Thread GitBox
merlimat commented on a change in pull request #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428#discussion_r176788666 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java

[GitHub] cckellogg opened a new pull request #1429: Add v2 support to the websockets endpoints.

2018-03-23 Thread GitBox
cckellogg opened a new pull request #1429: Add v2 support to the websockets endpoints. URL: https://github.com/apache/incubator-pulsar/pull/1429 Add v2 support for websockets. This is an automated message from the Apache Git

[GitHub] zhaijack opened a new pull request #1428: Issue #1117: handle race in concurrent bundle split

2018-03-23 Thread GitBox
zhaijack opened a new pull request #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428 ### Motivation in `NamespaceService.splitAndOwnBundle()`. The concurrent update of Policies of same namespace will cause some

[GitHub] maskit commented on issue #1413: Fix Ruby version error

2018-03-23 Thread GitBox
maskit commented on issue #1413: Fix Ruby version error URL: https://github.com/apache/incubator-pulsar/pull/1413#issuecomment-375663092 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] maskit commented on a change in pull request #1248: Start Proxy in TLS only mode.

2018-03-23 Thread GitBox
maskit commented on a change in pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#discussion_r176723683 ## File path: conf/broker.conf ## @@ -29,13 +29,13 @@ globalZookeeperServers= brokerServicePort=6650 #

[GitHub] maskit commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-23 Thread GitBox
maskit commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-375650471 retest this please This is an automated message from the Apache Git

[GitHub] maskit commented on a change in pull request #1297: Add Configuration to set tlsClientAuth

2018-03-23 Thread GitBox
maskit commented on a change in pull request #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#discussion_r176719660 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/TlsProducerConsumerBase.java

[GitHub] ivankelly opened a new pull request #1427: Add batching support to compaction

2018-03-23 Thread GitBox
ivankelly opened a new pull request #1427: Add batching support to compaction URL: https://github.com/apache/incubator-pulsar/pull/1427 With this patch compaction can select to keep only some of the submessages from a batch.

[GitHub] ivankelly opened a new pull request #1426: Increase timeout on ReplicatorTest#testCloseReplicatorStartProducer

2018-03-23 Thread GitBox
ivankelly opened a new pull request #1426: Increase timeout on ReplicatorTest#testCloseReplicatorStartProducer URL: https://github.com/apache/incubator-pulsar/pull/1426 A good run takes around 3.5 seconds, so it doesn't take much to push it past 5 seconds. Increased timeout to 15