[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-384160243 retest this please This is an automated message from the

[GitHub] zhaijack commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
zhaijack commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-384160243 retest this please for `org.apache.pulsar.broker.service.PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition`

[incubator-pulsar] branch master updated: Rename Connect `Message` interface to `Record` (#1636)

2018-04-24 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1fad36b Rename Connect `Message`

[GitHub] sijie closed pull request #1636: Rename Connect `Message` interface to `Record`

2018-04-24 Thread GitBox
sijie closed pull request #1636: Rename Connect `Message` interface to `Record` URL: https://github.com/apache/incubator-pulsar/pull/1636 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] sijie commented on issue #1549: offloadPrefix implementation for managed ledger

2018-04-24 Thread GitBox
sijie commented on issue #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#issuecomment-384078153 @ivankelly I think you might have to rebase this PR to latest master. I found the failures come from policies not found, seems

[GitHub] sijie commented on issue #1585: Default schemas

2018-04-24 Thread GitBox
sijie commented on issue #1585: Default schemas URL: https://github.com/apache/incubator-pulsar/pull/1585#issuecomment-384077484 @lucperkins `DefaultSchemasTest.testIntegerSchema` is failing This is an automated message from

[GitHub] sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183876408 ## File path:

[GitHub] sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183874978 ## File path:

[GitHub] sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183874835 ## File path:

[GitHub] sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183875713 ## File path:

[GitHub] sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183874711 ## File path:

[GitHub] sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
sijie commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183873291 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/OffloadIndexBlock.java

[GitHub] sijie commented on issue #1549: offloadPrefix implementation for managed ledger

2018-04-24 Thread GitBox
sijie commented on issue #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#issuecomment-384072923 retest this please This is an automated message from the Apache

[GitHub] sijie commented on issue #1634: In pulsar admin Java API, unified persistent vs non-persistent into "topics()"

2018-04-24 Thread GitBox
sijie commented on issue #1634: In pulsar admin Java API, unified persistent vs non-persistent into "topics()" URL: https://github.com/apache/incubator-pulsar/pull/1634#issuecomment-384071072 @merlimat I think this breaks the admin api related tests.

[GitHub] srkukarni commented on issue #1505: Proxy admin web requests

2018-04-24 Thread GitBox
srkukarni commented on issue #1505: Proxy admin web requests URL: https://github.com/apache/incubator-pulsar/pull/1505#issuecomment-384046003 retest this please This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on issue #1505: Proxy admin web requests

2018-04-24 Thread GitBox
sijie commented on issue #1505: Proxy admin web requests URL: https://github.com/apache/incubator-pulsar/pull/1505#issuecomment-384022588 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] sijie opened a new issue #1638: Improve the k8s deployment documentation

2018-04-24 Thread GitBox
sijie opened a new issue #1638: Improve the k8s deployment documentation URL: https://github.com/apache/incubator-pulsar/issues/1638 Context: ``` Byron [5:31 AM] so it turns out that when using `hostPath` for a volume.. it will retain the data on the host even after the

[GitHub] lucperkins commented on a change in pull request #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function

2018-04-24 Thread GitBox
lucperkins commented on a change in pull request #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function URL: https://github.com/apache/incubator-pulsar/pull/1594#discussion_r183810678 ## File path:

[GitHub] lucperkins commented on a change in pull request #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function

2018-04-24 Thread GitBox
lucperkins commented on a change in pull request #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function URL: https://github.com/apache/incubator-pulsar/pull/1594#discussion_r183810678 ## File path:

[GitHub] lucperkins commented on issue #1507: Using Pulsar as a message queue (cookbook)

2018-04-24 Thread GitBox
lucperkins commented on issue #1507: Using Pulsar as a message queue (cookbook) URL: https://github.com/apache/incubator-pulsar/pull/1507#issuecomment-384006896 @merlimat Okay, I've made the requested changes. Ready for review.

[GitHub] lucperkins commented on a change in pull request #1507: Using Pulsar as a message queue (cookbook)

2018-04-24 Thread GitBox
lucperkins commented on a change in pull request #1507: Using Pulsar as a message queue (cookbook) URL: https://github.com/apache/incubator-pulsar/pull/1507#discussion_r180510283 ## File path: site/docs/latest/cookbooks/message-queue.md ## @@ -0,0 +1,89 @@ +--- +title:

[GitHub] bardock commented on issue #1625: Bookie's AutoRecovery affects publish times

2018-04-24 Thread GitBox
bardock commented on issue #1625: Bookie's AutoRecovery affects publish times URL: https://github.com/apache/incubator-pulsar/issues/1625#issuecomment-383966819 @merlimat, Do you have any thoughts on this? Thanks! This is

[GitHub] ivankelly commented on issue #1637: LedgerOffloader interface allows two phase update

2018-04-24 Thread GitBox
ivankelly commented on issue #1637: LedgerOffloader interface allows two phase update URL: https://github.com/apache/incubator-pulsar/pull/1637#issuecomment-383955681 retest this please // V1_ReplicatorTest.testCloseReplicatorStartProducer

[GitHub] zhaijack commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
zhaijack commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183752765 ## File path:

[GitHub] HaraldGustafsson commented on issue #1633: Admin REST-API from a python client

2018-04-24 Thread GitBox
HaraldGustafsson commented on issue #1633: Admin REST-API from a python client URL: https://github.com/apache/incubator-pulsar/issues/1633#issuecomment-383938117 Just realized that the parameter in the body should not be `{"actions": ["consume", "produce"]}` it should be `[0, 1]`. But

[GitHub] ivankelly commented on issue #1637: LedgerOffloader interface allows two phase update

2018-04-24 Thread GitBox
ivankelly commented on issue #1637: LedgerOffloader interface allows two phase update URL: https://github.com/apache/incubator-pulsar/pull/1637#issuecomment-383911869 @sijie Will rebase #1549 on this, when this is merged.

[GitHub] ivankelly opened a new pull request #1637: LedgerOffloader interface allows two phase update

2018-04-24 Thread GitBox
ivankelly opened a new pull request #1637: LedgerOffloader interface allows two phase update URL: https://github.com/apache/incubator-pulsar/pull/1637 This patch modifies the LedgerOffloader interface to allow the caller to first record that parameters used for an offload, and then

[GitHub] ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183663105 ## File path:

[GitHub] ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183664823 ## File path:

[GitHub] ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183666210 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/OffloadIndexBlock.java

[GitHub] ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183670561 ## File path:

[GitHub] ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183662825 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/OffloadIndexBlock.java

[GitHub] ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183667630 ## File path:

[GitHub] ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183670708 ## File path:

[GitHub] ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload.

2018-04-24 Thread GitBox
ivankelly commented on a change in pull request #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r183666499 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/OffloadIndexBlock.java

[incubator-pulsar] branch asf-site updated: Updated site at revision dd601b7

2018-04-24 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new adf2f37 Updated site at revision

[GitHub] sijie commented on a change in pull request #1636: Rename Connect `Message` interface to `Record`

2018-04-24 Thread GitBox
sijie commented on a change in pull request #1636: Rename Connect `Message` interface to `Record` URL: https://github.com/apache/incubator-pulsar/pull/1636#discussion_r183625515 ## File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java ##

[GitHub] sijie commented on a change in pull request #1636: Rename Connect `Message` interface to `Record`

2018-04-24 Thread GitBox
sijie commented on a change in pull request #1636: Rename Connect `Message` interface to `Record` URL: https://github.com/apache/incubator-pulsar/pull/1636#discussion_r183625045 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageRecordImpl.java