[GitHub] rdhabalia removed a comment on issue #2057: Forward user-properties to sink

2018-06-30 Thread GitBox
rdhabalia removed a comment on issue #2057: Forward user-properties to sink URL: https://github.com/apache/incubator-pulsar/pull/2057#issuecomment-401583939 retest this please This is an automated message from the Apache Git S

[incubator-pulsar] branch master updated: fix bug with specifying jar via config file (#2053)

2018-06-30 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new f14b9e9 fix bug with specifying jar vi

[GitHub] sijie commented on issue #2052: fix bug in concerning ContextImpl

2018-06-30 Thread GitBox
sijie commented on issue #2052: fix bug in concerning ContextImpl URL: https://github.com/apache/incubator-pulsar/pull/2052#issuecomment-401585138 retest this please This is an automated message from the Apache Git Service. To

[GitHub] sijie closed pull request #2053: fix bug with specifying jar via config file

2018-06-30 Thread GitBox
sijie closed pull request #2053: fix bug with specifying jar via config file URL: https://github.com/apache/incubator-pulsar/pull/2053 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[incubator-pulsar] branch master updated: Add semantic integration tests for non-persistent topics and effectively-once producing (#2059)

2018-06-30 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new bee124e Add semantic integration tests

[GitHub] sijie closed pull request #2059: Add semantic integration tests for non-persistent topics and effectively-once producing

2018-06-30 Thread GitBox
sijie closed pull request #2059: Add semantic integration tests for non-persistent topics and effectively-once producing URL: https://github.com/apache/incubator-pulsar/pull/2059 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed belo

[GitHub] rdhabalia commented on a change in pull request #2058: Pulsar Kinesis-sink upgrade aws-sdk version

2018-06-30 Thread GitBox
rdhabalia commented on a change in pull request #2058: Pulsar Kinesis-sink upgrade aws-sdk version URL: https://github.com/apache/incubator-pulsar/pull/2058#discussion_r199338630 ## File path: pulsar-io/kinesis/pom.xml ## @@ -65,25 +65,20 @@ -com.amazo

[GitHub] rdhabalia commented on issue #2057: Forward user-properties to sink

2018-06-30 Thread GitBox
rdhabalia commented on issue #2057: Forward user-properties to sink URL: https://github.com/apache/incubator-pulsar/pull/2057#issuecomment-401583939 retest this please This is an automated message from the Apache Git Service.

[GitHub] sijie commented on issue #2060: Migrate CLI integration test mode to use testcontainers

2018-06-30 Thread GitBox
sijie commented on issue #2060: Migrate CLI integration test mode to use testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2060#issuecomment-401581393 Only change 15181fe is for being reviewed in this PR. Th

[GitHub] sijie opened a new pull request #2060: Integration tests/migrate cli

2018-06-30 Thread GitBox
sijie opened a new pull request #2060: Integration tests/migrate cli URL: https://github.com/apache/incubator-pulsar/pull/2060 This change is based on #2059 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie commented on issue #2059: Add semantic integration tests for non-persistent topics and effectively-once producing

2018-06-30 Thread GitBox
sijie commented on issue #2059: Add semantic integration tests for non-persistent topics and effectively-once producing URL: https://github.com/apache/incubator-pulsar/pull/2059#issuecomment-401580924 retest this please This

[GitHub] jerrypeng commented on issue #2052: fix bug in concerning ContextImpl

2018-06-30 Thread GitBox
jerrypeng commented on issue #2052: fix bug in concerning ContextImpl URL: https://github.com/apache/incubator-pulsar/pull/2052#issuecomment-401578969 retest please This is an automated message from the Apache Git Service. To

[GitHub] sijie opened a new pull request #2059: Add semantic integration tests for non-persistent topics and effectively-once producing

2018-06-30 Thread GitBox
sijie opened a new pull request #2059: Add semantic integration tests for non-persistent topics and effectively-once producing URL: https://github.com/apache/incubator-pulsar/pull/2059 This is an automated message from the A

[GitHub] jai1 commented on a change in pull request #2058: Pulsar Kinesis-sink upgrade aws-sdk version

2018-06-30 Thread GitBox
jai1 commented on a change in pull request #2058: Pulsar Kinesis-sink upgrade aws-sdk version URL: https://github.com/apache/incubator-pulsar/pull/2058#discussion_r199336061 ## File path: pulsar-io/kinesis/pom.xml ## @@ -65,25 +65,20 @@ Review comment:

[GitHub] jai1 commented on a change in pull request #2058: Pulsar Kinesis-sink upgrade aws-sdk version

2018-06-30 Thread GitBox
jai1 commented on a change in pull request #2058: Pulsar Kinesis-sink upgrade aws-sdk version URL: https://github.com/apache/incubator-pulsar/pull/2058#discussion_r199336064 ## File path: pulsar-io/kinesis/pom.xml ## @@ -65,25 +65,20 @@ -com.amazonaws

[GitHub] rdhabalia commented on issue #2058: Pulsar Kinesis-sink upgrade aws-sdk version

2018-06-30 Thread GitBox
rdhabalia commented on issue #2058: Pulsar Kinesis-sink upgrade aws-sdk version URL: https://github.com/apache/incubator-pulsar/pull/2058#issuecomment-401575858 @saandrews @jai1 can you please take a look. This is an automated

[GitHub] rdhabalia opened a new pull request #2058: Pulsar Kinesis-sink upgrade aws-sdk version

2018-06-30 Thread GitBox
rdhabalia opened a new pull request #2058: Pulsar Kinesis-sink upgrade aws-sdk version URL: https://github.com/apache/incubator-pulsar/pull/2058 ### Motivation Upgrade kinesis KPL and aws-sdk version for kinesis-sink. ### Result New KPL and aws-sdk version has bug-fixes

[GitHub] rdhabalia opened a new pull request #2057: Forward user-properties to sink

2018-06-30 Thread GitBox
rdhabalia opened a new pull request #2057: Forward user-properties to sink URL: https://github.com/apache/incubator-pulsar/pull/2057 ### Motivation While using pulsar-sink, sometimes application wants sink-impl to forward user-properties coming from the pulsar-source into the message

[incubator-pulsar] branch master updated: Introduce testcontainer based cluster integration tests (#2055)

2018-06-30 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4d1cf20 Introduce testcontainer based

[GitHub] sijie closed pull request #2055: Introduce testcontainer based cluster integration tests

2018-06-30 Thread GitBox
sijie closed pull request #2055: Introduce testcontainer based cluster integration tests URL: https://github.com/apache/incubator-pulsar/pull/2055 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[GitHub] mgodave edited a comment on issue #1303: RateLimiterTest is flaky

2018-06-30 Thread GitBox
mgodave edited a comment on issue #1303: RateLimiterTest is flaky URL: https://github.com/apache/incubator-pulsar/issues/1303#issuecomment-401570831 I'm looking through the Guava code and documentation to understand if the analysis in Pulsar's implementation is indeed accurate or even matt

[GitHub] rdhabalia removed a comment on issue #2024: Forward encryption properties with encrypted payload to consumer

2018-06-30 Thread GitBox
rdhabalia removed a comment on issue #2024: Forward encryption properties with encrypted payload to consumer URL: https://github.com/apache/incubator-pulsar/pull/2024#issuecomment-401571724 retest this please This is an autom

[GitHub] rdhabalia commented on issue #2024: Forward encryption properties with encrypted payload to consumer

2018-06-30 Thread GitBox
rdhabalia commented on issue #2024: Forward encryption properties with encrypted payload to consumer URL: https://github.com/apache/incubator-pulsar/pull/2024#issuecomment-401571724 retest this please This is an automated mes

[GitHub] mgodave commented on issue #1303: RateLimiterTest is flaky

2018-06-30 Thread GitBox
mgodave commented on issue #1303: RateLimiterTest is flaky URL: https://github.com/apache/incubator-pulsar/issues/1303#issuecomment-401570831 I'm looking through the Guava code and documentation to understand if the analysis in Pulsar's implementation is indeed accurate.

[GitHub] mgodave commented on issue #1303: RateLimiterTest is flaky

2018-06-30 Thread GitBox
mgodave commented on issue #1303: RateLimiterTest is flaky URL: https://github.com/apache/incubator-pulsar/issues/1303#issuecomment-401569992 OK, just had to reacquaint myself with the issue. The problem is that the entire test relies on "beating" the inherent race conditions between threa

[GitHub] mgodave commented on issue #1303: RateLimiterTest is flaky

2018-06-30 Thread GitBox
mgodave commented on issue #1303: RateLimiterTest is flaky URL: https://github.com/apache/incubator-pulsar/issues/1303#issuecomment-401568900 It's been awhile. Let me rerun and let you know. This is an automated message from

[GitHub] rdhabalia removed a comment on issue #2024: Forward encryption properties with encrypted payload to consumer

2018-06-30 Thread GitBox
rdhabalia removed a comment on issue #2024: Forward encryption properties with encrypted payload to consumer URL: https://github.com/apache/incubator-pulsar/pull/2024#issuecomment-401525147 retest this please This is an autom

[GitHub] rdhabalia removed a comment on issue #2024: Forward encryption properties with encrypted payload to consumer

2018-06-30 Thread GitBox
rdhabalia removed a comment on issue #2024: Forward encryption properties with encrypted payload to consumer URL: https://github.com/apache/incubator-pulsar/pull/2024#issuecomment-401561409 retest this please This is an autom

[GitHub] rdhabalia commented on issue #2024: Forward encryption properties with encrypted payload to consumer

2018-06-30 Thread GitBox
rdhabalia commented on issue #2024: Forward encryption properties with encrypted payload to consumer URL: https://github.com/apache/incubator-pulsar/pull/2024#issuecomment-401561409 retest this please This is an automated mes

[GitHub] sijie commented on issue #2055: Introduce testcontainer based cluster integration tests

2018-06-30 Thread GitBox
sijie commented on issue #2055: Introduce testcontainer based cluster integration tests URL: https://github.com/apache/incubator-pulsar/pull/2055#issuecomment-401556711 retest this please This is an automated message from the

[incubator-pulsar] branch asf-site updated: Updated site at revision 99c0ed2

2018-06-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 5baa167 Updated site at revision

[GitHub] ivankelly opened a new pull request #2056: Add authentication to admin proxy

2018-06-30 Thread GitBox
ivankelly opened a new pull request #2056: Add authentication to admin proxy URL: https://github.com/apache/incubator-pulsar/pull/2056 It turns out that the admin rest api proxy wasn't doing authentication at all, so if you can connect, you have access to the api at the same level as t

[GitHub] rdhabalia commented on issue #2024: Forward encryption properties with encrypted payload to consumer

2018-06-30 Thread GitBox
rdhabalia commented on issue #2024: Forward encryption properties with encrypted payload to consumer URL: https://github.com/apache/incubator-pulsar/pull/2024#issuecomment-401525147 retest this please This is an automated mes