[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1865: [SCB-2031] Fix mapping problem between pojo consumer method and provider swagger operation

2020-07-02 Thread GitBox
wujimin commented on a change in pull request #1865: URL: https://github.com/apache/servicecomb-java-chassis/pull/1865#discussion_r449155873 ## File path: swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/engine/SwaggerConsumer.java ##

[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1865: [SCB-2031] Fix mapping problem between pojo consumer method and provider swagger operation

2020-07-02 Thread GitBox
wujimin commented on a change in pull request #1865: URL: https://github.com/apache/servicecomb-java-chassis/pull/1865#discussion_r449154346 ## File path: swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/engine/SwaggerConsumer.java ##

[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1865: [SCB-2031] Fix mapping problem between pojo consumer method and provider swagger operation

2020-07-02 Thread GitBox
wujimin commented on a change in pull request #1865: URL: https://github.com/apache/servicecomb-java-chassis/pull/1865#discussion_r449153654 ## File path: providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/definition/PojoConsumerMeta.java ## @@ -33,7

[GitHub] [servicecomb-java-chassis] coveralls commented on pull request #1865: [SCB-2031] Fix mapping problem between pojo consumer method and provider swagger operation

2020-07-02 Thread GitBox
coveralls commented on pull request #1865: URL: https://github.com/apache/servicecomb-java-chassis/pull/1865#issuecomment-653120133 [![Coverage Status](https://coveralls.io/builds/31830812/badge)](https://coveralls.io/builds/31830812) Coverage increased (+0.01%) to 86.324% when

[GitHub] [servicecomb-java-chassis] coveralls commented on pull request #1864: [SCB-2030] add new invocation event to make extend features easier

2020-07-02 Thread GitBox
coveralls commented on pull request #1864: URL: https://github.com/apache/servicecomb-java-chassis/pull/1864#issuecomment-653082333 [![Coverage Status](https://coveralls.io/builds/31829284/badge)](https://coveralls.io/builds/31829284) Coverage decreased (-0.02%) to 86.293% when

[GitHub] [servicecomb-java-chassis] yhs0092 opened a new pull request #1865: [SCB-2031] Fix mapping problem between pojo consumer method and provider swagger operation

2020-07-02 Thread GitBox
yhs0092 opened a new pull request #1865: URL: https://github.com/apache/servicecomb-java-chassis/pull/1865 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed

[GitHub] [servicecomb-java-chassis] wujimin opened a new pull request #1864: [SCB-2030] add new invocation event to make extend features easier

2020-07-02 Thread GitBox
wujimin opened a new pull request #1864: URL: https://github.com/apache/servicecomb-java-chassis/pull/1864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[servicecomb-java-chassis] branch master updated: [SCB-2029] tiny improve to make extend filter features easier

2020-07-02 Thread liubao
This is an automated email from the ASF dual-hosted git repository. liubao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git The following commit(s) were added to refs/heads/master by this push: new 5f5264f [SCB-2029] tiny

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1863: [SCB-2029] tiny improve to make extend filter features easier

2020-07-02 Thread GitBox
liubao68 merged pull request #1863: URL: https://github.com/apache/servicecomb-java-chassis/pull/1863 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [servicecomb-service-center] ChinX commented on a change in pull request #660: add more action for code quality (#657)

2020-07-02 Thread GitBox
ChinX commented on a change in pull request #660: URL: https://github.com/apache/servicecomb-service-center/pull/660#discussion_r448904198 ## File path: syncer/samples/multi-servicecenters/servicecenter/hello-server/servicecenter/servicecenter.go ## @@ -20,20 +20,20 @@

[GitHub] [servicecomb-service-center] tianxiaoliang opened a new pull request #660: add more action for code quality (#657)

2020-07-02 Thread GitBox
tianxiaoliang opened a new pull request #660: URL: https://github.com/apache/servicecomb-service-center/pull/660 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB)

[GitHub] [servicecomb-service-center] tianxiaoliang closed pull request #659: add more action for code quality (#657)

2020-07-02 Thread GitBox
tianxiaoliang closed pull request #659: URL: https://github.com/apache/servicecomb-service-center/pull/659 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [servicecomb-service-center] tianxiaoliang opened a new pull request #659: add more action for code quality (#657)

2020-07-02 Thread GitBox
tianxiaoliang opened a new pull request #659: URL: https://github.com/apache/servicecomb-service-center/pull/659 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB)

[GitHub] [servicecomb-service-center] tianxiaoliang closed pull request #658: import go lint

2020-07-02 Thread GitBox
tianxiaoliang closed pull request #658: URL: https://github.com/apache/servicecomb-service-center/pull/658 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [servicecomb-java-chassis] coveralls commented on pull request #1863: [SCB-2029] tiny improve to make extend filter features easier

2020-07-02 Thread GitBox
coveralls commented on pull request #1863: URL: https://github.com/apache/servicecomb-java-chassis/pull/1863#issuecomment-652886673 [![Coverage Status](https://coveralls.io/builds/31820943/badge)](https://coveralls.io/builds/31820943) Coverage decreased (-0.005%) to 86.314%

[GitHub] [servicecomb-java-chassis] cmkcmk181 commented on issue #1859: 无法正确使用nacos,在nacos中配置路由不生效

2020-07-02 Thread GitBox
cmkcmk181 commented on issue #1859: URL: https://github.com/apache/servicecomb-java-chassis/issues/1859#issuecomment-652876560 我改为json的格式配置也不生效,我跟踪了代码发现以下if条件不满足,是不是和这个有关系? ![image](https://user-images.githubusercontent.com/8915324/86337381-9aad2e80-bc83-11ea-8dbb-7376da0fe2c1.png)

[GitHub] [servicecomb-java-chassis] Fang57 commented on issue #1849: 请求服务端接口报 Invoke all server failed

2020-07-02 Thread GitBox
Fang57 commented on issue #1849: URL: https://github.com/apache/servicecomb-java-chassis/issues/1849#issuecomment-652871390 handler: chain: Provider: default: qps-flowcontrol-provider Consumer: default: qps-flowcontrol-consumer,loadbalance