Re: [PR] [TINKERPOP-2979] added datetime() [tinkerpop]

2023-10-13 Thread via GitHub
codecov-commenter commented on PR #2289: URL: https://github.com/apache/tinkerpop/pull/2289#issuecomment-1762329987 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2289?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[PR] [TINKERPOP-2979] added datetime() [tinkerpop]

2023-10-13 Thread via GitHub
vkagamlyk opened a new pull request, #2289: URL: https://github.com/apache/tinkerpop/pull/2289 Function `datetime()` extended to return current server time when used without argument. ``` gremlin> datetime().toGMTString() ==>13 Oct 2023 20:44:20 GMT ``` -- This is an

Re: [PR] Fix Java driver HTTP connection request not encoding all args [tinkerpop]

2023-10-13 Thread via GitHub
xiazcy commented on code in PR #2284: URL: https://github.com/apache/tinkerpop/pull/2284#discussion_r1358912644 ## gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java: ## @@ -71,6 +71,7 @@ protected void encode(final

Re: [PR] Enable remote connection over HTTP for gremlin python [tinkerpop]

2023-10-13 Thread via GitHub
vkagamlyk commented on code in PR #2283: URL: https://github.com/apache/tinkerpop/pull/2283#discussion_r1358911155 ## gremlin-python/src/main/python/tests/process/test_translator.py: ## @@ -373,6 +374,30 @@ class SuperStr(str): tests.append([g.V().has("p1", None),

Re: [PR] Enable remote connection over HTTP for gremlin python [tinkerpop]

2023-10-13 Thread via GitHub
xiazcy commented on code in PR #2283: URL: https://github.com/apache/tinkerpop/pull/2283#discussion_r1358910305 ## gremlin-python/src/main/python/gremlin_python/driver/client.py: ## @@ -45,15 +46,20 @@ def __init__(self, url, traversal_source, protocol_factory=None,

Re: [PR] Enable remote connection over HTTP for gremlin python [tinkerpop]

2023-10-13 Thread via GitHub
xiazcy commented on code in PR #2283: URL: https://github.com/apache/tinkerpop/pull/2283#discussion_r1358910104 ## gremlin-python/src/main/python/tests/process/test_translator.py: ## @@ -373,6 +374,30 @@ class SuperStr(str): tests.append([g.V().has("p1", None),

Re: [PR] Enable remote connection over HTTP for gremlin python [tinkerpop]

2023-10-13 Thread via GitHub
kenhuuu commented on PR #2283: URL: https://github.com/apache/tinkerpop/pull/2283#issuecomment-1762107049 client and protocol have very similar code in lots of instances. I would consider refactoring by either adding in another class in-between to share functionality or move that shared

Re: [PR] Enable remote connection over HTTP for gremlin python [tinkerpop]

2023-10-13 Thread via GitHub
kenhuuu commented on code in PR #2283: URL: https://github.com/apache/tinkerpop/pull/2283#discussion_r1358753789 ## gremlin-python/src/main/python/gremlin_python/driver/client.py: ## @@ -45,15 +46,20 @@ def __init__(self, url, traversal_source, protocol_factory=None,

Re: [PR] Enable remote connection over HTTP for gremlin python [tinkerpop]

2023-10-13 Thread via GitHub
kenhuuu commented on code in PR #2283: URL: https://github.com/apache/tinkerpop/pull/2283#discussion_r1358752570 ## gremlin-python/src/main/python/gremlin_python/driver/aiohttp/transport.py: ## @@ -138,3 +138,104 @@ async def async_close(): def closed(self): #

Re: [PR] Fix Java driver HTTP connection request not encoding all args [tinkerpop]

2023-10-13 Thread via GitHub
kenhuuu commented on PR #2284: URL: https://github.com/apache/tinkerpop/pull/2284#issuecomment-1762098684 I'm not sure about the consequence of making this change but it seems to be needed to have parity with the WebSocket implementation so my VOTE is +1. -- This is an automated message

Re: [PR] Enable remote connection over HTTP for gremlin python [tinkerpop]

2023-10-13 Thread via GitHub
vkagamlyk commented on code in PR #2283: URL: https://github.com/apache/tinkerpop/pull/2283#discussion_r1358708186 ## gremlin-python/src/main/python/tests/process/test_translator.py: ## @@ -373,6 +374,30 @@ class SuperStr(str): tests.append([g.V().has("p1", None),

[tinkerpop] branch add-http-gremlin-python updated (8e2551703f -> e1da41d214)

2023-10-13 Thread xiazcy
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a change to branch add-http-gremlin-python in repository https://gitbox.apache.org/repos/asf/tinkerpop.git discard 8e2551703f Enable remote connection over HTTP for gremlin python add e1da41d214 Enable

[tinkerpop] branch add-http-gremlin-python updated (b2ef3dbb37 -> 8e2551703f)

2023-10-13 Thread xiazcy
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a change to branch add-http-gremlin-python in repository https://gitbox.apache.org/repos/asf/tinkerpop.git discard b2ef3dbb37 Enable remote connection over HTTP for gremlin python add 45c8d78a98 Fix JS

Re: [PR] Fix Java driver HTTP connection request not encoding all args [tinkerpop]

2023-10-13 Thread via GitHub
vkagamlyk commented on code in PR #2284: URL: https://github.com/apache/tinkerpop/pull/2284#discussion_r1358668529 ## gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java: ## @@ -71,6 +71,7 @@ protected void encode(final

Re: [PR] Fix Java driver HTTP connection request not encoding all args [tinkerpop]

2023-10-13 Thread via GitHub
Cole-Greer commented on code in PR #2284: URL: https://github.com/apache/tinkerpop/pull/2284#discussion_r1358627730 ## gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java: ## @@ -71,6 +71,7 @@ protected void encode(final

[tinkerpop] branch master updated: Updated CHANGELOG CTR

2023-10-13 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new 02eec919c3 Updated CHANGELOG CTR

[tinkerpop] branch 3.6-dev updated (89934d20da -> 097b32e917)

2023-10-13 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 89934d20da TINKERPOP-2724 Enabled some more gherkin tests around Path add 097b32e917 TINKERPOP-3001

[tinkerpop] 01/02: Merge branch '3.6-dev'

2023-10-13 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 32cbbae6bca0797ea5b98776608adcd3e29b3ccc Merge: 7be80b3082 097b32e917 Author: Stephen Mallette AuthorDate: Fri

[tinkerpop] branch master updated (7be80b3082 -> 73efcb32b5)

2023-10-13 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 7be80b3082 TINKERPOP-3000 Fixed bug in union() start add 097b32e917 TINKERPOP-3001 Fixed config setting

[tinkerpop] 02/02: Update CHANGELOG CTR

2023-10-13 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 73efcb32b52713893abd117bceec8b6b237e3158 Author: Stephen Mallette AuthorDate: Fri Oct 13 13:27:35 2023 -0400

[tinkerpop] branch master updated: TINKERPOP-3000 Fixed bug in union() start

2023-10-13 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new 7be80b3082 TINKERPOP-3000 Fixed bug in

Re: [PR] Bump xunit from 2.4.2 to 2.5.2 in /gremlin-dotnet [tinkerpop]

2023-10-13 Thread via GitHub
codecov-commenter commented on PR #2287: URL: https://github.com/apache/tinkerpop/pull/2287#issuecomment-1761658086 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2287?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

Re: [PR] Bump xunit.runner.visualstudio from 2.5.1 to 2.5.3 in /gremlin-dotnet [tinkerpop]

2023-10-13 Thread via GitHub
codecov-commenter commented on PR #2288: URL: https://github.com/apache/tinkerpop/pull/2288#issuecomment-1761658013 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2288?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[PR] Bump xunit.runner.visualstudio from 2.5.1 to 2.5.3 in /gremlin-dotnet [tinkerpop]

2023-10-13 Thread via GitHub
dependabot[bot] opened a new pull request, #2288: URL: https://github.com/apache/tinkerpop/pull/2288 Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.5.1 to 2.5.3. Commits

[PR] Bump xunit from 2.4.2 to 2.5.2 in /gremlin-dotnet [tinkerpop]

2023-10-13 Thread via GitHub
dependabot[bot] opened a new pull request, #2287: URL: https://github.com/apache/tinkerpop/pull/2287 Bumps [xunit](https://github.com/xunit/xunit) from 2.4.2 to 2.5.2. Commits https://github.com/xunit/xunit/commit/32931855e213ccb74d75a899af76f40388b2131b;>3293185 v2.5.2

[tinkerpop] branch dependabot/nuget/gremlin-dotnet/3.5-dev/xunit.runner.visualstudio-2.5.3 created (now 1e51ac8665)

2023-10-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/xunit.runner.visualstudio-2.5.3 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 1e51ac8665 Bump xunit.runner.visualstudio

[tinkerpop] branch dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.5.2 created (now e8b3235e71)

2023-10-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.5.2 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at e8b3235e71 Bump xunit from 2.4.2 to 2.5.2 in /gremlin-dotnet No

Re: [PR] Bump @types/node from 20.5.0 to 20.8.5 in /gremlint [tinkerpop]

2023-10-13 Thread via GitHub
codecov-commenter commented on PR #2285: URL: https://github.com/apache/tinkerpop/pull/2285#issuecomment-1761632373 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2285?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

Re: [PR] Bump @types/node from 20.5.0 to 20.8.5 in /docs/gremlint [tinkerpop]

2023-10-13 Thread via GitHub
codecov-commenter commented on PR #2286: URL: https://github.com/apache/tinkerpop/pull/2286#issuecomment-1761634990 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2286?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[tinkerpop] branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.8.4 deleted (was 66c1d11b6d)

2023-10-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.8.4 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 66c1d11b6d Bump @types/node from 20.5.0 to 20.8.4 in

[tinkerpop] branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.8.5 created (now 8d8a156911)

2023-10-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.8.5 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 8d8a156911 Bump @types/node from 20.5.0 to 20.8.5 in

Re: [PR] Bump @types/node from 20.5.0 to 20.8.4 in /docs/gremlint [tinkerpop]

2023-10-13 Thread via GitHub
dependabot[bot] commented on PR #2278: URL: https://github.com/apache/tinkerpop/pull/2278#issuecomment-1761612401 Superseded by #2286. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump @types/node from 20.5.0 to 20.8.4 in /docs/gremlint [tinkerpop]

2023-10-13 Thread via GitHub
dependabot[bot] closed pull request #2278: Bump @types/node from 20.5.0 to 20.8.4 in /docs/gremlint URL: https://github.com/apache/tinkerpop/pull/2278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Bump @types/node from 20.5.0 to 20.8.5 in /docs/gremlint [tinkerpop]

2023-10-13 Thread via GitHub
dependabot[bot] opened a new pull request, #2286: URL: https://github.com/apache/tinkerpop/pull/2286 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.5.0 to 20.8.5. Commits See full diff in

Re: [PR] Bump @types/node from 20.5.0 to 20.8.4 in /gremlint [tinkerpop]

2023-10-13 Thread via GitHub
dependabot[bot] commented on PR #2277: URL: https://github.com/apache/tinkerpop/pull/2277#issuecomment-1761583753 Superseded by #2285. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump @types/node from 20.5.0 to 20.8.4 in /gremlint [tinkerpop]

2023-10-13 Thread via GitHub
dependabot[bot] closed pull request #2277: Bump @types/node from 20.5.0 to 20.8.4 in /gremlint URL: https://github.com/apache/tinkerpop/pull/2277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Bump @types/node from 20.5.0 to 20.8.5 in /gremlint [tinkerpop]

2023-10-13 Thread via GitHub
dependabot[bot] opened a new pull request, #2285: URL: https://github.com/apache/tinkerpop/pull/2285 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.5.0 to 20.8.5. Commits See full diff in

[tinkerpop] branch dependabot/npm_and_yarn/gremlint/3.5-dev/types/node-20.8.4 deleted (was 4caa76bbd5)

2023-10-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/gremlint/3.5-dev/types/node-20.8.4 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 4caa76bbd5 Bump @types/node from 20.5.0 to 20.8.4 in

[tinkerpop] branch dependabot/npm_and_yarn/gremlint/3.5-dev/types/node-20.8.5 created (now 83625dd89a)

2023-10-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/gremlint/3.5-dev/types/node-20.8.5 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 83625dd89a Bump @types/node from 20.5.0 to 20.8.5 in

Re: [PR] Fix Java driver HTTP connection request not encoding all args [tinkerpop]

2023-10-13 Thread via GitHub
codecov-commenter commented on PR #2284: URL: https://github.com/apache/tinkerpop/pull/2284#issuecomment-1760957372 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2284?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[PR] Fix Java driver HTTP connection request not encoding all args [tinkerpop]

2023-10-13 Thread via GitHub
xiazcy opened a new pull request, #2284: URL: https://github.com/apache/tinkerpop/pull/2284 I noticed that the Java driver wasn't encoding the remaining args into the payload, such as aliases for traversal source were not registered. Not sure if it was intentional so I'm adding this quick

[tinkerpop] branch fix-java-http-conn created (now 9223b5aa69)

2023-10-13 Thread xiazcy
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a change to branch fix-java-http-conn in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 9223b5aa69 Fix java driver http connection not encoding all args (e.g. alias) in request This branch

[tinkerpop] 01/01: Fix java driver http connection not encoding all args (e.g. alias) in request

2023-10-13 Thread xiazcy
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a commit to branch fix-java-http-conn in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 9223b5aa690d0a36428fb3842d3cf71d581cf449 Author: Yang Xia <55853655+xia...@users.noreply.github.com>