codecov-commenter commented on PR #1949:
URL: https://github.com/apache/tinkerpop/pull/1949#issuecomment-1398515786
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1949?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
ministat opened a new pull request, #1949:
URL: https://github.com/apache/tinkerpop/pull/1949
The GraphSONRecordReader does not provide the GraphFilter to filter vetex
during deserialization. This PR fixed it. In addition, two UTs for vertex
filtering of both GraphSONRecordReader and
xiazcy opened a new pull request, #1948:
URL: https://github.com/apache/tinkerpop/pull/1948
Testing if this version bump works on java 8 & java 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
FlorianHockmann commented on PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#issuecomment-1396535991
> The diagnostics here is referring to what code it was able to analyze, not
what the results of that analysis was. The extraction error there means that
there was one file
Cole-Greer commented on PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#issuecomment-1387491400
> Thanks a lot for tackling this! The changes also look good to me
basically. The .NET scan however includes this in its logs:
>
> ```
> Analysis produced the following
Cole-Greer commented on code in PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#discussion_r1073859847
##
.github/workflows/codeql.yml:
##
@@ -0,0 +1,104 @@
+name: "CodeQL"
+
+on:
+ push:
+branches: [ "master", "3.5-dev", "3.6-dev" ]
+ pull_request:
+#
Cole-Greer commented on code in PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#discussion_r1073852728
##
.github/workflows/codeql.yml:
##
@@ -0,0 +1,104 @@
+name: "CodeQL"
+
+on:
+ push:
+branches: [ "master", "3.5-dev", "3.6-dev" ]
+ pull_request:
+#
FlorianHockmann commented on code in PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#discussion_r1073629543
##
.github/workflows/codeql.yml:
##
@@ -0,0 +1,104 @@
+name: "CodeQL"
+
+on:
+ push:
+branches: [ "master", "3.5-dev", "3.6-dev" ]
+ pull_request:
+
codecov-commenter commented on PR #1947:
URL: https://github.com/apache/tinkerpop/pull/1947#issuecomment-1386046034
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1947?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Cole-Greer opened a new pull request, #1947:
URL: https://github.com/apache/tinkerpop/pull/1947
Adds new workflow which runs CodeQL vulnerability scanning on any pushes or
pull requests to master, 3.5-dev, or 3.6-dev.
Also includes a small fix in go to prevent a possible lossy type
codecov-commenter commented on PR #1946:
URL: https://github.com/apache/tinkerpop/pull/1946#issuecomment-1384628526
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1946?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Cole-Greer opened a new pull request, #1946:
URL: https://github.com/apache/tinkerpop/pull/1946
https://issues.apache.org/jira/browse/TINKERPOP-2767
The existing error handling in TraversalOpProcessor and SessionOpProcessor
during bytecode iteration was catching all exceptions
dependabot[bot] commented on PR #1935:
URL: https://github.com/apache/tinkerpop/pull/1935#issuecomment-1384124152
Superseded by #1945.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] closed pull request #1935: Bump prettier from 2.8.1 to 2.8.2 in
/gremlin-javascript/src/main/javascript/gremlin-javascript
URL: https://github.com/apache/tinkerpop/pull/1935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dependabot[bot] opened a new pull request, #1945:
URL: https://github.com/apache/tinkerpop/pull/1945
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.1 to 2.8.3.
Release notes
Sourced from https://github.com/prettier/prettier/releases;>prettier's
releases.
dependabot[bot] closed pull request #1936: Bump prettier from 2.8.1 to 2.8.2 in
/gremlint
URL: https://github.com/apache/tinkerpop/pull/1936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #1936:
URL: https://github.com/apache/tinkerpop/pull/1936#issuecomment-1384123352
Superseded by #1944.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #1944:
URL: https://github.com/apache/tinkerpop/pull/1944
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.1 to 2.8.3.
Release notes
Sourced from https://github.com/prettier/prettier/releases;>prettier's
releases.
dependabot[bot] closed pull request #1925: Bump eslint from 7.32.0 to 8.31.0 in
/gremlin-javascript/src/main/javascript/gremlin-javascript
URL: https://github.com/apache/tinkerpop/pull/1925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dependabot[bot] opened a new pull request, #1943:
URL: https://github.com/apache/tinkerpop/pull/1943
Bumps [eslint](https://github.com/eslint/eslint) from 7.32.0 to 8.32.0.
Release notes
Sourced from https://github.com/eslint/eslint/releases;>eslint's releases.
v8.32.0
dependabot[bot] commented on PR #1925:
URL: https://github.com/apache/tinkerpop/pull/1925#issuecomment-1384122949
Superseded by #1943.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #1942:
URL: https://github.com/apache/tinkerpop/pull/1942
Bumps [BenchmarkDotNet](https://github.com/dotnet/BenchmarkDotNet) from
0.13.3 to 0.13.4.
Commits
FlorianHockmann commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1383647445
> I made the changes from master, which I now see is pretty far from
apache:3.5-dev. Should I have started from 3.5-dev in the first place?
That would be ideal, yes. I
tormodhau commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1383611490
> Thanks for this contribution, @tormodhau! I didn't fully review it, but
could you please change the base branch to `3.5-dev`? That way, we can easily
merge the contribution into
FlorianHockmann commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1383594004
Thanks for this contribution, @tormodhau! I didn't fully review it, but
could you please change the base branch to `3.5-dev`? That way, we can easily
merge the contribution
vkagamlyk merged PR #1937:
URL: https://github.com/apache/tinkerpop/pull/1937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vkagamlyk merged PR #1940:
URL: https://github.com/apache/tinkerpop/pull/1940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lyndonbauto commented on PR #1937:
URL: https://github.com/apache/tinkerpop/pull/1937#issuecomment-1382577163
VOTE+1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lyndonbauto commented on PR #1940:
URL: https://github.com/apache/tinkerpop/pull/1940#issuecomment-1382576825
VOTE+1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
codecov-commenter commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1382376699
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
tormodhau opened a new pull request, #1941:
URL: https://github.com/apache/tinkerpop/pull/1941
Fixes: https://issues.apache.org/jira/browse/TINKERPOP-2853
When reading a non-registered custom type with GraphBinary, a generic
exception is thrown:
xiazcy commented on PR #1940:
URL: https://github.com/apache/tinkerpop/pull/1940#issuecomment-1382336348
VOTE +1 pending change log entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vkagamlyk commented on PR #1940:
URL: https://github.com/apache/tinkerpop/pull/1940#issuecomment-1381261483
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
codecov-commenter commented on PR #1940:
URL: https://github.com/apache/tinkerpop/pull/1940#issuecomment-1381261289
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
kenhuuu opened a new pull request, #1940:
URL: https://github.com/apache/tinkerpop/pull/1940
Fixes https://issues.apache.org/jira/browse/TINKERPOP-2847.
Storing and comparing the request IDs in lower case prevents issues that
arise when the supplied ID and returned ID are using
vkagamlyk commented on PR #1938:
URL: https://github.com/apache/tinkerpop/pull/1938#issuecomment-1379660406
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
xiazcy commented on PR #1937:
URL: https://github.com/apache/tinkerpop/pull/1937#issuecomment-1379650714
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
codecov-commenter commented on PR #1939:
URL: https://github.com/apache/tinkerpop/pull/1939#issuecomment-1379646014
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Cole-Greer opened a new pull request, #1939:
URL: https://github.com/apache/tinkerpop/pull/1939
https://issues.apache.org/jira/browse/TINKERPOP-2841
In my testing, the go glv was not sending per-request options correctly to
the server. Go was passing request options inside the
codecov-commenter commented on PR #1938:
URL: https://github.com/apache/tinkerpop/pull/1938#issuecomment-1379535499
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
codecov-commenter commented on PR #1937:
URL: https://github.com/apache/tinkerpop/pull/1937#issuecomment-1379531910
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1937?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
vkagamlyk commented on code in PR #1938:
URL: https://github.com/apache/tinkerpop/pull/1938#discussion_r1067484871
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/client-behavior-tests.js:
##
@@ -64,5 +63,15 @@ describe('Client', function () {
Cole-Greer opened a new pull request, #1938:
URL: https://github.com/apache/tinkerpop/pull/1938
https://issues.apache.org/jira/browse/TINKERPOP-2844
Creates a test where a driver sends a request to gremlin-socket-server with
all per-request settings set. gremlin-socket-server
vkagamlyk commented on PR #1937:
URL: https://github.com/apache/tinkerpop/pull/1937#issuecomment-1379512109
Thank you Cole!
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Cole-Greer opened a new pull request, #1937:
URL: https://github.com/apache/tinkerpop/pull/1937
It was observed in the java driver that the UserAgent class could fail to
load if the manifest file was excluded from the jar. This is because the user
agent relies on the manifest to extract
xiazcy merged PR #1933:
URL: https://github.com/apache/tinkerpop/pull/1933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xiazcy commented on PR #1933:
URL: https://github.com/apache/tinkerpop/pull/1933#issuecomment-1379393262
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
xiazcy merged PR #1923:
URL: https://github.com/apache/tinkerpop/pull/1923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xiazcy commented on PR #1923:
URL: https://github.com/apache/tinkerpop/pull/1923#issuecomment-1379392341
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vkagamlyk commented on PR #1923:
URL: https://github.com/apache/tinkerpop/pull/1923#issuecomment-1377579292
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vkagamlyk commented on PR #1933:
URL: https://github.com/apache/tinkerpop/pull/1933#issuecomment-1377578583
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
FlorianHockmann commented on code in PR #1923:
URL: https://github.com/apache/tinkerpop/pull/1923#discussion_r1065415293
##
gremlin-dotnet/src/Gremlin.Net/Process/Utils.cs:
##
@@ -32,8 +32,11 @@ namespace Gremlin.Net.Process
///
/// Contains useful methods that can
Cole-Greer commented on code in PR #1923:
URL: https://github.com/apache/tinkerpop/pull/1923#discussion_r1064947226
##
gremlin-dotnet/src/Gremlin.Net/Process/Utils.cs:
##
@@ -32,8 +32,11 @@ namespace Gremlin.Net.Process
///
/// Contains useful methods that can be
Cole-Greer commented on code in PR #1923:
URL: https://github.com/apache/tinkerpop/pull/1923#discussion_r1064944969
##
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientBehaviorIntegrationTests.cs:
##
@@ -84,5 +84,37 @@ await
Cole-Greer commented on code in PR #1923:
URL: https://github.com/apache/tinkerpop/pull/1923#discussion_r1064944292
##
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientBehaviorIntegrationTests.cs:
##
@@ -84,5 +84,37 @@ await
Cole-Greer commented on code in PR #1923:
URL: https://github.com/apache/tinkerpop/pull/1923#discussion_r1064943944
##
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientBehaviorIntegrationTests.cs:
##
@@ -84,5 +84,37 @@ await
dependabot[bot] opened a new pull request, #1936:
URL: https://github.com/apache/tinkerpop/pull/1936
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.1 to 2.8.2.
Release notes
Sourced from https://github.com/prettier/prettier/releases;>prettier's
releases.
dependabot[bot] opened a new pull request, #1935:
URL: https://github.com/apache/tinkerpop/pull/1935
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.1 to 2.8.2.
Release notes
Sourced from https://github.com/prettier/prettier/releases;>prettier's
releases.
dependabot[bot] opened a new pull request, #1934:
URL: https://github.com/apache/tinkerpop/pull/1934
Bumps [ws](https://github.com/websockets/ws) from 8.11.0 to 8.12.0.
Release notes
Sourced from https://github.com/websockets/ws/releases;>ws's
releases.
8.12.0
Features
FlorianHockmann merged PR #1930:
URL: https://github.com/apache/tinkerpop/pull/1930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
FlorianHockmann commented on code in PR #1923:
URL: https://github.com/apache/tinkerpop/pull/1923#discussion_r1061581137
##
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientBehaviorIntegrationTests.cs:
##
@@ -84,5 +84,37 @@ await
mikepersonick merged PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mikepersonick commented on PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#issuecomment-1374527608
Added the CHANGELOG and squashed the commits. Should be good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1064010332
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeStep.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1064010260
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeStep.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache
codecov-commenter commented on PR #1933:
URL: https://github.com/apache/tinkerpop/pull/1933#issuecomment-1374113064
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1933?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Cole-Greer opened a new pull request, #1933:
URL: https://github.com/apache/tinkerpop/pull/1933
Adds a section in the gremlin-semantics docs for the dedup step.
Main purpose of this is to highlight some extra considerations with dedup
implementation which are somewhat beyond the
vkagamlyk commented on PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#issuecomment-1374073811
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vkagamlyk commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063741742
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeStep.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software
vkagamlyk commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063733156
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeStep.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software
spmallette commented on PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#issuecomment-1373955271
VOTE +1 (needs CHANGELOG, but that can land after merge)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mikepersonick commented on PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#issuecomment-1373951007
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063542207
##
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java:
##
@@ -290,6 +298,15 @@ public void iteratedToList() {
}
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063541978
##
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:
##
@@ -131,9 +132,16 @@ public void TranslateTraversal(string traversalText)
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063541693
##
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:
##
@@ -131,9 +132,16 @@ public void TranslateTraversal(string traversalText)
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063539064
##
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:
##
@@ -131,9 +132,16 @@ public void TranslateTraversal(string traversalText)
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063504505
##
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphFeatureTest.java:
##
@@ -33,7 +33,11 @@
tags = "not @RemoteOnly
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063503147
##
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:
##
@@ -131,9 +132,16 @@ public void TranslateTraversal(string traversalText)
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063500774
##
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java:
##
@@ -290,6 +298,15 @@ public void iteratedToList() {
}
}
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063499610
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeStep.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063494138
##
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphFeatureTest.java:
##
@@ -33,7 +33,11 @@
tags = "not
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063493920
##
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphFeatureTest.java:
##
@@ -33,7 +33,11 @@
tags = "not
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063492695
##
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java:
##
@@ -290,6 +298,15 @@ public void iteratedToList() {
}
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063492048
##
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:
##
@@ -131,9 +132,16 @@ public void TranslateTraversal(string traversalText)
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063488908
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/iterator/IteratorUtils.java:
##
@@ -260,10 +301,40 @@ public static Iterator cast(final
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063488308
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/iterator/IteratorUtils.java:
##
@@ -163,6 +192,7 @@ public static Map collectMap(final
mikepersonick commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063486411
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/iterator/IteratorUtils.java:
##
@@ -116,39 +120,64 @@ public S next() {
spmallette commented on PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#issuecomment-1373568410
given that this is a breaking change, i think this needs some Upgrade
Documentation to explain what to watch out for. also, looks like some recent
changes in the docs broke CI.
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063398374
##
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphFeatureTest.java:
##
@@ -33,7 +33,11 @@
tags = "not @RemoteOnly
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063396607
##
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/ProcessLimitedStandardSuite.java:
##
@@ -59,31 +61,36 @@ public class
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063395831
##
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java:
##
@@ -290,6 +298,15 @@ public void iteratedToList() {
}
}
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063394383
##
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs:
##
@@ -131,9 +132,16 @@ public void TranslateTraversal(string traversalText)
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063387414
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/iterator/IteratorUtils.java:
##
@@ -260,10 +301,40 @@ public static Iterator cast(final Iterator
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063381736
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/iterator/IteratorUtils.java:
##
@@ -163,6 +192,7 @@ public static Map collectMap(final
Iterator
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063380893
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/iterator/IteratorUtils.java:
##
@@ -116,39 +120,64 @@ public S next() {
throw
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063374730
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeStep.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software
spmallette commented on code in PR #1929:
URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063374730
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeStep.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software
codecov-commenter commented on PR #1932:
URL: https://github.com/apache/tinkerpop/pull/1932#issuecomment-1372306059
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1932?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
dependabot[bot] opened a new pull request, #1931:
URL: https://github.com/apache/tinkerpop/pull/1931
Bumps [github.com/cucumber/godog](https://github.com/cucumber/godog) from
0.12.5 to 0.12.6.
Release notes
Sourced from
dependabot[bot] opened a new pull request, #1932:
URL: https://github.com/apache/tinkerpop/pull/1932
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.5.0 to
0.6.0.
Commits
https://github.com/golang/text/commit/ec5565b1b747ce5ca569aeefc09e737b479a12ac;>ec5565b
1 - 100 of 5835 matches
Mail list logo
