Re: [PR] TINKERPOP-3029 Fix enumeration for .NET 8 [tinkerpop]

2024-01-15 Thread via GitHub
FlorianHockmann merged PR #2424: URL: https://github.com/apache/tinkerpop/pull/2424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] TINKERPOP-3029 Fix enumeration for .NET 8 [tinkerpop]

2024-01-11 Thread via GitHub
xiazcy commented on PR #2424: URL: https://github.com/apache/tinkerpop/pull/2424#issuecomment-1888079847 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] TINKERPOP-3029 Fix enumeration for .NET 8 [tinkerpop]

2024-01-09 Thread via GitHub
vkagamlyk commented on PR #2424: URL: https://github.com/apache/tinkerpop/pull/2424#issuecomment-1883908255 thank you @FlorianHockmann! VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] TINKERPOP-3029 Fix enumeration for .NET 8 [tinkerpop]

2024-01-05 Thread via GitHub
FlorianHockmann commented on PR #2424: URL: https://github.com/apache/tinkerpop/pull/2424#issuecomment-1878426662 I added a CHANGELOG / upgrade docs entry and applied the suggestion by @vkagamlyk. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] TINKERPOP-3029 Fix enumeration for .NET 8 [tinkerpop]

2024-01-04 Thread via GitHub
FlorianHockmann commented on code in PR #2424: URL: https://github.com/apache/tinkerpop/pull/2424#discussion_r1441466689 ## gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs: ## @@ -82,21 +82,22 @@ public bool MoveNext() } private b

Re: [PR] TINKERPOP-3029 Fix enumeration for .NET 8 [tinkerpop]

2024-01-03 Thread via GitHub
EricSites commented on code in PR #2424: URL: https://github.com/apache/tinkerpop/pull/2424#discussion_r1441072113 ## gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs: ## @@ -82,21 +82,22 @@ public bool MoveNext() } private bool Mo

Re: [PR] TINKERPOP-3029 Fix enumeration for .NET 8 [tinkerpop]

2024-01-03 Thread via GitHub
vkagamlyk commented on code in PR #2424: URL: https://github.com/apache/tinkerpop/pull/2424#discussion_r1440829828 ## gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs: ## @@ -82,21 +82,22 @@ public bool MoveNext() } private bool Mo

Re: [PR] TINKERPOP-3029 Fix enumeration for .NET 8 [tinkerpop]

2024-01-03 Thread via GitHub
codecov-commenter commented on PR #2424: URL: https://github.com/apache/tinkerpop/pull/2424#issuecomment-1875641877 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apach