vkagamlyk merged PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vkagamlyk commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-2004578580
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vkagamlyk commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1998346909
I think the code is good and would like to see it merged.
But this is a very big change that may be important to other people, so I
would recommend writing a short message to [dev
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1993622235
Have updated the browser example to use TypeScript instead. Didn't touch the
node example as it's right now just a collection of scripts :p
NOTE:
You can see from the browser
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522535064
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id,
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522534690
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js:
##
@@ -20,28 +20,28 @@
/**
* @author Jorge Bay Gondra
*/
-'use
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522533103
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id,
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522528198
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js:
##
@@ -20,28 +20,28 @@
/**
* @author Jorge Bay Gondra
*/
-'use
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522524987
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js:
##
@@ -20,28 +20,28 @@
/**
* @author Jorge Bay Gondra
*/
-'use
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522509577
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id,
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522509374
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/traversal.ts:
##
@@ -476,49 +481,43 @@ function toEnum(typeName, keys) {
const directionAlias
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522501485
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id,
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522500544
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/traversal.ts:
##
@@ -476,49 +481,43 @@ function toEnum(typeName, keys) {
const
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1993445516
Added a small entry to the `changelog` file, please let me know if further
info or modification is needed.
--
This is an automated message from the Apache Git Service.
To respond to the
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992675130
@vkagamlyk I've removed all the unnecessary changes to the test files. Also
reset them all to what is on `master` first so there are no conflicts from
`3.7`.
--
This is an automated
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992506652
> documentation update for
[users](https://tinkerpop.apache.org/docs/current/reference/#gremlin-javascript),
[developers
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992495561
> P.S. Please do not change the formatting because it makes code review very
difficult. It's usually better to make separate PR for formatting/fix styles.
Yeah, this is because my
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522052097
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/sasl-authentication-tests.js:
##
@@ -69,38 +68,43 @@ describe('DriverRemoteConnection',
vkagamlyk commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992488713
Missing parts:
- documentation update for
[users](https://tinkerpop.apache.org/docs/current/reference/#gremlin-javascript),
[developers
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522028418
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/sasl-authentication-tests.js:
##
@@ -69,38 +68,43 @@
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992375619
> I think this is a good first step to implement the type system. Thank you
for contribution @tien!
>
> Did I understand correctly that users will be able to use it without
having
vkagamlyk commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992334497
I think this is a good first step to implement the type system. Thank you
for contribution @tien!
Did I understand correctly that users will be able to use it without having
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1989644763
> maybe just need to revive this one -
https://issues.apache.org/jira/browse/TINKERPOP-2027 we didn't quite do what we
thought we were going to do on that as i read back through that one.
spmallette commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1989425590
maybe just need to revive this one -
https://issues.apache.org/jira/browse/TINKERPOP-2027 we didn't quite do what we
thought we were going to do on that as i read back through that
xiazcy commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1989420022
Thanks for the work @tien! I'm not familiar with JS or TS enough to provide
insightful feedback, so I will leave that for folks who have the expertise.
Just some housekeeping items,
codecov-commenter commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1985024642
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2515?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
All
tien opened a new pull request, #2515:
URL: https://github.com/apache/tinkerpop/pull/2515
- Change public interfacing files to TypeScript
- Keep internal serializers as JavaScript
- Change CommonJS to Module
--
This is an automated message from the Apache Git Service.
To respond to
27 matches
Mail list logo
