Re: [trafficserver] branch master updated: remove bad check

2017-06-07 Thread James Peach
> On Jun 7, 2017, at 12:49 PM, dra...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > dragon pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/trafficserver.git > > > The following commit(s) were added to

Re: [trafficserver] branch master updated: TS-5063: Fixes coverity warnings and cleans up the temp string

2016-11-27 Thread James Peach
> On Nov 27, 2016, at 2:19 PM, zw...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > zwoop pushed a commit to branch master > in repository https://git-dual.apache.org/repos/asf/trafficserver.git > > The following commit(s) were added to

Re: [trafficserver] branch master updated: TS-4858: fix memory leak problem of global_default_keyblock

2016-10-17 Thread James Peach
> On Oct 17, 2016, at 3:53 PM, shinr...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > shinrich pushed a commit to branch master > in repository https://git-dual.apache.org/repos/asf/trafficserver.git > > The following commit(s) were added to

Re: [trafficserver] branch master updated: Fix possibility of NULL assignment to std::string

2016-10-02 Thread James Peach
> On Oct 2, 2016, at 5:36 PM, sor...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > sorber pushed a commit to branch master > in repository https://git-dual.apache.org/repos/asf/trafficserver.git > > The following commit(s) were added to

Re: [trafficserver] 07/08: TS-4738: docs: update logs_xml.config doc to note its replacement by logging.config (to preserve search engine hits)

2016-08-23 Thread James Peach
> On Aug 23, 2016, at 12:52 AM, js...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > jsime pushed a commit to branch master > in repository https://git-dual.apache.org/repos/asf/trafficserver.git > > commit ba71f829df79fc1f9d71699865b479896f55712b

Re: [trafficserver] branch master updated: TS-3922: Websocket Timeouts, transaction overrideable & clang format

2016-04-21 Thread James Peach
This commit broke the Lua build. Did you run ./ci/regression before committing? https://ci.trafficserver.apache.org/job/out_of_tree-master/1631/changes > On Apr 21, 2016, at 7:45 PM, bri...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > briang

Re: [trafficserver] 01/01: Merge pull request #567 from sudheerv/ts-3857

2016-04-15 Thread James Peach
I can't find an email with the actual diff? Is there one, or does that only happen on squashed merges? > On Apr 14, 2016, at 3:06 PM, sudhe...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > sudheerv pushed a commit to branch master > in repository

Re: [trafficserver] branch master updated: TS-4340: fix small issue related to match typ e NONE

2016-04-14 Thread James Peach
> On Apr 14, 2016, at 1:44 PM, bri...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > briang pushed a commit to branch master > in repository https://git-dual.apache.org/repos/asf/trafficserver.git > > The following commit(s) were added to

Re: trafficserver git commit: TS-4087: Reduce SETTINGS_MAX_CONCURRENT_STREAMS when too many streams

2016-03-25 Thread James Peach
> On Mar 24, 2016, at 2:57 AM, Masaori Koshiba <masa...@apache.org> wrote: > > 2016年3月23日(水) 14:23 James Peach <jpe...@apache.org>: > >> [snip] >>> } >>> + >>> +return Http2::min_concurrent_streams_in; >>> +

Re: trafficserver git commit: TS-4087: Reduce SETTINGS_MAX_CONCURRENT_STREAMS when too many streams

2016-03-22 Thread James Peach
> On Mar 21, 2016, at 6:57 PM, masa...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 1e9c9484c -> 0e6e5c151 > > > TS-4087: Reduce SETTINGS_MAX_CONCURRENT_STREAMS when too many streams > > Add below variables in records.config > -

Re: trafficserver git commit: TS-3977: Add cache-key-genid to experimental plugins. This closes #309.

2016-03-03 Thread James Peach
> On Mar 3, 2016, at 12:16 PM, a...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 1d1cb8fae -> fbdf0221d > > > TS-3977: Add cache-key-genid to experimental plugins. > This closes #309. > > > Project:

Re: trafficserver git commit: [TS-4024] wire tracing enhancements. This closes #337.

2016-01-12 Thread James Peach
This doesn't look like it addresses Alan's last comment about "unifying the SSL error reporting logic" > On Jan 12, 2016, at 7:48 AM, shinr...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 9399a7641 -> bb40d788b > > > [TS-4024] wire tracing

Re: trafficserver git commit: TS-4007: ClassAllocator: don't attempt to destruct the prototype object when ClassAllocator goes out of scope

2015-11-10 Thread James Peach
> On Nov 9, 2015, at 10:38 PM, bri...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master c7610467e -> e4cb30531 > > > TS-4007: ClassAllocator: don't attempt to destruct the prototype object when > ClassAllocator goes out of scope > > > Project:

Re: trafficserver git commit: TS-315: Add switch to disable config file generation/runtime behavior changing

2015-10-22 Thread James Peach
Hey Bryan, I think that proxy.config.disable_configuration_modification should prevent rewriting the config, but you should still be able to update proxy.config.disable_configuration_modification out of band and have it update without a restart. Apart from that, disabling the update threads

Re: trafficserver git commit: [TS-3949] Prevent active timeout event from firing after PluginVC is closed.

2015-09-27 Thread James Peach
> On Sep 26, 2015, at 10:41 PM, sudhe...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master f9a6930fc -> ae9a343a9 > > > [TS-3949] Prevent active timeout event from firing > after PluginVC is closed. > > > Project:

Re: trafficserver git commit: TS-3928: Make TSRemapNewInstance not required in remap plugins

2015-09-21 Thread James Peach
Phil, can you please update the man page for TSRemapNewInstance? https://docs.trafficserver.apache.org/en/latest/reference/api/TSRemap.en.html thanks! > On Sep 21, 2015, at 1:14 PM, sor...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 0a58767f7 ->

Re: trafficserver git commit: Coverity issues: making the sanity check calls useful!

2015-08-12 Thread James Peach
This has multiple, independent changes, so it should have been a series of separate commits. I think it is also worth referencing the Coverity CID (I assume that this fixes a number of them?) On Aug 11, 2015, at 2:18 PM, a...@apache.org wrote: Repository: trafficserver Updated Branches:

Re: trafficserver git commit: TS-3497: Define Http2Error to classify errors

2015-08-05 Thread James Peach
On Aug 5, 2015, at 9:05 AM, zw...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 7d63eae28 - 0fc4dcdea TS-3497: Define Http2Error to classify errors This closes #267 Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: [1/6] trafficserver git commit: Document which configurations are overwritable

2015-06-08 Thread James Peach
Do you mean overridable? TSHttpOverridableConfig(). On Jun 8, 2015, at 3:46 PM, mlib...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 9bb97769e - dfb14525a Document which configurations are overwritable Project:

Re: trafficserver git commit: TS-3122: Add support for hugepages on Linux

2015-06-08 Thread James Peach
On Jun 8, 2015, at 8:40 AM, sor...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 1a0832b3b - bba557870 TS-3122: Add support for hugepages on Linux Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: trafficserver git commit: TS-3479 Remove verbose Warning() from HTTP/2 connections

2015-04-03 Thread James Peach
On Apr 2, 2015, at 8:55 PM, Leif Hedstrom zw...@apache.org wrote: On Apr 2, 2015, at 9:51 PM, Leif Hedstrom zw...@apache.org wrote: On Apr 1, 2015, at 6:08 PM, James Peach jpe...@apache.org wrote: On Apr 1, 2015, at 3:50 PM, zw...@apache.org wrote: [snip] http://git-wip

Re: trafficserver git commit: TS-3470 traffic_server --help segfaults when SPDY is enabled

2015-04-02 Thread James Peach
On Mar 31, 2015, at 6:51 PM, Leif Hedstrom zw...@apache.org wrote: On Mar 31, 2015, at 1:39 PM, James Peach jpe...@apache.org wrote: On Mar 31, 2015, at 10:17 AM, zw...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master e13d8a6e8 - e0de1d6ed TS

Re: trafficserver git commit: TS-3479 Remove verbose Warning() from HTTP/2 connections

2015-04-01 Thread James Peach
On Apr 1, 2015, at 3:50 PM, zw...@apache.org wrote: [snip] http://git-wip-us.apache.org/repos/asf/trafficserver/blob/26f438d4/proxy/http2/Http2SessionAccept.cc -- diff --git a/proxy/http2/Http2SessionAccept.cc

Re: trafficserver git commit: TS-3470 traffic_server --help segfaults when SPDY is enabled

2015-03-31 Thread James Peach
On Mar 31, 2015, at 10:17 AM, zw...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master e13d8a6e8 - e0de1d6ed TS-3470 traffic_server --help segfaults when SPDY is enabled [snip] diff --git a/lib/ts/ink_args.cc b/lib/ts/ink_args.cc index

Re: trafficserver git commit: TS-2709: ATS does not send close-notify on shutdown.

2015-03-26 Thread James Peach
On Mar 26, 2015, at 1:18 PM, shinr...@apache.org wrote: [snip] -- diff --git a/iocore/net/SSLNetVConnection.cc b/iocore/net/SSLNetVConnection.cc index 3d58072..a1988f2 100644 --- a/iocore/net/SSLNetVConnection.cc +++

Re: [1/3] trafficserver git commit: TS-3437: Make DH params configurable

2015-03-12 Thread James Peach
The added configuration is proxy.config.ssl.server.enable_dhparams, but the code checks proxy.config.ssl.client.enable_dhparams. The added configuration is marked RECU_RESTART_TS, but will actually take effect when ssl_multicert.config is reloaded. So I think this should be RECU_DYNAMIC

Re: trafficserver git commit: TS-3417: Add MADV_DONTDUMP capability

2015-03-09 Thread James Peach
On Mar 9, 2015, at 6:54 PM, sor...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 3b24ea14e - fe219a131 TS-3417: Add MADV_DONTDUMP capability Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: [1/3] trafficserver git commit: TS-3421 Add a -t range option for proxyauth, which asks for a bytes=0-0 Range

2015-03-03 Thread James Peach
Please update the documentation On Mar 2, 2015, at 5:10 PM, zw...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 0c697b238 - ab4da857d TS-3421 Add a -t range option for proxyauth, which asks for a bytes=0-0 Range Project:

Re: trafficserver git commit: TS-3409: Adjust new and old metric names to avoid corrupting existing *.snap files.

2015-02-26 Thread James Peach
On Feb 26, 2015, at 1:15 PM, shinr...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 4ab0ea32b - 115eabd1e TS-3409: Adjust new and old metric names to avoid corrupting existing *.snap files. How does changing metric names corrupt the snap files? Is

Re: [1/2] trafficserver git commit: TS-3375 - Further refining error actions on bad SSL configuration.

2015-02-24 Thread James Peach
On Feb 16, 2015, at 9:53 AM, shinr...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 53d5c6dfb - a8e0c5e17 TS-3375 - Further refining error actions on bad SSL configuration. [snip]

Re: trafficserver git commit: TS-3380: Add configure time constant to enable openssl 1.0.2 changes to compile with libressl

2015-02-09 Thread James Peach
On Feb 9, 2015, at 4:12 PM, shinr...@apache.org wrote: [snip] http://git-wip-us.apache.org/repos/asf/trafficserver/blob/2dbdd9c2/build/crypto.m4 -- diff --git a/build/crypto.m4 b/build/crypto.m4 index 32276a2..2c83793

Re: trafficserver git commit: TS-2480: Fix to work in the case where there are no ticket key files but tickets have not been disabled. Also fix RHEL 5 compile error.

2015-02-05 Thread James Peach
On Feb 5, 2015, at 7:32 PM, shinr...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 1d617582b - 5fe69772a TS-2480: Fix to work in the case where there are no ticket key files but tickets have not been disabled. Doesn't OpenSSL do this implicitly? Or

Re: trafficserver git commit: Fix linking to external ssl libs for traffic_crashlog

2015-02-04 Thread James Peach
Wait, how does traffic_crashlog drag in OpenSSL? On Feb 4, 2015, at 12:01 PM, jackso...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master b220c23d6 - d95ab615a Fix linking to external ssl libs for traffic_crashlog Project:

Re: [1/2] trafficserver git commit: TS-3303 tcpinfo: we can close the log file object multiple times

2015-01-18 Thread James Peach
On Jan 15, 2015, at 5:29 PM, zw...@apache.org wrote: [snip] diff --git a/plugins/tcpinfo/tcpinfo.cc b/plugins/tcpinfo/tcpinfo.cc index 481f553..1937eed 100644 --- a/plugins/tcpinfo/tcpinfo.cc +++ b/plugins/tcpinfo/tcpinfo.cc @@ -171,12 +171,9 @@ log_tcp_info(Config * config, const char

Re: trafficserver git commit: TS-3219: Separate WCCP client process

2015-01-08 Thread James Peach
Should this be cmd/traffic_wccp? On Jan 8, 2015, at 12:00 PM, shinr...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master aaf5d6bfa - 5f2fc30d7 TS-3219: Separate WCCP client process Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo

Re: trafficserver git commit: Enable a few more options for the base build

2014-12-17 Thread James Peach
On Dec 17, 2014, at 8:24 AM, Leif Hedstrom zw...@apache.org wrote: On Dec 17, 2014, at 9:18 AM, James Peach jpe...@apache.org wrote: Does this mean that all our CI builds now use --enable-reclaimable-freelist? No, only 2 of them. I didn’t want to do it for everything, because

Re: trafficserver git commit: TS-3224: fix problem of ts_lua coredump

2014-12-10 Thread James Peach
On Dec 10, 2014, at 6:18 AM, kic...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 156b7be9c - 60c97c6f0 TS-3224: fix problem of ts_lua coredump Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: trafficserver git commit: Fixing AddressSanitizer issue where sizeof(size_t) sizeof(int).

2014-11-20 Thread James Peach
On Nov 20, 2014, at 11:53 AM, bri...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 74d29be0e - 90b635481 Fixing AddressSanitizer issue where sizeof(size_t) sizeof(int). Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: [1/2] trafficserver git commit: [TS-3153]: Ability to disable or modify npn advertisement based on SNI

2014-11-18 Thread James Peach
On Nov 17, 2014, at 1:12 PM, sudhe...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 08f19da9b - 34ca6f2dc [TS-3153]: Ability to disable or modify npn advertisement based on SNI Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo

Re: [1/2] trafficserver git commit: [TS-3153]: Add documentation for new API TSSslAdvertiseProtocolSet

2014-11-17 Thread James Peach
Why didn't this go through API review? https://cwiki.apache.org/confluence/display/TS/API+Review+Process On Nov 17, 2014, at 1:27 PM, sudhe...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master be70f1cab - f7d8f1b54 [TS-3153]: Add documentation for new

Re: [1/2] git commit: TS-2986: Adding stats to TLS errors

2014-11-14 Thread James Peach
On Aug 6, 2014, at 10:20 AM, James Peach jpe...@apache.org wrote: On Aug 5, 2014, at 12:16 PM, Brian Geffon briangef...@gmail.com wrote: Technically you'd probably aggregate all of these into a single variable for production monitoring, but having insight into the individual failure

Re: trafficserver git commit: [TS-3199]: Do not wait for body for HEAD method

2014-11-14 Thread James Peach
On Nov 14, 2014, at 4:27 PM, sudhe...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 5c37860c7 - d26674750 [TS-3199]: Do not wait for body for HEAD method Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: [TS-2683]: Enhance the bg fetch plugin to support specifyng various exclusion criteria

2014-10-30 Thread James Peach
On Oct 30, 2014, at 2:38 PM, sudhe...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 35a71e919 - e49344c15 [TS-2683]: Enhance the bg fetch plugin to support specifyng various exclusion criteria Project:

Re: git commit: [TS-2682] Add per remap support for background fetch plugin

2014-10-30 Thread James Peach
On Oct 30, 2014, at 4:09 PM, sudhe...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 589d8013e - 42c89c713 [TS-2682] Add per remap support for background fetch plugin Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: [TS-2503]: Dynamic TLS Record Sizing for better page load latencies. The strategy used is essentially to use small TLS records that fit into a single TCP segment for the first ~1 MB of

2014-10-17 Thread James Peach
On Oct 17, 2014, at 7:59 AM, sudhe...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 609443dbe - dee36e716 [TS-2503]: Dynamic TLS Record Sizing for better page load latencies. The strategy used is essentially to use small TLS records that fit into a

Re: git commit: TS-3139] New script, traffic_primer, to prime a set of boxes with content

2014-10-15 Thread James Peach
On Oct 15, 2014, at 1:47 PM, zw...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 3e64d405c - cdd1d15b4 TS-3139] New script, traffic_primer, to prime a set of boxes with content I think it wold be better to have 1 script that works in both modes. 2

Re: [1/3] git commit: TS-3080: Optimized SSL Session Cache

2014-10-09 Thread James Peach
I thought you were going to format to our style guidelines before committing? On Oct 8, 2014, at 11:34 AM, bri...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 195259b16 - f1bedb41e TS-3080: Optimized SSL Session Cache Project:

Re: git commit: [TS-3121] Add method is_valid_response()

2014-10-08 Thread James Peach
On Oct 8, 2014, at 9:42 AM, sudhe...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master a33073505 - 6548088ec [TS-3121] Add method is_valid_response() Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: [TS-3112] - Add null pointer check for contp to prevent core dump after handleEvent(TS_FETCH_EVENT_EXT_HEAD_DONE)

2014-10-03 Thread James Peach
On Oct 3, 2014, at 6:29 AM, sudhe...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 33f651c90 - d1b3dc66b [TS-3112] - Add null pointer check for contp to prevent core dump after handleEvent(TS_FETCH_EVENT_EXT_HEAD_DONE) Project:

Re: git commit: [TS-3112] - Add null pointer check for contp to prevent core dump after handleEvent(TS_FETCH_EVENT_EXT_HEAD_DONE)

2014-10-03 Thread James Peach
; } contp-handleEvent(event, this); } while (chunked_handler.state == ChunkedHandler::CHUNK_FLOW_CONTROL); Thanks, Sudheer On 10/3/14, 8:57 AM, James Peach jamespe...@me.com wrote: On Oct 3, 2014, at 8:35 AM, Sudheer Vinukonda sudhe...@yahoo-inc.com.INVALID wrote: Hi James

Re: git commit: TS-3108: Add port matching condition to header_rewrite

2014-10-02 Thread James Peach
On Oct 2, 2014, at 12:47 PM, sor...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master adae7cd16 - 5054186f9 TS-3108: Add port matching condition to header_rewrite Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: TS-1475: Coverity 1242015 Buffer not null terminated

2014-09-30 Thread James Peach
On Sep 30, 2014, at 7:28 AM, zw...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 98ea180cc - f16c7615a TS-1475: Coverity 1242015 Buffer not null terminated Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: [TS-3085] Large POSTs over (relatively) slower connections failing in ats5 Call ERR_get_error_line_data() via SSL_CLR_ERR_INCR_DYN_STAT to clean up the error queue after processing an

2014-09-24 Thread James Peach
On Sep 24, 2014, at 6:40 AM, sudhe...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 17bef772a - d12327d84 [TS-3085] Large POSTs over (relatively) slower connections failing in ats5 Call ERR_get_error_line_data() via SSL_CLR_ERR_INCR_DYN_STAT to clean up

Re: git commit: TS-3073: Forward FIN from client to server in tr-pass handling.

2014-09-21 Thread James Peach
On Sep 21, 2014, at 6:19 PM, a...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 9e46e4e19 - 514c9e1a6 TS-3073: Forward FIN from client to server in tr-pass handling. Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: [1/6] git commit: TS-1800: Add new hash function base class

2014-08-08 Thread James Peach
On Aug 8, 2014, at 3:08 PM, sor...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 5c0bc7c94 - 7fa5c5c7a TS-1800: Add new hash function base class Any tests? Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: [1/2] git commit: TS-2986: Adding stats to TLS errors

2014-08-06 Thread James Peach
, an error log is much more helpful. I'm +1 on stats, but these could be much more useful. On Tue, Aug 5, 2014 at 12:11 PM, James Peach jamespe...@me.com wrote: What is the use case for these stats? I can see how the logs might be too noisy, but they don't seem like good candidates for metrics

Re: [1/3] ats_speed: PageSpeed optimization plugin

2014-08-04 Thread James Peach
Great! Thanks a lot Otto :) On Aug 4, 2014, at 6:57 AM, osch...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master fab202517 - 083abd4ff http://git-wip-us.apache.org/repos/asf/trafficserver/blob/083abd4f/plugins/experimental/ats_speed/gzip/README

Re: git commit: TS-2802: SNI support for origin servers - fix WCCP compile errors.

2014-08-01 Thread James Peach
Thanks Alan! On Aug 1, 2014, at 7:20 AM, a...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 4b2429b60 - 426879358 TS-2802: SNI support for origin servers - fix WCCP compile errors. Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo

Re: git commit: TS-2863: Enable FQDN selection for shared sessions.

2014-07-25 Thread James Peach
Still reviewing, but I wish this had been a number of smaller patches. For example, const'ing the MD5 stuff and adding ~PluginIdentity() could have been independent patches ... On Jul 24, 2014, at 7:20 PM, a...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master

Re: [2/3] git commit: TS-1146: added counters to TLS ticket callback

2014-07-17 Thread James Peach
On Jul 17, 2014, at 10:24 AM, bri...@apache.org wrote: TS-1146: added counters to TLS ticket callback This is a new feature, so it should have had a new Jira ticket. Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: TS-2780: Core dump in SpdyRequest::clear() in production testing of SPDY

2014-07-08 Thread James Peach
A helper function would make this cleaner: SpdyRequest * SpdyClientSession::find_request(int streamid) { mapint32_t, SpdyRequest*::iterator iter = this-req_map.find(streamid); return iter == this-req_map.end() ? NULL : iter-second; } On Jul 8, 2014, at 12:29 PM, bc...@apache.org wrote:

Re: git commit: Doc: Plugin identity and related logging tags.

2014-06-09 Thread James Peach
On Jun 9, 2014, at 5:35 AM, Alan M. Carroll a...@network-geographics.com wrote: James, The correct syntax for referring to function arguments is :c:arg:`foo` Except sockaddr in this case is not a functiona argument, it is a type. The argument is addr. Ah, good point. :data:`NULL`

Re: git commit: Doc: Plugin identity and related logging tags.

2014-06-05 Thread James Peach
On Jun 5, 2014, at 6:52 PM, a...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master caf514b25 - 13843023a Doc: Plugin identity and related logging tags. Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: [2/2] git commit: TS-2845: Commit e6b9cb533 causes problems with stats_over_http

2014-06-01 Thread James Peach
This seems like a fairly subtle bug. Is it possibly to construct a test to ensure we don't regress it? At the least, could you add a source code comment so that future changes are aware of how to manage squid error codes? On May 30, 2014, at 7:13 PM, bc...@apache.org wrote: TS-2845: Commit

Re: git commit: Update docs for ip_allow and remap.config to reflect changes to allow artibtrary methods

2014-06-01 Thread James Peach
On May 30, 2014, at 3:33 PM, bri...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 61b12a323 - 82c14a99b Update docs for ip_allow and remap.config to reflect changes to allow artibtrary methods Project:

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-29 Thread James Peach
On May 29, 2014, at 12:19 AM, Wei Sun sun...@yahoo-inc.com wrote: On 5/29/14, 1:36 AM, Bryan Call bc...@yahoo-inc.com wrote: On May 26, 2014, at 6:00 PM, James Peach jpe...@apache.org wrote: Bryan, How are you expecting proxy.process.ssl.total_handshake_time to be used? What

Re: git commit: TS-2838 Add log fields for plugins on HttpSM and use for SPDY.

2014-05-28 Thread James Peach
Please remove the documentation for the 'cps' log field. Please document the 'piid' log field. I don't see how this is wired up to SPDY, could you spell that out for me? On May 23, 2014, at 9:30 AM, a...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master

Re: git commit: TS-2856: Remove proxy.config.spdy.verbose_in and use diags instead

2014-05-28 Thread James Peach
Nice! On May 28, 2014, at 5:46 PM, bc...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master d22f98910 - d0f4d5c47 TS-2856: Remove proxy.config.spdy.verbose_in and use diags instead Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-27 Thread James Peach
On May 27, 2014, at 7:33 AM, Sudheer Vinukonda sudhe...@yahoo-inc.com wrote: On 5/26/14, 6:00 PM, James Peach jpe...@apache.org wrote: Bryan, How are you expecting proxy.process.ssl.total_handshake_time to be used? What units is it in? Unless I'm missing something, the aggregate

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-27 Thread James Peach
On May 27, 2014, at 9:14 AM, Sudheer Vinukonda sudhe...@yahoo-inc.com wrote: On 5/27/14, 8:47 AM, James Peach jpe...@apache.org wrote: On May 27, 2014, at 7:33 AM, Sudheer Vinukonda sudhe...@yahoo-inc.com wrote: On 5/26/14, 6:00 PM, James Peach jpe...@apache.org wrote: Bryan

Re: git commit: TS-2528 Use stdbool.h in the public mgmtapi.h interface, C99 standard.

2014-05-26 Thread James Peach
On May 23, 2014, at 5:47 PM, zw...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 639329e38 - bc054cf8d TS-2528 Use stdbool.h in the public mgmtapi.h interface, C99 standard. So we now require C99 to build plugins? That sounds reasonable, but it should

Re: git commit: TS-2808 Remove confusing and probably bogus comment in TSVConnCreate

2014-05-26 Thread James Peach
So how does one use he TSVConn that TSVConnCreate() returns? On May 23, 2014, at 10:10 AM, zw...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 7fe24aefa - 59fa19025 TS-2808 Remove confusing and probably bogus comment in TSVConnCreate Project:

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-26 Thread James Peach
Bryan, How are you expecting proxy.process.ssl.total_handshake_time to be used? What units is it in? Unless I'm missing something, the aggregate handshake time does not seem very interesting. What does proxy.process.spdy.total_time mean, and how would I use it? Why does

Re: git commit: TS-2528 Use stdbool.h in the public mgmtapi.h interface, C99 standard.

2014-05-26 Thread James Peach
On May 26, 2014, at 5:56 PM, Leif Hedstrom zw...@apache.org wrote: On May 26, 2014, at 6:41 PM, James Peach jpe...@apache.org wrote: On May 23, 2014, at 5:47 PM, zw...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 639329e38 - bc054cf8d TS-2528

Re: git commit: TS-2838 Add log fields for plugins on HttpSM and use for SPDY.

2014-05-23 Thread James Peach
This should have gone through API review. Can you please post a review email? On May 23, 2014, at 9:30 AM, a...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master b6383928a - aadb75226 TS-2838 Add log fields for plugins on HttpSM and use for SPDY.

Re: git commit: TS-2381 The actual add SPDY stream counter patch.

2014-05-22 Thread James Peach
Pretty sure TS-2831 is the bug you're looking for ... On May 22, 2014, at 9:26 AM, a...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master f230e610c - 77dd7d282 TS-2381 The actual add SPDY stream counter patch. Project:

Re: git commit: TS-2555: add more hook support for ts_lua plugin

2014-05-21 Thread James Peach
On May 20, 2014, at 9:59 PM, kic...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 90f44b522 - 2ba2baaa6 TS-2555: add more hook support for ts_lua plugin I still think that declaring global functions for hooks is ugly and not Lua-like. Automatically

Re: [1/2] git commit: [TS-2822] Crash in LogBufferIterator::next

2014-05-21 Thread James Peach
On May 21, 2014, at 9:50 AM, bri...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 2ba2baaa6 - 374355c01 [TS-2822] Crash in LogBufferIterator::next Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: TS-2830 Make gcc 4.1.2 happy.

2014-05-21 Thread James Peach
On May 21, 2014, at 6:58 PM, a...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master ad6d30052 - ada6b33e8 TS-2830 Make gcc 4.1.2 happy. Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: TS-2830 Make SPDY configurable.

2014-05-21 Thread James Peach
On May 21, 2014, at 6:24 PM, a...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 24d860c05 - b7e69b0fa TS-2830 Make SPDY configurable. [snip] cts only new SPDY connections, not existing connects. + +.. ts:cv:: CONFIG proxy.config.spdy.verbose_in INT

Re: git commit: TS-2821 Add to default records.config and tweak the name to be more consistent.

2014-05-19 Thread James Peach
On May 19, 2014, at 5:26 PM, a...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master c25fb7541 - ce8304309 TS-2821 Add to default records.config and tweak the name to be more consistent. Project:

Re: [1/3] git commit: TS-2766: HdrHeap::coalesce_str_heaps doesn't properly calculate new heap size

2014-05-12 Thread James Peach
Brian, Can you please add a test for this? That would help other devs understand how this is supposed to work and prevent regressions in the future thanks! On May 1, 2014, at 1:51 PM, bri...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 22bb4923e -

Re: git commit: TS-2736: Add config option to set the max open files limit for the traffic_server process to some percentage of the fs.file-max proc value on Linux. The default is 90%.

2014-05-12 Thread James Peach
On Apr 24, 2014, at 12:50 PM, James Peach jpe...@apache.org wrote: On Apr 24, 2014, at 10:45 AM, sor...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master eb183eef9 - 22ed6d8ed TS-2736: Add config option to set the max open files limit

Re: git commit: TS-2555: updates to share lua context across hook invocations and only add global hooks if corresponding lua functions exist

2014-05-05 Thread James Peach
On May 4, 2014, at 5:58 PM, kic...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master ea7849384 - 5b1535e39 TS-2555: updates to share lua context across hook invocations and only add global hooks if corresponding lua functions exist Project:

Re: git commit: TS-2735: Align all memory during freelist allocations

2014-04-21 Thread James Peach
On Apr 21, 2014, at 12:58 PM, sor...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 4f2dc70f0 - 32f71df3a TS-2735: Align all memory during freelist allocations Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: TS-2732: Add url_sig plugin

2014-04-18 Thread James Peach
On Apr 18, 2014, at 12:56 PM, sor...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master bcfd36abf - 88f18501d TS-2732: Add url_sig plugin Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: TS-2555 add global plugin support for ts_lua plugin

2014-04-17 Thread James Peach
On Apr 17, 2014, at 9:01 AM, Leif Hedstrom zw...@apache.org wrote: On Apr 16, 2014, at 8:19 PM, 李刚(阙寒) que...@taobao.com wrote: Maybe we can use the same lua_States in both remap and global plugins. Not exactly related, but one thing that really bothers me with the new plugin is

Re: git commit: TS-2555 add global plugin support for ts_lua plugin

2014-04-16 Thread James Peach
On Apr 15, 2014, at 10:34 PM, kic...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 9f509d401 - 904e1f7c2 TS-2555 add global plugin support for ts_lua plugin Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: TS-2711 Build with the include LuaJIT

2014-04-15 Thread James Peach
On Apr 15, 2014, at 7:29 AM, zw...@apache.org wrote: ... +# These are currently built separate, as part of building the lib/ tree, using +# the normal LuaJIT build system. We are using the .o's directly, instead of the +# luajit.a to avoid the linker from optimizing symbols away. We could

Re: git commit: TS-2703 Add a text log format to escalate plugin

2014-04-10 Thread James Peach
On Apr 10, 2014, at 5:54 AM, zw...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 4b6c8e022 - 77c5cf39b TS-2703 Add a text log format to escalate plugin Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: [2/6] git commit: TS-2690 Make the escalate plugin support URL and Host redirects

2014-04-10 Thread James Peach
On Apr 10, 2014, at 5:54 AM, zw...@apache.org wrote: TS-2690 Make the escalate plugin support URL and Host redirects TS-2690 Support multiple status codes for each rule, e.g. 403,404: Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: [4/5] git commit: TS-2612: Indroduce TSHttpConnectWithProtoStack() API

2014-04-02 Thread James Peach
On Mar 27, 2014, at 8:35 PM, Yunkai Zhang yunkai...@gmail.com wrote: On Fri, Mar 28, 2014 at 8:00 AM, James Peach jpe...@apache.org wrote: On Mar 13, 2014, at 2:56 PM, James Peach jpe...@apache.org wrote: On Mar 11, 2014, at 8:12 PM, yun...@apache.org wrote: TS-2612: Indroduce

Re: Build failed in Jenkins: debian_6_x64-master-hardening-regression #273

2014-03-28 Thread James Peach
On Mar 27, 2014, at 5:26 PM, jenk...@boot.org wrote: See http://jenkins.boot.org/job/debian_6_x64-master-hardening-regression/273/changes [snip] libtool: compile: c++ -DHAVE_CONFIG_H -I.

Re: [4/5] git commit: TS-2612: Indroduce TSHttpConnectWithProtoStack() API

2014-03-27 Thread James Peach
On Mar 13, 2014, at 2:56 PM, James Peach jpe...@apache.org wrote: On Mar 11, 2014, at 8:12 PM, yun...@apache.org wrote: TS-2612: Indroduce TSHttpConnectWithProtoStack() API 1) Firstly, add a bitmask, *proto_stack*, in NetVConnection/HttpSM, and set it properly. 2) For some plugins

Re: git commit: TS-2628 Remove the wrong notification for not, to avoid spreading bad info.

2014-03-16 Thread James Peach
On Mar 16, 2014, at 2:03 PM, zw...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master d3fd1e674 - 4836e4e27 TS-2628 Remove the wrong notification for not, to avoid spreading bad info. This seems fine for now, but as we discussed, the right fix is to make

Re: [4/5] git commit: TS-2612: Indroduce TSHttpConnectWithProtoStack() API

2014-03-13 Thread James Peach
On Mar 11, 2014, at 8:12 PM, yun...@apache.org wrote: TS-2612: Indroduce TSHttpConnectWithProtoStack() API 1) Firstly, add a bitmask, *proto_stack*, in NetVConnection/HttpSM, and set it properly. 2) For some plugins that using TSHttpConnect() API to do request, the Logging module

Re: [2/2] git commit: intercept support in atscppapi

2014-03-06 Thread James Peach
We should have a JIRA ticket for this so that we can publish accurate change logs and release notes On Mar 6, 2014, at 12:47 PM, bri...@apache.org wrote: intercept support in atscppapi Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

Re: git commit: TS-2576: Add Oct/Hex escape representation into LogFormat

2014-02-26 Thread James Peach
On Feb 26, 2014, at 4:30 AM, yun...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master 6d4005f8b - 38996681d TS-2576: Add Oct/Hex escape representation into LogFormat Introudce two escape representations into LogFormat: * Oct escape sequence: '\abc':

Re: git commit: TS-2576: Add Oct/Hex escape representation into LogFormat

2014-02-26 Thread James Peach
On Feb 26, 2014, at 7:39 PM, Yunkai Zhang yunkai...@gmail.com wrote: Updated. thanks a lot :) On Thu, Feb 27, 2014 at 9:04 AM, James Peach jpe...@apache.org wrote: On Feb 26, 2014, at 4:30 AM, yun...@apache.org wrote: Repository: trafficserver Updated Branches: refs/heads/master

Re: git commit: TS-2570: Reduce number of malloc/free in remap_stats fast path

2014-02-14 Thread James Peach
On Feb 13, 2014, at 3:14 PM, sor...@apache.org wrote: Updated Branches: refs/heads/master 6636f4dcf - 178c7b92a TS-2570: Reduce number of malloc/free in remap_stats fast path Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit:

  1   2   >