guangxuCheng commented on pull request #231:
URL: https://github.com/apache/incubator-tubemq/pull/231#issuecomment-684551169
@justinmclean can you take a look? We are preparing to release the next
version. Thanks
This is an
aloyszhang commented on pull request #247:
URL: https://github.com/apache/incubator-tubemq/pull/247#issuecomment-683516353
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log
aloyszhang commented on a change in pull request #251:
URL: https://github.com/apache/incubator-tubemq/pull/251#discussion_r484818600
##
File path:
tubemq-manager/src/main/java/org/apache/tubemq/manager/backend/AbstractDaemon.java
##
@@ -0,0 +1,80 @@
+package
gosonzhang commented on pull request #269:
URL: https://github.com/apache/incubator-tubemq/pull/269#issuecomment-693276067
@charlely you need push this request to master.
This is an automated message from the Apache Git
gosonzhang commented on pull request #255:
URL: https://github.com/apache/incubator-tubemq/pull/255#issuecomment-691377763
@charlely thanks
This is an automated message from the Apache Git Service.
To respond to the
gosonzhang commented on pull request #255:
URL: https://github.com/apache/incubator-tubemq/pull/255#issuecomment-691377763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
yuanboliu commented on pull request #256:
URL: https://github.com/apache/incubator-tubemq/pull/256#issuecomment-691901316
@gosonzhang please review it :>)
This is an automated message from the Apache Git Service.
To respond
gosonzhang commented on pull request #255:
URL: https://github.com/apache/incubator-tubemq/pull/255#issuecomment-691377763
@charlely thanks
This is an automated message from the Apache Git Service.
To respond to the
guangxuCheng commented on pull request #231:
URL: https://github.com/apache/incubator-tubemq/pull/231#issuecomment-692001992
Preparing to release the next version, Merge firstly.
This is an automated message from the Apache
yuanboliu commented on pull request #249:
URL: https://github.com/apache/incubator-tubemq/pull/249#issuecomment-684870675
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gosonzhang commented on pull request #255:
URL: https://github.com/apache/incubator-tubemq/pull/255#issuecomment-691377763
@charlely thanks
This is an automated message from the Apache Git Service.
To respond to the
codecov-io commented on pull request #282:
URL: https://github.com/apache/incubator-tubemq/pull/282#issuecomment-705928196
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/282?src=pr=h1)
Report
> Merging
charlely commented on pull request #282:
URL: https://github.com/apache/incubator-tubemq/pull/282#issuecomment-705946447
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on
codecov-io commented on pull request #283:
URL: https://github.com/apache/incubator-tubemq/pull/283#issuecomment-706069257
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/283?src=pr=h1)
Report
> Merging
codecov-io commented on pull request #282:
URL: https://github.com/apache/incubator-tubemq/pull/282#issuecomment-705928196
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/282?src=pr=h1)
Report
> Merging
codecov-io commented on pull request #283:
URL: https://github.com/apache/incubator-tubemq/pull/283#issuecomment-706069257
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/283?src=pr=h1)
Report
> Merging
charlely commented on pull request #282:
URL: https://github.com/apache/incubator-tubemq/pull/282#issuecomment-705946447
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yuanboliu commented on pull request #271:
URL: https://github.com/apache/incubator-tubemq/pull/271#issuecomment-697094081
ok, go ahead, I've saved it in local environment
This is an automated message from the Apache Git
gosonzhang commented on pull request #271:
URL: https://github.com/apache/incubator-tubemq/pull/271#issuecomment-697093111
I found that this issue includes many contents. I have a problem with the
operation here: the realization of this part of the requirement should be
submitted to the
yuanboliu commented on pull request #271:
URL: https://github.com/apache/incubator-tubemq/pull/271#issuecomment-697094081
ok, go ahead, I've saved it in local environment
This is an automated message from the Apache Git
yuanboliu commented on pull request #273:
URL: https://github.com/apache/incubator-tubemq/pull/273#issuecomment-697208022
merge code to new feature branch
This is an automated message from the Apache Git Service.
To respond
gosonzhang opened a new pull request #289:
URL: https://github.com/apache/incubator-tubemq/pull/289
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gosonzhang merged pull request #289:
URL: https://github.com/apache/incubator-tubemq/pull/289
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gosonzhang merged pull request #55:
URL: https://github.com/apache/incubator-tubemq-website/pull/55
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gosonzhang opened a new pull request #55:
URL: https://github.com/apache/incubator-tubemq-website/pull/55
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lamberliu opened a new pull request #291:
URL: https://github.com/apache/incubator-tubemq/pull/291
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
keyihao opened a new pull request #290:
URL: https://github.com/apache/incubator-tubemq/pull/290
Add static const variable definition to fix link error reported at
https://issues.apache.org/jira/browse/TUBEMQ-380
This is an
yuanboliu opened a new pull request #292:
URL: https://github.com/apache/incubator-tubemq/pull/292
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gosonzhang merged pull request #56:
URL: https://github.com/apache/incubator-tubemq-website/pull/56
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lamberliu opened a new pull request #56:
URL: https://github.com/apache/incubator-tubemq-website/pull/56
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
netroby commented on pull request #231:
URL: https://github.com/apache/incubator-tubemq/pull/231#issuecomment-669080816
Why not apache license?
MIT license?
This is an automated message from the Apache Git Service.
To
codecov-commenter commented on pull request #231:
URL: https://github.com/apache/incubator-tubemq/pull/231#issuecomment-669078614
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/231?src=pr=h1)
Report
> Merging
gosonzhang commented on pull request #231:
URL: https://github.com/apache/incubator-tubemq/pull/231#issuecomment-669085405
The TubeMQ LICENSE is not changed, still Apache V2. This is the description
of the external code LICENSE referenced by the project, include:
1. the reference's
lubanproj commented on a change in pull request #229:
URL: https://github.com/apache/incubator-tubemq/pull/229#discussion_r466909572
##
File path: tubemq-client-twins/tubemq-client-go/codec/codec/serialization.go
##
@@ -0,0 +1,119 @@
+package codec
+
+import (
+ "errors"
gosonzhang commented on pull request #234:
URL: https://github.com/apache/incubator-tubemq/pull/234#issuecomment-671301172
The main changes are as follows:
1. Add 3 parameters in SendMessageResponseB2P: messageId, appendTime,
appendOffset, respectively save the messageId of the message
gosonzhang commented on pull request #229:
URL: https://github.com/apache/incubator-tubemq/pull/229#issuecomment-670927740
Thanks @lubanproj and @liangyuanpeng
This is an automated message from the Apache Git Service.
To
gosonzhang commented on pull request #232:
URL: https://github.com/apache/incubator-tubemq/pull/232#issuecomment-669780537
Thanks @hystericalhell
This is an automated message from the Apache Git Service.
To respond to the
liangyuanpeng commented on a change in pull request #229:
URL: https://github.com/apache/incubator-tubemq/pull/229#discussion_r466448803
##
File path: tubemq-client-twins/tubemq-client-go/codec/codec/serialization.go
##
@@ -0,0 +1,119 @@
+package codec
+
+import (
+
liangyuanpeng commented on a change in pull request #229:
URL: https://github.com/apache/incubator-tubemq/pull/229#discussion_r466453562
##
File path: tubemq-client-twins/tubemq-client-go/codec/codec/serialization.go
##
@@ -0,0 +1,119 @@
+package codec
Review comment:
liangyuanpeng commented on pull request #229:
URL: https://github.com/apache/incubator-tubemq/pull/229#issuecomment-669960476
We can code go client for TubeMQ together if you have any plan and agree. :)
This is an automated
gosonzhang commented on pull request #235:
URL: https://github.com/apache/incubator-tubemq/pull/235#issuecomment-671938518
Add maxOffset information field
This is an automated message from the Apache Git Service.
To respond
gosonzhang commented on pull request #229:
URL: https://github.com/apache/incubator-tubemq/pull/229#issuecomment-669633294
@lubanproj, there are some problems with the pr submitted
This is an automated message from the
gosonzhang commented on a change in pull request #174:
URL: https://github.com/apache/incubator-tubemq/pull/174#discussion_r447314196
##
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/broker/metadata/TopicMetadata.java
##
@@ -37,7 +37,7 @@
private int
aloyszhang commented on pull request #174:
URL: https://github.com/apache/incubator-tubemq/pull/174#issuecomment-651741298
Thanks for your contribution @hystericalhell , LGTM
This is an automated message from the Apache Git
charlely commented on a change in pull request #197:
URL: https://github.com/apache/incubator-tubemq/pull/197#discussion_r452213482
##
File path: tubemq-client-twins/tubemq-client-cpp/CMakeLists.txt
##
@@ -0,0 +1,30 @@
+cmake_minimum_required (VERSION 3.1)
+
+project (TubeMQ)
codecov-commenter commented on pull request #197:
URL: https://github.com/apache/incubator-tubemq/pull/197#issuecomment-656111687
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/197?src=pr=h1)
Report
> Merging
gosonzhang commented on a change in pull request #197:
URL: https://github.com/apache/incubator-tubemq/pull/197#discussion_r452201521
##
File path: tubemq-client-twins/tubemq-client-cpp/CMakeLists.txt
##
@@ -0,0 +1,30 @@
+cmake_minimum_required (VERSION 3.1)
+
+project
gosonzhang commented on a change in pull request #197:
URL: https://github.com/apache/incubator-tubemq/pull/197#discussion_r452219813
##
File path: tubemq-client-twins/tubemq-client-cpp/CMakeLists.txt
##
@@ -0,0 +1,30 @@
+cmake_minimum_required (VERSION 3.1)
+
+project
gosonzhang commented on a change in pull request #188:
URL: https://github.com/apache/incubator-tubemq/pull/188#discussion_r450054394
##
File path: tubemq-client-twins/tubemq-client-cpp/src/logger.cc
##
@@ -0,0 +1,58 @@
+
+
Review comment:
need license
gosonzhang commented on a change in pull request #190:
URL: https://github.com/apache/incubator-tubemq/pull/190#discussion_r450094119
##
File path: tubemq-client-twins/tubemq-client-cpp/example/log/main.cc
##
@@ -0,0 +1,28 @@
+
Review comment:
need license
gosonzhang commented on a change in pull request #188:
URL: https://github.com/apache/incubator-tubemq/pull/188#discussion_r450055641
##
File path: tubemq-client-twins/tubemq-client-cpp/example/log/main.cc
##
@@ -0,0 +1,28 @@
+
Review comment:
need license
aloyszhang commented on pull request #175:
URL: https://github.com/apache/incubator-tubemq/pull/175#issuecomment-652138626
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
lamberliu commented on pull request #175:
URL: https://github.com/apache/incubator-tubemq/pull/175#issuecomment-652143124
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gosonzhang commented on pull request #176:
URL: https://github.com/apache/incubator-tubemq/pull/176#issuecomment-652829864
Thanks @imarch1
This is an automated message from the Apache Git Service.
To respond to the message,
codecov-commenter commented on pull request #196:
URL: https://github.com/apache/incubator-tubemq/pull/196#issuecomment-655917522
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/196?src=pr=h1)
Report
> Merging
hystericalhell commented on pull request #143:
URL: https://github.com/apache/incubator-tubemq/pull/143#issuecomment-645425892
Add IndexScale control in config file, while resolve estimated scale issue
by accepting parameter from user.
lamberliu commented on pull request #165:
URL: https://github.com/apache/incubator-tubemq/pull/165#issuecomment-646528777
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
lamberliu commented on pull request #170:
URL: https://github.com/apache/incubator-tubemq/pull/170#issuecomment-648612785
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
codecov-commenter commented on pull request #172:
URL: https://github.com/apache/incubator-tubemq/pull/172#issuecomment-648729172
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/172?src=pr=h1)
Report
> Merging
gosonzhang commented on a change in pull request #142:
URL: https://github.com/apache/incubator-tubemq/pull/142#discussion_r446744239
##
File path: conf/broker.ini
##
@@ -38,7 +38,10 @@ transferSize= 524288
loadMessageStoresInParallel=true
; timeout of consumer heartbeat,
gosonzhang commented on pull request #149:
URL: https://github.com/apache/incubator-tubemq/pull/149#issuecomment-643885585
I suggest not to merge this PR
This change uses the ObjectArrayDeque class to pre-allocate array elements,
and uses AtomicBoolean's weakCompareAndSet method to
gosonzhang commented on pull request #147:
URL: https://github.com/apache/incubator-tubemq/pull/147#issuecomment-643931532
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gosonzhang removed a comment on pull request #147:
URL: https://github.com/apache/incubator-tubemq/pull/147#issuecomment-643931532
+1
This is an automated message from the Apache Git Service.
To respond to the message,
hystericalhell edited a comment on pull request #143:
URL: https://github.com/apache/incubator-tubemq/pull/143#issuecomment-643934089
Updated:
As discussed with Guocheng Zhang, there are a few facts current system has
implemented:
1. A SegmentList consists of only ONE topic, the
hystericalhell commented on pull request #143:
URL: https://github.com/apache/incubator-tubemq/pull/143#issuecomment-643934089
Updated:
As discussed with Guocheng Zhang, there are a few facts current system has
implemented:
1. A SegmentList consists of only ONE topic, the filter is
gosonzhang commented on pull request #142:
URL: https://github.com/apache/incubator-tubemq/pull/142#issuecomment-643930917
This modification is not a best practice, this problem needs to be adjusted
in conjunction with other points
codecov-commenter commented on pull request #154:
URL: https://github.com/apache/incubator-tubemq/pull/154#issuecomment-644517051
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/154?src=pr=h1)
Report
> Merging
codecov-commenter commented on pull request #153:
URL: https://github.com/apache/incubator-tubemq/pull/153#issuecomment-644485680
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/153?src=pr=h1)
Report
> Merging
codecov-commenter commented on pull request #143:
URL: https://github.com/apache/incubator-tubemq/pull/143#issuecomment-643959751
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/143?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
codecov-commenter commented on pull request #146:
URL: https://github.com/apache/incubator-tubemq/pull/146#issuecomment-643960105
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/146?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
codecov-commenter edited a comment on pull request #146:
URL: https://github.com/apache/incubator-tubemq/pull/146#issuecomment-643960105
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/146?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
gosonzhang commented on pull request #169:
URL: https://github.com/apache/incubator-tubemq/pull/169#issuecomment-647248060
@lubanproj, you need rebase your project code and then pull your changed.
This is an automated
gosonzhang commented on pull request #169:
URL: https://github.com/apache/incubator-tubemq/pull/169#issuecomment-647258164
There is another question that needs attention, if it takes a long time, it
is better to merge into this branch
codecov-commenter commented on pull request #169:
URL: https://github.com/apache/incubator-tubemq/pull/169#issuecomment-647275723
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/169?src=pr=h1)
Report
> Merging
gosonzhang commented on a change in pull request #142:
URL: https://github.com/apache/incubator-tubemq/pull/142#discussion_r443180243
##
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/MessageStore.java
##
@@ -559,13 +566,13 @@ private long
hystericalhell commented on a change in pull request #142:
URL: https://github.com/apache/incubator-tubemq/pull/142#discussion_r443505874
##
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/broker/metadata/TopicMetadata.java
##
@@ -37,6 +37,8 @@
private
hystericalhell commented on a change in pull request #142:
URL: https://github.com/apache/incubator-tubemq/pull/142#discussion_r443506367
##
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/broker/metadata/BrokerDefMetadata.java
##
@@ -36,6 +36,8 @@
hystericalhell commented on a change in pull request #142:
URL: https://github.com/apache/incubator-tubemq/pull/142#discussion_r443505255
##
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/broker/metadata/TopicMetadata.java
##
@@ -95,57 +97,63 @@ public
hystericalhell commented on a change in pull request #142:
URL: https://github.com/apache/incubator-tubemq/pull/142#discussion_r443503970
##
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/MessageStore.java
##
@@ -559,13 +566,13 @@ private long
gosonzhang commented on a change in pull request #157:
URL: https://github.com/apache/incubator-tubemq/pull/157#discussion_r441924856
##
File path:
tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tubemq/TubemqSinkFunction.java
##
@@ -0,0
lamberliu commented on pull request #157:
URL: https://github.com/apache/incubator-tubemq/pull/157#issuecomment-645739937
reopen
This is an automated message from the Apache Git Service.
To respond to the message, please
lamberliu removed a comment on pull request #157:
URL: https://github.com/apache/incubator-tubemq/pull/157#issuecomment-645739937
reopen
This is an automated message from the Apache Git Service.
To respond to the message,
gosonzhang commented on a change in pull request #163:
URL: https://github.com/apache/incubator-tubemq/pull/163#discussion_r442685741
##
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/common/utils/WebParameterUtils.java
##
@@ -631,8 +631,7 @@ public static
codecov-commenter commented on pull request #163:
URL: https://github.com/apache/incubator-tubemq/pull/163#issuecomment-646459242
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr=h1)
Report
> Merging
gosonzhang commented on pull request #166:
URL: https://github.com/apache/incubator-tubemq/pull/166#issuecomment-646464461
The PR title need format as [TUBEMQ-XXX] YYY
This is an automated message from the Apache Git
codecov-commenter edited a comment on pull request #163:
URL: https://github.com/apache/incubator-tubemq/pull/163#issuecomment-646459242
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr=h1)
Report
> Merging
codecov-commenter commented on pull request #164:
URL: https://github.com/apache/incubator-tubemq/pull/164#issuecomment-646483848
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/164?src=pr=h1)
Report
> Merging
lamberliu commented on pull request #160:
URL: https://github.com/apache/incubator-tubemq/pull/160#issuecomment-645750628
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
guangxuCheng commented on pull request #118:
URL: https://github.com/apache/incubator-tubemq/pull/118#issuecomment-642388203
hi @yayoec, Thanks for your contributing.
TubeMQ use jira for issue management. Before submitting a PR, you need to
create a new issue on jira.
dockerzhang commented on pull request #146:
URL: https://github.com/apache/incubator-tubemq/pull/146#issuecomment-642596787
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov-commenter commented on pull request #152:
URL: https://github.com/apache/incubator-tubemq/pull/152#issuecomment-643156532
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/152?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
yuanboliu commented on pull request #146:
URL: https://github.com/apache/incubator-tubemq/pull/146#issuecomment-643129579
@guangxuCheng
create a new PR for your comments:
codecov-commenter commented on pull request #147:
URL: https://github.com/apache/incubator-tubemq/pull/147#issuecomment-643227874
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/147?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
codecov-commenter commented on pull request #149:
URL: https://github.com/apache/incubator-tubemq/pull/149#issuecomment-643865635
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/149?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
codecov-commenter commented on pull request #226:
URL: https://github.com/apache/incubator-tubemq/pull/226#issuecomment-663838792
#
[Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/226?src=pr=h1)
Report
> Merging
liangyuanpeng commented on a change in pull request #209:
URL: https://github.com/apache/incubator-tubemq/pull/209#discussion_r456479553
##
File path: tubemq-client-twins/tubemq-client-go/consumer.go
##
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
gosonzhang commented on pull request #209:
URL: https://github.com/apache/incubator-tubemq/pull/209#issuecomment-659449182
@lubanproj you need rebase the code and then pull request.
many history prs are pulled in this pr.
dockerzhang removed a comment on pull request #226:
URL: https://github.com/apache/incubator-tubemq/pull/226#issuecomment-664799854
+1
This is an automated message from the Apache Git Service.
To respond to the message,
dockerzhang commented on pull request #226:
URL: https://github.com/apache/incubator-tubemq/pull/226#issuecomment-664799854
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log
gosonzhang removed a comment on pull request #226:
URL: https://github.com/apache/incubator-tubemq/pull/226#issuecomment-664800543
+1
This is an automated message from the Apache Git Service.
To respond to the message,
1 - 100 of 599 matches
Mail list logo
