[GitHub] [incubator-tvm] jwfromm commented on issue #4521: ONNX importer ModelParams bug

jwfromm commented on issue #4521: ONNX importer ModelParams bug URL: https://github.com/apache/incubator-tvm/issues/4521#issuecomment-565689979 Ok so what's happening is Onnx treats the shape of Reshape operators as parameters that naturally get added to the dictionary of global parameters

[GitHub] [incubator-tvm] jwfromm commented on issue #4521: ONNX importer ModelParams bug

jwfromm commented on issue #4521: ONNX importer ModelParams bug URL: https://github.com/apache/incubator-tvm/issues/4521#issuecomment-565689101 This is strange and I'll try to figure out where that parameter is coming from. Just curious though, does this have any negative effect besides

[GitHub] [incubator-tvm] optima2005 commented on a change in pull request #4511: [CONV] Asymmetric padding

optima2005 commented on a change in pull request #4511: [CONV] Asymmetric padding URL: https://github.com/apache/incubator-tvm/pull/4511#discussion_r357900412 ## File path: topi/tests/python/test_topi_conv2d_nchw.py ## @@ -176,6 +184,20 @@ def test_conv2d_nchw():

[GitHub] [incubator-tvm] optima2005 commented on a change in pull request #4511: [CONV] Asymmetric padding

optima2005 commented on a change in pull request #4511: [CONV] Asymmetric padding URL: https://github.com/apache/incubator-tvm/pull/4511#discussion_r357900352 ## File path: topi/tests/python/test_topi_conv2d_nchw.py ## @@ -176,6 +184,20 @@ def test_conv2d_nchw():

[GitHub] [incubator-tvm] optima2005 commented on a change in pull request #4511: [CONV] Asymmetric padding

optima2005 commented on a change in pull request #4511: [CONV] Asymmetric padding URL: https://github.com/apache/incubator-tvm/pull/4511#discussion_r357888579 ## File path: topi/tests/python/test_topi_conv2d_nchw.py ## @@ -176,6 +184,20 @@ def test_conv2d_nchw():

[GitHub] [incubator-tvm] tqchen merged pull request #4517: [Bugfix][Frontend][TFlite] Fix wrong function call in TANH tests

tqchen merged pull request #4517: [Bugfix][Frontend][TFlite] Fix wrong function call in TANH tests URL: https://github.com/apache/incubator-tvm/pull/4517 This is an automated message from the Apache Git Service. To respond

[incubator-tvm] branch master updated (f10944c -> f5e2c44)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from f10944c Fix bias_add gradient (#4516) add f5e2c44 [Bugfix][Frontend][TFlite] Fix wrong function call

[GitHub] [incubator-tvm] optima2005 commented on a change in pull request #4511: [CONV] Asymmetric padding

optima2005 commented on a change in pull request #4511: [CONV] Asymmetric padding URL: https://github.com/apache/incubator-tvm/pull/4511#discussion_r357888579 ## File path: topi/tests/python/test_topi_conv2d_nchw.py ## @@ -176,6 +184,20 @@ def test_conv2d_nchw():

[GitHub] [incubator-tvm] anwang2009 edited a comment on issue #4521: ONNX importer ModelParams bug

anwang2009 edited a comment on issue #4521: ONNX importer ModelParams bug URL: https://github.com/apache/incubator-tvm/issues/4521#issuecomment-565681415 Poking around a little, it looks like `reshape_attr_tensor421` persists in `self._nodes` and `self._params` for the entirety of

[GitHub] [incubator-tvm] anwang2009 commented on issue #4521: ONNX importer ModelParams bug

anwang2009 commented on issue #4521: ONNX importer ModelParams bug URL: https://github.com/apache/incubator-tvm/issues/4521#issuecomment-565681415 Poking around a little, it looks like `reshape_attr_tensor421` persists in `self._nodes` and self._params` for the entirety of `from_onnx`.

[GitHub] [incubator-tvm] anwang2009 opened a new issue #4521: ONNX importer ModelParams bug

anwang2009 opened a new issue #4521: ONNX importer ModelParams bug URL: https://github.com/apache/incubator-tvm/issues/4521 Using the onnx importer on mobilenetv2-1.0 with opset 7, `relay_params` appears to have an extra parameter as compared to `relay_model`'s parameters. Here's a

[GitHub] [incubator-tvm] optima2005 commented on a change in pull request #4511: [CONV] Asymmetric padding

optima2005 commented on a change in pull request #4511: [CONV] Asymmetric padding URL: https://github.com/apache/incubator-tvm/pull/4511#discussion_r357888579 ## File path: topi/tests/python/test_topi_conv2d_nchw.py ## @@ -176,6 +184,20 @@ def test_conv2d_nchw():

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4397: Use the best tuner possible

comaniac commented on a change in pull request #4397: Use the best tuner possible URL: https://github.com/apache/incubator-tvm/pull/4397#discussion_r357885141 ## File path: tutorials/autotvm/tune_simple_template.py ## @@ -294,8 +296,9 @@ def matmul(N, L, M, dtype):

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4397: Use the best tuner possible

comaniac commented on a change in pull request #4397: Use the best tuner possible URL: https://github.com/apache/incubator-tvm/pull/4397#discussion_r357885082 ## File path: tutorials/autotvm/tune_simple_template.py ## @@ -32,6 +32,8 @@ # Install dependencies #

[GitHub] [incubator-tvm] comaniac opened a new pull request #4520: [AutoTVM] Fix Empty Config caused Crashing

comaniac opened a new pull request #4520: [AutoTVM] Fix Empty Config caused Crashing URL: https://github.com/apache/incubator-tvm/pull/4520 ### **Problem Description** Some TOPI schedules such as `depthwise_conv2d_nchw` on x86 has no tuning space at all. However since

[GitHub] [incubator-tvm] masahi commented on issue #4485: [WIP] Clean up AMD Code Gen

masahi commented on issue #4485: [WIP] Clean up AMD Code Gen URL: https://github.com/apache/incubator-tvm/pull/4485#issuecomment-565656521 @petrex btw we have the rocm channel on our slack. We can discuss rocm related issues with @t-vi there if you like. We used that channel when we

[GitHub] [incubator-tvm] vmiheer commented on issue #4397: Use the best tuner possible

vmiheer commented on issue #4397: Use the best tuner possible URL: https://github.com/apache/incubator-tvm/pull/4397#issuecomment-565655940 Updated. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] inadob commented on issue #4517: [Bugfix][Frontend][TFlite] Fix wrong function call in TANH tests

inadob commented on issue #4517: [Bugfix][Frontend][TFlite] Fix wrong function call in TANH tests URL: https://github.com/apache/incubator-tvm/pull/4517#issuecomment-565634828 Can you check this PR, @kevinthesun @FrozenGene

[GitHub] [incubator-tvm] inadob commented on issue #4518: [Bugfix][Frontend][TF] Fix incorrect calculations in tf SLICE

inadob commented on issue #4518: [Bugfix][Frontend][TF] Fix incorrect calculations in tf SLICE URL: https://github.com/apache/incubator-tvm/pull/4518#issuecomment-565634636 @kevinthesun @FrozenGene can you please review this patch

[GitHub] [incubator-tvm] vinx13 commented on a change in pull request #4476: Implement 1d deconvolution

vinx13 commented on a change in pull request #4476: Implement 1d deconvolution URL: https://github.com/apache/incubator-tvm/pull/4476#discussion_r357821727 ## File path: python/tvm/relay/op/nn/nn.py ## @@ -1,3 +1,4 @@ + Review comment: remove this

[GitHub] [incubator-tvm] vinx13 commented on a change in pull request #4476: Implement 1d deconvolution

vinx13 commented on a change in pull request #4476: Implement 1d deconvolution URL: https://github.com/apache/incubator-tvm/pull/4476#discussion_r357821616 ## File path: python/tvm/relay/op/nn/_nn.py ## @@ -348,6 +348,38 @@ def legalize_conv2d_transpose(attrs, inputs,

[GitHub] [incubator-tvm] vinx13 commented on a change in pull request #4476: Implement 1d deconvolution

vinx13 commented on a change in pull request #4476: Implement 1d deconvolution URL: https://github.com/apache/incubator-tvm/pull/4476#discussion_r357822590 ## File path: topi/tests/python/test_topi_conv1d_transpose_ncw.py ## @@ -0,0 +1,84 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] vinx13 commented on a change in pull request #4476: Implement 1d deconvolution

vinx13 commented on a change in pull request #4476: Implement 1d deconvolution URL: https://github.com/apache/incubator-tvm/pull/4476#discussion_r357823345 ## File path: topi/python/topi/nn/util.py ## @@ -172,3 +172,36 @@ def get_pad_tuple3d(padding, kernel): pad_left

[incubator-tvm] branch master updated (6e085b4 -> f10944c)

This is an automated email from the ASF dual-hosted git repository. wuwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 6e085b4 Fix TF resize for dynamic size models (#4510) add f10944c Fix bias_add gradient (#4516) No new

[GitHub] [incubator-tvm] vinx13 merged pull request #4516: Fix bias_add gradient

vinx13 merged pull request #4516: Fix bias_add gradient URL: https://github.com/apache/incubator-tvm/pull/4516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#discussion_r357430232 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -0,0 +1,608 @@ +# Licensed to

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#discussion_r357432794 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -0,0 +1,974 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#discussion_r357431913 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -0,0 +1,974 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#discussion_r357781978 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -0,0 +1,974 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#discussion_r357785269 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -0,0 +1,974 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#discussion_r357430755 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -0,0 +1,608 @@ +# Licensed to

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

jwfromm commented on a change in pull request #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#discussion_r357781410 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -0,0 +1,974 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] comaniac commented on issue #4482: [Relay] External codegen

comaniac commented on issue #4482: [Relay] External codegen URL: https://github.com/apache/incubator-tvm/pull/4482#issuecomment-565574443 Thanks @tqchen, we've addressed your comments. Please take another look when you get a chance.

[GitHub] [incubator-tvm] zhiics merged pull request #4510: Fix TF resize for dynamic size models

zhiics merged pull request #4510: Fix TF resize for dynamic size models URL: https://github.com/apache/incubator-tvm/pull/4510 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-tvm] branch master updated (7e3bf12 -> 6e085b4)

This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 7e3bf12 [CI] Update docker image ci_lint to obtain Python 3.6 from ppa:deadsnakes/ppa (#4505) (#4506)

[GitHub] [incubator-tvm] SWu opened a new issue #4519: [Relay] VM executor doesn't work with higher order gradient function

SWu opened a new issue #4519: [Relay] VM executor doesn't work with higher order gradient function URL: https://github.com/apache/incubator-tvm/issues/4519 I'm using the 0.6.0 release of TVM, and functions generated by `relay.transform.gradient()` in higher order mode break with the

[GitHub] [incubator-tvm] inadob commented on a change in pull request #4502: [Relay][Frontend][TFlite] Add parses support for SLICE

inadob commented on a change in pull request #4502: [Relay][Frontend][TFlite] Add parses support for SLICE URL: https://github.com/apache/incubator-tvm/pull/4502#discussion_r357715907 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -219,6 +219,26 @@ def

[GitHub] [incubator-tvm] inadob commented on a change in pull request #4502: [Relay][Frontend][TFlite] Add parses support for SLICE

inadob commented on a change in pull request #4502: [Relay][Frontend][TFlite] Add parses support for SLICE URL: https://github.com/apache/incubator-tvm/pull/4502#discussion_r357715194 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -1033,6 +1034,35 @@ def

[GitHub] [incubator-tvm] inadob commented on a change in pull request #4502: [Relay][Frontend][TFlite] Add parses support for SLICE

inadob commented on a change in pull request #4502: [Relay][Frontend][TFlite] Add parses support for SLICE URL: https://github.com/apache/incubator-tvm/pull/4502#discussion_r357715194 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -1033,6 +1034,35 @@ def

[GitHub] [incubator-tvm] inadob opened a new pull request #4518: [Bugfix][Frontend][TF] Fix incorrect calculations in tf SLICE

inadob opened a new pull request #4518: [Bugfix][Frontend][TF] Fix incorrect calculations in tf SLICE URL: https://github.com/apache/incubator-tvm/pull/4518 * fix formula for calculating end indices when size[i] == -1 * add a test case for size[i] == -1 * discard expanding dimension

[GitHub] [incubator-tvm] inadob opened a new pull request #4517: [Bugfix][Frontend][TFlite] Fix wrong function call in TANH tests

inadob opened a new pull request #4517: [Bugfix][Frontend][TFlite] Fix wrong function call in TANH tests URL: https://github.com/apache/incubator-tvm/pull/4517 * Replace sigmoid() with tanh() in TFlite parser tests for TANH

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4502: [Relay][Frontend][TFlite] Add parses support for SLICE

FrozenGene commented on a change in pull request #4502: [Relay][Frontend][TFlite] Add parses support for SLICE URL: https://github.com/apache/incubator-tvm/pull/4502#discussion_r357708592 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -219,6 +219,26 @@

[GitHub] [incubator-tvm] SWu commented on issue #4516: Fix bias_add gradient

SWu commented on issue #4516: Fix bias_add gradient URL: https://github.com/apache/incubator-tvm/pull/4516#issuecomment-565483704 @MarisaKirisame @vinx13 @junrushao1994 please review This is an automated message from the

[GitHub] [incubator-tvm] Aeroxander commented on issue #4262: [RELAY][Bug] 'name_hint' AttributeError issue when covert tensorflow to TVM

Aeroxander commented on issue #4262: [RELAY][Bug] 'name_hint' AttributeError issue when covert tensorflow to TVM URL: https://github.com/apache/incubator-tvm/issues/4262#issuecomment-565469422 @Msabih That'd be great, thanks!

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4511: [CONV] Asymmetric padding

FrozenGene commented on a change in pull request #4511: [CONV] Asymmetric padding URL: https://github.com/apache/incubator-tvm/pull/4511#discussion_r357575493 ## File path: topi/tests/python/test_topi_conv2d_nchw.py ## @@ -176,6 +184,20 @@ def test_conv2d_nchw():