[GitHub] [tvm] comaniac commented on pull request #7145: [AutoScheduler] Improve SearchTask and ComputeDAG serialization

2020-12-22 Thread GitBox
comaniac commented on pull request #7145: URL: https://github.com/apache/tvm/pull/7145#issuecomment-749989310 Per offline discussion, now we only support (de)serialization of ComputeDAG constructed by compute, because this limitation can largely simplify the design. @merrymercy @jcf9

[GitHub] [tvm] masahi opened a new pull request #7157: [TOPI] GPU sort IR refactor to enable sort by keys

2020-12-22 Thread GitBox
masahi opened a new pull request #7157: URL: https://github.com/apache/tvm/pull/7157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] jcf94 commented on pull request #7156: [AutoScheduler] Update layout rewrite option setting for measuring

2020-12-22 Thread GitBox
jcf94 commented on pull request #7156: URL: https://github.com/apache/tvm/pull/7156#issuecomment-749974856 Will update the log version after #7144 since this PR has modified the log structure of SearchTask. This is an automa

[GitHub] [tvm] jcf94 opened a new pull request #7156: [AutoScheduler] Update layout rewrite option setting for measuring

2020-12-22 Thread GitBox
jcf94 opened a new pull request #7156: URL: https://github.com/apache/tvm/pull/7156 AutoScheduler uses a cost model to guide the search search. We now have NO_REWRITE, INSERT_TRANSFORM_STAGE, REWRITE_FOR_PRE_TRANSFORMED three options when applying schedule from AutoScheduler. In m

[GitHub] [tvm] comaniac commented on pull request #7143: [AutoScheduler] Python based measure callbacks

2020-12-22 Thread GitBox
comaniac commented on pull request #7143: URL: https://github.com/apache/tvm/pull/7143#issuecomment-749962826 Per offline discussion, we cast the abstract SearchPolicy to the actual instance so that we can pass it to the packed function. @merrymercy @jcf94 PTAL. ---

[GitHub] [tvm] comaniac merged pull request #7151: Add a FunctionPattern, remove unused attributes in CallPattern

2020-12-22 Thread GitBox
comaniac merged pull request #7151: URL: https://github.com/apache/tvm/pull/7151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[tvm] branch main updated: Add a FunctionPattern, remove unused attributes in CallPattern (#7151)

2020-12-22 Thread comaniac
This is an automated email from the ASF dual-hosted git repository. comaniac pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 4a7503d Add a FunctionPattern, remove unused attribu

[GitHub] [tvm] comaniac commented on pull request #7151: Add a FunctionPattern, remove unused attributes in CallPattern

2020-12-22 Thread GitBox
comaniac commented on pull request #7151: URL: https://github.com/apache/tvm/pull/7151#issuecomment-749952354 Thanks @mbrookhart @jwfromm This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [tvm] jwfromm commented on a change in pull request #7146: [CUDA]batch_matmul tensorcore schedule

2020-12-22 Thread GitBox
jwfromm commented on a change in pull request #7146: URL: https://github.com/apache/tvm/pull/7146#discussion_r547662242 ## File path: tests/python/topi/python/test_topi_batch_matmul_tensorcore.py ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [tvm] jwfromm commented on pull request #7146: [CUDA]batch_matmul tensorcore schedule

2020-12-22 Thread GitBox
jwfromm commented on pull request #7146: URL: https://github.com/apache/tvm/pull/7146#issuecomment-749941299 @Meteorix out of curiosity can you share some of your benchmarking results? I'd love to know how much faster this performs than cublas.

[GitHub] [tvm] jwfromm commented on a change in pull request #7147: [CUDA][PASS]Legalize tensorcore

2020-12-22 Thread GitBox
jwfromm commented on a change in pull request #7147: URL: https://github.com/apache/tvm/pull/7147#discussion_r547655745 ## File path: python/tvm/topi/cuda/conv2d_alter_op.py ## @@ -345,4 +347,49 @@ def _conv2d_legalize(attrs, inputs, arg_types): else:

[GitHub] [tvm] junrushao1994 commented on a change in pull request #7153: [RUNTIME] Add libbacktrace for backtraces with line numbers

2020-12-22 Thread GitBox
junrushao1994 commented on a change in pull request #7153: URL: https://github.com/apache/tvm/pull/7153#discussion_r547579013 ## File path: include/tvm/target/tag.h ## @@ -139,7 +139,7 @@ inline TargetTagRegEntry& TargetTagRegEntry::set_name() { } #define TVM_TARGET_TAG_REG

[GitHub] [tvm] masahi commented on a change in pull request #7154: [Torch] Restore class-aware NMS for detection models by graph rewrite

2020-12-22 Thread GitBox
masahi commented on a change in pull request #7154: URL: https://github.com/apache/tvm/pull/7154#discussion_r547615181 ## File path: python/tvm/relay/frontend/pytorch_utils.py ## @@ -25,3 +35,98 @@ def is_version_greater_than(ver): return "".join(re.findall(r"(\d+\.)(\d+\.

[GitHub] [tvm] masahi commented on a change in pull request #7154: [Torch] Restore class-aware NMS for detection models by graph rewrite

2020-12-22 Thread GitBox
masahi commented on a change in pull request #7154: URL: https://github.com/apache/tvm/pull/7154#discussion_r547566314 ## File path: tests/python/frontend/pytorch/test_object_detection.py ## @@ -102,38 +105,55 @@ def test_detection_models(): scripted_model = generate_jit_m

[GitHub] [tvm] roger-zhao opened a new issue #7155: Potential bug for SearchSpace length

2020-12-22 Thread GitBox
roger-zhao opened a new issue #7155: URL: https://github.com/apache/tvm/issues/7155 https://github.com/apache/tvm/blob/08a69d4f92742c8c526d6a7c2a5805d00f5dc725/python/tvm/autotvm/task/space.py#L839 here, when _length is None, then initiate it to current search space length, it's alm

[GitHub] [tvm] codeislife99 commented on a change in pull request #7126: Sparse fill empty rows op

2020-12-22 Thread GitBox
codeislife99 commented on a change in pull request #7126: URL: https://github.com/apache/tvm/pull/7126#discussion_r547597810 ## File path: include/tvm/topi/transform.h ## @@ -1386,6 +1386,96 @@ inline Array meshgrid(const Array& inputs, const std::string& in return result;

[GitHub] [tvm] codeislife99 commented on a change in pull request #7126: Sparse fill empty rows op

2020-12-22 Thread GitBox
codeislife99 commented on a change in pull request #7126: URL: https://github.com/apache/tvm/pull/7126#discussion_r547596393 ## File path: include/tvm/topi/transform.h ## @@ -1386,6 +1386,96 @@ inline Array meshgrid(const Array& inputs, const std::string& in return result;

[GitHub] [tvm] codeislife99 commented on a change in pull request #7126: Sparse fill empty rows op

2020-12-22 Thread GitBox
codeislife99 commented on a change in pull request #7126: URL: https://github.com/apache/tvm/pull/7126#discussion_r547596393 ## File path: include/tvm/topi/transform.h ## @@ -1386,6 +1386,96 @@ inline Array meshgrid(const Array& inputs, const std::string& in return result;

[GitHub] [tvm] kevinthesun commented on a change in pull request #7154: [Torch] Restore class-aware NMS for detection models by graph rewrite

2020-12-22 Thread GitBox
kevinthesun commented on a change in pull request #7154: URL: https://github.com/apache/tvm/pull/7154#discussion_r547594012 ## File path: python/tvm/relay/frontend/pytorch_utils.py ## @@ -25,3 +35,98 @@ def is_version_greater_than(ver): return "".join(re.findall(r"(\d+\.)(

[GitHub] [tvm] jcf94 commented on a change in pull request #7145: [AutoScheduler] Improve SearchTask and ComputeDAG serialization

2020-12-22 Thread GitBox
jcf94 commented on a change in pull request #7145: URL: https://github.com/apache/tvm/pull/7145#discussion_r547593358 ## File path: python/tvm/auto_scheduler/search_task.py ## @@ -221,10 +221,6 @@ def __init__( target_host = Target(target_host) self.dag

[GitHub] [tvm] jcf94 commented on a change in pull request #7145: [AutoScheduler] Improve SearchTask and ComputeDAG serialization

2020-12-22 Thread GitBox
jcf94 commented on a change in pull request #7145: URL: https://github.com/apache/tvm/pull/7145#discussion_r547593358 ## File path: python/tvm/auto_scheduler/search_task.py ## @@ -221,10 +221,6 @@ def __init__( target_host = Target(target_host) self.dag

[GitHub] [tvm] masahi commented on pull request #7154: [Torch] Restore class-aware NMS for detection models by graph rewrite

2020-12-22 Thread GitBox
masahi commented on pull request #7154: URL: https://github.com/apache/tvm/pull/7154#issuecomment-749860080 I should mention that this rewrite is not run by default, so there is no perf risk. This is an automated message fro

[GitHub] [tvm] zhiics commented on pull request #7154: [Torch] Restore class-aware NMS for detection models by graph rewrite

2020-12-22 Thread GitBox
zhiics commented on pull request #7154: URL: https://github.com/apache/tvm/pull/7154#issuecomment-749858927 @masahi I think this is an plausible as well particularly it is only in the parser. @kevinthesun please help take a look as well. Thanks.

[GitHub] [tvm] masahi edited a comment on pull request #7154: [Torch] Restore class-aware NMS for detection models by graph rewrite

2020-12-22 Thread GitBox
masahi edited a comment on pull request #7154: URL: https://github.com/apache/tvm/pull/7154#issuecomment-749858279 @zhiics Sure updated the description. Unfortunately I cannot claim that this is perf improvement. The regression is only 200 us on CPU, so it may be just a measurement noise,

[GitHub] [tvm] masahi commented on pull request #7154: [Torch] Restore class-aware NMS for detection models by graph rewrite

2020-12-22 Thread GitBox
masahi commented on pull request #7154: URL: https://github.com/apache/tvm/pull/7154#issuecomment-749858279 @zhiics Sure updated the description. The regression is only 200 us on CPU, so it may be just a measurement noise. I have no idea why I'm not getting good speed up. IOU tests,

[GitHub] [tvm] zhiics commented on pull request #7154: [Torch] Restore class-aware NMS for detection models by graph rewrite

2020-12-22 Thread GitBox
zhiics commented on pull request #7154: URL: https://github.com/apache/tvm/pull/7154#issuecomment-749852977 @masahi Thanks for the perf improvement. Could you provide the CPU numbers as well? This is an automated message fro

[tvm] branch main updated: [Rust] Impl IsObjectRef for Array (#7138)

2020-12-22 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 08a69d4 [Rust] Impl IsObjectRef for Array (#7138) 08a

[GitHub] [tvm] jroesch merged pull request #7138: [Rust] Impl IsObjectRef for Array

2020-12-22 Thread GitBox
jroesch merged pull request #7138: URL: https://github.com/apache/tvm/pull/7138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] jroesch commented on pull request #7138: [Rust] Impl IsObjectRef for Array

2020-12-22 Thread GitBox
jroesch commented on pull request #7138: URL: https://github.com/apache/tvm/pull/7138#issuecomment-749847986 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [tvm] masahi commented on a change in pull request #7154: [Torch] Restore class-aware NMS for detection models by graph rewrite

2020-12-22 Thread GitBox
masahi commented on a change in pull request #7154: URL: https://github.com/apache/tvm/pull/7154#discussion_r547566314 ## File path: tests/python/frontend/pytorch/test_object_detection.py ## @@ -102,38 +105,55 @@ def test_detection_models(): scripted_model = generate_jit_m

[GitHub] [tvm] junrushao1994 edited a comment on pull request #7153: [RUNTIME] Add libbacktrace for backtraces with line numbers

2020-12-22 Thread GitBox
junrushao1994 edited a comment on pull request #7153: URL: https://github.com/apache/tvm/pull/7153#issuecomment-749842135 Thank you Tristan for the hard work! Would love to ask some questions just for clarification on the forum first :-) Would you like to also copy your bullet points

[GitHub] [tvm] junrushao1994 commented on pull request #7153: [RUNTIME] Add libbacktrace for backtraces with line numbers

2020-12-22 Thread GitBox
junrushao1994 commented on pull request #7153: URL: https://github.com/apache/tvm/pull/7153#issuecomment-749842135 Thank you Tristan for the hard work! Would love to ask some questions just for clarification on the forum first :-) --

[GitHub] [tvm] masahi opened a new pull request #7154: [Torch] Restore class-aware NMS for detection models by graph rewrite

2020-12-22 Thread GitBox
masahi opened a new pull request #7154: URL: https://github.com/apache/tvm/pull/7154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] mbrookhart commented on a change in pull request #7126: Sparse fill empty rows op

2020-12-22 Thread GitBox
mbrookhart commented on a change in pull request #7126: URL: https://github.com/apache/tvm/pull/7126#discussion_r547556384 ## File path: include/tvm/topi/transform.h ## @@ -1386,6 +1386,96 @@ inline Array meshgrid(const Array& inputs, const std::string& in return result; }

[GitHub] [tvm] tkonolige opened a new pull request #7153: [RUNTIME] Add libbacktrace for backtraces with line numbers

2020-12-22 Thread GitBox
tkonolige opened a new pull request #7153: URL: https://github.com/apache/tvm/pull/7153 - Added libbacktrace to 3rdparty - Changed build settings to give absolute paths in debug symbols - Move CHECK and LOG to tvm/support/logging.h - Rename tvm::Error to tvm::CompileError - Creat

[GitHub] [tvm] tkonolige opened a new pull request #7152: [RUNTIME] Improve error messages for TypedPackedFunc

2020-12-22 Thread GitBox
tkonolige opened a new pull request #7152: URL: https://github.com/apache/tvm/pull/7152 This PR is an alternate to #7108, that captures the name of a TypedPackedFunc into a lambda instead of adding it as a field to the class. Right now, naming a TypedPackedFunc is optional, but I suggest w

[GitHub] [tvm] comaniac commented on pull request #7142: Asymmetric padding in conv2d workload

2020-12-22 Thread GitBox
comaniac commented on pull request #7142: URL: https://github.com/apache/tvm/pull/7142#issuecomment-749830449 I see what you meant. How about we just simply add a test in `test_topi_conv2d_int8.py` that directly calls `fallback_schedule_cpu_common_int8` that takes a workload generated by

[GitHub] [tvm] Wheest commented on pull request #7142: Asymmetric padding in conv2d workload

2020-12-22 Thread GitBox
Wheest commented on pull request #7142: URL: https://github.com/apache/tvm/pull/7142#issuecomment-749822386 Thanks, I understand better what a good test for this PR would be: one that fails on the current `main` branch but not this PR. I've been working on devising a test like this,

[GitHub] [tvm] tkonolige commented on a change in pull request #7107: [Tutorial] Add output validation to sparse tutorial

2020-12-22 Thread GitBox
tkonolige commented on a change in pull request #7107: URL: https://github.com/apache/tvm/pull/7107#discussion_r547540336 ## File path: tests/scripts/task_ci_python_setup.sh ## @@ -31,3 +31,4 @@ set -o pipefail echo "Addtiional setup in" ${CI_IMAGE_NAME} python3 -m pip inst

[GitHub] [tvm] comaniac commented on pull request #7142: Asymmetric padding in conv2d workload

2020-12-22 Thread GitBox
comaniac commented on pull request #7142: URL: https://github.com/apache/tvm/pull/7142#issuecomment-749775593 As you pointed out, the workload doesn't handle asymmetric padding as the compute implementation, which looks like a bug to me. However, it never triggers CI errors before, meaning

[GitHub] [tvm] comaniac commented on pull request #7126: Sparse fill empty rows op

2020-12-22 Thread GitBox
comaniac commented on pull request #7126: URL: https://github.com/apache/tvm/pull/7126#issuecomment-749772392 > @comaniac Every time I select request changes on GitHub, it switches it "suggested changes". Maybe because I am not a committer? Yes that's the case, but we'll do our best

[GitHub] [tvm] Wheest commented on pull request #7142: Asymmetric padding in conv2d workload

2020-12-22 Thread GitBox
Wheest commented on pull request #7142: URL: https://github.com/apache/tvm/pull/7142#issuecomment-749763887 Happy to add a test case if necessary, though I'm still to get familiar with the testing infrastructure for TVM. Existing specific TOPI conv2d implementations are tested with a

[GitHub] [tvm] mbrookhart opened a new pull request #7151: Add a FunctionPattern, remove unused attributes in CallPattern

2020-12-22 Thread GitBox
mbrookhart opened a new pull request #7151: URL: https://github.com/apache/tvm/pull/7151 Thanks! cc @comaniac This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [tvm] tkonolige commented on a change in pull request #7149: Sparse segment sum op

2020-12-22 Thread GitBox
tkonolige commented on a change in pull request #7149: URL: https://github.com/apache/tvm/pull/7149#discussion_r547482617 ## File path: src/relay/op/tensor/transform.cc ## @@ -1553,6 +1553,59 @@ RELAY_REGISTER_OP("meshgrid") .set_attr("FTVMCompute", MeshgridCompute) .

[GitHub] [tvm] tkonolige commented on a change in pull request #7126: Sparse fill empty rows op

2020-12-22 Thread GitBox
tkonolige commented on a change in pull request #7126: URL: https://github.com/apache/tvm/pull/7126#discussion_r547480430 ## File path: python/tvm/relay/op/transform.py ## @@ -1320,3 +1320,84 @@ def adv_index(inputs): Output tensor. """ return _make.adv_index

[GitHub] [tvm] tkonolige commented on pull request #7126: Sparse fill empty rows op

2020-12-22 Thread GitBox
tkonolige commented on pull request #7126: URL: https://github.com/apache/tvm/pull/7126#issuecomment-749747412 @comaniac Every time I select request changes on GitHub, it switches it "suggested changes". Maybe because I am not a committer? -

[GitHub] [tvm] tkonolige commented on a change in pull request #7126: Sparse fill empty rows op

2020-12-22 Thread GitBox
tkonolige commented on a change in pull request #7126: URL: https://github.com/apache/tvm/pull/7126#discussion_r547476827 ## File path: python/tvm/relay/op/transform.py ## @@ -1320,3 +1320,83 @@ def adv_index(inputs): Output tensor. """ return _make.adv_index

[GitHub] [tvm] jwfromm commented on pull request #7086: [Relay][Op] Remove reverse attribute from reshape and reverse_reshape operators.

2020-12-22 Thread GitBox
jwfromm commented on pull request #7086: URL: https://github.com/apache/tvm/pull/7086#issuecomment-749726587 I think @tqchen and @icemelon9 need to take another look to confirm that these changes look good before we can merge. I believe this solution addresses their concerns while removing

[GitHub] [tvm] comaniac commented on pull request #7149: Sparse segment sum op

2020-12-22 Thread GitBox
comaniac commented on pull request #7149: URL: https://github.com/apache/tvm/pull/7149#issuecomment-749725438 The Relay part LGTM. However, since I'm not familiar with the implementation of those operators, I would ask @tkonolige and @mbrookhart to review this PR.

[GitHub] [tvm] comaniac commented on pull request #7126: Sparse fill empty rows op

2020-12-22 Thread GitBox
comaniac commented on pull request #7126: URL: https://github.com/apache/tvm/pull/7126#issuecomment-749724064 @tkonolige @mbrookhart PTAL and approve or request changes explicitly. Thanks. This is an automated message from t

[GitHub] [tvm] comaniac commented on a change in pull request #7145: [AutoScheduler][Bugfix] Hardware params is not serialized properly

2020-12-22 Thread GitBox
comaniac commented on a change in pull request #7145: URL: https://github.com/apache/tvm/pull/7145#discussion_r547452564 ## File path: python/tvm/auto_scheduler/search_task.py ## @@ -221,10 +221,6 @@ def __init__( target_host = Target(target_host) self.d

[GitHub] [tvm] codeislife99 opened a new pull request #7150: Tf front end for sparse reshape op

2020-12-22 Thread GitBox
codeislife99 opened a new pull request #7150: URL: https://github.com/apache/tvm/pull/7150 This PR builds the TF Frontend for sparse_reshape op( #7125 ) [TF: https://www.tensorflow.org/api_docs/python/tf/sparse/reshape] Thi

[GitHub] [tvm] tkonolige commented on a change in pull request #7148: [Frontend][Tensorflow] Sparse_Dense Op CSR scheduling issue resolved for Cuda & X86

2020-12-22 Thread GitBox
tkonolige commented on a change in pull request #7148: URL: https://github.com/apache/tvm/pull/7148#discussion_r547395050 ## File path: python/tvm/topi/cuda/sparse.py ## @@ -311,6 +339,8 @@ def sparse_dense_padded(data, weight_data, weight_indices, weight_indptr): output

[GitHub] [tvm] tkonolige commented on a change in pull request #7125: Sparse reshape op

2020-12-22 Thread GitBox
tkonolige commented on a change in pull request #7125: URL: https://github.com/apache/tvm/pull/7125#discussion_r547393612 ## File path: python/tvm/relay/op/transform.py ## @@ -1320,3 +1320,52 @@ def adv_index(inputs): Output tensor. """ return _make.adv_index

[GitHub] [tvm] comaniac commented on a change in pull request #7144: [AutoScheduler] Support string processing to records

2020-12-22 Thread GitBox
comaniac commented on a change in pull request #7144: URL: https://github.com/apache/tvm/pull/7144#discussion_r547386833 ## File path: python/tvm/auto_scheduler/measure_record.py ## @@ -98,6 +98,46 @@ def __iter__(self): yield ret[0], ret[1] # (input, result)

[GitHub] [tvm] ANSHUMAN87 commented on a change in pull request #7107: [Tutorial] Add output validation to sparse tutorial

2020-12-22 Thread GitBox
ANSHUMAN87 commented on a change in pull request #7107: URL: https://github.com/apache/tvm/pull/7107#discussion_r547302078 ## File path: tests/scripts/task_ci_python_setup.sh ## @@ -31,3 +31,4 @@ set -o pipefail echo "Addtiional setup in" ${CI_IMAGE_NAME} python3 -m pip ins

[tvm] branch main updated (66744d9 -> bc43ed4)

2020-12-22 Thread mbaret
This is an automated email from the ASF dual-hosted git repository. mbaret pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 66744d9 [TFLite] pack operation extedned with const args (#6984) add bc43ed4 [BYOC] [ACL] include_non_call_ops = Fa

[GitHub] [tvm] mbaret merged pull request #7121: [BYOC] [ACL] include_non_call_ops = False

2020-12-22 Thread GitBox
mbaret merged pull request #7121: URL: https://github.com/apache/tvm/pull/7121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [tvm] mbaret commented on pull request #7121: [BYOC] [ACL] include_non_call_ops = False

2020-12-22 Thread GitBox
mbaret commented on pull request #7121: URL: https://github.com/apache/tvm/pull/7121#issuecomment-749529776 Thanks @d-smirnov This is an automated message from the Apache Git Service. To respond to the message, please log on

[tvm] branch main updated (968b6f6 -> 66744d9)

2020-12-22 Thread sijusamuel
This is an automated email from the ASF dual-hosted git repository. sijusamuel pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 968b6f6 Add `is_floating_point()` test and better type support in `verify_model_vm()` (#7134) add 66744d9 [TFL

[GitHub] [tvm] siju-samuel merged pull request #6984: [TFLite] pack operation extedned with const args

2020-12-22 Thread GitBox
siju-samuel merged pull request #6984: URL: https://github.com/apache/tvm/pull/6984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] codeislife99 commented on pull request #7149: Sparse segment sum op

2020-12-22 Thread GitBox
codeislife99 commented on pull request #7149: URL: https://github.com/apache/tvm/pull/7149#issuecomment-749495823 cc: @trevor-m @zhiics @comaniac @anijain2305 PTAL ! This is an automated message from the Apache Git Service.

[GitHub] [tvm] codeislife99 opened a new pull request #7149: Sparse segment sum op

2020-12-22 Thread GitBox
codeislife99 opened a new pull request #7149: URL: https://github.com/apache/tvm/pull/7149 This PR is for adding support for sparse segment sum OP (https://www.tensorflow.org/api_docs/python/tf/sparse/segment_sum?hl=bn) as a part of a larger effort to add sparse operator support. (#7125, #

[GitHub] [tvm] codeislife99 commented on a change in pull request #7126: Sparse fill empty rows op

2020-12-22 Thread GitBox
codeislife99 commented on a change in pull request #7126: URL: https://github.com/apache/tvm/pull/7126#discussion_r547197106 ## File path: src/relay/op/tensor/transform.cc ## @@ -1553,6 +1553,63 @@ RELAY_REGISTER_OP("meshgrid") .set_attr("FTVMCompute", MeshgridCompute)

[GitHub] [tvm] codeislife99 commented on a change in pull request #7126: Sparse fill empty rows op

2020-12-22 Thread GitBox
codeislife99 commented on a change in pull request #7126: URL: https://github.com/apache/tvm/pull/7126#discussion_r547196976 ## File path: src/relay/op/tensor/transform.cc ## @@ -1553,6 +1553,63 @@ RELAY_REGISTER_OP("meshgrid") .set_attr("FTVMCompute", MeshgridCompute)

[GitHub] [tvm] masahi commented on pull request #7134: Add `is_floating_point()` test and better type support in `verify_model_vm()`

2020-12-22 Thread GitBox
masahi commented on pull request #7134: URL: https://github.com/apache/tvm/pull/7134#issuecomment-749440133 Thanks @TylerADavis This is an automated message from the Apache Git Service. To respond to the message, please log

[tvm] branch main updated: Add `is_floating_point()` test and better type support in `verify_model_vm()` (#7134)

2020-12-22 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 968b6f6 Add `is_floating_point()` test and better type

[GitHub] [tvm] masahi merged pull request #7134: Add `is_floating_point()` test and better type support in `verify_model_vm()`

2020-12-22 Thread GitBox
masahi merged pull request #7134: URL: https://github.com/apache/tvm/pull/7134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [tvm] junrushao1994 closed issue #6943: [MaskRCNN][AnnotateTarget]: Fails while reconciling shapes of concatenate inputs

2020-12-22 Thread GitBox
junrushao1994 closed issue #6943: URL: https://github.com/apache/tvm/issues/6943 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] junrushao1994 commented on issue #6943: [MaskRCNN][AnnotateTarget]: Fails while reconciling shapes of concatenate inputs

2020-12-22 Thread GitBox
junrushao1994 commented on issue #6943: URL: https://github.com/apache/tvm/issues/6943#issuecomment-749415022 Thanks for reporting. We use the discussion forum (https://discuss.tvm.apache.org/) for general usage issues. Please open a thread in the forum. Thanks! -

[GitHub] [tvm] junrushao1994 closed issue #6931: Problems when import BERT model from tensorflow Relay

2020-12-22 Thread GitBox
junrushao1994 closed issue #6931: URL: https://github.com/apache/tvm/issues/6931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] junrushao1994 commented on issue #6931: Problems when import BERT model from tensorflow Relay

2020-12-22 Thread GitBox
junrushao1994 commented on issue #6931: URL: https://github.com/apache/tvm/issues/6931#issuecomment-749414663 Thanks for reporting. We use the discussion forum (https://discuss.tvm.apache.org/) for general usage issues. Please open a thread in the forum. Thanks! -

[GitHub] [tvm] junrushao1994 commented on issue #7057: [Bug] RecursionError: maximum recursion depth exceeded while calling a Python object

2020-12-22 Thread GitBox
junrushao1994 commented on issue #7057: URL: https://github.com/apache/tvm/issues/7057#issuecomment-749413853 AFAIK it happens when an error is thrown in the constructor. Thanks for reporting. We use the discussion forum (https://discuss.tvm.apache.org/) for general usage issues. Please op

[GitHub] [tvm] junrushao1994 closed issue #7057: [Bug] RecursionError: maximum recursion depth exceeded while calling a Python object

2020-12-22 Thread GitBox
junrushao1994 closed issue #7057: URL: https://github.com/apache/tvm/issues/7057 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] junrushao1994 commented on issue #7077: tvm_mobilefacenet running error

2020-12-22 Thread GitBox
junrushao1994 commented on issue #7077: URL: https://github.com/apache/tvm/issues/7077#issuecomment-749413539 Thanks for reporting. We use the discussion forum (https://discuss.tvm.apache.org/) for general usage issues. Please open a thread in the forum. Thanks! -

[GitHub] [tvm] junrushao1994 closed issue #7077: tvm_mobilefacenet running error

2020-12-22 Thread GitBox
junrushao1994 closed issue #7077: URL: https://github.com/apache/tvm/issues/7077 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the