[GitHub] [tvm] ashutosh-arm commented on a diff in pull request #13807: [microTVM] Fix host-driven AOT memory workspaces

2023-01-20 Thread GitBox
ashutosh-arm commented on code in PR #13807: URL: https://github.com/apache/tvm/pull/13807#discussion_r1082873726 ## src/runtime/crt/aot_executor/aot_executor.c: ## @@ -203,17 +203,6 @@ int TVMAotExecutor_Init(TVMAotExecutor* executor, TVMModuleHandle module_handle,

[GitHub] [tvm] NicolaLancellotti commented on a diff in pull request #13643: [CMSIS-NN] Add a runtime error message

2023-01-20 Thread GitBox
NicolaLancellotti commented on code in PR #13643: URL: https://github.com/apache/tvm/pull/13643#discussion_r1082846680 ## apps/microtvm/cmsisnn/Makefile: ## @@ -69,6 +69,18 @@ $(BUILD_DIR)/crt_backend_api.o: $(STANDALONE_CRT_PATH)/src/runtime/crt/common/cr

[GitHub] [tvm] tvm-bot commented on pull request #13816: Extend the USE_LIBBACKTRACE option

2023-01-20 Thread GitBox
tvm-bot commented on PR #13816: URL: https://github.com/apache/tvm/pull/13816#issuecomment-1398661120 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] yelite opened a new pull request, #13816: Extend the USE_LIBBACKTRACE option

2023-01-20 Thread GitBox
yelite opened a new pull request, #13816: URL: https://github.com/apache/tvm/pull/13816 This PR extends the value accepted by USE_LIBBACKTRACE cmake variable. It adds ability to search pre-compile libbacktrace from system path or user-provided path. The behavior of this variable after this

[GitHub] [tvm] junrushao merged pull request #13814: [COMMUNITY] alanmacd -> Reviewer

2023-01-20 Thread GitBox
junrushao merged PR #13814: URL: https://github.com/apache/tvm/pull/13814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] Lunderberg commented on a diff in pull request #13569: [tir][testing] Enable intra-IRModule primfunc call

2023-01-20 Thread GitBox
Lunderberg commented on code in PR #13569: URL: https://github.com/apache/tvm/pull/13569#discussion_r1082618777 ## include/tvm/ir/function.h: ## @@ -63,6 +63,13 @@ enum class CallingConv : int { * - Implementation: defined by device runtime(e.g. runtime/cuda) */

[GitHub] [tvm] tvm-bot commented on pull request #13815: [CMSIS-NN] Reduction in code size of AOT test runner binary

2023-01-20 Thread GitBox
tvm-bot commented on PR #13815: URL: https://github.com/apache/tvm/pull/13815#issuecomment-1398494767 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] tvm-bot commented on pull request #13814: [COMMUNITY] alanmacd -> Reviewer

2023-01-20 Thread GitBox
tvm-bot commented on PR #13814: URL: https://github.com/apache/tvm/pull/13814#issuecomment-1398468628 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] leandron opened a new pull request, #13814: [COMMUNITY] alanmacd -> Reviewer

2023-01-20 Thread GitBox
leandron opened a new pull request, #13814: URL: https://github.com/apache/tvm/pull/13814 Please welcome @alanmacd as a new Reviewer in TVM. Alan has contributed to microTVM and improving CI on Windows and MacOS. Moreover, Alan has been consistently doing code-reviews in many patches

[GitHub] [tvm] KJlaccHoeUM9l commented on a diff in pull request #13747: [ONNX] QGemm support

2023-01-20 Thread GitBox
KJlaccHoeUM9l commented on code in PR #13747: URL: https://github.com/apache/tvm/pull/13747#discussion_r1082566149 ## python/tvm/relay/frontend/onnx.py: ## @@ -4898,6 +4898,90 @@ def _impl_v10(cls, inputs, attr, params): return out +class QGemm(OnnxOpConverter): +

[GitHub] [tvm] masahi merged pull request #13799: [TESTING] Enable execution of test_packed_8x8x32_resnet50

2023-01-20 Thread GitBox
masahi merged PR #13799: URL: https://github.com/apache/tvm/pull/13799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao merged pull request #13813: [TVMScript] `T.allocate` with `T.decl_buffer` syntax sugar for TVMScript printer

2023-01-20 Thread GitBox
junrushao merged PR #13813: URL: https://github.com/apache/tvm/pull/13813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao commented on a diff in pull request #13813: [TVMScript] `T.allocate` with `T.decl_buffer` syntax sugar for TVMScript printer

2023-01-20 Thread GitBox
junrushao commented on code in PR #13813: URL: https://github.com/apache/tvm/pull/13813#discussion_r1082269934 ## tests/python/unittest/test_tvmscript_printer_tir.py: ## @@ -327,6 +328,53 @@ def test_allocate(): ) +def test_allocate_with_decl_buffer_sugar(): +with

[GitHub] [tvm] fPecc commented on a diff in pull request #13770: [microTVM]Gemmini code generation using microTVM

2023-01-20 Thread GitBox
fPecc commented on code in PR #13770: URL: https://github.com/apache/tvm/pull/13770#discussion_r1082254341 ## python/tvm/contrib/gemmini/tutorials/single_operators/add-tutorial.ipynb: ## @@ -0,0 +1,395 @@ +{ Review Comment: Thanks for the feedback, I am on it -- This is

[GitHub] [tvm] wrongtest-intellif merged pull request #13700: [TIR][Schedule] Improve cache_index to cache common subexpressions

2023-01-20 Thread GitBox
wrongtest-intellif merged PR #13700: URL: https://github.com/apache/tvm/pull/13700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] echuraev commented on a diff in pull request #13791: [TOOL][NATIVE] Android native application for deploy and run

2023-01-19 Thread GitBox
echuraev commented on code in PR #13791: URL: https://github.com/apache/tvm/pull/13791#discussion_r1082147944 ## apps/cpp_rtvm/README.md: ## @@ -0,0 +1,354 @@ + + + + + + + + + + + + + + + + + + +# Native Inference application for CPP Native + +Native inference tool ```rtvm```

[GitHub] [tvm] leandron commented on pull request #13807: [microTVM] Fix host-driven AOT memory workspaces

2023-01-19 Thread GitBox
leandron commented on PR #13807: URL: https://github.com/apache/tvm/pull/13807#issuecomment-1398000903 Cc @ashutosh-arm @d-smirnov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] tvm-bot commented on pull request #13813: [TVMScript] `T.allocate` with `T.decl_buffer` syntax sugar for TVMScript printer

2023-01-19 Thread GitBox
tvm-bot commented on PR #13813: URL: https://github.com/apache/tvm/pull/13813#issuecomment-1397960314 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] cyx-6 opened a new pull request, #13813: [TVMScript] `T.allocate` with `T.decl_buffer` syntax sugar for TVMScript printer

2023-01-19 Thread GitBox
cyx-6 opened a new pull request, #13813: URL: https://github.com/apache/tvm/pull/13813 This PR implements the syntax sugar of `T.allocate` with `T.decl_buffer` for new TVMScript printer. This syntax sugar will skip the `T.allocate`, when its body is a matched `T.decl_buffer`, and the `Var`

[GitHub] [tvm] junrushao commented on pull request #13809: [TIR][FIX] check args size when creating prim_func by runtime::Registry

2023-01-19 Thread GitBox
junrushao commented on PR #13809: URL: https://github.com/apache/tvm/pull/13809#issuecomment-1397916804 That sounds reasonable to me :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] junrushao merged pull request #13801: [TVMScript] `T.match_buffer` syntax sugar in arguments for TVMScript printer

2023-01-19 Thread GitBox
junrushao merged PR #13801: URL: https://github.com/apache/tvm/pull/13801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] tvm-bot commented on pull request #13812: [Draft][microTVM][CRT]Separate CRT template project from standalone CRT build

2023-01-19 Thread GitBox
tvm-bot commented on PR #13812: URL: https://github.com/apache/tvm/pull/13812#issuecomment-1397818635 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] multiverstack-intellif commented on pull request #13700: [TIR][Schedule] Improve cache_index to cache common subexpressions

2023-01-19 Thread GitBox
multiverstack-intellif commented on PR #13700: URL: https://github.com/apache/tvm/pull/13700#issuecomment-1397765552 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] tvm-bot commented on pull request #13811: [microTVM] Allow multiple runners in tuning micro models with meta-schedule

2023-01-19 Thread GitBox
tvm-bot commented on PR #13811: URL: https://github.com/apache/tvm/pull/13811#issuecomment-1397752705 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] mkatanbaf opened a new pull request, #13811: [microTVM] Allow multiple runners in tuning micro models with meta-schedule

2023-01-19 Thread GitBox
mkatanbaf opened a new pull request, #13811: URL: https://github.com/apache/tvm/pull/13811 This PR adds support for running candidate projects on multiple physical boards when using meta-schedule to tune micro models, and helps reducing the tuning time. -- This is an automated message

[GitHub] [tvm] mehrdadh merged pull request #13783: [microTVM] Add tutorial on how to generate MLPerfTiny submissions

2023-01-19 Thread GitBox
mehrdadh merged PR #13783: URL: https://github.com/apache/tvm/pull/13783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] mehrdadh commented on pull request #13806: [Draft]Update zephyr version to 3.2 and Zephyr SDK to 0.15.2

2023-01-19 Thread GitBox
mehrdadh commented on PR #13806: URL: https://github.com/apache/tvm/pull/13806#issuecomment-1397741108 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] adstraw commented on a diff in pull request #13721: [MetaSchedule][Hexagon] Add MultiLevelTilingHexagon to schedule asyn…

2023-01-19 Thread GitBox
adstraw commented on code in PR #13721: URL: https://github.com/apache/tvm/pull/13721#discussion_r1081717491 ## include/tvm/meta_schedule/schedule_rule.h: ## @@ -210,6 +210,31 @@ class ScheduleRule : public runtime::ObjectRef { Optional> vector_load_lens, Optional>

[GitHub] [tvm] masahi commented on issue #13666: [Bug] rocm platform result are not correct

2023-01-19 Thread GitBox
masahi commented on issue #13666: URL: https://github.com/apache/tvm/issues/13666#issuecomment-1397695640 @mvermeulen Thanks I got it working, but the result is the same as my non-docker execution: LLVM and rocm results are different. ``` LLVM output [-0.22859041 -0.25806972

[GitHub] [tvm] slyubomirsky commented on pull request #13769: [testing][py_converter] Enhance py_converter to better support entire modules

2023-01-19 Thread GitBox
slyubomirsky commented on PR #13769: URL: https://github.com/apache/tvm/pull/13769#issuecomment-1397687275 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] mehrdadh merged pull request #13810: [Docker]Add dialout group by default on login

2023-01-19 Thread GitBox
mehrdadh merged PR #13810: URL: https://github.com/apache/tvm/pull/13810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao commented on pull request #13701: [Frontend][PaddlePaddle] Add topk op and Fix bug, when the output is a dimension, it …

2023-01-19 Thread GitBox
junrushao commented on PR #13701: URL: https://github.com/apache/tvm/pull/13701#issuecomment-1397544506 seems like there is some issues in rebasing and now the PR has inflated to 25k lines -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [tvm] mehrdadh commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM

2023-01-19 Thread GitBox
mehrdadh commented on PR #13418: URL: https://github.com/apache/tvm/pull/13418#issuecomment-1397526323 cc @kparzysz-quic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] mehrdadh commented on pull request #13418: [Hexagon][CI] Updated sha for builder LLVM

2023-01-19 Thread GitBox
mehrdadh commented on PR #13418: URL: https://github.com/apache/tvm/pull/13418#issuecomment-1397526004 @joshherr-quic any update on this? Unfortunately This is blocking updating hexagon image. I appreciate if you could provide a follow up on this. thanks! -- This is an automated

[GitHub] [tvm] mehrdadh commented on a diff in pull request #13783: [microTVM] Add tutorial on how to generate MLPerfTiny submissions

2023-01-19 Thread GitBox
mehrdadh commented on code in PR #13783: URL: https://github.com/apache/tvm/pull/13783#discussion_r1081772521 ## gallery/how_to/work_with_microtvm/micro_mlperftiny.py: ## @@ -0,0 +1,285 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] areusch commented on pull request #12525: [TVMC] Allow selecting a subset of tasks to be used in `tvmc tune`

2023-01-19 Thread GitBox
areusch commented on PR #12525: URL: https://github.com/apache/tvm/pull/12525#issuecomment-1397496361 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] driazati commented on issue #13586: [Release] v0.11.0 release schedule

2023-01-19 Thread GitBox
driazati commented on issue #13586: URL: https://github.com/apache/tvm/issues/13586#issuecomment-1397462189 The release branches are protected from force pushes / deletes by GitHub, but cherry-picking shouldn't require rewriting history right? Are you doing something like this?

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #13747: [ONNX] QGemm support

2023-01-19 Thread GitBox
AndrewZhaoLuo commented on PR #13747: URL: https://github.com/apache/tvm/pull/13747#issuecomment-1397391359 Sorry, I will take a look tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #13747: [ONNX] QGemm support

2023-01-19 Thread GitBox
AndrewZhaoLuo commented on PR #13747: URL: https://github.com/apache/tvm/pull/13747#issuecomment-1397391062 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] AndrewZhaoLuo merged pull request #13797: [ONNX] Extend converter for Attention from Microsoft onnxruntime contrib opset

2023-01-19 Thread GitBox
AndrewZhaoLuo merged PR #13797: URL: https://github.com/apache/tvm/pull/13797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] tvm-bot commented on pull request #13810: [Docker]Add dialout group by default on login

2023-01-19 Thread GitBox
tvm-bot commented on PR #13810: URL: https://github.com/apache/tvm/pull/13810#issuecomment-1397293342 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] mehrdadh opened a new pull request, #13810: [Docker]Add dialout group by default on login

2023-01-19 Thread GitBox
mehrdadh opened a new pull request, #13810: URL: https://github.com/apache/tvm/pull/13810 This would help to run commands like nrfjprog inside docker without `sudo` command. cc @driazati -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] abhikran-quic commented on pull request #13799: [TESTING] Enable execution of test_packed_8x8x32_resnet50

2023-01-19 Thread GitBox
abhikran-quic commented on PR #13799: URL: https://github.com/apache/tvm/pull/13799#issuecomment-1397207115 Hi @csullivan @masahi - Could you please help in reviewing this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tvm] mvermeulen commented on issue #13666: [Bug] rocm platform result are not correct

2023-01-19 Thread GitBox
mvermeulen commented on issue #13666: URL: https://github.com/apache/tvm/issues/13666#issuecomment-1397176511 @masahi most likely you are missing arguments when starting up the docker container. Here is how I run it: ``` docker run -it --device=/dev/dri --device=/dev/kfd

[GitHub] [tvm] Lunderberg commented on a diff in pull request #13746: [Arith] Support eq in detect_clip_bound

2023-01-19 Thread GitBox
Lunderberg commented on code in PR #13746: URL: https://github.com/apache/tvm/pull/13746#discussion_r1081430254 ## src/arith/detect_linear_equation.cc: ## @@ -217,6 +221,9 @@ bool DetectClipBound(const PrimExpr& cond, } else { p.min_value = -ret.base; } +if

[GitHub] [tvm] echuraev merged pull request #13779: [Adreno] Update interface of AnnotateMemoryScope pass

2023-01-19 Thread GitBox
echuraev merged PR #13779: URL: https://github.com/apache/tvm/pull/13779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] KJlaccHoeUM9l commented on pull request #13797: [ONNX] Extend converter for Attention from Microsoft onnxruntime contrib opset

2023-01-19 Thread GitBox
KJlaccHoeUM9l commented on PR #13797: URL: https://github.com/apache/tvm/pull/13797#issuecomment-1397020862 Hello @AndrewZhaoLuo! Looks like we can merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tvm] leandron commented on issue #13586: [Release] v0.11.0 release schedule

2023-01-19 Thread GitBox
leandron commented on issue #13586: URL: https://github.com/apache/tvm/issues/13586#issuecomment-1396925985 I'm picking this up and facing an issue with _protected branches_ when trying to cherry-pick #13624 into `v0.11.0` - any idea how to solve that? ``` $ git push -f upstream

[GitHub] [tvm] Hzfengsy commented on pull request #13809: [TIR][FIX] check args size when creating prim_func by runtime::Registry

2023-01-19 Thread GitBox
Hzfengsy commented on PR #13809: URL: https://github.com/apache/tvm/pull/13809#issuecomment-1396847246 After looking at the codebase again, it would be great if we can ensure this PackedFunc has two args. Another approach is adding `ICHECK_EQ(args.size(), 2)`. Keeping

[GitHub] [tvm] woobinw commented on pull request #13701: [Frontend][PaddlePaddle] Add topk op and Fix bug, when the output is a dimension, it …

2023-01-19 Thread GitBox
woobinw commented on PR #13701: URL: https://github.com/apache/tvm/pull/13701#issuecomment-1396770869 > Could you rebase to latest HEAD? I’m sure it’s going to pass this time Yes, It has been rebased to latest HEAD. -- This is an automated message from the Apache Git Service. To

[GitHub] [tvm] arjunsuresh commented on a diff in pull request #13783: [microTVM] Add tutorial on how to generate MLPerfTiny submissions

2023-01-19 Thread GitBox
arjunsuresh commented on code in PR #13783: URL: https://github.com/apache/tvm/pull/13783#discussion_r1081016183 ## gallery/how_to/work_with_microtvm/micro_mlperftiny.py: ## @@ -0,0 +1,285 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] Ever-Kid commented on pull request #13809: [TIR][FIX] check args size when creating prim_func by runtime::Registry

2023-01-19 Thread GitBox
Ever-Kid commented on PR #13809: URL: https://github.com/apache/tvm/pull/13809#issuecomment-1396688652 > Could you please add a regression test? Sure, I guess I should test `te.CreatePrimFunc` by `runtime::Registry`. Any hints where to put this testcase, like

[GitHub] [tvm] Hzfengsy commented on pull request #13809: [TIR][FIX] check args size when creating prim_func by runtime::Registry

2023-01-19 Thread GitBox
Hzfengsy commented on PR #13809: URL: https://github.com/apache/tvm/pull/13809#issuecomment-1396615409 Could you please add a regression test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] Ever-Kid commented on pull request #13809: [TIR][FIX] check args size when creating prim_func by runtime::Registry

2023-01-19 Thread GitBox
Ever-Kid commented on PR #13809: URL: https://github.com/apache/tvm/pull/13809#issuecomment-1396614747 cc. @vinx13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] tvm-bot commented on pull request #13809: [TIR][FIX] check args size when creating prim_func by runtime::Registry

2023-01-19 Thread GitBox
tvm-bot commented on PR #13809: URL: https://github.com/apache/tvm/pull/13809#issuecomment-1396613269 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] Ever-Kid opened a new pull request, #13809: [TIR][FIX] check args size when creating prim_func by runtime::Registry

2023-01-19 Thread GitBox
Ever-Kid opened a new pull request, #13809: URL: https://github.com/apache/tvm/pull/13809 default value for `index_dtype_override` is null, so it would be better if the registry block of `te.CreatePrimFunc` could check args size. -- This is an automated message from the Apache Git

[GitHub] [tvm] KJlaccHoeUM9l commented on pull request #13797: [ONNX] Extend converter for Attention from Microsoft onnxruntime contrib opset

2023-01-19 Thread GitBox
KJlaccHoeUM9l commented on PR #13797: URL: https://github.com/apache/tvm/pull/13797#issuecomment-1396610608 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] masahi commented on pull request #13779: [Adreno] Update interface of AnnotateMemoryScope pass

2023-01-18 Thread GitBox
masahi commented on PR #13779: URL: https://github.com/apache/tvm/pull/13779#issuecomment-1396457326 @echuraev Can you try rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] masahi merged pull request #13808: [TIR]Fix the crash of the pass RemoveNoOp

2023-01-18 Thread GitBox
masahi merged PR #13808: URL: https://github.com/apache/tvm/pull/13808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao commented on pull request #13701: [Frontend][PaddlePaddle] Add topk op and Fix bug, when the output is a dimension, it …

2023-01-18 Thread GitBox
junrushao commented on PR #13701: URL: https://github.com/apache/tvm/pull/13701#issuecomment-1396424581 Could you rebase to latest HEAD? I’m sure it’s going to pass this time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tvm] masahi commented on issue #13666: [Bug] rocm platform result are not correct

2023-01-18 Thread GitBox
masahi commented on issue #13666: URL: https://github.com/apache/tvm/issues/13666#issuecomment-1396406356 @mvermeulen I tried to use your image but got the following error ``` # rocminfo ROCk module is loaded Unable to open /dev/kfd read-write: No such file or directory Failed

[GitHub] [tvm] tvm-bot commented on pull request #13808: Fix the crash of the pass RemoveNoOp

2023-01-18 Thread GitBox
tvm-bot commented on PR #13808: URL: https://github.com/apache/tvm/pull/13808#issuecomment-1396344107 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] lightzhan-intellif opened a new pull request, #13808: Fix the crash of the pass RemoveNoOp

2023-01-18 Thread GitBox
lightzhan-intellif opened a new pull request, #13808: URL: https://github.com/apache/tvm/pull/13808 This PR tries to fix the crash of the pass `RemoveNoOp` when the condition of IfThenElseNode can be statically determined. For example: ```python @L.prim_func def remove_no_op():

[GitHub] [tvm] wangzy0327 commented on issue #13666: [Bug] rocm platform result are not correct

2023-01-18 Thread GitBox
wangzy0327 commented on issue #13666: URL: https://github.com/apache/tvm/issues/13666#issuecomment-1396327672 ok, I will try to run it later. Can you tell me about the docker tvm on code commit? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] Ever-Kid commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

2023-01-18 Thread GitBox
Ever-Kid commented on PR #13744: URL: https://github.com/apache/tvm/pull/13744#issuecomment-1396321397 Thanks you guys’ kindly help~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] masahi commented on issue #13805: [CI Problem] TOPI tests on ci_cpu fail

2023-01-18 Thread GitBox
masahi commented on issue #13805: URL: https://github.com/apache/tvm/issues/13805#issuecomment-1396231649 https://github.com/apache/tvm/pull/13804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] masahi closed issue #13805: [CI Problem] TOPI tests on ci_cpu fail

2023-01-18 Thread GitBox
masahi closed issue #13805: [CI Problem] TOPI tests on ci_cpu fail URL: https://github.com/apache/tvm/issues/13805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] tvm-bot commented on pull request #13807: Fix host-driven AOT memory workspaces

2023-01-18 Thread GitBox
tvm-bot commented on PR #13807: URL: https://github.com/apache/tvm/pull/13807#issuecomment-1396204943 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] alanmacd opened a new pull request, #13807: Fix host-driven AOT memory workspaces

2023-01-18 Thread GitBox
alanmacd opened a new pull request, #13807: URL: https://github.com/apache/tvm/pull/13807 When using host-driven AOT with memory pools enabled, the workspace and constant memory were not properly supported. In order for them to work properly, the _run function (typically

[GitHub] [tvm] ashutosh-arm merged pull request #13804: [TOPI] Making test_strided_set require a GPU for testing

2023-01-18 Thread GitBox
ashutosh-arm merged PR #13804: URL: https://github.com/apache/tvm/pull/13804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao commented on a diff in pull request #13801: [TVMScript] `T.match_buffer` syntax sugar in arguments for TVMScript printer

2023-01-18 Thread GitBox
junrushao commented on code in PR #13801: URL: https://github.com/apache/tvm/pull/13801#discussion_r1080543155 ## src/script/printer/tir/function.cc: ## @@ -34,16 +36,54 @@ String FindFunctionName(const IRDocsifier& d, const tir::PrimFunc& f) { return "main"; } +bool

[GitHub] [tvm] masahi commented on pull request #13779: [Adreno] Update interface of AnnotateMemoryScope pass

2023-01-18 Thread GitBox
masahi commented on PR #13779: URL: https://github.com/apache/tvm/pull/13779#issuecomment-1396067393 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] junrushao commented on a diff in pull request #13801: [TVMScript] `T.match_buffer` syntax sugar in arguments for TVMScript printer

2023-01-18 Thread GitBox
junrushao commented on code in PR #13801: URL: https://github.com/apache/tvm/pull/13801#discussion_r1074042870 ## src/script/printer/tir/buffer.cc: ## @@ -126,6 +126,14 @@ ExprDoc BufferDecl(const tir::Buffer& buffer, const String& method, const Array<

[GitHub] [tvm] cyx-6 commented on a diff in pull request #13801: [TVMScript] `T.match_buffer` syntax sugar in arguments for TVMScript printer

2023-01-18 Thread GitBox
cyx-6 commented on code in PR #13801: URL: https://github.com/apache/tvm/pull/13801#discussion_r1074020799 ## src/script/printer/tir/buffer.cc: ## @@ -126,6 +126,14 @@ ExprDoc BufferDecl(const tir::Buffer& buffer, const String& method, const Array<

[GitHub] [tvm] junrushao commented on a diff in pull request #13801: [TVMScript] `T.match_buffer` syntax sugar in arguments for TVMScript printer

2023-01-18 Thread GitBox
junrushao commented on code in PR #13801: URL: https://github.com/apache/tvm/pull/13801#discussion_r1074019767 ## src/script/printer/tir/buffer.cc: ## @@ -126,6 +126,14 @@ ExprDoc BufferDecl(const tir::Buffer& buffer, const String& method, const Array<

[GitHub] [tvm] junrushao commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

2023-01-18 Thread GitBox
junrushao commented on PR #13744: URL: https://github.com/apache/tvm/pull/13744#issuecomment-1387699870 It's merged! Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] junrushao merged pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

2023-01-18 Thread GitBox
junrushao merged PR #13744: URL: https://github.com/apache/tvm/pull/13744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] mvermeulen commented on issue #13666: [Bug] rocm platform result are not correct

2023-01-18 Thread GitBox
mvermeulen commented on issue #13666: URL: https://github.com/apache/tvm/issues/13666#issuecomment-1387643084 Tried this with the following docker image I built from latest ROCm: ``` docker pull mevermeulen/rocm-tvm:5.4.2 ``` I didn't have OpenCL built in that so I compared

[GitHub] [tvm] tvm-bot commented on pull request #13806: [Draft]Update zephyr version to 3.2 and Zephyr SDK to 0.15.2

2023-01-18 Thread GitBox
tvm-bot commented on PR #13806: URL: https://github.com/apache/tvm/pull/13806#issuecomment-1387596454 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] mehrdadh opened a new pull request, #13806: [Draft]Update zephyr version to 3.2 and Zephyr SDK to 0.15.2

2023-01-18 Thread GitBox
mehrdadh opened a new pull request, #13806: URL: https://github.com/apache/tvm/pull/13806 This PR updates Zephyr version and Zephyr SDK version to the latest release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] slyubomirsky commented on pull request #13769: [testing][py_converter] Enhance py_converter to better support entire modules

2023-01-18 Thread GitBox
slyubomirsky commented on PR #13769: URL: https://github.com/apache/tvm/pull/13769#issuecomment-1387449378 I think there's been another spurious failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tvm] neildhickey opened a new issue, #13805: [CI Problem] TOPI tests on ci_cpu fail

2023-01-18 Thread GitBox
neildhickey opened a new issue, #13805: URL: https://github.com/apache/tvm/issues/13805 ### PR Failing https://github.com/apache/tvm/pull/13724 caused an issue when running TOPI tests on ci_cpu. ``` tvm.topi.transform:test_strided_set segfaullts when run on ci_cpu.

[GitHub] [tvm] neildhickey opened a new pull request, #13804: [TOPI] Making test_strided_set require a GPU for testing

2023-01-18 Thread GitBox
neildhickey opened a new pull request, #13804: URL: https://github.com/apache/tvm/pull/13804 https://github.com/apache/tvm/pull/13724 caused an issue in ci_cpu testing when running the TOPI tests. This pull request sets the failing test to require a gpu to run -- This is an automated

[GitHub] [tvm] tvm-bot commented on pull request #13804: [TOPI] Making test_strided_set require a GPU for testing

2023-01-18 Thread GitBox
tvm-bot commented on PR #13804: URL: https://github.com/apache/tvm/pull/13804#issuecomment-1387366481 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] tqchen commented on a diff in pull request #13791: [TOOL][NATIVE] Android native application for deploy and run

2023-01-18 Thread GitBox
tqchen commented on code in PR #13791: URL: https://github.com/apache/tvm/pull/13791#discussion_r1073772649 ## .gitmodules: ## @@ -19,3 +19,6 @@ [submodule "3rdparty/OpenCL-Headers"] path = 3rdparty/OpenCL-Headers url =

[GitHub] [tvm] ekalda merged pull request #13772: [microNPU] Add hardware constraints for binary elementwise

2023-01-18 Thread GitBox
ekalda merged PR #13772: URL: https://github.com/apache/tvm/pull/13772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] ekalda commented on a diff in pull request #13772: [microNPU] Add hardware constraints for binary elementwise

2023-01-18 Thread GitBox
ekalda commented on code in PR #13772: URL: https://github.com/apache/tvm/pull/13772#discussion_r1073653209 ## tests/python/contrib/test_ethosu/test_legalize.py: ## @@ -951,20 +962,30 @@ def verify(ext_func): assert op.checked_type.dtype == dtype assert

[GitHub] [tvm] echuraev commented on pull request #13779: [Adreno] Update interface of AnnotateMemoryScope pass

2023-01-18 Thread GitBox
echuraev commented on PR #13779: URL: https://github.com/apache/tvm/pull/13779#issuecomment-1387212152 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] lhutton1 commented on pull request #13529: [microNPU] Upgrade to 22.08 version of Arm(R) Ethos(TM)-U NPU drivers

2023-01-18 Thread GitBox
lhutton1 commented on PR #13529: URL: https://github.com/apache/tvm/pull/13529#issuecomment-1387208560 Thanks @Alexey-Yazev @leandron! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] lhutton1 merged pull request #13529: [microNPU] Upgrade to 22.08 version of Arm(R) Ethos(TM)-U NPU drivers

2023-01-18 Thread GitBox
lhutton1 merged PR #13529: URL: https://github.com/apache/tvm/pull/13529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao closed pull request #12665: [TVMScript] TIR Printer: AttrStmt and Allocate

2023-01-18 Thread GitBox
junrushao closed pull request #12665: [TVMScript] TIR Printer: AttrStmt and Allocate URL: https://github.com/apache/tvm/pull/12665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] junrushao closed pull request #12635: [TVMScript] TIR Printer: LetStmt and others

2023-01-18 Thread GitBox
junrushao closed pull request #12635: [TVMScript] TIR Printer: LetStmt and others URL: https://github.com/apache/tvm/pull/12635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] yelite opened a new pull request, #12603: [TVMScript] TIR Printer: Assert and Concise Scoping

2023-01-18 Thread GitBox
yelite opened a new pull request, #12603: URL: https://github.com/apache/tvm/pull/12603 This PR: - Adds TIR assert printing - Adds helpers for stmt body printing and concise scoping This PR is in draft state because it's branched off from a pending PR #12582 Tracking

[GitHub] [tvm] junrushao closed pull request #12603: [TVMScript] TIR Printer: Assert and Concise Scoping

2023-01-18 Thread GitBox
junrushao closed pull request #12603: [TVMScript] TIR Printer: Assert and Concise Scoping URL: https://github.com/apache/tvm/pull/12603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] junrushao closed pull request #12582: [TVMScript] TIR Printer: Simple Statements

2023-01-18 Thread GitBox
junrushao closed pull request #12582: [TVMScript] TIR Printer: Simple Statements URL: https://github.com/apache/tvm/pull/12582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] junrushao closed pull request #12576: [TVMScript] TIR Printer: Op

2023-01-18 Thread GitBox
junrushao closed pull request #12576: [TVMScript] TIR Printer: Op URL: https://github.com/apache/tvm/pull/12576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tvm] junrushao closed pull request #12492: [TVMScript] TIR Printer: Var and Type

2023-01-18 Thread GitBox
junrushao closed pull request #12492: [TVMScript] TIR Printer: Var and Type URL: https://github.com/apache/tvm/pull/12492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] junrushao closed pull request #12552: [TVMScript] TIR Printer: Expression

2023-01-18 Thread GitBox
junrushao closed pull request #12552: [TVMScript] TIR Printer: Expression URL: https://github.com/apache/tvm/pull/12552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] junrushao closed pull request #12506: [TVMScript] TIR Printer: Buffer

2023-01-18 Thread GitBox
junrushao closed pull request #12506: [TVMScript] TIR Printer: Buffer URL: https://github.com/apache/tvm/pull/12506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] junrushao commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

2023-01-18 Thread GitBox
junrushao commented on PR #13744: URL: https://github.com/apache/tvm/pull/13744#issuecomment-1387133374 I rebased this branch to latest HEAD so that the CI could run properly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

  1   2   3   4   5   6   7   8   9   10   >