[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-27 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399484380 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,152 @@ #include #include #include "../.

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-27 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399484380 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,152 @@ #include #include #include "../.

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-27 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399454748 ## File path: src/relay/qnn/op/op_common.h ## @@ -74,16 +212,17 @@ static inline bool QnnBroadcastRel(co

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-27 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399454748 ## File path: src/relay/qnn/op/op_common.h ## @@ -74,16 +212,17 @@ static inline bool QnnBroadcastRel(co

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-27 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399447558 ## File path: src/relay/qnn/op/subtract.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-27 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399446872 ## File path: src/relay/qnn/op/subtract.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-27 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399431735 ## File path: src/relay/qnn/op/subtract.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-27 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399430571 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,152 @@ #include #include #include "../.

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-27 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399428671 ## File path: src/relay/qnn/op/mul.cc ## @@ -42,22 +42,13 @@ namespace qnn { Expr QnnMulCanonicalize(co

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-27 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399428714 ## File path: src/relay/qnn/op/mul.cc ## @@ -42,22 +42,13 @@ namespace qnn { Expr QnnMulCanonicalize(co

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-26 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r398849702 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,151 @@ #include #include #include "../.

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-26 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r398849174 ## File path: src/relay/qnn/op/add.cc ## @@ -97,39 +66,29 @@ Expr QnnAddCanonicalize(const Attrs& attrs,

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-26 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r398849174 ## File path: src/relay/qnn/op/add.cc ## @@ -97,39 +66,29 @@ Expr QnnAddCanonicalize(const Attrs& attrs,

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-26 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r398847759 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,155 @@ #include #include #include "../.

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-26 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r398847589 ## File path: src/relay/qnn/op/mul.cc ## @@ -71,31 +59,35 @@ Expr QnnMulCanonicalize(const Attrs& attrs,

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-26 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r398788973 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,155 @@ #include #include #include "../.

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-26 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r398780962 ## File path: python/tvm/relay/qnn/op/qnn.py ## @@ -436,3 +436,54 @@ def mul(lhs, rhs, lhs_scale, lhs_ze

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-26 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r398784846 ## File path: src/relay/qnn/op/mul.cc ## @@ -42,22 +42,10 @@ namespace qnn { Expr QnnMulCanonicalize(co

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-26 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r398786009 ## File path: src/relay/qnn/op/mul.cc ## @@ -71,31 +59,35 @@ Expr QnnMulCanonicalize(const Attrs& attrs,

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

2020-03-26 Thread GitBox
anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r398787686 ## File path: src/relay/qnn/op/add.cc ## @@ -97,39 +66,29 @@ Expr QnnAddCanonicalize(const Attrs& attrs,